GNU bug report logs - #66567
[PATCH] use-package: Add ignored-files support to :vc keyword

Previous Next

Full log

Message #52 received at 66567 <at> debbugs.gnu.org (full text, mbox):

From: "John Wiegley" <johnw <at> gnu.org>
To: "Tony Zorman" <tonyzorman <at> mailbox.org>, "Eli Zaretskii" <eliz <at> gnu.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 66567 <at> debbugs.gnu.org
Subject: Re: bug#66567: [PATCH] use-package: Add ignored-files support to :vc
 keyword
Date: Tue, 14 May 2024 18:19:10 -0700

That all makes sense to me then. Looks good to go.

John

On Tue, May 14, 2024, at 9:08 AM, Tony Zorman wrote:
> Hi,
>
> On Fri, May 03 2024 23:16, John Wiegley wrote:
>>>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>>>> I'd really like to see this merged; if it helps move things along a
>>>> bit quicker, I can also make the necessary changes to package-vc.el.
>>
>>> John, could you please review the patches and comment?
>>
>> Hi Eli, I’ve read through the proposed patches. What’s being proposed looks
>> good to me, except that I find it odd that it mentions two new keywords in the
>> ChangeLog that have nothing to do with the :vc keyword. Why conflate that into
>> this changeset? I don’t see those keywords mentioned anywhere else but the
>> valid keywords list, so is this for economy rather than creating two patches?
>
> I did attach two patches to the original message, separating these out.
> Though you are right that perhaps I should have also created two
> separate bugs for this. It's just something I noticed along the way and
> figured I'd forget again if I didn't fix it immediately.
>
> These keywords (I hope I haven't misunderstood you and you are referring
> to :make and :shell-command) do, however, have something to do with :vc
> in the sense that they are sub-keywords of it, much like :ignored-files
> is.
>
>   Tony
>
> -- 
> Tony Zorman | https://tony-zorman.com/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.