GNU bug report logs - #66567
[PATCH] use-package: Add ignored-files support to :vc keyword

Previous Next

Full log

Message #46 received at 66567 <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <johnw <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tony Zorman <tonyzorman <at> mailbox.org>, philipk <at> posteo.net,
 66567 <at> debbugs.gnu.org
Subject: Re: bug#66567: [PATCH] use-package: Add ignored-files support to
 :vc keyword
Date: Fri, 03 May 2024 23:16:34 -0700

>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:

>> I'd really like to see this merged; if it helps move things along a
>> bit quicker, I can also make the necessary changes to package-vc.el.

> John, could you please review the patches and comment?

Hi Eli, I’ve read through the proposed patches. What’s being proposed looks
good to me, except that I find it odd that it mentions two new keywords in the
ChangeLog that have nothing to do with the :vc keyword. Why conflate that into
this changeset? I don’t see those keywords mentioned anywhere else but the
valid keywords list, so is this for economy rather than creating two patches?

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.