From unknown Sat Sep 06 02:33:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66562 <66562@debbugs.gnu.org> To: bug#66562 <66562@debbugs.gnu.org> Subject: Status: [PATCH] gnu: emacs-haskell-snippets: Fix haskell-snippets-dir value. Reply-To: bug#66562 <66562@debbugs.gnu.org> Date: Sat, 06 Sep 2025 09:33:06 +0000 retitle 66562 [PATCH] gnu: emacs-haskell-snippets: Fix haskell-snippets-dir= value. reassign 66562 guix-patches submitter 66562 Rostislav Svoboda severity 66562 normal tag 66562 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 15 11:18:32 2023 Received: (at submit) by debbugs.gnu.org; 15 Oct 2023 15:18:32 +0000 Received: from localhost ([127.0.0.1]:53949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs2sx-0001PO-Oa for submit@debbugs.gnu.org; Sun, 15 Oct 2023 11:18:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs2sv-0001P7-Ut for submit@debbugs.gnu.org; Sun, 15 Oct 2023 11:18:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qs2sS-0007is-Dx for guix-patches@gnu.org; Sun, 15 Oct 2023 11:18:00 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qs2sQ-0002wH-V1 for guix-patches@gnu.org; Sun, 15 Oct 2023 11:18:00 -0400 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-533d31a8523so6185698a12.1 for ; Sun, 15 Oct 2023 08:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697383076; x=1697987876; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fiDkbrEIhfH1I6nY0ItXnXQZRaIbcXvucK80xeU1i48=; b=RXbgyiEBvZJaU+TFgzwufYyzfD1siBcaOwsJFvxUq0zJ3uPnCFzyfNxXEC5PwvPO5T vDO9k0R1LZ38Cn05e/4D4pWB3r37ydWYONyNZZRM9zUomi7E/qcTfT0K5e+KYdBMlcDD icYZvoYFZNRqnrAsOEyRtwjvrKMz1f5Dvmzn57RIGtpo8dAFiRjFDiD+9wMX/Jlo3RF3 iCv1kpsGNZSl9PVDuGFjCRJz6Skr2HK6Lre9qZgs6Ef0IaeTa1TaZxEk/oDKjZR1vu2u 0f9W4YvEY3mGrQXbFQ9OOfc944e0bu8YwIOqTQ/oUqxGUNnDZ8lELaQoMmb/MW54mQNO 1jSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697383076; x=1697987876; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fiDkbrEIhfH1I6nY0ItXnXQZRaIbcXvucK80xeU1i48=; b=wNjKgsNQ5RrCbZoxXyuCbSV4JqNKoeJ9XEFIuMadJN7eEL+C9zBnE/3vj7IF/Om+Wi ZEJZydVgJW1cx6RUQXLFywfdPe2XZbpjd9s3vucTWrN0L0f1KY8FfX0QPe5FQpcCgLaF qtUj7pXvXCxMrN3FfFCBK9+o4F7OPYbzxO7t2EMGOW8gTSWDyN0Nw4Cz3+KYeNBc7NI5 xZC5ndQQr1xrXFxkWWzZgBTDTUAZ6tJ4Z4Ed/he6Qct/JO9GsB5JL6Gygrtb+LaQ8Hue e4T1y1ZAKWrIGYnrF2cgpl05ep7zThOuq7fD1suFzo4uhaoE2pe/sZZM/mj50HbhdSwv /MCQ== X-Gm-Message-State: AOJu0Ywypjp2bIWvA/dKamrACtb2TxM+GwWNSL8qbKini+YjERTyV02p 8KB7VuVe7T8eiJaNUWbmv7gWhp6euZucGx/9 X-Google-Smtp-Source: AGHT+IFPj/TohHZL5yCestt2vYta1gsiq9TRZHM4OIMFILzVrYe7DnOD8Dwx0ypBo5dOH4TyWH5lCw== X-Received: by 2002:aa7:c584:0:b0:531:2b7c:513a with SMTP id g4-20020aa7c584000000b005312b7c513amr25662252edq.17.1697383075318; Sun, 15 Oct 2023 08:17:55 -0700 (PDT) Received: from ecke.fritz.box (dynamic-2a01-0c23-7943-9000-d954-c96a-7afd-b479.c23.pool.telefonica.de. [2a01:c23:7943:9000:d954:c96a:7afd:b479]) by smtp.googlemail.com with ESMTPSA id f26-20020a50ee9a000000b0052e1783ab25sm14116971edr.70.2023.10.15.08.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 08:17:54 -0700 (PDT) From: Rostislav Svoboda X-Google-Original-From: Rostislav Svoboda To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-haskell-snippets: Fix haskell-snippets-dir value. Date: Sun, 15 Oct 2023 17:17:30 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Andrew Tropin , Katherine Cox-Buday , Liliana Marie Prikler Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=rostislav.svoboda@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, TVD_SPACE_RATIO=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Rostislav Svoboda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): Fix haskell-snippets-dir value The value of haskell-snippets-dir was: /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/haskell-snippets-*/ It needs to be: /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/ The error was (abbreviated): No such file or directory, /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/haskell-snippets-*/snippets --- gnu/packages/emacs-xyz.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index bb8c25f9b5..8bb0d6d43a 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -35545,6 +35545,12 @@ (define-public emacs-haskell-snippets (list #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'patch-haskell-snippets-dir + (lambda* (#:key outputs #:allow-other-keys) + (emacs-substitute-sexps "haskell-snippets.el" + ("setq haskell-snippets-dir" + '(file-name-parent-directory + (file-name-directory load-file-name)))))) (add-after 'install 'install-snippets (lambda _ (let ((snippets base-commit: a0d2ecde943bd1854ddbb7c0cad35a1fc64dc5ab -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 15 12:02:20 2023 Received: (at 66562) by debbugs.gnu.org; 15 Oct 2023 16:02:20 +0000 Received: from localhost ([127.0.0.1]:53982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs3ZL-00037K-S8 for submit@debbugs.gnu.org; Sun, 15 Oct 2023 12:02:20 -0400 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:50658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs3ZG-000371-MM for 66562@debbugs.gnu.org; Sun, 15 Oct 2023 12:02:18 -0400 Received: by mail-ed1-x543.google.com with SMTP id 4fb4d7f45d1cf-53d9b94731aso6602857a12.1 for <66562@debbugs.gnu.org>; Sun, 15 Oct 2023 09:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697385704; x=1697990504; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=mj8K54b5S7OdVgLgfIYtZUrPmCZB6tF9EF3APnyAiJw=; b=ays294WAAJ94dtnB1sryVKFefLfxdyQP+7iU0edgV1FLZSF5/GdluZ+nndFO7Me5U0 mfpPZRTR9Wx00iEOYBtPKTCze69Lv0hnlPF2T/6XH5CUPwCndXViILWYYURiVsiJTq28 LWUJ8964EPk3cIEMUJEWmEF8iEmx+0w9CWRkpOgLPYP4pFYLDcI2KrPYUsFHW/0reART 9+vzDneHFkzVQba2FQek9FUaTViRouic52LNdDUhErmPyeMKeSbtop7Rfz7wwXi5mmWV xQL2nHpoS2FMSxBwF9uK/CA2UIWWj84r2KiWY478yBBO2IKJp2RAIOy7UZXPGchkQ8he jYhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697385704; x=1697990504; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mj8K54b5S7OdVgLgfIYtZUrPmCZB6tF9EF3APnyAiJw=; b=WhU3Mo+P77NM5IClh/vgr5ev/u5iBh6jU6UwnT2rKYxsdwcjED2wvHRn1bRCi5ajyy XSEn2uDIaPPTHsc0zl5Tedr9N0/FHX9qGWibEsuIXn4aH7+gHlj3fsHP7DDppV2C1oSq VwYkW6aN424ATJFjamqVok4xbrM2TVWUX3e72ACsl7UBoz+LfpzIN9iJx2uzGh7jk91P ai3YfhLI+cJso0tufaHW7Tei7RN3ATkFKOUOGsR04G3X4br+yEQiAeb76qPzpcOgl3g1 Bl1mjYd3B79PJAAplbBnv9Trd5rzu3c0kEP+i4yQDBOw9xmgT9V4WH7/sFCxidCm2i4Z 3orQ== X-Gm-Message-State: AOJu0YxGladNBd5YgLT9Ur3sfyar4l66CMcT+FLy0MWKHeGx3n3LC5rz nEn4Hw4LO/RSVFCtmiE0trY= X-Google-Smtp-Source: AGHT+IFE2sCUYfFSKgqkCtVIg2I9wqNZWUF4p8Wd9cjlYhY92x2gHmTC0CID/iJLUuSoJViPD+3y+g== X-Received: by 2002:a50:9f4b:0:b0:53d:a1c0:410e with SMTP id b69-20020a509f4b000000b0053da1c0410emr14314782edf.7.1697385704092; Sun, 15 Oct 2023 09:01:44 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id eh4-20020a0564020f8400b0053dab756073sm6766020edb.84.2023.10.15.09.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 09:01:42 -0700 (PDT) Message-ID: Subject: Re: [bug#66562] [PATCH] gnu: emacs-haskell-snippets: Fix haskell-snippets-dir value. From: Liliana Marie Prikler To: Rostislav Svoboda , 66562@debbugs.gnu.org Date: Sun, 15 Oct 2023 18:01:41 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: Katherine Cox-Buday , Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 15.10.2023 um 17:17 +0200 schrieb Rostislav Svoboda: > * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): Fix > haskell-snippets-dir value >=20 > The value of haskell-snippets-dir was: > =C2=A0 /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site- > lisp/haskell-snippets-*/ > It needs to be: > =C2=A0 /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/ >=20 > The error was (abbreviated): > No such file or directory, /gnu/store/*-emacs-haskell-snippets- > */share/emacs/site-lisp/haskell-snippets-*/snippets Explanations go above the ChangeLog. > --- > =C2=A0gnu/packages/emacs-xyz.scm | 6 ++++++ > =C2=A01 file changed, 6 insertions(+) >=20 > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index bb8c25f9b5..8bb0d6d43a 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -35545,6 +35545,12 @@ (define-public emacs-haskell-snippets > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:phases > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #~(modify-phases %standa= rd-phases > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (add-= after 'unpack 'patch-haskell-snippets-dir > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (lambda* (#:key outputs #:allow-other-keys) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (emacs-substitute-sexps "haskell-snippets.el" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("setq haskell-snippets-dir" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '(file-name-parent-directory > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name-directory load-= file-name)))))) There is actually a substitute-sexps specialization for variables.=20 Perhaps use that instead? Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 15 13:22:40 2023 Received: (at 66562) by debbugs.gnu.org; 15 Oct 2023 17:22:40 +0000 Received: from localhost ([127.0.0.1]:54053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs4p6-0006FW-8A for submit@debbugs.gnu.org; Sun, 15 Oct 2023 13:22:40 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:46086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs4p2-0006FG-HE for 66562@debbugs.gnu.org; Sun, 15 Oct 2023 13:22:39 -0400 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-507a98517f3so726972e87.0 for <66562@debbugs.gnu.org>; Sun, 15 Oct 2023 10:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697390526; x=1697995326; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4iUk/o+jSaGscThebuq6g+xhch8nW8eGOlQglL2gacA=; b=QwdvbW3praHTHxAELy6DIJQvzPywHv9V/wO3zUfE4mJCRSSr1/ODdQJxj18235vPrJ jdnSAJ7/YKaywR21zDrahFhsnzV+FHLUCZQto3fNEqgIztWvrIkkzYmIDAojOGz1uKlG 8HrxK1rkOhTwU8Eap/NDynbKSpN1ek2pHy31IHRJHCKMFhHzX8YeGx+eI5bQwGggeOcT iDgX8vXorvmHoSl+cFAWTyRF9PfoZKyP8jCPH0FWWae3kWa+jsttcbAneB2bs5gTUcGC 0j8srHZKWgSIlrLopcVpj0qqufM/coGi2gQ3Yxih/Ty0mAfSLs322AkRt1HBXxfVvpay hSuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697390526; x=1697995326; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4iUk/o+jSaGscThebuq6g+xhch8nW8eGOlQglL2gacA=; b=YqLYTxQbH7zrlEuDflD9OY0rWe4kDHSZVAGWs1WpW3O4q/otcLw0mgbxuAh5Q6Mv56 afjJHLwm8ZB6OPiFIm2GThiX16IhABB181wpOLMaOjl1x8FZhR+/wuNr4nKCtihPOvS+ ZmnhssZTWb2HZuR7KnxPGQNciMSKh9u3cN6Ui8oArcVg6kC2m/DXs4tir7g5yx5+4v+H D6b+QzSX7G/5k4u6O8FqyRVljd09N3Lyy5HZ6RO87M9/zhopL+kKT1J+jl8QlTQLic3i 7H0+kckwJ9CtgtWUfyQJM86CaGd0efZP8+sVB5ex1jeWW0XyeXm9GHqgDSGes7YfbvwD l6wg== X-Gm-Message-State: AOJu0Yzt7w0oRRFXbmYam2FVOK1bzR7/1BIF2wWzcuzVMjU5kvVWMFqS +Ld5UoCgUAdvxTxwugqzlpfrKsvCAp4QTagsiUU= X-Google-Smtp-Source: AGHT+IE1AlPhsTbFdsB0NRTKmY5+4GXx6KKKDT0hTz8OmQpJ8uQR0AURX0Ivq5zVyniGsbdFF2JEHsLsnTCwHMQ9tMM= X-Received: by 2002:a05:6512:ad1:b0:500:90d1:90a6 with SMTP id n17-20020a0565120ad100b0050090d190a6mr33361259lfu.63.1697390525757; Sun, 15 Oct 2023 10:22:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rostislav Svoboda Date: Sun, 15 Oct 2023 19:21:29 +0200 Message-ID: Subject: Re: [bug#66562] [PATCH] gnu: emacs-haskell-snippets: Fix haskell-snippets-dir value. To: Liliana Marie Prikler Content-Type: multipart/mixed; boundary="0000000000005559570607c487dd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: 66562@debbugs.gnu.org, Katherine Cox-Buday , Andrew Tropin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005559570607c487dd Content-Type: text/plain; charset="UTF-8" > > + (emacs-substitute-sexps "haskell-snippets.el" > > + ("setq haskell-snippets-dir" > > + '(file-name-parent-directory > > + (file-name-directory load-file-name)))))) > There is actually a substitute-sexps specialization for variables. > Perhaps use that instead? The emacs-substitute-variables doesn't work since haskell-snippets-dir is defined using setq, not defcustom, hence I used the emacs-substitute-sexps. > > * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): Fix > > haskell-snippets-dir value > > > > The value of haskell-snippets-dir was: > > /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site- > > lisp/haskell-snippets-*/ > > It needs to be: > > /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/ > > > > The error was (abbreviated): > > No such file or directory, /gnu/store/*-emacs-haskell-snippets- > > */share/emacs/site-lisp/haskell-snippets-*/snippets > > Explanations go above the ChangeLog. Ok, I changed that. See the patch in the attachment. Cheers --0000000000005559570607c487dd Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-emacs-haskell-snippets-Fix-haskell-snippets-dir-.patch" Content-Disposition: attachment; filename="0001-gnu-emacs-haskell-snippets-Fix-haskell-snippets-dir-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lnrqggye0 RnJvbSBhZDFkYjE3NDIyMTYwNTRhYmQ0MDY5ODhiNmNlOWIzYmI1Y2IxOGVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8YWQxZGIxNzQyMjE2MDU0YWJkNDA2OTg4YjZjZTli M2JiNWNiMThlYy4xNjk3MzkwMzUxLmdpdC5Sb3N0aXNsYXYuU3ZvYm9kYUBnbWFpbC5jb20+CkZy b206IFJvc3Rpc2xhdiBTdm9ib2RhIDxSb3N0aXNsYXYuU3ZvYm9kYUBnbWFpbC5jb20+CkRhdGU6 IFN1biwgMTUgT2N0IDIwMjMgMTc6MDQ6NTcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IGVt YWNzLWhhc2tlbGwtc25pcHBldHM6IEZpeCBoYXNrZWxsLXNuaXBwZXRzLWRpciB2YWx1ZS4KClRo ZSBlcnJvciBpcyAoYWJicmV2aWF0ZWQpOgpObyBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5LCAvZ251 L3N0b3JlLyotZW1hY3MtaGFza2VsbC1zbmlwcGV0cy0qL3NoYXJlL2VtYWNzL3NpdGUtbGlzcC9o YXNrZWxsLXNuaXBwZXRzLSovc25pcHBldHMKClRoZSB2YWx1ZSBvZiBoYXNrZWxsLXNuaXBwZXRz LWRpciB3YXM6CiAgL2dudS9zdG9yZS8qLWVtYWNzLWhhc2tlbGwtc25pcHBldHMtKi9zaGFyZS9l bWFjcy9zaXRlLWxpc3AvaGFza2VsbC1zbmlwcGV0cy0qLwpJdCBuZWVkcyB0byBiZToKICAvZ251 L3N0b3JlLyotZW1hY3MtaGFza2VsbC1zbmlwcGV0cy0qL3NoYXJlL2VtYWNzL3NpdGUtbGlzcC8K CiogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gKGVtYWNzLWhhc2tlbGwtc25pcHBldHMpOiBG aXgKaGFza2VsbC1zbmlwcGV0cy1kaXIgdmFsdWUKLS0tCiBnbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbSB8IDYgKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gYi9nbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbQppbmRleCBiYjhjMjVmOWI1Li44YmIwZDZkNDNhIDEwMDY0NAotLS0gYS9nbnUvcGFja2Fn ZXMvZW1hY3MteHl6LnNjbQorKysgYi9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbQpAQCAtMzU1 NDUsNiArMzU1NDUsMTIgQEAgKGRlZmluZS1wdWJsaWMgZW1hY3MtaGFza2VsbC1zbmlwcGV0cwog ICAgICAgIChsaXN0CiAgICAgICAgICM6cGhhc2VzCiAgICAgICAgICN+KG1vZGlmeS1waGFzZXMg JXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICdwYXRjaC1o YXNrZWxsLXNuaXBwZXRzLWRpcgorICAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0 cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAgICAgICAgKGVtYWNzLXN1YnN0aXR1dGUt c2V4cHMgImhhc2tlbGwtc25pcHBldHMuZWwiCisgICAgICAgICAgICAgICAgICAoInNldHEgaGFz a2VsbC1zbmlwcGV0cy1kaXIiCisgICAgICAgICAgICAgICAgICAgJyhmaWxlLW5hbWUtcGFyZW50 LWRpcmVjdG9yeQorICAgICAgICAgICAgICAgICAgICAgKGZpbGUtbmFtZS1kaXJlY3RvcnkgbG9h ZC1maWxlLW5hbWUpKSkpKSkKICAgICAgICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ2luc3Rh bGwtc25pcHBldHMKICAgICAgICAgICAgICAgKGxhbWJkYSBfCiAgICAgICAgICAgICAgICAgKGxl dCAoKHNuaXBwZXRzCgpiYXNlLWNvbW1pdDogYTBkMmVjZGU5NDNiZDE4NTRkZGJiN2MwY2FkMzVh MWZjNjRkYzVhYgotLSAKMi40MS4wCgo= --0000000000005559570607c487dd-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 15 14:36:52 2023 Received: (at 66562) by debbugs.gnu.org; 15 Oct 2023 18:36:52 +0000 Received: from localhost ([127.0.0.1]:54115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs5yt-0000BD-Nv for submit@debbugs.gnu.org; Sun, 15 Oct 2023 14:36:52 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:56591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs5yr-0000Ay-6q for 66562@debbugs.gnu.org; Sun, 15 Oct 2023 14:36:50 -0400 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-40572aeb6d0so37815035e9.1 for <66562@debbugs.gnu.org>; Sun, 15 Oct 2023 11:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697394979; x=1697999779; darn=debbugs.gnu.org; h=mime-version:cc:to:subject:date:from:message-id:from:to:cc:subject :date:message-id:reply-to; bh=VXIGQbb/j4tXsQ0cd/p/XByxhbf5S6SGKU2Jtx1ybv4=; b=nOpTRXPuFGfyOYjTlv+ODdycMAz1NmzVN0ZHez4fteweV03I515fa3/To9sP0gLoIM CWqI+Irtbe5FCiUJaYlMdc/ANMdW4I5LEr66t5bkkCifwSGE0wAtJEj8C6nOSRgDPGxJ 0HwafEVtbfkUj+ombIM93ixhn8cFw1VsrBv5RYZvvXahXfBUW9n3EzjLFC978PnqMRqV lbGrR94GtjgBJYRGe7Z7Qo42z4hZOx/po2vNeFnZAuVVZoo72nKi0B7EY//att9bluy8 Q3X98iYfG1HIv2fJ7V9pUHNblK1uA7brQV8J9YIa4VAVllmSxPApP7tJRDp1Au/GNrtu qd2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697394979; x=1697999779; h=mime-version:cc:to:subject:date:from:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VXIGQbb/j4tXsQ0cd/p/XByxhbf5S6SGKU2Jtx1ybv4=; b=WTolrXdln9SL1nE9SisB1xfc7X7pfw5oLugwVFrYOu6XENi6SE5nTpGQC2KiX08cic Cn/68IPbh9UiD4g5vDMNMIpqIbCfamebl3Wa+OXOxiF4cu+eJw6fDaEWSdIAZknt0zub h0d7hcyIa7JBzfiZXyuqJ7RYipwT7R6NUrEm63LypHLjxmtn1v4vjtHuj5uHAg9Otzqz aaSGTeMGVRZESqnqbR2Skd+Cuv7PIxhr1izqThli6xO44ZyJWYUi1M2wAMF68qLieUDO liuaouQc5C3yko4nCRpVivPIWZ+IpkD+E8Q4TKQe583cdcxO25LuNTx86gsdihqTZGJl DG9A== X-Gm-Message-State: AOJu0YzaTrXkSWdZPDdM7BdwZU26VN1jQMH7ERMh6jJx/WMBrR0rvbug H6LkCQMd4/Qz/t+mntv8IRvQPeYstLG+gA== X-Google-Smtp-Source: AGHT+IHpodFugOUKdXNVeWERT+2IqSaUKI16Lm0NNDYosP3kw/+rmIiPKHW3edjGwICBnmDvdeemOA== X-Received: by 2002:a7b:ca54:0:b0:405:3885:490a with SMTP id m20-20020a7bca54000000b004053885490amr28065826wml.0.1697394978466; Sun, 15 Oct 2023 11:36:18 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id t7-20020a1c7707000000b0040586360a36sm5109312wmi.17.2023.10.15.11.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 11:36:17 -0700 (PDT) Message-ID: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> From: Liliana Marie Prikler Date: Sun, 15 Oct 2023 20:25:46 +0200 Subject: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. to: 66562@debbugs.gnu.org MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: Rostislav Svoboda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This package instructs Yasnippet to look for snippets relative to its own path. However, it installs the snippets directly to site-lisp, which as of 79cfe30f3eb10bd3dbf7aa0f6e873c945d7d0ea5 is one directory above that. Use the elpa-directory procedure introduced in that commit to rectify this mistake. * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets)[#:phases] : Use elpa-directory. Fixes: 66562 --- Hi Rostislav, Am Sonntag, dem 15.10.2023 um 17:17 +0200 schrieb Rostislav Svoboda: > * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): Fix > haskell-snippets-dir value > > The value of haskell-snippets-dir was: > /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/haskell-snippets-*/ > It needs to be: > /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/ Actually, emacs-haskell-snippets is doing something wrong when installing files directy to site-lisp instead of any other directory. Here's an attempt to fix that. Cheers gnu/packages/emacs-xyz.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index bb8c25f9b5..7f55febfbb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -35546,10 +35546,11 @@ (define-public emacs-haskell-snippets #:phases #~(modify-phases %standard-phases (add-after 'install 'install-snippets - (lambda _ + (lambda* (#:key outputs #:allow-other-keys) (let ((snippets (string-append - #$output "/share/emacs/site-lisp/snippets/haskell-mode"))) + (elpa-directory (assoc-ref outputs "out")) + "/snippets/haskell-mode"))) (mkdir-p snippets) (copy-recursively "snippets/haskell-mode" snippets))))))) (propagated-inputs base-commit: ef026e68fe58ed3be216c76f7c5f008893ed3095 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 16 06:58:45 2023 Received: (at 66562) by debbugs.gnu.org; 16 Oct 2023 10:58:45 +0000 Received: from localhost ([127.0.0.1]:55353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsLJ7-000247-AK for submit@debbugs.gnu.org; Mon, 16 Oct 2023 06:58:45 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:48266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsLJ5-00023n-JI for 66562@debbugs.gnu.org; Mon, 16 Oct 2023 06:58:44 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-507a62d4788so2268437e87.0 for <66562@debbugs.gnu.org>; Mon, 16 Oct 2023 03:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697453893; x=1698058693; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jIBxWVopsb3FgSk8AfnZFWJT1+F5PiM9PXAbe9dl8rM=; b=DHaKExRikurfGNWiHep0rQZKos2dXgA5piXhUI2JSSuoyzFO4QnZhmVcGfdPAwBrdD jpO4noAOU98A7ox2CfY8md3e1AfYsOM8D0wfRZm7qbyvbtFE0F0nt1CvFLKn0l71+Il7 6BW37IXsM8BSzx0HTMiJ5osO6w3kTBkO+VlKEzZ75brjbjHiumH6MXRRL78uqyNFzyYv j76Euj4FHfVcPwqphJ3J3shRUFdfWZkAR9jFNf6LJM+7QFLl/qmZ4HeQVMkSt4MAPDb1 cODSf1BJp2IPwshIQQM06L3IyzJ/RJs2cIF7Fp6ZEeRnW8JBRz8/UZMoi3qAJh8Kza/b rWJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697453893; x=1698058693; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jIBxWVopsb3FgSk8AfnZFWJT1+F5PiM9PXAbe9dl8rM=; b=huyi2fdJGZd81NA3JefE6/NamOrTaMmqeJJgrEseUll+rlimZp3Ce1GjOpUk3LYOuU aL8pLw7uhQunVEwy/rQZbel3vxL0Di80N02OmPG3mJAZbwAjEqFiUdU+b1PgGaUOkqMJ UVSaVVGgwpgu9g+QZmWU5kFPjJgF/uCNLD3hsypVATiU2l8eZ+LG6nzZXckedI9iBX6Y 48cWQq992BBqW/uHHo7V9HluFa/jkd/XhU5OI4YYSiE9wL3LHq8ZDSBspLZ0Y3ZuY9C3 OKGvp9825WhWzW1Q3S5nhWc1e3V7GGYRzUbufkOHbSHSPbAVcJoeH80QSAF1fxjHRea0 piTg== X-Gm-Message-State: AOJu0YzAHzDF1XKVi8d5fvhTn8A6rwfehRPpRTxbnprk9cPk78p/YNqU xaFcRgpB4/hiuFV5iVCJKt1yxN0ILAQHtnNWjWw= X-Google-Smtp-Source: AGHT+IHJwk+9U43ponvgnT3+ACD2tsukmhZIkoqzNa/nZFhGC2/R3uzXkWTKyDK4xppXLMnXDL66Dg36q8oMDmtVRg4= X-Received: by 2002:a05:6512:31d0:b0:4ff:a04c:8a5b with SMTP id j16-20020a05651231d000b004ffa04c8a5bmr34242919lfe.47.1697453892350; Mon, 16 Oct 2023 03:58:12 -0700 (PDT) MIME-Version: 1.0 References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> In-Reply-To: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> From: Rostislav Svoboda Date: Mon, 16 Oct 2023 12:57:35 +0200 Message-ID: Subject: Re: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. To: Liliana Marie Prikler Content-Type: multipart/mixed; boundary="000000000000474dde0607d348a2" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: 66562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000474dde0607d348a2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Liliana, Your patch works (thank you) and I improved it a tiny bit. (See attachment.) BTW shouldn't the revision number in the (git-version "0.1.0" "1" commit) be increased to "2" in your patch and to "3" in mine? Cheers Le dim. 15 oct. 2023 =C3=A0 20:36, Liliana Marie Prikler a =C3=A9crit : > > This package instructs Yasnippet to look for snippets relative to its own > path. However, it installs the snippets directly to site-lisp, which as = of > 79cfe30f3eb10bd3dbf7aa0f6e873c945d7d0ea5 is one directory above that. Us= e the > elpa-directory procedure introduced in that commit to rectify this mistak= e. > > * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets)[#:phases] > : Use elpa-directory. > > Fixes: 66562 > --- > Hi Rostislav, > > Am Sonntag, dem 15.10.2023 um 17:17 +0200 schrieb Rostislav Svoboda: > > * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): Fix > > haskell-snippets-dir value > > > > The value of haskell-snippets-dir was: > > /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/haskell-s= nippets-*/ > > It needs to be: > > /gnu/store/*-emacs-haskell-snippets-*/share/emacs/site-lisp/ > Actually, emacs-haskell-snippets is doing something wrong when installing= files > directy to site-lisp instead of any other directory. Here's an attempt t= o fix > that. > > Cheers > > gnu/packages/emacs-xyz.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index bb8c25f9b5..7f55febfbb 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -35546,10 +35546,11 @@ (define-public emacs-haskell-snippets > #:phases > #~(modify-phases %standard-phases > (add-after 'install 'install-snippets > - (lambda _ > + (lambda* (#:key outputs #:allow-other-keys) > (let ((snippets > (string-append > - #$output "/share/emacs/site-lisp/snippets/haskel= l-mode"))) > + (elpa-directory (assoc-ref outputs "out")) > + "/snippets/haskell-mode"))) > (mkdir-p snippets) > (copy-recursively "snippets/haskell-mode" snippets))))= ))) > (propagated-inputs > > base-commit: ef026e68fe58ed3be216c76f7c5f008893ed3095 > -- > 2.41.0 > --000000000000474dde0607d348a2 Content-Type: application/x-patch; name="0001-gnu-emacs-haskell-snippets-Improve-snippets-installa.patch" Content-Disposition: attachment; filename="0001-gnu-emacs-haskell-snippets-Improve-snippets-installa.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lnss0lr60 RnJvbSAyZmEzYjg3NmIyZjVmOTY3NTEwMjA1YmFkYWIxZjY4NjVkNTQ4ZjYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8MmZhM2I4NzZiMmY1Zjk2NzUxMDIwNWJhZGFiMWY2 ODY1ZDU0OGY2MC4xNjk3NDUyNjU5LmdpdC5Sb3N0aXNsYXYuU3ZvYm9kYUBnbWFpbC5jb20+CkZy b206IFJvc3Rpc2xhdiBTdm9ib2RhIDxSb3N0aXNsYXYuU3ZvYm9kYUBnbWFpbC5jb20+CkRhdGU6 IE1vbiwgMTYgT2N0IDIwMjMgMTI6Mjk6MjAgKzAyMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IGVt YWNzLWhhc2tlbGwtc25pcHBldHM6IEltcHJvdmUgc25pcHBldHMgaW5zdGFsbGF0aW9uLgoKRFJZ IGluIHRoZSBzcGVjaWZpY2F0aW9uIG9mIHRoZSByZWxhdGl2ZSBwYXRoIG9mIHRoZSBzbmlwcGV0 cyBkaXJlY3RvcnkuCgoqIGdudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy1oYXNrZWxs LXNuaXBwZXRzKVsjOnBoYXNlc10KPGluc3RhbGwtc25pcHBldHM+OiBJbXByb3ZlIHNuaXBwZXRz IGluc3RhbGxhdGlvbi4KLS0tCiBnbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSB8IDEyICsrKysr Ky0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSBiL2dudS9wYWNrYWdlcy9l bWFjcy14eXouc2NtCmluZGV4IDdmNTVmZWJmYmIuLjllMGQyNWQwNmYgMTAwNjQ0Ci0tLSBhL2du dS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2Nt CkBAIC0zNTU0NywxMiArMzU1NDcsMTIgQEAgKGRlZmluZS1wdWJsaWMgZW1hY3MtaGFza2VsbC1z bmlwcGV0cwogICAgICAgICAjfihtb2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMKICAgICAg ICAgICAgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ2luc3RhbGwtc25pcHBldHMKICAgICAgICAgICAg ICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQotICAgICAgICAg ICAgICAgIChsZXQgKChzbmlwcGV0cwotICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFw cGVuZAotICAgICAgICAgICAgICAgICAgICAgICAgKGVscGEtZGlyZWN0b3J5IChhc3NvYy1yZWYg b3V0cHV0cyAib3V0IikpCi0gICAgICAgICAgICAgICAgICAgICAgICAiL3NuaXBwZXRzL2hhc2tl bGwtbW9kZSIpKSkKLSAgICAgICAgICAgICAgICAgIChta2Rpci1wIHNuaXBwZXRzKQotICAgICAg ICAgICAgICAgICAgKGNvcHktcmVjdXJzaXZlbHkgInNuaXBwZXRzL2hhc2tlbGwtbW9kZSIgc25p cHBldHMpKSkpKSkpCisgICAgICAgICAgICAgICAgKGxldCogKChyZWxhdGl2ZS1kaXJwYXRoICJz bmlwcGV0cy9oYXNrZWxsLW1vZGUiKQorICAgICAgICAgICAgICAgICAgICAgICAoaW5zdGFsbGF0 aW9uLWRpcgorICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGVscGEtZGly ZWN0b3J5IChhc3NvYy1yZWYgb3V0cHV0cyAib3V0IikpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiLyIgcmVsYXRpdmUtZGlycGF0aCkpKQorICAgICAgICAgICAgICAg ICAgKG1rZGlyLXAgaW5zdGFsbGF0aW9uLWRpcikKKyAgICAgICAgICAgICAgICAgIChjb3B5LXJl Y3Vyc2l2ZWx5IHJlbGF0aXZlLWRpcnBhdGggaW5zdGFsbGF0aW9uLWRpcikpKSkpKSkKICAgICAg IChwcm9wYWdhdGVkLWlucHV0cwogICAgICAgIChsaXN0IGVtYWNzLXlhc25pcHBldCkpCiAgICAg ICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1Yi5jb20vaGFza2VsbC9oYXNrZWxsLXNuaXBwZXRz IikKCmJhc2UtY29tbWl0OiBhMGQyZWNkZTk0M2JkMTg1NGRkYmI3YzBjYWQzNWExZmM2NGRjNWFi CnByZXJlcXVpc2l0ZS1wYXRjaC1pZDogZjBjMGIyODAwYWRjOTVlYzFjZjJiNWM5MjZjY2EzNmM3 OGU2OTFhZApwcmVyZXF1aXNpdGUtcGF0Y2gtaWQ6IDExMWZhYzExNzY4ZDE0NWUxM2NhOTA1ZGI4 MThlYjc1MWQwZWU0NTcKcHJlcmVxdWlzaXRlLXBhdGNoLWlkOiA1YmRlODM1ZGUxZTBmN2U5Y2Q3 NTI5ODZkYTA1ODU0NjM3MTNkNzQ1CnByZXJlcXVpc2l0ZS1wYXRjaC1pZDogZjZlYjg2NzQ3YTZk MjNkYThlMjRjNWZmNTU1YTI5YTYwMDIyODhmNApwcmVyZXF1aXNpdGUtcGF0Y2gtaWQ6IDJkOGFh MzViZWIzZDlmOThhMzNhNWEwNGU5MDM0ODgyM2JhNzA0ZTAKcHJlcmVxdWlzaXRlLXBhdGNoLWlk OiAyYzUzMTI1ZDkzYWNkYmU5ZTY4MjE4YjIwMTU0MTRmNTQzNWU3YzkyCi0tIAoyLjQxLjAKCg== --000000000000474dde0607d348a2-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 16 12:58:35 2023 Received: (at 66562) by debbugs.gnu.org; 16 Oct 2023 16:58:35 +0000 Received: from localhost ([127.0.0.1]:57712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsQvL-0002xB-9n for submit@debbugs.gnu.org; Mon, 16 Oct 2023 12:58:35 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:59450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsQvG-0002ws-PP for 66562@debbugs.gnu.org; Mon, 16 Oct 2023 12:58:33 -0400 Received: by mail-ed1-x542.google.com with SMTP id 4fb4d7f45d1cf-53d82bea507so8334257a12.2 for <66562@debbugs.gnu.org>; Mon, 16 Oct 2023 09:58:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697475479; x=1698080279; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Vi5Ul3UZ9LBIYwqvL6EKf3utIfwTxDXIM3hqeP7kIGU=; b=VP5ddtYxJxGvFxkfIQldd4T5UkJ7ab1Z7hvH/vCwu3TLtyIE2oBerclOtO5LABEk66 49pYPXyRsbFsA7Vz62BAWuw91nqb0o9lyURMI4WgOZINrzPQZ5gWi5rPvothselFEN3c Ma1kpcH8/U0Myfijx1DusIId2a4qGWeZOq4eFX9CfGhgLZV40oGCvTpVztEmvRUxmRIM 8gFk+tyD4X43A4cZc2spyWBmPeBUIHiHc1QfP1lZwKHO8KjHjjcQyUS4CZRcgRHu1jk9 xWuTYtXgySRU+IEVCgVZEb7HF1iaC0YNAXOKrTIpRgywhjCkap2regcRstpaluA+YY08 Q0tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697475479; x=1698080279; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Vi5Ul3UZ9LBIYwqvL6EKf3utIfwTxDXIM3hqeP7kIGU=; b=U/QmHgDy38cwbAAFao8oSx19B/+5LScj0gzQBeINusW74dhpljmbvzqRX49WTDsk/r l/MkU+1OqeErjpLgCzNV5CL+F+nCEIz6zaMs0iH1SRftOnOQ8DtqCQYzL67wYf9A+EqD o/ufRC5HUlCWsXWU5fWfs7R05NBcLIjOpX1MMTZhyTeVxHGS2URXOdKyLTetW+32GUJv vsv7JVOw2LeVM+CmKnxhZy7xq1MjX7NZ4+jWbD+fqQWF74JClTBfTodvyxDkMwLOZRSu jv2+9YhixS7mrB1T8wRYuiB/r9sfjuClQuAK1T0rP7mgxNaGiCSgFmBt3larchfHNizo itLw== X-Gm-Message-State: AOJu0YyufjZQdizXy60xm1DxAfrfKGJBH9V/FouYSgURSdy21lc90nXh TZAI/4d6Do4XtJ9Zm/9p8Mg= X-Google-Smtp-Source: AGHT+IFIBw8jD4Yh6PvZ7+7UEzQm+w/6zNCjXEmcR0ay8sHAu149nPQQkb/d2tdsjOTigR6gfcKUPg== X-Received: by 2002:a17:906:d54f:b0:9be:71ab:fb5e with SMTP id cr15-20020a170906d54f00b009be71abfb5emr6925902ejc.22.1697475479217; Mon, 16 Oct 2023 09:57:59 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 17-20020a170906029100b00989828a42e8sm4355695ejf.154.2023.10.16.09.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:57:57 -0700 (PDT) Message-ID: <17cd7d2255c7e3e1efb1fb83fc4c0cc84c0c127e.camel@gmail.com> Subject: Re: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. From: Liliana Marie Prikler To: Rostislav Svoboda Date: Mon, 16 Oct 2023 18:57:56 +0200 In-Reply-To: References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: 66562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Montag, dem 16.10.2023 um 12:57 +0200 schrieb Rostislav Svoboda: > Hi Liliana, >=20 > Your patch works (thank you) and I improved it a tiny bit. (See > attachment.) BTW shouldn't the revision number in the (git-version > "0.1.0" "1" commit) be increased to "2" in your patch and to "3" in > mine? No. It should just be one patch anyway and the change doesn't affect the source code, but the build recipe. As such, the rebuild is going to happen either way. > DRY in the specification of the relative path of the snippets > directory. You can just amend my commit. > - (let ((snippets > - (string-append > - (elpa-directory (assoc-ref outputs "out")) > - "/snippets/haskell-mode"))) > - (mkdir-p snippets) > - (copy-recursively "snippets/haskell-mode" > snippets))))))) > + (let* ((relative-dirpath "snippets/haskell-mode") > + (installation-dir > + (string-append (elpa-directory (assoc-ref > outputs "out")) > + "/" relative-dirpath))) > + (mkdir-p installation-dir) > + (copy-recursively relative-dirpath installation- > dir))))))) Now you repeat yourself on relative-dirpath (which is a very Java name anyway, just five characters shorter than the original value won't win you Kolmogorov complexity). Plus you're requiring let* instead of let. Btw. don't=20 ((compose=C2=A0 (lambda (src dst) (mkdir-p src) (copy-recursively dst src)) (lambda (dir store) (values dir (string-append store "/" dir))) "snippets/haskell-mode" (elpa-directory (assoc-ref outputs "out"))) to avoid gratuitous repetition. Sometimes explicit is better than implicit, even if it comes at the cost of typing a constant twice :) Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 17 12:50:35 2023 Received: (at 66562) by debbugs.gnu.org; 17 Oct 2023 16:50:35 +0000 Received: from localhost ([127.0.0.1]:60942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsnH8-0007Td-NU for submit@debbugs.gnu.org; Tue, 17 Oct 2023 12:50:35 -0400 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]:45449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsnH7-0007TN-0X for 66562@debbugs.gnu.org; Tue, 17 Oct 2023 12:50:33 -0400 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-507b18cf2e1so2879471e87.3 for <66562@debbugs.gnu.org>; Tue, 17 Oct 2023 09:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697561401; x=1698166201; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kQsORQqC5t7ELxw4Gcd1XLGgIIE1KBApKTbuqNvg+X0=; b=gDwywmCMedZLyj3C03lTk1qi5FG7d+SX22exwwMK1bf1lyiSl3w3WCmBHrcQWAXM5G AZAJwUKstwiwcwUZXpUhF1MWAr/7M1upYLEuMd48aJQArM1YDvYcE84Np1CXd3J9lF6t Bg+Eo5gtboZTOghGIE7ZJr8SpQtgz/fcNfrqw9XbmtcpqhFlkaxQUrPR6ooSBObLL9KU DCtTFN5yaXLt+jrkiBSyzlBmhEerL0R1UwhaEOmKoj/K9XlxNoC+Omjc/8Pkc4ZOX57l xjP/gByvIZX2nLDzD642LwYvgeyxkT4cs8ANL3sDspMcAVe45gBnCTT0Dn70YWo0FE6+ pGaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697561401; x=1698166201; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kQsORQqC5t7ELxw4Gcd1XLGgIIE1KBApKTbuqNvg+X0=; b=RtE8DuEK56fGhD6T/bNX9Tm1x4VOAd8aLz2yd0n152vSO83rgtGdD+nwr1dbrCqsoA FFDq/PItOndVk/JlMVIp3xyaAj+qBMXVKsSOpcur2nObGLeFPrKXDfZoMIgBgS7+GVTe p2A6ZczZDP3AmmOKyGCqqCS42+TTZJP8o7Q+/0lPI8cCQ1p+/JqcVKJKBlxVZgrlYpFI RcId6Izp5pyGFAALuQqA/L9KBLMiZRaUyG3ukZXPuHgdmhMFO10zzYG4oxtROJmvoywi 0AGie5RnnlBZ9TjLF+Zcs1P+HleNLJYXIiE73cm5nHO4JsMU/KJlzcfvrn8laHRKNtrM JQHQ== X-Gm-Message-State: AOJu0Yyxz/68pAI4WBPxkThDcNsg9NKBBRi7kG6sdTln3o4IyQ5R5ld+ LeephZqz1dxs94fGqYkfKDsPQcZVsTDF8p2N9TI= X-Google-Smtp-Source: AGHT+IHpwfaOtc5czTGSf+Hh4Xo/9ApOaTGau/6mSx24Wqk+YmaH6bLjdLe1HUXZiDUkgpmW/p0ESj6uX0DwU49ghts= X-Received: by 2002:a05:6512:2202:b0:507:a00a:262b with SMTP id h2-20020a056512220200b00507a00a262bmr2690279lfu.68.1697561400543; Tue, 17 Oct 2023 09:50:00 -0700 (PDT) MIME-Version: 1.0 References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> <17cd7d2255c7e3e1efb1fb83fc4c0cc84c0c127e.camel@gmail.com> In-Reply-To: <17cd7d2255c7e3e1efb1fb83fc4c0cc84c0c127e.camel@gmail.com> From: Rostislav Svoboda Date: Tue, 17 Oct 2023 18:49:23 +0200 Message-ID: Subject: Re: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. To: Liliana Marie Prikler Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: 66562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, >> Your patch works (thank you) and I improved it a tiny bit. (See >> attachment.) BTW shouldn't the revision number in the (git-version >> "0.1.0" "1" commit) be increased to "2" in your patch and to "3" in >> mine? > No. It should just be one patch anyway and the change doesn't affect > the source code, but the build recipe. As such, the rebuild is going > to happen either way. > >> DRY in the specification of the relative path of the snippets >> directory. > You can just amend my commit. > >> - (let ((snippets >> - (string-append >> - (elpa-directory (assoc-ref outputs "out")) >> - "/snippets/haskell-mode"))) >> - (mkdir-p snippets) >> - (copy-recursively "snippets/haskell-mode" >> snippets))))))) >> + (let* ((relative-dirpath "snippets/haskell-mode") >> + (installation-dir >> + (string-append (elpa-directory (assoc-ref >> outputs "out")) >> + "/" relative-dirpath))) >> + (mkdir-p installation-dir) >> + (copy-recursively relative-dirpath installation- >> dir))))))) > Now you repeat yourself on relative-dirpath Sure. We have to specify what to copy, and where to copy it. If what and where maintain the same structure, then some repetition is inevitable. > Sometimes explicit is better than implicit, > even if it comes at the cost of typing a constant twice :) A typo in a constant is a runtime error, whereas a typo in a variable name gets caught by the compiler. That's the main rationale behind my patch. (The rest of my email contains just some side remarks.) Cheers, Bost > (which is a very Java name anyway, just five characters shorter than > the original value won't win you Kolmogorov complexity). If it were up to me, I'd use 'src', 'dst'. I find the 'no abbreviations for identifiers' policy excessive. > Plus you're requiring let* instead of let. Having both variants is a language deficiency, in my opinion. Only let should exist, functioning as let* does. This should extend to lambda*, define*, etc. > Btw. don't > ((compose > (lambda (src dst) (mkdir-p src) (copy-recursively dst src)) > (lambda (dir store) (values dir (string-append store "/" dir))) > "snippets/haskell-mode" (elpa-directory (assoc-ref outputs "out"))) > to avoid gratuitous repetition. On the one hand, we face gratuitous repetition; on the other, a snippet like this better expresses compositional transformation between inputs and outputs, which I find to be a way more important that avoiding gratuitous repetition (pun intended). And as a side effect it also simplifies debugging: ((compose ;; (lambda (a b) (format #t "[DBG] 3. a: ~a; b: ~a\n" a b) (values a b)) (lambda (src dst) (mkdir-p src) (copy-recursively src dst)) ;; (lambda (a b) (format #t "[DBG] 2. a: ~a; b: ~a\n" a b) (values a b)) (lambda (dir store) (values dir (string-append store "/" dir))) ;; (lambda (a b) (format #t "[DBG] 1. a: ~a; b: ~a\n" a b) (values a b)) ) "snippets/haskell-mode" (elpa-directory (assoc-ref outputs "out"))) And if you insist, the gratuitous repetition could, in theory, be avoided: ((compose copy-recursively (juxt mkdir-p (partial string-append (elpa-directory (assoc-ref outputs "out")) "/"))) "snippets/haskell-mode") Only if partial and juxt would exist... and here you go ;-) (define (partial fun . args) "Partial function application." (lambda x (apply fun (append args x)))) (define (juxt . fns) "Naive implementation. Inspired by Clojure's juxt. ((juxt a b c) x) => (list (a x) (b x) (c x))" (lambda args (map (lambda (fn) (apply fn args)) fns))) Here yet another pattern appears, the map-reduce. Also the juxt function just screams for "let's call the mkdir-p and (partial string-append ...) in parallel". > Btw. don't (compose ...) Quite the contrary, I think we should do more of (compose ...), however functional composition is hard-to-impossible if e.g.: - essential higher order functions like juxt and partial are not available. - mkdir-p and copy-recursively from the (guix build utils) aren't monadic and mkdir-p returns #t instead of a path-string and copy-recursively returns: scheme@(guile-user)> ,use (guix build utils) scheme@(guile-user)> (copy-recursively "/tmp/f1.txt" "/tmp/f2.txt") `/tmp/foo.txt' -> `/tmp/fox.txt' eeeh... what exactly is the return value of copy-recursively? Hmm. - copy-recursively, although naturally a reducer (i.e. a member of the fold-family, think of 'a list of things goes into a container') is not implemented as such. Hmm, disappointing... although a <...>-fold is used in its implementation. Double hmm. - in general, the built-in compose function can't be called with zero arguments. For that purpose I cobbled myself: (define (comp . fns) "Like `compose'. Can be called with zero arguments. I.e. (thunk? comp) => #t Works also for functions returning and accepting multiple values." (lambda args (if (null? fns) (apply values args) (let [(proc (car fns)) (rest (cdr fns))] (if (null? rest) (apply proc args) (let ((g (apply comp rest))) (call-with-values (lambda () (apply g args)) proc))))))) And finally, in the (guix build utils) there's the install-file which works with single files. What about adding its recursive version: (define* (install-recursively source destination #:key (log (current-output-port)) (follow-symlinks? #f) (copy-file copy-file) keep-mtime? keep-permissions?) "Recursive version of install-file." (mkdir-p destination) (copy-recursively source (string-append destination "/" (basename destination)) #:log log #:follow-symlinks? follow-symlinks? #:copy-file copy-file #:keep-mtime? keep-mtime? #:keep-permissions? keep-permissions?)) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 17 13:29:58 2023 Received: (at 66562) by debbugs.gnu.org; 17 Oct 2023 17:29:58 +0000 Received: from localhost ([127.0.0.1]:60976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsntG-0000Bh-86 for submit@debbugs.gnu.org; Tue, 17 Oct 2023 13:29:58 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:52584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsntC-0000BR-VM for 66562@debbugs.gnu.org; Tue, 17 Oct 2023 13:29:56 -0400 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-991c786369cso959845466b.1 for <66562@debbugs.gnu.org>; Tue, 17 Oct 2023 10:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697563763; x=1698168563; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bjZ4UWsU/K6dzawskbfx4aX68i2OQ+apg27k351x4Ts=; b=XyYpGh/RRXoriYyX6IU7PMfSAUksVgvP5ph53amEZZf+Cqaby4P+L0AW0HWY67Y2BB gfYOP4RqErmrp+OKQ11/Ccfg0a32fsPlu6rgOaICfSZfFY4YHpmoCizGX37sxcbespbz U/C26ZFXJXPe0TScTNM3uNd1dljBMrYtN/dQu8g1/nydCx82AbrtZHGKbojR7D3PnE4H +AqPl3ToRnaz6Mcl+QibmOsN33twMPQK1A9LKStRDV06gG7yCbe0ZbpHsY2015iO+hT5 usNTYTR6vsR2eH4dtSw9thPoU8AV/J7fjyFrmptvzXCo7pp7FKY4Ldj2zh8ijKFVT8c3 rdFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697563763; x=1698168563; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bjZ4UWsU/K6dzawskbfx4aX68i2OQ+apg27k351x4Ts=; b=VV/ifIXNTI/iw1uKLKSCcpjFXabb+Ze8m7YzA/tJarBieSLkunmESGT8n7KJiGKkju ZuRM0MS11IPrpuclR7X5HLszcuQuLBKJRdWKUBGQiRcw8MKxMMPaJdOZBp0qjhx+SnBz Hm9vt8NYIBNwZbUz/jN+VhpKpa/3tN4nl1ZZJ31OosFQndmFWfCK9izbYkNKq0BWEsu5 3RKofu0w0CfM0QVAmSlgOl1/4b447IdqRouaS4Htc6uRW70uI4qZ0bkE5U7U+/7Zy8SO oFBCYQq+nQhQm0uqHR/TZysObkd36xTj3QO+vDTHWHhOeaigCXL6AheFBrh4zAs3Yml3 Q88A== X-Gm-Message-State: AOJu0YwJwUgqbHgizn4KKZwF1xDTs5GVEsU5gU3NAhIU1CEuzd8ztTka /IN20q7hRMd4TTjVWPajgL4= X-Google-Smtp-Source: AGHT+IFkRYvK8H5g9jYOMoRQNIK2rJmWiaTMEM0jU4OIOLXgu/OCnthY+4t4DnBld22N0ylXjHd8bg== X-Received: by 2002:a17:907:3e8c:b0:9ad:8aac:362b with SMTP id hs12-20020a1709073e8c00b009ad8aac362bmr2840328ejc.23.1697563762993; Tue, 17 Oct 2023 10:29:22 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id i22-20020a1709064ed600b00992f2befcbcsm161708ejv.180.2023.10.17.10.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 10:29:21 -0700 (PDT) Message-ID: <70adcf74508ed4c7c6159d7b904e4ceca5e7a75e.camel@gmail.com> Subject: Re: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. From: Liliana Marie Prikler To: Rostislav Svoboda Date: Tue, 17 Oct 2023 19:29:20 +0200 In-Reply-To: References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> <17cd7d2255c7e3e1efb1fb83fc4c0cc84c0c127e.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: 66562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Rostislav Am Dienstag, dem 17.10.2023 um 18:49 +0200 schrieb Rostislav Svoboda: > [=E2=80=A6] > > Plus you're requiring let* instead of let. >=20 > Having both variants is a language deficiency, in my opinion. Only > let should exist, functioning as let* does. This should extend to > lambda*, define*, etc. Only let should exist, functioning as let does. let* is sugar on top. (Not serious about this, there are reasons to have let*, but there are also reasons it's not the default behaviour.) > > Btw. don't > > =C2=A0 ((compose > > =C2=A0=C2=A0=C2=A0 (lambda (src dst) (mkdir-p src) (copy-recursively ds= t src)) > > =C2=A0=C2=A0=C2=A0 (lambda (dir store) (values dir (string-append store= "/" dir))) > > =C2=A0=C2=A0 "snippets/haskell-mode" (elpa-directory (assoc-ref outputs > > "out"))) > > to avoid gratuitous repetition. >=20 > On the one hand, we face gratuitous repetition; on the other, a > snippet like this better expresses compositional transformation > between inputs and outputs, which I find to be a way more important > that avoiding gratuitous repetition (pun intended). And as a side > effect it also simplifies debugging: >=20 > ((compose > =C2=A0 ;; (lambda (a b) (format #t "[DBG] 3. a: ~a; b: ~a\n" a b) (values > a b)) > =C2=A0 (lambda (src dst) (mkdir-p src) (copy-recursively src dst)) > =C2=A0 ;; (lambda (a b) (format #t "[DBG] 2. a: ~a; b: ~a\n" a b) (values > a b)) > =C2=A0 (lambda (dir store) (values dir (string-append store "/" dir))) > =C2=A0 ;; (lambda (a b) (format #t "[DBG] 1. a: ~a; b: ~a\n" a b) (values > a b)) > =C2=A0 ) > =C2=A0"snippets/haskell-mode" (elpa-directory (assoc-ref outputs "out"))) If you need to warp your head around through three debug statements, I'm not convinced you're improving the overall code all that much. > And if you insist, the gratuitous repetition could, in theory, be > avoided: >=20 > ((compose > =C2=A0 copy-recursively > =C2=A0 (juxt mkdir-p (partial string-append (elpa-directory (assoc-ref > outputs "out")) "/"))) > =C2=A0"snippets/haskell-mode") >=20 > Only if partial and juxt would exist... and here you go ;-) >=20 > (define (partial fun . args) > =C2=A0 "Partial function application." > =C2=A0 (lambda x (apply fun (append args x)))) >=20 > (define (juxt . fns) > =C2=A0 "Naive implementation. Inspired by Clojure's juxt. > ((juxt a b c) x) =3D> (list (a x) (b x) (c x))" > =C2=A0 (lambda args > =C2=A0=C2=A0=C2=A0 (map (lambda (fn) (apply fn args)) fns))) >=20 > Here yet another pattern appears, the map-reduce. Also the juxt > function just screams for "let's call the mkdir-p and (partial > string-append ...) in parallel". You can do all that, but it does go against the KISS principle :) > > Btw. don't (compose ...) >=20 > Quite the contrary, I think we should do more of (compose ...), > however functional composition is hard-to-impossible if e.g.: >=20 > - essential higher order functions like juxt and partial are not > available. We have partial. We call it cut. It's part of SRFI-26. It even simplifies the definition of juxt:=C2=A0 (lambda args (map (cut apply <> args) fns)) Anyhow, we quite often don't use it because we'd have to add it to #:modules and the benefit over raw lambdas is often negligible. > - mkdir-p and copy-recursively from the (guix build utils) aren't > monadic and mkdir-p returns #t instead of a path-string and > copy-recursively returns: >=20 > =C2=A0 scheme@(guile-user)> ,use (guix build utils) > =C2=A0 scheme@(guile-user)> (copy-recursively "/tmp/f1.txt" "/tmp/f2.txt"= ) > =C2=A0 `/tmp/foo.txt' -> `/tmp/fox.txt' >=20 > =C2=A0 eeeh... what exactly is the return value of copy-recursively? Hmm. It returns *unspecified*. Yes, most of this stuff is indeed not monadic. Scheme is not purely functional, so side effects are allowed :) > - copy-recursively, although naturally a reducer (i.e. a member of > the fold-family, think of 'a list of things goes into a container') > is not implemented as such. Hmm, disappointing... although a <...>- > fold is used in its implementation. Double hmm. There is a cost to constructing the return value of a fold. I personally can do without creating lists that no one will end up inspecting anyway. > - in general, the built-in compose function can't be called with zero > arguments. For that purpose I cobbled myself: >=20 > (define (comp . fns) > =C2=A0 "Like `compose'. Can be called with zero arguments. I.e. (thunk? > comp) =3D> #t > Works also for functions returning and accepting multiple values." > =C2=A0 (lambda args > =C2=A0=C2=A0=C2=A0 (if (null? fns) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (apply values args) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (let [(proc (car fns)) (rest (= cdr fns))] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (null? rest) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (apply proc args) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (let ((g (apply comp rest))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (call-with-values (lambda () (apply g args)) > proc))))))) I'd argue that compose without procedures is quite meaningless, but maybe I'm thinking too hard. > And finally, in the (guix build utils) there's the install-file which > works with single files. What about adding its recursive version: >=20 > (define* (install-recursively source destination > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 #:key > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 (log (current-output-port)) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 (follow-symlinks? #f) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 (copy-file copy-file) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 keep-mtime? keep-permissions?) > =C2=A0 "Recursive version of install-file." > =C2=A0 (mkdir-p destination) > =C2=A0 (copy-recursively source > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (string-append destination "/" (= basename > destination)) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:log log > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:follow-symlinks? follow-symlin= ks? > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:copy-file copy-file > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:keep-mtime? keep-mtime? > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:keep-permissions? keep-permiss= ions?)) There'd be no point in having copy-recursively then. For a more complete build system that already takes care of all that without having you fiddling with juxt, partial, etc., just take copy-build- system. Not that it's needed here, mind you. Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 04:56:06 2023 Received: (at 66562) by debbugs.gnu.org; 18 Oct 2023 08:56:06 +0000 Received: from localhost ([127.0.0.1]:33135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt2LW-0002Mc-8r for submit@debbugs.gnu.org; Wed, 18 Oct 2023 04:56:06 -0400 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:43351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qt2LS-0002M4-75 for 66562@debbugs.gnu.org; Wed, 18 Oct 2023 04:56:04 -0400 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2c51682fddeso43731321fa.1 for <66562@debbugs.gnu.org>; Wed, 18 Oct 2023 01:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697619330; x=1698224130; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5nPoG5Hd6m2DQTRhsMKPz3kl1PQHpy1g/yJ79b25Rro=; b=HzDww/16np8GhS0+E0Jg5cAXK500ppApFF4IuE/zwx3qoF+nSl7cBlpS1aWLTmcRLj OIMsDBhfa6qotUmekvQB++4BOMrQhHXFa5NZxPQWSVr1HHYlwOIqiLrYqAfYtj1CcSrX rIot6zNwhrkC7/ECqR6e98ZpAc2QntX6svvieUU11fR4ooER1ZfMCrWRG/2PlmnEhbam hOSKN0Y/0aV7VkDaML+Yl8NH/QuNt9AWk8p7Ar/X716/+79mL1ZyUmtXagnRZfzemlnu mcYC1LXP0HJD3uDi1yTY5LXU1xwio30anzoMXYqNkgpcoH3NIWfPwIgfdN5Q/ze3Lo4M D3sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697619330; x=1698224130; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5nPoG5Hd6m2DQTRhsMKPz3kl1PQHpy1g/yJ79b25Rro=; b=g3js1MMEn8Xv4PPGosLxBfiVWlQQG4k1rXQjW3lWXprR7zZTwAQH5nD9reqj67gJoG B79vIH4Z6JZmULnxkwfhivlY21rxj8pKtlrca2QZmVakV2Q65Ipq2PWLZmUBB8iNUibO IkqmXR4kI/6Dq2hhPc3oFK3HHVifTLT4DtAiLvURvYbYuARXs1SPq9jNPCLq6MRJBHuF rzxC7QWsEnQKw8K3tNMTnooe/iPLR89YxopZ7ovvfOipEt9wNTdo7MHiM5hVzckpwD1E Pipzy0+t9nPDNAzlR6FiYTxKHVwoRif8hqTmhsmlCYgu2w2X2M46GhV4Iqo+m9mGXwA4 MGig== X-Gm-Message-State: AOJu0YzZSIt712TD2XQcQk2KOxwgesCGfGpld2HDqpTr4EU60uRSReHe TDX9BnrCKvGFKjznjAW/2ZYfYTcWK0NxUY91L+qIPzrkKqN1bkEs X-Google-Smtp-Source: AGHT+IG0slzeV/oCcddXXeScv/LBDLQpXMPVGBqjb7PnUZo/mUQn4YPIZ72rMkZCUYrZKCpnaO9sngR/rZnokH61SVQ= X-Received: by 2002:a2e:8017:0:b0:2bd:7bd:1a45 with SMTP id j23-20020a2e8017000000b002bd07bd1a45mr1776396ljg.13.1697619329965; Wed, 18 Oct 2023 01:55:29 -0700 (PDT) MIME-Version: 1.0 References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> <17cd7d2255c7e3e1efb1fb83fc4c0cc84c0c127e.camel@gmail.com> <70adcf74508ed4c7c6159d7b904e4ceca5e7a75e.camel@gmail.com> In-Reply-To: <70adcf74508ed4c7c6159d7b904e4ceca5e7a75e.camel@gmail.com> From: Rostislav Svoboda Date: Wed, 18 Oct 2023 10:54:53 +0200 Message-ID: Subject: Re: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. To: Liliana Marie Prikler Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: 66562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, I think we're digressing and since our discussion is mostly about opinions I'd prefer to discontinue it. Except for one rather important point: > > - in general, the built-in compose function can't be called with zero > > arguments. For that purpose I cobbled myself: ... > I'd argue that compose without procedures is quite meaningless, but > maybe I'm thinking too hard. Food for thought: in Emacs Lisp: *** Welcome to IELM *** Type (describe-mode) or press C-h m for help. ELISP> (-compose) # In Racket: Welcome to Racket v8.10 [cs]. > (compose) # Clojure 1.11.1 user=> (comp) #object[clojure.core$identity 0x610db97e "clojure.core$identity@610db97e"] Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 17:59:16 2023 Received: (at 66562) by debbugs.gnu.org; 18 Oct 2023 21:59:16 +0000 Received: from localhost ([127.0.0.1]:34867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtEZP-00050b-Qi for submit@debbugs.gnu.org; Wed, 18 Oct 2023 17:59:16 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:52270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtEZJ-00050G-T3 for 66562@debbugs.gnu.org; Wed, 18 Oct 2023 17:59:14 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-9bdf5829000so864214766b.0 for <66562@debbugs.gnu.org>; Wed, 18 Oct 2023 14:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697666317; x=1698271117; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=dj8J0WT2RIkC5PBoStGED7ANoebXp7LY485zxYjdcjU=; b=ZdnAHXkD0QTmChLB5lIGBZ5FctnExOqlEbeXJMPcmEL67nIg/+Poh76PvNfFyVMva8 TkiJQJbTG6x4j25iv+bzM62dV7tqMBo3+IxdsfJ8i6SLTWaswuNrTWjR+VQvOvIDVaOI nf3znEu0i/sjIKCg29PP2m9yaNtBeRc/iVf0yi3wdzTNNeNxGSBjzs+3GG4dO4l2T8R1 7LGn7gGnTENmjEMtyCEfn1KMXYDXm9MHr7Ag2ShxIQVTEah5dwvmrZHx+7zYNBL+DwKy 0w0eN5SArCWy1h9p92G8zP8E5pgOyCV8tq4Iv5hGnFYqf9wEDup2ohIj9p1Sv4Wddloa klyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697666317; x=1698271117; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dj8J0WT2RIkC5PBoStGED7ANoebXp7LY485zxYjdcjU=; b=sAzHcDLJ+fQcRRB3he+fvmnQbfh5WrzhA6yRMY0/RccwH2fjGSP7NwPF0b1nktuEAA qF5A93KCHgJQOYxZR60BXfsexmPrBwPp+Un50dl+re5dR/SqRCojE7csIlWjik04Xqkz Ed+mBeHFe1xXPPWwrONK9XF73J+xI1mSRclyP/73+WRERlrYE4xrOIEtwcqFpQjZlzDl 9lGe5mtT7O8f3X6G4LISk+Zfx/IA+yC2OMFl/8wolvPmfKmqMW3cBfX7eLDcJKYCkdC+ xqT+RJOnQfzzR4C4I/ilMTBOCMkoib8zIrif4qIdbzx3bjzQ/aIUIpo20kq5Nl/v67+b m4RQ== X-Gm-Message-State: AOJu0Yz8FfIvcLQCgQUzZR1lWBh3wpYhTfp6tP865u7Teb4knv0VYVml zSNVNoQ55Fi/wGv4TYUXrGo= X-Google-Smtp-Source: AGHT+IEOZQM3JzQyUt4t1G5kALHZn74COGF8TSc2nulNCwMsmtzJhafhZVfFadPmeHXXxiEP0UcI9g== X-Received: by 2002:a17:907:6d1c:b0:9a1:f10d:9746 with SMTP id sa28-20020a1709076d1c00b009a1f10d9746mr344589ejc.20.1697666316894; Wed, 18 Oct 2023 14:58:36 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n6-20020a170906688600b0099cb349d570sm2380702ejr.185.2023.10.18.14.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 14:58:35 -0700 (PDT) Message-ID: <329616d22860c97b39490401b5c6640639377902.camel@gmail.com> Subject: Re: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. From: Liliana Marie Prikler To: Rostislav Svoboda Date: Wed, 18 Oct 2023 23:58:34 +0200 In-Reply-To: References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> <17cd7d2255c7e3e1efb1fb83fc4c0cc84c0c127e.camel@gmail.com> <70adcf74508ed4c7c6159d7b904e4ceca5e7a75e.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562 Cc: 66562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Mittwoch, dem 18.10.2023 um 10:54 +0200 schrieb Rostislav Svoboda: > Hi Liliana, >=20 > I think we're digressing and since our discussion is mostly about > opinions I'd prefer to discontinue it.=C2=A0 Agree to disagreeing then. > Except for one rather important point: >=20 > > > - in general, the built-in compose function can't be called with > > > zero arguments. For that purpose I cobbled myself: > ... > > I'd argue that compose without procedures is quite meaningless, but > > maybe I'm thinking too hard. >=20 > Food for thought: >=20 > in Emacs Lisp: > *** Welcome to IELM ***=C2=A0 Type (describe-mode) or press C-h m for > help. > ELISP> (-compose) > # >=20 > In Racket: > Welcome to Racket v8.10 [cs]. > > (compose) > # >=20 > Clojure 1.11.1 > user=3D> (comp) > #object[clojure.core$identity 0x610db97e > "clojure.core$identity@610db97e"] Looks like a bunch of implementation-defined behaviour to me. Note that rnrs barely specifies the case for two arguments :) Cheers From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 23 03:59:23 2023 Received: (at 66562-done) by debbugs.gnu.org; 23 Oct 2023 07:59:23 +0000 Received: from localhost ([127.0.0.1]:48953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qupqN-0001U0-5K for submit@debbugs.gnu.org; Mon, 23 Oct 2023 03:59:23 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:57541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qupqL-0001Tm-4t for 66562-done@debbugs.gnu.org; Mon, 23 Oct 2023 03:59:21 -0400 Received: by mail-ej1-x643.google.com with SMTP id a640c23a62f3a-9b9faf05f51so422006566b.2 for <66562-done@debbugs.gnu.org>; Mon, 23 Oct 2023 00:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698047926; x=1698652726; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=fHZhfIGDbQsPm/kUHTzuN0tnz9O1EmNUtWxKDiMQWxc=; b=aTvkSS90lU0UeyfqeUiEf6LGnlNnsQ1t/eV8ICN3f23YfXLtutgnX0CMQ8A629fmoJ oNhZPiiPNoGRfsKy7cc3TO4dzuI6WRnBWml8W9xRBXL7vm8wsLnKSVE7uYb7NyFnCxDw 2o9PzrKBuSg86f4c2czhVntnFrzrZoB9tDNUWsDK5niXQgZP+NVwSSH1ZEgEdOXc4z+d W4oDQNCSmUOpTzBnhlgl+BgtYfOey7UyPUn2MgoHjkvv00iCokXUdadaouS23ZDJTaQK CP8dkxSIit7Kxd/gtcdzWMLpebtqRWSZyiz5MebPp/Abuwp/+p/OLEGkjO05bjVD4I+E QrHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698047926; x=1698652726; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fHZhfIGDbQsPm/kUHTzuN0tnz9O1EmNUtWxKDiMQWxc=; b=L17qNGwnJPvL0c2S7cvJr3AOKK7E5O60GS8bYYIzszMTm42bSjT4A4P7DJto4H4eR7 KZjKvDa3nu2aVnCWyxf4CqZ4OTkLDA7MGAA+xB9bzryNw+iBfu0yvew/CBYf6FcCRkAp yKK+IkAwflRP4hgmXP8ydPCQR9T4YPy6WmtxUroIOZXh4BNE2y/mxkbDB5g+v6UJwuVz PHcFLX/AynDYPEnXek1cjjXXK0QSwCXo8SBUJxz82qYsBBDETB7uHY1voKTDkUtd+h/N qXYcx1PfAs0x16kIPH2nIxRLkfET3hhQ4p2FyBXeIZETjejIDczeoOfD6HGaRWwdl85w BlsA== X-Gm-Message-State: AOJu0YzYfmyIytdNYd1Ge6YCUOev+YfMSb+faR7zE7iYleDqSbmsKE7j eJHiY7n4UEHLA59hlmXQie7czZhsoG+BQA== X-Google-Smtp-Source: AGHT+IGxm7/lA5A1Vm/6ddhjItyIdNo9GTSDR/JaI9me8U1Nnu8d7Tsugt2PFogVOT4ZGmWv2aazIA== X-Received: by 2002:a17:907:72c2:b0:9be:a2b6:7eae with SMTP id du2-20020a17090772c200b009bea2b67eaemr6872303ejc.52.1698047926228; Mon, 23 Oct 2023 00:58:46 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id h25-20020a170906261900b0099293cdbc98sm6347131ejc.145.2023.10.23.00.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 00:58:45 -0700 (PDT) Message-ID: <7839ec87e27c059d17b3fe3e33011a449aed7a40.camel@gmail.com> Subject: Re: [PATCH v3] gnu: emacs-haskell-snippets: Use correct directory for snippets. From: Liliana Marie Prikler To: 66562-done@debbugs.gnu.org Date: Mon, 23 Oct 2023 09:58:43 +0200 In-Reply-To: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> References: <36c6ef9a672215883a84b8fec5a58a440d32ee11.1697394827.git.liliana.prikler@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66562-done Cc: Rostislav Svoboda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 15.10.2023 um 20:25 +0200 schrieb Liliana Marie Prikler: > This package instructs Yasnippet to look for snippets relative to its > own > path.=C2=A0 However, it installs the snippets directly to site-lisp, whic= h > as of > 79cfe30f3eb10bd3dbf7aa0f6e873c945d7d0ea5 is one directory above > that.=C2=A0 Use the > elpa-directory procedure introduced in that commit to rectify this > mistake. >=20 > * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets)[#:phases] > : Use elpa-directory. >=20 > Fixes: 66562 > --- Made the fixes line more descriptive and pushed. Cheers From unknown Sat Sep 06 02:33:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Nov 2023 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator