From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 16 14:31:28 2010 Received: (at submit) by debbugs.gnu.org; 16 Jul 2010 18:31:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZph2-0000jQ-JB for submit@debbugs.gnu.org; Fri, 16 Jul 2010 14:31:28 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZph0-0000jL-UQ for submit@debbugs.gnu.org; Fri, 16 Jul 2010 14:31:27 -0400 Received: from lists.gnu.org ([199.232.76.165]:38237) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OZphF-0006dE-1o for submit@debbugs.gnu.org; Fri, 16 Jul 2010 14:31:41 -0400 Received: from [140.186.70.92] (port=57416 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZphD-0007yi-HN for bug-coreutils@gnu.org; Fri, 16 Jul 2010 14:31:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZphA-0002Jc-8x for bug-coreutils@gnu.org; Fri, 16 Jul 2010 14:31:37 -0400 Received: from kiwi.cs.ucla.edu ([131.179.128.19]:57335) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZph9-0002J1-Vc for bug-coreutils@gnu.org; Fri, 16 Jul 2010 14:31:36 -0400 Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by kiwi.cs.ucla.edu (8.13.8+Sun/8.13.8/UCLACS-6.0) with ESMTP id o6GIVXtb021415 for ; Fri, 16 Jul 2010 11:31:33 -0700 (PDT) Message-ID: <4C40A585.5090803@cs.ucla.edu> Date: Fri, 16 Jul 2010 11:31:33 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100527 Thunderbird/3.0.5 MIME-Version: 1.0 To: Bug Coreutils Subject: [PATCH] tests/misc/sort-merge-fdlimit: don't assume -R opens /dev/urandom Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) While reviewing the recent sort patches I discovered something else that needed to be merged. One test in the patch assumes that sort -R opens /dev/urandom, and makes sure that file descriptor exhaustion doesn't occur. But sort -R no longer opens /dev/urandom by default, so the test doesn't actually test for the bug that it was designed for (and the test will succeed even if the bug was present). I installed this to resurrect the test. >From 9e89f39526999c6eef0a0d0211eaa1804e62a628 Mon Sep 17 00:00:00 2001 From: Paul R. Eggert Date: Fri, 16 Jul 2010 11:27:42 -0700 Subject: [PATCH] tests/misc/sort-merge-fdlimit: don't assume -R opens /dev/urandom * tests/misc/sort-merge-fdlimit: This test was written assuming that -R typically opens /dev/urandom, but that's no longer the case. Redo test to specify a random source; this resurrects the point of checking for file descriptor exhaustion. Also try plain -R, since that implementation may change in the future too. --- tests/misc/sort-merge-fdlimit | 14 +++++++++----- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/misc/sort-merge-fdlimit b/tests/misc/sort-merge-fdlimit index d1736f5..56b8518 100755 --- a/tests/misc/sort-merge-fdlimit +++ b/tests/misc/sort-merge-fdlimit @@ -31,6 +31,7 @@ mkdir in err || framework_failure for i in `seq 17`; do echo $i >in/$i done +seq 17 >some-data # When these tests are run inside the automated testing framework, they # have one less available file descriptor than when run outside the @@ -43,11 +44,14 @@ done && sort -m --batch-size=16 in/* 2>err/merge-default-err \ || ! grep "open failed" err/merge-default-err) || fail=1 -# If sort opens a file (/dev/urandom) to sort by random hashes of keys, +# If sort opens a file to sort by random hashes of keys, # it needs to consider this file against its limit on open file -# descriptors. -(ulimit -n 20 \ - && sort -mR --batch-size=16 in/* 2>err/merge-random-err \ - || ! grep "open failed" err/merge-random-err) || fail=1 +# descriptors. Test once with the default random source +# and once with an explicit source. +for randsource in '' --random-source=some-data; do + (ulimit -n 20 \ + && sort -mR $randsource --batch-size=16 in/* 2>err/merge-random-err \ + || ! grep "open failed" err/merge-random-err) || fail=1 +done Exit $fail -- 1.7.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 02:49:30 2010 Received: (at 6655) by debbugs.gnu.org; 24 Jul 2010 06:49:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcYY5-0002tS-Rk for submit@debbugs.gnu.org; Sat, 24 Jul 2010 02:49:30 -0400 Received: from kiwi.cs.ucla.edu ([131.179.128.19]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcYY3-0002tN-A7 for 6655@debbugs.gnu.org; Sat, 24 Jul 2010 02:49:28 -0400 Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by kiwi.cs.ucla.edu (8.13.8+Sun/8.13.8/UCLACS-6.0) with ESMTP id o6O6nOGQ006444 for <6655@debbugs.gnu.org>; Fri, 23 Jul 2010 23:49:25 -0700 (PDT) Message-ID: <4C4A8CF4.2070105@cs.ucla.edu> Date: Fri, 23 Jul 2010 23:49:24 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100527 Thunderbird/3.0.5 MIME-Version: 1.0 To: 6655@debbugs.gnu.org Subject: Re: [PATCH] tests/misc/sort-merge-fdlimit: don't assume -R opens /dev/urandom References: <4C40A585.5090803@cs.ucla.edu> In-Reply-To: <4C40A585.5090803@cs.ucla.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 6655 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On 07/16/10 11:31, Paul Eggert wrote: > I installed this to resurrect the test. Ooops; forgot to push that. Sorry. Just did it now. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 24 03:24:12 2010 Received: (at 6655) by debbugs.gnu.org; 24 Jul 2010 07:24:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcZ5g-00038T-No for submit@debbugs.gnu.org; Sat, 24 Jul 2010 03:24:12 -0400 Received: from kiwi.cs.ucla.edu ([131.179.128.19]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcZ5e-00038O-T4 for 6655@debbugs.gnu.org; Sat, 24 Jul 2010 03:24:12 -0400 Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by kiwi.cs.ucla.edu (8.13.8+Sun/8.13.8/UCLACS-6.0) with ESMTP id o6O7O7Dk006685; Sat, 24 Jul 2010 00:24:09 -0700 (PDT) Message-ID: <4C4A9517.9060708@cs.ucla.edu> Date: Sat, 24 Jul 2010 00:24:07 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100527 Thunderbird/3.0.5 MIME-Version: 1.0 To: Bug Coreutils Subject: Re: [PATCH] du: tune, and fix some -L bugs with dangling or cyclic symlinks References: <4C361834.4080306@cs.ucla.edu> In-Reply-To: <4C361834.4080306@cs.ucla.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 6655 Cc: 6655@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) No further comment, and that patch does fix some real bugs and seems to be pretty safe, so I took the liberty of pushing it. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 19 03:14:25 2011 Received: (at control) by debbugs.gnu.org; 19 Apr 2011 07:14:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QC58i-0008GB-Px for submit@debbugs.gnu.org; Tue, 19 Apr 2011 03:14:25 -0400 Received: from mx.meyering.net ([82.230.74.64]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QC58g-0008Fz-LU for control@debbugs.gnu.org; Tue, 19 Apr 2011 03:14:22 -0400 Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id 2DB50600FB; Tue, 19 Apr 2011 09:14:17 +0200 (CEST) From: Jim Meyering To: control@debbugs.gnu.org Subject: Re: bug#6655: [PATCH] tests/misc/sort-merge-fdlimit: don't assume -R opens /dev/urandom In-Reply-To: <4C40A585.5090803@cs.ucla.edu> (Paul Eggert's message of "Fri, 16 Jul 2010 11:31:33 -0700") References: <4C40A585.5090803@cs.ucla.edu> Date: Tue, 19 Apr 2011 09:14:17 +0200 Message-ID: <87oc421zna.fsf@rho.meyering.net> Lines: 4 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) close 6655 thanks Pushed months ago, so closed. From unknown Fri Aug 22 01:03:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 May 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator