Subject: Re: bug#66539: 30.0.50; eldoc-echo-area-prefer-doc-buffer missing choice

From: Mauro Aranda <[email-masked]>
Date: Sat, 14 Oct 2023 10:36:20 -0300

tags 66539 patch
quit

Patch attached.  Please also note that this, and other user options are
missing the :version keyword (which I guess should be 28.1, at least for
this one)

From 9a583a2d4e5dacd4a443c3d37c096fa34f6ec17a Mon Sep 17 00:00:00 2001
From: Mauro Aranda <[email-masked]>
Date: Sat, 14 Oct 2023 10:34:54 -0300
Subject: [PATCH] Fix a defcustom :type

* lisp/emacs-lisp/eldoc.el (eldoc-echo-area-prefer-doc-buffer): Make
:type a choice, to allow for the value maybe.  (Bug##66539)
---
 lisp/emacs-lisp/eldoc.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 3a786bb321b..941f1e4e157 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -132,7 +132,9 @@ eldoc-echo-area-prefer-doc-buffer
 buffer (displayed by `eldoc-doc-buffer') is already displayed in
 some window.  If the value is the symbol `maybe', then the echo area
 is only skipped if the documentation needs to be truncated there."
-  :type 'boolean)
+  :type '(choice (const :tag "Prefer ElDoc's documentation buffer" t)
+                 (const :tag "Prefer echo area" nil)
+                 (const :tag "Skip echo area if truncating" maybe)))
 
 (defface eldoc-highlight-function-argument
   '((t (:inherit bold)))
-- 
2.34.1