From unknown Tue Jun 17 01:37:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Resent-From: Tomas Volf Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 13 Oct 2023 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: 66531@debbugs.gnu.org Cc: Tomas Volf X-Debbugs-Original-To: bug-guile@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169721393820734 (code B ref -1); Fri, 13 Oct 2023 16:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Oct 2023 16:18:58 +0000 Received: from localhost ([127.0.0.1]:47300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrKsM-0005OM-2A for submit@debbugs.gnu.org; Fri, 13 Oct 2023 12:18:58 -0400 Received: from lists.gnu.org ([2001:470:142::17]:35272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrKsJ-0005O8-AZ for submit@debbugs.gnu.org; Fri, 13 Oct 2023 12:18:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrKrp-0006sb-IY for bug-guile@gnu.org; Fri, 13 Oct 2023 12:18:26 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrKrn-00039e-1Q for bug-guile@gnu.org; Fri, 13 Oct 2023 12:18:25 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id EF67A26B373; Fri, 13 Oct 2023 16:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697213897; bh=j+nWa6+Rigc76UQWflcDcQwvt8kaZiYFMDPC85JI/pU=; h=From:To:Cc:Subject:Date; b=oYb/Y1nVlO3jLt7hNNHFvLdoCyX6tfpJLnqyXMvOae/0nnpk2+/l4fBcxq/KDZstH rhOsh2ZQY1c30gZsk2H/pCE3+b66zEtGpwelEQFsGdt1ocBndWWTuZcezy5aG6fCUr 3uyNKNekGC2M45cfv73mbZIjfUFVkqKFHt6s9zICb0qugV48fHQdC5PhLSseLuHLMb xnc+bUjxvxJ+lC/5unmcqQAuqfGEc8nlIuIqrH61n1AFM9xeLuA2BhcSY7Azo2J5yD aFNEBsy4y/W0125jvZkk1LQz7C/BihfHkMrb2hZq+QhpxWfCikXGg7M/2Q761zkFwe P5z8ImrhRBzE48PmU61JjHvDVWZP+2MjNzj9bZHd8xz19Jun++VdMzw4aIOZ2qe7pS U8t0NxjpBLNiLPJOx8eo/nwLpguK6DQ9ZlnIYQJBWTPKFoJCd0ctRcUvrjS6oT29bE DwdVovjz0K2WNWGsO0vCo17TeZkYYDRYh9Eo8GbwJrdkgcscab6zAf5r2Bbyoqc7FN H9NDc6ppekgLGFhqAwi1cdLybriZNcYVS4LWwL4WcsAz2uyNW+XFcZDkuezNnaksWk bZBColiqSJ5xwdW5oKGlIDic0auITh+xArapAL++1s8VsY98keI+yYxg/u9/G3VAgP p7ykBCeALIf/yi2xbfh9/sRY= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost (unknown [81.17.16.88]) by wolfsden.cz (Postfix) with ESMTPSA id 0F89926B4E1; Fri, 13 Oct 2023 16:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697213897; bh=j+nWa6+Rigc76UQWflcDcQwvt8kaZiYFMDPC85JI/pU=; h=From:To:Cc:Subject:Date; b=oYb/Y1nVlO3jLt7hNNHFvLdoCyX6tfpJLnqyXMvOae/0nnpk2+/l4fBcxq/KDZstH rhOsh2ZQY1c30gZsk2H/pCE3+b66zEtGpwelEQFsGdt1ocBndWWTuZcezy5aG6fCUr 3uyNKNekGC2M45cfv73mbZIjfUFVkqKFHt6s9zICb0qugV48fHQdC5PhLSseLuHLMb xnc+bUjxvxJ+lC/5unmcqQAuqfGEc8nlIuIqrH61n1AFM9xeLuA2BhcSY7Azo2J5yD aFNEBsy4y/W0125jvZkk1LQz7C/BihfHkMrb2hZq+QhpxWfCikXGg7M/2Q761zkFwe P5z8ImrhRBzE48PmU61JjHvDVWZP+2MjNzj9bZHd8xz19Jun++VdMzw4aIOZ2qe7pS U8t0NxjpBLNiLPJOx8eo/nwLpguK6DQ9ZlnIYQJBWTPKFoJCd0ctRcUvrjS6oT29bE DwdVovjz0K2WNWGsO0vCo17TeZkYYDRYh9Eo8GbwJrdkgcscab6zAf5r2Bbyoqc7FN H9NDc6ppekgLGFhqAwi1cdLybriZNcYVS4LWwL4WcsAz2uyNW+XFcZDkuezNnaksWk bZBColiqSJ5xwdW5oKGlIDic0auITh+xArapAL++1s8VsY98keI+yYxg/u9/G3VAgP p7ykBCeALIf/yi2xbfh9/sRY= Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b04980c0; Fri, 13 Oct 2023 16:18:15 +0000 (UTC) From: Tomas Volf Date: Fri, 13 Oct 2023 18:18:11 +0200 Message-ID: <20231013161811.19233-1-wolf@wolfsden.cz> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=37.205.8.62; envelope-from=ws@wolfsnet.cz; helo=wolfsden.cz X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Both macros were missing a quote for the procedure call, causing the actual return value to be compiled into the ftw.go, instead of the procedure call. Snippet from disassembly of ftw.go does confirm that: 55 (make-immediate 2 3990) ;; 997 at ice-9/ftw.scm:319:46 56 (make-long-immediate 1 120002) ;; 30000 at ice-9/ftw.scm:320:46 That effectively prevented ftw from entering directories without access for others. Simple reproduction: scheme@(guile-user)> ,use (ice-9 ftw) scheme@(guile-user)> (mkdir "/tmp/xxxx") scheme@(guile-user)> (chmod "/tmp/xxxx" #o0700) scheme@(guile-user)> (ftw "/tmp/xxxx" (lambda (_ __ f) (pk f) #t)) ;;; (directory-not-readable) $1 = #t scheme@(guile-user)> (system "ls -al /tmp/xxxx") total 0 drwx------ 1 wolf wolf 0 Oct 11 22:54 . drwxrwxrwt 1 root root 888 Oct 11 22:54 .. $2 = 0 The fix is to quote the procedure call, leading to the intended behavior. This fixes bug 55344. * module/ice-9/ftw.scm (getuid-or-false): Quote the (getuid). (getgid-or-false): Quote the (getgid). --- module/ice-9/ftw.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/module/ice-9/ftw.scm b/module/ice-9/ftw.scm index ac6aa6316..8496086a1 100644 --- a/module/ice-9/ftw.scm +++ b/module/ice-9/ftw.scm @@ -201,12 +201,12 @@ (define-macro (getuid-or-false) (if (defined? 'getuid) - (getuid) + '(getuid) #f)) (define-macro (getgid-or-false) (if (defined? 'getgid) - (getgid) + '(getgid) #f)) (define (directory-files dir) -- 2.41.0 From unknown Tue Jun 17 01:37:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Resent-From: Mike Gran Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 13 Oct 2023 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: "66531@debbugs.gnu.org" <66531@debbugs.gnu.org>, Tomas Volf Received: via spool by 66531-submit@debbugs.gnu.org id=B66531.169721826230325 (code B ref 66531); Fri, 13 Oct 2023 17:32:01 +0000 Received: (at 66531) by debbugs.gnu.org; 13 Oct 2023 17:31:02 +0000 Received: from localhost ([127.0.0.1]:47384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrM03-0007sg-NS for submit@debbugs.gnu.org; Fri, 13 Oct 2023 13:31:02 -0400 Received: from sonic314-13.consmr.mail.bf2.yahoo.com ([74.6.132.123]:33517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrLzw-0007sL-V1 for 66531@debbugs.gnu.org; Fri, 13 Oct 2023 13:30:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697218223; bh=F0a4m+DJpj75zlgJzcQ9phsVX4MZ/CD2u4dGjsMGx+E=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=C8dTox6FvXaje3AZxsImj7Ffh+1dqIJX4E5Q89oy0m9zYNzJCovfk0ia0CRO35qz9sPPnSmhFTCLyLB+zFbZhkntAa6GxqAiXXBN+bbvL+rFLNaI1EIqG725SYqq51hep5ICGUWSRmS1J8zVcp7vsf9JAEjSUdehQnuJqKaXjPOts9jNBF/1YhU3nOPOo8FKXVIRa8/lMLPST7cQ6YKHvvaC6Y5YemjTgVUGKTncjYhh2SGfKMB0Xs8/JhHctnLK23EBc3+JOQerLYsuMflHsxerJ+tRBC1P/e2NJgvRs4zrFbeN/pAwDnTAVXpPwUP/yc3M+UOHWmRzgZ4IueHLWQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1697218223; bh=Fx0Ja2P8C6kqX4PQdnk8b7G9PvtkKWi4zxMDW6xs8Ly=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=fcxNUIZLzmMiZmq0MpyRT8Gzbesl4ksM1qS32uvPRh2QMDdLVwEYN+zRipsKJGlz+RDp26aQBhtA3KSB7Gt10CPag/4M3K9TjQdHcJ5nwj19dl/ouDvqteLinFpNtmrJBZf/90ZQyS34dtLkpEpg8e4NM6HtB6zmuxK4wrotdNJSt1pFs9zfZA286LnnsY8B/NbsCcczenZM63yYnmn5zInO/JDhhHHUaaKZir1Vu2YAVVV8oTEjxBluSAD6hz+K25w0Nw/FQfGe6PGNhCqlK45nG69yQ3u3jIht/c5WfE/Wj3PDBULwOCWeABF+5sFAaCGHtbcnPydeYAS62eZkrA== X-YMail-OSG: yd2TDK4VM1l5fKCpcOqplBRH05a.F5aPY6CtcshwMMwM1D5nqtI0HW2Ebogqqll 3sVeq1gLMW8BuiX.SiTXo_nTvj16m4RDERYyXKSGOEJr72TFo3SiXICwXsS75C6xgi.VRgAHDPQD u2FKoTb7cN31yfRHvi4HwEN9EbI4kaHG3Tw5G3oCtKLeDSgkhM9X9R0IZ6hj6ihITrPtXGrcH5Ha DyF3p8zWysMBxAjjMjl7Gx96iDpbVQix050dCyhvTJSfa8v26VxBonoem.dPend9lgETrcDzJH4K lshUZif8b_HHRdoJNzWES5JX9ZrhkyQM6M3hfZH6xN5Y1.bqNczdd79BdKxStMAkruFrWSi.TUFo 7hsS48uSEa0PtelMlz7mGCLRVABQ__C2NQodhRhJhcF7ECrMQcqqLfn7PeWOJ0mOKdwtRVd3woaP DJ3PON8pCaBSbLy_lJrNJxVKLyw6K9DjJn_zG0y5cH3Gl4FXkBjzXm_FmVtrV3bfN1LCDBkX8wfw ANC3V4HgXAcNpRP7uLh0MNat2KyJx7eEQHAghWIhTD5Fuba88fB4xWDs51FA_bEqINkcXorrrjyo IbW3pKZLVTULnaXLR9LArxKPoMzZpd6dM0e_gqw_pZDglAJrYKwldSU0HnXIKNXF7BHbL4wN36tI PAsT6RmKR7rXVyw8GQmbyNRxUeJ07.O3WtltQ54H4NmzR3YNVc30MFSfJmkUTdoQRGwhTuPc6jDz YylqPuUdQeXBnqAw8SSH4CsOJI0FnQ0e2.8l1exmyDb1rYlrhkFR5f0roxiYP8vG5NQwrCt49lXb cVL5AQctDXOaxGBlJRU5K_6KMsadXLmuUlHP1ubEtsft.IuGCf8LJQGnWfAirOcufDhqvt.jK6ut Q8d2oG3na_o1AEftu6aLafinfxNOLXlGEjikudMqdgaOqdWnbEcWsc.K18Pl0NzcJTZRPGokOKns cUP539WvCizCmm3QCBOXY0EXMZnS9bde06kwAOgxLdHbT1CbHxxA_6LVsmHnAHXyW9G4.Ongh6cm BpodDg8biKDzatjq0CJWSfl9W0g.xdvOyAlZ3Kxt96j7ZTvmldoM9MfiyidI4jQXwQCLPWNgV3eh cGfnKkSvwzZjlFzoJJcYr1kZ9s1wQFadwMbMqmyZcP5usNgochGPPCbX1ktg4qTOeTkLjM43zutv 2r2PeIKS.kUqvfvjZaLIOjXn599o1uQpn0FmSmKbgzwHO395zEOkrlkE7lQkjcX3lGEh0Xz8MXLO YHWKS.A2y2xxbel3cXtMHtnv8NicpN9Gpwyz2tEndFYDP3wx8_6u1ow_y4s7RIeCm0IdQ0yuUFBp MVt3jBpsplEjEY9biy6dqI320FGafCB98D7yLVihxh_fOg_ygvlqFhsi0jBzQjWTNKq67wpfA_Tv tbjHDj0KFUW1QcH7sEYjwvDPE7GPVimcSY0OG60qw8BFVbStk_7qgpcoGNyU5xC4bOuflSnNfpzz HYb5HEAP5a93TaYq2JrY5gXCNQXRwIw7bmxSk216tCgF2PPGtG2pAZg9r8PZLWJqMJ2LPZDPRNRM HpYVcPhO913WST3qOCvp2rkfYn9eCegfFIxIrsMFk3GYeOxcyGsujLXgfVFgfBXREUhbORtSoWZ6 0Yk9AZ9B9Kdn9KGxMQrXQvt06TjJtulbpXdgdmh7LE8G9nvs2KZE8vwn_gTfFoK4UHsqwlHNSr.L lb1tDkKpiDEwW1Igq2A_ke2gO9a_QQsKaSNw.KX.TgvNbvTkmRo9Sv.OPCvaYZpo4UFt7kDZ1hcm iHjeDI4FrFdmd1QHruwDowepov4FBy4mT11TCGke4CDFmqnMJjrElQU3bh4SxGY2IkImwtzM9Eyc OqvoqWZYxSCI4zhpksbAh4kl0plpoEkw2Qa2ROf_cNxYN42kpkCU6raG4El7V07hhBNBECw2.gsm gSuPvjI_34coAdGRe2t.MBq93f67y8yCs6KatkQjr1IxiSkarPkfehLJioLRvS0Vh9iUU0P6T9YT Fimo2UhBw3hsycPyO0muW03muRXL39u_yieK3_9z8.EhLj1klnQANQEfnP1VkZz5zee53BA4zTaM m9u..Ygi3afC4bosnZsGhpkQ4wHYjutxmeiL5bBj_bwCouq8s_KqhOXqgWegKnqmJ2PqKxhd48gD RR5o6kiDzI6uQuHQV6ZDWiaO5bFIgeKvlGvUMuUndB0KI3FvEVPqSjiA_eI1qRwR6W4gzgeq2Lsx faBPdCCgjFNaBDQEu9dxMgRMCsy4M0k56ZAFoCgjJjfnGe3cS_Ey9xmiEtIA7BPk- X-Sonic-MF: X-Sonic-ID: 596d0c91-c2bd-4e4b-a4f6-d90dfb154dde Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Fri, 13 Oct 2023 17:30:23 +0000 Date: Fri, 13 Oct 2023 17:30:06 +0000 (UTC) From: Mike Gran Message-ID: <458374241.8000448.1697218206032@mail.yahoo.com> In-Reply-To: <20231013161811.19233-1-wolf@wolfsden.cz> References: <20231013161811.19233-1-wolf@wolfsden.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21797 YMailNorrin Content-Length: 390 X-Spam-Score: -0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) > Both macros were missing a quote for the procedure call, causing the > actual return value to be compiled into the ftw.go, instead of the >procedure call.=C2=A0 Snippet from disassembly of ftw.go does confirm that= : Looks good to me. If you don't have commit approval, I can take the action to commit it, and write a test case, since I was the one who broke it back in 2021. Mike Gran From unknown Tue Jun 17 01:37:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Resent-From: Tomas Volf Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 13 Oct 2023 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Mike Gran Cc: "66531@debbugs.gnu.org" <66531@debbugs.gnu.org> Received: via spool by 66531-submit@debbugs.gnu.org id=B66531.16972212404009 (code B ref 66531); Fri, 13 Oct 2023 18:21:02 +0000 Received: (at 66531) by debbugs.gnu.org; 13 Oct 2023 18:20:40 +0000 Received: from localhost ([127.0.0.1]:47396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrMm8-00012b-HV for submit@debbugs.gnu.org; Fri, 13 Oct 2023 14:20:40 -0400 Received: from wolfsden.cz ([37.205.8.62]:43056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrMm2-00012K-NK for 66531@debbugs.gnu.org; Fri, 13 Oct 2023 14:20:39 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id B7D0526CB9F; Fri, 13 Oct 2023 18:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697221208; bh=Hwk0xXbVMB7RqbipJyUOvZrgQvEnu1u33k+mhj6qXwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=SUqUkoOMU70jBsMGtC/nlcm2UGgWerq1ZW7xWfmB/uvNGDfOctPllKL6gcXoTy/BS zpVRHvfHT7k3iPYisgfU1cUfPOGX0KzKOWXrm1PEhBs47MfOfJxs3qn+Gkts99JPjN b0DTog+GsuSDcB7QZaLGByFG7o+tOQ/vhYLlHiPH8SPVLwIZifNM9ETPqapTAVke2w xKI741/gnwPYO0UJnMGMPZ+dy/VgAarZ+Ygtrw4/XKLNfcdgel6ZjQo2JyuahJvl3d PQeyaQNzwYSTTdiBb8nsMk0goE7q/mK/hUJgtYYglP9KU72dUDmj3w8xlFWoUk7LUP U0TvxdYrVWVS/IcRMonbymu+jVvyoMoq+L7ktyyCdAoVW8pu+kTEdkfMhjWqlzR3sW hNQ709JmDA8Z+9TPLfcyu1GBAhMHko9ji7YOb9VmyVZzbmSOOFt3acBtaqse5hZzIj lG7Vud3Eq60MndM2Yrcq2XKdVcvniy4H1FQkUCg5JTToPOmUwSCVd0fQlvpbJNvMu0 WelUMIkowEZNTCswEN9IX7GS7HG1yVjI2m73lKYhYYNmVIStabFP7WYyxlIfknMDTs mrSOUXpHqN57qlca2TB7j9H2ZRa35bOQU/jCim+1SkJRtyqYWSLTo7Y3I+Cq+zPvOQ ixavs9gbedPCRr5XbxZZZMO0= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost (unknown [81.17.16.88]) by wolfsden.cz (Postfix) with ESMTPSA id 6DAE426C78D; Fri, 13 Oct 2023 18:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697221207; bh=Hwk0xXbVMB7RqbipJyUOvZrgQvEnu1u33k+mhj6qXwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=vNYnUJD/hmwaEPDS7wdafiq7crtIhe5nQ9esQokwGlquxR0oJEsL86hlUjRnZGHSw xpvudaiL//UEXWDXNQ0D61zesI23CVMYkedKiKC4FlSWjTANR49kmgJELSWNtTyDAB DUIhzosZyBEEV34lbeJE2kmDgGVu+mA+N1xCSMcGAVdl98fbewzi2sH7olY/5RDuiy AarY/j3ZWys8skPtgt8mzGAib72aIEu81lj3k/WEl3N9tu//N8Rk2FXN81IcT+QD15 Y1So/HlUwszqrZ1naffPN+RT20qj43JVITQ5dRVE/dny13pPLzEnJ9aVfFYE6TfQ9z PQ2/+B6j/CM+UCPwjPsWM4hCxzPcvl+0hup4q4EU1W68tsaDTfjXXECLruT5kr5yJJ bs1uU6T2e+nYqBJe9TRoH1l+7AJlWzG4O4Sz7GbYNyFABgo4LOj4ZIZ/eID5H+BquX Wa0i8KTvmxnonjn8nbjr4gsdGnoTZDMD9OkCETrpb5DeyKcy7Q/uLvpDG4wEPC7rU5 3bbPlCG+WrWdptqPGvndfhIIHSOMzOo6pONoz/oqDMYNyncgTxIfjEI7ySN150gbNP D55LUriH55yaMrG7NaNrBplYMnwzTDkhJHvPTh6LcNDJcxZr0CEMc7/okkIKCXOtI3 G9Zo8xLPEZ3QgNRyPikPR668= Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ffb90aca; Fri, 13 Oct 2023 18:20:03 +0000 (UTC) Date: Fri, 13 Oct 2023 20:20:03 +0200 From: Tomas Volf Message-ID: References: <20231013161811.19233-1-wolf@wolfsden.cz> <458374241.8000448.1697218206032@mail.yahoo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LI0+977NKn5E6PUe" Content-Disposition: inline In-Reply-To: <458374241.8000448.1697218206032@mail.yahoo.com> X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --LI0+977NKn5E6PUe Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2023-10-13 17:30:06 +0000, Mike Gran wrote: > > Both macros were missing a quote for the procedure call, causing the > > actual return value to be compiled into the ftw.go, instead of the > >procedure call.=A0 Snippet from disassembly of ftw.go does confirm that: >=20 > Looks good to me. >=20 > If you don't have commit approval, I can take the action to commit it, > and write a test case, since I was the one who broke it back in 2021. I do not have commit access, nor I am sure how the tests should look like, so if you would be so kind to take it over from here, that would be great. :) >=20 > Mike Gran Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --LI0+977NKn5E6PUe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmUpilMACgkQL7/ufbZ/ waku8RAAsBcAmNEcEVr2S+gKv09shY2mNmI0eovF8jPlzBfm/49jlEPbQFa9cOdT ASXQB7wkjGz9tum9IhzU6Q2UW7AcR0IS+g2Rvr4JATuKTds3vfShxhw+1WQccoCh YvzT/OugnhL+89pth+RjM9wUmJMKF81DBZa/Sdya7CdE9xVniJaiLhgjd7xNy3Pe gBcnBGk6KcAruie5lElpVxZyeXUDaUPUtQTQqqSMkOOhbPjtOP+LA+RQAIV2NSg4 UlABG+LTMhAfo94puj6ZEpGCg6MQZcrE28rX5sMP3SfC3THwu9yox56z19Ti+L4p EkPtf6Bn1+ySgJF/mslHc4Cu2AJGUaYnwxmkJl3M7fL4eJtmWMZUyuD/gzlRCOkt pSmwQsusPciHoxNVck+lU16krZbgAsNr2TlkFSlzWub+5K+xBuSWiDzU7cft+OcM EQBIxuDSqCZ4aLlSJ1ybd8fiZLeWzDWm9ZtGne/Fuv2S7C0soEs/39eXO5d8szBt phNf3KfPtqXe9lRJxyw2ioUnjKf4FtA36zRx363PXzNg/vDrjNDsjTsJHw7WjfwY CBPcX6uxqpaMbSy5Uj4zwD9LC3EY/0WcZxyPS7t34KpIxvl7lwtYbyTscWAE//BG d4RnwdlGk+g/3s7C27E0RKxkth/B70hoKBOv2paDj0PGM+nbtcg= =HeZA -----END PGP SIGNATURE----- --LI0+977NKn5E6PUe-- From unknown Tue Jun 17 01:37:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Resent-From: Mike Gran Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 25 Oct 2023 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Tomas Volf Cc: "66531@debbugs.gnu.org" <66531@debbugs.gnu.org> Received: via spool by 66531-submit@debbugs.gnu.org id=B66531.169824255414185 (code B ref 66531); Wed, 25 Oct 2023 14:03:02 +0000 Received: (at 66531) by debbugs.gnu.org; 25 Oct 2023 14:02:34 +0000 Received: from localhost ([127.0.0.1]:59725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveSn-0003gX-Vg for submit@debbugs.gnu.org; Wed, 25 Oct 2023 10:02:34 -0400 Received: from sonic314-13.consmr.mail.bf2.yahoo.com ([74.6.132.123]:40105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveSk-0003gI-Sx for 66531@debbugs.gnu.org; Wed, 25 Oct 2023 10:02:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698242506; bh=oosYU0reBa6YPYsM+Px6rgqmYz+vG5EZbQ6zKAKE9Hk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=dBC77cEw+uRbr0fB4xZPIgt36ICWvSkSKT0eW+nMTRH1lkWUohQY4K5cuZN1PqD6FtSgcQl6KtvEqNbQC/zDhmiE8x2X5AU65IJiqVHqxhDoWdmMoz1qBupWIxWpTgoURuInWLHdLgoCUmukA/K+5VZ8uQBun9YxS3zJdSnAT9HOyRqNRSUBIsbrOXcxrV7junA/Ie1n+/iVqa0LZueDj6cxLJr2pCMgix4DESZ7lqdr3hkcwxedjhERs6JjHyXKr1BQvQJgIwB+JtyWz6KyMandF6+ajsXFWaLaQmkPGZWG9NrMJy96UJk7COG+UhsgtXJWhtGjVH9p4yGpbjlakQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1698242506; bh=I7lKmrfa6qn4b7ANeRZQ/ev7rRQ8xwW3I61qe7h6eM7=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=j72/yHY6/yGEpSTo5FqRI9wApEy2ghqkOb8OJuo+zKuc0qw+46rzATLUELv3kF+ubc0SX3QJVNBHPBh2fZvudDVEXL+ypKwn0Nb8l0K9YrSY20FfOi61T9UMdw/rqS6MUIZ9kI8+ODfGTb8t7eTsvGjcyMHmCFGDF1DogHQ+Z3LsVhxjDJ+lvE5uAION1knei8a8xRZBUF1jXO6G2yakt/ll20r0Rb7UB50ynb8OQpSDxSf6673MaHfi0JOqDzRiV5FlyzzC0LLrHhKsvHTMdF5Vt/yShWWEmQUb9L0+fMKv52a3X+XZg0UmXfqj3+u8q1AAekLeXdI7prKIx0h1ug== X-YMail-OSG: UeCfebsVM1nAndXIGINYS3Ke9IlsgwHNg.aOL5mitQIZldFsHKUrZixxpbGPC2E yHF1DprqetkvnSYPftkVM4oOnW31awjDRKVTQ8KZ4dA._7g0qZXNaLa4LGFY9zJdQsmR4TF7SONl KtTcIS5qLqb.VOS5RSO5b7o4KFVJvUeqrT3.GLpwvCvMCz2ZQP37lPMoYIDlw5C3exOYNsInYEEF iCuuyk6tQBPgs8BxPhgysw1yEPR_jdaLQm9JSEIt9Ih6UlrYN_2vb1nTP9F1EObh6YYLkjE9xJXD tbxn3xjWpZ44k4XK_AvXTkGYZTfa7oVHr06pw8xf9lBbVl4kiCY2R.hDHdnO2I4rsLkTEsTIBbni i4FvFfoX0gVOM5TtaX3X9ZXHZ5LfNx9GFZmhUmdIntl8OfBBdaqeT_RVJZ6kJbE.z0UyetxlRdXN MPnBkqUxhi1MmzmZfFXdhoEFyRZGokVZwh7lqimJ4FApyc75l0sEgVelPnz9P0KHD0rEcJzFbUQA NQ7tEA7WVmV68aTRNEpjLWNnTA5zBb0nT6EH9FqrhwHf7fZxNRqXHqRqEHgoWz.S1ayYLbYWaEZ1 gsKU1zOhemd1Vn73j7BgQB4zWxrONhQxS376sdiCBMorES5HI060KJnuPQ_Ql3VJhXTRhXDWexzZ mX8Cd_5JRDK9R2AwCkpHBde7uP.xo4aFKHtPSMU3ITF7JeAckwI0gac6ObPY6rWIjPggcVkxNflu 5JEBpPL5XALzPUz2AMXV5U2.uBGUOkkSgygUKNYhQsghe2Gm9UBUe21HY1bLV3p3gHoAT1VI.MC0 IXtgiaHa05R8emOdpXLIA3KRsa6APQyeLVxyTxUsWwZk7ldemENcUOzPwYAkBcfWYsNNwYGukdvE CT._xT5n9_K8vxYerkGl57i2LsKhcVpHDG7uNTmtpuhnkN7RoHH.kvwQgDb6B9aOG5CrfaSZ0Vuw udJ7hNZzQ53jlwpNY3bwL638FV.39PaaLw_gn5V5Vlu8mp6Gcs.l2rXLsCX0_BpBOEimaijN3_f7 hCXgf4XTFycE6D9QRmonZAZ.Uwzmw0IEVqojkJ.YPhEEBffM0TQ9g3ZxvLAF7OB0pILkWPueKje0 RnTSvQaIuHyqyJRTJfkz1AfW3h1h9aO1gPSaL37qa84vsYYFLEy43jh4d23Lrf3regmppWa_jPZl radpqzCz74gaCLcHq59yTGc7xErf_2wuP.dPZHQ9N.m3W2YS33kDDo4jS3NbVA8xTHmXblb3v2Fp EKlp_9KCHK.KBI14yTjR_f.nu7AwVtIcuNUD2JLrM56rbN.T01gmrkLgEuC7q88lORPQ96EBVYUv N8pdl8RXQgKdam69BWfRIxvMu6Nyl7Tfj4S_H7vayMnV7kyG_X08Hz_4Pi7u6lwzHMGRE3tjsAOO CU.grx_YDGg22H8rqf65fCJgYF5MF6lUocLwag8psJ9qb62eAwelKo_fiC0HDI6YdGO2Ed8atDfM D2Cqodq3SBuO2QUUpHssbrAMDeeiabuW0OZwXloUnz.MrMRTN3wyvUbf5zk73iRjZqq.FbwiayW9 MINZ49T.uBzwUrpjVPAWwSoDzQ_bF5IPr4uzHs3DDH0OqWaXMDzh_bZyPcg84cgnkN1Zw2T7s5mc TJ.RNqB08FHp7JWoyyfQFEVPqE3WkrHUAdcGDUHsaD52Hqe7ubD0FEzqAjWhsCELsnGBznSPS06a 3koCJvbe5tu5wIttCNZcEHzpZEBUnrEfSMVAj2cPNNMS5P6xu0Xp7cOZYB_fUHMz2mVrFORYacy1 b3dnCH87u9LVdRYqzIbaBrb_ekB8DSUT2dftJiQcz0dhZDJ2I06S9RFktpc7EvLlIWCrEt.Bvsfz 6Nb7fBEw2KSItZSjp92KIokdo6AOz3H36HsTQLyi0td8gkK3aTh2U2L2F8VBsOQiLK9dpfrUS30H VGSE.7BeY7Lu9ODHYFAbdshS4KPhNUA2a7kF0oS3VXNK9Rh2mwTmjOhEHnZGTUWpF7hPhheAdeDU TuuDiFCvX07YcaC3gBnCTTJZSUuqFWhW.97i19t6_bWLDyb5LiO3XwoRSFpQFK2MVOnBCXUcGJTJ FKoPtaVyCatBA8abtLgPeVA7AgYye88fy3BUkVuMkbR_Og4eZGik3mVthumScVhnqYM9YG.8M4cE MVfJ1mq.S1cEeAgBU5f1yjcfSvZRC.DOm.LUn9tpsFld5AtEYv1zHcOKFtdi9ENAeJKMJzAvwuI2 X_kmbPPlj8FDlStgy2xSy5u72idcHDdNFrCnOr6PomJAleRNhv3EjJEFwAYpjONE- X-Sonic-MF: X-Sonic-ID: 1a264ea9-8781-47ca-a832-3ea9c838c9b8 Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.bf2.yahoo.com with HTTP; Wed, 25 Oct 2023 14:01:46 +0000 Date: Wed, 25 Oct 2023 14:01:43 +0000 (UTC) From: Mike Gran Message-ID: <1644276721.1249459.1698242503726@mail.yahoo.com> In-Reply-To: References: <20231013161811.19233-1-wolf@wolfsden.cz> <458374241.8000448.1697218206032@mail.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21797 YMailNorrin Content-Length: 1004 X-Spam-Score: -0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I haven't forgotten about this. My linux devel box died. Maybe someone else can make the push, otherwise, I'll be back in business i= n a couple weeks. On Friday, October 13, 2023 at 11:20:11 AM PDT, Tomas Volf wrote:=20 On 2023-10-13 17:30:06 +0000, Mike Gran wrote: > > Both macros were missing a quote for the procedure call, causing the > > actual return value to be compiled into the ftw.go, instead of the > >procedure call.=C2=A0 Snippet from disassembly of ftw.go does confirm th= at: >=20 > Looks good to me. >=20 > If you don't have commit approval, I can take the action to commit it, > and write a test case, since I was the one who broke it back in 2021. I do not have commit access, nor I am sure how the tests should look like, so if you would be so kind to take it over from here, that would be great. :) >=20 > Mike Gran Tomas Volf --=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. From unknown Tue Jun 17 01:37:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 29 Nov 2023 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Mike Gran Cc: "66531@debbugs.gnu.org" <66531@debbugs.gnu.org> Received: via spool by 66531-submit@debbugs.gnu.org id=B66531.17012779498125 (code B ref 66531); Wed, 29 Nov 2023 17:13:02 +0000 Received: (at 66531) by debbugs.gnu.org; 29 Nov 2023 17:12:29 +0000 Received: from localhost ([127.0.0.1]:50993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8O6u-00026y-Nm for submit@debbugs.gnu.org; Wed, 29 Nov 2023 12:12:29 -0500 Received: from wolfsden.cz ([37.205.8.62]:51326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8NAK-0000LA-FM for 66531@debbugs.gnu.org; Wed, 29 Nov 2023 11:11:59 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 06C8525FF52; Wed, 29 Nov 2023 16:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1701274307; bh=cALcL67dBdVTKXIm7wzMTs1zKBaisJH1DZ00aDCQj+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Gco+z3Wc/wNPd2r1T1IfWu4eGX5mWMv1BfYUbXJ10Se2UQmbsVwTy/Moq9r4dIZrF 3IDNZm8mfrDAhg/fCmUiFr7pYqMSMQkHz7KSCPKHDLTdRyAHCXYJyXS8R5fKayHvkc +T8bHaeBvGnf50f4egLKpyFKzzkviS2iPt/BuaPISZJOqOyAcLVO4BVMsyC2zGuec/ fVwoIwxQhwIfN3jQ7G7zi9ImPZPUXM46mWHNzPIijcQkM92Jmb8QrjgrYWDrp/UE2Z lxhUbgFXiLO/aNhdEAbmNbemYn5YXvJDN4kQLodJWv06o0fvneV4OORAXws1n12jli s2KD+hEaSy2jR2O0bKxMUqUSgS4B1HsRhF2tMvcNhehHOkwZbbRO/NCOtGu717CmXp 7rIZbD9t6Ovqg9lL5sd5eSmUGZb1WLUAlr0m0lNudgk/dvj87sesriz4swgUXNnh2Z C0GHv0LGQa/Vo3+00nh0ISJKwI9tALMgLTLUcTHfQ6SLmaNgLqxu/DaKI6HJAXUq/W r/FLGMd1pv/iPmsG3UlrLGi+CoQreS/ELdFXWoVbUXtGeNhh97ei1WL9d/GE0gz8Jc p+Yc69XuIwqvnK5PXVcBM/ZGopEtpX/q2o6+hMdVYOW+WrmZc4SGPM1YeuVjuER1ge gO/q3VNt4PxlKwIkjHuzreWg= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost (unknown [81.17.16.69]) by wolfsden.cz (Postfix) with ESMTPSA id 0A48226138A; Wed, 29 Nov 2023 16:11:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1701274306; bh=cALcL67dBdVTKXIm7wzMTs1zKBaisJH1DZ00aDCQj+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=xqdUSw7s0R2DQpZCc1OacPJ9W1qdOhUPdDEYsMxdBfq/gIh8IJiyLrhiI/kClje6V VkAJY7btYX+g/m9ahXAVLulWP7zDsgk4TODrxCP6ymzulnEzmqQAPhLIOKdrMNBshW fAQ0TSTtlEYlO7ZC7r6ylbwdido0db4sMMQLdaIRFxZTVJpK/GSo9dHRPau0uoD6JG OzW84cXLvVw1KnNhRcoTy7mTAKwxzyn+Bd8ExY9AMypViZvgdI/DEYhenMnM39Ou4G 5f4C0Cft0DSBHEa7hBwIKI8fAeEHQjISAjH0Tavo/vdiQlaM9jD0X6VjajTKjA/x+g JG4NcxHWzyqIi7Jpmu/DddfmkMuic9GWaag6HpntQ1vVDQ8skpB9iCYBg3xeWuyRe1 8mO0BKzQ497/yvCJyyNtp5oJQmfolsBZ77BH2c/r96qGiFh85fY+yQU+r4r+iUBRK0 oWVO/uMYtKGCDTDEv/3GgZWDZHOVS2LE7TSvEZ02p3HadLxNSuJ2N93pyVZYOe/+Dz W9v6IApjUQ4Q1j08eFj8BFWoUFbUh7c/3+Frn4OfrAI3KItDqjACsTndsYRadFQ39p XmGJQa+oEr1SERgFoJ++YiwFOKAyw6in+iiDb+1bFV91u/oXAu2pwYrhmpyMBDsyXs PlSMZpJD/k2/1JgtmiXiu1Yg= Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ba1b062b; Wed, 29 Nov 2023 16:11:45 +0000 (UTC) Date: Wed, 29 Nov 2023 17:11:45 +0100 From: Tomas Volf <~@wolfsden.cz> Message-ID: References: <20231013161811.19233-1-wolf@wolfsden.cz> <458374241.8000448.1697218206032@mail.yahoo.com> <1644276721.1249459.1698242503726@mail.yahoo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FzAwB/ed3OKVyqYO" Content-Disposition: inline In-Reply-To: <1644276721.1249459.1698242503726@mail.yahoo.com> X-Spam-Score: 0.2 (/) X-Mailman-Approved-At: Wed, 29 Nov 2023 12:12:27 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --FzAwB/ed3OKVyqYO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On 2023-10-25 14:01:43 +0000, Mike Gran wrote: > I haven't forgotten about this. My linux devel box died. My deepest sympathies. > > Maybe someone else can make the push, otherwise, I'll be back in business in a couple weeks. Polite ping, just making sure this is still on the radar. Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --FzAwB/ed3OKVyqYO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmVnYsEACgkQL7/ufbZ/ wakN5Q/+KA01MEw4X9nIZHczjaYjJLzfPjBiQY2z2tE+RBIP8W5dfsa+r+saFGuI QcE+xD3nfnz65lt3bVXVF9t15rpjd76azMzMzpOQDi37T24yECENoNxxDQGHYhPW FKqMkuCTJkazK0+mQ5CHFyLUA84gFJ8rLVcul63RP8lc7q03lTBxRr9ma52NH0mH D/Ce7yMjA7xxtQaHcpL4TH174ans3/rUO0x//amd/NVdAjko5z+owA3llNPmm8OC J2mZhXc9fWhoqO84GsuNd20bozbmF6+b4A00NoO1BJHhWBbhG34rDlW6Iju8JFFF ux2rK4Os+xBQFz3E7sT73P2OdWPV4yrh6pQV1/5P9a/TdzfcoxA19fEj8WgX4OUP /jzsEi+kD9tpexcHeHXSNNtmDCNjPMg5K8TkuuoMsK8w8lP2um5/CgCaypWTnEBl kiY+Y65jcFSdhTRVaGsS+D+GRecd4PwPDFHij4JJFqSsGTwypc5JdpqySIh9hETJ 7l94RIY4NHGPQqcEkpoBq2NMjkdGONkhRUvkjfwTDHaxnldIIrDNZ3jUttgyB2ep 5k2SH+Bu226oSoGs14ZBI3vpfaIBCEIVne2v+UogJcO9zcANzG8Cdgc42z51j23R ORRejeNm7OZqWMGOqYAlFsEnAiuBY/tNQQAt6d8qdE/t1Yg8UFk= =29HK -----END PGP SIGNATURE----- --FzAwB/ed3OKVyqYO-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 09 11:57:45 2024 Received: (at control) by debbugs.gnu.org; 9 Jan 2024 16:57:45 +0000 Received: from localhost ([127.0.0.1]:40788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNFQ8-0006p5-QC for submit@debbugs.gnu.org; Tue, 09 Jan 2024 11:57:44 -0500 Received: from wolfsden.cz ([37.205.8.62]:50748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rNFQ3-0006op-Qf for control@debbugs.gnu.org; Tue, 09 Jan 2024 11:57:43 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id B272A24D43F; Tue, 9 Jan 2024 16:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704819451; bh=GR2IFv0YlflU6yuopJuAgX4b2E9Puog7Gw24j28w5QI=; h=Date:To:From:Subject; b=aatmiCHssDdbwzVpUVnKz0m5RPb5BhDoCUt2qDcNWlFVpIoumsc7buvjzsI94QYUw QM+dAZ0lCe0KXYfxIZGYCWKpVl+jSDq70sS/f39FerNBEyvqSmshdwnW6rTn17MZDw FpLglKmJUKHfMDfGWw0Ttu2idmFxMGxfnz9XP22CWVcs7Zans0Xmu0/pGZHu5oVEUd 6vY91C/Yfh4I0KgjoPWaGWA7PQA9KsMFwTLccEP8ttFSNrVyugHabIyafQ/yItYMze 16KH3ej8hM0HGnWQsqWyhhD2aVe9Sa5E+oVLjH8n9Y8qWtD7jtm4gBTa9yQVs0ssAG /GPWFgO/8wY9Ws0aUVRYYZ5s2o35qYA4T4T+1O69GrY76SP3yIAbXhaojnO02Zo870 kd3NRWqsEqzDxBM2W6x7DaDkP5mL+ZnZayHhBFeSss7PdyXhXSCHU8bYSlY1Xh1v/l lbZwVt2m61RPKl+8KYEqA6KDa8c7JcrELTy9V0q4pDbzcjQLnCBhxKvZ2TeE7qfbTU ynYUIAreL7zmJfEYEXJz9u/m7hiiEye8pRbgciIM2G2CIvdPOMnz/S5uQK007bwy6N DGYCSQWnNFEXJCUeNSNQIqKZ6clgGKiMZghcjIQCjZY1N2s6+ZiGXzJtK2rbgupkY3 Ungba7j/A4v8kOVbEwBgnZRY= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [146.70.134.143]) by wolfsden.cz (Postfix) with ESMTPSA id 8224724E200 for ; Tue, 9 Jan 2024 16:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1704819450; bh=GR2IFv0YlflU6yuopJuAgX4b2E9Puog7Gw24j28w5QI=; h=Date:To:From:Subject; b=jFF0GfCcpfDcgz5QtlCsK20LYlUkS9RXbtmlxo0QhKKTyvvQrlsD+UeH6DKjw7KwN 5YKM4Y6mHrjauU5/ccxIoISTSDvfIFXp6g8b/McTl7bZFLzQAPvGvl/yFR0OddJ4UA AS/NVET480X32hZw1710GpDMgBMm26XmB2eAVQERF4jMeVF+xj+1jyrYmeC2VFzaAO Pzz2vt7QzVyS3N7vEBDEZXUVkIIAuRpHu7I369jBhymQqYsaAuDuPFSHGOLnoyGcqk zzLLHMXCEIuE+a3ORNN6IV/IheIRN8WaP3uuCYaRDxHoidllqIlQkvjQaL3+FUJFjM CkXksGnFI4HNRkasIjwpCF4VpGBM1D4E6o3kTrQV868PWLL1FBh5/khbJ7SLJMGjWR W/k7qh2hw78j3c/55mm/NkI3CAK26xDkBJ04FceFrAc4uzj6HuMidrYsEe7t1x0U0M U7E0nx+tXEzZA7mr+/wfS552eeUHMsPz5uDQEfVW4oXiUcX/T56QWKfUsex33MAWmi EPLzFbGJtku/rgvovOT9C1DPJeGoRpHotJgHRnKXfroNbhr+u3bGUNdd5qeuMK5IW5 eOYdG5juQC+7Yp7YBjjNjHYSVdA9V2IPbvVt0YFXvD407rQLRKoUh9YzXoWM2hsI1/ +9aeY35O2zqCSkc4n6Dt1xt4= Date: Tue, 09 Jan 2024 17:57:30 +0100 Message-ID: To: control@debbugs.gnu.org From: Tomas Volf <~@wolfsden.cz> Subject: control message for bug #66531 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) submitter 66531 ! quit From unknown Tue Jun 17 01:37:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros., bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros., control message for bug #66531 Resent-From: Tomas Volf <~@wolfsden.cz> Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 16 Jan 2024 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66531 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch To: Mike Gran Cc: Tomas Volf , control@debbugs.gnu.org, 66531@debbugs.gnu.org Received: via spool by 66531-submit@debbugs.gnu.org id=B66531.17054088475781 (code B ref 66531); Tue, 16 Jan 2024 12:41:02 +0000 Received: (at 66531) by debbugs.gnu.org; 16 Jan 2024 12:40:47 +0000 Received: from localhost ([127.0.0.1]:48029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rPikJ-0001V9-DQ for submit@debbugs.gnu.org; Tue, 16 Jan 2024 07:40:47 -0500 Received: from wolfsden.cz ([37.205.8.62]:59760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rPikG-0001Uu-NS; Tue, 16 Jan 2024 07:40:45 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 39D66252A6C; Tue, 16 Jan 2024 12:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705408842; bh=XI2B7rKTA03yITGHKbu1fpoi+vpF3zHDJiMobOSmwDE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=WdgFhHX95+mRKHt+vqvtvyV8qGqj4x0teP0KDPX+7ghHBkg6m19O2FMgFbjxXhgm0 2oOEaKxninsHNK23fv0+qkleduavyiq7p/FOWQbySqzyB2qgMhqnF/EBNt8pKpfr82 jrPirpLyHaim7Za3+tA7jT7spLUFgD607N/DskSDK1muDgNol4HDTLrI7JbEHhY3mP 5hXvvmr/043OH/hv4pO8EZfywq+TSXYy8i1h5AJ3iRl42ASgPHniTaS96MH0e7Qn4Q EfS8S2+6RgejutbGguud36p/P8bqV+iE5Jy7Sd/K1Wwtjkc9Ny36E5z8yyZ3gArkef LMYWtjC+udC6/UWm+zgC39m1/00x0gQdXRcxUjJW2HRkwFDCaSNjAi4hifQzJDzCJS 09HLo7xEftOHnO7FzBKJc0OBT2XR6gEi+ny/V3Utk4Gt1z4dx2rGIsAC4yK8WKKziT pyOlqWrduCG4HMaT9iojA8mtRtTU424FSLgiGnMdTDB6MmSw4Zw3SgtNX/KTExSJhd WxbB9zq2P+ya1zXPgn/S0y0lcvEX3Py/F+xPiQK58ZNJ0izlNKzU8goHIRZD6vEwcc qN9iQOcWGMzqU7CFGvgGzeCmjmiVyCIuS2xRwpaaeE+WB8ihVyIVxhrhGkn7woRmiW G8SgsI2JYeT8SP6kBr4jm93w= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [81.17.16.72]) by wolfsden.cz (Postfix) with ESMTPSA id BCAFA2528E0; Tue, 16 Jan 2024 12:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1705408841; bh=XI2B7rKTA03yITGHKbu1fpoi+vpF3zHDJiMobOSmwDE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=a4YQlVMJBB2ag16MkIsNL+FkUHDcv+A0QDze0yM4XPSXUIJTbu6CDS6VuqOTg4xdx ijG9S2/Yvop/Mt41XCBfHvfYyyGb32Cr0hz4MVw73QgzKpGCTRxXWRX9ft40zdahkn NN0nV0Y72yUbWuE/SGYkFdkg3a8QoFp92cb/X/T9++LxwoZq1EWU5ksmQ/I5qOu2UR jZ1FHTjkzdxXvhyz6dianRIGId4vppqi3wdfWW4jR9mudZHdG9k/1iSXb/XpbBHXfh WQanUqSqcRHQGr7iu0c18R6Brn+SxpkRp+pbzBas1uJ7hjDNecgLJ4NFw7bvDDznvt JU5Ebr7gbkwjecyvp4bKtDaoQ13TntWFqK0OSLvG0mymxhE9KmmZvxevhXAyYjOpQs nCMSyTF3PBNJ+hu4IsoOOAfOAXhzlaB5QgKz6a6tlUDidAvAK/l6jizMPVXlAsM2s0 gF68kT9rdTj07bgKLDDilTVodYaYAuzE+PUCX56mXdaqtJR6cRJuPaptWAADnruTTz LPrxRjO8XQXvpFPubLlkugbQY2w4h1PrxJYiVFis8vCwdMLr4TlnvBlrhD0nhZrARC spliI3kccpUSF2roeu46qpEbBI/QMJvXKkqMkWHa3JwIkPLpyWtoFJCpE7U0zaY3XA IwdTm22FjRPDQkM7c7AK7vDY= From: Tomas Volf <~@wolfsden.cz> In-Reply-To: <1644276721.1249459.1698242503726@mail.yahoo.com> (Mike Gran's message of "Wed, 25 Oct 2023 14:01:43 +0000 (UTC), Wed, 29 Nov 2023 17:11:45 +0100, Tue, 09 Jan 2024 17:57:30 +0100") References: <20231013161811.19233-1-wolf@wolfsden.cz> <458374241.8000448.1697218206032@mail.yahoo.com> <20231013161811.19233-1-wolf@wolfsden.cz> <458374241.8000448.1697218206032@mail.yahoo.com> <1644276721.1249459.1698242503726@mail.yahoo.com> <1644276721.1249459.1698242503726@mail.yahoo.com> Date: Tue, 16 Jan 2024 13:40:40 +0100 Message-ID: <878r4psb7b.fsf@wolfsden.cz> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mike Gran writes: Hello, > I haven't forgotten about this. My linux devel box died. > > Maybe someone else can make the push, otherwise, I'll be back in business in a couple weeks. Just a polite ping regarding this patch. Thank you and have a nice day, Tomas Volf From unknown Tue Jun 17 01:37:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tomas Volf <~@wolfsden.cz> Subject: bug#66531: closed (Re: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros.) Message-ID: References: <87r0i0p8ub.fsf@gnu.org> <20231013161811.19233-1-wolf@wolfsden.cz> X-Gnu-PR-Message: they-closed 66531 X-Gnu-PR-Package: guile X-Gnu-PR-Keywords: patch Reply-To: 66531@debbugs.gnu.org Date: Mon, 29 Jan 2024 13:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1706535002-14107-1" This is a multi-part message in MIME format... ------------=_1706535002-14107-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. which was filed against the guile package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66531@debbugs.gnu.org. --=20 66531: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66531 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1706535002-14107-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66531-done) by debbugs.gnu.org; 29 Jan 2024 13:29:08 +0000 Received: from localhost ([127.0.0.1]:59312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rURhE-0003dm-BH for submit@debbugs.gnu.org; Mon, 29 Jan 2024 08:29:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rURhC-0003dE-NI for 66531-done@debbugs.gnu.org; Mon, 29 Jan 2024 08:29:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rURgt-0005py-Cx; Mon, 29 Jan 2024 08:28:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Yrry/7cVioTvhBpnISdD8VcMRv+2z7m/Ugh5xF0p2uA=; b=ehG1OQ7/AtgmI7zuvYeY 65M46TiRKchKMuUJ49WyE7VP6dYONIRH0vz8pmPSyD6eetvvwcERa32t55BcD2pjzwFAdN8k8MX6D 0RQr9Gx1rnzd8+UERLej3wSX0wxl/MLKIH4hzKEvvBht/iYydyUIn7P9Xhieq9iPoEf7pDLVsMMl/ 3omvggNsJR7EwAvqfqqAdurYnlQ77rUfAwqkqTxSeKpZPJ03HuLmmtrSM0r9fQoqXVcdSArdDR7uX Nd9LjdfbWsemEKYqn1dhZqwuO2PhV4ZjbfOLSlQf3L0NXEvw3c9yRbQoAeh4FOOZaOiKIi08LVzxw zTSTGvt57Ayx4A==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tomas Volf Subject: Re: bug#66531: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. In-Reply-To: <20231013161811.19233-1-wolf@wolfsden.cz> (Tomas Volf's message of "Fri, 13 Oct 2023 18:18:11 +0200") References: <20231013161811.19233-1-wolf@wolfsden.cz> Date: Mon, 29 Jan 2024 14:28:28 +0100 Message-ID: <87r0i0p8ub.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66531-done Cc: 66531-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Tomas Volf skribis: > Both macros were missing a quote for the procedure call, causing the > actual return value to be compiled into the ftw.go, instead of the > procedure call. Snippet from disassembly of ftw.go does confirm that: > > 55 (make-immediate 2 3990) ;; 997 at ice-9/ftw.scm:319:46 > 56 (make-long-immediate 1 120002) ;; 30000 at ice-9/ftw.scm:320:46 > > That effectively prevented ftw from entering directories without access > for others. Simple reproduction: > > scheme@(guile-user)> ,use (ice-9 ftw) > scheme@(guile-user)> (mkdir "/tmp/xxxx") > scheme@(guile-user)> (chmod "/tmp/xxxx" #o0700) > scheme@(guile-user)> (ftw "/tmp/xxxx" (lambda (_ __ f) (pk f) #t)) > > ;;; (directory-not-readable) > $1 = #t > scheme@(guile-user)> (system "ls -al /tmp/xxxx") > total 0 > drwx------ 1 wolf wolf 0 Oct 11 22:54 . > drwxrwxrwt 1 root root 888 Oct 11 22:54 .. > $2 = 0 > > The fix is to quote the procedure call, leading to the intended > behavior. > > This fixes bug 55344. > > * module/ice-9/ftw.scm (getuid-or-false): Quote the (getuid). > (getgid-or-false): Quote the (getgid). Applied, thanks! ------------=_1706535002-14107-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Oct 2023 16:18:58 +0000 Received: from localhost ([127.0.0.1]:47300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrKsM-0005OM-2A for submit@debbugs.gnu.org; Fri, 13 Oct 2023 12:18:58 -0400 Received: from lists.gnu.org ([2001:470:142::17]:35272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrKsJ-0005O8-AZ for submit@debbugs.gnu.org; Fri, 13 Oct 2023 12:18:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrKrp-0006sb-IY for bug-guile@gnu.org; Fri, 13 Oct 2023 12:18:26 -0400 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrKrn-00039e-1Q for bug-guile@gnu.org; Fri, 13 Oct 2023 12:18:25 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id EF67A26B373; Fri, 13 Oct 2023 16:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697213897; bh=j+nWa6+Rigc76UQWflcDcQwvt8kaZiYFMDPC85JI/pU=; h=From:To:Cc:Subject:Date; b=oYb/Y1nVlO3jLt7hNNHFvLdoCyX6tfpJLnqyXMvOae/0nnpk2+/l4fBcxq/KDZstH rhOsh2ZQY1c30gZsk2H/pCE3+b66zEtGpwelEQFsGdt1ocBndWWTuZcezy5aG6fCUr 3uyNKNekGC2M45cfv73mbZIjfUFVkqKFHt6s9zICb0qugV48fHQdC5PhLSseLuHLMb xnc+bUjxvxJ+lC/5unmcqQAuqfGEc8nlIuIqrH61n1AFM9xeLuA2BhcSY7Azo2J5yD aFNEBsy4y/W0125jvZkk1LQz7C/BihfHkMrb2hZq+QhpxWfCikXGg7M/2Q761zkFwe P5z8ImrhRBzE48PmU61JjHvDVWZP+2MjNzj9bZHd8xz19Jun++VdMzw4aIOZ2qe7pS U8t0NxjpBLNiLPJOx8eo/nwLpguK6DQ9ZlnIYQJBWTPKFoJCd0ctRcUvrjS6oT29bE DwdVovjz0K2WNWGsO0vCo17TeZkYYDRYh9Eo8GbwJrdkgcscab6zAf5r2Bbyoqc7FN H9NDc6ppekgLGFhqAwi1cdLybriZNcYVS4LWwL4WcsAz2uyNW+XFcZDkuezNnaksWk bZBColiqSJ5xwdW5oKGlIDic0auITh+xArapAL++1s8VsY98keI+yYxg/u9/G3VAgP p7ykBCeALIf/yi2xbfh9/sRY= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost (unknown [81.17.16.88]) by wolfsden.cz (Postfix) with ESMTPSA id 0F89926B4E1; Fri, 13 Oct 2023 16:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1697213897; bh=j+nWa6+Rigc76UQWflcDcQwvt8kaZiYFMDPC85JI/pU=; h=From:To:Cc:Subject:Date; b=oYb/Y1nVlO3jLt7hNNHFvLdoCyX6tfpJLnqyXMvOae/0nnpk2+/l4fBcxq/KDZstH rhOsh2ZQY1c30gZsk2H/pCE3+b66zEtGpwelEQFsGdt1ocBndWWTuZcezy5aG6fCUr 3uyNKNekGC2M45cfv73mbZIjfUFVkqKFHt6s9zICb0qugV48fHQdC5PhLSseLuHLMb xnc+bUjxvxJ+lC/5unmcqQAuqfGEc8nlIuIqrH61n1AFM9xeLuA2BhcSY7Azo2J5yD aFNEBsy4y/W0125jvZkk1LQz7C/BihfHkMrb2hZq+QhpxWfCikXGg7M/2Q761zkFwe P5z8ImrhRBzE48PmU61JjHvDVWZP+2MjNzj9bZHd8xz19Jun++VdMzw4aIOZ2qe7pS U8t0NxjpBLNiLPJOx8eo/nwLpguK6DQ9ZlnIYQJBWTPKFoJCd0ctRcUvrjS6oT29bE DwdVovjz0K2WNWGsO0vCo17TeZkYYDRYh9Eo8GbwJrdkgcscab6zAf5r2Bbyoqc7FN H9NDc6ppekgLGFhqAwi1cdLybriZNcYVS4LWwL4WcsAz2uyNW+XFcZDkuezNnaksWk bZBColiqSJ5xwdW5oKGlIDic0auITh+xArapAL++1s8VsY98keI+yYxg/u9/G3VAgP p7ykBCeALIf/yi2xbfh9/sRY= Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b04980c0; Fri, 13 Oct 2023 16:18:15 +0000 (UTC) From: Tomas Volf To: bug-guile@gnu.org Subject: [PATCH] ftw: Fix getuid-or-false, getgid-or-false macros. Date: Fri, 13 Oct 2023 18:18:11 +0200 Message-ID: <20231013161811.19233-1-wolf@wolfsden.cz> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=37.205.8.62; envelope-from=ws@wolfsnet.cz; helo=wolfsden.cz X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_NONE=0.001, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit Cc: Tomas Volf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Both macros were missing a quote for the procedure call, causing the actual return value to be compiled into the ftw.go, instead of the procedure call. Snippet from disassembly of ftw.go does confirm that: 55 (make-immediate 2 3990) ;; 997 at ice-9/ftw.scm:319:46 56 (make-long-immediate 1 120002) ;; 30000 at ice-9/ftw.scm:320:46 That effectively prevented ftw from entering directories without access for others. Simple reproduction: scheme@(guile-user)> ,use (ice-9 ftw) scheme@(guile-user)> (mkdir "/tmp/xxxx") scheme@(guile-user)> (chmod "/tmp/xxxx" #o0700) scheme@(guile-user)> (ftw "/tmp/xxxx" (lambda (_ __ f) (pk f) #t)) ;;; (directory-not-readable) $1 = #t scheme@(guile-user)> (system "ls -al /tmp/xxxx") total 0 drwx------ 1 wolf wolf 0 Oct 11 22:54 . drwxrwxrwt 1 root root 888 Oct 11 22:54 .. $2 = 0 The fix is to quote the procedure call, leading to the intended behavior. This fixes bug 55344. * module/ice-9/ftw.scm (getuid-or-false): Quote the (getuid). (getgid-or-false): Quote the (getgid). --- module/ice-9/ftw.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/module/ice-9/ftw.scm b/module/ice-9/ftw.scm index ac6aa6316..8496086a1 100644 --- a/module/ice-9/ftw.scm +++ b/module/ice-9/ftw.scm @@ -201,12 +201,12 @@ (define-macro (getuid-or-false) (if (defined? 'getuid) - (getuid) + '(getuid) #f)) (define-macro (getgid-or-false) (if (defined? 'getgid) - (getgid) + '(getgid) #f)) (define (directory-files dir) -- 2.41.0 ------------=_1706535002-14107-1--