From unknown Sat Sep 20 18:41:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66520: 30.0.50; Small issues with defcustoms in ERC Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2023 13:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 66520@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169720402721112 (code B ref -1); Fri, 13 Oct 2023 13:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Oct 2023 13:33:47 +0000 Received: from localhost ([127.0.0.1]:45492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrIIV-0005US-74 for submit@debbugs.gnu.org; Fri, 13 Oct 2023 09:33:47 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrIIS-0005UE-R7 for submit@debbugs.gnu.org; Fri, 13 Oct 2023 09:33:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrII0-0005MO-5y for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2023 09:33:16 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrIHy-0002v8-3x for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2023 09:33:15 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-690ce3c55f1so1683390b3a.0 for ; Fri, 13 Oct 2023 06:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697203991; x=1697808791; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=hEhb8HS3DQyGCm044kYqSTNVXePFUSleGW/gWnj8Q8I=; b=T6SYtIQ19eRME3Lf0r9llRnN2kU4Wrhr0L1M5EaHV3EcnSfu9PZLjQ+hhDxLErnlgZ mXuC4YKVFNEtKr1Q7yqRd7qS1QYK/E85Z+Cxqj7BPop/V83F1ipFNLCEkpRPERuOrneO tM3VwJDBkHj/ALgtJbe6V3d5J4HPIo4HjJEZsg75b9hMF8vcyA7cu4xvOJKWTlQ6BA2T /kbnXBMjh/ZSz5WCCGBBrcysiQ6DEpGHistC1EfJkX85LtAI9OAbe3sWgbbfqJzeCqFA I1RmvJUm1c1Y+RpyY56isro4j+j//8Xm1EIlSCF3PvmjINM6VaXFWHKivthm7W3tlcQU 1RZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697203991; x=1697808791; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hEhb8HS3DQyGCm044kYqSTNVXePFUSleGW/gWnj8Q8I=; b=LpnkFwdrbys1561f9/I8EsCR4xgYYk08/tIW5QkyOTIldKZdCO0gSh1JkkjciKz9MM WpE8/M4sNPRYGfUJ+6G3f29t1wycy2R2nmz/BEjdLZGKm40D4u9VLCq3fChZWWZF+pzG 54ykXMuMZpyhBgc8yUh6zQjU9A8jrySzbecBc/AO+JFyoj1EXti32OXioM4Rm5dTKA9C UWZ2YePc3afUU/PAUZu/As7LaurNAoUYBUpYKHi77bwrd8/A1y+DPJsjqXAWcMlQWzZ8 w4jJ23rflr4LhQxjzPuZXTR+AXbaCV2gz71VM7SWY039TfrKAjUoK451LXyE0qIZ7ysB 5xyg== X-Gm-Message-State: AOJu0YxmrEFenX0pWYmOk1R7/yFCEFuc2RcTvaFSI4R8SLaUtJO5F6zB Qk3fNeK2AF0xuqyvcWWZbKQySRh8Dj290MZm X-Google-Smtp-Source: AGHT+IEMMxQo+jJ1mPObASpfRj2iZbXTXmRkEhcLH10n5hExAE5YOJAdtUYd7WWUS/ye86Hg0F5dww== X-Received: by 2002:a05:6a00:3906:b0:690:c75e:25d7 with SMTP id fh6-20020a056a00390600b00690c75e25d7mr26740144pfb.18.1697203991495; Fri, 13 Oct 2023 06:33:11 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id o4-20020a056a001b4400b006884549adc8sm13531045pfv.29.2023.10.13.06.33.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Oct 2023 06:33:11 -0700 (PDT) Message-ID: <7dbaca89-8e51-41d9-bb55-0cf51dbcd6cf@gmail.com> Date: Fri, 13 Oct 2023 10:33:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Mauro Aranda Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=maurooaranda@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Looking for defcustom docstrings and :type inconsistencies, I found the following in erc/: The docstring of erc-fill-variable-maximum-indentation says its value can be nil, but its :type is just integer. The choices in erc-keep-place-indicator-style look like a copy-pasta from erc-keep-place-indicator-buffer-type.  The docstring matches what the code checks, so I guess the choices are wrong. Finally, erc-networks-alist says that MATCHER can be either a regexp or a function.  But neither erc-determine-network (obsoleted) nor erc-networks--determine check to see if MATCHER is a function. So maybe that isn't supported? From unknown Sat Sep 20 18:41:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66520: 30.0.50; Small issues with defcustoms in ERC Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2023 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 66520@debbugs.gnu.org Received: via spool by 66520-submit@debbugs.gnu.org id=B66520.169720430221548 (code B ref 66520); Fri, 13 Oct 2023 13:39:01 +0000 Received: (at 66520) by debbugs.gnu.org; 13 Oct 2023 13:38:22 +0000 Received: from localhost ([127.0.0.1]:45499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrIMv-0005bT-RM for submit@debbugs.gnu.org; Fri, 13 Oct 2023 09:38:22 -0400 Received: from mail-il1-x12c.google.com ([2607:f8b0:4864:20::12c]:54322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrIMt-0005bA-2k; Fri, 13 Oct 2023 09:38:20 -0400 Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-352a3a95271so7541005ab.0; Fri, 13 Oct 2023 06:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697204270; x=1697809070; darn=debbugs.gnu.org; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=L4ZUoHD122SMmh8fE1DI4MLSMbj/NjmZP8RZLrFJi0U=; b=A7uADSWlzTmJdwh1oe43tvitwd5ykNWpj0icBd2ycpljjpq353hiAxcVsYpZx9QY1a BAy616K6Ll6f/IynKZavOUxjWPU/8GeQ+9Qxpegjc8HFNQ1+mCv5Uqaz9wEe8SgBXHfa d77AEbV/xEjzsrBjmiz70G1CVVgvxxq29BG3i3KsjCKJl8tIQyysH6L577YcBvc0chI3 jd/o3Bn8tAKu9ESVMvJP8/6brwmqPOaUYqgZJKC1VdZBoNujfI1qqeM8iK149Rh6+dOx Xqr2umwuiA1ydvb4QK1MdAIew8sH6KEGwMZ7FBZ9Y7qqctUvzDUu+INz8PdsUOQ3XRrk tIqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697204270; x=1697809070; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L4ZUoHD122SMmh8fE1DI4MLSMbj/NjmZP8RZLrFJi0U=; b=DxikHVKaXH0oIdqTvuNm+NCa+Tn/APGG9lyZyprU5I5dPmfOjIvgncMhtlR+wJR55m a90GTYHKm48GOYH4kmz5hHH9eqLJBGpPrr1g+DatpaV/JCxP006vSBXePfUyPUB87nC6 FmidU7Xek2a0VPP8N1nzXq8pnA2tGE+d/WROTB5Gcu0vJXgMCfX++0RYhsyhilYYfKJq MtS8dZWnP4En3njIlhrQLtn89KEZSNP0GDb9kxKH9VjnWQsNCxlG1TU1CoEtgxgUgQJF pqANOYZDo/cmWk6Cw3uq5r2AvB/T55vQo8HXYreYKhqGcSKHoundfvdfwuoi83XAS0Fu Cm3w== X-Gm-Message-State: AOJu0YyOJrnpTJ0V1gA3yegaILPl2QHXyEcvl5X+Y8/T64RGNbOoOdYi qR6oBVC8drFo2MvHkqWjidbEce+4cvU5Pbwa X-Google-Smtp-Source: AGHT+IG1yRW7sF30HS+uT/zozKpUxPgTaAwVZpwdMg04yfTbN6fAe+eZx2wkLQvYyLI7+DzGBFBFaA== X-Received: by 2002:a05:6e02:12b3:b0:34f:f0d9:5a1c with SMTP id f19-20020a056e0212b300b0034ff0d95a1cmr26142990ilr.15.1697204269842; Fri, 13 Oct 2023 06:37:49 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id w1-20020aa79541000000b006b287c0ed63sm1323219pfq.137.2023.10.13.06.37.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Oct 2023 06:37:49 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------4lLJuYcTZVxk7cdxNMNYKHgz" Message-ID: <04e68172-0d8f-42bf-bc40-9639a57ecc38@gmail.com> Date: Fri, 13 Oct 2023 10:37:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Mauro Aranda References: <7dbaca89-8e51-41d9-bb55-0cf51dbcd6cf@gmail.com> In-Reply-To: <7dbaca89-8e51-41d9-bb55-0cf51dbcd6cf@gmail.com> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------4lLJuYcTZVxk7cdxNMNYKHgz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit tags 66520 patch quit I attach a patch to fix these issues. Maybe I'm wrong about changing the docstring in erc-networks-alist. --------------4lLJuYcTZVxk7cdxNMNYKHgz Content-Type: text/x-patch; charset=UTF-8; name="0001-More-defcustom-fixes-in-ERC-Bug-66520.patch" Content-Disposition: attachment; filename="0001-More-defcustom-fixes-in-ERC-Bug-66520.patch" Content-Transfer-Encoding: base64 RnJvbSBmNjQ2NjRhNDIwMTY3MzhjMDM0YzVkY2JhYzYyMDY0YWFkZTRmM2U4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IEZyaSwgMTMgT2N0IDIwMjMgMTA6MzY6MjkgLTAzMDAKU3ViamVjdDog W1BBVENIXSBNb3JlIGRlZmN1c3RvbSBmaXhlcyBpbiBFUkMgKEJ1ZyM2NjUyMCkKCiogbGlz cC9lcmMvZXJjLWZpbGwuZWwgKGVyYy1maWxsLXZhcmlhYmxlLW1heGltdW0taW5kZW50YXRp b24pOiBDaGFuZ2UKOnR5cGUgdG8gY2hvaWNlLCB0byBhbGxvdyBuaWwuCiogbGlzcC9lcmMv ZXJjLWdvb2RpZXMuZWwgKGVyYy1rZWVwLXBsYWNlLWluZGljYXRvci1zdHlsZSk6IEZpeApj b3B5LXBhc3RhLgoqIGxpc3AvZXJjL2VyYy1uZXR3b3Jrcy5lbCAoZXJjLW5ldHdvcmtzLWFs aXN0KTogRG9uJ3QgYWR2ZXJ0aXNlIHRoYXQKTUFUQ0hFUiBjYW4gYmUgYSBmdW5jdGlvbiwg c2luY2UgaXQgZG9lc24ndCBsb29rIGxpa2UgdGhhdCBpcwpzdXBwb3J0ZWQuCi0tLQogbGlz cC9lcmMvZXJjLWZpbGwuZWwgICAgIHwgMyArKy0KIGxpc3AvZXJjL2VyYy1nb29kaWVzLmVs ICB8IDQgKysrLQogbGlzcC9lcmMvZXJjLW5ldHdvcmtzLmVsIHwgNSArKy0tLQogMyBmaWxl cyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGlzcC9lcmMvZXJjLWZpbGwuZWwgYi9saXNwL2VyYy9lcmMtZmlsbC5lbAppbmRleCAw ZTZiNWEzZWZiOC4uNTA4Nzk1ZGE3YzEgMTAwNjQ0Ci0tLSBhL2xpc3AvZXJjL2VyYy1maWxs LmVsCisrKyBiL2xpc3AvZXJjL2VyYy1maWxsLmVsCkBAIC0xMTAsNyArMTEwLDggQEAgZXJj LWZpbGwtc3RhdGljLWNlbnRlcgogKGRlZmN1c3RvbSBlcmMtZmlsbC12YXJpYWJsZS1tYXhp bXVtLWluZGVudGF0aW9uIDE3CiAgICJEb24ndCBpbmRlbnQgYSBsaW5lIGFmdGVyIGEgbG9u ZyBuaWNrIG1vcmUgdGhhbiB0aGlzIG1hbnkgY2hhcmFjdGVycy4KIFNldCB0byBuaWwgdG8g ZGlzYWJsZS4iCi0gIDp0eXBlICdpbnRlZ2VyKQorICA6dHlwZSAnKGNob2ljZSAoY29uc3Qg OnRhZyAiRGlzYWJsZSIgbmlsKQorICAgICAgICAgICAgICAgICBpbnRlZ2VyKSkKIAogKGRl ZmN1c3RvbSBlcmMtZmlsbC1jb2x1bW4gNzgKICAgIlRoZSBjb2x1bW4gYXQgd2hpY2ggYSBm aWxsZWQgcGFyYWdyYXBoIGlzIGJyb2tlbi4iCmRpZmYgLS1naXQgYS9saXNwL2VyYy9lcmMt Z29vZGllcy5lbCBiL2xpc3AvZXJjL2VyYy1nb29kaWVzLmVsCmluZGV4IGI3NzE3NmQ4YWM3 Li4zZmY0YzcyZGI5OSAxMDA2NDQKLS0tIGEvbGlzcC9lcmMvZXJjLWdvb2RpZXMuZWwKKysr IGIvbGlzcC9lcmMvZXJjLWdvb2RpZXMuZWwKQEAgLTM4OSw3ICszODksOSBAQCBlcmMta2Vl cC1wbGFjZS1pbmRpY2F0b3Itc3R5bGUKIGFwcHJvcHJpYXRlIGxpbmUuICBBIHZhbHVlIG9m IHQgZG9lcyBib3RoLiIKICAgOmdyb3VwICdlcmMKICAgOnBhY2thZ2UtdmVyc2lvbiAnKEVS QyAuICI1LjYiKSA7IEZJWE1FIHN5bmMgb24gcmVsZWFzZQotICA6dHlwZSAnKGNob2ljZSAo Y29uc3QgdCkgKGNvbnN0IHNlcnZlcikgKGNvbnN0IHRhcmdldCkpKQorICA6dHlwZSAnKGNo b2ljZSAoY29uc3QgOnRhZyAiVXNlIGFycm93IiBhcnJvdykKKyAgICAgICAgICAgICAgICAg KGNvbnN0IDp0YWcgIlVzZSBmYWNlIiBmYWNlKQorICAgICAgICAgICAgICAgICAoY29uc3Qg OnRhZyAiVXNlIGJvdGggYXJyb3cgYW5kIGZhY2UiIHQpKSkKIAogKGRlZmN1c3RvbSBlcmMt a2VlcC1wbGFjZS1pbmRpY2F0b3ItYnVmZmVyLXR5cGUgdAogICAiRVJDIGJ1ZmZlciB0eXBl IGluIHdoaWNoIHRvIGRpc3BsYXkgYGtlZXAtcGxhY2UtaW5kaWNhdG9yJy4KZGlmZiAtLWdp dCBhL2xpc3AvZXJjL2VyYy1uZXR3b3Jrcy5lbCBiL2xpc3AvZXJjL2VyYy1uZXR3b3Jrcy5l bAppbmRleCBiYTc5OTBlODdkNi4uZDczZDcxNWRiMmMgMTAwNjQ0Ci0tLSBhL2xpc3AvZXJj L2VyYy1uZXR3b3Jrcy5lbAorKysgYi9saXNwL2VyYy9lcmMtbmV0d29ya3MuZWwKQEAgLTc1 Niw5ICs3NTYsOCBAQCBlcmMtbmV0d29ya3MtYWxpc3QKIEVhY2ggbmV0d29yayBpcyBhIGxp c3QgKE5FVCBNQVRDSEVSKSB3aGVyZQogTkVUIGlzIGEgc3ltYm9sIG5hbWluZyB0aGF0IElS QyBuZXR3b3JrIGFuZAogTUFUQ0hFUiBpcyB1c2VkIHRvIGZpbmQgYSBjb3JyZXNwb25kaW5n IG5ldHdvcmsgdG8gYSBzZXJ2ZXIgd2hpbGUKLSAgY29ubmVjdGVkIHRvIGl0LiAgSWYgaXQg aXMgcmVnZXhwLCBpdCdzIHVzZWQgdG8gbWF0Y2ggYWdhaW5zdAotICBgZXJjLXNlcnZlci1h bm5vdW5jZWQtbmFtZScuICBJdCBjYW4gYWxzbyBiZSBhIGZ1bmN0aW9uIChwcmVkaWNhdGUp LgotICBUaGVuIGl0IGlzIGV4ZWN1dGVkIHdpdGggdGhlIHNlcnZlciBidWZmZXIgYXMgY3Vy cmVudCBidWZmZXIuIgorY29ubmVjdGVkIHRvIGl0LiAgSWYgaXQgaXMgYSByZWdleHAsIGl0 J3MgdXNlZCB0byBtYXRjaCBhZ2FpbnN0CitgZXJjLXNlcnZlci1hbm5vdW5jZWQtbmFtZScu IgogICA6dHlwZSAnKHJlcGVhdAogCSAgKGxpc3QgOnRhZyAiTmV0d29yayIKIAkJKHN5bWJv bCA6dGFnICJOZXR3b3JrIG5hbWUiKQotLSAKMi4zNC4xCgo= --------------4lLJuYcTZVxk7cdxNMNYKHgz-- From unknown Sat Sep 20 18:41:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mauro Aranda Subject: bug#66520: closed (Re: bug#66520: 30.0.50; Small issues with defcustoms in ERC) Message-ID: References: <8734yeef73.fsf@neverwas.me> <7dbaca89-8e51-41d9-bb55-0cf51dbcd6cf@gmail.com> X-Gnu-PR-Message: they-closed 66520 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 66520@debbugs.gnu.org Date: Fri, 13 Oct 2023 15:06:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1697209563-21512-1" This is a multi-part message in MIME format... ------------=_1697209563-21512-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66520: 30.0.50; Small issues with defcustoms in ERC which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66520@debbugs.gnu.org. --=20 66520: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66520 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1697209563-21512-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66520-done) by debbugs.gnu.org; 13 Oct 2023 15:05:25 +0000 Received: from localhost ([127.0.0.1]:47080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrJjB-0005Zr-1h for submit@debbugs.gnu.org; Fri, 13 Oct 2023 11:05:25 -0400 Received: from mail-108-mta199.mxroute.com ([136.175.108.199]:42223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrJj7-0005Zf-J6 for 66520-done@debbugs.gnu.org; Fri, 13 Oct 2023 11:05:23 -0400 Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta199.mxroute.com (ZoneMTA) with ESMTPSA id 18b2991a4af000ff68.001 for <66520-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 13 Oct 2023 15:04:52 +0000 X-Zone-Loop: 835c2a78ceb6de7e8164a54b8e723abd3e0cb4ca0b09 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ylESfGe4C3BmkH9i6COgNiGY2s6IaHUUbM3CR6a8UD4=; b=KSikzl4EYrvWD2lSTUyBgdd6kQ Htk7Q/28QgEUinvY9gjApaRzXEJpe3DxGHnLZX47e1T5R5eW3Ng2xEqDn4Vonr2wQbak0syURcn6G +Nk4oZgQ7WbciNDQMMOekhmOI295VCn6g4G9v2rAfuNihpHnNg0iv/z4N17LNIM2wEw7IbGcUrRJP u34M0MqJeV+lWV6bx0cckXns5vNVS4D8J1fpUAkj4gJ/sNN7DZE83dyQspd87t2Ko22GigzTEVhHq k0SOmRINmB88Jy7+L3oEE0kjUnPy3WA8g2KU4SkzUk5M1MDRj/vwZ/h0ncYN441v3Rcg7uLPTEO5+ yZIYN+FA==; From: "J.P." To: Mauro Aranda Subject: Re: bug#66520: 30.0.50; Small issues with defcustoms in ERC In-Reply-To: <04e68172-0d8f-42bf-bc40-9639a57ecc38@gmail.com> (Mauro Aranda's message of "Fri, 13 Oct 2023 10:37:44 -0300") References: <7dbaca89-8e51-41d9-bb55-0cf51dbcd6cf@gmail.com> <04e68172-0d8f-42bf-bc40-9639a57ecc38@gmail.com> Date: Fri, 13 Oct 2023 08:04:48 -0700 Message-ID: <8734yeef73.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66520-done Cc: emacs-erc@gnu.org, 66520-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > tags 66520 patch > quit > > > I attach a patch to fix these issues. Appreciate the diligence! > Maybe I'm wrong about changing the docstring in erc-networks-alist. Nah, I couldn't find any sign of the function variant being considered in the 18+ years since the file was first introduced to the old CVS repo. I've added this as https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=baf778c7 Thanks and closing. ------------=_1697209563-21512-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Oct 2023 13:33:47 +0000 Received: from localhost ([127.0.0.1]:45492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrIIV-0005US-74 for submit@debbugs.gnu.org; Fri, 13 Oct 2023 09:33:47 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrIIS-0005UE-R7 for submit@debbugs.gnu.org; Fri, 13 Oct 2023 09:33:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrII0-0005MO-5y for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2023 09:33:16 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrIHy-0002v8-3x for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2023 09:33:15 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-690ce3c55f1so1683390b3a.0 for ; Fri, 13 Oct 2023 06:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697203991; x=1697808791; darn=gnu.org; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=hEhb8HS3DQyGCm044kYqSTNVXePFUSleGW/gWnj8Q8I=; b=T6SYtIQ19eRME3Lf0r9llRnN2kU4Wrhr0L1M5EaHV3EcnSfu9PZLjQ+hhDxLErnlgZ mXuC4YKVFNEtKr1Q7yqRd7qS1QYK/E85Z+Cxqj7BPop/V83F1ipFNLCEkpRPERuOrneO tM3VwJDBkHj/ALgtJbe6V3d5J4HPIo4HjJEZsg75b9hMF8vcyA7cu4xvOJKWTlQ6BA2T /kbnXBMjh/ZSz5WCCGBBrcysiQ6DEpGHistC1EfJkX85LtAI9OAbe3sWgbbfqJzeCqFA I1RmvJUm1c1Y+RpyY56isro4j+j//8Xm1EIlSCF3PvmjINM6VaXFWHKivthm7W3tlcQU 1RZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697203991; x=1697808791; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hEhb8HS3DQyGCm044kYqSTNVXePFUSleGW/gWnj8Q8I=; b=LpnkFwdrbys1561f9/I8EsCR4xgYYk08/tIW5QkyOTIldKZdCO0gSh1JkkjciKz9MM WpE8/M4sNPRYGfUJ+6G3f29t1wycy2R2nmz/BEjdLZGKm40D4u9VLCq3fChZWWZF+pzG 54ykXMuMZpyhBgc8yUh6zQjU9A8jrySzbecBc/AO+JFyoj1EXti32OXioM4Rm5dTKA9C UWZ2YePc3afUU/PAUZu/As7LaurNAoUYBUpYKHi77bwrd8/A1y+DPJsjqXAWcMlQWzZ8 w4jJ23rflr4LhQxjzPuZXTR+AXbaCV2gz71VM7SWY039TfrKAjUoK451LXyE0qIZ7ysB 5xyg== X-Gm-Message-State: AOJu0YxmrEFenX0pWYmOk1R7/yFCEFuc2RcTvaFSI4R8SLaUtJO5F6zB Qk3fNeK2AF0xuqyvcWWZbKQySRh8Dj290MZm X-Google-Smtp-Source: AGHT+IEMMxQo+jJ1mPObASpfRj2iZbXTXmRkEhcLH10n5hExAE5YOJAdtUYd7WWUS/ye86Hg0F5dww== X-Received: by 2002:a05:6a00:3906:b0:690:c75e:25d7 with SMTP id fh6-20020a056a00390600b00690c75e25d7mr26740144pfb.18.1697203991495; Fri, 13 Oct 2023 06:33:11 -0700 (PDT) Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id o4-20020a056a001b4400b006884549adc8sm13531045pfv.29.2023.10.13.06.33.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Oct 2023 06:33:11 -0700 (PDT) Message-ID: <7dbaca89-8e51-41d9-bb55-0cf51dbcd6cf@gmail.com> Date: Fri, 13 Oct 2023 10:33:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Mauro Aranda Subject: 30.0.50; Small issues with defcustoms in ERC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=maurooaranda@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Looking for defcustom docstrings and :type inconsistencies, I found the following in erc/: The docstring of erc-fill-variable-maximum-indentation says its value can be nil, but its :type is just integer. The choices in erc-keep-place-indicator-style look like a copy-pasta from erc-keep-place-indicator-buffer-type.  The docstring matches what the code checks, so I guess the choices are wrong. Finally, erc-networks-alist says that MATCHER can be either a regexp or a function.  But neither erc-determine-network (obsoleted) nor erc-networks--determine check to see if MATCHER is a function. So maybe that isn't supported? ------------=_1697209563-21512-1--