GNU bug report logs - #66500
[PATCH core-updates 0/3] Custom output labels for copy-build-system.

Previous Next

Full log

Message #38 received at 66500 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 66500 <at> debbugs.gnu.org
Subject: Re: [PATCH core-updates 1/3] build: copy-build-system: Allow
 specifying different output labels.
Date: Thu, 19 Oct 2023 16:36:03 +0100

Hi Liliana,

On 2023-10-19 10:46, Liliana Marie Prikler wrote:
> This is perhaps extremely nitpicky, but there should be a comma before
> "the @code{#:output} argument".

Addressing this with v2.

> s/for output labelled/within the output named/
> or 
> s/for output labelled \"doc\"/within the \"doc\" output/

Likewise, went for the second choice here.

> Otherwise LGTM.  Note, however, that CI doesn't like this series.

Strange, the CI complains of a merge conflict yet I didn't encounter
any issues when rebasing this to the latest core-updates [1].


[1]: guix commit d59653b7c9e43ebdbba20e2ca071429507f94c67

-- 
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.