GNU bug report logs - #66481
[PATCH gnome-team] gnu: tracker-miners: Update to 3.6.1.

Previous Next

Full log

Message #14 received at 66481 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: rg <at> raghavgururajan.name, 66481 <at> debbugs.gnu.org
Subject: Re: [bug#66481] [PATCH gnome-team] gnu: tracker-miners: Update to
 3.6.1.
Date: Thu, 12 Oct 2023 13:31:30 -0400

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Donnerstag, dem 12.10.2023 um 10:21 -0400 schrieb Maxim Cournoyer:
>> Hello,
>> 
>> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>> 
>> > * gnu/packages/gnome.scm (tracker-miners): Update to 3.6.1.
>> 
>> LGTM.  I think this is a small change enough that it doesn't need to
>> go through guix-patches (you could have pushed it already).
> IIUC the exception for small patches is no longer part of the manual. 
> Plus, with the recent kerfluffle around tracker-miners, I prefer a
> review :)

The relevant bits from info '(guix) managing patches and branches' is
this:

> As an exception, some changes considered “trivial” or “obvious” may be
> pushed directly to the ‘master’ branch.  This includes changes to fix
> typos and reverting commits that caused immediate problems.  This is
> subject to being adjusted, allowing individuals to commit directly on
> non-controversial changes on parts they’re familiar with.

It mentions 'master' there but I think this was an oversight; the same
should hold for any branch.  And I think bumping a version field and the
hash is non-controversial enough if it doesn't break the world and was
tested :-).

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.