GNU bug report logs - #66470
29.1; Provide Urdu input method

Previous Next

Full log

Message #40 received at 66470 <at> debbugs.gnu.org (full text, mbox):

From: Rahguzar <rahguzar <at> zohomail.eu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 66470 <at> debbugs.gnu.org
Subject: Re: bug#66470: 29.1; Provide Urdu input method
Date: Sun, 29 Oct 2023 17:27:38 +0100

[Message part 1 (text/plain, inline)]

Hi Eli,
  Thanks for the review. I have made the changes you asked for, please
  let me know of other changes need.

Eli Zaretskii <eliz <at> gnu.org> writes:


> Thanks.  This lacks a ChangeLog-style commit log message (see
> CONTRIBUTE and "git log" for how we write those).

I have added the commit message with some help from magit. Please let me
know if changes to it are needed.

> Can you come up with a shorter mode-line indicator for this and other
> input methods?  We usually use just 1 or 2 letters for it; you used
> something much longer.

Done now, all of them are now 1 or 2 letters.

>> +(defun pakistan--define-quail-rules (rules &optional prefix package)
>> +  "Define the rules for an input method.
>
> Our style is to have the first sentence of a doc string be a summary
> of what the function does and also mention all the mandatory
> arguments.  I would suggest something like
>
>   Define rules for a Pakistan input method as determined by RULES.

Done, with a slight rewording.

>> +(defun pakistan--make-setter (&optional prefix package)
>> +  "Retrun the setter function.
>       ^^^^^^
> Typo.

Thanks, fixed now.

>> +The function add rules to PACKAGE with PREFIX."
>                 ^^^
> "adds".
>
>> +(defun pakistan--set-numeral-translations (var val)
>> +  "Add translations for digits.
>
> This should mention the arguments.

It does now but awkwardly. Maybe instead of defining this function, the
setter should be lambda?

>> +(quail-define-package
>> + "urdu-custom" "Urdu" "اردو انفر۱دی" t
>> + "Intuitive and customizable transl input method for Urdu.
>> +By default this input method doesn't try to follow the common romanization of Urdu
>> +very closely.  The reason for this is allow to for input efficiency. It works as
>> +follows:
>
> Please try not to use lines longer than 79 characters in doc strings.

I have filled the lines in the doc string with a fill column of 78.

> Thanks.

Thanks for the review,
Rahguzar

[0001-Input-methods-for-Urdu-Pashto-and-Sindhi.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.