GNU bug report logs - #66470
29.1; Provide Urdu input method

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rahguzar <rahguzar <at> zohomail.eu>
Cc: 66470 <at> debbugs.gnu.org
Subject: bug#66470: 29.1; Provide Urdu input method
Date: Sun, 29 Oct 2023 13:51:41 +0200

> From: Rahguzar <rahguzar <at> zohomail.eu>
> Cc: 66470 <at> debbugs.gnu.org
> Date: Sat, 21 Oct 2023 20:59:10 +0200
> 
> I have attached a new patch with this email containing 5 input methods.
> 3 of them for Urdu and 1 each for Pashto and Sindhi. Two of Urdu input
> methods correspond to the two keyboards at https://www.branah.com/urdu
> and the Pashto and Sindhi input methods follow keyboard layouts from the
> same page.

Thanks.  This lacks a ChangeLog-style commit log message (see
CONTRIBUTE and "git log" for how we write those).

> +;; Layout taken from https://www.branah.com/urdu
> +(quail-define-package
> + "urdu-keyboard" "Urdu" "اردو تختی" t
                            ^^^^^^^^
Can you come up with a shorter mode-line indicator for this and other
input methods?  We usually use just 1 or 2 letters for it; you used
something much longer.

> +(defun pakistan--define-quail-rules (rules &optional prefix package)
> +  "Define the rules for an input method.

Our style is to have the first sentence of a doc string be a summary
of what the function does and also mention all the mandatory
arguments.  I would suggest something like

  Define rules for a Pakistan input method as determined by RULES.

> +(defun pakistan--make-setter (&optional prefix package)
> +  "Retrun the setter function.
      ^^^^^^
Typo.

> +The function add rules to PACKAGE with PREFIX."
                ^^^
"adds".

> +(defun pakistan--set-numeral-translations (var val)
> +  "Add translations for digits.

This should mention the arguments.

> +(quail-define-package
> + "urdu-custom" "Urdu" "اردو انفر۱دی" t
> + "Intuitive and customizable transl input method for Urdu.
> +By default this input method doesn't try to follow the common romanization of Urdu
> +very closely.  The reason for this is allow to for input efficiency. It works as
> +follows:

Please try not to use lines longer than 79 characters in doc strings.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.