Subject: Re: bug#66470: 29.1; Provide Urdu input method

From: Eli Zaretskii <[email-masked]>
Date: Sat, 04 Nov 2023 13:15:42 +0200

> From: Rahguzar <[email-masked]>
> Cc: [email-masked]
> Date: Sat, 04 Nov 2023 11:56:50 +0100
> 
> I have attached an updated version of the patch which addresses and
> other problems indicated in your previous messages. Please let me know
> of further changes needed and thanks for the reviews.

Thanks.  This still has a few issues, though.

First, when I try to activate the pashto-keyboard input method in
"emacs -Q", Emacs signals en error:

  Symbol’s value as variable is void: pakistan-urdu-use-roman-digits

I wonder how this worked for you.

> +(defcustom pakistan-urdu-prefixes
> +  '((diacritics "o")
> +    (poetic "G")
> +    (religious "M")
> +    (balochi-brahui "B")
> +    (pashto "P")
> +    (sindhi "C")
> +    (saraiki-hindko "X"))
> +  "Prefixes for `urdu-custom' input method."
> +  :set #'pakistan--set-prefixes
> +  :type '(repeat (list symbol string))
> +  :group 'pakistan-urdu-input)

Each defcustom should have a :version tag stating the first version in
which it will appear.