From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 10 20:26:20 2023 Received: (at submit) by debbugs.gnu.org; 11 Oct 2023 00:26:20 +0000 Received: from localhost ([127.0.0.1]:37189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqN3M-0004dS-9Q for submit@debbugs.gnu.org; Tue, 10 Oct 2023 20:26:20 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqN3J-0004dB-Hq for submit@debbugs.gnu.org; Tue, 10 Oct 2023 20:26:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqN2r-0007Ty-I6 for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 20:25:50 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqN2p-0005iV-TK for bug-gnu-emacs@gnu.org; Tue, 10 Oct 2023 20:25:49 -0400 Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-5859b06509cso4025554a12.2 for ; Tue, 10 Oct 2023 17:25:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696983943; x=1697588743; h=mime-version:organization:subject:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wp8zLQQv8aRy1e7xz7/DCwAO5ZBnRs/JS8afWNFV6fE=; b=NOGTWXd0prf3pOPHERIeQ/ow6GbwQmP+lTNELZIlulLN5ZH7JQnwsVwFKVsmHxrXp6 IC5g/2x+NAE3v9/QykqOWeMKluee/afvplYMxYzV0vcqykPlwYoo8k4itRoGq+E7eoEx 4TL9XM8+tnsZ8jyFdatgS+T7Qrp9gt4Y5seMk/BGMEF00e2f0ZYqeRYVqF5o5klPyv1e 0cU2HmgkSnrK8pDo6mGnwWXSdrG21Td0n/cvt919pPC+20EA2WkCJYnwADiPSvH6almT stxeoKbVk3OPUon70/cJPMKXiSvDwPBI/Oqqg6ywL10eOOOAa59FbfOISHy/3JVx4DQ7 uvng== X-Gm-Message-State: AOJu0Yy8AzsBYyvNcr2CZ83CRjTdHbZJd/xtlle+VXqn1lyYQUO5jDvX 0KK7/ZraD0LZER/wrrTLMf/LUNpHEg== X-Google-Smtp-Source: AGHT+IG9/nia5qPMHbsrduR5AloFj2ZGN4q3Z9fTm5M2ZjRYRlhhmElnEfTXjl3HV11xAZNX2sdkQg== X-Received: by 2002:a05:6a20:2446:b0:14c:e8d4:fb3e with SMTP id t6-20020a056a20244600b0014ce8d4fb3emr20408748pzc.43.1696983942554; Tue, 10 Oct 2023 17:25:42 -0700 (PDT) Received: from localhost (157-205-200-190.cns.tayoreru.com. [157.205.200.190]) by smtp.gmail.com with ESMTPSA id v5-20020aa78505000000b00696ca62d5f5sm8842568pfn.8.2023.10.10.17.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 17:25:42 -0700 (PDT) Date: Wed, 11 Oct 2023 09:25:39 +0900 Message-ID: From: Katsumi Yamaoka To: bug-gnu-emacs@gnu.org Subject: 30.0.50; shr sometimes displays the same image twice Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=209.85.215.177; envelope-from=katsumi.yamaoka@gmail.com; helo=mail-pg1-f177.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_TVD_MIME_NO_HEADERS=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, If an alt text, that has an `image-displayer' text property, is filled by `shr-fill-line' by way of `shr-fill-lines', the image is displayed for two or more times. It is because the `image-displayer' [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (katsumi.yamaoka[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 T_TVD_MIME_NO_HEADERS BODY: No description available. 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Hi, If an alt text, that has an `image-displayer' text property, is filled by `shr-fill-line' by way of `shr-fill-lines', the image is displayed for two or more times. It is because the `image-displayer' text property is divided by the newline(s). Here is a quick hack: --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- lisp/net/shr.el~ 2023-09-04 23:25:12.472173300 +0000 +++ lisp/net/shr.el 2023-10-11 00:23:43.577152000 +0000 @@ -799,13 +799,17 @@ (when (= (preceding-char) ?\s) (delete-char -1)) (let ((gap-start (point)) - (face (get-text-property (point) 'face))) - ;; Extend the background to the end of the line. + (face (get-text-property (point) 'face)) + (displayer (get-text-property (point) 'image-displayer))) + ;; Extend the background and the image displayer to the end + ;; of the line. (insert ?\n) (shr-indent) (when face (put-text-property gap-start (point) 'face (shr-face-background face))) + (when displayer + (put-text-property gap-start (point) 'image-displayer displayer)) (when (and (> (1- gap-start) (point-min)) (get-text-property (point) 'shr-url) ;; The link on both sides of the newline are the --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 08:04:51 2023 Received: (at 66457) by debbugs.gnu.org; 11 Oct 2023 12:04:51 +0000 Received: from localhost ([127.0.0.1]:37704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqXxK-0002vq-OQ for submit@debbugs.gnu.org; Wed, 11 Oct 2023 08:04:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqXxI-0002vb-NO for 66457@debbugs.gnu.org; Wed, 11 Oct 2023 08:04:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqXwq-0002DH-Hn; Wed, 11 Oct 2023 08:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LqxMY6X1GAwbN4xLkdHfGXj30bw/ON6L3pm5sDhlU64=; b=O79mWrPSBqo4 Ey4yXjRfRJVE1FppDUAArLA8a7cE5R68O0cViewGbpLcvvROR8F7lipH5BD4hgq/gjPgS5CFpv2EC gAGDJaIGxm5r8YofEYhbzGZavfS9gnDQFfndTIItBWT30zscgrdGRWR4R56FSQuJR7ZOgUOM4KdV4 Jab/b2QBPEDzIjv2W6VSN/4oBKqGU05wpJUq3np9eXVZELnoXh1nceU0RMHj8qao9l3v4fjP8IBmh uQB07aiAKUdRsZ+pT0nWvDFpC+DUeB+d/Rgzh/+2cTPZhMzE7JQwGKg9Vj60xTF6IhPkYW+zP18r+ IF9pBxwDLfmYc8E87mnVtg==; Date: Wed, 11 Oct 2023 15:04:13 +0300 Message-Id: <834jixv002.fsf@gnu.org> From: Eli Zaretskii To: Katsumi Yamaoka In-Reply-To: (message from Katsumi Yamaoka on Wed, 11 Oct 2023 09:25:39 +0900) Subject: Re: bug#66457: 30.0.50; shr sometimes displays the same image twice References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66457 Cc: 66457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 11 Oct 2023 09:25:39 +0900 > From: Katsumi Yamaoka > > If an alt text, that has an `image-displayer' text property, is > filled by `shr-fill-line' by way of `shr-fill-lines', the image > is displayed for two or more times. It is because the > `image-displayer' text property is divided by the newline(s). > Here is a quick hack: Thanks, but can you show a recipe to reproduce the issue and test the solution? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 11 20:49:34 2023 Received: (at 66457) by debbugs.gnu.org; 12 Oct 2023 00:49:34 +0000 Received: from localhost ([127.0.0.1]:40244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqjtO-0007Va-Cw for submit@debbugs.gnu.org; Wed, 11 Oct 2023 20:49:34 -0400 Received: from mail-pg1-f171.google.com ([209.85.215.171]:42109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqjtM-0007VB-3D for 66457@debbugs.gnu.org; Wed, 11 Oct 2023 20:49:32 -0400 Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-578d791dd91so309966a12.0 for <66457@debbugs.gnu.org>; Wed, 11 Oct 2023 17:49:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697071743; x=1697676543; h=mime-version:organization:references:subject:cc:to:from:message-id :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u3UWmhm2STqXH1Zx6DnZkTyd98nigUxorVoMrr3jSgA=; b=q9e/l/0rF3Hx66rOvVOqQpVeVQGlLB315XUY/2yCWto0Wn/Qa2c3R7mzckJldQV8jR xwLAiRgR1oU3uzR/ExyPTWINM1HriC3Ofb5bEgadxD6l9hUzAIZBypWKn6MI1bqK+3vP Ui3YGRFc+fC2JDqhaHnUmvyKr3G/4mGyTzvY3k9EzrfksMPouYQJkvBo72khoXZhlwgV AlIMqoJqrJCv2trlCMdJhVYfq9Z2wFodt6LzouPZVj8AUJNtcmTawRMzTzk7xf+DwtC4 8mDJ1ZBJW98TO2h8BgSFAr45GF7TDpmQWr07LhODo9EVndCaOzjNftADvQaftc5N/fKn 0Z9g== X-Gm-Message-State: AOJu0YztRBenuoWSihiLbuGFpyIdMkwJy8g73WwHrBxJub+/8U+APUZq ZmEBeTGvikHCS1jZe1lcIw== X-Google-Smtp-Source: AGHT+IHwDaVecqr+XzxG1YQAcddVfDi6GUzkG0HzX0871UjdkKsSuDzAqrKJWdw+/tHG8z9NZMjGXg== X-Received: by 2002:a17:902:e852:b0:1c5:59dc:6e93 with SMTP id t18-20020a170902e85200b001c559dc6e93mr34006785plg.3.1697071743491; Wed, 11 Oct 2023 17:49:03 -0700 (PDT) Received: from localhost (157-205-200-190.cns.tayoreru.com. [157.205.200.190]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c20d00b001c72d5e16acsm502068pll.57.2023.10.11.17.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 17:49:02 -0700 (PDT) Date: Thu, 12 Oct 2023 09:49:00 +0900 Message-ID: From: Katsumi Yamaoka To: Eli Zaretskii Subject: Re: bug#66457: 30.0.50; shr sometimes displays the same image twice References: <834jixv002.fsf@gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66457 Cc: 66457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= On Wed, 11 Oct 2023 15:04:13 +0300, Eli Zaretskii wrote: > Thanks, but can you show a recipe to reproduce the issue and test the > solution? Ok, here is an example html mail. Set `mm-text-html-renderer' to `shr', read the example mail in Gnus in some way, and try `W D W' and `W D D' commands. --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=Example Content-Transfer-Encoding: base64 VG86IG5vYm9keQpTdWJqZWN0OiB0ZXN0CkZyb206IEthdHN1bWkgWWFtYW9rYSA8eWFtYW9rYUBq cGwub3JnPgpEYXRlOiBUaHUsIDEyIE9jdCAyMDIzIDA5OjM0OjU0ICswOTAwCk1lc3NhZ2UtSUQ6 IDxkZzlpOHI4ODF4dzEuZnNmQGpwbC5vcmc+Ck1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlw ZTogbXVsdGlwYXJ0L3JlbGF0ZWQ7IGJvdW5kYXJ5PSI9PT1ib3VuZGFyeT09PSI7IHR5cGU9InRl eHQvaHRtbCI7IHN0YXJ0PSI8c3RhcnQ+IgoKLS09PT1ib3VuZGFyeT09PQpDb250ZW50LVR5cGU6 IHRleHQvaHRtbApDb250ZW50LUlEOiA8c3RhcnQ+Cgo8aHRtbD4KICA8Ym9keT4KICAgIEhlcmUg c2hvdWxkIGJlIGEgc2luZ2xlIGJveDoKICAgIDxpbWcgc3JjPSJjaWQ6aW1hZ2UiCgkgYWx0PSIq KioqICoqKiogKioqKiAqKioqICoqKiogKioqKiAqKioqICoqKiogKioqKiAqKioqICoqKiogKioq KiAqKioqICoqKiogKioqKiAqKioqICoqKiogKioqKiAqKioqICoqKiogKioqKiAqKioqICoqKiog KioqKiAqKioqICoqKiogKioqKiAqKioqICI+CiAgPC9ib2R5Pgo8L2h0bWw+CgotLT09PWJvdW5k YXJ5PT09CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IGJhc2U2NApDb250ZW50LURpc3Bvc2l0 aW9uOiBpbmxpbmUKQ29udGVudC1UeXBlOiBpbWFnZS9wbmcKQ29udGVudC1JRDogPGltYWdlPgoK aVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQURBQUFBQXdBUU1BQUFCdHpHdkVBQUFBQTFCTVZFVUEv LzhaWEM4bEFBQUFEVWxFUVZRWQowMk5nR0FYVUJBQUJVQUFCcCtMYUZnQUFBQUJKUlU1RXJrSmdn Zz09CgotLT09PWJvdW5kYXJ5PT09LS0K --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 12 01:09:36 2023 Received: (at 66457) by debbugs.gnu.org; 12 Oct 2023 05:09:36 +0000 Received: from localhost ([127.0.0.1]:40400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqnx2-0000R7-AR for submit@debbugs.gnu.org; Thu, 12 Oct 2023 01:09:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqnwz-0000Qu-EE for 66457@debbugs.gnu.org; Thu, 12 Oct 2023 01:09:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqnwX-0006cK-M7; Thu, 12 Oct 2023 01:09:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KEnD9A1mewwQAtiR3b6TNtzHrfi0vnkCUKVyvfJaB9Y=; b=k53r4Y3BCtJ4 Tc9640KLKW0I0fK7+ixsCrvHrSdQC10Gqi/w/81YU6zzbRBWZTLG/ycVWbQDuYuAnKNStn3QiKgOq X7cbktAo5lVDC5bJzsfY59NoY7GzPLAajIFQiynwGbIfX5qdX96ASuN5soSzg1PrKlMHyNNmJC0du P+XA/WXAX2318SWwmov4QGm5074NdljS+ENcGdGc1riRKyLNtpd0aJV2sN9m24a4fs6/zzwm25v/D fm+PcuNNGOCQv+MoKii6Gn6J2GL3q4ENfMrg8iXVPFDlR3pSegkIMTeq3leLJeG2yqfMCm2ZvXO5i U3q9NFkjNZOyjp5/Jv0C4w==; Date: Thu, 12 Oct 2023 08:08:57 +0300 Message-Id: <831qe0v34m.fsf@gnu.org> From: Eli Zaretskii To: Katsumi Yamaoka In-Reply-To: (message from Katsumi Yamaoka on Thu, 12 Oct 2023 09:49:00 +0900) Subject: Re: bug#66457: 30.0.50; shr sometimes displays the same image twice References: <834jixv002.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66457 Cc: 66457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 12 Oct 2023 09:49:00 +0900 > From: Katsumi Yamaoka > Cc: 66457@debbugs.gnu.org > > On Wed, 11 Oct 2023 15:04:13 +0300, Eli Zaretskii wrote: > > Thanks, but can you show a recipe to reproduce the issue and test the > > solution? > > Ok, here is an example html mail. > Set `mm-text-html-renderer' to `shr', read the example mail in > Gnus in some way, and try `W D W' and `W D D' commands. Thanks. (That was an invalid mbox file, btw; I needed to fix it, but that was easy. Also, I don't use Gnus, so if you can show a fill recipe including the "read the example mail in Gnus in some way" part, I'd appreciate that, as I'd like to make sure I see exactly what you see in Gnus. Meanwhile, I tried in Rmail instead, which also uses shr.el to display HTML emails.) So now I'm not sure I understand what you are saying. You said: > If an alt text, that has an `image-displayer' text property, is > filled by `shr-fill-line' by way of `shr-fill-lines', the image > is displayed for two or more times. It is because the > `image-displayer' text property is divided by the newline(s). AFAIU, the alt text is text that is displayed instead of an image, when the image cannot or should not be displayed for some reason. If my understanding is correct, then why do you expect the alt text to take only one line on display? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 25 09:47:47 2023 Received: (at 66457) by debbugs.gnu.org; 25 Oct 2023 13:47:47 +0000 Received: from localhost ([127.0.0.1]:57767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveEd-0002ip-1y for submit@debbugs.gnu.org; Wed, 25 Oct 2023 09:47:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveEb-0002id-4i for 66457@debbugs.gnu.org; Wed, 25 Oct 2023 09:47:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qveE1-0002DR-BX; Wed, 25 Oct 2023 09:47:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9fJxYi9C+EMD5EloZrP1E30FyGZWwf+VsMSGxAX2nDY=; b=rQaLxK7m8SJ6 atOsIFVlwDY1ZeQ8EVDLWd5c0RyT3MUMwPjF1Hj6kZbfhHg4wHF8OqIyi7Pat6QzfyX8KYVRQaD0T arqrKksegx+zQ+tIUOhaheLx+8pw+3sE5t7JhuhTZ5Zoq2CYzYgOPb2Ilz8G+/l20XNV99Y0lT+p4 G0S0MWoEIp2/0nm5QgBu2Ew9hHXm4hazyLUlm9u5gQ6DkZ17kBftqDUqgppkb8d2aPOxhLcb3+bhz u6Q7S4HSSN1sZ+PTIkJJqzosQ5tN3c1P/OyjKZM33KaLLjFklqHViKmxprPhnLopO7SS7BdpBo2Et z6aeCYeNyKBVqebU9uHSuQ==; Date: Wed, 25 Oct 2023 16:47:12 +0300 Message-Id: <83y1fqizkv.fsf@gnu.org> From: Eli Zaretskii To: yamaoka@jpl.org In-Reply-To: <831qe0v34m.fsf@gnu.org> (message from Eli Zaretskii on Thu, 12 Oct 2023 08:08:57 +0300) Subject: Re: bug#66457: 30.0.50; shr sometimes displays the same image twice References: <834jixv002.fsf@gnu.org> <831qe0v34m.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66457 Cc: 66457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! > Cc: 66457@debbugs.gnu.org > Date: Thu, 12 Oct 2023 08:08:57 +0300 > From: Eli Zaretskii > > > Date: Thu, 12 Oct 2023 09:49:00 +0900 > > From: Katsumi Yamaoka > > Cc: 66457@debbugs.gnu.org > > > > On Wed, 11 Oct 2023 15:04:13 +0300, Eli Zaretskii wrote: > > > Thanks, but can you show a recipe to reproduce the issue and test the > > > solution? > > > > Ok, here is an example html mail. > > Set `mm-text-html-renderer' to `shr', read the example mail in > > Gnus in some way, and try `W D W' and `W D D' commands. > > Thanks. (That was an invalid mbox file, btw; I needed to fix it, but > that was easy. Also, I don't use Gnus, so if you can show a fill > recipe including the "read the example mail in Gnus in some way" part, > I'd appreciate that, as I'd like to make sure I see exactly what you > see in Gnus. Meanwhile, I tried in Rmail instead, which also uses > shr.el to display HTML emails.) > > So now I'm not sure I understand what you are saying. You said: > > > If an alt text, that has an `image-displayer' text property, is > > filled by `shr-fill-line' by way of `shr-fill-lines', the image > > is displayed for two or more times. It is because the > > `image-displayer' text property is divided by the newline(s). > > AFAIU, the alt text is text that is displayed instead of an image, > when the image cannot or should not be displayed for some reason. If > my understanding is correct, then why do you expect the alt text to > take only one line on display? > > > > From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 25 19:58:48 2023 Received: (at 66457) by debbugs.gnu.org; 25 Oct 2023 23:58:48 +0000 Received: from localhost ([127.0.0.1]:60234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvnlw-0002mC-Fn for submit@debbugs.gnu.org; Wed, 25 Oct 2023 19:58:48 -0400 Received: from mail-pl1-f178.google.com ([209.85.214.178]:43140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvnls-0002lx-Dc for 66457@debbugs.gnu.org; Wed, 25 Oct 2023 19:58:47 -0400 Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1c9e06f058bso11130085ad.0 for <66457@debbugs.gnu.org>; Wed, 25 Oct 2023 16:58:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698278288; x=1698883088; h=mime-version:organization:references:subject:cc:to:from:message-id :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7HWUMf6Efl3RgHI+V09AH6s4dn2lEj8OmR8G40GyXlo=; b=qmHebqRO+95WNmr7w4mG51iVXU7Z2ARXknH0rP21CSLGDEHcxrjCcsHMiCBNaLZ6ze EJrnU0qhXh7WjlLwi6uxh9v9inf0ksmbVN0VwrsEJc8jYiDGx/5/97c3+55Ji+T4zvxq uii7/i9IEQxB+pnnHPKEyNRydKPOiEBO5ipEWNeJchk934YZXMdrSRTdIRcdjsqMWGii DpzriCwd7QrarBRmbRvnn7z5+w39FusoVEBBERANoqprk5Sloz5spliA4XrXcXfRUfIa zzt54X8sg9ZiP2DbeFMA1podsNNgGKN/77psP7iVhXSli7f7Po6W8iOzH53TXGIiWM1P 38Vw== X-Gm-Message-State: AOJu0YyyhStAGcrkS2go0uxCHJhIrLQ8th3/oDS2cE2js6hKA8lpkb84 +w8g4Gyc8cxz9PPqLkqelQ== X-Google-Smtp-Source: AGHT+IGhqep912D66Ol09k6Xx1gw78+iLSwGc2relXhGgJ1Z3M/reO6yxDce0OcydS1z1N7C9tiEyg== X-Received: by 2002:a17:903:22d0:b0:1ca:e16f:a713 with SMTP id y16-20020a17090322d000b001cae16fa713mr1627376plg.2.1698278287745; Wed, 25 Oct 2023 16:58:07 -0700 (PDT) Received: from localhost (157-205-200-190.cns.tayoreru.com. [157.205.200.190]) by smtp.gmail.com with ESMTPSA id m17-20020a170902db1100b001c9c6a78a56sm9777841plx.97.2023.10.25.16.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 16:58:07 -0700 (PDT) Date: Thu, 26 Oct 2023 08:58:04 +0900 Message-ID: From: Katsumi Yamaoka To: Eli Zaretskii Subject: Re: bug#66457: 30.0.50; shr sometimes displays the same image twice References: <834jixv002.fsf@gnu.org> <831qe0v34m.fsf@gnu.org> <83y1fqizkv.fsf@gnu.org> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 66457 Cc: 66457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Wed, 25 Oct 2023 16:47:12 +0300, Eli Zaretskii wrote: > Ping! [...] >>> If an alt text, that has an `image-displayer' text property, is >>> filled by `shr-fill-line' by way of `shr-fill-lines', the image >>> is displayed for two or more times. It is because the >>> `image-displayer' text property is divided by the newline(s). >> AFAIU, the alt text is text that is displayed instead of an image, >> when the image cannot or should not be displayed for some reason. If >> my understanding is correct, then why do you expect the alt text to >> take only one line on display? Well, I don't think so, i.e., the alt text may be multiple lines. However, the author wrote shr-fill-line so to assume it to take a single line, or he only might have overlooked it.