From unknown Sat Aug 09 13:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66448] [PATCH] image: Add 'lba partition label. Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 10 Oct 2023 16:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66448@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169695544230299 (code B ref -1); Tue, 10 Oct 2023 16:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 10 Oct 2023 16:30:42 +0000 Received: from localhost ([127.0.0.1]:36811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqFd3-0007sd-JL for submit@debbugs.gnu.org; Tue, 10 Oct 2023 12:30:42 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqFcz-0007sJ-6A for submit@debbugs.gnu.org; Tue, 10 Oct 2023 12:30:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqFcV-0001Wv-OL for guix-patches@gnu.org; Tue, 10 Oct 2023 12:30:08 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqFcT-0000II-10 for guix-patches@gnu.org; Tue, 10 Oct 2023 12:30:07 -0400 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by chimborazo.ee.ethz.ch (Postfix) with ESMTP id 453014016E for ; Tue, 10 Oct 2023 18:29:30 +0200 (CEST) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10026) with ESMTP id 9EFF0I8rWwtt for ; Tue, 10 Oct 2023 18:29:29 +0200 (CEST) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA for ; Tue, 10 Oct 2023 18:29:29 +0200 (CEST) Date: Tue, 10 Oct 2023 18:29:26 +0200 From: Gabriel Wicki Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=129.132.2.15; envelope-from=gabriel@erlikon.ch; helo=chimborazo.ee.ethz.ch X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Some (embedded) system create FAT32/LBA partitions first, i thought this is too easy to not include in Guix. Please let me know if I can improve anything! TIA for review and merge >From c5080162e8a77f60aaf9a967a896f57c113dde47 Mon Sep 17 00:00:00 2001 Message-ID: From: Gabriel Wicki Date: Tue, 10 Oct 2023 18:02:04 +0200 Subject: [PATCH] image: Add 'lba partition label. * gnu/image.scm (validate-partition-flags): Add lba to the valid flags. * doc/guix.texi ('partition' Reference): Document it. --- doc/guix.texi | 10 ++++++---- gnu/image.scm | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index ad26a29513..95aae6ac02 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -45590,10 +45590,12 @@ partition Reference @item @code{flags} (default: @code{'()}) The partition flags as a list of symbols. Possible values are -@code{'boot} and @code{'esp}. The @code{'boot} flags should be set if -you want to boot from this partition. Exactly one partition should have -this flag set, usually the root one. The @code{'esp} flag identifies a -UEFI System Partition. +@code{'boot}, @code{'esp} and @code{'lba}. The @code{'boot} flags +should be set if you want to boot from this partition. Exactly one +partition should have this flag set, usually the root one. The +@code{'esp} flag identifies a UEFI System Partition. The @code{'lba} +flag @acronym{LBA, Local Block Addressing} allows for bigger FAT +partitions than 8GiB. @item @code{initializer} (default: @code{#false}) The partition initializer procedure as a gexp. This procedure is called diff --git a/gnu/image.scm b/gnu/image.scm index 523653dd77..493aea94cd 100644 --- a/gnu/image.scm +++ b/gnu/image.scm @@ -100,7 +100,7 @@ (define-with-syntax-properties (validate-partition-offset (value properties)) ;; The supported partition flags. (define-with-syntax-properties (validate-partition-flags (value properties)) - (let ((bad-flags (lset-difference eq? value '(boot esp)))) + (let ((bad-flags (lset-difference eq? value '(boot esp lba)))) (unless (and (list? value) (null? bad-flags)) (raise (make-compound-condition base-commit: f4e8baf3806e79d7111d2943859865ae4ee0b59d -- 2.41.0 From unknown Sat Aug 09 13:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66448] [PATCH] image: Add 'lba partition label. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Oct 2023 08:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki Cc: 66448@debbugs.gnu.org Received: via spool by 66448-submit@debbugs.gnu.org id=B66448.16970142999434 (code B ref 66448); Wed, 11 Oct 2023 08:52:01 +0000 Received: (at 66448) by debbugs.gnu.org; 11 Oct 2023 08:51:39 +0000 Received: from localhost ([127.0.0.1]:37474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqUwM-0002S6-WA for submit@debbugs.gnu.org; Wed, 11 Oct 2023 04:51:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqUwK-0002Rs-9Y for 66448@debbugs.gnu.org; Wed, 11 Oct 2023 04:51:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqUvr-0006HM-OV; Wed, 11 Oct 2023 04:51:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=SjZQG3ATLOkeYJM3vpw9gdwLgdLaz2LawDrHHB7DyHI=; b=XUmu9S0d6eR/TGGTp55v oh05wSZVlUt3DBlE+6LVE4kPPdUDufOTY3Z4lR7yr46OuLhDYDBKolJpxQmL7Hbqmg3AjhH5P+fKG TwWt/92fDEpmxn1q8U+CB3g6ikiGtrc1EjnGOmCdLPg853JjJgqkW5YIe5t5Rzmw7rv8kF/X6Oams +J+QyTTMhRoQ2Nlzb7urPVEl6mBotY8SeDjRtcJ8jQB8Pox7R010ZTzrIIOIyArXntrRRC4L0IxzK yk4nj7S6xR9T/seHmp8aDtT36a1+uZPF1naXcr8yIgrDRe82NMJZ426RfzfJBqGTat4LLqYhzP4fz nLvUP79O3a7JDw==; From: Mathieu Othacehe References: Date: Wed, 11 Oct 2023 10:51:03 +0200 In-Reply-To: (Gabriel Wicki's message of "Tue, 10 Oct 2023 18:29:26 +0200") Message-ID: <87o7h58ruw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > + (let ((bad-flags (lset-difference eq? value '(boot esp lba)))) I may be missing something, but don't we need something in make-vfat-image of (gnu build image) to take that one into account? Thanks, Mathieu From unknown Sat Aug 09 13:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66448] [PATCH] image: Add 'lba partition label. Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Oct 2023 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 66448@debbugs.gnu.org Received: via spool by 66448-submit@debbugs.gnu.org id=B66448.16970145889874 (code B ref 66448); Wed, 11 Oct 2023 08:57:02 +0000 Received: (at 66448) by debbugs.gnu.org; 11 Oct 2023 08:56:28 +0000 Received: from localhost ([127.0.0.1]:37478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqV11-0002ZB-MU for submit@debbugs.gnu.org; Wed, 11 Oct 2023 04:56:27 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:40271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqV0y-0002Yt-Ql for 66448@debbugs.gnu.org; Wed, 11 Oct 2023 04:56:26 -0400 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by chimborazo.ee.ethz.ch (Postfix) with ESMTP id EA3704006D; Wed, 11 Oct 2023 10:55:26 +0200 (CEST) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10026) with ESMTP id TLf2wrujclGh; Wed, 11 Oct 2023 10:55:26 +0200 (CEST) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA; Wed, 11 Oct 2023 10:55:25 +0200 (CEST) Date: Wed, 11 Oct 2023 10:55:23 +0200 From: Gabriel Wicki Message-ID: References: <87o7h58ruw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7h58ruw.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I didn't follow the whole source tree to figure out how all of this works, but this tiny change makes the image partition show up as LBA. From unknown Sat Aug 09 13:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66448] [PATCH] image: Add 'lba partition label. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 13 Oct 2023 13:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Gabriel Wicki Cc: 66448@debbugs.gnu.org Received: via spool by 66448-submit@debbugs.gnu.org id=B66448.169720218517062 (code B ref 66448); Fri, 13 Oct 2023 13:04:01 +0000 Received: (at 66448) by debbugs.gnu.org; 13 Oct 2023 13:03:05 +0000 Received: from localhost ([127.0.0.1]:45462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrHom-0004R7-Vh for submit@debbugs.gnu.org; Fri, 13 Oct 2023 09:03:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrHoj-0004Qb-46 for 66448@debbugs.gnu.org; Fri, 13 Oct 2023 09:03:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrHoF-0003qP-8Y; Fri, 13 Oct 2023 09:02:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=NEr3hAiqkWfYwJItTiQNh1reswKNV9O0D6cbCVaseIM=; b=Svo3qkdOR6g6t4PthG9M +AupEd2ghxQ7CU3gRHU/KTiM/lSdgOhd8kpDlFkvZypCME0rFOKMz4oo1BMwO6LWyuDggDZ6zPG/T 0F3Z/aiCJMR6tpSIlV3qt6Ur6FaHneRmjSk4I0zvOD3+r0hwQHGHMl7PfkXysJWmZeX3UDcQVEOhO u9A+fx4FPAF3y59jVMEwL5Nr3teTpoIRIMKcT2lNxivfKByccB2AGK9Cy/9QCYFHRtap56wMKXqjD hiYrGmz1OWd0kkj60jNaI5bQQmRQsOYNThRy3ZLiHnbzxowlE0cxygiXLLHiHl84Cnxr0/crZKHds GA0yNbppvTgQYQ==; From: Mathieu Othacehe References: <87o7h58ruw.fsf@gnu.org> Date: Fri, 13 Oct 2023 15:02:25 +0200 In-Reply-To: (Gabriel Wicki's message of "Wed, 11 Oct 2023 10:55:23 +0200") Message-ID: <87h6mud6am.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > I didn't follow the whole source tree to figure out how all of this > works, but this tiny change makes the image partition show up as LBA. I had a closer look, this flag has no effect at all. If the 'esp flag is set then the MBR partition type is set to 0xEF (EFI partition). If the flag is removed, then depending on the file-system type: "fat16" or "fat32", the partition type will be 0x0E or 0x0C which are respectively FAT16 with LBA an FAT32 with LBA. I guess that by removing the 'esp flag and adding the 'lba flag you ended up with an LBA partition. That was the consequence of removing the 'esp flag, not adding the 'lba flag. The partition type is specified in the partition->dos-type procedure of (gnu system image). The corresponding types can be found here: https://en.wikipedia.org/wiki/Partition_type. We could improve the documentation here by stating that fat16 and fat32 partitions are by default LBA compatible, but the source modification in not needed. Thanks, Mathieu From unknown Sat Aug 09 13:14:36 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66448] [PATCH] image: Add 'lba partition label. Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Oct 2023 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66448 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 66448@debbugs.gnu.org Received: via spool by 66448-submit@debbugs.gnu.org id=B66448.169754570515581 (code B ref 66448); Tue, 17 Oct 2023 12:29:02 +0000 Received: (at 66448) by debbugs.gnu.org; 17 Oct 2023 12:28:25 +0000 Received: from localhost ([127.0.0.1]:58781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsjBR-00043F-8e for submit@debbugs.gnu.org; Tue, 17 Oct 2023 08:28:25 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]:46713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsjBN-00042x-6n for 66448@debbugs.gnu.org; Tue, 17 Oct 2023 08:28:24 -0400 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by chimborazo.ee.ethz.ch (Postfix) with ESMTP id 1CCA940146; Tue, 17 Oct 2023 14:27:50 +0200 (CEST) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10026) with ESMTP id TxwLtgI0Hfti; Tue, 17 Oct 2023 14:27:49 +0200 (CEST) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA; Tue, 17 Oct 2023 14:27:49 +0200 (CEST) Date: Tue, 17 Oct 2023 14:27:46 +0200 From: Gabriel Wicki Message-ID: References: <87o7h58ruw.fsf@gnu.org> <87h6mud6am.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h6mud6am.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Mathieu Thanks for looking into it. And yes, that was exactly what happened. Plus i was tricked by my own setup (for once showing the LBA label and another time not). Oh well (: I've attached a possible patch for the documentation. Thanks again for the review and the clarification of the issue. Best regards >From eacb1696cdc51350e3d5d223b94a2546c459d2ea Mon Sep 17 00:00:00 2001 Message-ID: From: Gabriel Wicki Date: Tue, 17 Oct 2023 14:16:51 +0200 Subject: [PATCH] doc: Clarify partition LBA compatibility. * doc/guix.texi (partition Reference): Clarify LBA compatibility. --- doc/guix.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guix.texi b/doc/guix.texi index 3517c95251..6b6d166290 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -45649,7 +45649,8 @@ partition Reference @item @code{file-system} (default: @code{"ext4"}) The partition file system as a string, defaulting to @code{"ext4"}. The supported values are @code{"vfat"}, @code{"fat16"}, @code{"fat32"} and -@code{"ext4"}. +@code{"ext4"}. @code{"vfat"}, @code{"fat16"} and @code{"fat32"} +partitions without the @code{'esp} flag are by default LBA compatible. @item @code{file-system-options} (default: @code{'()}) The partition file system creation options that should be passed to the base-commit: d389f6777359aa44ef9c71989fc1f49e6b222f1d -- 2.41.0 From unknown Sat Aug 09 13:14:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Gabriel Wicki Subject: bug#66448: closed (Re: bug#66448: [PATCH] image: Add 'lba partition label.) Message-ID: References: <87bkcxmlyy.fsf@gnu.org> X-Gnu-PR-Message: they-closed 66448 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 66448@debbugs.gnu.org Date: Tue, 17 Oct 2023 13:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1697548442-31396-1" This is a multi-part message in MIME format... ------------=_1697548442-31396-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66448: [PATCH] image: Add 'lba partition label. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66448@debbugs.gnu.org. --=20 66448: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66448 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1697548442-31396-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66448-done) by debbugs.gnu.org; 17 Oct 2023 13:13:15 +0000 Received: from localhost ([127.0.0.1]:58862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsjsp-00089C-B1 for submit@debbugs.gnu.org; Tue, 17 Oct 2023 09:13:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsjsl-00088w-EW for 66448-done@debbugs.gnu.org; Tue, 17 Oct 2023 09:13:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsjsG-0006Z3-AJ; Tue, 17 Oct 2023 09:12:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=aa0Ldfq9P4yxjr8cwQxR+Tma0rz+X0kOus+XMCFkY9M=; b=QoS4C+JTv+qZO9Yk283y wokr4tgGRIBUZRuxlQDXAgfMNX6AiQunrXFMO+a5mXC9ronrig7ccW5PhzqMAkLct5WfEDuKcqCSr cYG4DlCwKl+5XoqjZl9sAeybHmFWvcTOsfTxnKcSLrk6AZlBxxXqF8472TQLSkP49bG5v1ZqGooUp Qx674kmKgBMOEPk7/kQuwnZERzpx0Ikq6ag+mcWPy2Byi0numKHSjWu3TBdOnhVT66fYL3xXVEow+ nvrCfJU10YhqjK5nQLtd7aTXW09wt1YR2MSu7i++ZYnWqowxOlGshUgsymf+J6lHrKSWUUDxqyGkQ C4mmNnObSmjBSg==; From: Mathieu Othacehe To: Gabriel Wicki Subject: Re: bug#66448: [PATCH] image: Add 'lba partition label. In-Reply-To: (Gabriel Wicki's message of "Tue, 17 Oct 2023 14:27:46 +0200") References: <87o7h58ruw.fsf@gnu.org> <87h6mud6am.fsf@gnu.org> Date: Tue, 17 Oct 2023 15:12:37 +0200 Message-ID: <87bkcxmlyy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66448-done Cc: 66448-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > I've attached a possible patch for the documentation. Perfect. Applied! Thanks, Mathieu ------------=_1697548442-31396-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Oct 2023 16:30:42 +0000 Received: from localhost ([127.0.0.1]:36811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqFd3-0007sd-JL for submit@debbugs.gnu.org; Tue, 10 Oct 2023 12:30:42 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqFcz-0007sJ-6A for submit@debbugs.gnu.org; Tue, 10 Oct 2023 12:30:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqFcV-0001Wv-OL for guix-patches@gnu.org; Tue, 10 Oct 2023 12:30:08 -0400 Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqFcT-0000II-10 for guix-patches@gnu.org; Tue, 10 Oct 2023 12:30:07 -0400 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by chimborazo.ee.ethz.ch (Postfix) with ESMTP id 453014016E for ; Tue, 10 Oct 2023 18:29:30 +0200 (CEST) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from chimborazo.ee.ethz.ch ([129.132.2.15]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10026) with ESMTP id 9EFF0I8rWwtt for ; Tue, 10 Oct 2023 18:29:29 +0200 (CEST) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by chimborazo.ee.ethz.ch (Postfix) with ESMTPSA for ; Tue, 10 Oct 2023 18:29:29 +0200 (CEST) Date: Tue, 10 Oct 2023 18:29:26 +0200 From: Gabriel Wicki To: guix-patches@gnu.org Subject: [PATCH] image: Add 'lba partition label. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=129.132.2.15; envelope-from=gabriel@erlikon.ch; helo=chimborazo.ee.ethz.ch X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Some (embedded) system create FAT32/LBA partitions first, i thought this is too easy to not include in Guix. Please let me know if I can improve anything! TIA for review and merge >From c5080162e8a77f60aaf9a967a896f57c113dde47 Mon Sep 17 00:00:00 2001 Message-ID: From: Gabriel Wicki Date: Tue, 10 Oct 2023 18:02:04 +0200 Subject: [PATCH] image: Add 'lba partition label. * gnu/image.scm (validate-partition-flags): Add lba to the valid flags. * doc/guix.texi ('partition' Reference): Document it. --- doc/guix.texi | 10 ++++++---- gnu/image.scm | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index ad26a29513..95aae6ac02 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -45590,10 +45590,12 @@ partition Reference @item @code{flags} (default: @code{'()}) The partition flags as a list of symbols. Possible values are -@code{'boot} and @code{'esp}. The @code{'boot} flags should be set if -you want to boot from this partition. Exactly one partition should have -this flag set, usually the root one. The @code{'esp} flag identifies a -UEFI System Partition. +@code{'boot}, @code{'esp} and @code{'lba}. The @code{'boot} flags +should be set if you want to boot from this partition. Exactly one +partition should have this flag set, usually the root one. The +@code{'esp} flag identifies a UEFI System Partition. The @code{'lba} +flag @acronym{LBA, Local Block Addressing} allows for bigger FAT +partitions than 8GiB. @item @code{initializer} (default: @code{#false}) The partition initializer procedure as a gexp. This procedure is called diff --git a/gnu/image.scm b/gnu/image.scm index 523653dd77..493aea94cd 100644 --- a/gnu/image.scm +++ b/gnu/image.scm @@ -100,7 +100,7 @@ (define-with-syntax-properties (validate-partition-offset (value properties)) ;; The supported partition flags. (define-with-syntax-properties (validate-partition-flags (value properties)) - (let ((bad-flags (lset-difference eq? value '(boot esp)))) + (let ((bad-flags (lset-difference eq? value '(boot esp lba)))) (unless (and (list? value) (null? bad-flags)) (raise (make-compound-condition base-commit: f4e8baf3806e79d7111d2943859865ae4ee0b59d -- 2.41.0 ------------=_1697548442-31396-1--