GNU bug report logs - #66436
[PATCH] doc: Add some guidelines for reviewing.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 66436 <at> debbugs.gnu.org, dev <at> jpoiret.xyz, zimon.toutoune <at> gmail.com
Subject: [bug#66436] [PATCH v3] doc: Add some guidelines for reviewing.
Date: Sun, 05 Nov 2023 15:51:32 +0100

Hello,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New
> section.
> (Debbugs Usertags): Expound with Emacs Debbugs information and document the
> 'reviewed-looks-good' usertag.
>
> Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b
> ---
>
> Changes in v3:
>  - Replace LGTM with Reviewed-by Git tag
>  - Add b4 config
>  - Link to the Submitting Patches section for check list
>  - Fuse further suggestions by both Ludovic and Simon

Could you mention the b4 change in the commit log?  Otherwise LGTM!

> +[b4]
> +        attestation-check-dkim = off
> +        attestation-policy = off
> +        linkmask = https://yhetil.org/guix/%s
> +        linktrailermask = https://yhetil.org/guix/%s
> +        midmask = https://yhetil.org/guix/%s

Really cool to have the b4 workflow documented and a default config in
place!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.