GNU bug report logs - #66436
[PATCH] doc: Add some guidelines for reviewing.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Tue, 10 Oct 2023 12:56:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 66436 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>, Clément Lassieur <clement <at> lassieur.org>
Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing.
Date: Tue, 31 Oct 2023 20:03:47 +0100

Hi Maxim,

On Tue, 31 Oct 2023 at 19:53, Maxim Cournoyer <maxim.cournoyer <at> gmail.com> wrote:

> >> IMHO, it is worth to clearly state:

[...]

> That's already mentioned in 'Submitting Patches':

[...]

> I don't think we should repeat it here :-) (also, we now have CI, which
> should be more apt at catching breakage here).

We are listing the expectations for the Review process, therefore
repeat that the dependencies need to be checked at Review time makes
sense to me.  It can be a sentence as: "make sure CI does not report
new error" or something like that.

Cheers,
simon
This bug report was last modified 1 year and 275 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.