From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 10 Oct 2023 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66436@debbugs.gnu.org, maxim.cournoyer@gmail.com X-Debbugs-Original-To: guix-patches@gnu.org, maxim.cournoyer@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.16969425161050 (code B ref -1); Tue, 10 Oct 2023 12:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Oct 2023 12:55:16 +0000 Received: from localhost ([127.0.0.1]:34247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqCGY-0000Gr-OH for submit@debbugs.gnu.org; Tue, 10 Oct 2023 08:55:15 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqCGU-0000Ga-EF for submit@debbugs.gnu.org; Tue, 10 Oct 2023 08:55:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqCG3-0002yr-Hn for guix-patches@gnu.org; Tue, 10 Oct 2023 08:54:43 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqCG1-0004Zf-NF for guix-patches@gnu.org; Tue, 10 Oct 2023 08:54:43 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-77386822cfbso379469785a.0 for ; Tue, 10 Oct 2023 05:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696942480; x=1697547280; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=G8kBbFenunZSNMWvsvKTKp+fnxuuUp9i29bT2ST8UQQ=; b=OH2xUnuNvU3F+trJBcC7M38BXxkGVq3YmV6p53LnjarTrZT3MGBxBEob2TnZ5FRRwB Lq6VGijxZmTmnCGdADzcuSjaE7ot80vmgQB/12TV2c2/7Zy1cWAXDOsyIRvNsa4x9yC6 w969ckrMPsEgd6GZFnNNxS3gvXd/jWhWqLpLpfgBT34KCriiv2s6oKKYjA1DAzlDOFJJ mIzq1GnqvDaWj5IiNpDAhD2fo1GocM2ounM9vDGALczyUYW0Np073kBBH38lHvX+VMFr bh2/zTph0cQaTS5+gpSvtjhm4h5UxWkg9ynxi0AaORMvVNQwU+NDyegALdvrf32bGXOt Lt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696942480; x=1697547280; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G8kBbFenunZSNMWvsvKTKp+fnxuuUp9i29bT2ST8UQQ=; b=bZij2d7vDjf9TeiubijNFhfVkq80ipelHOv70E0Pjydu66QViBZhKbhhW0iSChBtv/ oCpX+mtS879dx57sR9zkNrg6p4GpG48UinXBoyJHvut63c+gmf6hg8/HytVKb4BoPTDA 2Nwr4F0MZHi8fdkcJTdaJeGL9a4oMhJi8g023Adk2iuibxQFMj05pwDsAI9YnFsw5G+a UmT4KikWtnJ0i41Z94GmYY0rQRGz9aVV0rvGnAw1sV1+va/gqbT2h0c4RrA8nw4IhVtB 6bJlSKEqw8SsTAgMT9RadWgTFjnAB2KFRTdhkXvKO8PIvbZWUX8VfHC9wBvbm5LplzAn NxhA== X-Gm-Message-State: AOJu0Yy5izQ8bH6Wlawu6jh7pLAieKxRJ4tf/sy8LgfDKhwzC0B+6dR8 ZI+iuynR0osADMIRREvtIy/SWu02nt+65A== X-Google-Smtp-Source: AGHT+IG3UtpGFBBsTc/bl4NKKkYzedVNl5OuQ1aCLkiS7ki1VMz7szPGkuKZ1qX2jE6UjucaBpaD6Q== X-Received: by 2002:a05:620a:4106:b0:774:2a7f:fa24 with SMTP id j6-20020a05620a410600b007742a7ffa24mr23197905qko.25.1696942480103; Tue, 10 Oct 2023 05:54:40 -0700 (PDT) Received: from localhost.localdomain (dsl-10-149-16.b2b2c.ca. [72.10.149.16]) by smtp.gmail.com with ESMTPSA id w19-20020a05620a149300b0076eee688a95sm4315688qkj.0.2023.10.10.05.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:54:39 -0700 (PDT) From: Maxim Cournoyer Date: Tue, 10 Oct 2023 08:54:27 -0400 Message-ID: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x733.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New section. * doc/contributing.texi (Debbugs Usertags): Expound with Emacs Debbugs information and document the 'reviewed-looks-good' usertag. Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b --- doc/contributing.texi | 53 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 864190b119..b09e9cc299 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -29,6 +29,7 @@ Contributing * Submitting Patches:: Share your work. * Tracking Bugs and Changes:: Keeping it all organized. * Commit Access:: Pushing to the official repository. +* Reviewing the Work of Others:: Some guidelines for sharing reviews. * Updating the Guix Package:: Updating the Guix package definition. * Writing Documentation:: Improving documentation in GNU Guix. * Translating Guix:: Make Guix speak your native language. @@ -605,7 +606,7 @@ Packaging Guidelines * Version Numbers:: When the name is not enough. * Synopses and Descriptions:: Helping users find the right package. * Snippets versus Phases:: Whether to use a snippet, or a build phase. -* Cyclic Module Dependencies:: Going full circle. +* Cyclic Module Dependencies:: Going full circle. * Emacs Packages:: Your Elisp fix. * Python Modules:: A touch of British comedy. * Perl Modules:: Little pearls. @@ -1972,7 +1973,12 @@ Debbugs Usertags tag any bug with an arbitrary label. Bugs can be searched by usertag, so this is a handy way to organize bugs@footnote{The list of usertags is public information, and anyone can modify any user's list of usertags, -so keep that in mind if you choose to use this feature.}. +so keep that in mind if you choose to use this feature.}. If you use +Emacs Debbugs, the entry-point to consult existing usertags is the +@samp{C-u M-x debbugs-gnu-usertags} procedure. To set a usertag, press +@samp{C} while consulting a bug within the *Guix-Patches* buffer opened +with @samp{C-u M-x debbugs-gnu-bugs} buffer, then select @code{usertag} +and follow the instructions. For example, to view all the bug reports (or patches, in the case of @code{guix-patches}) tagged with the usertag @code{powerpc64le-linux} @@ -1985,9 +1991,9 @@ Debbugs Usertags to interact with Debbugs. In Guix, we are experimenting with usertags to keep track of -architecture-specific issues. To facilitate collaboration, all our -usertags are associated with the single user @code{guix}. The following -usertags currently exist for that user: +architecture-specific issues, as well as reviewed ones. To facilitate +collaboration, all our usertags are associated with the single user +@code{guix}. The following usertags currently exist for that user: @table @code @@ -2005,6 +2011,9 @@ Debbugs Usertags appropriate to assign this usertag to a bug report for a package that fails to build reproducibly. +@item reviewed-looks-good +You have reviewed the series and it looks good to you (LGTM). + @end table If you're a committer and you want to add a usertag, just start using it @@ -2237,6 +2246,40 @@ Commit Access you're welcome to use your expertise and commit rights to help other contributors, too! +@node Reviewing the Work of Others +@section Reviewing the Work of Others + +Perhaps the biggest action you can do to help GNU Guix grow as a project +is to review the work contributed by others. You do not need to be a +committer to do so; applying, building, linting and running other +people's series and sharing your comments about your experience will +give some confidence to committers that should result in the proposed +change being merged faster. + +@cindex LGTM, Looks Good To Me +@cindex reviewing, guidelines +Review comments should be unambiguous; be as clear and explicit as you +can about what you think should be changed, ensuring the author can take +action on it. The following well understood/codified @acronym{LGTM, +Looks Good To Me} phrases should be used to sign off as a reviewer, +meaning you have reviewed the change and that it looks good to you: + +@enumerate +@item +If the @emph{whole} series (containing multiple commits) looks good to +you, reply with a @samp{This series LGTM!} to the cover page if it has +one, or to the last patch of the series otherwise. + +@item +If you instead want to mark a @emph{single commit} as reviewed (but not +the whole series), simply reply with @samp{LGTM!} to that commit +message. +@end enumerate + +If you are not a committer, you can help others find a @emph{series} you +have reviewed more easily by adding a @code{reviewed-looks-good} usertag +for the @code{guix} user (@pxref{Debbugs Usertags}). + @node Updating the Guix Package @section Updating the Guix Package base-commit: 619ff2fa1d5b60b5fe33216ca2d6219c04a5515b -- 2.41.0 From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH] doc: Add some guidelines for reviewing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 10 Oct 2023 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169694462415468 (code B ref 66436); Tue, 10 Oct 2023 13:31:02 +0000 Received: (at 66436) by debbugs.gnu.org; 10 Oct 2023 13:30:24 +0000 Received: from localhost ([127.0.0.1]:34322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqCoZ-00041N-8i for submit@debbugs.gnu.org; Tue, 10 Oct 2023 09:30:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqCoW-000419-Md for 66436@debbugs.gnu.org; Tue, 10 Oct 2023 09:30:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqCo6-0004C8-3R; Tue, 10 Oct 2023 09:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=A3/wQvjXHC0vcxWatXpUTvqO71aCQbOxALV95NNyAmo=; b=GUnCW2foClk8GJJEmvq/ tk9YXoDYJUHKAhwpjRF9yrfgkyZG/KhrWAekIoCqLr3XdJ2g6bjExf3NAe0QaX/n4WQ7w2B/s1Fjd 72SJWxujnpWMR3hv4EPXFoW+Srmrm8csZav8dPXw+UmrnZfhRLViOxbqvqh1nw7sMyqi4dAroNOFr kG0CQ/K1+l7TEHbCVxH07N7Cik42ogdhJ2yzwauJUlmBAuOl51cwloKUdi0+FVsp+QI00qrD6sbGu PLfL0EuyAybWLyTHCYNfUXMv/+bUpE9tEHRL+JTjfzKT5FPXsapjXneHGodzpRo8P8n1xPFlSDM8j Fgqxycah3LHgHw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 10 Oct 2023 08:54:27 -0400") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> Date: Tue, 10 Oct 2023 15:29:37 +0200 Message-ID: <87r0m2wqpq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, This looks great to me! Maxim Cournoyer skribis: > +@cindex LGTM, Looks Good To Me > +@cindex reviewing, guidelines > +Review comments should be unambiguous; be as clear and explicit as you > +can about what you think should be changed, ensuring the author can take > +action on it. I=E2=80=99d add a few guidelines here, and perhaps we can make it a bullet list: 1. Be clear and explicit about changes you are suggesting, ensuring the author can take action on it. In particular, it is a good idea to explicitly ask for new revisions when you want it. 2. Remain focused: do not change the scope of the work being reviewed. For example, if the contribution touches a code that follows a pattern deemed unwieldy, it would be unfair to ask the submitter to fix all occurrences of that pattern in the code; to put it simply, if an problem unrelated to the patch at hand was already there, do not ask the submitter to fix it. 3. Ensure progress. As they respond to review, submitters may submit new revisions of their changes; avoid requesting changes that you did not request in the previous round of comments. Overall, the submitter should get a clear sense of progress; the number of items open for discussion should clearly decrease over time. 4. Review is a discussion. The submitter's and reviewer's views on how to achieve a particular change may not always be aligned. As a reviewer, try hard to explain the rationale for suggestions you make, and to understand and take into account the submitter's motivation for doing things in a certain way. 5. Aim for finalization. Reviewing code is time-consuming. Your goal as a reviewer is to put the process on a clear path towards integration, possibly with agreed-upon changes, or rejection, with a clear and mutually-understood reasoning. Avoid leaving the review process in a lingering state with no clear way out. I just made it up but I=E2=80=99m sure there are good review guidelines out there that we could use as an example. My 2=C2=A2, Ludo=E2=80=99. From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> In-Reply-To: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: maxim.cournoyer@gmail.com, ludo@gnu.org, guix-patches@gnu.org Resent-Date: Wed, 11 Oct 2023 00:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66436@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer , Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-Xcc: Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169698388717638 (code B ref 66436); Wed, 11 Oct 2023 00:25:02 +0000 Received: (at 66436) by debbugs.gnu.org; 11 Oct 2023 00:24:47 +0000 Received: from localhost ([127.0.0.1]:37183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqN1q-0004aQ-Hr for submit@debbugs.gnu.org; Tue, 10 Oct 2023 20:24:47 -0400 Received: from mail-qv1-xf2b.google.com ([2607:f8b0:4864:20::f2b]:61602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqN1m-0004a6-Gg for 66436@debbugs.gnu.org; Tue, 10 Oct 2023 20:24:45 -0400 Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-66d01345d73so3708776d6.2 for <66436@debbugs.gnu.org>; Tue, 10 Oct 2023 17:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696983855; x=1697588655; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XrQH8uTi2PNi7eIZX2jE67w381DSDyiihJBLQImx08g=; b=TbztkL52IXj0A37vM2uD2vq07XvF8/QpKykcAocwX7brSYJUTWnGNfTX0HMTMQm/fY VtgPqg+tv+q0q4xrwRWemM4YmbDKUt1D7U1F51igq33jR6Cc8g58HwpUuOkQ85T30JsT vHW7ilBMrD0yFrP7oAkEZinj30N7PzbGpizyLaByzgTmniY6tEJxSirIz2QfW+OyBCY9 K6jkINq1C2ht2HjRk7DN1OnuDlCzYvJRNDtDZ8mRGv643oTuhppwJTYP8KO4DI3ltj4R BdW3WD/hj0eq1aG9SGkGJX92FvnvkbXXN92EWeJKoKGIz6Wg0I+KvgNrfZgDIuJ8qTVh ikYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696983855; x=1697588655; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XrQH8uTi2PNi7eIZX2jE67w381DSDyiihJBLQImx08g=; b=fK48X0m+T1QlO6jgE6mZH9kBbHQ+5CWN+otfP1GLxAZQdHCyQ24TZK/mZt0z08wPK3 BAJwTmzGEiUc+OCEPCDYk9Pk8VcR2yPxAuBN7tWIPjqwV1y2GcHCpoeT4DGcivRqaXtL Ebuhr7eIuUZ4bVrR/6YXJqiy7LYt2jN9HJroodY7anyFqCU0jpcWDP6kE+uN6cT/+ReN YfmWHY6SjxOeHZDhWofjJ1xxuxdlwQgIy8YCoAiyJqy9WPjEQhCDur7Ufjd2c79zESUw I4Pn568zty+E4LXqsNpH80b8IdsORPyqOmuY9zY8tfTCVscPTcGG9Gj3aOr2BkkSOre2 K5gw== X-Gm-Message-State: AOJu0YxUDKlwjD/wyn8Z8YAxhnrIa6beDs6n6sh4x2kkTHdVBri16Mwi c29et9AtLBe5T4PV+9x+AFIhkz81/BNLVA== X-Google-Smtp-Source: AGHT+IGLbNYBhVb6bud3DUdAPYT7TiaJXDLFg+I//xnR/fXLyqLujTOhbXPV6rRgqmfWLkygMjwc1A== X-Received: by 2002:a0c:f1c9:0:b0:66c:eff1:73d0 with SMTP id u9-20020a0cf1c9000000b0066ceff173d0mr3214059qvl.14.1696983855119; Tue, 10 Oct 2023 17:24:15 -0700 (PDT) Received: from localhost.localdomain (dsl-10-149-16.b2b2c.ca. [72.10.149.16]) by smtp.gmail.com with ESMTPSA id i19-20020a0cf393000000b00632209f7157sm5134851qvk.143.2023.10.10.17.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 17:24:14 -0700 (PDT) From: Maxim Cournoyer Date: Tue, 10 Oct 2023 20:24:05 -0400 Message-ID: <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New section. * doc/contributing.texi (Debbugs Usertags): Expound with Emacs Debbugs information and document the 'reviewed-looks-good' usertag. Series-version: 2 Series-cc: ludo@gnu.org Series-to: 66436@debbugs.gnu.org Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b Co-authored-by: Ludovic Courtès --- v2: integrate guidelines suggested by Ludovic doc/contributing.texi | 93 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 88 insertions(+), 5 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 864190b119..b8a0839c7f 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -29,6 +29,7 @@ Contributing * Submitting Patches:: Share your work. * Tracking Bugs and Changes:: Keeping it all organized. * Commit Access:: Pushing to the official repository. +* Reviewing the Work of Others:: Some guidelines for sharing reviews. * Updating the Guix Package:: Updating the Guix package definition. * Writing Documentation:: Improving documentation in GNU Guix. * Translating Guix:: Make Guix speak your native language. @@ -605,7 +606,7 @@ Packaging Guidelines * Version Numbers:: When the name is not enough. * Synopses and Descriptions:: Helping users find the right package. * Snippets versus Phases:: Whether to use a snippet, or a build phase. -* Cyclic Module Dependencies:: Going full circle. +* Cyclic Module Dependencies:: Going full circle. * Emacs Packages:: Your Elisp fix. * Python Modules:: A touch of British comedy. * Perl Modules:: Little pearls. @@ -1972,7 +1973,12 @@ Debbugs Usertags tag any bug with an arbitrary label. Bugs can be searched by usertag, so this is a handy way to organize bugs@footnote{The list of usertags is public information, and anyone can modify any user's list of usertags, -so keep that in mind if you choose to use this feature.}. +so keep that in mind if you choose to use this feature.}. If you use +Emacs Debbugs, the entry-point to consult existing usertags is the +@samp{C-u M-x debbugs-gnu-usertags} procedure. To set a usertag, press +@samp{C} while consulting a bug within the *Guix-Patches* buffer opened +with @samp{C-u M-x debbugs-gnu-bugs} buffer, then select @code{usertag} +and follow the instructions. For example, to view all the bug reports (or patches, in the case of @code{guix-patches}) tagged with the usertag @code{powerpc64le-linux} @@ -1985,9 +1991,9 @@ Debbugs Usertags to interact with Debbugs. In Guix, we are experimenting with usertags to keep track of -architecture-specific issues. To facilitate collaboration, all our -usertags are associated with the single user @code{guix}. The following -usertags currently exist for that user: +architecture-specific issues, as well as reviewed ones. To facilitate +collaboration, all our usertags are associated with the single user +@code{guix}. The following usertags currently exist for that user: @table @code @@ -2005,6 +2011,9 @@ Debbugs Usertags appropriate to assign this usertag to a bug report for a package that fails to build reproducibly. +@item reviewed-looks-good +You have reviewed the series and it looks good to you (LGTM). + @end table If you're a committer and you want to add a usertag, just start using it @@ -2237,6 +2246,80 @@ Commit Access you're welcome to use your expertise and commit rights to help other contributors, too! +@node Reviewing the Work of Others +@section Reviewing the Work of Others + +Perhaps the biggest action you can do to help GNU Guix grow as a project +is to review the work contributed by others. You do not need to be a +committer to do so; applying, reading the source, building, linting and +running other people's series and sharing your comments about your +experience will give some confidence to committers, and should result in +the proposed change being merged faster. + +@cindex reviewing, guidelines +Review comments should be unambiguous; be as clear and explicit as you +can about what you think should be changed, ensuring the author can take +action on it. Please try to keep the following guidelines in mind +during review: + +@enumerate +@item +@emph{Be clear and explicit about changes you are suggesting}, ensuring +the author can take action on it. In particular, it is a good idea to +explicitly ask for new revisions when you want it. + +@item +@emph{Remain focused: do not change the scope of the work being +reviewed.} For example, if the contribution touches code that follows a +pattern deemed unwieldy, it would be unfair to ask the submitter to fix +all occurrences of that pattern in the code; to put it simply, if a +problem unrelated to the patch at hand was already there, do not ask the +submitter to fix it. + +@item +@emph{Ensure progress.} As they respond to review, submitters may +submit new revisions of their changes; avoid requesting changes that you +did not request in the previous round of comments. Overall, the +submitter should get a clear sense of progress; the number of items open +for discussion should clearly decrease over time. + +@item +@emph{Review is a discussion.} The submitter's and reviewer's views on +how to achieve a particular change may not always be aligned. As a +reviewer, try hard to explain the rationale for suggestions you make, +and to understand and take into account the submitter's motivation for +doing things in a certain way. + +@item +@emph{Aim for finalization.} Reviewing code is time-consuming. Your +goal as a reviewer is to put the process on a clear path towards +integration, possibly with agreed-upon changes, or rejection, with a +clear and mutually-understood reasoning. Avoid leaving the review +process in a lingering state with no clear way out. +@end enumerate + +@cindex LGTM, Looks Good To Me +When you deem the proposed change adequate and ready for inclusion +within Guix, the following well understood/codified @acronym{LGTM, Looks +Good To Me} phrases should be used to sign off as a reviewer, meaning +you have reviewed the change and that it looks good to you: + +@itemize +@item +If the @emph{whole} series (containing multiple commits) looks good to +you, reply with a @samp{This series LGTM!} to the cover page if it has +one, or to the last patch of the series otherwise. + +@item +If you instead want to mark a @emph{single commit} as reviewed (but not +the whole series), simply reply with @samp{LGTM!} to that commit +message. +@end itemize + +If you are not a committer, you can help others find a @emph{series} you +have reviewed more easily by adding a @code{reviewed-looks-good} usertag +for the @code{guix} user (@pxref{Debbugs Usertags}). + @node Updating the Guix Package @section Updating the Guix Package base-commit: 5a8f9d32f5196263bc50c2059bac4c4226784a59 -- 2.41.0 From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 0/2] Add support for Git Large File Storage (LFS). References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> In-Reply-To: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: maxim.cournoyer@gmail.com, ludo@gnu.org, guix@cbaines.net, dev@jpoiret.xyz, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Thu, 12 Oct 2023 02:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66436@debbugs.gnu.org Cc: Maxim Cournoyer , Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines , Josselin Poiret , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-Xcc: Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines , Josselin Poiret , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169707897813973 (code B ref 66436); Thu, 12 Oct 2023 02:50:01 +0000 Received: (at 66436) by debbugs.gnu.org; 12 Oct 2023 02:49:38 +0000 Received: from localhost ([127.0.0.1]:40293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqllW-0003d7-1W for submit@debbugs.gnu.org; Wed, 11 Oct 2023 22:49:38 -0400 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]:58678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqllQ-0003ci-EN for 66436@debbugs.gnu.org; Wed, 11 Oct 2023 22:49:32 -0400 Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-77412b91c41so31616085a.1 for <66436@debbugs.gnu.org>; Wed, 11 Oct 2023 19:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697078940; x=1697683740; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qDFlAJJjouGwwLSL9KA3dYgCcwwL8Jh0WuZy8NWlQBE=; b=VyAJMAioSHVdBDJtQWnxdbhDTHorIOaz+raSpxXL6DYKa4Ikv9gnCyLwOEPCnjAD5E SkskZyagQ6SeVyjFEk/+8H5ZFfhl3Hdx4mGUh5ZT3a4l2aZ7PTU8PMJzxOP8ghOH+7wI gLwJOAbXAKvi0XIuQ1dzeoB1hdMwWYoD+LFCtly4lGwILNFUUEi1m/Lkqr9wjWk9rMX5 Er2YxgqUrPF6yAyPP/hZTTh89CwVG6mZvJJUA3XMABQwxBGHhJUPAmrh0HSaqFDBibbM MkBS7Ti6gR6NtEVJBJrDDgkH7P4p7rb9UoX4Ciqacc7vlSFSqDM/sm9YQj5S7wuGQAMK V65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697078940; x=1697683740; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qDFlAJJjouGwwLSL9KA3dYgCcwwL8Jh0WuZy8NWlQBE=; b=aMwJN4ppby0Waf7Dba62+PSP6LqlKy1Bza5NCNXdGRG+FzULu3y6Y/Ruq0GGc5E0vM PbzKrpYgKmbwiI0ODphXPAZ/M93/JAP0Ph/W3qjY1qpxduv4dd3kiBzlNDLLvchIIoVa EFrJX14esg7k0uMk33IDqfdr+okP1gJIHsIe5hnzfI/aZwP2ua5xImuDTq+Sx7Se1M4Z EsQiOMr+zXP+jNsrDRUdgehjwzG4hGsZBvaCiMpRTEQWSpb8jyua+FT1D+2VdoOIE3Hw MhCve42NmYZWl9LBLxGr0Thbe1GD6QXYgXxRto4owxm8+eXcsG+CewuH1dnrWaQGsrFY OD+Q== X-Gm-Message-State: AOJu0YzH50RCooFZr7MzrM+azdqco4XLVAF9hQitOLWgkwQl4hZm2DAI EWOQpl+iNDAQUiV1ZaEcbOjq6Dxvt8E= X-Google-Smtp-Source: AGHT+IHxana2FPKcEwfqrwRSPHX6SeHYjKf4MFVAvAPB5E07DPWAHZF1MSnbyji0DGCy3JsXWtnutw== X-Received: by 2002:a05:620a:813:b0:775:74e3:6d50 with SMTP id s19-20020a05620a081300b0077574e36d50mr21043212qks.77.1697078940162; Wed, 11 Oct 2023 19:49:00 -0700 (PDT) Received: from localhost.localdomain (dsl-10-128-66.b2b2c.ca. [72.10.128.66]) by smtp.gmail.com with ESMTPSA id f10-20020a05620a15aa00b007659935ce64sm5671657qkk.71.2023.10.11.19.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 19:48:59 -0700 (PDT) From: Maxim Cournoyer Date: Wed, 11 Oct 2023 22:48:40 -0400 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) While updating orcus to its latest version (0.19.0), I stumbled on a test a failure, which ended up being caused by the lack of test files in the repository checkout. These files are stored using the LFS extension in the repo; when not using LFS, empty text stubs with some metadata are left in their place. I've opted to keep the dependency on git-lfs optional for now for the daemon. The git in-band downloader will only add the git-lfs dependency when the git-reference object has its lfs? field set to true. Maxim Cournoyer (2): gnu: git-lfs: Patch /bin/sh references. git-download: Add support for Git Large File Storage (LFS). configure.ac | 10 ++++++ doc/guix.texi | 9 +++++ gnu/packages/version-control.scm | 5 +++ guix/build/git.scm | 18 +++++++--- guix/config.scm.in | 4 +++ guix/git-download.scm | 58 ++++++++++++++++++++----------- guix/scripts/perform-download.scm | 3 ++ guix/self.scm | 10 +++++- 8 files changed, 92 insertions(+), 25 deletions(-) base-commit: d6d706a58b8159748d3a46fa97cae18850487c8a -- 2.41.0 From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 1/2] gnu: git-lfs: Patch /bin/sh references. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: maxim.cournoyer@gmail.com, ludo@gnu.org, guix-patches@gnu.org Resent-Date: Thu, 12 Oct 2023 02:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66436@debbugs.gnu.org Cc: Maxim Cournoyer , Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-Xcc: Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169707897913981 (code B ref 66436); Thu, 12 Oct 2023 02:50:02 +0000 Received: (at 66436) by debbugs.gnu.org; 12 Oct 2023 02:49:39 +0000 Received: from localhost ([127.0.0.1]:40296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqlla-0003dL-Bm for submit@debbugs.gnu.org; Wed, 11 Oct 2023 22:49:39 -0400 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:59831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqllT-0003cp-Ao for 66436@debbugs.gnu.org; Wed, 11 Oct 2023 22:49:35 -0400 Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-774141bb415so30902085a.3 for <66436@debbugs.gnu.org>; Wed, 11 Oct 2023 19:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697078943; x=1697683743; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZgKi7EpEvjW0mbT/V2tMCSKIl6GMHrB+TffsyDgJk5c=; b=mS2e0UQsXXUdatYDZ8Kw2EHcOOgVwVNNU/u5LNfwbKG91lFIzOWNLP1pGs2d8kQO/5 sPxY/jctNxNxD0SkQzTCarf3ITOKctkGKw/ysNSte8iEzvN4R/GqNhzoiVHN9mQdizYm pjhgkB9XMMwSMlSs9LgnhE/OktyWD8o2S+weGcWpRrdNu/ASMfV4D/C+4d39CmRjB2Ov bO6ZdYlGzZHPSXhxE8qm5s+G+UkzGIEXbJjVNPmsWgU+6BLL9MbIO4B2+2NNpbuPLYXR 8+968Cfxw8vhBRgsEkvfTF0UJ/cvolU8rmtyC66XRjaRALp2F2DiSAJ+8u5RwXXpXpq7 DgcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697078943; x=1697683743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZgKi7EpEvjW0mbT/V2tMCSKIl6GMHrB+TffsyDgJk5c=; b=kITQhG39ZB8+5XlyT2Jp1DjXW9c6/Qqh+yiIqedJMEW+cHjeGALS41hgpc1/iMrz7Z SZKZD27bn7BbAS4snZGRsMqWVG5CHXHmdD+/oVV6pGH1Kt7123lDrhtIMIs7EEr6dUaq iVvlZBJlomKOQw0RL2J54Am4ShIV/tIfvXAMMUQ1yyhkUoK2oe5aJ+N1VJwh8MoM+PHx bMzkV5BHkaf3VCWm3ARBCATOEyg6/IexdQqTtLCvFetdWouRGQveOEj2883lGTccXSOE 46zY6ifBA1NI2Y9/b1wLChHndTQnOCD2GqEPP2nGIim2pdP3WNRKyLxdwHW5DHY661m9 NF6g== X-Gm-Message-State: AOJu0YxIKYQZIycEx5hpuiyEfo+lZ609IK4OkTG/azQswPYI5HMl9A/1 2j88arkK+6qRDK1GCd5HSMqJboyLNdY= X-Google-Smtp-Source: AGHT+IGdkyWoFOSGI9whL4coIp2TXQCRfOWbMp03vPTHjCdxTSjwORewNQcuO08lEWt3AMCRZzhJqA== X-Received: by 2002:a05:620a:40d2:b0:774:1474:a819 with SMTP id g18-20020a05620a40d200b007741474a819mr25054887qko.71.1697078943384; Wed, 11 Oct 2023 19:49:03 -0700 (PDT) Received: from localhost.localdomain (dsl-10-128-66.b2b2c.ca. [72.10.128.66]) by smtp.gmail.com with ESMTPSA id f10-20020a05620a15aa00b007659935ce64sm5671657qkk.71.2023.10.11.19.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 19:49:02 -0700 (PDT) From: Maxim Cournoyer Date: Wed, 11 Oct 2023 22:48:41 -0400 Message-ID: <2343e018a06ef7e1ce7d9d7cc2e6d30c76027277.1697078865.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/version-control.scm (git-lfs) [arguments]: Add patch-/bin/sh phase. Change-Id: I2d455e683e4f6e30cd32f5b1fdaccac71616826c --- gnu/packages/version-control.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index d9c53af71c..04b52f2a85 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -3175,6 +3175,11 @@ (define-public git-lfs #:install-source? #f #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'patch-/bin/sh + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "src/github.com/git-lfs/git-lfs/lfs/hook.go" + (("/bin/sh") + (search-input-file inputs "bin/sh"))))) (add-after 'unpack 'fix-embed-x-net (lambda _ (delete-file-recursively "src/golang.org/x/net/publicsuffix/data") -- 2.41.0 From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS). Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: maxim.cournoyer@gmail.com, ludo@gnu.org, guix@cbaines.net, dev@jpoiret.xyz, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Thu, 12 Oct 2023 02:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66436@debbugs.gnu.org Cc: Maxim Cournoyer , Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines , Josselin Poiret , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-Xcc: Maxim Cournoyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines , Josselin Poiret , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169707898414003 (code B ref 66436); Thu, 12 Oct 2023 02:50:02 +0000 Received: (at 66436) by debbugs.gnu.org; 12 Oct 2023 02:49:44 +0000 Received: from localhost ([127.0.0.1]:40298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqlld-0003di-2x for submit@debbugs.gnu.org; Wed, 11 Oct 2023 22:49:44 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:44166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqllW-0003cu-L4 for 66436@debbugs.gnu.org; Wed, 11 Oct 2023 22:49:39 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-77386822cfbso33137685a.0 for <66436@debbugs.gnu.org>; Wed, 11 Oct 2023 19:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697078947; x=1697683747; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vfTYc6L7D6jFFhzqJ9mhyYLfJoP8PrxeLPkO1ed2HBI=; b=ThEUndIUhGs7LBkU8BdxwyWZhd47HMW7yegWC0TEJJ3LIG4DC+TYLZFPwlCsq8oO1Q PV2mmJsLCPpj8FOTHheF5F6j/5vvCvgqr4pTGcGzm3gy/nRzwWBr08UdcLvqnMVjp1QI COva3Y45HGkfrGByBpzGwDVDvc+MS0mqt6VEa7y+sW6dLOWDCk5YFAsM17HjhPcfQxmX 1RbgIIcRIHs/ebIfNoB67ViLMJsNwJEHXzBPYP0Cq4H3ycP2ViLI2LxDbFnHRhVRatHm MXJPAoBQ3CMEVCinid3fsYDwdk6oPIpWHSL4jFFlw38yGaA1fqhLfGSrh9smvdym1Yoi 2IHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697078947; x=1697683747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vfTYc6L7D6jFFhzqJ9mhyYLfJoP8PrxeLPkO1ed2HBI=; b=wBu4bQH+t5mJWUF/UWVsqChlDBnTvE8/wpKc4TrisWVOOa6+qMvqHmUkFw/C52Odwr me7qp3Rc8wxipHe8udtLSLz453Vll5vhiewTxT940I5sCOBvBK+2S0rcDJr1kOJEQya9 PkO0592zex+xKWLZpzDxg489X47sPa5EIFR6vrQCgP/yA0AYtbhKDwGHttVYs5XQZsNE hrdSqPN8qDpwqRI6faypeGYQl1z/pzBmmGxYuY2Qtg4kgd2NQLMj2ZZ7hbRY1dB10oOF EqlvevF3vy6t/URImF9mUbgR6Wueu+5tncLs/MuF+sW7Ic01rMXYelyAjZf+U+yXtUfn 5pGQ== X-Gm-Message-State: AOJu0YzYg6jmz9Kjh4C7z1Ks+/y2oDRExy6bOD7W+qa5Vn9HapbamOeR zkUqoQeKJgFQmPN7ERS460A3Vfx/bxc= X-Google-Smtp-Source: AGHT+IEub/EyREcHk1lQL+to9fuWYZTGYqaGZIGnpH4LdMlFMk5+0ih5wu4z9pYPEem+kSN4YwJQkg== X-Received: by 2002:a05:620a:24c8:b0:774:11c4:45cb with SMTP id m8-20020a05620a24c800b0077411c445cbmr28757069qkn.53.1697078946542; Wed, 11 Oct 2023 19:49:06 -0700 (PDT) Received: from localhost.localdomain (dsl-10-128-66.b2b2c.ca. [72.10.128.66]) by smtp.gmail.com with ESMTPSA id f10-20020a05620a15aa00b007659935ce64sm5671657qkk.71.2023.10.11.19.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 19:49:06 -0700 (PDT) From: Maxim Cournoyer Date: Wed, 11 Oct 2023 22:48:42 -0400 Message-ID: <58269ccea06b016c38d3bea8678608c8cccce1ca.1697078865.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/git-download.scm () [lfs?]: New field. (git-fetch/in-band): New #:git-lfs argument. : Remove labels. Conditionally add git-lfs. : Read "git lfs?" environment variable and pass its value to the #:lfs? argument of git-fetch-with-fallback. Use INPUTS directly; update comment. derivation>: Add "git lfs?" to #:env-vars. (git-fetch/built-in): Add "lfs?" to #:env-vars. * guix/build/git.scm (git-fetch) [lfs?]: New argument, doc and setup code. (git-fetch-with-fallback) [lfs?]: New argument. Pass it to git-fetch. * guix/scripts/perform-download.scm (perform-git-download): Honor the 'lfs?' environment variable. * doc/guix.texi (origin Reference) : Document the new 'lfs?' field. (Requirements): Mention the optional 'git-lfs' dependency. * configure.ac: Add a check for the 'git-lfs' command. * guix/config.scm.in (%git-lfs): New variable. * guix/self.scm (%packages): Add git-lfs. (compiled-guix): Add git-lfs to guix-config. (make-config.scm): New #:git-lfs argument. Change-Id: I5b233b8642a7bdb8737b9d9b740e7254a89ccb25 --- configure.ac | 10 ++++++ doc/guix.texi | 9 +++++ guix/build/git.scm | 18 +++++++--- guix/config.scm.in | 4 +++ guix/git-download.scm | 58 ++++++++++++++++++++----------- guix/scripts/perform-download.scm | 3 ++ guix/self.scm | 10 +++++- 7 files changed, 87 insertions(+), 25 deletions(-) diff --git a/configure.ac b/configure.ac index d817f620cf..5342c0f80e 100644 --- a/configure.ac +++ b/configure.ac @@ -208,6 +208,16 @@ if test "x$GIT" = "x"; then fi AC_SUBST([GIT]) +dnl Git Large File Storage is an optional dependency for the +dnl "builtin:git-download" derivation builder. +AC_PATH_PROG([GIT_LFS], [git-lfs]) +if test "x$GIT_LFS" = "x"; then + AC_MSG_WARN([Git Large File Storage (git-lfs) is missing; + The builtin:git-download derivation builder of the Guix daemon will + not be able to use it.]) +fi +AC_SUBST([GIT_LFS]) + LIBGCRYPT_LIBDIR="no" LIBGCRYPT_PREFIX="no" diff --git a/doc/guix.texi b/doc/guix.texi index dc16ec1d15..89faaa7b90 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -1020,6 +1020,11 @@ Requirements The following dependencies are optional: @itemize +@item +The daemon will be able to fetch from Git repositories using the +@uref{https://git-lfs.com/, Git Large File Storage} extension when the +@command{git-lfs} command is available. + @item @c Note: We need at least 0.13.0 for #:nodelay. Support for build offloading (@pxref{Daemon Offload Setup}) and @@ -8499,6 +8504,10 @@ origin Reference @command{git describe} style identifier such as @code{v1.0.1-10-g58d7909c97}. +@item @code{lfs?} (default: @code{#f}) +This Boolean indicates whether to fetch Git large file storage (LFS) +files. + @item @code{recursive?} (default: @code{#f}) This Boolean indicates whether to recursively fetch Git sub-modules. @end table diff --git a/guix/build/git.scm b/guix/build/git.scm index 0ff263c81b..82c31fabf1 100644 --- a/guix/build/git.scm +++ b/guix/build/git.scm @@ -33,10 +33,13 @@ (define-module (guix build git) ;;; Code: (define* (git-fetch url commit directory - #:key (git-command "git") recursive?) + #:key (git-command "git") + lfs? recursive?) "Fetch COMMIT from URL into DIRECTORY. COMMIT must be a valid Git commit -identifier. When RECURSIVE? is true, all the sub-modules of URL are fetched, -recursively. Return #t on success, #f otherwise." +identifier. When LFS? is true, configure Git to also fetch Large File +Storage (LFS) files; it assumes that the @code{git-lfs} extension is available +in the environment. When RECURSIVE? is true, all the sub-modules of URL are +fetched, recursively. Return #t on success, #f otherwise." ;; Disable TLS certificate verification. The hash of the checkout is known ;; in advance anyway. @@ -57,6 +60,11 @@ (define* (git-fetch url commit directory (with-directory-excursion directory (invoke git-command "init" "--initial-branch=main") (invoke git-command "remote" "add" "origin" url) + + (when lfs? + (setenv "HOME" "/tmp") + (invoke git-command "lfs" "install")) + (if (zero? (system* git-command "fetch" "--depth" "1" "origin" commit)) (invoke git-command "checkout" "FETCH_HEAD") (begin @@ -81,11 +89,13 @@ (define* (git-fetch url commit directory (define* (git-fetch-with-fallback url commit directory - #:key (git-command "git") recursive?) + #:key (git-command "git") + lfs? recursive?) "Like 'git-fetch', fetch COMMIT from URL into DIRECTORY, but fall back to alternative methods when fetching from URL fails: attempt to download a nar, and if that also fails, download from the Software Heritage archive." (or (git-fetch url commit directory + #:lfs? lfs? #:recursive? recursive? #:git-command git-command) (download-nar directory) diff --git a/guix/config.scm.in b/guix/config.scm.in index 62e15dd713..4997a1740e 100644 --- a/guix/config.scm.in +++ b/guix/config.scm.in @@ -36,6 +36,7 @@ (define-module (guix config) %system %git + %git-lfs %gzip %bzip2 %xz)) @@ -113,6 +114,9 @@ (define %system (define %git "@GIT@") +(define %git-lfs + "@GIT_LFS@") + (define %gzip "@GZIP@") diff --git a/guix/git-download.scm b/guix/git-download.scm index 5d5d73dc6b..6feeea6428 100644 --- a/guix/git-download.scm +++ b/guix/git-download.scm @@ -51,6 +51,7 @@ (define-module (guix git-download) git-reference? git-reference-url git-reference-commit + git-reference-lfs? git-reference-recursive? git-fetch @@ -71,7 +72,9 @@ (define-record-type* git-reference? (url git-reference-url) (commit git-reference-commit) - (recursive? git-reference-recursive? ; whether to recurse into sub-modules + (lfs? git-reference-lfs? ;whether to fetch LFS files + (default #f)) + (recursive? git-reference-recursive? ;whether to recurse into sub-modules (default #f))) (define (git-package) @@ -79,11 +82,17 @@ (define (git-package) (let ((distro (resolve-interface '(gnu packages version-control)))) (module-ref distro 'git-minimal))) +(define (git-lfs-package) + "Return the default 'git-lfs' package." + (let ((distro (resolve-interface '(gnu packages version-control)))) + (module-ref distro 'git-lfs))) + (define* (git-fetch/in-band ref hash-algo hash #:optional name #:key (system (%current-system)) (guile (default-guile)) - (git (git-package))) + (git (git-package)) + (git-lfs (git-lfs-package))) "Return a fixed-output derivation that performs a Git checkout of REF, using GIT and GUILE (thus, said derivation depends on GIT and GUILE). @@ -91,18 +100,22 @@ (define* (git-fetch/in-band ref hash-algo hash It will be removed when versions of guix-daemon implementing \"builtin:git-download\" will be sufficiently widespread." (define inputs - `(("git" ,(or git (git-package))) - - ;; When doing 'git clone --recursive', we need sed, grep, etc. to be - ;; available so that 'git submodule' works. + `(,(or git (git-package)) + ,@(if (git-reference-lfs? ref) + (list (or git-lfs (git-lfs-package))) + '()) ,@(if (git-reference-recursive? ref) - (standard-packages) + ;; TODO: remove (standard-packages) after + ;; 48e528a26f9c019eeaccf5e3de3126aa02c98d3b is merged into master; + ;; currently when doing 'git clone --recursive', we need sed, grep, + ;; etc. to be available so that 'git submodule' works. + (map second (standard-packages)) ;; The 'swh-download' procedure requires tar and gzip. - `(("gzip" ,(module-ref (resolve-interface '(gnu packages compression)) - 'gzip)) - ("tar" ,(module-ref (resolve-interface '(gnu packages base)) - 'tar)))))) + (list (module-ref (resolve-interface '(gnu packages compression)) + 'gzip) + (module-ref (resolve-interface '(gnu packages base)) + 'tar))))) (define guile-json (module-ref (resolve-interface '(gnu packages guile)) 'guile-json-4)) @@ -126,7 +139,7 @@ (define* (git-fetch/in-band ref hash-algo hash (define build (with-imported-modules modules - (with-extensions (list guile-json gnutls ;for (guix swh) + (with-extensions (list guile-json gnutls ;for (guix swh) guile-lzlib) #~(begin (use-modules (guix build git) @@ -134,6 +147,9 @@ (define* (git-fetch/in-band ref hash-algo hash #:select (set-path-environment-variable)) (ice-9 match)) + (define lfs? + (call-with-input-string (getenv "git lfs?") read)) + (define recursive? (call-with-input-string (getenv "git recursive?") read)) @@ -144,18 +160,17 @@ (define* (git-fetch/in-band ref hash-algo hash #+(file-append glibc-locales "/lib/locale")) (setlocale LC_ALL "en_US.utf8") - ;; The 'git submodule' commands expects Coreutils, sed, - ;; grep, etc. to be in $PATH. - (set-path-environment-variable "PATH" '("bin") - (match '#+inputs - (((names dirs outputs ...) ...) - dirs))) + ;; The 'git submodule' commands expects Coreutils, sed, grep, + ;; etc. to be in $PATH. This also ensures that git extensions are + ;; found. + (set-path-environment-variable "PATH" '("bin") '#+inputs) (setvbuf (current-output-port) 'line) (setvbuf (current-error-port) 'line) (git-fetch-with-fallback (getenv "git url") (getenv "git commit") #$output + #:lfs? lfs? #:recursive? recursive? #:git-command "git"))))) @@ -175,13 +190,15 @@ (define* (git-fetch/in-band ref hash-algo hash (git-reference-url ref)))) ("git commit" . ,(git-reference-commit ref)) ("git recursive?" . ,(object->string - (git-reference-recursive? ref)))) + (git-reference-recursive? ref))) + ("git lfs?" . ,(object->string + (git-reference-lfs? ref)))) #:leaked-env-vars '("http_proxy" "https_proxy" "LC_ALL" "LC_MESSAGES" "LANG" "COLUMNS") #:system system - #:local-build? #t ;don't offload repo cloning + #:local-build? #t ;don't offload repo cloning #:hash-algo hash-algo #:hash hash #:recursive? #t @@ -209,6 +226,7 @@ (define* (git-fetch/built-in ref hash-algo hash (_ (git-reference-url ref))))) ("commit" . ,(git-reference-commit ref)) + ("lfs?" . ,(object->string (git-reference-lfs? ref))) ("recursive?" . ,(object->string (git-reference-recursive? ref)))) #:leaked-env-vars '("http_proxy" "https_proxy" diff --git a/guix/scripts/perform-download.scm b/guix/scripts/perform-download.scm index 9aa0e61e9d..37904941d1 100644 --- a/guix/scripts/perform-download.scm +++ b/guix/scripts/perform-download.scm @@ -96,6 +96,7 @@ (define* (perform-git-download drv output 'bmRepair' builds." (derivation-let drv ((url "url") (commit "commit") + (lfs? "lfs?") (recursive? "recursive?")) (unless url (leave (G_ "~a: missing Git URL~%") (derivation-file-name drv))) @@ -103,6 +104,7 @@ (define* (perform-git-download drv output (leave (G_ "~a: missing Git commit~%") (derivation-file-name drv))) (let* ((url (call-with-input-string url read)) + (lfs? (and lfs? (call-with-input-string lfs? read))) (recursive? (and recursive? (call-with-input-string recursive? read))) (drv-output (assoc-ref (derivation-outputs drv) "out")) @@ -115,6 +117,7 @@ (define* (perform-git-download drv output (setenv "PATH" "/run/current-system/profile/bin:/bin:/usr/bin") (git-fetch-with-fallback url commit output + #:lfs? lfs? #:recursive? recursive? #:git-command %git)))) diff --git a/guix/self.scm b/guix/self.scm index a1f235659d..96021be6f6 100644 --- a/guix/self.scm +++ b/guix/self.scm @@ -69,6 +69,7 @@ (define %packages ("gzip" . ,(ref 'compression 'gzip)) ("bzip2" . ,(ref 'compression 'bzip2)) ("xz" . ,(ref 'compression 'xz)) + ("git-lfs" . ,(ref 'version-control 'git-lfs)) ("git-minimal" . ,(ref 'version-control 'git-minimal)) ("po4a" . ,(ref 'gettext 'po4a)) ("gettext-minimal" . ,(ref 'gettext 'gettext-minimal)) @@ -830,6 +831,9 @@ (define* (compiled-guix source #:key (define git (specification->package "git-minimal")) + (define git-lfs + (specification->package "git-lfs")) + (define dependencies (append-map transitive-package-dependencies (list guile-gcrypt guile-gnutls guile-git guile-avahi @@ -1004,6 +1008,7 @@ (define* (compiled-guix source #:key #:bzip2 bzip2 #:xz xz #:git git + #:git-lfs git-lfs #:package-name %guix-package-name #:package-version @@ -1109,7 +1114,7 @@ (define %default-config-variables (%storedir . "/gnu/store") (%sysconfdir . "/etc"))) -(define* (make-config.scm #:key gzip xz bzip2 git +(define* (make-config.scm #:key gzip xz bzip2 git git-lfs (package-name "GNU Guix") (package-version "0") (channel-metadata #f) @@ -1140,6 +1145,7 @@ (define* (make-config.scm #:key gzip xz bzip2 git %store-database-directory %config-directory %git + %git-lfs %gzip %bzip2 %xz)) @@ -1184,6 +1190,8 @@ (define* (make-config.scm #:key gzip xz bzip2 git (define %git #+(and git (file-append git "/bin/git"))) + (define %git-lfs + #+(and git-lfs (file-append git-lfs "/bin/git-lfs"))) (define %gzip #+(and gzip (file-append gzip "/bin/gzip"))) (define %bzip2 -- 2.41.0 From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 0/2] Add support for Git Large File Storage (LFS). Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Oct 2023 02:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66436@debbugs.gnu.org Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169707914114460 (code B ref 66436); Thu, 12 Oct 2023 02:53:01 +0000 Received: (at 66436) by debbugs.gnu.org; 12 Oct 2023 02:52:21 +0000 Received: from localhost ([127.0.0.1]:40331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqloD-0003lA-8d for submit@debbugs.gnu.org; Wed, 11 Oct 2023 22:52:21 -0400 Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]:55299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqloA-0003kl-2O for 66436@debbugs.gnu.org; Wed, 11 Oct 2023 22:52:20 -0400 Received: by mail-ua1-x92f.google.com with SMTP id a1e0cc1a2514c-7b08ac3ce7fso261295241.2 for <66436@debbugs.gnu.org>; Wed, 11 Oct 2023 19:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697079110; x=1697683910; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ca0BeqdyFgx8XkNsPYaQOWCBbx9BBQw60uZ0q+Mt6H8=; b=OuZ3tfzixiU1Kvp/rgfz5JyERk7cnuYXv5r+BD+nRHV9gxxHoQzoX29juXPVu60ic0 cvs6v4hPFzXoi7yKNYk4Obqx3bMRCYkaPHfScBL4OmG3o34ewu+tfM4t2MUSHFS5opOt sBKuAYS1jGhHzguQgAtYKD4O1WR3nnaP/9Zo0N8TmJRukyBjFmTGRfIiihMznKZSAjIZ ND61iAPZXw5vHiwdO9qWY8lXJDEEEWjAy0A2yb93dah5uU93Hy2vcWvD9hN5wpOxjeDo bWWNzkgKTBX0cbuKO+vFSK7N3es2ZGc9eUH4ddzbKNH6s9vMGTl+NXH4ijoS1rEqtCuw Gxbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697079110; x=1697683910; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ca0BeqdyFgx8XkNsPYaQOWCBbx9BBQw60uZ0q+Mt6H8=; b=PLKapcK4YXzaPaTfK4WVriInOmuQcW9A7jNtE+yGgSKlXndoRIkSZjEGJbWCgEK66s TLTfxoF2uuYBqwA/U74cgmEF0dI5rbl6pPS/uLPclZktbix7VXklS473QCSqYyDJR6UG jE1QnxFNeopMjiGnFoEMS20dxtS8o0b5Xa7kAXhEL+fV/RvBbRy3rRVkhFPbH0tL061a qjMEqPJdUwKwDWSMRhLVsdTwOKq63mZwVT2cav1WJbckv3nfUab5DnFLztNHUPrBSW6i QrQPOnbKPhBHOWIr2BwPRINPPF1HEDgn2k/m9pK+v30Gnc2Yf8P8vGeQ4FmoQUstmgBG 9d2Q== X-Gm-Message-State: AOJu0YyFe5MVfMTq4FUAArI8+t54iKWRJrX5qySv9IeAiUAWAvxLIsVx /RXcab1lS/tYiLyfXAZC79o= X-Google-Smtp-Source: AGHT+IHoYUC4EzH2V1xLXe+d1CtdheGrtpjA0IGXX1kXRsiaKEq7QknsofHO/jri41WY1QCmDhD3IQ== X-Received: by 2002:a1f:ab8e:0:b0:4a4:cd2:5ebe with SMTP id u136-20020a1fab8e000000b004a40cd25ebemr329621vke.12.1697079110224; Wed, 11 Oct 2023 19:51:50 -0700 (PDT) Received: from hurd (dsl-10-128-66.b2b2c.ca. [72.10.128.66]) by smtp.gmail.com with ESMTPSA id o11-20020a056214108b00b0066d0621bb67sm1033792qvr.114.2023.10.11.19.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 19:51:49 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (Maxim Cournoyer's message of "Wed, 11 Oct 2023 22:48:40 -0400") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> Date: Wed, 11 Oct 2023 22:51:48 -0400 Message-ID: <878r88d03f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Maxim Cournoyer writes: > While updating orcus to its latest version (0.19.0), I stumbled on a test a > failure, which ended up being caused by the lack of test files in the > repository checkout. These files are stored using the LFS extension in the > repo; when not using LFS, empty text stubs with some metadata are left in > their place. > > I've opted to keep the dependency on git-lfs optional for now for the daemon. > The git in-band downloader will only add the git-lfs dependency when the > git-reference object has its lfs? field set to true. > > Maxim Cournoyer (2): > gnu: git-lfs: Patch /bin/sh references. > git-download: Add support for Git Large File Storage (LFS). Apologies for sending this series twice; the first time I sent it erroneously to 66436 after forgetting to run 'mumi new'. -- Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 1/2] gnu: git-lfs: Patch /bin/sh references. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2023 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.16973031279846 (code B ref 66436); Sat, 14 Oct 2023 17:06:02 +0000 Received: (at 66436) by debbugs.gnu.org; 14 Oct 2023 17:05:27 +0000 Received: from localhost ([127.0.0.1]:50333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri4t-0002Yk-EQ for submit@debbugs.gnu.org; Sat, 14 Oct 2023 13:05:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qri4s-0002YS-0q for 66436@debbugs.gnu.org; Sat, 14 Oct 2023 13:05:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qri4P-0004Jp-16; Sat, 14 Oct 2023 13:04:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=T8I+IdwTjxXsPTTB99PCOgMLakxkwNhNlpdCJPTNjuU=; b=AVvAG+dRZX4GEEd2Cs4G rw8B+NVx1PMcoaZwcXwb8k0wJMiJnHCXy++J1sYkuoLWm/i3eZTuz7/8Qx4OkQWXo47QJKCaIPIrt TSJHrXOuOJqkJuklU+3KYdBGjV8sMVlim+RI8MTv9wkEAjeZ8Nwj+s/PPcYolr6tN7Iok1rnOiIF3 fOF5dwb7fo5llkpIXGI+OzkLwH0Flxf1Y/Waej9u5Wl7nFWZB3Bdz+fqqk7qEb1KoP2zsQu+BEjIe TlX5tQ+75MPs1CvRKhvMg9TTK5h5Hd6v16Hz37eUUtvJWG2RSDSOQ5Hk8psLHxrgOhAxtYbpr5PaL Mbu9FAh3e1ox5g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <2343e018a06ef7e1ce7d9d7cc2e6d30c76027277.1697078865.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 11 Oct 2023 22:48:41 -0400") References: <2343e018a06ef7e1ce7d9d7cc2e6d30c76027277.1697078865.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 23 =?UTF-8?Q?Vend=C3=A9miaire?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Navet X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 14 Oct 2023 19:04:44 +0200 Message-ID: <87h6mtdtjn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > * gnu/packages/version-control.scm (git-lfs) > [arguments]: Add patch-/bin/sh phase. LGTM! From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS). Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Oct 2023 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 66436@debbugs.gnu.org, Christopher Baines Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169730361610692 (code B ref 66436); Sat, 14 Oct 2023 17:14:01 +0000 Received: (at 66436) by debbugs.gnu.org; 14 Oct 2023 17:13:36 +0000 Received: from localhost ([127.0.0.1]:50358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qriCi-0002mK-4U for submit@debbugs.gnu.org; Sat, 14 Oct 2023 13:13:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qriCc-0002m3-Ed for 66436@debbugs.gnu.org; Sat, 14 Oct 2023 13:13:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qriC8-00067q-48; Sat, 14 Oct 2023 13:12:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=aLt40g8pgzoAlpXg0WLErkPjU5MqipbI1B09IkhbBUY=; b=ZEg70ZnK3do51+7I5W/e M/Gv3i4LsAYw/PnHM7f7ELzMVgIPyw2In+ph+nkZ7AB0YkF05OStTxLN+pu2KmFu3EqC8zS9ph86k oCgyaG2MhU6IGMqVQUt3yALJqqeNnKGvFjcy3m2cqol5hQPyvw4T9A9Y0qrKBVhy7JfrzTNJfTs+x CQ+04VBL6n+LvqqNaianbxjM/co+kbwak+BmMDqn7efMu5sSBWcwB0xYR4wf6rdKNCyEkAXny9OFX 3XRXaR55+eB6zhB4bbqzZkcaJ5VG71ThN4bmCFSBaIIPSe+YtuHR/TMR+ED4N/0x6nBukXUfoN1BB pU7rH3pFAGSYnw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <58269ccea06b016c38d3bea8678608c8cccce1ca.1697078865.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 11 Oct 2023 22:48:42 -0400") References: <58269ccea06b016c38d3bea8678608c8cccce1ca.1697078865.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 23 =?UTF-8?Q?Vend=C3=A9miaire?= an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Navet X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 14 Oct 2023 19:12:42 +0200 Message-ID: <877cnpdt6d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > * guix/git-download.scm () [lfs?]: New field. > (git-fetch/in-band): New #:git-lfs argument. > : Remove labels. Conditionally add git-lfs. > : Read "git lfs?" environment > variable and pass its value to the #:lfs? argument of git-fetch-with-fall= back. > Use INPUTS directly; update comment. > derivation>: Add "git lfs?" to #:env-vars. > (git-fetch/built-in): Add "lfs?" to #:env-vars. > * guix/build/git.scm (git-fetch) [lfs?]: New argument, doc and setup code. > (git-fetch-with-fallback) [lfs?]: New argument. Pass it to git-fetch. > * guix/scripts/perform-download.scm (perform-git-download): Honor the 'lf= s?' > environment variable. > * doc/guix.texi (origin Reference) : Document the new 'lfs= ?' > field. > (Requirements): Mention the optional 'git-lfs' dependency. > * configure.ac: Add a check for the 'git-lfs' command. > * guix/config.scm.in (%git-lfs): New variable. > * guix/self.scm (%packages): Add git-lfs. > (compiled-guix): Add git-lfs to guix-config. > (make-config.scm): New #:git-lfs argument. I wonder whether this is a desirable feature, in the sense that the store is not designed to hold large amounts of data: just like Git has Git-LFS and Git-Annex, we=E2=80=99d need Guix-Annex (in fact, the GWL is ki= nda doing that already!). Furthermore=E2=80=A6 > +dnl Git Large File Storage is an optional dependency for the > +dnl "builtin:git-download" derivation builder. > +AC_PATH_PROG([GIT_LFS], [git-lfs]) > +if test "x$GIT_LFS" =3D "x"; then > + AC_MSG_WARN([Git Large File Storage (git-lfs) is missing; > + The builtin:git-download derivation builder of the Guix daemon will > + not be able to use it.]) =E2=80=A6 I don=E2=80=99t think we want to spend more words on the effect o= f increasing the closure size and getting locked with Git (libgit2 doesn=E2=80=99t imple= ment LFS I suppose.) To me this part is a showstopper; we should just make it clear that =E2=80=9Cbuiltin:git-download=E2=80=9D does not implement LFS. Also, it is crucial for the =E2=80=9Cbuiltin:git-download=E2=80=9D semantic= s to be the same across all installations and to be very stable. > +(define* (make-config.scm #:key gzip xz bzip2 git git-lfs > (package-name "GNU Guix") > (package-version "0") > (channel-metadata #f) > @@ -1140,6 +1145,7 @@ (define* (make-config.scm #:key gzip xz bzip2 git > %store-database-directory > %config-directory > %git > + %git-lfs This I=E2=80=99d like to avoid, too (for the size issue). Overall, I feel like LFS support, if needed, should be =E2=80=9Con the side= =E2=80=9D, with a custom =E2=80=98git-fetch/lfs=E2=80=99 or something along these line= s (just like we have =E2=80=98url-fetch/tarbomb=E2=80=99). We might still need to change (guix build git) to implement it, but I would make sure that =E2=80=9Cbuiltin:git-download=E2=80=9D remains unaffec= ted and never fetches LFS stuff, even if =E2=80=98git-lfs=E2=80=99 happens to be on $PATH= or something. WDYT? Ludo=E2=80=99. From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Oct 2023 09:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , 66436@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169736374620006 (code B ref 66436); Sun, 15 Oct 2023 09:56:02 +0000 Received: (at 66436) by debbugs.gnu.org; 15 Oct 2023 09:55:46 +0000 Received: from localhost ([127.0.0.1]:51231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrxqc-0005Cc-6l for submit@debbugs.gnu.org; Sun, 15 Oct 2023 05:55:46 -0400 Received: from jpoiret.xyz ([206.189.101.64]:46890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrxqZ-0005CT-O7 for 66436@debbugs.gnu.org; Sun, 15 Oct 2023 05:55:44 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 5140118543D; Sun, 15 Oct 2023 09:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1697363718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ggo3gUMyRNd+6wpMNj6ldrvx7OnnK7b3UYpubQfYwHM=; b=Jmf7k8Z7jIPIt6hJEbEwzQ1pQ3X8AYdNnOe46abVBcRlZrY4sORQzOpyWiC15AmnskKMOw UYzInUs8JaDgSk2kgZktQ7hNeXt1MHR9bQUyOG01+9vcxrXBqpo7o7k57Cy/b6Ub+PxYm8 cx3MSHW6Vqzd27DD/aYHoingcYsO89LtjpRlTdx+3VLGdq5pbxQayfyuqGqJOaojGzXO6M xltvkij4UKN57Ep2rDunkR6w1wAaMgU5W2aKexlJ/iWNE5Q3ew3y3HN6YVMiDmw72E0Bd9 3jORAfgjcWVOnDNnCxIm4BqEC3e7inye2ANbg976e3rPjOHmdHQwThZ2c0SM0w== From: Josselin Poiret In-Reply-To: <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> Date: Sun, 15 Oct 2023 11:55:15 +0200 Message-ID: <87jzroyzuk.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Level: * X-Spamd-Bar: + Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer writes: > +@cindex LGTM, Looks Good To Me > +When you deem the proposed change adequate and ready for inclusion > +within Guix, the following well understood/codified @acronym{LGTM, Looks > +Good To Me} phrases should be used to sign off as a reviewer, meaning > +you have reviewed the change and that it looks good to you: > + > +@itemize > +@item > +If the @emph{whole} series (containing multiple commits) looks good to > +you, reply with a @samp{This series LGTM!} to the cover page if it has > +one, or to the last patch of the series otherwise. > + > +@item > +If you instead want to mark a @emph{single commit} as reviewed (but not > +the whole series), simply reply with @samp{LGTM!} to that commit > +message. > +@end itemize Some mbox -> patches tools (like b4) are able to automatically apply trailers like "Reviewed-by: some ident <...>" found as replies to patch series [1]. I also like the very clear meaning of it: there's no way you would type this without meaning "Yes, I officially vouch that this patch series has been reviewed by me". Maybe this could be codified here? Otherwise, seem good to me. [1] `b4 am`'s -t option, see https://b4.docs.kernel.org/en/latest/maintainer/am-shazam.html Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmUrtwMQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaiqBCC/4zDX0BupR681wVirKoJuOctDso8gn+obJQ 7T6ftm50NNzywQ1cwAb6cHlVptX2FpyKOcCPq1MhhyAuw2BgqCP0OeciiJWBcDO4 NE5jqjYovr47Au02v7Fez1PJ3hsJF4a/pSwvkGsHonjv3w46rT1NJla2TKw74ihP vYpBza6eKaso3XNMDMs+ur2D2EJ0UpAFdJurGpHtZ6pJgobrpRjnLpu9TI//FEBr V3Ijb0+alwMCzSApnGO/8xeO2VzUS7xOwyibt2NOBA9vH+05GNo53koU24kL3SGd 9NMhRCvJHRUod7MIBZfgsCFjuZF6G4fQ+hr1+BBoU8RSuO+PZTmStARfAf16OlPY JWN5FpPc3tPCmYYM72hT9Zc0a5Ymfp/mVsFDx6Q7R/epB1u8vEGN+7n5iCGGwhoi 9t8Ld0Tya3Si2dn1qglcuHsN+c6a6s5JYf2nk0pdLTzX1tBFVRCnQhmz9y7jKyHI u8qrlUL0e5lHjv7v0hNwEbua/4+RNTU= =8Qxd -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2023 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169746496710880 (code B ref 66436); Mon, 16 Oct 2023 14:03:02 +0000 Received: (at 66436) by debbugs.gnu.org; 16 Oct 2023 14:02:47 +0000 Received: from localhost ([127.0.0.1]:57439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsOBD-0002pQ-3t for submit@debbugs.gnu.org; Mon, 16 Oct 2023 10:02:47 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:61750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsOBA-0002pD-Ky for 66436@debbugs.gnu.org; Mon, 16 Oct 2023 10:02:45 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7742be66bd3so330079585a.3 for <66436@debbugs.gnu.org>; Mon, 16 Oct 2023 07:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697464934; x=1698069734; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8CEcurRHneGOxycmS99b2LowP5HOdfWaoCykFc0SO+U=; b=ScN8m2rdFpa7D8wzr67L9hw00VV9AzjoGJvFgx2MRM0gKgvhEKXsZ0Yu9rwXKg2pHH k4LsGsUrM3d5CVTxIyZhp+iMHe9SFjwQ4vbY8Tt7tum3X8okGBa4OQzf3IBVG7vz6Zlp /jRcGUSgPt2cB4gI8/eJrSHlyXAlfDj5mkDemAETOKrCA1KP2IzDVgWrmoNKrSuCH/wX 4AfxMhoxvgum93XHFIm94yN/pw1AjWwRVGFDbEBiFSUzcGpITrvdcbNR0Ra3oIrnAeJF lG+pYxH9B0X5knA/swVrB3KD0/j1AEzIjJh1bo4RI99Zjnc2c0/0L5IJEYF1i7OB61Vx xlmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697464934; x=1698069734; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8CEcurRHneGOxycmS99b2LowP5HOdfWaoCykFc0SO+U=; b=sbwN/W5Hr4o28bSKdRw6UQaiXdMQ2rxGaR8CXTnAMhZpXHSxqB7UN7zZaTPh+w9Rzy 0JDtqaRWCarnUJRtzPGa1TWiP2fyFvgvuyBeGjmbrpcUoE7HJ+9GTY+wdBQcg7fYl6x5 pgFxJ8526snkDlIw2D2I8lYeSbcQ/8oqyrWUHsN2xZeshfVYMaSUkmehclDOMnNrIzYm FsSCwwuvZe/Bd5KHHRMy7DsMFlTfGLgcdHWpNjtNPjF+rp8/d86GXUw1jk5hAjKAbBXW mBC+77gbaMp+QB6zYdUNBHWCBhq5YMS41yU+EcopOwLqvOQSUabYe6xyWm2UsGbdp6vU 62LA== X-Gm-Message-State: AOJu0YzAzjErVTTFh9glDe708KvdSDj2Vp0tWtAEo0LLVfa4xPRRXJVW SI6t9jkRaAGeHQ2Mu6sNXV8= X-Google-Smtp-Source: AGHT+IFQWfeJJe7zEfR3g3yKNm0KdPTEZgS7bct+Z1Qoli1lhmXOEhu0LV3wY5EHZO0JEQJ6ZgvyUQ== X-Received: by 2002:a05:620a:4008:b0:775:92ac:a0af with SMTP id h8-20020a05620a400800b0077592aca0afmr42423715qko.13.1697464934033; Mon, 16 Oct 2023 07:02:14 -0700 (PDT) Received: from hurd (dsl-10-149-74.b2b2c.ca. [72.10.149.74]) by smtp.gmail.com with ESMTPSA id w9-20020ae9e509000000b0076d08d5f93asm2997162qkf.60.2023.10.16.07.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 07:02:13 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87jzroyzuk.fsf@jpoiret.xyz> (Josselin Poiret's message of "Sun, 15 Oct 2023 11:55:15 +0200") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87jzroyzuk.fsf@jpoiret.xyz> Date: Mon, 16 Oct 2023 10:02:12 -0400 Message-ID: <87fs2azmvv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Josselin Poiret writes: > Hi Maxim, > > Maxim Cournoyer writes: > >> +@cindex LGTM, Looks Good To Me >> +When you deem the proposed change adequate and ready for inclusion >> +within Guix, the following well understood/codified @acronym{LGTM, Looks >> +Good To Me} phrases should be used to sign off as a reviewer, meaning >> +you have reviewed the change and that it looks good to you: >> + >> +@itemize >> +@item >> +If the @emph{whole} series (containing multiple commits) looks good to >> +you, reply with a @samp{This series LGTM!} to the cover page if it has >> +one, or to the last patch of the series otherwise. >> + >> +@item >> +If you instead want to mark a @emph{single commit} as reviewed (but not >> +the whole series), simply reply with @samp{LGTM!} to that commit >> +message. >> +@end itemize > > Some mbox -> patches tools (like b4) are able to automatically apply > trailers like "Reviewed-by: some ident <...>" found as replies to patch > series [1]. I also like the very clear meaning of it: there's no way > you would type this without meaning "Yes, I officially vouch that this > patch series has been reviewed by me". Maybe this could be codified > here? Reading about it at , it seems 'b4 -t' is about adding the 'Review-by' git trailers found in replies to *cover letters*, and inserting them on each commit of the series when applied. Do you use such a tool when applying patches working with Guix review? I'm not too fond of adding tool-specific bits to the otherwise tool-agnostic section above, but perhaps we could add a note or something. -- Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 1/2] gnu: git-lfs: Patch /bin/sh references. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2023 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 66436@debbugs.gnu.org Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169746762816269 (code B ref 66436); Mon, 16 Oct 2023 14:48:02 +0000 Received: (at 66436) by debbugs.gnu.org; 16 Oct 2023 14:47:08 +0000 Received: from localhost ([127.0.0.1]:57492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsOs8-0004EL-2h for submit@debbugs.gnu.org; Mon, 16 Oct 2023 10:47:08 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:42039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsOs4-0004Dp-TE for 66436@debbugs.gnu.org; Mon, 16 Oct 2023 10:47:06 -0400 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-77574c2cffdso390534485a.0 for <66436@debbugs.gnu.org>; Mon, 16 Oct 2023 07:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697467594; x=1698072394; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pXpXkbKx5syAN5mElfPPHI48+XbI8tnUPPEdDFh/IfU=; b=KMSQqQoeVqAa5zoGyW2G0tRCJZIsDqASuh5BDItjKbJYRM4cRHgd/oLxFgTJ4fJSf4 it+IZKs0Mo4JDwy1BWkfI1KCG1eCIeXunfZxXDNBTrJ7ADX4ZK0Qqs0M/NttWa9HGitv F0BZj0PZHsPhms77KTHYHRReij6Q1gJXNmKV6PI39HnXvXHWUvcnYdSm5x5QluQGNDij Kb1Uva5O8rZ4lrBVvscuPem+tAzTLTBaYpUIEFHkAmcpfF6dEZxmtHmkJwvkDIzPlZHH NPb0MGeyBDKSAN/Z0WXQeARCrAoOF8dT7QIrYw9xdISMweqmelfXkudP8Q4dbaiKpwiR dBJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697467594; x=1698072394; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pXpXkbKx5syAN5mElfPPHI48+XbI8tnUPPEdDFh/IfU=; b=SUs0AsNWYeR7xl3cnttwj/0x/b8MNs/YEqpBg7r1p0R703ICNbDaq0Okl3kJHATtv4 1s79+VsC8j/1nvSxIQCJOvd7QXUpdPJkQfHBKc75/nVNnpULVp14UiJmPsCIeKGkadSf NE3CD9lgPxjRkHTEpzgfyXj4ib2lLNE8+463gE5Ofs0HbuTyAqYS6Zoujt2pYB+kOwQ/ 94kcb8Kz0mzxJrMvmjNweD0VZ9coLEbVdPdb3jwG/F4Oi/cNRfaIfaPRD3Ub//3jFBDZ P8T0IgKPlMDUUGjat6gnSwwmqezHs8dhwgGUQVaxoxtYYKipgPdEt8B9R++1i3IyoeO6 Zliw== X-Gm-Message-State: AOJu0Yz5V4RpITMSzU6mLXhFYP7XCJ/CLyyd0FNn4cHLjeu2WSWtUBEQ 7vkyV57LJGBRIXJ92EtoV9lT8wjqH6Q= X-Google-Smtp-Source: AGHT+IHg6dAuAGR/yXLVKB6sF8Gg5JjYBUmg+AHwUWZcWTc80Z2L027Ot94L/g9eTbDeSjRPRVPIXg== X-Received: by 2002:a05:620a:390e:b0:775:cda7:88c with SMTP id qr14-20020a05620a390e00b00775cda7088cmr10366195qkn.38.1697467594285; Mon, 16 Oct 2023 07:46:34 -0700 (PDT) Received: from hurd (dsl-10-149-74.b2b2c.ca. [72.10.149.74]) by smtp.gmail.com with ESMTPSA id f1-20020a05620a15a100b007756f60bcacsm3019185qkk.79.2023.10.16.07.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 07:46:33 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87h6mtdtjn.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 14 Oct 2023 19:04:44 +0200") References: <2343e018a06ef7e1ce7d9d7cc2e6d30c76027277.1697078865.git.maxim.cournoyer@gmail.com> <87h6mtdtjn.fsf@gnu.org> Date: Mon, 16 Oct 2023 10:46:32 -0400 Message-ID: <87a5sizktz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> * gnu/packages/version-control.scm (git-lfs) >> [arguments]: Add patch-/bin/sh phase. > > LGTM! I've installed this commit, thanks. --=20 Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS). Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2023 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 66436@debbugs.gnu.org, Christopher Baines Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169746906019809 (code B ref 66436); Mon, 16 Oct 2023 15:11:01 +0000 Received: (at 66436) by debbugs.gnu.org; 16 Oct 2023 15:11:00 +0000 Received: from localhost ([127.0.0.1]:57597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsPF9-00059H-CX for submit@debbugs.gnu.org; Mon, 16 Oct 2023 11:11:00 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:60524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsPF3-00058r-Ad for 66436@debbugs.gnu.org; Mon, 16 Oct 2023 11:10:54 -0400 Received: by mail-qv1-xf30.google.com with SMTP id 6a1803df08f44-66d17bdabe1so29147066d6.0 for <66436@debbugs.gnu.org>; Mon, 16 Oct 2023 08:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697469019; x=1698073819; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OLk7VOT8JtNoqJ65aZFdmVmV6ejnvpIOcNKbuhK59uI=; b=kFsN6gTPus3RIKuezGUUBmMm4+7kdTI5wk9n5FN4m9jaGBTg97p/FU/YDcWirtyoEB ZTanWpxSYEZfC6aoRrKmlmGg4ucdNimS5e9lMaqU54rfQETQKKCvR27lfeFZFwxiJVWv OYKk3PbL5TBKUxpDmznF5TAlz/BUIIUC4R3T6XUwzExpwUe12decuaO2DZogrX40L8Rg QYX9fcyWVacX3uJspLUxT4KylXTvn8AGW2WJMB78lNEHNP+eNoWIQPxypjLmtDEs4KCn w1W2TsZi8yKB1yMcTlp/2L83y3bvpAGJjkU4ohe8UAp/kYr0iQj5ioK9Ft9vZeqK/XQj ZkFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697469019; x=1698073819; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OLk7VOT8JtNoqJ65aZFdmVmV6ejnvpIOcNKbuhK59uI=; b=Y8x1ThRzc2jQobIlnHoqTCcuo75cOrSXdWDZJppTfhJPReJN+najNwwGadpunlSuTd r+gHlpKYGmruzVMRe5LnaQzRrCdjhmuBoSJsyODgPUVQTVQuu8xKdIGBZojUnQ8I2k5G 5gf3HkTljcp9XDPbPWy0QgJ1+KxzHcHZmwgBSJ4mqfaIW/c2IEGCHsVK6u1SsrZsSwzJ HDrf04LEr2LiPwhO1ReMhqzdsXyFdemqajShcQrL5+081iIHmREie4wimc13PlEMqyEf csr6J9qvAxYkWX++cIgKsgXvrU2hqDDyZNcQDVb20Nx1VdX2WIsduOqQm2Dbg92/Hr7c eePQ== X-Gm-Message-State: AOJu0YxWXoWjv160s34BLzOBS9Qstke5jNwovXe+v3KYvoG50ynSjUrW McnA28FsuwsMNOdR3mrbEWfzghetYuRKpA== X-Google-Smtp-Source: AGHT+IEdsz2tplojyxGqaag1V2bZktvknHrk8ckwNooqBYRb8uzzbm4TcIx6pGEXzkhRxbICoDtooQ== X-Received: by 2002:a0c:f111:0:b0:66d:4d99:bd3b with SMTP id i17-20020a0cf111000000b0066d4d99bd3bmr4820891qvl.23.1697469018508; Mon, 16 Oct 2023 08:10:18 -0700 (PDT) Received: from hurd (dsl-10-149-74.b2b2c.ca. [72.10.149.74]) by smtp.gmail.com with ESMTPSA id d9-20020a0cea89000000b00656506a1881sm3496523qvp.74.2023.10.16.08.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 08:10:18 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <877cnpdt6d.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 14 Oct 2023 19:12:42 +0200") References: <58269ccea06b016c38d3bea8678608c8cccce1ca.1697078865.git.maxim.cournoyer@gmail.com> <877cnpdt6d.fsf@gnu.org> Date: Mon, 16 Oct 2023 11:10:16 -0400 Message-ID: <87sf6ay55z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> * guix/git-download.scm () [lfs?]: New field. >> (git-fetch/in-band): New #:git-lfs argument. >> : Remove labels. Conditionally add git-lfs. >> : Read "git lfs?" environment >> variable and pass its value to the #:lfs? argument of git-fetch-with-fal= lback. >> Use INPUTS directly; update comment. >> derivation>: Add "git lfs?" to #:env-vars. >> (git-fetch/built-in): Add "lfs?" to #:env-vars. >> * guix/build/git.scm (git-fetch) [lfs?]: New argument, doc and setup cod= e. >> (git-fetch-with-fallback) [lfs?]: New argument. Pass it to git-fetch. >> * guix/scripts/perform-download.scm (perform-git-download): Honor the 'l= fs?' >> environment variable. >> * doc/guix.texi (origin Reference) : Document the new 'lf= s?' >> field. >> (Requirements): Mention the optional 'git-lfs' dependency. >> * configure.ac: Add a check for the 'git-lfs' command. >> * guix/config.scm.in (%git-lfs): New variable. >> * guix/self.scm (%packages): Add git-lfs. >> (compiled-guix): Add git-lfs to guix-config. >> (make-config.scm): New #:git-lfs argument. > > I wonder whether this is a desirable feature, in the sense that the > store is not designed to hold large amounts of data: just like Git has > Git-LFS and Git-Annex, we=E2=80=99d need Guix-Annex (in fact, the GWL is = kinda > doing that already!). Interesting thoughts, though in the case of running the 'orcus' package test suite, the "large" files are simply .ods files (Open Document spreadsheet). It seems LFS is useful to store binary data files of any kind, notwithstanding their size. > Furthermore=E2=80=A6 > >> +dnl Git Large File Storage is an optional dependency for the >> +dnl "builtin:git-download" derivation builder. >> +AC_PATH_PROG([GIT_LFS], [git-lfs]) >> +if test "x$GIT_LFS" =3D "x"; then >> + AC_MSG_WARN([Git Large File Storage (git-lfs) is missing; >> + The builtin:git-download derivation builder of the Guix daemon will >> + not be able to use it.]) > > =E2=80=A6 I don=E2=80=99t think we want to spend more words on the effect= of increasing > the closure size and getting locked with Git (libgit2 doesn=E2=80=99t imp= lement > LFS I suppose.) To me this part is a showstopper; we should just make > it clear that =E2=80=9Cbuiltin:git-download=E2=80=9D does not implement L= FS. I thought we already did get locked with having git as a hard dependency. I guess you are keeping some hope for that to be reversed in the future, pending new libgit2 developments such as gaining garbage collection (git gc) support? git-lfs would increase the closure of guix from 688 to 700 MiB. > Also, it is crucial for the =E2=80=9Cbuiltin:git-download=E2=80=9D semant= ics to be the > same across all installations and to be very stable. > >> +(define* (make-config.scm #:key gzip xz bzip2 git git-lfs >> (package-name "GNU Guix") >> (package-version "0") >> (channel-metadata #f) >> @@ -1140,6 +1145,7 @@ (define* (make-config.scm #:key gzip xz bzip2 git >> %store-database-directory >> %config-directory >> %git >> + %git-lfs > > This I=E2=80=99d like to avoid, too (for the size issue). > > Overall, I feel like LFS support, if needed, should be =E2=80=9Con the si= de=E2=80=9D, > with a custom =E2=80=98git-fetch/lfs=E2=80=99 or something along these li= nes (just like > we have =E2=80=98url-fetch/tarbomb=E2=80=99). > > We might still need to change (guix build git) to implement it, but I > would make sure that =E2=80=9Cbuiltin:git-download=E2=80=9D remains unaff= ected and never > fetches LFS stuff, even if =E2=80=98git-lfs=E2=80=99 happens to be on $PA= TH or > something. > > WDYT? Your arguments make sense. I'll try to see how git-fetch/lfs could be implemented. --=20 Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS). Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2023 15:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Cc: Josselin Poiret , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 66436@debbugs.gnu.org, Christopher Baines Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169746952421048 (code B ref 66436); Mon, 16 Oct 2023 15:19:02 +0000 Received: (at 66436) by debbugs.gnu.org; 16 Oct 2023 15:18:44 +0000 Received: from localhost ([127.0.0.1]:57610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsPMi-0005TQ-BS for submit@debbugs.gnu.org; Mon, 16 Oct 2023 11:18:44 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:40995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsPMe-0005TA-7M for 66436@debbugs.gnu.org; Mon, 16 Oct 2023 11:18:43 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-405e48d8e72so8981615e9.0 for <66436@debbugs.gnu.org>; Mon, 16 Oct 2023 08:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697469489; x=1698074289; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UNpN7Zxe537SqnHzOKQAZpP+G4QQ2DeQ9bG7LBT3Uqk=; b=XN6J5Zejj4VA/ESks0w3Oh0XHpP9Zb8eht9L01A4kNdARGcflM0pkGGVnT1HG4P1gN a1sXW9qe4x3Otn2P7NWZKBpFQJcnbJnDS+TMA/ETQs5tZdpcmUeh4g1jvl87yYk89JXs wa0GBNO5daB8HTkiGYw5qJ3sSKUNzwmkC57d+vuCSliZ+XLQUoySl3rfK4KBl53gF4/C o+k3EgP3eja4/fqdq5G8JwnHzN0QjeEgX2Gr4YrkoVJaV8rbgHwJxdQoZqUpvCT1jlMk TPpP2RuFUXwWmP84uiBqY6dCWDpcsZrgERYQN6C/KCmjEr0ysjMpWBWkd2T33f6ha4aB KQTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697469489; x=1698074289; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UNpN7Zxe537SqnHzOKQAZpP+G4QQ2DeQ9bG7LBT3Uqk=; b=EYBVzFJIyx2to2bXiK9kCnBsY4tJ+u2UJRw9yY3ESyYMqeX3+YS12dhxgIHlN7887l 5ooqXB42PP9rzACfnfvjxmJbrwhNflb0pUsdPilqpIg6eyqyzvbjoxbpuQ12ScaX5WTt FvUAcKRDZeQkTE8/pwQr4QRvgWHmSfwRAKNeSa1OP9ULK57Tm/ILIb86wKpJwxRBUVP9 iu5ZcVB/3UWbU17b4eVjld8sqW6r1QTZkp93utku3vuETV6qmThCc/qPN2SREpCI3k7Y fbPDBnM4GVc+lS61hv9CDsin4USxKHSVHYE86rPgWLHQMnVdWYho1qznMmcSTQbNub36 ShEw== X-Gm-Message-State: AOJu0YwS3hGP2+a0YQDttDwyWneQ52FDHuObsWZg46xgt78GXfaLikdd 5eWyVfcc0KvUZllZlktnqcI= X-Google-Smtp-Source: AGHT+IGH12Tvg3dFFZ+OsGjPKfA25dae284jm1DtUtNCmHKHP9LLZnDcZisjIN6HCXNJDrzt7nEj9w== X-Received: by 2002:a05:600c:3b9a:b0:3fe:21a6:a18 with SMTP id n26-20020a05600c3b9a00b003fe21a60a18mr31206439wms.3.1697469489343; Mon, 16 Oct 2023 08:18:09 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c204f00b004063cd8105csm7322182wmg.22.2023.10.16.08.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 08:18:09 -0700 (PDT) From: Simon Tournier In-Reply-To: <877cnpdt6d.fsf@gnu.org> References: <58269ccea06b016c38d3bea8678608c8cccce1ca.1697078865.git.maxim.cournoyer@gmail.com> <877cnpdt6d.fsf@gnu.org> Date: Mon, 16 Oct 2023 17:15:39 +0200 Message-ID: <87fs2ar42s.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, I reorder Ludo=E2=80=99s answers for clarity. On Sat, 14 Oct 2023 at 19:12, Ludovic Court=C3=A8s wrote: > Also, it is crucial for the =E2=80=9Cbuiltin:git-download=E2=80=9D semant= ics to be the > same across all installations and to be very stable. I agree and that=E2=80=99s one strong argument for me. > Overall, I feel like LFS support, if needed, should be =E2=80=9Con the si= de=E2=80=9D, > with a custom =E2=80=98git-fetch/lfs=E2=80=99 or something along these li= nes (just like > we have =E2=80=98url-fetch/tarbomb=E2=80=99). I agree with this direction. Most of the fetching methods should not be implemented with =E2=80=9Cbuiltin=E2=80=9C but the converse, git-fetch/lfs. ( Even, I think the current git-fetch using out-of-band builtin recently introduced should be a =E2=80=99git-fetch/bootstrap=E2=80=99 metho= d, and git-fetch using in-band should be the default method. ) Cheers, simon From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH 2/2] git-download: Add support for Git Large File Storage (LFS). Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2023 16:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , 66436@debbugs.gnu.org, Christopher Baines Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.16974734737223 (code B ref 66436); Mon, 16 Oct 2023 16:25:02 +0000 Received: (at 66436) by debbugs.gnu.org; 16 Oct 2023 16:24:33 +0000 Received: from localhost ([127.0.0.1]:57689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsQOP-0001sR-Cs for submit@debbugs.gnu.org; Mon, 16 Oct 2023 12:24:33 -0400 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]:59554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsQOK-0001s9-Qv for 66436@debbugs.gnu.org; Mon, 16 Oct 2023 12:24:32 -0400 Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-66cfd35f595so26734196d6.2 for <66436@debbugs.gnu.org>; Mon, 16 Oct 2023 09:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697473438; x=1698078238; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lyoHmC5DOEL0HXpxdgvODAZQpZ1/bSB9USHvqS8JGz0=; b=TJJgnVYwTpjtXIUPIk2IozaZyPqfaYfQ6sIZf+I4BwAhzssi4BP6DhADytzGXVjL07 HuLDRtHd7++4RbsgHzC/8X91+zq3Du/aW6bHSfdU1fN4LD58AmR5YdGbl6yFW+kia8Bo TmSoNZtxyuPy+bm0e+g9lNhAGXiqJnheNyDYlXYhddgcO00qQCttzoWuy/n77Vz7sdPM npDWNfus5SArQ7Jt6/ciHiE1QXgdgXTXeHyQlMidlnTGBqc2aB84g+17DYxVzVr1QqX9 90BWjSlCWykir+EHa2GvOtgm217UrxBn94J3JLucmCkdbpwIJhEAK7Qfi2UTG9NtkrQS 9kxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697473438; x=1698078238; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lyoHmC5DOEL0HXpxdgvODAZQpZ1/bSB9USHvqS8JGz0=; b=YznBSQFXB1PptBt7JN/8H4XkEEuL3vayjdCbGaihgBBaHQElEr+Tf5tdg1FHKMhOCK /zSNwxR+HAAsE+uWItTqokZ6Y0GYjAGVK2zmuY/Mai6NwpnduO/P4wC0xda3fkvF+fWs sR8c/jxZuGQ/s5ajjyzvZCrqnlQikjA2h1a2p8Wf9QoRL8SXplmaKu1gKn1vsU59heQP buu0bUjF1ZTL4iiqUBSE382ENxCkc0a578oAMARjxtN+L9cfjdgzlTR1Xy4Mj+hPnfag 1MsFm1wTd+VX6bf6dmRxHIzqXgzsqOmudTOUXSG0GqsMkT5MAbafplxwLcvy31JeO7iJ gD+w== X-Gm-Message-State: AOJu0YzDcA0ipzzRNvVVb93f11+wo0rEhMomGzwoWjge4NMPKJQBsUH1 I3vE3gfYx3l9w2TEAGzjqFq6yZr1q0FTtQ== X-Google-Smtp-Source: AGHT+IGAxAONltq7N/kD1QY7yyEhvxOQtBQ0yrzb9RQipPDqw1uiUWQMmeKjkrU+UGhvaE+1yJw2gw== X-Received: by 2002:a0c:e445:0:b0:635:93fb:fc05 with SMTP id d5-20020a0ce445000000b0063593fbfc05mr28175782qvm.10.1697473438348; Mon, 16 Oct 2023 09:23:58 -0700 (PDT) Received: from hurd (dsl-10-149-74.b2b2c.ca. [72.10.149.74]) by smtp.gmail.com with ESMTPSA id dw15-20020a0562140a0f00b006365b23b5dfsm3475051qvb.23.2023.10.16.09.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 09:23:57 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87fs2ar42s.fsf@gmail.com> (Simon Tournier's message of "Mon, 16 Oct 2023 17:15:39 +0200") References: <58269ccea06b016c38d3bea8678608c8cccce1ca.1697078865.git.maxim.cournoyer@gmail.com> <877cnpdt6d.fsf@gnu.org> <87fs2ar42s.fsf@gmail.com> Date: Mon, 16 Oct 2023 12:23:56 -0400 Message-ID: <87fs2awn6r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Simon Tournier writes: > Hi, > > I reorder Ludo=E2=80=99s answers for clarity. > > On Sat, 14 Oct 2023 at 19:12, Ludovic Court=C3=A8s wrote: > >> Also, it is crucial for the =E2=80=9Cbuiltin:git-download=E2=80=9D seman= tics to be the >> same across all installations and to be very stable. > > I agree and that=E2=80=99s one strong argument for me. > >> Overall, I feel like LFS support, if needed, should be =E2=80=9Con the s= ide=E2=80=9D, >> with a custom =E2=80=98git-fetch/lfs=E2=80=99 or something along these l= ines (just like >> we have =E2=80=98url-fetch/tarbomb=E2=80=99). > > I agree with this direction. Most of the fetching methods should not be > implemented with =E2=80=9Cbuiltin=E2=80=9C but the converse, git-fetch/lf= s. > > ( Even, I think the current git-fetch using out-of-band builtin > recently introduced should be a =E2=80=99git-fetch/bootstrap=E2=80=99 met= hod, and > git-fetch using in-band should be the default method. ) Thanks for tipping in, I'll look into adding a whole new 'git-fetch/lfs' procedure. --=20 Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 08:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169778957923465 (code B ref 66436); Fri, 20 Oct 2023 08:13:01 +0000 Received: (at 66436) by debbugs.gnu.org; 20 Oct 2023 08:12:59 +0000 Received: from localhost ([127.0.0.1]:38579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtkcs-00066N-RS for submit@debbugs.gnu.org; Fri, 20 Oct 2023 04:12:59 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:49497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtkcq-00066B-Vi for 66436@debbugs.gnu.org; Fri, 20 Oct 2023 04:12:57 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D35D9320010B; Fri, 20 Oct 2023 04:12:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 20 Oct 2023 04:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697789543; x=1697875943; bh=TjErLIafFf4HOZ5hDE5CnmCM1BKPZZU8PiB kkI9bXpo=; b=T5OJkVW1iqI9jkIdbVmsBnUP+InjdaSLLz29n51JEkVW3xYio6w crdi8jXcoXF2nXyZ6w+sf3V+mqnbSnO1+L7e4Y+LuFNxbG0lg6sFlOePpFDepUA6 37KhqvkXXOByzJeBtNq/6ARiGLP0Go6izIgOiKYfaO/A5mH2DflbRgU6Phqpbezw gE43lT/D6KFR6UjDqW6GJMTAL90RkPaCGr4Am+U1Skss2VBwpzbAn/iRiAu9NgfB mVUfuk+3EKGVzmyea19rI3za9AVEloxtFwWhmpIh8Qn8Ts7F1/b4TVjkcaPUqop+ 1YkKt1xBBJ77aEUZCl5EnvSNcKoMXdrPaNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697789543; x=1697875943; bh=TjErLIafFf4HOZ5hDE5CnmCM1BKPZZU8PiB kkI9bXpo=; b=G2HDL4uJJZNLFsqi1LE+QF9lnxWW633KOkkvShkqXSJXKgYbTLn 4q/vCXE1f3FrjWD/OmFMGPBCYjDVYA6aSveUYijWgc6mB9VYg/hKewmFCOKrg4YT rfhGvbz78RtyY8sApb6OXn9hioDLDM/8+AmRGKG3/meKP82WSMFGuyLv4IxsunWs nKlT11THyEaKfqb3m6Y92XFTzRjdQuwAQct+qEUSAzBguhq42uf6b864hwD0hwpO DpnLGLX02USMFAXFpCHJTDfxiltp/+rqMFzv2pHng56YjeussgSqhcNc7bxSgwyz 4+6JhqzYdF2zdg+/j7mSXURIZ9HWlEgnW+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeekucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefujghffffkfgggtgfgsehtqhertddtreejnecuhfhrohhmpeevlhormhgvnhht ucfnrghsshhivghurhcuoegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgheqnecugg ftrfgrthhtvghrnhepgeekheefffdtfeffueevkefgfffhtddugfdugeeugeevgfduteff udfgfefhjedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheptghlvghmvghntheslhgrshhsihgvuhhrrdhorhhg X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Oct 2023 04:12:22 -0400 (EDT) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 10 Oct 2023 20:24:05 -0400") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> Date: Fri, 20 Oct 2023 10:12:11 +0200 Message-ID: <87h6mlzp9g.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, These are a few questions regarding reviewing. 1. What should the reviewer do with old-style patches, like the ones that don't use G-Expressions? Should we tell the submitter to use them when possible or is it only a matter of style that is up to the submitter? Obviously they are hard to grasp for newcomers. It's probably good for newcomers if we teach them how to use G-Expressions but we don't really have time to do so, given the number of patches waiting to be reviewed. This question could be extended to style issues. Like using %var versus var. 2. What should the reviewer do when only small changes are required? The reviewer could do these changes in seconds whereas asking for a new revision could take days. These changes could be indentation fixes, removing of unused code, but they could also be more substantial, like adding a missing `file-name` field. Or changing old-style to G-Expressions? If the reviewer makes such changes and pushes them right away, I imagine they should be documented and explained. 3. Should the reviewer run the program being packaged? The above guidelines speak about applying, reading, building and linting but not running. (Making sure it works as expected.) Thanks, Cl=C3=A9ment From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 23:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169784294715764 (code B ref 66436); Fri, 20 Oct 2023 23:03:02 +0000 Received: (at 66436) by debbugs.gnu.org; 20 Oct 2023 23:02:27 +0000 Received: from localhost ([127.0.0.1]:41862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtyVb-000468-8m for submit@debbugs.gnu.org; Fri, 20 Oct 2023 19:02:27 -0400 Received: from mail-oo1-xc34.google.com ([2607:f8b0:4864:20::c34]:52728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtyVU-00045m-BE for 66436@debbugs.gnu.org; Fri, 20 Oct 2023 19:02:21 -0400 Received: by mail-oo1-xc34.google.com with SMTP id 006d021491bc7-581cb88f645so771583eaf.1 for <66436@debbugs.gnu.org>; Fri, 20 Oct 2023 16:01:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697842903; x=1698447703; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ml7q1FSw0rL1lYADaL4/tkxbt6LgDYPTklZzqqstLMk=; b=LIRkFgxAZAX/EuKoIZWMwPuLG3IQMdHKyo2kpfVbklWG/gHhLFO4kB0xOWmaGQBHVn dpaAP2SoecxCrDdGd5JlWRYIu8ej03b6Lwc7ZS7FIC+VaOJbfMmVa5HONuBeHJPWvMIT K70nt/GHZTJ4NLsz2xgQk1ejOhrFSnfm7GuOqBShGzFCHjEmE1kUYsTKGtWP821dXxP2 MpM9zIRshXqnYZ+9KYynNBldKyP4IeTQML4bPr0bbiDMu6zVYbUjGkQ42bBRPMJamPPQ mFf1bXsDqilwK8dsV5J3b+H+h3BDISxPUtDsWwKb5jW2hK/Hnwh6YS9RwNZCC2+QkQrF gVug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697842903; x=1698447703; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ml7q1FSw0rL1lYADaL4/tkxbt6LgDYPTklZzqqstLMk=; b=dfp3kngkQ8KySTCWdff2xRElKQyETNMY8mrwKyBy0qMiIo0z4EHlSJxBANmMptcaYt 4+yIgbpbcRCdq59aLb2Pzmw+kQBcs+8gxd9R/mEbw82E9ImNRZNsuaSzOYNIil2+xscx ZJoxyLR4hs91k7u7q6bvXFeL7jzf69VBsCUmWhIMkEFUz8Gx/Fj/1LYViHTlAGWKu3eO 7AHNIWrSYn7BAZ8hvoI1orAqvHzresJB99L7YRcjwfwzDlGgJYahPnJfdQFKLVge5OYi 2/Iawo+L4otMTMVLFkcC1BaRmENmh2+zKPAt1wlJMpV3aFk/5eZ9ngxBAgOOyWur64a6 XMxQ== X-Gm-Message-State: AOJu0YxHflWMQFb1k9EXsFliurL7Q8bUtCnqczAEmYWTnj7SJ6OK3BXc bkvoBVnTE0+CqHQv2lvCn9s= X-Google-Smtp-Source: AGHT+IGMAu5dAI4nMu+lJMwgSkbpUsNwfNWTTtS6YtQaCNm1RTuH3uI5Kd70an7LrhwBzOSTDYOEag== X-Received: by 2002:a05:6358:4320:b0:13a:bd3:3f85 with SMTP id r32-20020a056358432000b0013a0bd33f85mr2765872rwc.23.1697842902960; Fri, 20 Oct 2023 16:01:42 -0700 (PDT) Received: from hurd (dsl-156-111.b2b2c.ca. [66.158.156.111]) by smtp.gmail.com with ESMTPSA id dq16-20020a05622a521000b004181e5a724csm938370qtb.88.2023.10.20.16.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 16:01:42 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87h6mlzp9g.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Fri, 20 Oct 2023 10:12:11 +0200") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> Date: Fri, 20 Oct 2023 19:01:41 -0400 Message-ID: <87r0logap6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Cl=C3=A9ment Lassieur writes: > Hi, > > These are a few questions regarding reviewing. > > 1. What should the reviewer do with old-style patches, like the ones > that don't use G-Expressions? Should we tell the submitter to use > them when possible or is it only a matter of style that is up to the > submitter? Obviously they are hard to grasp for newcomers. > > It's probably good for newcomers if we teach them how to use > G-Expressions but we don't really have time to do so, given the > number of patches waiting to be reviewed. > > This question could be extended to style issues. Like using %var > versus var. I think we should now make sure all new submissions use the current style; if they aren't we can demand of the contributors to adjust it. There is a blog post and enough examples in the code base already that should make this not too difficult. > 2. What should the reviewer do when only small changes are required? > The reviewer could do these changes in seconds whereas asking for a > new revision could take days. These changes could be indentation > fixes, removing of unused code, but they could also be more > substantial, like adding a missing `file-name` field. Or changing > old-style to G-Expressions? > > If the reviewer makes such changes and pushes them right away, I > imagine they should be documented and explained. In general, I think it's best to let the contributor know about the small problems so they can submit a v2, as they'll learn to pay attention to these. For first submissions, we can make the experience easier by adjusting locally and pushing directly for small things. This also holds for very old contributions where the original author is no longer around. I think these two points could be expound as new subsections of the 'Coding Style' section; the current scope is about codifying the human interactions more than the technical details. > 3. Should the reviewer run the program being packaged? The above > guidelines speak about applying, reading, building and linting but > not running. (Making sure it works as expected.) >From the diff: --8<---------------cut here---------------start------------->8--- +Perhaps the biggest action you can do to help GNU Guix grow as a project +is to review the work contributed by others. You do not need to be a +committer to do so; applying, reading the source, building, linting and +running other people's series and sharing your comments about your +experience will give some confidence to committers, and should result in +the proposed change being merged faster. --8<---------------cut here---------------end--------------->8--- So it does mention trying out the software ("running"). --=20 Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Oct 2023 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.16980050444906 (code B ref 66436); Sun, 22 Oct 2023 20:05:01 +0000 Received: (at 66436) by debbugs.gnu.org; 22 Oct 2023 20:04:04 +0000 Received: from localhost ([127.0.0.1]:48298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queg8-0001Gz-0J for submit@debbugs.gnu.org; Sun, 22 Oct 2023 16:04:04 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1queg6-0001G8-DM for 66436@debbugs.gnu.org; Sun, 22 Oct 2023 16:04:03 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2EF225C01B3; Sun, 22 Oct 2023 16:03:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 22 Oct 2023 16:03:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1698005008; x=1698091408; bh=GwqMRzACtRZwgoMDm+GozstS3R/9TMFX6zw vBZYK2IA=; b=c8R9bBEDoACoBgV9GVWXag25QMq+OQrdZaJw/74xWTspxTD1Ofr k7rb7+uU5ClC9ZgWrz3f/JU0owyy0Pug04g0tSCF4A0Guf/KiEVJ9C9rD6DOUCTB 43IzgjFOPioyllRvwruhbfNsZtZjbUes/ABsEyZIQ2hgnZ/o+0Djh95tDm8IdUFx gaATfKBW2SQupIQlKwtJh8IsPu7d8Y+SU5e19dPYGApttERQrn8l/0pUNQ4WnRzz 1GlqZ7TjxBN10K1s10u87hp7L3bFooNp03QetAeHV2oqMyRAIF2d1UuSNSv13Yk0 jKmnK0DKxkjstzH2kjerBRQ/UB6FtREnsNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1698005008; x=1698091408; bh=GwqMRzACtRZwgoMDm+GozstS3R/9TMFX6zw vBZYK2IA=; b=bNA1V1TS1ZYHSyXXUx/S6y0Ul0zSGpBSvh/gKgNG3qY5jhUkukm yenOVguyA8h9GMRRYTYRbcTIr/VLkWTKuzPpdRQdYjsSMTfU5f11EdC2hsyPkzBZ oTh5G/wG0t/0uUbn/+Lz5W7PEpWWRBMjPdHLuRvw3LEY58+WzofUV5+wqonuzIAj iw7hKl75VYdkJGaq2khqYNJIq3Ir5Yj7gI94pzIHO9hmo/jb9yeQEMMDayids1qn PusaONubwbItF33NLsMUeqY6pEAye79aFzuzfxFEQptmpMVPlIIVGp9hb5E0i+I1 loexa5pxcfzeQUfFV42m4VIRMW7Cx58TlRA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrkeeggdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeeiudeuheeviedtleelheeivedutdejgfevhfdvtedvudel hfdthedvvddtieehkeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhi vghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 22 Oct 2023 16:03:26 -0400 (EDT) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <87r0logap6.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 20 Oct 2023 19:01:41 -0400") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> Date: Sun, 22 Oct 2023 22:03:12 +0200 Message-ID: <87il6ybf27.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Maxim, Maxim Cournoyer writes: >> 1. What should the reviewer do with old-style patches, like the ones >> that don't use G-Expressions? Should we tell the submitter to use >> them when possible or is it only a matter of style that is up to the >> submitter? Obviously they are hard to grasp for newcomers. >> >> It's probably good for newcomers if we teach them how to use >> G-Expressions but we don't really have time to do so, given the >> number of patches waiting to be reviewed. >> >> This question could be extended to style issues. Like using %var >> versus var. > > I think we should now make sure all new submissions use the current > style; if they aren't we can demand of the contributors to adjust it. > There is a blog post and enough examples in the code base already that > should make this not too difficult. Are you referring to this one? https://guix.gnu.org/en/blog/2023/dissecting-guix-part-3-g-expressions/ >> 2. What should the reviewer do when only small changes are required? >> The reviewer could do these changes in seconds whereas asking for a >> new revision could take days. These changes could be indentation >> fixes, removing of unused code, but they could also be more >> substantial, like adding a missing `file-name` field. Or changing >> old-style to G-Expressions? >> >> If the reviewer makes such changes and pushes them right away, I >> imagine they should be documented and explained. > > +Perhaps the biggest action you can do to help GNU Guix grow as a project > +is to review the work contributed by others. You do not need to be a > +committer to do so; applying, reading the source, building, linting and > +running other people's series and sharing your comments about your > +experience will give some confidence to committers, and should result in > +the proposed change being merged faster. > > So it does mention trying out the software ("running"). Yes indeed! I didn't see it. Thanks for your reply! Cl=C3=A9ment From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Oct 2023 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169802619824885 (code B ref 66436); Mon, 23 Oct 2023 01:57:02 +0000 Received: (at 66436) by debbugs.gnu.org; 23 Oct 2023 01:56:38 +0000 Received: from localhost ([127.0.0.1]:48637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qukBH-0006TF-5N for submit@debbugs.gnu.org; Sun, 22 Oct 2023 21:56:38 -0400 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:58370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qukBC-0006Sx-Id for 66436@debbugs.gnu.org; Sun, 22 Oct 2023 21:56:34 -0400 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-41cbf8e1f77so16259291cf.0 for <66436@debbugs.gnu.org>; Sun, 22 Oct 2023 18:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698026156; x=1698630956; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bFEfs8bFlQm3YBSkg6jG4/B0Qu2a3Cbc95IrD0+H1qY=; b=JH1QGIf+xq6WnGvtwvhFdQdZ+a2Hh29rqIiDaVYoj6aDIUD+pAYT9cEAeWXlO4yunQ c8j/LVE/24xQASpKeKFslaQYoliadFccx4oBcVeaV3/mOokKvZ1hObA1VAJK+OdyU9QT VhPEeyp9mXR18M8VtmPk07G4lDgsA/KQrZ5lAl3o0r8Ti8dKahnj2D9S15gi3LpBrOPK vfafgamskvJTguKEY8SAta4CjIDEjrIL4r2gvTtuawGWGhT79oePK4o6AkEybiYnx4gf 6mqslGUkf1BSZsc51fhtL9QqI9cXPLNzPPLEPznOi1wFEM2fMrF5QnhVQ2eoFFhWiGp/ 35pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698026156; x=1698630956; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bFEfs8bFlQm3YBSkg6jG4/B0Qu2a3Cbc95IrD0+H1qY=; b=WbBRIrMk/ABYRFdf8UOcbJxMtw0irQxD7nQ6MLfzNRXBlA+luDuGR1hcVn5o8dd1kr iM03VFk6dU6Pbn23YOnpnV8q7lzfp5y44HyUm+cTtKl4ZbrNDQp093iKcRQGS3HniWnr HtC6aw9MU0/H0pjXNMm1j51i/K+MRN6MGPN15M327TkYveyxcHmshQU3+42/8PQMVbfz mnRPjmPAuU2NeT4lIZra2J2DieL9rsCbwBrvz84x0X31UUPsrI3VFkOnJ4w7OlaODIIO AHQoq5TCLlMtbrW97qqV4NowtxtC8hvaVIprgepV9O9yluXpvOiWpbO5mgaX314BOBNn wJQQ== X-Gm-Message-State: AOJu0YyooQ08oXPaciM+ex71t6pmUGwnT0eCJdb08LE25I6OM6y1pFbr +LLU/8lLDsHs95YsWuBTAsQ= X-Google-Smtp-Source: AGHT+IEnoQlIQTLyy64woTgy0F8Yk42BAudpxUQH7KPNsgEHLtME3SKPIv9WxHnWG5sSDfFq9bn91Q== X-Received: by 2002:a05:622a:490:b0:41c:e206:349b with SMTP id p16-20020a05622a049000b0041ce206349bmr5672939qtx.68.1698026156094; Sun, 22 Oct 2023 18:55:56 -0700 (PDT) Received: from hurd (dsl-205-236-230-191.b2b2c.ca. [205.236.230.191]) by smtp.gmail.com with ESMTPSA id t10-20020ac8738a000000b00417db2593bdsm2384501qtp.72.2023.10.22.18.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 18:55:55 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87il6ybf27.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?= Lassieur"'s message of "Sun, 22 Oct 2023 22:03:12 +0200") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <87il6ybf27.fsf@lassieur.org> Date: Sun, 22 Oct 2023 21:55:54 -0400 Message-ID: <8734y29k5x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Cl=C3=A9ment Lassieur writes: > Hi Maxim, > > Maxim Cournoyer writes: > >>> 1. What should the reviewer do with old-style patches, like the ones >>> that don't use G-Expressions? Should we tell the submitter to use >>> them when possible or is it only a matter of style that is up to the >>> submitter? Obviously they are hard to grasp for newcomers. >>> >>> It's probably good for newcomers if we teach them how to use >>> G-Expressions but we don't really have time to do so, given the >>> number of patches waiting to be reviewed. >>> >>> This question could be extended to style issues. Like using %var >>> versus var. >> >> I think we should now make sure all new submissions use the current >> style; if they aren't we can demand of the contributors to adjust it. >> There is a blog post and enough examples in the code base already that >> should make this not too difficult. > > Are you referring to this one? > https://guix.gnu.org/en/blog/2023/dissecting-guix-part-3-g-expressions/ Rather to the one corresponding to the 1.4.0 release, which introduced these new changes: . --=20 Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Oct 2023 09:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169813810927062 (code B ref 66436); Tue, 24 Oct 2023 09:02:03 +0000 Received: (at 66436) by debbugs.gnu.org; 24 Oct 2023 09:01:49 +0000 Received: from localhost ([127.0.0.1]:53088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDIK-00072O-No for submit@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:49 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:38168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDI8-000714-SR for 66436@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:38 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c51774da07so14866761fa.1 for <66436@debbugs.gnu.org>; Tue, 24 Oct 2023 02:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698138061; x=1698742861; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=li8ggQWWKb4FHRHSGVZdvNVc09pVZtJne+HMPfTltmk=; b=OwxLNcwQDQMIgvvScAKXahlv5XNx2Jy4ZW1KLiKmkb0Uwsn1RNj01QSTxnA9VFIbBM p3Kp19N9cPULR91fRH74Wl4ioQ9uWq2oKa60mZPkx68+Oa8MZKVP07ws7bU+yz5wyyo0 oyR/OOK12pN9NO33gyldX59RR3vItVH9lBpkq+goLVT5+021vAWsJade3eYrDq6T9zNO m3rC4ZTmcrVwdjscNASumPlEm0+duRh5/U1HcdabmnyKsFSt/i8rInXqJzToZK004lll R/oHqRyWdCtGf5UujKj0jhViBEwEHf8qzb40qkxILL314imgEw2V9iX6fnViBDISCkrD UMpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698138061; x=1698742861; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=li8ggQWWKb4FHRHSGVZdvNVc09pVZtJne+HMPfTltmk=; b=X11JeeqLki2GOdLB46nJxP2jbM5FI9LZVqUDj8ZEtAfu4FTxznOwVRZ78XmZJsB6Jt /QbeVNxpb1L0g3ZWLYt8Sfrq4GJYybBMQhwzkQpSzBqlyLyxYeT3Ym8H7APpqdFdWnmB 5Ee0L4e3uk8fufCUuZngpipz3OKWzbkHlcqvC7jQR15FJi/xoI0dGq2l+RSncswYBlDi 2yUfiPGxxROYZoN72E+LhwpcUcepZlpjLzorvOnRP8kskLDtHtCRRHWLqvFSMGQ9GF66 CEuRI5aodJPymfPWc2YebWQd+xxiJrnYCtspUW67vyDYb1oSlGd1ELBG9E6ScNCFxmaO 2XKg== X-Gm-Message-State: AOJu0YzTVcoOp+nxs3kN6wlq3X/wAXP1KzT4dyfDjGG6bBV7qcC5ch9w SZi6KSVdEN6abRSdAt24w80= X-Google-Smtp-Source: AGHT+IHs560xRcJAkl8Iq/9xSMdISQvT4ezksAs+bA50ocOQcrHqe5OkknVs1APJN5WrVAjudxtcHQ== X-Received: by 2002:a2e:a0d4:0:b0:2c5:409:7005 with SMTP id f20-20020a2ea0d4000000b002c504097005mr7595698ljm.4.1698138061102; Tue, 24 Oct 2023 02:01:01 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id r9-20020a05600c320900b0040644e699a0sm16133994wmp.45.2023.10.24.02.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 02:01:00 -0700 (PDT) From: Simon Tournier In-Reply-To: <87r0logap6.fsf@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> Date: Tue, 24 Oct 2023 10:49:35 +0200 Message-ID: <86il6wv200.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Fri, 20 Oct 2023 at 19:01, Maxim Cournoyer w= rote: >> 3. Should the reviewer run the program being packaged? The above >> guidelines speak about applying, reading, building and linting but >> not running. (Making sure it works as expected.) > --8<---------------cut here---------------start------------->8--- > +Perhaps the biggest action you can do to help GNU Guix grow as a project > +is to review the work contributed by others. You do not need to be a > +committer to do so; applying, reading the source, building, linting and > +running other people's series and sharing your comments about your > +experience will give some confidence to committers, and should result in > +the proposed change being merged faster. > --8<---------------cut here---------------end--------------->8--- > > So it does mention trying out the software ("running"). If LGTM also implies =E2=80=9CI run it and it is OK=E2=80=9D, then submitte= r should provide how to run it. Otherwise, for what it is worth, I will stop to review stuff that I do not use myself because reviewing is asking me too much: read some doc about how to run something that I do not care. ( Similarly, if LGTM also implies =E2=80=9CI have read the source code = and it is OK=E2=80=9D, it appears to me too much. ) Well, =E2=80=9Crunning=E2=80=9D and =E2=80=9Ctrying out the software=E2=80= =9D seems ambiguous. What does it mean =E2=80=9Crun IceCat=E2=80=9D or =E2=80=9Crun Gmsh=E2=80=9D or = else? What I like with the proposal is that it makes better defined what are the expectations behind LGTM. But what means =E2=80=9Crunning=E2=80=9D is = not clear for me. IMHO, it is worth to clearly state: 1. what helps the review process: =C2=AB applying, reading the source, building, linting and running other people's series and sharing your comments about your experience will give some confidence to committers, and should result in the proposed change being merged faster. =C2=BB 2. what means LGTM, from my understanding: applying, building, linting, carefully checking the code that is merged to Guix. Cheers, simon From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Oct 2023 09:02:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169813810927069 (code B ref 66436); Tue, 24 Oct 2023 09:02:04 +0000 Received: (at 66436) by debbugs.gnu.org; 24 Oct 2023 09:01:49 +0000 Received: from localhost ([127.0.0.1]:53090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDIL-00072R-DF for submit@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:49 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]:40303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvDIA-00071D-4A for 66436@debbugs.gnu.org; Tue, 24 Oct 2023 05:01:39 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-408cd9660b8so6811855e9.1 for <66436@debbugs.gnu.org>; Tue, 24 Oct 2023 02:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698138063; x=1698742863; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=QN6r7vasWJbMM/qei2Kvz0q7SMxVXIE1ynIYFPt6kCc=; b=G0BwryMvFKa0m6cVoMlHloK1yfrIPJ0HV7zMhiNHC6N2MQfs5w5CwQ6RiR+kJZazrv /D1Yu5z4jY9B2UJNAiYKpMx2dURPs962TcIUdKJ0EixnrYW2toD0XXefQwG8w+U/xp8o fVul1Uwf0+o957SuRwUOpL48avffiMiERWUb9gEyYyc4qasCGnKL3clqzcfkkraa93tu a7xs84tXQZo0VDPa/UhJnQ2vDdUgb1AeeAcSedu1CL+lYOj+yfcQQS1bIvZA2+w/CDoo +2vVQrjpjWutswDGzz0ql2cdoLQp7wUmWwKh38sQFosYG2x9R7XTnvx8vQPFo7FJbvQx CCXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698138063; x=1698742863; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QN6r7vasWJbMM/qei2Kvz0q7SMxVXIE1ynIYFPt6kCc=; b=edfq1Xck2DndovkDP2mct6Wl6SfVodmE+uj2fEIc/hyPcSZcSK+JxRv3WKQAl2wS2u sKhBcuCWb9F+tZNmmrKBmTherYcQF3O2+PZ8Bv5qlmlwOBXLCoFCyfHQzODXky1CaJ7D ixWtpjufJo91lu9pjdygbKmNM9NZZRQW2tBuCJJL8uUnS8zaancP4CrIF1iAVCYYoWxR nsw6718r+N8TX4AMc7D7ukA/xkFpln9482+qGKccJJtaULGv0e+UaC99h1jyvj2phw/k 4mFKJq8TUcKBgUwMNTSzm1ujEE14Ve6hP+1jLSlf1lIKq3dGvWWrChJ3b/OJY/GWeDoF /kGA== X-Gm-Message-State: AOJu0YxI9fwIGMPybuZcuORMdTyAZVL+Yvx6jlyBF+jYykzj/86Z3Yrn oWoyaziQ9nmgNs8pZHcMAL0iq+KnGMU= X-Google-Smtp-Source: AGHT+IHx7JYD0GhoGu6XrQXmDaa8jQGVE8tp001iTGDSdJq9G3OH1wxTMxHAYumyJPRqJrCfNn/NVw== X-Received: by 2002:a05:600c:4c17:b0:405:358c:ba75 with SMTP id d23-20020a05600c4c1700b00405358cba75mr8906080wmp.0.1698138062524; Tue, 24 Oct 2023 02:01:02 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id ay10-20020a05600c1e0a00b00405442edc69sm13698616wmb.14.2023.10.24.02.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 02:01:02 -0700 (PDT) From: Simon Tournier In-Reply-To: <86il6wv200.fsf@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <86il6wv200.fsf@gmail.com> Date: Tue, 24 Oct 2023 10:59:45 +0200 Message-ID: <86bkcov1j2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Re, On Tue, 24 Oct 2023 at 10:49, Simon Tournier wro= te: >> --8<---------------cut here---------------start------------->8--- >> +Perhaps the biggest action you can do to help GNU Guix grow as a project >> +is to review the work contributed by others. You do not need to be a >> +committer to do so; applying, reading the source, building, linting and >> +running other people's series and sharing your comments about your >> +experience will give some confidence to committers, and should result in >> +the proposed change being merged faster. >> --8<---------------cut here---------------end--------------->8--- [...] > IMHO, it is worth to clearly state: > > 1. what helps the review process: > > =C2=AB applying, reading the source, building, linting and running ot= her > people's series and sharing your comments about your experience will > give some confidence to committers, and should result in the > proposed change being merged faster. =C2=BB Although I do not know if it is the right place, I would mention that =E2=80=9Cbuilding=E2=80=9D also means that the dependants still build or cl= early indicate if something breaks. Cheers, simon From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 24 Oct 2023 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169816289317195 (code B ref 66436); Tue, 24 Oct 2023 15:55:01 +0000 Received: (at 66436) by debbugs.gnu.org; 24 Oct 2023 15:54:53 +0000 Received: from localhost ([127.0.0.1]:56384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvJk5-0004TG-FI for submit@debbugs.gnu.org; Tue, 24 Oct 2023 11:54:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvJk1-0004Sx-2H for 66436@debbugs.gnu.org; Tue, 24 Oct 2023 11:54:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvJjR-00023q-Q2; Tue, 24 Oct 2023 11:54:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HAKdRPaX35x2KDVE0xnwaq0WXhyZ2FE/OS7Vfy5PEwY=; b=UT2cB5VVPXCbdr679Q4y rTpmM36OQIVkKgMHipIYKp9HFMlA7M87dJXQqrbOFn/i2dbdAVpJYiGA4bwdJlMjU4J5XRQUZXvNB iKoLYirViG5Ad4+lOxbp6gjhEum5gtcu/CtP316UguRPjIxRyvm1/tn/tmWAKVRzBxJW5qpMdPzWi d6oq0erWiqKyXhe1+lJLyhFFB11a07oM3KIfYIhzpwRNoTKeYmsApSP88+cnRecJUek8LYqR23peU bTHv2emvkjFNssOchNJjdNfFpYS/bUUS4sNQdqypbCIsldM7DXAfKzIp1odWezfW7KRlc7i1dsdrd 49bLXdRTdf9Ewg==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 10 Oct 2023 20:24:05 -0400") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> Date: Tue, 24 Oct 2023 17:54:11 +0200 Message-ID: <87a5s86mos.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New > section. > * doc/contributing.texi (Debbugs Usertags): Expound with Emacs Debbugs ^ Nitpick: no need to repeat the file name. > +@node Reviewing the Work of Others > +@section Reviewing the Work of Others [...] > +@cindex reviewing, guidelines > +Review comments should be unambiguous; be as clear and explicit as you > +can about what you think should be changed, ensuring the author can take > +action on it. Please try to keep the following guidelines in mind > +during review: [...] > +@item > +@emph{Remain focused: do not change the scope of the work being > +reviewed.} For example, if the contribution touches code that follows a > +pattern deemed unwieldy, it would be unfair to ask the submitter to fix > +all occurrences of that pattern in the code; to put it simply, if a > +problem unrelated to the patch at hand was already there, do not ask the > +submitter to fix it. Another item came to mind, that could be phrased like this: Spend time proportional to the stakes. Ensure the discussion focuses on important aspects of the changes; do not let it be derailed by objectively unimportant issues@footnote{This situation is often referred to as ``bikeshedding'', where much time is spent discussing each one's preference for the color of the shed at the expense progress made on the project to keep bikes dry.}. In particular, issues such as code formatting and other conventions can be dealt with through automation---e.g., @command{guix lint} and @command{guix style}---or through documentation (@pxref{Packaging Guidelines}, as an example). Maybe that makes the guidelines too long though; your call. Otherwise LGTM! Ludo=E2=80=99. From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Oct 2023 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxim Cournoyer Cc: 66436@debbugs.gnu.org Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169824220813517 (code B ref 66436); Wed, 25 Oct 2023 13:57:01 +0000 Received: (at 66436) by debbugs.gnu.org; 25 Oct 2023 13:56:48 +0000 Received: from localhost ([127.0.0.1]:59710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveNM-0003Vx-BF for submit@debbugs.gnu.org; Wed, 25 Oct 2023 09:56:48 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:39994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qveNH-0003Vn-BW for 66436@debbugs.gnu.org; Wed, 25 Oct 2023 09:56:46 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-408434ce195so14259635e9.0 for <66436@debbugs.gnu.org>; Wed, 25 Oct 2023 06:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698242167; x=1698846967; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KM7BSEdQ0QxuZmQu6dXGQy+iDimH8K/cJEmEL5lEfzg=; b=kdfnyG9dYMi1dnEs+XTiH5rdaSIjqlAiY0vMLHAymmNSjdFNc2Luu76f/nOkMHoHcI SRDUGQll8qTYPC2KE6nZf9+D3lWhzGVjYkRiLyDa7nkmvCnT4/TYdGlV5gmTOgbJlaQH aD2QXlzkZOeTO7ZwXsfuJnOvz1Pfdm+5N8bO0Nga0eG1yxErMVNkIT3ctU3UoBdlf0rj nyxhrsVeOSX/alYCgWwSLXW+buhS+/P3YCKtuXVWJfBjbpQ81IqUDWN6wiTSNb3zZ6AA KHgD6SKpxColpadWkW7XLSUfzwieaWjv57N20vs0L+rIF9dp0hSNxnlFitq9ANQYrPoz +Cvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698242167; x=1698846967; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KM7BSEdQ0QxuZmQu6dXGQy+iDimH8K/cJEmEL5lEfzg=; b=IWh2aeduscXSYfINGDQssgllBc2HSXXZy/uO/JRylTUYHITnZvIE9r05DpDAG5CUDc DZK35KhFiKDYzQo4Vh4pdwuMJ6fGu4lxfu26jPuTQaG4x5Pev3fg7Y55iwJZ71z9Ygkm JiK9FVydm583q/oSR7JeDlKLJ83df9nV4OhFjPSE10Rfuc0J89tPK8VPbuFfdbM5S+cq oXH1FD6zOqD61FNYlK67aCp/or3n9kxpFRfqel+qBm448OQAyOBLAZmrXjuRlHra72xx /ejHI7ofiE1SWA0ZXYgH+vXfJhzJvIWYN2lWJEk4z3z4GdgJ1XUqsMqZrHqbD7nsVo32 qLrg== X-Gm-Message-State: AOJu0YwFqTqep1tJkK+kkTneNIvC7Z90M6BP9oPp/aid8MqDpKeicQTQ yrtEA5y17OXECCln7RW9Hp/p+1f2qkU= X-Google-Smtp-Source: AGHT+IESh+VhOpU+5Z+3e8Lq5ykj53AyGQVQXumMEW3jyeV5CTy6powOWAucjUHXcCp7YFRxSscP2g== X-Received: by 2002:a05:600c:4c17:b0:405:358c:ba75 with SMTP id d23-20020a05600c4c1700b00405358cba75mr11710551wmp.0.1698242166799; Wed, 25 Oct 2023 06:56:06 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id j13-20020a5d452d000000b0032d8eecf901sm12209937wra.3.2023.10.25.06.56.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 06:56:06 -0700 (PDT) From: Simon Tournier In-Reply-To: <87a5s86mos.fsf@gnu.org> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87a5s86mos.fsf@gnu.org> Date: Wed, 25 Oct 2023 15:53:04 +0200 Message-ID: <87o7gmhkqn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi On Tue, 24 Oct 2023 at 17:54, Ludovic Court=C3=A8s wrote: >> +@item >> +@emph{Remain focused: do not change the scope of the work being >> +reviewed.} For example, if the contribution touches code that follows a >> +pattern deemed unwieldy, it would be unfair to ask the submitter to fix >> +all occurrences of that pattern in the code; to put it simply, if a >> +problem unrelated to the patch at hand was already there, do not ask the >> +submitter to fix it. For me this item is clear=E2=80=A6 > Another item came to mind, that could be phrased like this: =E2=80=A6while this new is unclear=E2=80=A6 > Spend time proportional to the stakes. Ensure the discussion focuses > on important aspects of the changes; do not let it be derailed by > objectively unimportant issues@footnote{This situation is often > referred to as ``bikeshedding'', where much time is spent discussing > each one's preference for the color of the shed at the expense > progress made on the project to keep bikes dry.}. In particular, > issues such as code formatting and other conventions can be dealt with > through automation---e.g., @command{guix lint} and @command{guix > style}---or through documentation (@pxref{Packaging Guidelines}, as an > example). =E2=80=A6especially in the light of these other items: +@item +@emph{Review is a discussion.} The submitter's and reviewer's vie= ws on +how to achieve a particular change may not always be aligned. As a +reviewer, try hard to explain the rationale for suggestions you ma= ke, +and to understand and take into account the submitter's motivation= for +doing things in a certain way. +@item +@emph{Aim for finalization.} Reviewing code is time-consuming. Y= our +goal as a reviewer is to put the process on a clear path towards +integration, possibly with agreed-upon changes, or rejection, with= a +clear and mutually-understood reasoning. Avoid leaving the review +process in a lingering state with no clear way out. Well, I do not like: =C2=AB discussion focuses on important aspects of the changes; do not let it be derailed by objectively unimportant issues =C2=BB because it is not clear for me what means =E2=80=9Cimportant aspects=E2=80= =9D or =E2=80=9Cobjectively unimportant issues=E2=80=9D. How do I gauge? Sometimes, what does not appear to me =E2=80=9Cimportant=E2=80=9D at first = has then, at the end, an impact that cannot be neglected. This new item appears to me as: it is not a open discussion and you should refrain from commenting if you are not sure your point is *absolutely* important. Instead of this new item =E2=80=93 where my understanding is: avoid bikeshe= d :-) and I agree =E2=80=93 I propose to amend the item @emph{Review is a discuss= ion.} by explicitly refer to the 3 other items; which are, IMHO, the guards against bikeshedding. Something along: --8<---------------cut here---------------start------------->8--- @item @emph{Review is a discussion.} The submitter's and reviewer's views on how to achieve a particular change may not always be aligned. The discussion is lead by remain focused, ensure progress and aim for finalization; spend time proportional to the stakes@footnote{This situation is often referred to as ``bikeshedding'', where much time is spent discussing each one's preference for the color of the shed at the expense progress made on the project to keep bikes dry.}. As a reviewer, try hard to explain the rationale for suggestions you make, and to understand and take into account the submitter's motivation for doing things in a certain way. --8<---------------cut here---------------end--------------->8--- WDYT? Does it capture the idea? If yes, I would pick this order for the enumeration: 1. Be clear and explicit about changes you are suggesting=20 2. Remain focused 3. Ensure progress 4. Aim for finalization 5. Review is a discussion Cheers, simon From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Oct 2023 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169859118331215 (code B ref 66436); Sun, 29 Oct 2023 14:54:02 +0000 Received: (at 66436) by debbugs.gnu.org; 29 Oct 2023 14:53:03 +0000 Received: from localhost ([127.0.0.1]:43142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx79z-00087P-25 for submit@debbugs.gnu.org; Sun, 29 Oct 2023 10:53:03 -0400 Received: from jpoiret.xyz ([206.189.101.64]:43748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qx79w-00086z-Ti for 66436@debbugs.gnu.org; Sun, 29 Oct 2023 10:53:01 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 3175D184D5F; Sun, 29 Oct 2023 14:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1698591146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YWA+3zPEQYB0O/EFdMRACGf4Gm5f2ViHb5imEqtBrRY=; b=CfrWHWVGPDraonDSqwsOF6zFxonoMQfNWgk2pbgMdECPTwIDl6kHniXaXVsMTpzr5QN5O7 MvfxczFJt7dIbpDHnMMQ1W3jyU2vYsdtloEuzrid3nOYiJWFm3KZY5dewIlbjPMevKvpgS nxqOacIP6r9upJ7J1I2dAsRc2FLbhiM8jsEaXIO0IvUoT6rLuRSbG6yKqGQDhSwDdBYumr yDvcEuTVX5pjHewzUIZgdFSxoyh1oZ6HMVJ1oyVCfm8ds2bdIVlBeSQ3aZG+CRywwczS/b a5qCjsDP2V71bqoJCbuSXwFaJUq8EuvzlB1K3T1hnvbDg1wENKAZYhXBgfvwoA== From: Josselin Poiret In-Reply-To: <87fs2azmvv.fsf@gmail.com> References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87jzroyzuk.fsf@jpoiret.xyz> <87fs2azmvv.fsf@gmail.com> Date: Sun, 29 Oct 2023 15:52:21 +0100 Message-ID: <878r7l4h22.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim, Maxim Cournoyer writes: > Do you use such a tool when applying patches working with Guix review? Yes, it's very useful. > I'm not too fond of adding tool-specific bits to the otherwise > tool-agnostic section above, but perhaps we could add a note or > something. You can view this as a tool-agnostic but clear way way of formally saying "I've reviewed this". Otherwise, it's not entirely clear when someone has reviewed a patch series IMO. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmU+caUQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcailN7C/9JkUFR8VDrWk5Fn+o4wmiRpJUBHVl1Zj7D NoB2OvcgUXm7z3tXWHcwKJUPdXzScQiwt6FfolomAtbxWwqrdYLCn4LwWkGuadxc U0yiMFydcREFCvlynkuYpXbCN/+gkKVWrFU6YY+QKFanxxiq5Tk4mF9oivrooQ0H mSQTDzgWkC/PmtLrTvTqkUpfxf9JRwpdl0vqxkPwbVr3W+5ltmlnraA4oWqLKtsU v3mSM3X8VK0A+MeGKjlg4pZ0VFirPkSo9WDSOei1uymOE5ukantDEVjDXjlmuJ2q K7TOGixajvRvL6+vXYSdC8VOXSRmwE2xqxmhguduH4FQtRQf1lvZY1VaNEpwmpwQ 4mKajByo7frie2IJ+8o6hdYsSFgW93mpNBoXuPlIFEBp5YYFMPmwL4gTbKzQ/FnD +8nFJBrjwunLmZrku35YB2+csUp7bhSmEZxGdvYdQz9xdwjVIw9L5aAmKlzxpXtV Od7Hzs5AQue5JrnXhHLxRS8HRS9WWj0= =u3NA -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Oct 2023 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169877847417617 (code B ref 66436); Tue, 31 Oct 2023 18:55:02 +0000 Received: (at 66436) by debbugs.gnu.org; 31 Oct 2023 18:54:34 +0000 Received: from localhost ([127.0.0.1]:49172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxtso-0004a4-1J for submit@debbugs.gnu.org; Tue, 31 Oct 2023 14:54:34 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:45336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxtsh-0004Zj-UV for 66436@debbugs.gnu.org; Tue, 31 Oct 2023 14:54:32 -0400 Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3b2ec9a79bdso4154723b6e.3 for <66436@debbugs.gnu.org>; Tue, 31 Oct 2023 11:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778427; x=1699383227; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9xRKDmKD9bWsvBQoM36Cw/wb4GaXxs6b7UXebn1nw0A=; b=asjiCj7dhNQSxtTh4CA8iBHh8fs+RJXDiOMK5pPkhr6EbTXHAsxk+6dAb9C1EWwxs9 CPiYikMhvgJ/MO9rp/P5Mhh9ndeeb56Fj1bph9KZJNDvkUll2sJXV3Re4DdaEjtGT45Q bOHc7BHZwhOmQCaA1utwo7PaO2mSF1laKzp+KdJNcF3Kmo7ZcSihYsOMRP6c/9Q6F0um hVS5EozQZeLyTxZNcXdL0LNSDwV9SpZ7ZEhmiZwVmVr6mnZTDClL79GW56yXW5qRaLjv Mabq/CxdiRre9t/udtPTiR4Wz5UaPBjgDdOoWuHW3o14AIKT2szcPcYzxw9p5nEf7y7z wxYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778427; x=1699383227; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9xRKDmKD9bWsvBQoM36Cw/wb4GaXxs6b7UXebn1nw0A=; b=eOjKXBLBH5NL6xmt3UhN6dM7tNtBd+dHo+i8i7R2BwaM7UaNO9ntbC6Co1/MB/2TAb k3D/XyA6SmkCu6G3cZZrI9dt5ZM/KJuZBkm5NRAku9OLo49xiB++40udeMFzMtHYnPrM MW4oE+8Tggt/SSb5mzz6l/4q+jzKrbEvYN8+TALrplXLaBey2HNv6jVUzAHyOZBhn8is g93HewpAG11XYmPZ/KTHPOQaiTuY24w1Xb6K/e/G30A5pdntY2fVYcX6DWyO3qUP/JDf d7ZIAiyeiiAgBHKYqNVpqw3yGfdrb2a2fb+f6HyrOaBWXTenWmDhgAOwEg03lZu4QE4W IU/w== X-Gm-Message-State: AOJu0Yw2XqBWW5zCWxYuTyERHn7Gcb+W6tZp9vn0LL+/Nc6O70paiPQ7 r5SIEdETZF+IQwIkmgAcOcg= X-Google-Smtp-Source: AGHT+IFI5JGUFFUniN/SUg4tYTdPApVl1PuF3eMs+yul80xOGyvM5Y4+LTxvSZJFHfGYcLgT7fwB8Q== X-Received: by 2002:aca:1705:0:b0:3b2:e12e:d2db with SMTP id j5-20020aca1705000000b003b2e12ed2dbmr14677544oii.39.1698778427334; Tue, 31 Oct 2023 11:53:47 -0700 (PDT) Received: from hurd (dsl-10-128-239.b2b2c.ca. [72.10.128.239]) by smtp.gmail.com with ESMTPSA id j16-20020a05620a0a5000b007742bc74184sm735830qka.110.2023.10.31.11.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 11:53:46 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <86bkcov1j2.fsf@gmail.com> (Simon Tournier's message of "Tue, 24 Oct 2023 10:59:45 +0200") References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <86il6wv200.fsf@gmail.com> <86bkcov1j2.fsf@gmail.com> Date: Tue, 31 Oct 2023 14:53:45 -0400 Message-ID: <87jzr2pqrq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, Simon Tournier writes: > Re, > > On Tue, 24 Oct 2023 at 10:49, Simon Tournier w= rote: > >>> --8<---------------cut here---------------start------------->8--- >>> +Perhaps the biggest action you can do to help GNU Guix grow as a proje= ct >>> +is to review the work contributed by others. You do not need to be a >>> +committer to do so; applying, reading the source, building, linting and >>> +running other people's series and sharing your comments about your >>> +experience will give some confidence to committers, and should result = in >>> +the proposed change being merged faster. >>> --8<---------------cut here---------------end--------------->8--- > > [...] > >> IMHO, it is worth to clearly state: >> >> 1. what helps the review process: >> >> =C2=AB applying, reading the source, building, linting and running o= ther >> people's series and sharing your comments about your experience will >> give some confidence to committers, and should result in the >> proposed change being merged faster. =C2=BB > > Although I do not know if it is the right place, I would mention that > =E2=80=9Cbuilding=E2=80=9D also means that the dependants still build or = clearly > indicate if something breaks. That's already mentioned in 'Submitting Patches': 9. Check that dependent packages (if applicable) are not affected by the change; =E2=80=98guix refresh --list-dependent PACKAGE=E2=80=99 wi= ll help you do that (*note Invoking guix refresh::). I don't think we should repeat it here :-) (also, we now have CI, which should be more apt at catching breakage here). -- Thanks, Maxim From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v2] doc: Add some guidelines for reviewing. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Oct 2023 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169877908518770 (code B ref 66436); Tue, 31 Oct 2023 19:05:02 +0000 Received: (at 66436) by debbugs.gnu.org; 31 Oct 2023 19:04:45 +0000 Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxu2e-0004sg-Rg for submit@debbugs.gnu.org; Tue, 31 Oct 2023 15:04:45 -0400 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:41232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxu2a-0004sM-7a for 66436@debbugs.gnu.org; Tue, 31 Oct 2023 15:04:44 -0400 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6c7a4735a30so909810a34.1 for <66436@debbugs.gnu.org>; Tue, 31 Oct 2023 12:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698779038; x=1699383838; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Hn/ODctyiJTEJAUd6e32k95DxapynrNIlSGIm7oe5ho=; b=OaheXIQ73c+FfG6J+GIx9jleAYNkwvnSSU589teqk91Fr0mnfsPZIiGfsFJ+Mu6bku S1jWqIJyzRsG/GQB+Fcupvl7WGHRoRIubumc0Wde6ejenPk9PI7hZ2FS/CbJOowSdRUi pGC08hjgHduO0u9lYwaZ9Msv/4IdkOh5cCMXERxsk6SJXNjIQ+sY3egjRMqt5fB8Xb92 b/6zk5WkI8InpV3oAv39vYPrWjRmcK2E2YGQPVAb+DfW0Jj/cc/+zbjKARx3txgP/j9q NJ5LbNulwULUUtga4/rHz8oEDw4tE7yi4uETrSr6M9RPdm7ncIoympe7akOKJiC5ut0J M3wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698779038; x=1699383838; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hn/ODctyiJTEJAUd6e32k95DxapynrNIlSGIm7oe5ho=; b=ValfbJp3jYLV7QB80ChqiFBt+Ktj8L137Vyg1tepQcIvnTaAKY10FJOxkqitjFOFGu +cGyRENucDP7RQ9X5CcvWLQhLkTdWryGcV180lR3vEi8BqBxp47tBHLdayX5x3ct84Ci HdEC7zRz51yW63O6jeHF5TxnoWD0fbrAna3NiS1HZKs2vsZzxfQ1bVNxBFwFgLJKk0xI h7PrdgaVfgsZdFcy8IP0KyAIlvf0VIRCFl5G3oVRqGjnpW6YEJv2lMhh+ofPvKk/eNkx ZebomKuo0CIVFswAnP3TYjwR3K3x6qkkTy3LyrK7FeS4PP8j9guWqgVzdvEpWBNnaFBl JnIg== X-Gm-Message-State: AOJu0Yxks3nuDZdaVuWa2LoOshMBdDkUR7F75ysN5X6ATLAgTxnTcE7N lP6692eoMHKSvfnqI9aihPXdz92nQOGBXc4qw20= X-Google-Smtp-Source: AGHT+IHpB3xOmDc7hEWyIqVs4v5psvQJPcPEEN5uDhpB7T/ynCOtscMGCkDQuAsv/VEmobpc13jMI217CKWFRnfObno= X-Received: by 2002:a05:6808:2024:b0:3ad:f3c0:5da3 with SMTP id q36-20020a056808202400b003adf3c05da3mr15352512oiw.3.1698779038745; Tue, 31 Oct 2023 12:03:58 -0700 (PDT) MIME-Version: 1.0 References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> <0a5e027af3c0b61f9ab9f3c66e73b7a769eef7fd.1696983695.git.maxim.cournoyer@gmail.com> <87h6mlzp9g.fsf@lassieur.org> <87r0logap6.fsf@gmail.com> <86il6wv200.fsf@gmail.com> <86bkcov1j2.fsf@gmail.com> <87jzr2pqrq.fsf@gmail.com> In-Reply-To: <87jzr2pqrq.fsf@gmail.com> From: Simon Tournier Date: Tue, 31 Oct 2023 20:03:47 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Tue, 31 Oct 2023 at 19:53, Maxim Cournoyer wrote: > >> IMHO, it is worth to clearly state: [...] > That's already mentioned in 'Submitting Patches': [...] > I don't think we should repeat it here :-) (also, we now have CI, which > should be more apt at catching breakage here). We are listing the expectations for the Review process, therefore repeat that the dependencies need to be checked at Review time makes sense to me. It can be a sentence as: "make sure CI does not report new error" or something like that. Cheers, simon From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v3] doc: Add some guidelines for reviewing. References: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> In-Reply-To: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Nov 2023 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66436@debbugs.gnu.org Cc: dev@jpoiret.xyz, ludo@gnu.org, Maxim Cournoyer , zimon.toutoune@gmail.com Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169886669731157 (code B ref 66436); Wed, 01 Nov 2023 19:25:01 +0000 Received: (at 66436) by debbugs.gnu.org; 1 Nov 2023 19:24:57 +0000 Received: from localhost ([127.0.0.1]:52631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyGph-00086P-0V for submit@debbugs.gnu.org; Wed, 01 Nov 2023 15:24:57 -0400 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]:58626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qyGpb-000861-7K for 66436@debbugs.gnu.org; Wed, 01 Nov 2023 15:24:51 -0400 Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3b2e22f1937so102256b6e.1 for <66436@debbugs.gnu.org>; Wed, 01 Nov 2023 12:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698866645; x=1699471445; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MT+IFg4AWRv1indXPxhlaNjkH1oet2eprYbXtuE6ekM=; b=nplUeaQsCzb8STk2LaB3Fdts5kZhy/qmstR7zt1nxEl0JEYUj8mS8uB3CTZHdXiZHn uU5L8NsvvUl8Ki+OT+uZRM26EDevPgRCfX5tVYXwqSage370vSqHV0CxiZ0zX4kIogCV /FjHl1OztiZnS1bQpjl4U9uDW4JXVH8X54uz+Cmh+ibqhkkJHr63qKUTx0sXvVJHp4aL kwkYRVshvUsrP+M/Ek9UQQjAEyuWDRorN244kpBDf8yPRL/UMye2umrr58J1jFkmI16o 8Fujl4ZfUREvaPQWxS4jQHPlSR1VAFrznCe2q5BiPl2451EahUgFzSSPVjFIyhrgAY4Z InuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698866645; x=1699471445; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MT+IFg4AWRv1indXPxhlaNjkH1oet2eprYbXtuE6ekM=; b=k6i21nNmaRWO3wjY40C1TvygDCdCZ++JOZ4WGku0NXyCtLbgahsUMpP8sRa5SdOTy+ xNNZPYrWPn7+hfjliH/Hdp4qkTU1KyPnDBnGA/Sz5wUTSwRJCC1U9r+YLPXQhl/GtoT6 eKEuhdOyWkxVu3oOc33RnD09nd5SyHPDMACCPkocFeZ+JmBFxuRyMUKmieYiNfyA1/AQ 0C77vts4NiYpJ0q1SzZ+LaYWsmf7+CqESxYI+3OmH3VrqmA0AYC+CzEgj9mtJUJIqkSS MEMhND1Rjv+ylMIdD5vTUYpgD9/t+1M/GCuiZxTkpjWKIxHdJkW2Llgzugb7PR2LtEQ+ Jxxg== X-Gm-Message-State: AOJu0Yzmju3M+v1MBqKTS/lurUCJxA2losUFU5cmw8/BSO8AfBx6ptR/ CBPWv3f5emsjbVGhgK9q3nXewFg1AIKGoQ== X-Google-Smtp-Source: AGHT+IECKeayhCkcCdWN4HLvLYVNpa41isQzRz650PuyKRNfPnb8sTe21MBJ2lI4DcBuDHiBo81UUA== X-Received: by 2002:a05:6808:1a02:b0:3ae:5c48:6f42 with SMTP id bk2-20020a0568081a0200b003ae5c486f42mr21875136oib.5.1698866644965; Wed, 01 Nov 2023 12:24:04 -0700 (PDT) Received: from localhost.localdomain (dsl-10-128-239.b2b2c.ca. [72.10.128.239]) by smtp.gmail.com with ESMTPSA id u29-20020a05620a085d00b00775afce4235sm1677940qku.131.2023.11.01.12.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 12:24:03 -0700 (PDT) From: Maxim Cournoyer Date: Wed, 1 Nov 2023 15:23:23 -0400 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New section. (Debbugs Usertags): Expound with Emacs Debbugs information and document the 'reviewed-looks-good' usertag. Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b --- Changes in v3: - Replace LGTM with Reviewed-by Git tag - Add b4 config - Link to the Submitting Patches section for check list - Fuse further suggestions by both Ludovic and Simon doc/contributing.texi | 111 ++++++++++++++++++++++++++++++++++++++++-- etc/git/gitconfig | 7 +++ 2 files changed, 114 insertions(+), 4 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 30876447d4..023478c98d 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -29,6 +29,7 @@ Contributing * Submitting Patches:: Share your work. * Tracking Bugs and Changes:: Keeping it all organized. * Commit Access:: Pushing to the official repository. +* Reviewing the Work of Others:: Some guidelines for sharing reviews. * Updating the Guix Package:: Updating the Guix package definition. * Writing Documentation:: Improving documentation in GNU Guix. * Translating Guix:: Make Guix speak your native language. @@ -1981,7 +1982,12 @@ Debbugs Usertags tag any bug with an arbitrary label. Bugs can be searched by usertag, so this is a handy way to organize bugs@footnote{The list of usertags is public information, and anyone can modify any user's list of usertags, -so keep that in mind if you choose to use this feature.}. +so keep that in mind if you choose to use this feature.}. If you use +Emacs Debbugs, the entry-point to consult existing usertags is the +@samp{C-u M-x debbugs-gnu-usertags} procedure. To set a usertag, press +@samp{C} while consulting a bug within the *Guix-Patches* buffer opened +with @samp{C-u M-x debbugs-gnu-bugs} buffer, then select @code{usertag} +and follow the instructions. For example, to view all the bug reports (or patches, in the case of @code{guix-patches}) tagged with the usertag @code{powerpc64le-linux} @@ -1994,9 +2000,9 @@ Debbugs Usertags to interact with Debbugs. In Guix, we are experimenting with usertags to keep track of -architecture-specific issues. To facilitate collaboration, all our -usertags are associated with the single user @code{guix}. The following -usertags currently exist for that user: +architecture-specific issues, as well as reviewed ones. To facilitate +collaboration, all our usertags are associated with the single user +@code{guix}. The following usertags currently exist for that user: @table @code @@ -2014,6 +2020,9 @@ Debbugs Usertags appropriate to assign this usertag to a bug report for a package that fails to build reproducibly. +@item reviewed-looks-good +You have reviewed the series and it looks good to you (LGTM). + @end table If you're a committer and you want to add a usertag, just start using it @@ -2283,6 +2292,100 @@ Commit Access you're welcome to use your expertise and commit rights to help other contributors, too! +@node Reviewing the Work of Others +@section Reviewing the Work of Others + +Perhaps the biggest action you can do to help GNU Guix grow as a project +is to review the work contributed by others. You do not need to be a +committer to do so; applying, reading the source, building, linting and +running other people's series and sharing your comments about your +experience will give some confidence to committers. Basically, you gmust +ensure the check list found in the @ref{Submitting Patches} section has +been correctly followed. A reviewed patch series should give the best +chances for the proposed change to be merged faster, so if a change you +would like to see merged hasn't yet been reviewed, this is the most +appropriate thing to do! + +@cindex reviewing, guidelines +Review comments should be unambiguous; be as clear and explicit as you +can about what you think should be changed, ensuring the author can take +action on it. Please try to keep the following guidelines in mind +during review: + +@enumerate +@item +@emph{Be clear and explicit about changes you are suggesting}, ensuring +the author can take action on it. In particular, it is a good idea to +explicitly ask for new revisions when you want it. + +@item +@emph{Remain focused: do not change the scope of the work being +reviewed.} For example, if the contribution touches code that follows a +pattern deemed unwieldy, it would be unfair to ask the submitter to fix +all occurrences of that pattern in the code; to put it simply, if a +problem unrelated to the patch at hand was already there, do not ask the +submitter to fix it. + +@item +@emph{Ensure progress.} As they respond to review, submitters may +submit new revisions of their changes; avoid requesting changes that you +did not request in the previous round of comments. Overall, the +submitter should get a clear sense of progress; the number of items open +for discussion should clearly decrease over time. + +@item +@emph{Aim for finalization.} Reviewing code is time-consuming. Your +goal as a reviewer is to put the process on a clear path towards +integration, possibly with agreed-upon changes, or rejection, with a +clear and mutually-understood reasoning. Avoid leaving the review +process in a lingering state with no clear way out. + +@item +@emph{Review is a discussion.} The submitter's and reviewer's views on +how to achieve a particular change may not always be aligned. To lead +the discussion, remain focused, ensure progress and aim for +finalization, spending time proportional to the stakes@footnote{The +tendency to discuss minute details at length is often referred to as +``bikeshedding'', where much time is spent discussing each one's +preference for the color of the shed at the expense of progress made on +the project to keep bikes dry.}. As a reviewer, try hard to explain the +rationale for suggestions you make, and to understand and take into +account the submitter's motivation for doing things in a certain way. +@end enumerate + +@cindex LGTM, Looks Good To Me +@cindex review tags +@cindex Reviewed-by, git trailer +When you deem the proposed change adequate and ready for inclusion +within Guix, the following well understood/codified +@samp{Reviewed-by:@tie{}Your@tie{}Name} +@footnote{The @samp{Reviewed-by} Git trailer is used by other projects +such as Linux, and is understood by third-party tools such as the +@samp{b4 am} sub-command, which is able to retrieve the complete +submission email thread from a public-inbox instance and add the Git +trailers found in replies to the commit patches.} line should be used to +sign off as a reviewer, meaning you have reviewed the change and that it +looks good to you: + +@itemize +@item +If the @emph{whole} series (containing multiple commits) looks good to +you, reply with @samp{Reviewed-by:@tie{}Your@tie{}Name} +to the cover page if it has one, or to the last patch of the series +otherwise, adding another @samp{(for the whole series)} comment on the +line below to explicit this fact. + +@item +If you instead want to mark a @emph{single commit} as reviewed (but not +the whole series), simply reply with +@samp{Reviewed-by:@tie{}Your@tie{}Name} to that +commit message. +@end itemize + +If you are not a committer, you can help others find a @emph{series} you +have reviewed more easily by adding a @code{reviewed-looks-good} usertag +for the @code{guix} user (@pxref{Debbugs Usertags}). + @node Updating the Guix Package @section Updating the Guix Package diff --git a/etc/git/gitconfig b/etc/git/gitconfig index 907ad01804..654a630b18 100644 --- a/etc/git/gitconfig +++ b/etc/git/gitconfig @@ -16,3 +16,10 @@ to = guix-patches@gnu.org headerCmd = etc/teams.scm cc-members-header-cmd thread = no + +[b4] + attestation-check-dkim = off + attestation-policy = off + linkmask = https://yhetil.org/guix/%s + linktrailermask = https://yhetil.org/guix/%s + midmask = https://yhetil.org/guix/%s base-commit: a96f1c1bc0fa186414359890025e8acacbb1de02 -- 2.41.0 From unknown Sat Sep 06 10:36:00 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66436] [PATCH v3] doc: Add some guidelines for reviewing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Nov 2023 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66436 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66436@debbugs.gnu.org, dev@jpoiret.xyz, zimon.toutoune@gmail.com Received: via spool by 66436-submit@debbugs.gnu.org id=B66436.169919594119986 (code B ref 66436); Sun, 05 Nov 2023 14:53:01 +0000 Received: (at 66436) by debbugs.gnu.org; 5 Nov 2023 14:52:21 +0000 Received: from localhost ([127.0.0.1]:36416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzeU9-0005CI-AJ for submit@debbugs.gnu.org; Sun, 05 Nov 2023 09:52:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzeU7-0005C4-9r for 66436@debbugs.gnu.org; Sun, 05 Nov 2023 09:52:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzeTQ-00054y-Jn; Sun, 05 Nov 2023 09:51:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=LWIxKQd0cmCc6MLnw8VIjZQbaiU9rCujCXzAPKkrIFU=; b=aBXQ8MG9WU5sudDGyjAX lxOk/2+kTKY5SOROUsVOVpk3E8fy/4oZslO2wNVmCGQ0Rz0aJTNNXg0KyqtxLdZO+Oi9Fd04jjVqm G7jlcqVfuLu4Tep/RSpJJP8fFkjGUbWbzC+ax8ujDUaJ467gu28Muh6oV90KX+HCuMUr43wU7v3Vd 3nj7yGUMkObyF1MVrcrE8B1XVTwMQqXgBalFCbHRBIViwj7KnSMnICGkJnkoZkL5RRjdOtCqzHydG gMFhVUa4sGy19dqiSZQl7qxlhiJEGBIqfWhKiL9o9C4JruaPYwNAbY4Yds1eYHKQFK1y3dicA0vJk ck1lqic4LMH6xA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Maxim Cournoyer's message of "Wed, 1 Nov 2023 15:23:23 -0400") References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 Brumaire an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Dindon X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 05 Nov 2023 15:51:32 +0100 Message-ID: <87fs1k1cej.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Maxim Cournoyer skribis: > * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New > section. > (Debbugs Usertags): Expound with Emacs Debbugs information and document t= he > 'reviewed-looks-good' usertag. > > Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b > --- > > Changes in v3: > - Replace LGTM with Reviewed-by Git tag > - Add b4 config > - Link to the Submitting Patches section for check list > - Fuse further suggestions by both Ludovic and Simon Could you mention the b4 change in the commit log? Otherwise LGTM! > +[b4] > + attestation-check-dkim =3D off > + attestation-policy =3D off > + linkmask =3D https://yhetil.org/guix/%s > + linktrailermask =3D https://yhetil.org/guix/%s > + midmask =3D https://yhetil.org/guix/%s Really cool to have the b4 workflow documented and a default config in place! Ludo=E2=80=99. From unknown Sat Sep 06 10:36:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Maxim Cournoyer Subject: bug#66436: closed (Re: [PATCH v3] doc: Add some guidelines for reviewing.) Message-ID: References: <87edh1k0c7.fsf@gmail.com> <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> X-Gnu-PR-Message: they-closed 66436 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 66436@debbugs.gnu.org Date: Tue, 07 Nov 2023 16:15:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1699373702-12779-1" This is a multi-part message in MIME format... ------------=_1699373702-12779-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66436: [PATCH] doc: Add some guidelines for reviewing. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66436@debbugs.gnu.org. --=20 66436: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66436 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1699373702-12779-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66436-done) by debbugs.gnu.org; 7 Nov 2023 16:14:48 +0000 Received: from localhost ([127.0.0.1]:43071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Oj1-0003JX-Hn for submit@debbugs.gnu.org; Tue, 07 Nov 2023 11:14:47 -0500 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]:51650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0Oiz-0003JI-DY for 66436-done@debbugs.gnu.org; Tue, 07 Nov 2023 11:14:46 -0500 Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-67131800219so40002776d6.3 for <66436-done@debbugs.gnu.org>; Tue, 07 Nov 2023 08:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699373642; x=1699978442; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n7WfCSnPCJJAn7+FAnytuH2RHmKjdS9O5M6gr/uFpww=; b=V2Cj/g22AiVQllEj6nBCbdGAkCrh2JQ8+seNNQOlmHj5O1wDlwJcXYCXjy/xRyMTik Z5DO0RYiCYOjT3crQ6dABlwIJbmFe9KVsTIgfAQ6o9mY2XQ/vV+hnsdNFqcej7wKq94S ZC7Wx+1PslJL3HcjO8eG/G1lu5/ANtq2CM+ZPIy8cWSi5bvI/E8bnUR+J+/M7OHyVA7N jGZD/CMrORfSFqdEk6RT3uVhPx2HQtK5NGcDOjZQIa3SJrvqsJAhX5zNQtgaIcLeeSC9 CQAKA6qbsfl0dDAaKIk4U7SQ6GphG9rR5pCInvyPGISgg/czToz4UR6f9is81zMzhebx oywg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699373642; x=1699978442; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n7WfCSnPCJJAn7+FAnytuH2RHmKjdS9O5M6gr/uFpww=; b=mNybAABlpOIkHmUCqggpO5luhpWgtaj9Uc+h2OQLbkkPQol6lH76g8gXYNWQLyfgfY lzmEO9R6mex1Hkp1uepj6Un4ib7ZwU/NVTGutEtscOsR58Na3BAwRIs8WNN0xHt/I6Wb CSbKPF0jUsjEflqVuMs4pbyNzmD0Y3oVhgd12CZLN9Xc2oC4Wy3LbnG+XU264AWOI0yD ozxuvT7qejL7q62VR5gctzKQULnCYCdB1fQ5FJVtJnsOsyJ4ZAkvhNAq53AxOTgVKED6 wl0E2dH1xcDcYMOQYNJRCXVRiF7FxJI9cqQwa79E9QQ+XoJEWGmd91YRpMOCDtt80Tc8 2s+Q== X-Gm-Message-State: AOJu0Yxi+cc/W7m3eL5SEFlMmC57o7KdHFgqMDf8KAfjsX+3d1bZ5UgR jr2UH9t1VObN9o55VZioik8= X-Google-Smtp-Source: AGHT+IGCWGY81QJrmEPxoF2f1BEFaoME9BOasqYxh8yo0pRJe0Xe03iWMr+M0a0xbJtzUoPxaKytJQ== X-Received: by 2002:a05:6214:2464:b0:65b:a66:3109 with SMTP id im4-20020a056214246400b0065b0a663109mr41025798qvb.8.1699373641786; Tue, 07 Nov 2023 08:14:01 -0800 (PST) Received: from hurd (dsl-10-130-87.b2b2c.ca. [72.10.130.87]) by smtp.gmail.com with ESMTPSA id q10-20020a0cfa0a000000b0065d05c8bb5dsm26360qvn.64.2023.11.07.08.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Nov 2023 08:14:01 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH v3] doc: Add some guidelines for reviewing. In-Reply-To: <87fs1k1cej.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 05 Nov 2023 15:51:32 +0100") References: <87fs1k1cej.fsf@gnu.org> Date: Tue, 07 Nov 2023 11:14:00 -0500 Message-ID: <87edh1k0c7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66436-done Cc: 66436-done@debbugs.gnu.org, dev@jpoiret.xyz, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: > Hello, > > Maxim Cournoyer skribis: > >> * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: N= ew >> section. >> (Debbugs Usertags): Expound with Emacs Debbugs information and document = the >> 'reviewed-looks-good' usertag. >> >> Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b >> --- >> >> Changes in v3: >> - Replace LGTM with Reviewed-by Git tag >> - Add b4 config >> - Link to the Submitting Patches section for check list >> - Fuse further suggestions by both Ludovic and Simon > > Could you mention the b4 change in the commit log? Otherwise LGTM! Done, thanks for the review. >> +[b4] >> + attestation-check-dkim =3D off >> + attestation-policy =3D off >> + linkmask =3D https://yhetil.org/guix/%s >> + linktrailermask =3D https://yhetil.org/guix/%s >> + midmask =3D https://yhetil.org/guix/%s > > Really cool to have the b4 workflow documented and a default config in > place! Now we could document more extensively some successful workflows in the Cookbook (Debbugs/Gnus-based, QA-based, b4-based, etc.) :-). --=20 Thanks, Maxim ------------=_1699373702-12779-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Oct 2023 12:55:16 +0000 Received: from localhost ([127.0.0.1]:34247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqCGY-0000Gr-OH for submit@debbugs.gnu.org; Tue, 10 Oct 2023 08:55:15 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqCGU-0000Ga-EF for submit@debbugs.gnu.org; Tue, 10 Oct 2023 08:55:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqCG3-0002yr-Hn for guix-patches@gnu.org; Tue, 10 Oct 2023 08:54:43 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqCG1-0004Zf-NF for guix-patches@gnu.org; Tue, 10 Oct 2023 08:54:43 -0400 Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-77386822cfbso379469785a.0 for ; Tue, 10 Oct 2023 05:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696942480; x=1697547280; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=G8kBbFenunZSNMWvsvKTKp+fnxuuUp9i29bT2ST8UQQ=; b=OH2xUnuNvU3F+trJBcC7M38BXxkGVq3YmV6p53LnjarTrZT3MGBxBEob2TnZ5FRRwB Lq6VGijxZmTmnCGdADzcuSjaE7ot80vmgQB/12TV2c2/7Zy1cWAXDOsyIRvNsa4x9yC6 w969ckrMPsEgd6GZFnNNxS3gvXd/jWhWqLpLpfgBT34KCriiv2s6oKKYjA1DAzlDOFJJ mIzq1GnqvDaWj5IiNpDAhD2fo1GocM2ounM9vDGALczyUYW0Np073kBBH38lHvX+VMFr bh2/zTph0cQaTS5+gpSvtjhm4h5UxWkg9ynxi0AaORMvVNQwU+NDyegALdvrf32bGXOt Lt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696942480; x=1697547280; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G8kBbFenunZSNMWvsvKTKp+fnxuuUp9i29bT2ST8UQQ=; b=bZij2d7vDjf9TeiubijNFhfVkq80ipelHOv70E0Pjydu66QViBZhKbhhW0iSChBtv/ oCpX+mtS879dx57sR9zkNrg6p4GpG48UinXBoyJHvut63c+gmf6hg8/HytVKb4BoPTDA 2Nwr4F0MZHi8fdkcJTdaJeGL9a4oMhJi8g023Adk2iuibxQFMj05pwDsAI9YnFsw5G+a UmT4KikWtnJ0i41Z94GmYY0rQRGz9aVV0rvGnAw1sV1+va/gqbT2h0c4RrA8nw4IhVtB 6bJlSKEqw8SsTAgMT9RadWgTFjnAB2KFRTdhkXvKO8PIvbZWUX8VfHC9wBvbm5LplzAn NxhA== X-Gm-Message-State: AOJu0Yy5izQ8bH6Wlawu6jh7pLAieKxRJ4tf/sy8LgfDKhwzC0B+6dR8 ZI+iuynR0osADMIRREvtIy/SWu02nt+65A== X-Google-Smtp-Source: AGHT+IG3UtpGFBBsTc/bl4NKKkYzedVNl5OuQ1aCLkiS7ki1VMz7szPGkuKZ1qX2jE6UjucaBpaD6Q== X-Received: by 2002:a05:620a:4106:b0:774:2a7f:fa24 with SMTP id j6-20020a05620a410600b007742a7ffa24mr23197905qko.25.1696942480103; Tue, 10 Oct 2023 05:54:40 -0700 (PDT) Received: from localhost.localdomain (dsl-10-149-16.b2b2c.ca. [72.10.149.16]) by smtp.gmail.com with ESMTPSA id w19-20020a05620a149300b0076eee688a95sm4315688qkj.0.2023.10.10.05.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 05:54:39 -0700 (PDT) From: Maxim Cournoyer To: guix-patches@gnu.org, maxim.cournoyer@gmail.com Subject: [PATCH] doc: Add some guidelines for reviewing. Date: Tue, 10 Oct 2023 08:54:27 -0400 Message-ID: <19f82d9bbef649c750ad067d23ebbaee6f9ae494.1696942467.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x733.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * doc/contributing.texi (Contributing) [Reviewing the Work of Others]: New section. * doc/contributing.texi (Debbugs Usertags): Expound with Emacs Debbugs information and document the 'reviewed-looks-good' usertag. Change-Id: I56630b15ec4fbc5c67e5420dbf2838556a005d6b --- doc/contributing.texi | 53 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 864190b119..b09e9cc299 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -29,6 +29,7 @@ Contributing * Submitting Patches:: Share your work. * Tracking Bugs and Changes:: Keeping it all organized. * Commit Access:: Pushing to the official repository. +* Reviewing the Work of Others:: Some guidelines for sharing reviews. * Updating the Guix Package:: Updating the Guix package definition. * Writing Documentation:: Improving documentation in GNU Guix. * Translating Guix:: Make Guix speak your native language. @@ -605,7 +606,7 @@ Packaging Guidelines * Version Numbers:: When the name is not enough. * Synopses and Descriptions:: Helping users find the right package. * Snippets versus Phases:: Whether to use a snippet, or a build phase. -* Cyclic Module Dependencies:: Going full circle. +* Cyclic Module Dependencies:: Going full circle. * Emacs Packages:: Your Elisp fix. * Python Modules:: A touch of British comedy. * Perl Modules:: Little pearls. @@ -1972,7 +1973,12 @@ Debbugs Usertags tag any bug with an arbitrary label. Bugs can be searched by usertag, so this is a handy way to organize bugs@footnote{The list of usertags is public information, and anyone can modify any user's list of usertags, -so keep that in mind if you choose to use this feature.}. +so keep that in mind if you choose to use this feature.}. If you use +Emacs Debbugs, the entry-point to consult existing usertags is the +@samp{C-u M-x debbugs-gnu-usertags} procedure. To set a usertag, press +@samp{C} while consulting a bug within the *Guix-Patches* buffer opened +with @samp{C-u M-x debbugs-gnu-bugs} buffer, then select @code{usertag} +and follow the instructions. For example, to view all the bug reports (or patches, in the case of @code{guix-patches}) tagged with the usertag @code{powerpc64le-linux} @@ -1985,9 +1991,9 @@ Debbugs Usertags to interact with Debbugs. In Guix, we are experimenting with usertags to keep track of -architecture-specific issues. To facilitate collaboration, all our -usertags are associated with the single user @code{guix}. The following -usertags currently exist for that user: +architecture-specific issues, as well as reviewed ones. To facilitate +collaboration, all our usertags are associated with the single user +@code{guix}. The following usertags currently exist for that user: @table @code @@ -2005,6 +2011,9 @@ Debbugs Usertags appropriate to assign this usertag to a bug report for a package that fails to build reproducibly. +@item reviewed-looks-good +You have reviewed the series and it looks good to you (LGTM). + @end table If you're a committer and you want to add a usertag, just start using it @@ -2237,6 +2246,40 @@ Commit Access you're welcome to use your expertise and commit rights to help other contributors, too! +@node Reviewing the Work of Others +@section Reviewing the Work of Others + +Perhaps the biggest action you can do to help GNU Guix grow as a project +is to review the work contributed by others. You do not need to be a +committer to do so; applying, building, linting and running other +people's series and sharing your comments about your experience will +give some confidence to committers that should result in the proposed +change being merged faster. + +@cindex LGTM, Looks Good To Me +@cindex reviewing, guidelines +Review comments should be unambiguous; be as clear and explicit as you +can about what you think should be changed, ensuring the author can take +action on it. The following well understood/codified @acronym{LGTM, +Looks Good To Me} phrases should be used to sign off as a reviewer, +meaning you have reviewed the change and that it looks good to you: + +@enumerate +@item +If the @emph{whole} series (containing multiple commits) looks good to +you, reply with a @samp{This series LGTM!} to the cover page if it has +one, or to the last patch of the series otherwise. + +@item +If you instead want to mark a @emph{single commit} as reviewed (but not +the whole series), simply reply with @samp{LGTM!} to that commit +message. +@end enumerate + +If you are not a committer, you can help others find a @emph{series} you +have reviewed more easily by adding a @code{reviewed-looks-good} usertag +for the @code{guix} user (@pxref{Debbugs Usertags}). + @node Updating the Guix Package @section Updating the Guix Package base-commit: 619ff2fa1d5b60b5fe33216ca2d6219c04a5515b -- 2.41.0 ------------=_1699373702-12779-1--