GNU bug report logs - #66431
[PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: nvp <noah.v.peart <at> gmail.com>
Subject: bug#66431: closed (Re: bug#66431: [PATCH] Fix reset
 treesit--explorer-last-node when explorer buffer was killed)
Date: Sun, 22 Oct 2023 03:37:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 66431 <at> debbugs.gnu.org.

-- 
66431: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66431
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: nvp <noah.v.peart <at> gmail.com>
Cc: 66431-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#66431: [PATCH] Fix reset treesit--explorer-last-node when
 explorer buffer was killed
Date: Sat, 21 Oct 2023 20:35:48 -0700

> On Oct 21, 2023, at 5:40 PM, nvp <noah.v.peart <at> gmail.com> wrote:
> 
> Ok that makes sense, thanks for clearing that up for me, your fix looks good. I'm loving this package!

Thanks, I pushed the fix to emacs-29. I’m glad you are finding it useful!

Yuan

[Message part 3 (message/rfc822, inline)]

From: nvp <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer
 was killed
Date: Mon, 9 Oct 2023 23:02:48 -0700

[Message part 4 (text/plain, inline)]

Tags: patch


Bug: After `treesit-explorer-mode` is enabled in a buffer and its
associated `treesit--explorer-buffer` is killed, a subsequent call
to `treesit-explorer-mode` initially displays an empty explorer
buffer b/c `treesit--explorer-refresh` sees old value for
`treesit--explorer-last-node`.

* lisp/treesit.el (treesit-explorer-mode): reset
`treesit--explorer-last-node` when `treesit--explorer-buffer` was killed

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD
Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 5 (text/html, inline)]

[fix-treesit-explorer-last-node.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.