GNU bug report logs - #66431
[PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed

Previous Next

Package: emacs;

Reported by: nvp <noah.v.peart <at> gmail.com>

Date: Tue, 10 Oct 2023 06:04:02 UTC

Severity: normal

Tags: patch

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: nvp <noah.v.peart <at> gmail.com>, 66431 <at> debbugs.gnu.org
Subject: bug#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed
Date: Sat, 14 Oct 2023 10:08:41 -0700

> On Oct 14, 2023, at 1:17 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: nvp <noah.v.peart <at> gmail.com>
>> Date: Mon, 9 Oct 2023 23:02:48 -0700
>> 
>> Tags: patch
>> 
>> Bug: After `treesit-explorer-mode` is enabled in a buffer and its
>> associated `treesit--explorer-buffer` is killed, a subsequent call
>> to `treesit-explorer-mode` initially displays an empty explorer
>> buffer b/c `treesit--explorer-refresh` sees old value for
>> `treesit--explorer-last-node`.
>> 
>> * lisp/treesit.el (treesit-explorer-mode): reset
>> `treesit--explorer-last-node` when `treesit--explorer-buffer` was killed
>> 
>> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
>> 3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD
>> Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e
>> Repository branch: master
>> Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
>> System Description: Ubuntu 22.04.3 LTS
> 
> Yuan, could you please look into this?  Is the patch OK to go in, and
> if so, should it be installed on emacs-29?

I’ll look at it, thanks for the reminder.

Yuan





This bug report was last modified 1 year and 291 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.