GNU bug report logs - #66424
[PATCH core-updates] gnu: libxkbcommon: Fix cross-compile.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66424: closed ([PATCH core-updates] gnu: libxkbcommon: Fix
 cross-compile.)
Date: Mon, 16 Oct 2023 02:30:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 16 Oct 2023 02:28:13 +0000
with message-id <874jirb8sv.fsf <at> protonmail.com>
and subject line Re: bug#66424: [PATCH core-updates] gnu: libxkbcommon: Fix cross-compile.
has caused the debbugs.gnu.org bug report #66424,
regarding [PATCH core-updates] gnu: libxkbcommon: Fix cross-compile.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66424: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66424
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libxkbcommon: Fix cross-compile.
Date: Mon,  9 Oct 2023 23:07:42 +0800

* gnu/packages/xdisorg.scm (libxkbcommon): Fix cross-compile.
[native-inputs]: When cross-compile add PKG-CONFIG-FOR-BUILD.
---
 gnu/packages/xdisorg.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index db948a9318..84bdcad031 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -527,9 +527,13 @@ (define-public libxkbcommon
            wayland-protocols
            xkeyboard-config))
     (native-inputs
-     (list bison doxygen pkg-config python
-           ;; wayland-scanner is required at build time.
-           wayland))
+     (append
+      (if (%current-target-system)
+          (list pkg-config-for-build)
+          '())
+      (list bison doxygen pkg-config python
+            ;; wayland-scanner is required at build time.
+            wayland)))
     (arguments
      (list #:configure-flags
            #~(list (string-append "-Dxkb-config-root="

base-commit: 9b77bd0b9b4f3de69390da0ba7db5b9dbc01e554
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: zhengjunjie <at> iscas.ac.cn
Cc: Marius Bakke <marius <at> gnu.org>, Efraim Flashner <efraim <at> flashner.co.il>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 66424-done <at> debbugs.gnu.org
Subject: Re: bug#66424: [PATCH core-updates] gnu: libxkbcommon: Fix
 cross-compile.
Date: Mon, 16 Oct 2023 02:28:13 +0000

Hi all,

cc'ing Efraim too, since...

On Sun, Oct 15, 2023 at 01:30 AM, zhengjunjie <at> iscas.ac.cn wrote:

>> 在 2023年10月13日，22:50，Maxim Cournoyer <maxim.cournoyer <at> gmail.com> 写道：
>>
>>
>> On the top of my head, I thought pkg-config-for-build had been obsolete
>> by the pkg-config symbol being dynamically bound to something that makes
>> sense for the context it's used in, via some macro trickery.  I may have
>> misunderstood things
>
> For cross build,
>
> pkg-config -> xxxx-pkg-config
> pkg-config-for-build -> pkg-config
>
> libxkbcommon require wayland-scanner to generate c file, this is why
> need pkg-config-for-build, pkg-config is require by find library. Is
> different ,so libxkbcommon need both on cross build.

looks like the same change was made on master in
bc1634a197dc9ab7aa0dead8c7449bb5db09cea6. Along with other commits
then to do the same thing to other similar packages.

So, I'm closing as I believe this is done but figured I'd loop in
Efraim in case there was anything else on this matter to discuss.

Thanks all!
John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.