From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 22:56:09 2023 Received: (at submit) by debbugs.gnu.org; 8 Oct 2023 02:56:09 +0000 Received: from localhost ([127.0.0.1]:56083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpJxh-0000xT-0D for submit@debbugs.gnu.org; Sat, 07 Oct 2023 22:56:09 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpJxf-0000x5-AQ for submit@debbugs.gnu.org; Sat, 07 Oct 2023 22:56:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpJxG-00064a-3n for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 22:55:42 -0400 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpJxE-00072a-DP for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 22:55:41 -0400 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1e5bc692721so405594fac.0 for ; Sat, 07 Oct 2023 19:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696733738; x=1697338538; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=sermD5+O8iWwTwwQCc83vplxPSRFmTb7Y9GAnWuhYr8=; b=V7rHoM+WysZUxBHRSScztrg5Tx8JgMtzINgS21SVVzLJgvkGaBUBYAe449UjhJR5gT EVmvg0KRqHi2nzo+8Oh5QfbUMAmY1N9wicS/4WnxaFvo/+AqKVBDNagBa6YkBIRASaD2 FWTI5uAWovGvnl9p/0lkgjsdN08nb+KonTCIgXAgZLWOzfBvh7wE1r3mNjmdXlXjctIr N8DNkYXPGs1Kj/8r0ce/Unpyw2tI1hKd9A/U/qzgvodl9VFcIlHvY7OCRogYCP0EfK2i NaNDH+2RIKAau3E9Y+KYdrkbNp4uZn106dFXgYUNu5pz03sXMfAhVo5inZd9MAUhedoY s61g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696733738; x=1697338538; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sermD5+O8iWwTwwQCc83vplxPSRFmTb7Y9GAnWuhYr8=; b=JFLLZS69WeGVIVC19m+GzxebVFM87g4GOFP9f1Npmk0ElGSnQNDGTguyXYFPNwQSm+ XVyLJYWEQ9Rs2f9v6OGnay/ovYBHMs7f+QszFAYFotE+bvwtaJMJBASrdq38BxLmXUvz uXJdL/zgJYXf1WN5QH+awFkRWZhqzOznyQFqk4P390y2jGeP2L0zEy6S5x9Zd9cJwCAa rpMh1VWje9wzebu2cw1BWIfhvw9q77kv16+37QVezqKUzlu5kBkiFDY8lgTmGdY7p/CB UPwSLuqzHEPSt99+tA+Wu0v7iFQdYEq/7Msq/7afeokA3uZziiM91dOzwOahhsA7Yxjl quGg== X-Gm-Message-State: AOJu0YxC/01mOsG9YcBaGYCqxUdjf79wkKLV5RmM83nctoM2M+WRF8RB d4/A6r0BhTtLtII+O/kxd4fcOfqHJ40nXf1KqgWFOcjnOPLYTvt9 X-Google-Smtp-Source: AGHT+IGJUREgHoOt9Xy+xVcE478/yQbmZ39rAfiW3sWqzg4bOHF+jtj/GVsKe3mM6GcMhnHPrBeWJd/hcQ7NQm7YdXo= X-Received: by 2002:a05:6870:164f:b0:1ba:6180:ff47 with SMTP id c15-20020a056870164f00b001ba6180ff47mr13634836oae.21.1696733738535; Sat, 07 Oct 2023 19:55:38 -0700 (PDT) MIME-Version: 1.0 From: nvp Date: Sat, 7 Oct 2023 19:55:27 -0700 Message-ID: Subject: [PATCH] Fix 'treesit-query-validate' To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000c3f7a206072b9b75" Received-SPF: pass client-ip=2001:4860:4864:20::36; envelope-from=noah.v.peart@gmail.com; helo=mail-oa1-x36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000c3f7a206072b9b75 Content-Type: multipart/alternative; boundary="000000000000c3f7a006072b9b73" --000000000000c3f7a006072b9b73 Content-Type: text/plain; charset="UTF-8" Tags: patch Bug: when calling `treesit-query-validate` interactively, the query is expanded with `treesit-query-expand`, despite being a string. This produces unreadable output in the error message buffer. * lisp/treesit.el (treesit-query-validate): Only expand sexp queries before insertion into query error buffer. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Ubuntu 22.04.3 LTS Configured using: 'configure --prefix=/usr/local --with-modules --with-tree-sitter --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls --with-json --with-mailutils --with-jpeg --with-png --with-rsvg --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12 CXX=gcc-12' --000000000000c3f7a006072b9b73 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Tags: patch

Bug: when calling `treesit-query-valida= te` interactively,
the query is expanded with `treesit-query-expand`, de= spite being a
string. This produces unreadable output in the error messa= ge buffer.

* lisp/treesit.el (treesit-query-validate): Only expand s= exp queries
before insertion into query error buffer.

In GNU Emac= s 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo ver= sion 1.16.0) of 2023-10-05 built on noah-X580VD
Repository revision: 505= c80623049d9e181918acdac8229c9a2041b1e
Repository branch: master
Windo= wing system distributor 'The X.Org Foundation', version 11.0.121010= 04
System Description: Ubuntu 22.04.3 LTS

Configured using:
= =C2=A0'configure --prefix=3D/usr/local --with-modules --with-tree-sitte= r
--with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with= -tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
CXX=3Dgcc-12= '
--000000000000c3f7a006072b9b73-- --000000000000c3f7a206072b9b75 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-fix-dont-expand-string-query-in-treesit-query-valida.patch" Content-Disposition: attachment; filename="0001-fix-dont-expand-string-query-in-treesit-query-valida.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lngvfhl90 RnJvbSAyNTgzYTM3YWYxYWE0YjMzNjQ5Yjc0Y2U1ZjE0OGNkODUyMWRlNWI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBudmVybm8gPG5vYWgudi5wZWFydEBnbWFpbC5jb20+CkRhdGU6 IFNhdCwgNyBPY3QgMjAyMyAxOTozNjo0NCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGZpeDogZG9u dCBleHBhbmQgc3RyaW5nIHF1ZXJ5IGluIHRyZWVzaXQtcXVlcnktdmFsaWRhdGUKCi0tLQogbGlz cC90cmVlc2l0LmVsIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90cmVlc2l0LmVsIGIvbGlzcC90cmVlc2l0LmVs CmluZGV4IDQwMjQxN2M2Y2E5Li4wNDhjZGQ0ZTU5NCAxMDA2NDQKLS0tIGEvbGlzcC90cmVlc2l0 LmVsCisrKyBiL2xpc3AvdHJlZXNpdC5lbApAQCAtMjg4OSw3ICsyODg5LDcgQEAgdHJlZXNpdC1x dWVyeS12YWxpZGF0ZQogICAgICAgICAgICAgICAgICAgKHN0YXJ0IChudGggMSBkYXRhKSkKICAg ICAgICAgICAgICAgICAgIChpbmhpYml0LXJlYWQtb25seSB0KSkKICAgICAgICAgICAgICAoZXJh c2UtYnVmZmVyKQotICAgICAgICAgICAgIChpbnNlcnQgKHRyZWVzaXQtcXVlcnktZXhwYW5kIHF1 ZXJ5KSkKKyAgICAgICAgICAgICAoaW5zZXJ0IChpZiAoc3RyaW5ncCBxdWVyeSkgcXVlcnkgKHRy ZWVzaXQtcXVlcnktZXhwYW5kIHF1ZXJ5KSkpCiAgICAgICAgICAgICAgKGdvdG8tY2hhciBzdGFy dCkKICAgICAgICAgICAgICAoc2VhcmNoLWZvcndhcmQgIiAiIG5pbCB0KQogICAgICAgICAgICAg IChwdXQtdGV4dC1wcm9wZXJ0eSBzdGFydCAocG9pbnQpICdmYWNlICdlcnJvcikKLS0gCjIuMzQu MQoK --000000000000c3f7a206072b9b75-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 19:00:37 2023 Received: (at 66400) by debbugs.gnu.org; 8 Oct 2023 23:00:37 +0000 Received: from localhost ([127.0.0.1]:58857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpclJ-0002Kc-96 for submit@debbugs.gnu.org; Sun, 08 Oct 2023 19:00:37 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:49596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpclG-0002KL-04 for 66400@debbugs.gnu.org; Sun, 08 Oct 2023 19:00:35 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-692b2bdfce9so3558744b3a.3 for <66400@debbugs.gnu.org>; Sun, 08 Oct 2023 16:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696806007; x=1697410807; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MwL1nextUSpHyIoY++tRjRr5S2NYe/ffqWZapIGywRs=; b=OmyoxzaYthhxXfJb6hb/bZE+GjXS1liDGE82ET63MrwHjmt5nQMwvldIB+ZEIK++aX 3WWLycHW/40MyD+qYLDAbGZ0K3wxPwHZBEict7s7/gVQhPams8md5A7AuPTiTcQZ9b04 x4IdX9wDWaHFdS4wsPOdx6NJzEF6QmCElaYNjr2PzxhGDgSEg2lJxGkD6J1PDt8Er3FA y8Z8yWwe/lsOmi+esxXm6uGnW1xy1OSC2IxcQQ35HO3JQdDZWLQZQYMrj/bfVhg+X7ta 1D4Dj5mfURnb5Gs5Ip9dAb67RoTQaeGdp1WmDy3+Lce3i9Ehh7MV6PUTi/tw8UAMrWA6 +0BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696806007; x=1697410807; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MwL1nextUSpHyIoY++tRjRr5S2NYe/ffqWZapIGywRs=; b=Z6e22EnsMaGNQ8cNAfPrVcwHIVqUanSXOD7pzDBGbht3YOFQDE7dPnbUJOZ+ixzhIW UGbQXACY6/Gi/FkdubHo6yV2ufe41iUGUr/7MuI6k7ug7J5LsK8jl6/wOXEoiLWdLwVJ 3GgqUVbDitr7JlF8VNta8Rr232vSVuK6uG2PlbPZPpGnHvxfta8HoM5tAww0MdJ+C128 VizAZx3KuUtrC8vhcYzK8m4iTSU8SdmmUoODZ9g7SQmQYFAQhXP04AcKapFs+HFfoJYC xbivKUwUZYESyHKRROWFxXwNl5pDspNxEs2v4tkYhXIWFWwJw2J8kEyFD4xfYKq1R0G0 m/og== X-Gm-Message-State: AOJu0YwVnig1salmd1vWQ6H1vL9LrwuUJv312YFCPXT6B4HnG8M2AdT4 y/rM8IftuSTXhc3hL3v3v6Y= X-Google-Smtp-Source: AGHT+IHGOuCUvKY/cCQYwCWSh14LZWHNfb5+Udur/dVuf6hqkld1jnNNlCJmQ76cMKKVLp1H5S+0Wg== X-Received: by 2002:a05:6a00:2e90:b0:690:3b59:cc7a with SMTP id fd16-20020a056a002e9000b006903b59cc7amr18625042pfb.23.1696806007174; Sun, 08 Oct 2023 16:00:07 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 4-20020aa79104000000b0069305627491sm4970280pfh.159.2023.10.08.16.00.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 16:00:06 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate' From: Yuan Fu In-Reply-To: Date: Sun, 8 Oct 2023 15:59:55 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: nvp X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66400 Cc: 66400@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 7, 2023, at 7:55 PM, nvp wrote: >=20 > Tags: patch >=20 > Bug: when calling `treesit-query-validate` interactively, > the query is expanded with `treesit-query-expand`, despite being a > string. This produces unreadable output in the error message buffer. >=20 > * lisp/treesit.el (treesit-query-validate): Only expand sexp queries > before insertion into query error buffer. Thank you very much! May I ask whether you have signed the copyright = assignment? Though for this patch, the assignment isn=E2=80=99t needed, = since it changes 2 lines, well within the 15 lines limit for the exempt. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 20:35:53 2023 Received: (at 66400) by debbugs.gnu.org; 9 Oct 2023 00:35:53 +0000 Received: from localhost ([127.0.0.1]:58891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpeFV-0005WT-0B for submit@debbugs.gnu.org; Sun, 08 Oct 2023 20:35:53 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:61672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpeFS-0005WB-MP for 66400@debbugs.gnu.org; Sun, 08 Oct 2023 20:35:51 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1bdf4752c3cso23130115ad.2 for <66400@debbugs.gnu.org>; Sun, 08 Oct 2023 17:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696811724; x=1697416524; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/SJYyjkHhd/oiwrXcwxBJthViOmeY9gJv/iLc7FHFzY=; b=RAWyFWwxEdVnW3ERqW+B+h/kwfy7A2z+TUdVwctrH9Xz8AjUBENWVG1qB7pW+5BtmX r4+JCwyYgvO5DvE8XFa+MatTczI76XEnYk8wtv3U6ImtRSs1t4omhA9ZQBZMZY2SB2De 8nnnPdx+zdpkjLDbXCIGQ/WOFYfy8P6f2iW+lLshVrHafVrqchE/OnmPGBdxd7XoVyuy PQNDEIUQyWWt7Oj/pIG1E4rJ1xPw8sinm8WEd4mGcnrx3rD21WSRTUdyZil1od/buQmi uMDZbZT1xyg7LEKgq7LeKLGhDugpLW7Ye7LQ7fivRIEp8IBHC+hHViZB/eTAc4XMILSM bvHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696811724; x=1697416524; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/SJYyjkHhd/oiwrXcwxBJthViOmeY9gJv/iLc7FHFzY=; b=fLOy2pxPYIygRxGomnuCtvO6oL56BoEvAXH1h5oIBkyKHen2l3UtDsl0pCoNKva0u4 0UTr/Flln0WW2guyGymmbOscWguu1vAOA4dnKReTuTB7+gTnk7ycpPfkYAtz9O7dPInd c3iXX12tAaNHc5VcA74CGqVchQvXX4gdKEbH9aesCRDdjlZ+4mx2mx5fg2Ir/Vd6oPXM ERLFoEQBHc8OEQcma4DyoePdg271p5kMsQrJA9Wxdt1eEJZ2B8VdLlh9cZsQwmywjr6t PzN9Ar224Mz6DEvBzC+MI00VsDVKIrt5rE3LVi11NRuu+2qDPNysRLoSfigqCfU54HIJ FXEw== X-Gm-Message-State: AOJu0Yz/yWlZfhltAufXwRla6XGpzt3pDYoH3GghWOVDjQqIE7nsOdIZ MYSsauxYMd52zNxr8DLgpD8= X-Google-Smtp-Source: AGHT+IERH69RIyKlDqDSg5MvGk0FMgqrlwZP2UwCRA35fAvaZV0A+x7J5SROgyRUDTeQy/9pPA0DXg== X-Received: by 2002:a17:902:dacd:b0:1c0:c174:3695 with SMTP id q13-20020a170902dacd00b001c0c1743695mr13470218plx.13.1696811724475; Sun, 08 Oct 2023 17:35:24 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id y13-20020a170902ed4d00b001c898328289sm4384689plb.158.2023.10.08.17.35.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 17:35:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate' From: Yuan Fu In-Reply-To: Date: Sun, 8 Oct 2023 17:35:12 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <26DD773A-01BA-4186-AB9B-0F4AF3471345@gmail.com> References: To: nvp X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66400 Cc: Eli Zaretskii , 66400@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) (Adding emacs-debbugs to CC) > On Oct 8, 2023, at 5:22 PM, nvp wrote: >=20 > Hi Yuan, > I believe I have, through contributions to ESS in the past. Is there = somewhere I can check? > Thankyou Great! Eli can check it for you. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 08 22:36:09 2023 Received: (at 66400) by debbugs.gnu.org; 9 Oct 2023 02:36:09 +0000 Received: from localhost ([127.0.0.1]:58942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpg7s-00013n-PY for submit@debbugs.gnu.org; Sun, 08 Oct 2023 22:36:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpg7q-00013Y-PW for 66400@debbugs.gnu.org; Sun, 08 Oct 2023 22:36:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpg7Q-0006Gz-UZ; Sun, 08 Oct 2023 22:35:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=UUiQYT79s1AV3bQFgsAoVLJj/JHO46EaXmypp3aili4=; b=V3A6/tfNQOxFypwJguUv zIFUY1vxwHkSOeLbxS2ro9qM1EEzRe9c/Bww6d9JTHUGHaxLBhq9PXhipoodXfkZWePOL/tlhfhQb heTgHI5L6g60+zAJOG04oSNuETWpEXe8BWtTfNY33fx08EEz+4pCYCSSeWrpOeNMPPj78LjvGKXUr uPz7elmw3tylEZk7zkX6WPGs1rk3mFYyOtv8qyrilbMGdbm/2jiVtyjhT1yPUAwjNZSeTnyJsmcPk Y9s6ZkQAFe5SpsH3M6S+cyR08BSptCvRIlW9KvauJiD9zJb/8AMuQ8k3cZzPpaZ1sVGgwDRpb9Q2q Dr4EQli4jUg75g==; Date: Mon, 09 Oct 2023 05:35:27 +0300 Message-Id: <83wmvwwmj4.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Sun, 8 Oct 2023 15:59:55 -0700) Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate' References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66400 Cc: noah.v.peart@gmail.com, 66400@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 66400@debbugs.gnu.org > From: Yuan Fu > Date: Sun, 8 Oct 2023 15:59:55 -0700 > > > * lisp/treesit.el (treesit-query-validate): Only expand sexp queries > > before insertion into query error buffer. > > Thank you very much! May I ask whether you have signed the copyright assignment? Though for this patch, the assignment isn’t needed, since it changes 2 lines, well within the 15 lines limit for the exempt. Noah's assignment is on file. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 00:24:43 2023 Received: (at 66400) by debbugs.gnu.org; 9 Oct 2023 04:24:43 +0000 Received: from localhost ([127.0.0.1]:59010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qphox-0004l9-EB for submit@debbugs.gnu.org; Mon, 09 Oct 2023 00:24:43 -0400 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]:52340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qphov-0004ku-KC for 66400@debbugs.gnu.org; Mon, 09 Oct 2023 00:24:42 -0400 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-1dcdfeb7e44so2934466fac.0 for <66400@debbugs.gnu.org>; Sun, 08 Oct 2023 21:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696825455; x=1697430255; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VMTKXE+ojKZCQ+CSv9JS0qlAjFOTykv8+iL7cUcfe0M=; b=GzM7WTU152SziF5oj1dgXOWiPwk459EGPdJRmGqPZKDqphVcKF4YtsXY+V0iNqdJSE CXakrvEtSfOviQcQe1QLn7LdiWTHcYUfK1Y4LnaxSDD+S8HYmpCguUqOFhcFqOMsQEmR Y9ge6elR4jEJvt4TLBbbz8AE56MBaBbB29w+1dOJvUkJPTWBH/8dl3PdtBXkmijRH0H9 vqjb6WZ/kt7hgacW0be8G/8chJnFOx5aiN8+8Ceqd55FPjFxwDawkFOX02sz6bLdTvcA /pUNPORyQ2z3htyeLbu2qBOARayQKEofvo5JN0b/ESFYw7I+6ZEE4qjraYaxnyc24SRv inOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696825455; x=1697430255; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VMTKXE+ojKZCQ+CSv9JS0qlAjFOTykv8+iL7cUcfe0M=; b=CoHYrFtxx2O9udj5fQLT0WpeaXto8peBsGs+aOedPZaa6G0OlchcFOCI5mD+Z/GicO cPNyXVtez+AeAKazSumeg0APN2IiQsnXRpfefZ9Xk4KNRjb4Fd0W4fwUHeMWsUd8pb8G SvvhGT4ekR59jZouIHPZJsPsdEapQu6gn3hvskuKNCvhODx6fqS7b3Dg64QlYy+SZImj TeLpT0AcifXYUZB26t5pzcFazHFcEhrflBVExZKjNNUfAZU5OTsWBqyajB1+ytjLXqgY fk7MU0+upeiDTmIXs4rnkskwf9ASqKNAO0Ac98VrIGnFsPy/AXJdBnWVEhl8qtvKwdOz 5mAA== X-Gm-Message-State: AOJu0Ywl5xqGM0VdwOj/kheIYjBvoGQaht/MwncbJ2zJQnfcS++8vgBo k5vvq/rPjMxzW7oF0e/bxntI15Ggr7wUC5xT20w= X-Google-Smtp-Source: AGHT+IEDuk/WxcS6/rFK/o11TrZZdOJPrxZjC9BgkIfTZKubsAzIjfx3/8HWA3cxR4oFNpKdiDuskKBNaaxefK2SYkM= X-Received: by 2002:a05:6870:b691:b0:1d7:876:c825 with SMTP id cy17-20020a056870b69100b001d70876c825mr16529258oab.48.1696825455253; Sun, 08 Oct 2023 21:24:15 -0700 (PDT) MIME-Version: 1.0 References: <83wmvwwmj4.fsf@gnu.org> In-Reply-To: <83wmvwwmj4.fsf@gnu.org> From: nvp Date: Sun, 8 Oct 2023 21:24:04 -0700 Message-ID: Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate' To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000819e4e060740f687" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66400 Cc: Yuan Fu , 66400@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000819e4e060740f687 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thankyou both! On Sun, Oct 8, 2023 at 7:35=E2=80=AFPM Eli Zaretskii wrote: > > Cc: 66400@debbugs.gnu.org > > From: Yuan Fu > > Date: Sun, 8 Oct 2023 15:59:55 -0700 > > > > > * lisp/treesit.el (treesit-query-validate): Only expand sexp queries > > > before insertion into query error buffer. > > > > Thank you very much! May I ask whether you have signed the copyright > assignment? Though for this patch, the assignment isn=E2=80=99t needed, s= ince it > changes 2 lines, well within the 15 lines limit for the exempt. > > Noah's assignment is on file. > --000000000000819e4e060740f687 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thankyou both!

On Sun, Oct 8, 2023 at 7:35=E2=80=AFPM Eli Z= aretskii <eliz@gnu.org> wrote:
> Cc: 66400@debbugs.gnu.org
> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 8 Oct 2023 15:59:55 -0700
>
> > * lisp/treesit.el (treesit-query-validate): Only expand sexp quer= ies
> > before insertion into query error buffer.
>
> Thank you very much! May I ask whether you have signed the copyright a= ssignment? Though for this patch, the assignment isn=E2=80=99t needed, sinc= e it changes 2 lines, well within the 15 lines limit for the exempt.

Noah's assignment is on file.
--000000000000819e4e060740f687-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 01:05:43 2023 Received: (at 66400-done) by debbugs.gnu.org; 9 Oct 2023 05:05:43 +0000 Received: from localhost ([127.0.0.1]:59037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpiSd-0006El-DU for submit@debbugs.gnu.org; Mon, 09 Oct 2023 01:05:43 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:54478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpiSb-0006EU-9H for 66400-done@debbugs.gnu.org; Mon, 09 Oct 2023 01:05:41 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-690f7d73a3aso3723100b3a.0 for <66400-done@debbugs.gnu.org>; Sun, 08 Oct 2023 22:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696827915; x=1697432715; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UMrEM0LsUrISgWZ8yOS9UzRmKKF0B3ko2BYwZyrh6co=; b=dpiJ0idpHO0iFi5kKKBfeL06rp1Rb8gKvUtgNpw2j3MQ1mJM+Pijlun7vaxyUsDyPP bCPaKNPubc4PXBrPp2tgJfn9ubf5aXsR5PnaXwKwVmYp1YhHyrnQdfeWWwD3bP6r3fXZ 3any6BvL2kygHVNf5/4fndkBdzwkdKbJT9urGXGy+h+Pi5fSi1qkLkK10ik+sEQlFVgy yycJOqe8eliEk9yVLfRPH+ibznim/nTZOI9VAzTOQc8pYbsVprtR1hgqkynSkXDtj84j xZPArngwCoMS5NekzzKHRDcDs2AKj1EM7kCyTxeJAzr4XlLpEgHMcQ2xwkdZfd21EWP3 wNvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696827915; x=1697432715; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UMrEM0LsUrISgWZ8yOS9UzRmKKF0B3ko2BYwZyrh6co=; b=A9wHAulHwC0wQhEzCVB+AdkHd/xmD8b3xY85cKC3eyWd6DfZrO24Viw7LOWNKMwIAL BWIDQGWuvQ4z+dO7MGtfO36o2NH/R2j62G8ejXtZC/JLcPg5Ka3z6Xekc4pzXHUOLPr/ 1i8o744wWGSOpWXMLpVm3XrV1P5nmhgpgNnWbKI83Iw0bOIR2JlbE/ZtgOmP1FIcVOd/ 6SRlc3GLPfjLmAjPR95ESyCW/S8Kdpl+zF4O15n+Ky+P0BM1PEk6AUGhEo67OiQMeitr 6RN9umWCa0u1EUVJvqiohWX6CMq/LCu+csDUGEmJJxfW+dnpBrPANWZML2qd3Vor/ukj 09Lw== X-Gm-Message-State: AOJu0YztiiL3Vbeh3hfKxoopnNI8PMiX8dtiaaLoYPpIS0ajQGpEnp/c mmMGk0N3a8roXrGFGqaq7Jg= X-Google-Smtp-Source: AGHT+IFLEfeygBYZbv9h8rcfoWOmls0SG5E8ccrugPXPIYTwdSydCWT57Paw4IMghioXbAQIQINdCA== X-Received: by 2002:a05:6a00:c87:b0:68a:6d1a:b812 with SMTP id a7-20020a056a000c8700b0068a6d1ab812mr18135725pfv.9.1696827914999; Sun, 08 Oct 2023 22:05:14 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id d13-20020aa7814d000000b00690cd981652sm5367981pfn.61.2023.10.08.22.05.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 22:05:14 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate' From: Yuan Fu In-Reply-To: Date: Sun, 8 Oct 2023 22:05:04 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83wmvwwmj4.fsf@gnu.org> To: nvp X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66400-done Cc: 66400-done@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 8, 2023, at 9:24 PM, nvp wrote: >=20 > Thankyou both! >=20 > On Sun, Oct 8, 2023 at 7:35=E2=80=AFPM Eli Zaretskii = wrote: > > Cc: 66400@debbugs.gnu.org > > From: Yuan Fu > > Date: Sun, 8 Oct 2023 15:59:55 -0700 > >=20 > > > * lisp/treesit.el (treesit-query-validate): Only expand sexp = queries > > > before insertion into query error buffer. > >=20 > > Thank you very much! May I ask whether you have signed the copyright = assignment? Though for this patch, the assignment isn=E2=80=99t needed, = since it changes 2 lines, well within the 15 lines limit for the exempt. >=20 > Noah's assignment is on file. Merged, thank you! Yuan= From unknown Sat Sep 20 12:59:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Nov 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator