GNU bug report logs - #66400
[PATCH] Fix 'treesit-query-validate'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66400 in the body.
You can then email your comments to 66400 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: nvp <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix 'treesit-query-validate'
Date: Sat, 7 Oct 2023 19:55:27 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

Bug: when calling `treesit-query-validate` interactively,
the query is expanded with `treesit-query-expand`, despite being a
string. This produces unreadable output in the error message buffer.

* lisp/treesit.el (treesit-query-validate): Only expand sexp queries
before insertion into query error buffer.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD
Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 2 (text/html, inline)]

[0001-fix-dont-expand-string-query-in-treesit-query-valida.patch (text/x-patch, attachment)]

Message #8 received at 66400 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: nvp <noah.v.peart <at> gmail.com>
Cc: 66400 <at> debbugs.gnu.org
Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate'
Date: Sun, 8 Oct 2023 15:59:55 -0700

> On Oct 7, 2023, at 7:55 PM, nvp <noah.v.peart <at> gmail.com> wrote:
> 
> Tags: patch
> 
> Bug: when calling `treesit-query-validate` interactively,
> the query is expanded with `treesit-query-expand`, despite being a
> string. This produces unreadable output in the error message buffer.
> 
> * lisp/treesit.el (treesit-query-validate): Only expand sexp queries
> before insertion into query error buffer.

Thank you very much! May I ask whether you have signed the copyright assignment? Though for this patch, the assignment isn’t needed, since it changes 2 lines, well within the 15 lines limit for the exempt.

Yuan

Message #11 received at 66400 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: nvp <noah.v.peart <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 66400 <at> debbugs.gnu.org
Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate'
Date: Sun, 8 Oct 2023 17:35:12 -0700

(Adding emacs-debbugs to CC)

> On Oct 8, 2023, at 5:22 PM, nvp <noah.v.peart <at> gmail.com> wrote:
> 
> Hi Yuan,
> I believe I have, through contributions to ESS in the past.  Is there somewhere I can check?
> Thankyou

Great! Eli can check it for you.

Yuan

Message #14 received at 66400 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: noah.v.peart <at> gmail.com, 66400 <at> debbugs.gnu.org
Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate'
Date: Mon, 09 Oct 2023 05:35:27 +0300

> Cc: 66400 <at> debbugs.gnu.org
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sun, 8 Oct 2023 15:59:55 -0700
> 
> > * lisp/treesit.el (treesit-query-validate): Only expand sexp queries
> > before insertion into query error buffer.
> 
> Thank you very much! May I ask whether you have signed the copyright assignment? Though for this patch, the assignment isn’t needed, since it changes 2 lines, well within the 15 lines limit for the exempt.

Noah's assignment is on file.

Message #17 received at 66400 <at> debbugs.gnu.org (full text, mbox):

From: nvp <noah.v.peart <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Yuan Fu <casouri <at> gmail.com>, 66400 <at> debbugs.gnu.org
Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate'
Date: Sun, 8 Oct 2023 21:24:04 -0700

[Message part 1 (text/plain, inline)]

Thankyou both!

On Sun, Oct 8, 2023 at 7:35 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: 66400 <at> debbugs.gnu.org
> > From: Yuan Fu <casouri <at> gmail.com>
> > Date: Sun, 8 Oct 2023 15:59:55 -0700
> >
> > > * lisp/treesit.el (treesit-query-validate): Only expand sexp queries
> > > before insertion into query error buffer.
> >
> > Thank you very much! May I ask whether you have signed the copyright
> assignment? Though for this patch, the assignment isn’t needed, since it
> changes 2 lines, well within the 15 lines limit for the exempt.
>
> Noah's assignment is on file.
>

[Message part 2 (text/html, inline)]

Message #22 received at 66400-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: nvp <noah.v.peart <at> gmail.com>
Cc: 66400-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#66400: [PATCH] Fix 'treesit-query-validate'
Date: Sun, 8 Oct 2023 22:05:04 -0700

> On Oct 8, 2023, at 9:24 PM, nvp <noah.v.peart <at> gmail.com> wrote:
> 
> Thankyou both!
> 
> On Sun, Oct 8, 2023 at 7:35 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > Cc: 66400 <at> debbugs.gnu.org
> > From: Yuan Fu <casouri <at> gmail.com>
> > Date: Sun, 8 Oct 2023 15:59:55 -0700
> > 
> > > * lisp/treesit.el (treesit-query-validate): Only expand sexp queries
> > > before insertion into query error buffer.
> > 
> > Thank you very much! May I ask whether you have signed the copyright assignment? Though for this patch, the assignment isn’t needed, since it changes 2 lines, well within the 15 lines limit for the exempt.
> 
> Noah's assignment is on file.

Merged, thank you!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.