GNU bug report logs - #66394
29.1; Make register-read-with-preview more useful

Previous Next

Full log

Message #363 received at 66394 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Thierry Volpiatto <thievol <at> posteo.net>
Cc: michael_heerdegen <at> web.de, dmitry <at> gutov.dev, 66394 <at> debbugs.gnu.org,
 monnier <at> iro.umontreal.ca, stefankangas <at> gmail.com
Subject: Re: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Thu, 21 Dec 2023 13:47:51 +0200

> From: Thierry Volpiatto <thievol <at> posteo.net>
> Cc: monnier <at> iro.umontreal.ca,  stefankangas <at> gmail.com,  dmitry <at> gutov.dev,
>   michael_heerdegen <at> web.de,  66394 <at> debbugs.gnu.org
> Date: Wed, 20 Dec 2023 17:23:14 +0000
> 
> >   . I suggest to rename all the "*basic" symbols to "*traditional"
> >     instead (including such words in some doc strings)
> 
> Ok, done.  Have a look though to verify if docstring is correct.
> 
> >   . I think we need to update the NEWS entry, and in particular
> >     describe there the two different "styles" of entering the register
> >     names and the preview modes
> 
> I would prefer you do this, it will be better written.
> 
> > (I'm okay with doing these minor changes myself, once you install the
> > changes.)
> 
> Ok, now merged, Thanks.

Thanks, I have a question:

The doc string of register-use-preview says:

  This has no effect when the value of `register--read-with-preview-function'
  is `register-read-with-preview-traditional'.

However, customizing register-use-preview to the value 'traditional
has the exact effect of setting register--read-with-preview-function
to register-read-with-preview-traditional.  OTOH, when
register-use-preview is set to 'traditional, one can set it to a
different value, and then the behavior will change.  So I wonder what
that sentence is about and what I missed?  Is that perhaps a leftover
from previous versions, and should now be deleted?

I updated the documentation and NEWS.  I'd appreciate if you could
spare a few minutes to review the changes and point out any
inaccuracies or mistakes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.