GNU bug report logs - #66394
29.1; Make register-read-with-preview more useful

Previous Next

Full log

Message #246 received at 66394 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: michael_heerdegen <at> web.de, Eli Zaretskii <eliz <at> gnu.org>,
 stefankangas <at> gmail.com, monnier <at> iro.umontreal.ca, 66394 <at> debbugs.gnu.org
Subject: Re: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Tue, 12 Dec 2023 09:31:19 +0000

[Message part 1 (text/plain, inline)]

Thierry Volpiatto <thievol <at> posteo.net> writes:

> Dmitry Gutov <dmitry <at> gutov.dev> writes:
>
>> On 11/12/2023 19:32, Thierry Volpiatto wrote:
>>> I made a little error in one of the patch when merging from a working
>>> file for emacs-29.1, attaching here the two patches again with error
>>> corrected (read `register-use-preview` instead of
>>> `register-preview-use-preview`), sorry for this.
>>
>> JFYI, the second patch doesn't apply cleanly, which may make testing
>> them a bit more difficult.
>>
>> It's because of commit 598ab9ca10d35d6 by Eli with documentation
>> updates. When reverted, the second patch applies without problem.
>
> Dmitry thanks, here the patches again after rebasing.

I found another (merge) error in patch 0001 with defmethod names (read
register-command-info instead of register-preview-command-info), here
the patches corrected.  Without this changes, and with
register-use-preview == nil, confirmation is needed for copy-to-register
and friends, now fixed.

-- 
Thierry

[0001-Don-t-confirm-with-RET-even-when-overwriting-in-regi.patch (text/x-diff, attachment)]

[0002-Provide-emacs-29-behavior-for-register-preview.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.