From unknown Mon Aug 18 22:13:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66393: [PATCH] Make package-vc-install-from-checkout NAME argument optional Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: philipk@posteo.net, bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 66393@debbugs.gnu.org Cc: Philip Kaludercic (Emacs) X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Philip Kaludercic (Emacs) Received: via spool by submit@debbugs.gnu.org id=B.16967041608361 (code B ref -1); Sat, 07 Oct 2023 18:43:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Oct 2023 18:42:40 +0000 Received: from localhost ([127.0.0.1]:55908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpCG8-0002An-Fp for submit@debbugs.gnu.org; Sat, 07 Oct 2023 14:42:40 -0400 Received: from lists.gnu.org ([2001:470:142::17]:50114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpCG6-0002AW-86 for submit@debbugs.gnu.org; Sat, 07 Oct 2023 14:42:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpCFh-00044O-2g for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 14:42:13 -0400 Received: from out-205.mta0.migadu.com ([91.218.175.205]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpCFe-0004AT-1H for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 14:42:12 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1696704119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=uW01TJ+S6nZ55uJfX/Kupu3KGYiF5RegHM8f8PepJ8A=; b=igxzCwTdXqKxZePAHt5dMMd/sLrmUxyc7lykh1/S16/neWw7mUQ+mgKjkvRwM7cp0I/aH6 YJp6+FQVqOxQ3ozRQNY1jAKr4VLbEkfKBz0EgV63EYw7ZoRTHX7Xtq//K300vjgUgQazKU hum1dS/y95eLnVq86Dg+HoslLguQ86E= From: Joseph Turner Date: Sat, 07 Oct 2023 11:40:44 -0700 Message-ID: <87o7haw9zj.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.205; envelope-from=joseph@breatheoutbreathe.in; helo=out-205.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch The purpose of this change is to simplify the noninteractive usage of package-vc-install-from-checkout. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-package-vc-install-from-checkout-NAME-argument-.patch >From cfdd990c6e00decff370e5f224d60862c13be309 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Sat, 7 Oct 2023 11:38:43 -0700 Subject: [PATCH] Make package-vc-install-from-checkout NAME argument optional * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): Allow nil NAME; update documentation. --- lisp/emacs-lisp/package-vc.el | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index c7a30736e32..e47deca6d7a 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -841,18 +841,16 @@ for the last released version of the package." (find-file directory))) ;;;###autoload -(defun package-vc-install-from-checkout (dir name) +(defun package-vc-install-from-checkout (dir &optional name) "Set up the package NAME in DIR by linking it into the ELPA directory. +NAME defaults to the base name of DIR. Interactively, prompt the user for DIR, which should be a directory under version control, typically one created by `package-vc-checkout'. If invoked interactively with a prefix argument, prompt the user -for the NAME of the package to set up. Otherwise infer the package -name from the base name of DIR." +for the NAME of the package to set up." (interactive (let ((dir (read-directory-name "Directory: "))) - (list dir - (if current-prefix-arg - (read-string "Package name: ") - (file-name-base (directory-file-name dir)))))) + (list dir (when current-prefix-arg + (read-string "Package name: "))))) (unless (vc-responsible-backend dir) (user-error "Directory %S is not under version control" dir)) (package-vc--archives-initialize) -- 2.41.0 --=-=-=-- From unknown Mon Aug 18 22:13:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66393: [PATCH] Make package-vc-install-from-checkout NAME argument optional Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Joseph Turner Cc: 66393@debbugs.gnu.org Received: via spool by 66393-submit@debbugs.gnu.org id=B66393.169677984818501 (code B ref 66393); Sun, 08 Oct 2023 15:45:02 +0000 Received: (at 66393) by debbugs.gnu.org; 8 Oct 2023 15:44:08 +0000 Received: from localhost ([127.0.0.1]:58265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpVwt-0004oK-OM for submit@debbugs.gnu.org; Sun, 08 Oct 2023 11:44:08 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpVwr-0004ne-4z for 66393@debbugs.gnu.org; Sun, 08 Oct 2023 11:44:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 10AF0240027 for <66393@debbugs.gnu.org>; Sun, 8 Oct 2023 17:43:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1696779819; bh=5s59eYv+rzay5ihNLZciKtVizpesjqYnYk2aOYgVVbk=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=rG6hJlb2xFcDIuL7Tbivez/r00SCqwxlgwz9R5UK6+xQMHztfaJP9YzgPHqGhVwXK OyqAP6AAtwHA45oZ8UfO+yuG5iHHDeczhJbhOsnTDZhCf2SjN5gTIkd3i+zckjCVK0 mxksEmX2rRqJw0GvvdkQadFSel1sl7/h8ZqVwZ1vG9MGOwYLU9JWStkykurFafvRTF PgsvPLErBz4+mqgCnqPbbbLLXdaP0lbNikuRpEkNV01X4rtrypkBI4cy78QivqWCkD sQbk6yuw18PU4tEDuqJQjsIIq49p20zhvNLBU2DalOM4yso36q9a4DfdLGFQiXUGXh ao82gGSDWfM/g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4S3RK62fdDz9rxF; Sun, 8 Oct 2023 17:43:38 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <87o7haw9zj.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 07 Oct 2023 11:40:44 -0700") References: <87o7haw9zj.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 08 Oct 2023 15:43:37 +0000 Message-ID: <87o7h9ktli.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Turner writes: > Tags: patch > > The purpose of this change is to simplify the noninteractive usage of package-vc-install-from-checkout. > > From cfdd990c6e00decff370e5f224d60862c13be309 Mon Sep 17 00:00:00 2001 > From: Joseph Turner > Date: Sat, 7 Oct 2023 11:38:43 -0700 > Subject: [PATCH] Make package-vc-install-from-checkout NAME argument optional > > * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): > Allow nil NAME; update documentation. > --- > lisp/emacs-lisp/package-vc.el | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index c7a30736e32..e47deca6d7a 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -841,18 +841,16 @@ for the last released version of the package." > (find-file directory))) > > ;;;###autoload > -(defun package-vc-install-from-checkout (dir name) > +(defun package-vc-install-from-checkout (dir &optional name) > "Set up the package NAME in DIR by linking it into the ELPA directory. > +NAME defaults to the base name of DIR. > Interactively, prompt the user for DIR, which should be a directory > under version control, typically one created by `package-vc-checkout'. > If invoked interactively with a prefix argument, prompt the user > -for the NAME of the package to set up. Otherwise infer the package > -name from the base name of DIR." > +for the NAME of the package to set up." > (interactive (let ((dir (read-directory-name "Directory: "))) > - (list dir > - (if current-prefix-arg > - (read-string "Package name: ") > - (file-name-base (directory-file-name dir)))))) > + (list dir (when current-prefix-arg This looks fine, I'm just going to replace the `when' with a `and', ok? > + (read-string "Package name: "))))) > (unless (vc-responsible-backend dir) > (user-error "Directory %S is not under version control" dir)) > (package-vc--archives-initialize) From unknown Mon Aug 18 22:13:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66393: [PATCH] Make package-vc-install-from-checkout NAME argument optional Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 66393@debbugs.gnu.org Received: via spool by 66393-submit@debbugs.gnu.org id=B66393.169679828114031 (code B ref 66393); Sun, 08 Oct 2023 20:52:02 +0000 Received: (at 66393) by debbugs.gnu.org; 8 Oct 2023 20:51:21 +0000 Received: from localhost ([127.0.0.1]:58752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpakC-0003eF-In for submit@debbugs.gnu.org; Sun, 08 Oct 2023 16:51:20 -0400 Received: from out-198.mta0.migadu.com ([91.218.175.198]:44780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpak9-0003e4-Hv for 66393@debbugs.gnu.org; Sun, 08 Oct 2023 16:51:19 -0400 References: <87o7haw9zj.fsf@breatheoutbreathe.in> <87o7h9ktli.fsf@posteo.net> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1696798255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mjZIe9zOMPrh60/0eEQ12IphI8gD7R1j/AwcbHcWd4s=; b=fxY+vo9WMnG1+LB4KrdE4pvTjm9ggiuDkxy6kox8bXr2Rbxwq6MImjQO6QybSz+yM+eDq/ PS0u0Xc0WCimtuM/on97kr1SO251Il32iz2pAOjXG1752gXr1BsBbuOLTF1H4OJxLm473i HM2/O6IRVSi5exoyz9ADCT9rIkQCvIE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Joseph Turner Date: Sun, 08 Oct 2023 13:50:40 -0700 In-reply-to: <87o7h9ktli.fsf@posteo.net> Message-ID: <87a5ssu9ck.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > Joseph Turner writes: > >> Tags: patch >> >> The purpose of this change is to simplify the noninteractive usage of package-vc-install-from-checkout. >> >> From cfdd990c6e00decff370e5f224d60862c13be309 Mon Sep 17 00:00:00 2001 >> From: Joseph Turner >> Date: Sat, 7 Oct 2023 11:38:43 -0700 >> Subject: [PATCH] Make package-vc-install-from-checkout NAME argument optional >> >> * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): >> Allow nil NAME; update documentation. >> --- >> lisp/emacs-lisp/package-vc.el | 12 +++++------- >> 1 file changed, 5 insertions(+), 7 deletions(-) >> >> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> index c7a30736e32..e47deca6d7a 100644 >> --- a/lisp/emacs-lisp/package-vc.el >> +++ b/lisp/emacs-lisp/package-vc.el >> @@ -841,18 +841,16 @@ for the last released version of the package." >> (find-file directory))) >> >> ;;;###autoload >> -(defun package-vc-install-from-checkout (dir name) >> +(defun package-vc-install-from-checkout (dir &optional name) >> "Set up the package NAME in DIR by linking it into the ELPA directory. >> +NAME defaults to the base name of DIR. >> Interactively, prompt the user for DIR, which should be a directory >> under version control, typically one created by `package-vc-checkout'. >> If invoked interactively with a prefix argument, prompt the user >> -for the NAME of the package to set up. Otherwise infer the package >> -name from the base name of DIR." >> +for the NAME of the package to set up." >> (interactive (let ((dir (read-directory-name "Directory: "))) >> - (list dir >> - (if current-prefix-arg >> - (read-string "Package name: ") >> - (file-name-base (directory-file-name dir)))))) >> + (list dir (when current-prefix-arg > > This looks fine, I'm just going to replace the `when' with a `and', ok? Sure! >> + (read-string "Package name: "))))) >> (unless (vc-responsible-backend dir) >> (user-error "Directory %S is not under version control" dir)) >> (package-vc--archives-initialize) From unknown Mon Aug 18 22:13:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Joseph Turner Subject: bug#66393: closed (Re: bug#66393: [PATCH] Make package-vc-install-from-checkout NAME argument optional) Message-ID: References: <87jzrwlrvt.fsf@posteo.net> <87o7haw9zj.fsf@breatheoutbreathe.in> X-Gnu-PR-Message: they-closed 66393 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 66393@debbugs.gnu.org Date: Sun, 08 Oct 2023 21:36:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1696800962-19983-1" This is a multi-part message in MIME format... ------------=_1696800962-19983-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66393: [PATCH] Make package-vc-install-from-checkout NAME argument optional which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66393@debbugs.gnu.org. --=20 66393: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66393 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1696800962-19983-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66393-done) by debbugs.gnu.org; 8 Oct 2023 21:35:48 +0000 Received: from localhost ([127.0.0.1]:58802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpbRE-0005BX-AP for submit@debbugs.gnu.org; Sun, 08 Oct 2023 17:35:48 -0400 Received: from mout01.posteo.de ([185.67.36.65]:36263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpbRC-0005BI-K1 for 66393-done@debbugs.gnu.org; Sun, 08 Oct 2023 17:35:47 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2A0D3240028 for <66393-done@debbugs.gnu.org>; Sun, 8 Oct 2023 23:35:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1696800920; bh=I+XZhg6cqICkaFwJ5eNLPNC85UPTbETc6BYjTnq67oE=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=OrXFTNO5oYMTEPvQLP4rrjIFJnpholhZbFG80Qss7V1pyh5JewLCmm7lNNZ1Ci3v2 bzgxOeRjlzfs0kZ0D1Y0fg0Rh37QvLi+lY2gEZFj3hVFg4CcBLsnFU3wOUUpymHlf3 Ug4S0XqjXCx3FkLQ1Ga8yX4seLbnvXqnUzgq/eO1WKwqglB+oqnZrJYQwErM+QaEk9 iOmQGOqTbedQcB3NkhcvGDAht7usvfvqTSg7MAlmAQi7DTC5nJWRNi3AgNgAQWii3M 8gB6gGAepzsXJmX7YwrsHubvK4SmMJ7TRmefwU69oTLEU0o72wKTXsKYijd28sm8dU Jv/vvvw8Z8FKw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4S3b6v3wh9z9rxF; Sun, 8 Oct 2023 23:35:19 +0200 (CEST) From: Philip Kaludercic To: Joseph Turner Subject: Re: bug#66393: [PATCH] Make package-vc-install-from-checkout NAME argument optional In-Reply-To: <87o7haw9zj.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 07 Oct 2023 11:40:44 -0700") References: <87o7haw9zj.fsf@breatheoutbreathe.in> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 08 Oct 2023 21:35:18 +0000 Message-ID: <87jzrwlrvt.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66393-done Cc: 66393-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Joseph Turner writes: > Tags: patch > > The purpose of this change is to simplify the noninteractive usage of > package-vc-install-from-checkout. Thanks, pushed with slight modifications. ------------=_1696800962-19983-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Oct 2023 18:42:40 +0000 Received: from localhost ([127.0.0.1]:55908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpCG8-0002An-Fp for submit@debbugs.gnu.org; Sat, 07 Oct 2023 14:42:40 -0400 Received: from lists.gnu.org ([2001:470:142::17]:50114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpCG6-0002AW-86 for submit@debbugs.gnu.org; Sat, 07 Oct 2023 14:42:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpCFh-00044O-2g for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 14:42:13 -0400 Received: from out-205.mta0.migadu.com ([91.218.175.205]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpCFe-0004AT-1H for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 14:42:12 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1696704119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=uW01TJ+S6nZ55uJfX/Kupu3KGYiF5RegHM8f8PepJ8A=; b=igxzCwTdXqKxZePAHt5dMMd/sLrmUxyc7lykh1/S16/neWw7mUQ+mgKjkvRwM7cp0I/aH6 YJp6+FQVqOxQ3ozRQNY1jAKr4VLbEkfKBz0EgV63EYw7ZoRTHX7Xtq//K300vjgUgQazKU hum1dS/y95eLnVq86Dg+HoslLguQ86E= From: Joseph Turner To: bug-gnu-emacs@gnu.org Subject: [PATCH] Make package-vc-install-from-checkout NAME argument optional Date: Sat, 07 Oct 2023 11:40:44 -0700 X-Debbugs-CC: Philip Kaludercic (Emacs) Message-ID: <87o7haw9zj.fsf@breatheoutbreathe.in> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.205; envelope-from=joseph@breatheoutbreathe.in; helo=out-205.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch The purpose of this change is to simplify the noninteractive usage of package-vc-install-from-checkout. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-package-vc-install-from-checkout-NAME-argument-.patch >From cfdd990c6e00decff370e5f224d60862c13be309 Mon Sep 17 00:00:00 2001 From: Joseph Turner Date: Sat, 7 Oct 2023 11:38:43 -0700 Subject: [PATCH] Make package-vc-install-from-checkout NAME argument optional * lisp/emacs-lisp/package-vc.el (package-vc-install-from-checkout): Allow nil NAME; update documentation. --- lisp/emacs-lisp/package-vc.el | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index c7a30736e32..e47deca6d7a 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -841,18 +841,16 @@ for the last released version of the package." (find-file directory))) ;;;###autoload -(defun package-vc-install-from-checkout (dir name) +(defun package-vc-install-from-checkout (dir &optional name) "Set up the package NAME in DIR by linking it into the ELPA directory. +NAME defaults to the base name of DIR. Interactively, prompt the user for DIR, which should be a directory under version control, typically one created by `package-vc-checkout'. If invoked interactively with a prefix argument, prompt the user -for the NAME of the package to set up. Otherwise infer the package -name from the base name of DIR." +for the NAME of the package to set up." (interactive (let ((dir (read-directory-name "Directory: "))) - (list dir - (if current-prefix-arg - (read-string "Package name: ") - (file-name-base (directory-file-name dir)))))) + (list dir (when current-prefix-arg + (read-string "Package name: "))))) (unless (vc-responsible-backend dir) (user-error "Directory %S is not under version control" dir)) (package-vc--archives-initialize) -- 2.41.0 --=-=-=-- ------------=_1696800962-19983-1--