From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 05:24:31 2023 Received: (at submit) by debbugs.gnu.org; 7 Oct 2023 09:24:31 +0000 Received: from localhost ([127.0.0.1]:53317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp3Xy-0007Ft-Jv for submit@debbugs.gnu.org; Sat, 07 Oct 2023 05:24:30 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp3Xw-0007Fg-Gl for submit@debbugs.gnu.org; Sat, 07 Oct 2023 05:24:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp3XX-0006cd-DW for bug-guix@gnu.org; Sat, 07 Oct 2023 05:24:03 -0400 Received: from sender3-of-o57.zoho.com ([136.143.184.57]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp3XT-0006qJ-9l for bug-guix@gnu.org; Sat, 07 Oct 2023 05:24:03 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1696670635; cv=none; d=zohomail.com; s=zohoarc; b=OUng1MGmwIO8VW2ZY/OXotjDhJR4SEyttn2N1CZNaOBuNEdx1f4lZib4oRLS9sthu7Gm9d4vNHJh8g0hOFmzLD3THvVBcnVlkJEfrQw2y+rjblgyCi/0TnCj9k8NJwpS7kxo/ZqzN6/mBqoROd4uTLqkzWeKiOmgmiUVLv6o3ns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696670635; h=Content-Type:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=seZclOt8jxglt1Q3uxshSXTVJv/S8Lz+/9pm8Qgdl9I=; b=a0qDk7eK2PzENaZNXSjKLWjHtgW64MznBHhJymrjfaHScSQyCYEus5N4HEHDXeDnPop0IsutPK5KJkAQAlN6ttc6DNhhjO8rxHgDwsqJtSsucwW/CdebfFpnlzIiWB5o14eG/TP9/QzlpQ2o7NzdhiyjyUHWwHusNNRiDR/7mm0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1696670635; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=seZclOt8jxglt1Q3uxshSXTVJv/S8Lz+/9pm8Qgdl9I=; b=T3aZPcAekG641YNpYERFCdCrk9rcX3J99B5Bo9qbQoBHxVkkvRJ0ceu99Ge9Yx/x VZRWPmhvuT8tP4gk8JcTnJnG9nGpcWB/Kpq34ntu4LM6q4+qaK8ng6mJb2mwtxcllrO jp1s0lTujtTAK/AfUZoGhdL6yj54qiG2c9P6sRWE= Received: from localhost (i5E862CB7.versanet.de [94.134.44.183]) by mx.zohomail.com with SMTPS id 1696670633929453.6706333912148; Sat, 7 Oct 2023 02:23:53 -0700 (PDT) User-agent: mu4e 1.10.7; emacs 29.1 From: Ricardo Wurmus To: bug-guix@gnu.org Subject: [cuirass] /search/latest/archive fails Date: Sat, 07 Oct 2023 11:20:15 +0200 X-debbugs-cc: ludo@gnu.org, othacehe@gnu.org Message-ID: <87cyxqokew.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.57; envelope-from=rekado@elephly.net; helo=sender3-of-o57.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, I noticed that queries like this now consistently fail: https://ci.guix.gnu.org/search/latest/archive?query=spec%3Atarball+status%3Asuccess+system%3Ax86_64-linux+guix-binary.tar.xz This should redirect to a download URL. I went through the code and found that the problem lies in the return value of HANDLE-BUILDS-SEARCH-REQUEST, which does not include the ID field for BUILDPRODUCTS: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> ,use (cuirass database) scheme@(guile-user)> ,m (cuirass http) scheme@(cuirass http)> (define query (uri-decode "spec%3Atarball+status%3Asuccess+system%3Ax86_64-linux+guix-binary.tar.xz")) scheme@(cuirass http)> (vector->list (handle-builds-search-request `((query . ,query) (nr . 1) (order . finish-time+build-id)))) 2023-10-07T11:15:58 builds search request took 0.256186 seconds $1 = (((id . 2190078) (evaluation . "827027") (jobset . "tarball") (job . "binary-tarball.x86_64-linux") (timestamp . 1696611284) (starttime . 1696611211) (stoptime . 1696611284) (derivation . "/gnu/store/icam3qbpkjhsgrglx4wsy53bsrznqvs3-guix-binary.tar.xz.drv") (buildoutputs ("out" ("path" . "/gnu/store/0yb96ks4fa6781817ala5w706f945zq4-guix-binary.tar.xz"))) (system . "x86_64-linux") (nixname . "guix-binary.tar.xz") (buildstatus . 0) (weather . -1) (busy . 0) (priority . 9) (finished . 1) (buildproducts . #(((type . "archive") (path . "/gnu/store/0yb96ks4fa6781817ala5w706f945zq4-guix-binary.tar.xz") (file-size . 108105168)))))) scheme@(cuirass http)> (define build (car $1) ) scheme@(cuirass http)> (assoc-ref build 'id) $2 = 2190078 scheme@(cuirass http)> (define products (vector->list (assoc-ref build 'buildproducts))) scheme@(cuirass http)> products $3 = (((type . "archive") (path . "/gnu/store/0yb96ks4fa6781817ala5w706f945zq4-guix-binary.tar.xz") (file-size . 108105168))) scheme@(cuirass http)> (define product-type "archive") scheme@(cuirass http)> (find (lambda (product) (string=? (assoc-ref product 'type) product-type)) products) $4 = ((type . "archive") (path . "/gnu/store/0yb96ks4fa6781817ala5w706f945zq4-guix-binary.tar.xz") (file-size . 108105168)) scheme@(cuirass http)> (define product $4) scheme@(cuirass http)> (assoc-ref product 'id) $5 = #f --8<---------------cut here---------------end--------------->8--- Without the ID of the build product cuirass cannot build the download URL. -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 07 06:54:25 2023 Received: (at 66384) by debbugs.gnu.org; 7 Oct 2023 10:54:25 +0000 Received: from localhost ([127.0.0.1]:53455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4wy-0001V4-Mw for submit@debbugs.gnu.org; Sat, 07 Oct 2023 06:54:24 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4wv-0001Uu-LI for 66384@debbugs.gnu.org; Sat, 07 Oct 2023 06:54:23 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1696676038; cv=none; d=zohomail.com; s=zohoarc; b=QRunRsAqk59KRhQKYZvrWYAsV0/a5W3YGcWrW7SuxIisY1YJahMHWU/YU/xTXzgoN4/s23Ri/tSVcBLonJ/oWOZTO7ZfGNacw+05imYTMMvbyQggkdm7udIQbR+RvQUmuuUYbrNy8P/+CHerPZlNS6OvOX7AKfX30aN0NiHz+wA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696676038; h=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Q392uvo/HgWhpKRQvdYUsOyxG7mqlawk8FiizUVdk+Q=; b=X+hYmAT4KhLw5UKeGL6FF/OKDZei0iF+ukjDzt2NuVbjfTwQi8lSUeybUxyOUb4t7fbJt4bNjRLtsT+7X+/hr8ARG2V3GoR2CRWksv/NIDbFPB/8SzyiUtFkAoPWZ3JsvbmDyR/e+XkkyjSyTaABI1y+ZtFBR7NanwWujX+nxGs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1696676038; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=Q392uvo/HgWhpKRQvdYUsOyxG7mqlawk8FiizUVdk+Q=; b=e4uZWn1sIzZGPZUjjQvGuxS1BjmZHQH5/O0taLsfDBSXjtwhFXdEUZwXFScdFUtu tnmQsOTP6JofilrvwhZ4a55PNhSNnSKbbxqjNwdjTJ12h1LlZu8lkV520thM+nI2YSd fc9HXLN5S5REC3eAzbDvECsw8o+nOIGnbqOiNkDk= Received: from localhost (i5E862CB7.versanet.de [94.134.44.183]) by mx.zohomail.com with SMTPS id 1696676036969341.4867938337072; Sat, 7 Oct 2023 03:53:56 -0700 (PDT) References: <87cyxqokew.fsf@elephly.net> User-agent: mu4e 1.10.7; emacs 29.1 From: Ricardo Wurmus To: 66384@debbugs.gnu.org Subject: Re: [cuirass] /search/latest/archive fails Date: Sat, 07 Oct 2023 12:51:53 +0200 In-reply-to: <87cyxqokew.fsf@elephly.net> Message-ID: <878r8eog8u.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66384 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a consequence of commit 9b227abd29b15e7e25c54a71c524e7b26252a270, and it should be enough to fix it like this: --8<---------------cut here---------------start------------->8--- diff --git a/src/cuirass/http.scm b/src/cuirass/http.scm index 7e4fd3b..9c4c723 100644 --- a/src/cuirass/http.scm +++ b/src/cuirass/http.scm @@ -133,7 +133,8 @@ (finished . ,(bool->int finished?)) (buildproducts . ,(list->vector (map (lambda (product) - `((type . ,(build-product-type product)) + `((id . ,(build-product-id product)) + (type . ,(build-product-type product)) (path . ,(build-product-file product)) (file-size . ,(build-product-file-size product)))) (build-products build)))))) --8<---------------cut here---------------end--------------->8--- -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 09 15:34:32 2023 Received: (at 66384-done) by debbugs.gnu.org; 9 Oct 2023 19:34:32 +0000 Received: from localhost ([127.0.0.1]:33213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpw1Q-00017u-Fs for submit@debbugs.gnu.org; Mon, 09 Oct 2023 15:34:32 -0400 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpw1L-00017e-5C for 66384-done@debbugs.gnu.org; Mon, 09 Oct 2023 15:34:31 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1696880043; cv=none; d=zohomail.com; s=zohoarc; b=SSYFZD5lNC3wI6DLtw+HfImePn72kp+L3C1TnHa4zwJOcNEVzKdN0NR+FW7VooSX8ZKLiAcb1TiSHnmrBkrC5AuohHmpOViNB0iC4cPQv7a+GehBx7B3H/vit95nXsKtfz4HeWdKkW42ZWofcH6C85ck3Cu8RSZEmJFTPXmIfAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696880043; h=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=9l05pj8ejXtA58zYxRvpiYJx8zv5IzOqV8nC4zsFJi0=; b=jw2SnetVk32WulU3QQnfNF1TWJOaE7WefemnLE1EQwZZFBAzsoM0IqQPUPI5IyHea9atc7gUEoHkhulwJJQlSKKgPj9HfyejEuNbZ7eARFBbAkW+3V2uIX1aNSz2r7VWZKT+Fwx+dZn9PkHfCTMjlxix2fKUAlY7/k3+fR2sxBk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1696880043; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=9l05pj8ejXtA58zYxRvpiYJx8zv5IzOqV8nC4zsFJi0=; b=VVDGle7ggHFSjXiKmyBljSRUA9nq6HyIvzM74MGMA48CQZZUvlY53YZ1r6NjVUMf oe3gI1qInJz+UX7XS5z6ldWy3hncUGe3Axi2RCJtysR+rZpRBOj/OOiTkwG8j/A6Xk3 7UKyiTZNYIvhWZWgMeDBMmYoN9RczNvECVAUHEI4= Received: from localhost (87-110-142-46.pool.kielnet.net [46.142.110.87]) by mx.zohomail.com with SMTPS id 1696880041042238.7567591270539; Mon, 9 Oct 2023 12:34:01 -0700 (PDT) References: <87cyxqokew.fsf@elephly.net> <878r8eog8u.fsf@elephly.net> User-agent: mu4e 1.10.7; emacs 29.1 From: Ricardo Wurmus To: 66384-done@debbugs.gnu.org Subject: Re: [cuirass] /search/latest/archive fails Date: Mon, 09 Oct 2023 21:33:05 +0200 In-reply-to: <878r8eog8u.fsf@elephly.net> Message-ID: <87v8bfmvyy.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66384-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ricardo Wurmus writes: > This is a consequence of commit > 9b227abd29b15e7e25c54a71c524e7b26252a270, and it should be enough to fix > it like this: > > diff --git a/src/cuirass/http.scm b/src/cuirass/http.scm > index 7e4fd3b..9c4c723 100644 > --- a/src/cuirass/http.scm > +++ b/src/cuirass/http.scm > @@ -133,7 +133,8 @@ > (finished . ,(bool->int finished?)) > (buildproducts . ,(list->vector > (map (lambda (product) > - `((type . ,(build-product-type product)) > + `((id . ,(build-product-id product)) > + (type . ,(build-product-type product)) > (path . ,(build-product-file product)) > (file-size . ,(build-product-file-size product)))) > (build-products build)))))) Fixed with commit 72a1fc58d5fe7c2b5fce04dc07fe9eaaba0f8be3. -- Ricardo From unknown Fri Aug 15 18:12:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Nov 2023 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator