From unknown Fri Aug 15 20:51:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66382: 29.1; Prefixed find-file-at-point fails when ido-mode is active. Resent-From: =?UTF-8?Q?St=C3=A9phane?= Soppera Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 01:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66382 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 66382@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16966420276107 (code B ref -1); Sat, 07 Oct 2023 01:28:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Oct 2023 01:27:07 +0000 Received: from localhost ([127.0.0.1]:53089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qow5o-0001Ys-Rm for submit@debbugs.gnu.org; Fri, 06 Oct 2023 21:27:07 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qopmJ-0002UR-Jw for submit@debbugs.gnu.org; Fri, 06 Oct 2023 14:42:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qopls-0001OP-PF for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 14:41:57 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoplr-0007fN-0b for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 14:41:56 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-405524e6768so23759325e9.2 for ; Fri, 06 Oct 2023 11:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696617711; x=1697222511; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=pkvq6CGOz7CKoi3R05FUcHGHrxsHyxGivt8ahvebVFA=; b=K5Vbm7cqraN2kyCI2VrDD9hxcioTAYhHjEhC5MrgQCzv79VezhUj2o9VQUfUwyraOa i4He3JHzHoUG+EBSXM4SNSF8YJmVnuaThR95bbi1KkGUsWttyQ21NAYRwlSXCjVv16ul Tcnyx9q1jde3n1fvdPqinG1aggXciG3CVgc9gMxfe2FtjSNAOd6zcNSKSX010FT+PQiM FztR9xaLrifAtJpxu7m7DKh9tVmLcaIQX8ZxLOOxzKEgF3gcgCPZJ4lCpdMTpnBGVFzM mNNTVJip+OC+Bbjb/gqcBonJ3Qwj2Lh81yx6NBXO+4dar55zRL5YmRmPWgLlLeld/sJS cHkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696617711; x=1697222511; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pkvq6CGOz7CKoi3R05FUcHGHrxsHyxGivt8ahvebVFA=; b=YktbWcIvF8SLuNxx2rjw8OpHVeC9kK8mZx2M5IpxOB9Vuk5zG54N9YkFmwsNCseBBb s9KKgZ5zTM1K4Hscs80NF+0a2Hos5KE1TMx22ZkY7MNZ9AKrA6miWKl+Nz8+yHe4ysdt EBZK08ld2XUXD7yisky9LkfiG1clBhoQ9zafyh3C7uj9uCeuNmwInvoXlV/E1Mc0QKcE uGNYpc+cMGuTTYxLtf/MovUWoKyN8M49HkSne9EqiNuOjxNNbqzX2SxYlJJgg6f1AvXN YNiTvenVkc1cPIY5pQkh/HIK2/OaDHYX3dlZjWzF1kY7IXpPGR4lzq+2ga2j6mSVHc55 EJwQ== X-Gm-Message-State: AOJu0YwlFrJ7nIfDyvYOfhRKJA+FaZsHG2ELf0Z4KmNfGLyXVNPVAeWK ClNrLdQjBBV7Q3dDfCJlqhYNNrjR/hcu7mK/yrq32FfzboylQE+bwmDhseCn X-Google-Smtp-Source: AGHT+IELcd+OhoNJxPtsrKPykehmYGPXjnAYORFJ9PmXSfzoE8rS7FKUYpCQQ/1aaDULqeG7dnksNFIzSXPfyysApdI= X-Received: by 2002:a05:6000:114d:b0:323:37a8:d085 with SMTP id d13-20020a056000114d00b0032337a8d085mr7696040wrx.58.1696617710916; Fri, 06 Oct 2023 11:41:50 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?St=C3=A9phane?= Soppera Date: Fri, 6 Oct 2023 20:41:39 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000fb3ba206071097d1" Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=soppera@google.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Fri, 06 Oct 2023 21:26:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000fb3ba206071097d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Recipe to reproduce: emacs -Q M-x ido-mode M-x ffap-bindings C-u M-x find-file-at-point RET (any file can be used; the default `~/` on Unix works) This fails with: apply: Wrong number of arguments: #, 2 After doing M-x toggle-debug-on-error, the full stack is: Debugger entered--Lisp error: (wrong-number-of-arguments # 2) ido--ffap-find-file("~/" t) apply(ido--ffap-find-file ("~/" t)) #f(advice ido--ffap-find-file :override find-file)("~/" t) funcall-interactively(#f(advice ido--ffap-find-file :override find-file) "~/" t) find-file-at-point() funcall-interactively(find-file-at-point) command-execute(find-file-at-point record) execute-extended-command((4) "find-file-at-point" nil) funcall-interactively(execute-extended-command (4) "find-file-at-point" nil) command-execute(execute-extended-command) This regression seems to come from `(call-interactively ffap-file-finder)` with `(advice ido--ffap-find-file :override find-file)`. Since `ido--ffap-find-file` is not interactive, the `interactive` of `find-file` is used, which uses `find-file-read-args` which returns two arguments and not simply one. The function `ido--ffap-find-file` was added to fix bug #50279. In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-09-04, modified by Debian built on --=20 St=C3=A9phane SOPPERA --000000000000fb3ba206071097d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Recipe to reproduce:

=C2=A0 emacs= -Q
=C2=A0 M-x ido-mode
=C2=A0 M-x ffap-bindings
=C2=A0 C-u M-x fi= nd-file-at-point RET

(any file can be used; the default `~/` on Unix= works)

This fails with:

=C2=A0 apply: Wrong number of argume= nts: #<subr ido--ffap-find-file>, 2

After doing M-x toggle-deb= ug-on-error, the full stack is:

=C2=A0 Debugger entered--Lisp error:= (wrong-number-of-arguments #<subr ido--ffap-find-file> 2)
=C2=A0 = =C2=A0 =C2=A0 ido--ffap-find-file("~/" t)
=C2=A0 =C2=A0 =C2=A0= apply(ido--ffap-find-file ("~/" t))
=C2=A0 =C2=A0 =C2=A0 #f(a= dvice ido--ffap-find-file :override find-file)("~/" t)
=C2=A0 = =C2=A0 =C2=A0 funcall-interactively(#f(advice ido--ffap-find-file :override= find-file) "~/" t)
=C2=A0 =C2=A0 =C2=A0 find-file-at-point()<= br>=C2=A0 =C2=A0 =C2=A0 funcall-interactively(find-file-at-point)
=C2=A0= =C2=A0 =C2=A0 command-execute(find-file-at-point record)
=C2=A0 =C2=A0 = =C2=A0 execute-extended-command((4) "find-file-at-point" nil)
= =C2=A0 =C2=A0 =C2=A0 funcall-interactively(execute-extended-command (4) &qu= ot;find-file-at-point" nil)
=C2=A0 =C2=A0 =C2=A0 command-execute(ex= ecute-extended-command)

This regression seems to come from `(call-in= teractively
ffap-file-finder)` with `(advice ido--ffap-find-file :overri= de
find-file)`. Since `ido--ffap-find-file` is not interactive, the
`= interactive` of `find-file` is used, which uses `find-file-read-args`
wh= ich returns two arguments and not simply one.

The function `ido--ffa= p-find-file` was added to fix bug #50279.

In GNU Emacs 29.1 (build 1= , x86_64-pc-linux-gnu, GTK+ Version 3.24.37,
=C2=A0cairo version 1.16.0)= of 2023-09-04, modified by Debian built on

--
St=C3=A9phane= SOPPERA
--000000000000fb3ba206071097d1-- From unknown Fri Aug 15 20:51:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66382: 29.1; Prefixed find-file-at-point fails when ido-mode is active. Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 06:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66382 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?St=C3=A9phane?= Soppera Cc: 66382@debbugs.gnu.org Received: via spool by 66382-submit@debbugs.gnu.org id=B66382.16966612947652 (code B ref 66382); Sat, 07 Oct 2023 06:49:02 +0000 Received: (at 66382) by debbugs.gnu.org; 7 Oct 2023 06:48:14 +0000 Received: from localhost ([127.0.0.1]:53239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp16k-0001zJ-7G for submit@debbugs.gnu.org; Sat, 07 Oct 2023 02:48:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp16i-0001yZ-8t for 66382@debbugs.gnu.org; Sat, 07 Oct 2023 02:48:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp16J-0007nY-IF; Sat, 07 Oct 2023 02:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lLpInndKw5STZFwLJtfa3+H6GXS03awcvZLi/lGFt/I=; b=rRSfyfRGi185085UoQKH t1UquPmqGeUnLcZFyYFbYolFNzxZ5Wq0O4B3n0VdDQOqbLepNd5uM/f/w8dPtcTZ+nK8Tnv1TK8VB H3w65VAGTbOqmS3V1pAhklGf88JdI9MDCWiXFA1rbacD9qSr46MtcIlryRL6NSFLhnDVWmubZZA9p R4Ng5HFC3xEenYYhRzWqzKIGGg2oxBL3h1cHuL20m/W6vJoFbr8bQfv9vbV8J8XXd2620ZiuizbRB OY7TJIpcAVHMcKqJQZU0EP8rkH/r9HPxkUCXnA9w9A3r5pL0JPeQzANgUspTCOVuHj1YASr1cYSwy Zf/t67GZ9xdYDQ==; Date: Sat, 07 Oct 2023 09:47:56 +0300 Message-Id: <83h6n30vz7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 6 Oct 2023 20:41:39 +0200 > From: Stéphane Soppera via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Recipe to reproduce: > > emacs -Q > M-x ido-mode > M-x ffap-bindings > C-u M-x find-file-at-point RET > > (any file can be used; the default `~/` on Unix works) > > This fails with: > > apply: Wrong number of arguments: #, 2 > > After doing M-x toggle-debug-on-error, the full stack is: > > Debugger entered--Lisp error: (wrong-number-of-arguments # 2) > ido--ffap-find-file("~/" t) > apply(ido--ffap-find-file ("~/" t)) > #f(advice ido--ffap-find-file :override find-file)("~/" t) > funcall-interactively(#f(advice ido--ffap-find-file :override find-file) "~/" t) > find-file-at-point() > funcall-interactively(find-file-at-point) > command-execute(find-file-at-point record) > execute-extended-command((4) "find-file-at-point" nil) > funcall-interactively(execute-extended-command (4) "find-file-at-point" nil) > command-execute(execute-extended-command) > > This regression seems to come from `(call-interactively > ffap-file-finder)` with `(advice ido--ffap-find-file :override > find-file)`. Since `ido--ffap-find-file` is not interactive, the > `interactive` of `find-file` is used, which uses `find-file-read-args` > which returns two arguments and not simply one. > > The function `ido--ffap-find-file` was added to fix bug #50279. Thanks, should be fixed now on the emacs-29 branch. From unknown Fri Aug 15 20:51:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?St=C3=A9phane?= Soppera Subject: bug#66382: closed (Re: bug#66382: 29.1; Prefixed find-file-at-point fails when ido-mode is active.) Message-ID: References: <83jzrpslp1.fsf@gnu.org> X-Gnu-PR-Message: they-closed 66382 X-Gnu-PR-Package: emacs Reply-To: 66382@debbugs.gnu.org Date: Sat, 14 Oct 2023 07:34:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1697268842-19851-1" This is a multi-part message in MIME format... ------------=_1697268842-19851-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66382: 29.1; Prefixed find-file-at-point fails when ido-mode is active. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66382@debbugs.gnu.org. --=20 66382: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66382 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1697268842-19851-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66382-done) by debbugs.gnu.org; 14 Oct 2023 07:33:28 +0000 Received: from localhost ([127.0.0.1]:47770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZ9M-00059S-Gj for submit@debbugs.gnu.org; Sat, 14 Oct 2023 03:33:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZ9L-00059C-Bk for 66382-done@debbugs.gnu.org; Sat, 14 Oct 2023 03:33:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrZ8s-0004TS-Gj; Sat, 14 Oct 2023 03:32:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BBCUMk4eRCIuO27c/N9pU8IRLm3GbNYwYR2bMIUW1Wg=; b=eJF7LPXhG3BYecSzkYXj c71MJ582k3/Hh9xgBJ/h6TqouIZ3+zZtTv4kYRzkuS7fvomdFo4pXqh+HAaO0tofjS8aVK7w3Qy0q Y/2pbc2dYEv3U/ADQCCHuR4vQN3cNK0DHQMCkT1wAShV/QEUtLa92Hjk/m0P17ZE98iEU5RC7jDy3 /VbE5ucHF58oY8yvSlr7vTh51NUfRvpp5U4FXkIk3IszXFVURRTKWaEQlEvyrsj8DTgoFGS5wEjVn EjQvAz74WVvpruMMGwWi4qzUhHR3jbq9dc2UeRQ6iwBxy03gTWHaIhVd5YBb4pqMoOTLgzZfYkr34 mP/SvXRv8k6JCA==; Date: Sat, 14 Oct 2023 10:32:58 +0300 Message-Id: <83jzrpslp1.fsf@gnu.org> From: Eli Zaretskii To: soppera@google.com In-Reply-To: <83h6n30vz7.fsf@gnu.org> (message from Eli Zaretskii on Sat, 07 Oct 2023 09:47:56 +0300) Subject: Re: bug#66382: 29.1; Prefixed find-file-at-point fails when ido-mode is active. References: <83h6n30vz7.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66382-done Cc: 66382-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 66382@debbugs.gnu.org > Date: Sat, 07 Oct 2023 09:47:56 +0300 > From: Eli Zaretskii > > > Date: Fri, 6 Oct 2023 20:41:39 +0200 > > From: Stéphane Soppera via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > Recipe to reproduce: > > > > emacs -Q > > M-x ido-mode > > M-x ffap-bindings > > C-u M-x find-file-at-point RET > > > > (any file can be used; the default `~/` on Unix works) > > > > This fails with: > > > > apply: Wrong number of arguments: #, 2 > > > > After doing M-x toggle-debug-on-error, the full stack is: > > > > Debugger entered--Lisp error: (wrong-number-of-arguments # 2) > > ido--ffap-find-file("~/" t) > > apply(ido--ffap-find-file ("~/" t)) > > #f(advice ido--ffap-find-file :override find-file)("~/" t) > > funcall-interactively(#f(advice ido--ffap-find-file :override find-file) "~/" t) > > find-file-at-point() > > funcall-interactively(find-file-at-point) > > command-execute(find-file-at-point record) > > execute-extended-command((4) "find-file-at-point" nil) > > funcall-interactively(execute-extended-command (4) "find-file-at-point" nil) > > command-execute(execute-extended-command) > > > > This regression seems to come from `(call-interactively > > ffap-file-finder)` with `(advice ido--ffap-find-file :override > > find-file)`. Since `ido--ffap-find-file` is not interactive, the > > `interactive` of `find-file` is used, which uses `find-file-read-args` > > which returns two arguments and not simply one. > > > > The function `ido--ffap-find-file` was added to fix bug #50279. > > Thanks, should be fixed now on the emacs-29 branch. No further comments in a week, so I conclude the bug was indeed solved, and I'm closing it. ------------=_1697268842-19851-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Oct 2023 01:27:07 +0000 Received: from localhost ([127.0.0.1]:53089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qow5o-0001Ys-Rm for submit@debbugs.gnu.org; Fri, 06 Oct 2023 21:27:07 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qopmJ-0002UR-Jw for submit@debbugs.gnu.org; Fri, 06 Oct 2023 14:42:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qopls-0001OP-PF for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 14:41:57 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoplr-0007fN-0b for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 14:41:56 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-405524e6768so23759325e9.2 for ; Fri, 06 Oct 2023 11:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696617711; x=1697222511; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=pkvq6CGOz7CKoi3R05FUcHGHrxsHyxGivt8ahvebVFA=; b=K5Vbm7cqraN2kyCI2VrDD9hxcioTAYhHjEhC5MrgQCzv79VezhUj2o9VQUfUwyraOa i4He3JHzHoUG+EBSXM4SNSF8YJmVnuaThR95bbi1KkGUsWttyQ21NAYRwlSXCjVv16ul Tcnyx9q1jde3n1fvdPqinG1aggXciG3CVgc9gMxfe2FtjSNAOd6zcNSKSX010FT+PQiM FztR9xaLrifAtJpxu7m7DKh9tVmLcaIQX8ZxLOOxzKEgF3gcgCPZJ4lCpdMTpnBGVFzM mNNTVJip+OC+Bbjb/gqcBonJ3Qwj2Lh81yx6NBXO+4dar55zRL5YmRmPWgLlLeld/sJS cHkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696617711; x=1697222511; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pkvq6CGOz7CKoi3R05FUcHGHrxsHyxGivt8ahvebVFA=; b=YktbWcIvF8SLuNxx2rjw8OpHVeC9kK8mZx2M5IpxOB9Vuk5zG54N9YkFmwsNCseBBb s9KKgZ5zTM1K4Hscs80NF+0a2Hos5KE1TMx22ZkY7MNZ9AKrA6miWKl+Nz8+yHe4ysdt EBZK08ld2XUXD7yisky9LkfiG1clBhoQ9zafyh3C7uj9uCeuNmwInvoXlV/E1Mc0QKcE uGNYpc+cMGuTTYxLtf/MovUWoKyN8M49HkSne9EqiNuOjxNNbqzX2SxYlJJgg6f1AvXN YNiTvenVkc1cPIY5pQkh/HIK2/OaDHYX3dlZjWzF1kY7IXpPGR4lzq+2ga2j6mSVHc55 EJwQ== X-Gm-Message-State: AOJu0YwlFrJ7nIfDyvYOfhRKJA+FaZsHG2ELf0Z4KmNfGLyXVNPVAeWK ClNrLdQjBBV7Q3dDfCJlqhYNNrjR/hcu7mK/yrq32FfzboylQE+bwmDhseCn X-Google-Smtp-Source: AGHT+IELcd+OhoNJxPtsrKPykehmYGPXjnAYORFJ9PmXSfzoE8rS7FKUYpCQQ/1aaDULqeG7dnksNFIzSXPfyysApdI= X-Received: by 2002:a05:6000:114d:b0:323:37a8:d085 with SMTP id d13-20020a056000114d00b0032337a8d085mr7696040wrx.58.1696617710916; Fri, 06 Oct 2023 11:41:50 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?St=C3=A9phane_Soppera?= Date: Fri, 6 Oct 2023 20:41:39 +0200 Message-ID: Subject: 29.1; Prefixed find-file-at-point fails when ido-mode is active. To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="000000000000fb3ba206071097d1" Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=soppera@google.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 06 Oct 2023 21:26:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000fb3ba206071097d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Recipe to reproduce: emacs -Q M-x ido-mode M-x ffap-bindings C-u M-x find-file-at-point RET (any file can be used; the default `~/` on Unix works) This fails with: apply: Wrong number of arguments: #, 2 After doing M-x toggle-debug-on-error, the full stack is: Debugger entered--Lisp error: (wrong-number-of-arguments # 2) ido--ffap-find-file("~/" t) apply(ido--ffap-find-file ("~/" t)) #f(advice ido--ffap-find-file :override find-file)("~/" t) funcall-interactively(#f(advice ido--ffap-find-file :override find-file) "~/" t) find-file-at-point() funcall-interactively(find-file-at-point) command-execute(find-file-at-point record) execute-extended-command((4) "find-file-at-point" nil) funcall-interactively(execute-extended-command (4) "find-file-at-point" nil) command-execute(execute-extended-command) This regression seems to come from `(call-interactively ffap-file-finder)` with `(advice ido--ffap-find-file :override find-file)`. Since `ido--ffap-find-file` is not interactive, the `interactive` of `find-file` is used, which uses `find-file-read-args` which returns two arguments and not simply one. The function `ido--ffap-find-file` was added to fix bug #50279. In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-09-04, modified by Debian built on --=20 St=C3=A9phane SOPPERA --000000000000fb3ba206071097d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Recipe to reproduce:

=C2=A0 emacs= -Q
=C2=A0 M-x ido-mode
=C2=A0 M-x ffap-bindings
=C2=A0 C-u M-x fi= nd-file-at-point RET

(any file can be used; the default `~/` on Unix= works)

This fails with:

=C2=A0 apply: Wrong number of argume= nts: #<subr ido--ffap-find-file>, 2

After doing M-x toggle-deb= ug-on-error, the full stack is:

=C2=A0 Debugger entered--Lisp error:= (wrong-number-of-arguments #<subr ido--ffap-find-file> 2)
=C2=A0 = =C2=A0 =C2=A0 ido--ffap-find-file("~/" t)
=C2=A0 =C2=A0 =C2=A0= apply(ido--ffap-find-file ("~/" t))
=C2=A0 =C2=A0 =C2=A0 #f(a= dvice ido--ffap-find-file :override find-file)("~/" t)
=C2=A0 = =C2=A0 =C2=A0 funcall-interactively(#f(advice ido--ffap-find-file :override= find-file) "~/" t)
=C2=A0 =C2=A0 =C2=A0 find-file-at-point()<= br>=C2=A0 =C2=A0 =C2=A0 funcall-interactively(find-file-at-point)
=C2=A0= =C2=A0 =C2=A0 command-execute(find-file-at-point record)
=C2=A0 =C2=A0 = =C2=A0 execute-extended-command((4) "find-file-at-point" nil)
= =C2=A0 =C2=A0 =C2=A0 funcall-interactively(execute-extended-command (4) &qu= ot;find-file-at-point" nil)
=C2=A0 =C2=A0 =C2=A0 command-execute(ex= ecute-extended-command)

This regression seems to come from `(call-in= teractively
ffap-file-finder)` with `(advice ido--ffap-find-file :overri= de
find-file)`. Since `ido--ffap-find-file` is not interactive, the
`= interactive` of `find-file` is used, which uses `find-file-read-args`
wh= ich returns two arguments and not simply one.

The function `ido--ffa= p-find-file` was added to fix bug #50279.

In GNU Emacs 29.1 (build 1= , x86_64-pc-linux-gnu, GTK+ Version 3.24.37,
=C2=A0cairo version 1.16.0)= of 2023-09-04, modified by Debian built on

--
St=C3=A9phane= SOPPERA
--000000000000fb3ba206071097d1-- ------------=_1697268842-19851-1-- From unknown Fri Aug 15 20:51:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66382: 29.1; Prefixed find-file-at-point fails when ido-mode is active. Resent-From: =?UTF-8?Q?St=C3=A9phane?= Soppera Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Oct 2023 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66382 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 66382-done@debbugs.gnu.org Received: via spool by 66382-done@debbugs.gnu.org id=D66382.169744997331675 (code D ref 66382); Mon, 16 Oct 2023 09:53:02 +0000 Received: (at 66382-done) by debbugs.gnu.org; 16 Oct 2023 09:52:53 +0000 Received: from localhost ([127.0.0.1]:55281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsKHN-0008Eo-2v for submit@debbugs.gnu.org; Mon, 16 Oct 2023 05:52:53 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:47274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsKGz-0008Dx-UD for 66382-done@debbugs.gnu.org; Mon, 16 Oct 2023 05:52:30 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40776b200e5so22178325e9.2 for <66382-done@debbugs.gnu.org>; Mon, 16 Oct 2023 02:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697449919; x=1698054719; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=usxb9cGg4TivLn7YL/x46G6Zmx4+ZahEn7Yx5LDMxQE=; b=UmQrxO0ri21U+rmqTDVAS9H+Pr1VhQ+qb6u3flQmLkrI5vZfsAdcRVjfC9TPGjWH/h 8+RikR8n/E3QCZtmKhFVAxcxxLYP7Rn7fELsPFRhEHNpqw/LBaYwqtMXrfMY3XbXXtOL oqFLdOZGgI90Dchz02rcNc4Q6DfUgfjnphq/y9MU2rvv2yOEP4FkRNzTZi8V5DVVk8Ii wamTYzOEw4+QFbtJ0uFMz8H3brkC8zs+fZ6vGc/xQx7Hz4Qf1Sc01kj+oRnyk8NWnReu VgW3YhQM8jcrfi2PHd7+r31gb7J9sCkvhfXF5L9e5qMIqegXtYa1Hr3qI2t6whi1eS2O HLrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697449919; x=1698054719; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=usxb9cGg4TivLn7YL/x46G6Zmx4+ZahEn7Yx5LDMxQE=; b=OXMHa3WUIDzx/TaIPtzuihAT87lAtzQTRvPXrbSVXuVChCTUP9VkXCZQFvVOwwqu2W YAeIZufptbtgGeTgj8Ls0t87Zdj3ti0y2z4o3MiUtUlrKINzV1WsISB974TkgSdgDyU1 FPXG99P8xi1OuJGN0FXBmooitQz9LtSp2Tbj8go7jAQAV6qfOPcki1zeGgbDn/ukJ6NO nvhlFW6ddfnE4CxIw0DSuJT34Md6MiTGcoKnkvJ8YI+Mr09MgSXc8V5dPTWUNrr+AsPQ e5uQK0gfNDNvjUIumggVOnBH3nPtvlTHQI1chIPrfuz7RRlzp8bSb9bwTHDu9iM+LgFt 4sSg== X-Gm-Message-State: AOJu0Yw6AVpTwS+CSihLc62BlX0//NjVheJobNYlt+RGRPUct8tafjtK yH0tjujCxBu09+S7tWBZ5Ro3iou0hf8gn9mJjsSRkQ== X-Google-Smtp-Source: AGHT+IE9NTRyc6nwAxQBxSmFHMYCnPkf8lfei7/kU53GC1lDjp3RaKV0TpcYiDcQRzmajfYSe2h/JvzbVV/1htjFp3I= X-Received: by 2002:adf:f2ce:0:b0:32d:9fc9:d14a with SMTP id d14-20020adff2ce000000b0032d9fc9d14amr6337206wrp.12.1697449919211; Mon, 16 Oct 2023 02:51:59 -0700 (PDT) MIME-Version: 1.0 References: <83h6n30vz7.fsf@gnu.org> <83jzrpslp1.fsf@gnu.org> In-Reply-To: <83jzrpslp1.fsf@gnu.org> From: =?UTF-8?Q?St=C3=A9phane?= Soppera Date: Mon, 16 Oct 2023 11:51:47 +0200 Message-ID: Content-Type: multipart/alternative; boundary="0000000000007619950607d25b16" X-Spam-Score: -8.0 (--------) X-Mailman-Approved-At: Mon, 16 Oct 2023 05:52:52 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) --0000000000007619950607d25b16 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the fix! Since there was no question in the previous message I hesitated commenting again. On Sat, Oct 14, 2023 at 9:32=E2=80=AFAM Eli Zaretskii wrote: > > Cc: 66382@debbugs.gnu.org > > Date: Sat, 07 Oct 2023 09:47:56 +0300 > > From: Eli Zaretskii > > > > > Date: Fri, 6 Oct 2023 20:41:39 +0200 > > > From: St=C3=A9phane Soppera via "Bug reports for GNU Emacs, > > > the Swiss army knife of text editors" > > > > > > Recipe to reproduce: > > > > > > emacs -Q > > > M-x ido-mode > > > M-x ffap-bindings > > > C-u M-x find-file-at-point RET > > > > > > (any file can be used; the default `~/` on Unix works) > > > > > > This fails with: > > > > > > apply: Wrong number of arguments: #, 2 > > > > > > After doing M-x toggle-debug-on-error, the full stack is: > > > > > > Debugger entered--Lisp error: (wrong-number-of-arguments # ido--ffap-find-file> 2) > > > ido--ffap-find-file("~/" t) > > > apply(ido--ffap-find-file ("~/" t)) > > > #f(advice ido--ffap-find-file :override find-file)("~/" t) > > > funcall-interactively(#f(advice ido--ffap-find-file :override > find-file) "~/" t) > > > find-file-at-point() > > > funcall-interactively(find-file-at-point) > > > command-execute(find-file-at-point record) > > > execute-extended-command((4) "find-file-at-point" nil) > > > funcall-interactively(execute-extended-command (4) > "find-file-at-point" nil) > > > command-execute(execute-extended-command) > > > > > > This regression seems to come from `(call-interactively > > > ffap-file-finder)` with `(advice ido--ffap-find-file :override > > > find-file)`. Since `ido--ffap-find-file` is not interactive, the > > > `interactive` of `find-file` is used, which uses `find-file-read-args= ` > > > which returns two arguments and not simply one. > > > > > > The function `ido--ffap-find-file` was added to fix bug #50279. > > > > Thanks, should be fixed now on the emacs-29 branch. > > No further comments in a week, so I conclude the bug was indeed > solved, and I'm closing it. > --=20 St=C3=A9phane --0000000000007619950607d25b16 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks for the fix!
Since there was no question in the= previous message I hesitated commenting again.

On Sat, Oct 14, 2023= at 9:32=E2=80=AFAM Eli Zaretskii <eliz@= gnu.org> wrote:
> Cc: = 66382@debbugs.gnu.org
> Date: Sat, 07 Oct 2023 09:47:56 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Fri, 6 Oct 2023 20:41:39 +0200
> > From:=C2=A0 St=C3=A9phane Soppera via "Bug reports for GNU E= macs,
> >=C2=A0 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>= ;
> >
> > Recipe to reproduce:
> >
> >=C2=A0 =C2=A0emacs -Q
> >=C2=A0 =C2=A0M-x ido-mode
> >=C2=A0 =C2=A0M-x ffap-bindings
> >=C2=A0 =C2=A0C-u M-x find-file-at-point RET
> >
> > (any file can be used; the default `~/` on Unix works)
> >
> > This fails with:
> >
> >=C2=A0 =C2=A0apply: Wrong number of arguments: #<subr ido--ffap= -find-file>, 2
> >
> > After doing M-x toggle-debug-on-error, the full stack is:
> >
> >=C2=A0 =C2=A0Debugger entered--Lisp error: (wrong-number-of-argume= nts #<subr ido--ffap-find-file> 2)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0ido--ffap-find-file("~/" t) > >=C2=A0 =C2=A0 =C2=A0 =C2=A0apply(ido--ffap-find-file ("~/&quo= t; t))
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0#f(advice ido--ffap-find-file :override= find-file)("~/" t)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0funcall-interactively(#f(advice ido--ff= ap-find-file :override find-file) "~/" t)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0find-file-at-point()
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0funcall-interactively(find-file-at-poin= t)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0command-execute(find-file-at-point reco= rd)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0execute-extended-command((4) "find= -file-at-point" nil)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0funcall-interactively(execute-extended-= command (4) "find-file-at-point" nil)
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0command-execute(execute-extended-comman= d)
> >
> > This regression seems to come from `(call-interactively
> > ffap-file-finder)` with `(advice ido--ffap-find-file :override > > find-file)`. Since `ido--ffap-find-file` is not interactive, the<= br> > > `interactive` of `find-file` is used, which uses `find-file-read-= args`
> > which returns two arguments and not simply one.
> >
> > The function `ido--ffap-find-file` was added to fix bug #50279. >
> Thanks, should be fixed now on the emacs-29 branch.

No further comments in a week, so I conclude the bug was indeed
solved, and I'm closing it.


--
St=C3=A9phane
--0000000000007619950607d25b16--