Subject: Re: [bug#66367] [PATCH] gnu: Add gnome-shell-extension-night-theme-switcher.

From: Maxim Cournoyer <[email-masked]>
Date: Fri, 06 Oct 2023 09:13:07 -0400

Hi,

Sergio Pastor Pérez <[email-masked]> writes:

> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-night-theme-switcher): New variable.
> ---
> Hi.
>
> I'm submitting this patch specifically targeting version 65. Although there are
> newer versions of this shell extension, this is the last tagged commit which
> supports our version of GNOME, 42.4.
>
> Have a good night,
> Sergio.
>
>  gnu/packages/gnome-xyz.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index 8b5dc3030e..651c958f83 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -1050,6 +1050,30 @@ (define-public gnome-shell-extension-paperwm
>  notebooks and tiling window managers.")
>      (license license:gpl3)))
>  
> +(define-public gnome-shell-extension-night-theme-switcher
> +  (package
> +    (name "gnome-shell-extension-night-theme-switcher")
> +    (version "65")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url
> +              "https://gitlab.com/rmnvgr/nightthemeswitcher-gnome-shell-extension")
> +             (commit version)))
> +       (sha256
> +        (base32 "0qhi2g2lh6m8vhrmmfi60977f0i4k9x1zj68lrvpzzlqndz8cgh9"))
> +       (file-name (git-file-name name version))))
> +    (build-system meson-build-system)
> +    (native-inputs (list pkg-config
> +                         (list glib "bin")))

nitpick: when there are less than 5 inputs, it's fine to list them on a
single line.

> +    (synopsis "Automatic theme switcher for GNOME Shell")
> +    (description
> +     "Automatically toggle your GNOME desktops color scheme between light and
> +dark, switch backgrounds and run custom commands at sunset and sunrise.")
> +    (home-page "https://nightthemeswitcher.romainvigier.fr")
> +    (license license:gpl2+)))

Thanks.  There seems to be some binary code in the middle of the
description.  Could you check?

-- 
Thanks,
Maxim