GNU bug report logs - #66360
[PATCH] doc: Use herd for cerbot deploy hook example.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Bruno Victal <mirai <at> makinata.eu>
Subject: bug#66360: closed (Re: [bug#66360] [PATCH] doc: Use herd for
 cerbot deploy hook example.)
Date: Sat, 14 Oct 2023 20:30:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#66360: [PATCH] doc: Use herd for cerbot deploy hook example.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 66360 <at> debbugs.gnu.org.

-- 
66360: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66360
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 66360-done <at> debbugs.gnu.org
Subject: Re: [bug#66360] [PATCH] doc: Use herd for cerbot deploy hook example.
Date: Sat, 14 Oct 2023 22:28:59 +0200

Hi,

Bruno Victal <mirai <at> makinata.eu> skribis:

> * doc/guix.texi (Certificate Services): Replace PID file based example with
> one using (gnu services herd). Rename %nginx-deploy-hook to
> %certbot-deploy-hook.

Applied, thanks!

> +(define %certbot-deploy-hook
> +  (program-file "certbot-deploy-hook.scm"
> +    (with-imported-modules '((gnu services herd))
> +      #~(begin
> +          (use-modules (gnu services herd))
> +          (with-shepherd-action 'nginx ('reload) result result)))))

Should we make it the default ‘deploy-hook’ value in
<certificate-configuration>?  I’ve always been frustrated that
‘certbot-service-type’ doesn’t quite work out of the box.

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH] doc: Use herd for cerbot deploy hook example.
Date: Thu,  5 Oct 2023 14:20:49 +0100

* doc/guix.texi (Certificate Services): Replace PID file based example with
one using (gnu services herd). Rename %nginx-deploy-hook to
%certbot-deploy-hook.
---
 doc/guix.texi | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 8c5697589f..c54bfc0154 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -31935,11 +31935,12 @@ Certificate Services
 must be a @code{certbot-configuration} record as in this example:
 
 @lisp
-(define %nginx-deploy-hook
-  (program-file
-   "nginx-deploy-hook"
-   #~(let ((pid (call-with-input-file "/var/run/nginx/pid" read)))
-       (kill pid SIGHUP))))
+(define %certbot-deploy-hook
+  (program-file "certbot-deploy-hook.scm"
+    (with-imported-modules '((gnu services herd))
+      #~(begin
+          (use-modules (gnu services herd))
+          (with-shepherd-action 'nginx ('reload) result result)))))
 
 (service certbot-service-type
          (certbot-configuration
@@ -31948,7 +31949,7 @@ Certificate Services
            (list
             (certificate-configuration
              (domains '("example.net" "www.example.net"))
-             (deploy-hook %nginx-deploy-hook))
+             (deploy-hook %certbot-deploy-hook))
             (certificate-configuration
              (domains '("bar.example.net")))))))
 @end lisp

base-commit: 044a76c280c26b8ea731c4367d74474805b7257a
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.