From unknown Sun Jun 22 11:42:40 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66360] [PATCH] doc: Use herd for cerbot deploy hook example. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2023 13:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66360@debbugs.gnu.org Cc: Bruno Victal X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169651213113693 (code B ref -1); Thu, 05 Oct 2023 13:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Oct 2023 13:22:11 +0000 Received: from localhost ([127.0.0.1]:46268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoOIt-0003Yn-8c for submit@debbugs.gnu.org; Thu, 05 Oct 2023 09:22:11 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoOIo-0003Y6-OS for submit@debbugs.gnu.org; Thu, 05 Oct 2023 09:22:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoOIL-0005rr-Pk for guix-patches@gnu.org; Thu, 05 Oct 2023 09:21:37 -0400 Received: from smtpm4.myservices.hosting ([185.26.105.235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoOII-0007tK-Vo for guix-patches@gnu.org; Thu, 05 Oct 2023 09:21:37 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm4.myservices.hosting (Postfix) with ESMTP id A686020D71 for ; Thu, 5 Oct 2023 15:21:32 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id D0A7580095; Thu, 5 Oct 2023 15:21:31 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z1RN7GbECCuO; Thu, 5 Oct 2023 15:21:31 +0200 (CEST) Received: from guix-nuc.home.arpa (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 4E07280092; Thu, 5 Oct 2023 15:21:31 +0200 (CEST) From: Bruno Victal Date: Thu, 5 Oct 2023 14:20:49 +0100 Message-ID: <1e6aa96a1ed21a5cad335ba2693f09b20a4767d4.1696512049.git.mirai@makinata.eu> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.105.235; envelope-from=mirai@makinata.eu; helo=smtpm4.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * doc/guix.texi (Certificate Services): Replace PID file based example with one using (gnu services herd). Rename %nginx-deploy-hook to %certbot-deploy-hook. --- doc/guix.texi | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 8c5697589f..c54bfc0154 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -31935,11 +31935,12 @@ Certificate Services must be a @code{certbot-configuration} record as in this example: @lisp -(define %nginx-deploy-hook - (program-file - "nginx-deploy-hook" - #~(let ((pid (call-with-input-file "/var/run/nginx/pid" read))) - (kill pid SIGHUP)))) +(define %certbot-deploy-hook + (program-file "certbot-deploy-hook.scm" + (with-imported-modules '((gnu services herd)) + #~(begin + (use-modules (gnu services herd)) + (with-shepherd-action 'nginx ('reload) result result))))) (service certbot-service-type (certbot-configuration @@ -31948,7 +31949,7 @@ Certificate Services (list (certificate-configuration (domains '("example.net" "www.example.net")) - (deploy-hook %nginx-deploy-hook)) + (deploy-hook %certbot-deploy-hook)) (certificate-configuration (domains '("bar.example.net"))))))) @end lisp base-commit: 044a76c280c26b8ea731c4367d74474805b7257a -- 2.41.0 From unknown Sun Jun 22 11:42:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Bruno Victal Subject: bug#66360: closed (Re: [bug#66360] [PATCH] doc: Use herd for cerbot deploy hook example.) Message-ID: References: <87o7h19cdw.fsf@gnu.org> <1e6aa96a1ed21a5cad335ba2693f09b20a4767d4.1696512049.git.mirai@makinata.eu> X-Gnu-PR-Message: they-closed 66360 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 66360@debbugs.gnu.org Date: Sat, 14 Oct 2023 20:30:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1697315403-3986-1" This is a multi-part message in MIME format... ------------=_1697315403-3986-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66360: [PATCH] doc: Use herd for cerbot deploy hook example. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66360@debbugs.gnu.org. --=20 66360: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66360 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1697315403-3986-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66360-done) by debbugs.gnu.org; 14 Oct 2023 20:29:34 +0000 Received: from localhost ([127.0.0.1]:50684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrlGP-00010l-IG for submit@debbugs.gnu.org; Sat, 14 Oct 2023 16:29:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrlGN-00010X-1X for 66360-done@debbugs.gnu.org; Sat, 14 Oct 2023 16:29:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrlFt-0001zk-B3; Sat, 14 Oct 2023 16:29:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8IXmn4Q1B1HLw4ZiS6g/TSi+YIrFHpoMC9HdJe4obgc=; b=kFBxMF5ykaTkXNwisK37 hrRxkBoNS1uOL78LEO4JWc//5/C+/G81LNDXDewRA8OuBgit389SMQXG8BPdlVN1KKcnduHwlurZw ogBY7LMC4mdrvTRFqPAa499cEbxASVjfZ2wzJKqjTeaRIhAftv5IyYs07JxgMkLLQGnmmbho30w08 vTTG8BWluYzh1wNXGMhMP5j2zxD1P8ruaLOVHeZM7siasU5nYqbRWTvu3IK4dA9PZsReh9IDZgDS6 PbKm0guW5GQe4Kru1Ew0YnnWxGStWDAWK4gIaJBkAYedfTIi7OEOcsWBFLfwT7zfzsy8wL6rz0hJG Ur5M2JzNg4jMbA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Bruno Victal Subject: Re: [bug#66360] [PATCH] doc: Use herd for cerbot deploy hook example. In-Reply-To: <1e6aa96a1ed21a5cad335ba2693f09b20a4767d4.1696512049.git.mirai@makinata.eu> (Bruno Victal's message of "Thu, 5 Oct 2023 14:20:49 +0100") References: <1e6aa96a1ed21a5cad335ba2693f09b20a4767d4.1696512049.git.mirai@makinata.eu> Date: Sat, 14 Oct 2023 22:28:59 +0200 Message-ID: <87o7h19cdw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66360-done Cc: 66360-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Bruno Victal skribis: > * doc/guix.texi (Certificate Services): Replace PID file based example wi= th > one using (gnu services herd). Rename %nginx-deploy-hook to > %certbot-deploy-hook. Applied, thanks! > +(define %certbot-deploy-hook > + (program-file "certbot-deploy-hook.scm" > + (with-imported-modules '((gnu services herd)) > + #~(begin > + (use-modules (gnu services herd)) > + (with-shepherd-action 'nginx ('reload) result result))))) Should we make it the default =E2=80=98deploy-hook=E2=80=99 value in ? I=E2=80=99ve always been frustrated that =E2=80=98certbot-service-type=E2=80=99 doesn=E2=80=99t quite work out of th= e box. Ludo=E2=80=99. ------------=_1697315403-3986-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Oct 2023 13:22:11 +0000 Received: from localhost ([127.0.0.1]:46268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoOIt-0003Yn-8c for submit@debbugs.gnu.org; Thu, 05 Oct 2023 09:22:11 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoOIo-0003Y6-OS for submit@debbugs.gnu.org; Thu, 05 Oct 2023 09:22:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoOIL-0005rr-Pk for guix-patches@gnu.org; Thu, 05 Oct 2023 09:21:37 -0400 Received: from smtpm4.myservices.hosting ([185.26.105.235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoOII-0007tK-Vo for guix-patches@gnu.org; Thu, 05 Oct 2023 09:21:37 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm4.myservices.hosting (Postfix) with ESMTP id A686020D71 for ; Thu, 5 Oct 2023 15:21:32 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id D0A7580095; Thu, 5 Oct 2023 15:21:31 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z1RN7GbECCuO; Thu, 5 Oct 2023 15:21:31 +0200 (CEST) Received: from guix-nuc.home.arpa (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 4E07280092; Thu, 5 Oct 2023 15:21:31 +0200 (CEST) From: Bruno Victal To: guix-patches@gnu.org Subject: [PATCH] doc: Use herd for cerbot deploy hook example. Date: Thu, 5 Oct 2023 14:20:49 +0100 Message-ID: <1e6aa96a1ed21a5cad335ba2693f09b20a4767d4.1696512049.git.mirai@makinata.eu> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.105.235; envelope-from=mirai@makinata.eu; helo=smtpm4.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Bruno Victal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * doc/guix.texi (Certificate Services): Replace PID file based example with one using (gnu services herd). Rename %nginx-deploy-hook to %certbot-deploy-hook. --- doc/guix.texi | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 8c5697589f..c54bfc0154 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -31935,11 +31935,12 @@ Certificate Services must be a @code{certbot-configuration} record as in this example: @lisp -(define %nginx-deploy-hook - (program-file - "nginx-deploy-hook" - #~(let ((pid (call-with-input-file "/var/run/nginx/pid" read))) - (kill pid SIGHUP)))) +(define %certbot-deploy-hook + (program-file "certbot-deploy-hook.scm" + (with-imported-modules '((gnu services herd)) + #~(begin + (use-modules (gnu services herd)) + (with-shepherd-action 'nginx ('reload) result result))))) (service certbot-service-type (certbot-configuration @@ -31948,7 +31949,7 @@ Certificate Services (list (certificate-configuration (domains '("example.net" "www.example.net")) - (deploy-hook %nginx-deploy-hook)) + (deploy-hook %certbot-deploy-hook)) (certificate-configuration (domains '("bar.example.net"))))))) @end lisp base-commit: 044a76c280c26b8ea731c4367d74474805b7257a -- 2.41.0 ------------=_1697315403-3986-1--