GNU bug report logs - #66358
Some options are really subcommands + ignore arguments

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: control <at> debbugs.gnu.org, Tobias Geerinckx-Rice <me <at> tobias.gr>, "Perry, Daniel J" <dperry45 <at> gatech.edu>, 66358 <at> debbugs.gnu.org
Subject: bug#66358: Some options are really subcommands + ignore arguments
Date: Tue, 24 Oct 2023 10:48:18 -0400

Hi Simon,

Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> On Mon, 09 Oct 2023 at 14:25, Tobias Geerinckx-Rice via Bug reports
> for GNU Guix <bug-guix <at> gnu.org> wrote:
>
>> I think it would be less surprising if these ‘single, mutually exclusive 
>> actions’ should always be (sub)subcommands, e.g., ‘guix archive import’, 
>> ‘guix archive authorize’, …
>
> I am proposing to error for ambiguous cases as,
>
>     $ ./pre-inst-env guix archive --import --authorize hello < /tmp/hello.nar
>     guix archive: error: ambiguous options: "authorize" with "import"
>
> See attached patch.  WDYT?
>
> Please note that it errors when at least 2 options are ambiguous.  So if
> there is 3, you get the “two first ones“.

It seems a reasonable improvement to me, but I think *all* the
incompatible errors should be accumulated and printed in one go.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.