From unknown Tue Jun 17 01:50:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66336] [PATCH] gnu: guile-proba: Fix environment vars in Guile Proba's script. Resent-From: Fabio Natali Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2023 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66336 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66336@debbugs.gnu.org Cc: Luis Felipe , Fabio Natali X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.169641536516272 (code B ref -1); Wed, 04 Oct 2023 10:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Oct 2023 10:29:25 +0000 Received: from localhost ([127.0.0.1]:41654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnz89-0004EO-5k for submit@debbugs.gnu.org; Wed, 04 Oct 2023 06:29:25 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnz86-0004EA-Ex for submit@debbugs.gnu.org; Wed, 04 Oct 2023 06:29:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnz7i-0000uh-NL for guix-patches@gnu.org; Wed, 04 Oct 2023 06:28:59 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnz7g-0002aM-7p for guix-patches@gnu.org; Wed, 04 Oct 2023 06:28:58 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 793481BF206; Wed, 4 Oct 2023 10:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1696415333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hxxcgOkeJIXBItrMqzV+1sg4bFPIT0H8SWtccISvHqA=; b=NRK69SBdoKwW5JHRAeYZDwvPu0bHqdy15MahfV8oduEI2vyKfR9TbEGlnU0Fawc3cI48r4 THuf4zpcHCXJvlu5hNm33Zrkl0LyqYCp5EbW5MSiq9yuUFQmRZCpKKMrPHdFF3Oo19aS3/ XNE2ChHkvQBV0rdS5XeFVB2huPQCIr6nE33UeUWybc+LyW6zFDInCfsF106g4UT36ApvJx hl0Yg9Uq1I/5se3DCO4GMneq+v+ZTTDqjW48JhwGrM44TxmkkVAV33Lw6/yS7ZQ1iJpebE 3FRmM37TKaUvBdVSzMRiXBAGjTY7J+CZJYzx5YfVDBzJ+UyzVZRA6iHEL7EnhA== From: Fabio Natali Date: Wed, 4 Oct 2023 11:20:30 +0100 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: me@fabionatali.com Received-SPF: pass client-ip=217.70.183.201; envelope-from=me@fabionatali.com; helo=relay8-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) * gnu/packages/check.scm (guile-proba): Micro fix. Guile Proba's CLI script, as created via Guix's `wrap-program', should take into account (as opposed to discard) the original, user-defined values of `GUILE_LOAD_PATH' and `GUILE_LOAD_COMPILED_PATH'. Currently, Guile Proba's CLI script is unable to find any third-party library needed by the app being tested. This micro change should fix this. --- Hi, I think there might be a slight PATH-related issue in the way guile-proba is currently packaged. Specifically, I think it should be: #+begin_src scheme :noeval `("GUILE_LOAD_PATH" prefix (,(getenv "GUILE_LOAD_PATH"))) `("GUILE_LOAD_COMPILED_PATH" prefix (,(getenv "GUILE_LOAD_COMPILED_PATH"))))))) #+end_src as opposed to the way it's now: #+begin_src scheme :noeval `("GUILE_LOAD_PATH" = (,(getenv "GUILE_LOAD_PATH"))) `("GUILE_LOAD_COMPILED_PATH" = (,(getenv "GUILE_LOAD_COMPILED_PATH"))))))) #+end_src The current version results in the following CLI program: #+begin_export ascii user@host:~/staging/guix$ guix shell --container --link-profile coreutils guile-proba -- cat ~/.guix-profile/bin/proba #!/gnu/store/9vw5slrffp27rzy2i2plnw7xfqjyk7m4-bash-minimal-5.1.16/bin/bash export GUILE_LOAD_PATH="/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/share/guile/site/3.0:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0" export GUILE_LOAD_COMPILED_PATH="/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/lib/guile/3.0/site-ccache/:/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/lib/guile/3.0/site-ccache:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0" exec -a "$0" "/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/bin/.proba-real" "$@" #+end_export whereas I think the script should read (with this micro-patch): #+begin_export ascii user@host:~/staging/guix$ ./pre-inst-env guix shell --container --link-profile coreutils guile-proba -- cat ~/.guix-profile/bin/proba #!/gnu/store/9vw5slrffp27rzy2i2plnw7xfqjyk7m4-bash-minimal-5.1.16/bin/bash export GUILE_LOAD_PATH="/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/share/guile/site/3.0:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH" export GUILE_LOAD_COMPILED_PATH="/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/lib/guile/3.0/site-ccache/:/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/lib/guile/3.0/site-ccache:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH" exec -a "$0" "/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/bin/.proba-real" "$@" #+end_export As a result of this, currently, Guile Proba's CLI script is unable to find any third-party library needed by the app being tested. This micro change should fix this. This can be tested as follows. #+begin_export shell :noeval $ tree . ├── foo.scm └── tests └── test-main.scm #+end_export #+begin_src scheme :noeval ;; foo.scm (define-module (foo) #:use-module (ini) #:export (bar)) (define (bar) (call-with-input-string "[foo]\nbar=baz\n" ini->scm)) #+end_src #+begin_src scheme :noeval ;; test-main.scm (define-module (test-main) #:use-module (foo) #:use-module (srfi srfi-64)) (test-begin "main") (test-equal "main" (bar) '(("foo" ("bar" . "baz")))) (test-end "main") #+end_src With the above files in place: #+begin_src shell :noeval $ proba run tests [...] ice-9/boot-9.scm:3330:6: In procedure resolve-interface: no code for module (ini) #+end_src What do you think? I hope the change looks fine. Thanks, best, Fabio. gnu/packages/check.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 5af3b49280..e3c32c17c2 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -3599,8 +3599,8 @@ (define-public guile-proba (copy-file "proba.scm" script) (chmod script #o555) (wrap-program script - `("GUILE_LOAD_PATH" = (,(getenv "GUILE_LOAD_PATH"))) - `("GUILE_LOAD_COMPILED_PATH" = + `("GUILE_LOAD_PATH" prefix (,(getenv "GUILE_LOAD_PATH"))) + `("GUILE_LOAD_COMPILED_PATH" prefix (,(getenv "GUILE_LOAD_COMPILED_PATH"))))))) (add-after 'install 'install-manual (lambda* (#:key outputs #:allow-other-keys) base-commit: 24fc0370d0d12f34cffd44801cc6382fc5cc5f23 -- 2.41.0 From unknown Tue Jun 17 01:50:45 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#66336] [PATCH] gnu: guile-proba: Fix environment vars in Guile Proba's script. References: In-Reply-To: Resent-From: Luis Felipe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2023 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66336 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 66336@debbugs.gnu.org Received: via spool by 66336-submit@debbugs.gnu.org id=B66336.16965309712206 (code B ref 66336); Thu, 05 Oct 2023 18:37:02 +0000 Received: (at 66336) by debbugs.gnu.org; 5 Oct 2023 18:36:11 +0000 Received: from localhost ([127.0.0.1]:48525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoTCl-0000ZW-1j for submit@debbugs.gnu.org; Thu, 05 Oct 2023 14:36:11 -0400 Received: from sender3-pp-o98.zoho.com ([136.143.184.98]:25890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoTCh-0000ZI-4T for 66336@debbugs.gnu.org; Thu, 05 Oct 2023 14:36:09 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1696530945; cv=none; d=zohomail.com; s=zohoarc; b=Gdu/2/TlfNUTo9RlKL8MsZUlVHsvvrN8CaRh04c7kXU0u7yJiouqDlXuNABcvOLZgDcBXaYxXTS0SCPLMlaDZR7oRx5bf3Ea/KBIfGDHKL7XJcDKiwXfd8NT90fqJ8fz1TGlyE4GQEhBvA2MietfdS7GMaTdmPZwUeVIf0eZVgw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1696530945; h=Content-Type:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=LArWEwRo+4+Df345WTZRpv9baJcCsqMA6vnzmuVce20=; b=njMevWcfcgn+n8PW3iQHcqRKaLHYYaDmyO2kjG2hRm4tHaEanXh/c1vXqp+EdWygtzx18hPN5wu7Aq4tZXxQ9aPnIvWqUsd0tTxmmPdmKBzEixW27YWs07V/xvMQxJ9fs1CgjrkfyyrUUGiX9yngdTD6edbyfF2oNuYcqq/rBuc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=sirgazil@zoho.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1696530945; s=zm2022; d=zoho.com; i=sirgazil@zoho.com; h=Message-ID:Date:Date:MIME-Version:To:To:From:From:Subject:Subject:Content-Type:Feedback-ID:Message-Id:Reply-To:Cc; bh=LArWEwRo+4+Df345WTZRpv9baJcCsqMA6vnzmuVce20=; b=KTdOUyofusfcw3RuDCgMvBCh0JaMNwTJNrfMBCHjjxRWW0h+shVBghrk7wJBbbzv Ad3toDCgTZEwvTq1Boq/X3DkQlf9av1VgxlHipkz1wWI39U37MT9ZOfBZzo5522SWxp mayg0tGW8w0sL3B7BhsZSLGVCCRTKULxvDPwyEOc= Received: from [192.168.1.58] (191.95.158.240 [191.95.158.240]) by mx.zohomail.com with SMTPS id 169653094316118.79033954317947; Thu, 5 Oct 2023 11:35:43 -0700 (PDT) Message-ID: Date: Thu, 5 Oct 2023 18:35:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: es-MX, en-US From: Luis Felipe Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------GB5CcFkXt06heQi0HuyIDG01" X-Zoho-Virus-Status: 1 Feedback-ID: rr08011227f0a00fcd9130ddef6721553e00009c4d5d7dc78061c7f8021967b3b207e4bd4ac46a7345feffa3:zu08011227ad2d6cc2f1a1d8e3cd593c860000a9f8f364150f631cdba2a48c4eb88ec92d9d494662cb806723:rf08011226911d05534d21f512dcbe98070000b2f992f68558e158626e301062f8fe3877a9068ea307ef02:ZohoMail X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------GB5CcFkXt06heQi0HuyIDG01 Content-Type: multipart/mixed; boundary="------------diHebehVgYZ00UAxgg6Ru4g5"; protected-headers="v1" From: Luis Felipe To: 66336@debbugs.gnu.org Message-ID: Subject: [PATCH] gnu: guile-proba: Fix environment vars in Guile Proba's script. --------------diHebehVgYZ00UAxgg6Ru4g5 Content-Type: multipart/mixed; boundary="------------NdhEBNvNxVf2v5K3YmqkyXmd" --------------NdhEBNvNxVf2v5K3YmqkyXmd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 SGkgRmFiaW8sIGV2ZXJ5b25lLg0KDQpJIGNhbiByZXByb2R1Y2UgdGhlIGRlZmVjdCBhbmQg Y2FuIGNvbmZpcm0gdGhhdCB0aGUgcGF0Y2ggc29sdmVzIHRoZSANCnByb2JsZW0uDQoNCkkg ZG9uJ3QgaGF2ZSBjb21taXQgYWNjZXNzLCBidXQsIGZvciB3aGF0IGl0J3Mgd29ydGgsIEkg c2VlIHRoYXQgaW4gYSANCnwuL3ByZS1pbnN0LWVudnwNCg0K4piRIFRoZSBwYXRjaCBhcHBs aWVzIGNvcnJlY3RseQ0K4piRIHxndWl4IGJ1aWxkIC0tY2hlY2sgLS1uby1ncmFmdHMgZ3Vp bGUtcHJvYmEgfHN1Y2NlZWRzDQrimJEgZ3VpeCBsaW50IGd1aWxlLXByb2JhIGRvZXMgbm90 IHJlcG9ydCBpc3N1ZXMgKGFsdGhvdWdoIGl0IGluZGljYXRlcyANCnRoZSBwYWNrYWdlIGNh biBiZSB1cGdyYWRlZCB0byAwLjMuMSkNCg0KQ2hlZXJzLA0K --------------NdhEBNvNxVf2v5K3YmqkyXmd Content-Type: application/pgp-keys; name="OpenPGP_0x0AB0D067012F08C3.asc" Content-Disposition: attachment; filename="OpenPGP_0x0AB0D067012F08C3.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBGQLfUoBCADXXtq7q0B515koc28OwplQF3XrLOcHzn7DW2HL8WnRfSJp2Yra Ko6HyfbPmkjkfoRXpXyJBPvRE7f3O5RWkcEoTEXo5Ll2QEtYfangcoTxImcfwsdK mRl6saEPNhIykrYNM6gcLHxiL//NZZJwO+9uD2R4JRIQfJ7gJ4/e2m8SlA/0Xw1J KqClOOewnwUcb+cYtZSQo4r0ujYdDcFYlG3I7F+/DwTZfqCnixL0fSXEUOVQ5dUp u2lK3wMRHE9H60QEM96t6RPiQFA2uan8fX4eT1Igmdq69QUOAQBP5AHW91E+1eMT qcOa8VmCtJjcY9AMW65LVIzegwkQE4H0vC8DABEBAAHNOEx1aXMgRmVsaXBlIEzD s3BleiBBY2V2ZWRvIDxsdWlzLmZlbGlwZS5sYUB6b2hvbWFpbC5jb20+wsCOBBMB CAA4FiEECRCCei4GHmFsBqw9CrDQZwEvCMMFAmQLfUoCGwMFCwkIBwIGFQoJCAsC BBYCAwECHgECF4AACgkQCrDQZwEvCMO+oQf/bZt7NOgQw96RJSM32wTQhqj6C1dK jgtKmFecjxxXM5EiYQZPvBDrmjnzVu1mw70eE1N5DFNpCu0qp2vSqvly+PIa7z5F UOTivVpV6lDDc07BpW4J8/HNZu/GFmvZ2QtzPlr2rcGcRcwYlK9E+WKxT6lPINWN t2Ca9v+0Kz0OIAj4gEiJZNWQ41tIAHwNm9NKvBgtLxWB3UPteLnHSwRm7gptWF8I qkjyxNygj3vE+SSVYoilcQsljmCV4zbp7kGUFK9pIxwy85e4VmOehyKLxDqiIGKs 42PydPTFQc1KpmNpbrnadYyXEI8ZchMHbFI6YCduqv1aJ0Q2LmXxItikMc0uTHVp cyBGZWxpcGUgTMOzcGV6IEFjZXZlZG8gPHNpcmdhemlsQHpvaG8uY29tPsLAjgQT AQgAOBYhBAkQgnouBh5hbAasPQqw0GcBLwjDBQJkC345AhsDBQsJCAcCBhUKCQgL AgQWAgMBAh4BAheAAAoJEAqw0GcBLwjDSMMIALPFm3V9/KkzyEjoEYgtK7MNl8ce fER0K650rbenTX30/5lYwON4EFubf2cYUYwRSs8d+7Le6h035Mi13FGwwRhrDXyv zn1ifQbxBWkB4BgoIrAKvpjwOatC8+8D9zSi1giZhaoc4hggG6vkBhBB3mGx9lSL DZlghPIetNJkq4FHTFDqoFQt0ZgAZIGh46jjy4X+kSdhiNqnFSeZGFazQemdWZXS aipVx1se88aioXWlG8t6Ypr3r8vs+nAgWBYMdazymuIS4bxctSlM47zPt3E3lBwJ pdso0VjnTKfwKiWofCvTkHNO17OJegVGUQqMx6HeyinhY3nqZZaCzDIqkzfNOkx1 aXMgRmVsaXBlIEzDs3BleiBBY2V2ZWRvIDxsdWlzLmZlbGlwZS5sYUBwcm90b25t YWlsLmNvbT7CwI4EEwEIADgWIQQJEIJ6LgYeYWwGrD0KsNBnAS8IwwUCZAuABAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRAKsNBnAS8Iw3z9B/9TKed3eCaW vvPeMTeFAUcoqAiV39680Y0ppVdXTQmSBbs4QdIuABhgA7ZP9w1D8QOz8PKFCXN0 W7O2uFwuz/ZIh5yoLfY9ngtUibsjRjnLLEbRQnIAIBcwOVjTQnDC42WaZbiXqaPt WLeT48TULTMOKELc3B2mcLtrVyeDrjGe1f5nvpBb9m1JE7KtNfkPNNcQTpdsP1ru 4tg7EYWUM/oET6N2nq0Md6x/C1FPAF6l/Kskp9AmXTT01HRpjLFmnZYKiK5cuxv4 VgIkixHCuC4Y36AxnnpZ+BNS+Va9SSWBs4tvTqw6OR+ZV6DIJLRfHPoZYK5c62T8 bPNv/BQFa8IVzsBNBGQLfUoBCAC4OLfpwb7JTzA9nOrZmJHw7AljZYq9mK+GgZzp fwWwo2YyfjmAqkCa0r80Fv1Z7ypE3CVWkAvxb9OkRWKbnMpMw24o62MoGXnRszHw 8C65H5fagE1JpOoBXFZ5IM7ddsiWcOHEbFAgEDPgq8CpZORpa6Gqd850xvXZpIBN eM+Dz4BJK8LqICpO2IJHlW7T5F1IOA6MwJPCS8E3HyIt9QHFoyk+sDDGfAgWN2oe 8G6OE0m1qY8QI2bDd7Z/1m3fG1DKVacZAPuumjTdRIopiVQIZgKAOrzQQc+eiXtb mNLsbDam6TxE2m2HererWGRQw2y113jCwC2dQNJlauNWT7wBABEBAAHCwHYEGAEI ACAWIQQJEIJ6LgYeYWwGrD0KsNBnAS8IwwUCZAt9SgIbDAAKCRAKsNBnAS8Iw6gb CACQCVdwmXBqIxnqUJZ3ZYX837RFYqGmsXYn7K1QWZOSTz/TwxMWvm32DaCYAEtz XV+jAPE+ZygBUuOAT0SA4Wjsd/5gS8iqP01dhbPaKhlE+Y7hCp7Tud9uAd8OWhs7 EqEjCZyeJkFqcfq5sF5TKdpBWQ/qQrG//loAwDIOej4ayzmWDPP+wyKpBz7NV1ou P2DgZRsuSXobS5j4onVaUKRIWiflYLqTzkxysQ/Tt4ArfewjtbmDhkD4UevWXbJ1 h/YtwktCvD3EHai1w4xx+jtzS+Z1jiVW1AXNANeJP8MFC4VGu5/zdt5jUG0raFrx EjgnzKnuavTaZZVhOUYVUKv9 =3DIxoS -----END PGP PUBLIC KEY BLOCK----- --------------NdhEBNvNxVf2v5K3YmqkyXmd-- --------------diHebehVgYZ00UAxgg6Ru4g5-- --------------GB5CcFkXt06heQi0HuyIDG01 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEECRCCei4GHmFsBqw9CrDQZwEvCMMFAmUfAf0FAwAAAAAACgkQCrDQZwEvCMPG kwf7Bi09a2mVjPJyWskN8ogkMB8DXIiKkf7n3VuLbg4CUSYJ0iYGx34a7uRwv0C5zGah82TIPlMm gWWH1KOkWIk9+BNHmB5tcMTzEJ9B8tRmU4f1h5u6dprdf1onkYRt5XvAmNf/hxkQ4UlwtJpS86wS Z/G6lTMGmvnVfQmNMcivSqNJrNoelfTvLmWIdbh3Xq/stI3PhQHzvfj8tN0gOyYgKdpsfdo1gVqT zI/4vFAbhBF944qBC1aNQMww5RHVYqg8NYDDleHg+anAf9U6W9x4dZ9e5HpmhHkUtoR1Piyo4/Hf 07o74T/OP9i8KilHH363/r/wrBuDuuEh6XF7LVYGYQ== =JF1m -----END PGP SIGNATURE----- --------------GB5CcFkXt06heQi0HuyIDG01-- From unknown Tue Jun 17 01:50:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Fabio Natali Subject: bug#66336: closed (Re: bug#66336: [PATCH] gnu: guile-proba: Fix environment vars in Guile Proba's script.) Message-ID: References: <87cyxhgwo2.fsf@gnu.org> X-Gnu-PR-Message: they-closed 66336 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 66336@debbugs.gnu.org Date: Sat, 14 Oct 2023 13:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1697290202-2182-1" This is a multi-part message in MIME format... ------------=_1697290202-2182-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66336: [PATCH] gnu: guile-proba: Fix environment vars in Guile Proba's scr= ipt. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66336@debbugs.gnu.org. --=20 66336: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66336 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1697290202-2182-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66336-done) by debbugs.gnu.org; 14 Oct 2023 13:29:37 +0000 Received: from localhost ([127.0.0.1]:48184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrei0-0000Xz-Me for submit@debbugs.gnu.org; Sat, 14 Oct 2023 09:29:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrehx-0000Xh-IZ for 66336-done@debbugs.gnu.org; Sat, 14 Oct 2023 09:29:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrehT-0001IZ-RU; Sat, 14 Oct 2023 09:29:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fKsbEajoJpUbBI/m2N8nC+XDHukFbZEE09mvLIZmEXU=; b=DOp5tsIcYMpr5BuiB5m+ 1isVCjf+cDY//F0ExXiRu5N/BK3Ky/x3fyARBGa6EZyArN+l9ClPNyA3uqT9Ve/uMuWoPrj+/fCJ+ i3H5HPaUfbrop22Gm3mBPDJ4jNnuyyW1ocwVegD+UtxRZmoYUH2wAkIVkdGAVOvvyB8R12gIrpUsP 7zH/shyVTN0CsYAqD7SRI8YbEL++ha98DQEOhERI4X4/MAn7NgOOSCqRgltZvLAJUnrUm8kacmuKP eO/XhSDm8TdAWt9hIrcybzYxwmUcPmCa86ev8mNW8TQycCFIM2FARDDIHzV3kvdq8L4KGfvtSkqv2 p6tA5QinuJGiCQ==; From: Mathieu Othacehe To: Fabio Natali Subject: Re: bug#66336: [PATCH] gnu: guile-proba: Fix environment vars in Guile Proba's script. References: Date: Sat, 14 Oct 2023 15:29:01 +0200 In-Reply-To: (Fabio Natali's message of "Wed, 4 Oct 2023 11:20:30 +0100") Message-ID: <87cyxhgwo2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66336-done Cc: Luis Felipe , 66336-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > * gnu/packages/check.scm (guile-proba): Micro fix. Applied, thanks! Mathieu ------------=_1697290202-2182-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 Oct 2023 10:29:25 +0000 Received: from localhost ([127.0.0.1]:41654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnz89-0004EO-5k for submit@debbugs.gnu.org; Wed, 04 Oct 2023 06:29:25 -0400 Received: from lists.gnu.org ([2001:470:142::17]:54164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnz86-0004EA-Ex for submit@debbugs.gnu.org; Wed, 04 Oct 2023 06:29:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnz7i-0000uh-NL for guix-patches@gnu.org; Wed, 04 Oct 2023 06:28:59 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnz7g-0002aM-7p for guix-patches@gnu.org; Wed, 04 Oct 2023 06:28:58 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 793481BF206; Wed, 4 Oct 2023 10:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1696415333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hxxcgOkeJIXBItrMqzV+1sg4bFPIT0H8SWtccISvHqA=; b=NRK69SBdoKwW5JHRAeYZDwvPu0bHqdy15MahfV8oduEI2vyKfR9TbEGlnU0Fawc3cI48r4 THuf4zpcHCXJvlu5hNm33Zrkl0LyqYCp5EbW5MSiq9yuUFQmRZCpKKMrPHdFF3Oo19aS3/ XNE2ChHkvQBV0rdS5XeFVB2huPQCIr6nE33UeUWybc+LyW6zFDInCfsF106g4UT36ApvJx hl0Yg9Uq1I/5se3DCO4GMneq+v+ZTTDqjW48JhwGrM44TxmkkVAV33Lw6/yS7ZQ1iJpebE 3FRmM37TKaUvBdVSzMRiXBAGjTY7J+CZJYzx5YfVDBzJ+UyzVZRA6iHEL7EnhA== From: Fabio Natali To: guix-patches@gnu.org Subject: [PATCH] gnu: guile-proba: Fix environment vars in Guile Proba's script. Date: Wed, 4 Oct 2023 11:20:30 +0100 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: me@fabionatali.com Received-SPF: pass client-ip=217.70.183.201; envelope-from=me@fabionatali.com; helo=relay8-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Luis Felipe , Fabio Natali X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) * gnu/packages/check.scm (guile-proba): Micro fix. Guile Proba's CLI script, as created via Guix's `wrap-program', should take into account (as opposed to discard) the original, user-defined values of `GUILE_LOAD_PATH' and `GUILE_LOAD_COMPILED_PATH'. Currently, Guile Proba's CLI script is unable to find any third-party library needed by the app being tested. This micro change should fix this. --- Hi, I think there might be a slight PATH-related issue in the way guile-proba is currently packaged. Specifically, I think it should be: #+begin_src scheme :noeval `("GUILE_LOAD_PATH" prefix (,(getenv "GUILE_LOAD_PATH"))) `("GUILE_LOAD_COMPILED_PATH" prefix (,(getenv "GUILE_LOAD_COMPILED_PATH"))))))) #+end_src as opposed to the way it's now: #+begin_src scheme :noeval `("GUILE_LOAD_PATH" = (,(getenv "GUILE_LOAD_PATH"))) `("GUILE_LOAD_COMPILED_PATH" = (,(getenv "GUILE_LOAD_COMPILED_PATH"))))))) #+end_src The current version results in the following CLI program: #+begin_export ascii user@host:~/staging/guix$ guix shell --container --link-profile coreutils guile-proba -- cat ~/.guix-profile/bin/proba #!/gnu/store/9vw5slrffp27rzy2i2plnw7xfqjyk7m4-bash-minimal-5.1.16/bin/bash export GUILE_LOAD_PATH="/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/share/guile/site/3.0:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0" export GUILE_LOAD_COMPILED_PATH="/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/lib/guile/3.0/site-ccache/:/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/lib/guile/3.0/site-ccache:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0" exec -a "$0" "/gnu/store/2k854q6limcmiinqsysc7r5p3x61spcj-guile-proba-0.3.0/bin/.proba-real" "$@" #+end_export whereas I think the script should read (with this micro-patch): #+begin_export ascii user@host:~/staging/guix$ ./pre-inst-env guix shell --container --link-profile coreutils guile-proba -- cat ~/.guix-profile/bin/proba #!/gnu/store/9vw5slrffp27rzy2i2plnw7xfqjyk7m4-bash-minimal-5.1.16/bin/bash export GUILE_LOAD_PATH="/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/share/guile/site/3.0:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH" export GUILE_LOAD_COMPILED_PATH="/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/lib/guile/3.0/site-ccache/:/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/lib/guile/3.0/site-ccache:/gnu/store/wfhc8rbbmd0z25frrb5skhwcz242092i-guile-config-0.5.1/share/guile/site/3.0:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/lib/guile/3.0/site-ccache:/gnu/store/bc3zzjych6jyp4ph2af9k3w8qcs3nsn2-guile-lib-0.2.7/share/guile/site/3.0${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH" exec -a "$0" "/gnu/store/ibkh3kvhg5ky3xa9f49b48iv3wk0l1lk-guile-proba-0.3.0/bin/.proba-real" "$@" #+end_export As a result of this, currently, Guile Proba's CLI script is unable to find any third-party library needed by the app being tested. This micro change should fix this. This can be tested as follows. #+begin_export shell :noeval $ tree . ├── foo.scm └── tests └── test-main.scm #+end_export #+begin_src scheme :noeval ;; foo.scm (define-module (foo) #:use-module (ini) #:export (bar)) (define (bar) (call-with-input-string "[foo]\nbar=baz\n" ini->scm)) #+end_src #+begin_src scheme :noeval ;; test-main.scm (define-module (test-main) #:use-module (foo) #:use-module (srfi srfi-64)) (test-begin "main") (test-equal "main" (bar) '(("foo" ("bar" . "baz")))) (test-end "main") #+end_src With the above files in place: #+begin_src shell :noeval $ proba run tests [...] ice-9/boot-9.scm:3330:6: In procedure resolve-interface: no code for module (ini) #+end_src What do you think? I hope the change looks fine. Thanks, best, Fabio. gnu/packages/check.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm index 5af3b49280..e3c32c17c2 100644 --- a/gnu/packages/check.scm +++ b/gnu/packages/check.scm @@ -3599,8 +3599,8 @@ (define-public guile-proba (copy-file "proba.scm" script) (chmod script #o555) (wrap-program script - `("GUILE_LOAD_PATH" = (,(getenv "GUILE_LOAD_PATH"))) - `("GUILE_LOAD_COMPILED_PATH" = + `("GUILE_LOAD_PATH" prefix (,(getenv "GUILE_LOAD_PATH"))) + `("GUILE_LOAD_COMPILED_PATH" prefix (,(getenv "GUILE_LOAD_COMPILED_PATH"))))))) (add-after 'install 'install-manual (lambda* (#:key outputs #:allow-other-keys) base-commit: 24fc0370d0d12f34cffd44801cc6382fc5cc5f23 -- 2.41.0 ------------=_1697290202-2182-1--