GNU bug report logs - #66335
29.1.50; Additional known keywords for finder

Previous Next

To reply to this bug, email your comments to 66335 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.1.50; Additional known keywords for finder
Date: Wed, 04 Oct 2023 12:20:35 +0200

Hello,

I propose to add a few more commonly used keywords to finder.el. For
example "tree-sitter" is used by all the newly introduced major modes.
Besides that the following additional keywords might be useful and could
be added to `finder-known-keywords':

(accessibility . "Features improving accessibility")
(completion    . "Minibuffer and code completion")
(network       . "Features accessing the network")
(theme         . "Themes and styling")
(tree-sitter   . "Modes based Tree-Sitter")

For reference, a list of unknown keywords sorted by usage can be
obtained as follows:

(seq-sort-by
 #'cdr #'>
 (seq-filter (lambda (x) (> (cdr x) 1))
             (finder-unknown-keywords)))

Thanks!

In GNU Emacs 29.1.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.0, Xaw scroll bars) of 2023-10-03
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: Debian GNU/Linux trixie/sid

Message #8 received at 66335 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 66335 <at> debbugs.gnu.org
Subject: Re: bug#66335: 29.1.50; Additional known keywords for finder
Date: Wed, 04 Oct 2023 20:21:02 +0300

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Date: Wed, 04 Oct 2023 12:20:35 +0200
> 
> Hello,
> 
> I propose to add a few more commonly used keywords to finder.el. For
> example "tree-sitter" is used by all the newly introduced major modes.
> Besides that the following additional keywords might be useful and could
> be added to `finder-known-keywords':
> 
> (accessibility . "Features improving accessibility")
> (completion    . "Minibuffer and code completion")
> (network       . "Features accessing the network")
> (theme         . "Themes and styling")
> (tree-sitter   . "Modes based Tree-Sitter")

I think adding meaningful keywords is always welcome, the only problem
is to go over all the packages and add the new keywords to those which
need it.

Thanks.

Message #11 received at 66335 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 66335 <at> debbugs.gnu.org
Subject: Re: bug#66335: 29.1.50; Additional known keywords for finder
Date: Wed, 4 Oct 2023 18:43:46 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> I propose to add a few more commonly used keywords to finder.el. For
>> example "tree-sitter" is used by all the newly introduced major modes.
>> Besides that the following additional keywords might be useful and could
>> be added to `finder-known-keywords':
>>
>> (accessibility . "Features improving accessibility")
>> (completion    . "Minibuffer and code completion")
>> (network       . "Features accessing the network")
>> (theme         . "Themes and styling")
>> (tree-sitter   . "Modes based Tree-Sitter")
>
> I think adding meaningful keywords is always welcome, the only problem
> is to go over all the packages and add the new keywords to those which
> need it.

Daniel, would you like to propose a patch?

Message #14 received at 66335 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Stefan Kangas <stefankangas <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 66335 <at> debbugs.gnu.org
Subject: Re: bug#66335: 29.1.50; Additional known keywords for finder
Date: Wed, 4 Oct 2023 20:53:12 +0200

On 10/4/23 20:43, Stefan Kangas wrote:
>>> I propose to add a few more commonly used keywords to finder.el. For
>>> example "tree-sitter" is used by all the newly introduced major modes.
>>> Besides that the following additional keywords might be useful and could
>>> be added to `finder-known-keywords':
>>>
>>> (accessibility . "Features improving accessibility")
>>> (completion    . "Minibuffer and code completion")
>>> (network       . "Features accessing the network")
>>> (theme         . "Themes and styling")
>>> (tree-sitter   . "Modes based Tree-Sitter")
>>
>> I think adding meaningful keywords is always welcome, the only problem
>> is to go over all the packages and add the new keywords to those which
>> need it.
> 
> Daniel, would you like to propose a patch?

A patch to finder.el or to *all* packages? My proposal aims to add a few
keywords to finder.el, which seem to be used already, also across
ELPA/MELPA.

Besides that, the finder keyword list is not regenerated when installing
packages. This could be improved by calling `finder-compile-keywords',
taking the `finder-keywords-hash' and dumping it to some file which is
loaded by the init.el.

Daniel

Message #17 received at 66335 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Daniel Mendler <mail <at> daniel-mendler.de>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 66335 <at> debbugs.gnu.org
Subject: Re: bug#66335: 29.1.50; Additional known keywords for finder
Date: Wed, 4 Oct 2023 20:33:10 +0000

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> A patch to finder.el or to *all* packages? My proposal aims to add a few
> keywords to finder.el, which seem to be used already, also across
> ELPA/MELPA.

If we add new keywords, we should at the very least also add them to the
relevant built-in packages, I think.  It shouldn't be too many for the
above keywords, I expect?

> Besides that, the finder keyword list is not regenerated when installing
> packages. This could be improved by calling `finder-compile-keywords',
> taking the `finder-keywords-hash' and dumping it to some file which is
> loaded by the init.el.

Please file a separate feature request for this.

Message #20 received at 66335 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 66335 <at> debbugs.gnu.org, mail <at> daniel-mendler.de
Subject: Re: bug#66335: 29.1.50; Additional known keywords for finder
Date: Thu, 05 Oct 2023 08:34:58 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Wed, 4 Oct 2023 20:33:10 +0000
> Cc: 66335 <at> debbugs.gnu.org
> 
> Daniel Mendler <mail <at> daniel-mendler.de> writes:
> 
> > A patch to finder.el or to *all* packages? My proposal aims to add a few
> > keywords to finder.el, which seem to be used already, also across
> > ELPA/MELPA.
> 
> If we add new keywords, we should at the very least also add them to the
> relevant built-in packages, I think.  It shouldn't be too many for the
> above keywords, I expect?

Yes, exactly my thoughts.

Message #25 received at 66335 <at> debbugs.gnu.org (full text, mbox):

From: Rudolf Adamkovič <salutis <at> me.com>
To: Daniel Mendler <mail <at> daniel-mendler.de>, 66335 <at> debbugs.gnu.org
Subject: Re: bug#66335: 29.1.50; Additional known keywords for finder
Date: Fri, 06 Oct 2023 10:21:53 +0200

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> (tree-sitter   . "Modes based Tree-Sitter")

Note that Tree-sitter is spelled with lowercase 'l' as per:

https://tree-sitter.github.io/tree-sitter/

Rudy
-- 
"Chop your own wood and it will warm you twice."
-- Henry Ford; Francis Kinloch, 1819; Henry David Thoreau, 1854

Rudolf Adamkovič <salutis <at> me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.