From unknown Wed Jun 18 23:03:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66328 <66328@debbugs.gnu.org> To: bug#66328 <66328@debbugs.gnu.org> Subject: Status: 29.1; Incompatible change to `completing-read' breaks existing code Reply-To: bug#66328 <66328@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:03:45 +0000 retitle 66328 29.1; Incompatible change to `completing-read' breaks existin= g code reassign 66328 emacs submitter 66328 Drew Adams severity 66328 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 18:12:47 2023 Received: (at submit) by debbugs.gnu.org; 3 Oct 2023 22:12:47 +0000 Received: from localhost ([127.0.0.1]:40847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnndD-0007r2-Dm for submit@debbugs.gnu.org; Tue, 03 Oct 2023 18:12:47 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnndA-0007qo-KK for submit@debbugs.gnu.org; Tue, 03 Oct 2023 18:12:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnnck-0003vV-NP for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 18:12:14 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnnci-0006Iw-Gt for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 18:12:14 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393I4J2j013114 for ; Tue, 3 Oct 2023 22:11:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=cUuPdrnR7VzozKixKOJq6RvlK+1FYAX+IrE+hG0h+wk=; b=V22Tnvx7YXSv94TOAXMeN0GZRAU9ghR/aw409wOeIBgLjPRrPq8U6jbVnOYGnJDcA8Jb xmpF0IlCGM3+uINSSxNrhyJ4+ao9NrBTHCWUKGxrwtTBFDKwxpRfj1MwG9Du13ceEjqy 26h6MOrfmgjonjRxIkqV2OZBACt6Xrf/xfnWZ7+wIAt5q+YLTnAflJBuDbEijxU7ooTM 5vvwr3iqG8JCkLJ4rJ+BPZSBP5s+cDmFJMJzyiQC3y7khawzKRDPKnwRYwPVz3/kypXz D12pdhIZ0274VuT2CFmgmDvwND6Q4rbEjONCWTLQaraVxj59b+Fp3HWWtRAYGXWRu+IC wg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tea3edu32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 03 Oct 2023 22:11:45 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 393LwMbM005796 for ; Tue, 3 Oct 2023 22:11:44 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tea46qdx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 03 Oct 2023 22:11:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VdT1VYWcJpsjZmyMLL++9d7bO7Z7hHN/NESWigvibhA8IgSqtTxUsfXOYQBIln/GcAXdRIP0az44cGZwgj7k7IkrGrTAbhAEG4fK8ju6JYh1R7iqQN9Yge9TxFFFUgppPRNzZlEm0BthbGUrX5/uCMZbpuvvGzSZL1HhgUw9NAnwAqiCuwkHT2qdBsQDt8Vy5Cv3QIgWGnmSnN2dY59kgpJ/kJghK1NP59Ap8aEw0MZHkl+amOJU6P7xPjwtkC0Mfria4vPreCMwKhbXeYm/VuC8pNgXZRJiaw213u/6C5LferBqaBaRlE9AOPWoagwdkhnOIrs09o+y6L+7qnzuuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cUuPdrnR7VzozKixKOJq6RvlK+1FYAX+IrE+hG0h+wk=; b=M+QEgpuyPBsYiodFD+gGL455qwKYKdOhiqr7rsduPYjMrzOVRlw0TTyjoBNwgAJRVHV761M8R2NlpLPGZgIz2Dy6aXATq2+ZuDYGRQb5iYcz2ad+AdfKm7RiL5z1QFsn4pdzO2gLb8DTTxYUFL0eboSf7eV88fRhMtGkz6RwOLwQao22z5PT/VrNTYNLTuBqKOM+KLp6MzEdWCAn5bFZWemr4FPXI4lnoXIE7NO926w7RLr132z3eLO6PS2xeGEjxO8yMcT12/aJq7DBvKw8/K6tBL/0O+5X7zDzI4byXQX8dAy+46jJVlr32qXpQQUCwj4tR3or+d2HPSeJGCvMpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cUuPdrnR7VzozKixKOJq6RvlK+1FYAX+IrE+hG0h+wk=; b=oGidAQzAWpb4xLlBbeshfmhbGK/9atCiuRDLvZOjwRpjA8yIYq49EAay3qvw1L2vVJGSAXKNNG2Y3YtgNfhj6tjNYcqZo4zPO91q7Svr5hBSTmJlEV5nSEgpXOT7bu6r7YzhjfrANfzf51mcLUTaMggj6MBjnxGPYaJB4AjkQjM= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SA1PR10MB6639.namprd10.prod.outlook.com (2603:10b6:806:2b8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.29; Tue, 3 Oct 2023 22:11:41 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386%4]) with mapi id 15.20.6838.033; Tue, 3 Oct 2023 22:11:41 +0000 From: Drew Adams To: "bug-gnu-emacs@gnu.org" Subject: 29.1; Incompatible change to `completing-read' breaks existing code Thread-Topic: 29.1; Incompatible change to `completing-read' breaks existing code Thread-Index: Adn2Ros6Ehwz1+s1R6ebKttcBoDqZA== Date: Tue, 3 Oct 2023 22:11:41 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|SA1PR10MB6639:EE_ x-ms-office365-filtering-correlation-id: 7203a43a-2f8d-48a1-d994-08dbc45db8f1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MnamRDtmFnKg2SXkOyN0jX5/06dnOByiGp1P3CtOOZlSVC1p6InawD1ZSZv+yzb2HTTgaiF8/uSkCXx2MV6mi1Zgpei0e7CHdi97zD29iN9biRD3jhS87+F9G+ZXT2dLih+ytO+zuIl9YqWIidVzSF/Cr4X4GkVFsLguAw0FSdFj5fAHByynM8JssRxp0frH6EuKkvDAC8Ob5F/RvcpF6p54bBu7m5mmQGS9K/asBjU7vOPw8WMpXw1PcIn3SWZBFEpZqbfKvdV27+X0T2hU00WD3/wC5xXvcIobb+cOysp/Qbt8UAokH+W/756UgkWZYMzWxLTkzXjJagpf8Sol1nUy8/nZR9zg9L7v6dSU5txi+Mfjz7GNvsggIgs3PeIJ4rIwoA1n5N55bDVLrPbJiL5dzJKLusRDNC295l5HN5yH/ywpdfAUxlBY8GUfZq2fFQGr/86ohCFKNHKot2U4s+OHO1GCmvbPY4IyACf3AlBMvkTo55vHEfs9B2+31v0hrvyPHLKHeMXmd9BwoFjNlPsRJSYxlNpjA+rnNNaIX41Yrc2sieHBpUAc7YFC9VG3ws/J3WpObK4yiakqwq7JtbmDXS364pDKQEXRAwJ/Xg6C5A+2S9WDAWd32t3LAeoycpeWGoaK8POoa4b+blmblg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(376002)(136003)(396003)(346002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(45080400002)(478600001)(55016003)(52536014)(44832011)(5660300002)(71200400001)(6506007)(2906002)(8676002)(8936002)(66556008)(66946007)(64756008)(66476007)(316002)(6916009)(41300700001)(66446008)(76116006)(33656002)(9686003)(86362001)(7696005)(26005)(83380400001)(122000001)(38070700005)(38100700002)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C+tEwnYDIuwXZHG2CJnaXjRMw4FkKxoHfwhzXuJkZQvSATiaeJU7XhAlMq0p?= =?us-ascii?Q?P7iCwvciZFjtSCV31Mlua5a8uTpqsRB+ZNp4+NJL93NClnZmzXnMkSGmB9d/?= =?us-ascii?Q?rdhgsHCEvtmmn88oEE1OF0z5AWF/EldFRkNmyO5AXgxhARwdQTZG83hpyynH?= =?us-ascii?Q?SgLDFpA5JfqPonTFo5njwO1wE0C4djmWG53sC5XhucgXX5YJBG+l/oGjTHbM?= =?us-ascii?Q?UsClbShWyDvNt9GkDEgnBIVmzYBrDigyE7ek418oLTTkiOF4v+shg6ACnhuJ?= =?us-ascii?Q?+KwKooXKRS7A0OF8H45Jpi60kJJ9XR1PuCE/CfZ8l6IuOL0CffsJjNuT9l/Z?= =?us-ascii?Q?t7cminF619UP3c7dcC4XtHX2QgIp4vjcLuU3TItL0J7rLLhc+ha7Hxwc2pOj?= =?us-ascii?Q?2S4LhYk+9ix6U6+1erSjrVt7wqz1mXUNt8r7Jre1nbc4TpqyRlTqcNdFZTcD?= =?us-ascii?Q?LpP6hA6dJBb06dXrtcjy2Ib3z3R/Mwx6NbLJaTbGYzGb0wC4VFS4+tzgMxmm?= =?us-ascii?Q?mZkSfUIc5xW5FxEhVztM2nvXGCHH+T4Xx8gvzoUo8lx8vtTOodyRg5Gr0lva?= =?us-ascii?Q?2e3C6mdGHeFSq9m97usY7e29KZT4XTM4y8DzgdHRUzIObx3LXdMIeCag8bCE?= =?us-ascii?Q?/ZE/OabFcWiVgRyN5JJnbVivA071nAnRVqCz1upu3ju632XTkc+/zULg9KrL?= =?us-ascii?Q?ZbJdYNUYd/Bs9BJt3zKlinXsDonbBd0eHEahHWdiOKXoi4nLDGYewrssaFlK?= =?us-ascii?Q?uMVwh5C2dAJP4n7V2vmqrPFcTSkwDGkk4JdENbnWIQQZFiTwN9KSULiVPST9?= =?us-ascii?Q?A4/HiIRrd/88a6zRFJoiUrVBjHkqScUnB9FB86uJ0E+oJmBChaD5fypv+mAC?= =?us-ascii?Q?UaDTXujytkbVPp632nUKJEEPgMvXzszPVnuFClxET2yFLKyPpMSiB3N9dslW?= =?us-ascii?Q?E22xXUNvhcKuBzqiz2kW7ZEpPPTDHoo8gg0zrs051yZ3rAgDpsH7nkv48rp1?= =?us-ascii?Q?fFgbH6LenZxeDXKqlOVjT2uIhHVl54z4zDfZ2UkuwBCMHTwewWZxKuVWmnD0?= =?us-ascii?Q?JECt75XIQ78GNTKZLOwcVcdjgVdfGs6ueHfMJcsam/6mdSZrMFCQuivU52If?= =?us-ascii?Q?47V+GVapYC7bNbtwXP7fU1l+NXAbTfnDnAycILQExW9SnEvjRJnGFsPQ5nXP?= =?us-ascii?Q?TeuXlSi7LZjwHIGLg60HbuXzfQB3SY+hy9XHeakLLlIj/KyjbHE+yQ36yuOW?= =?us-ascii?Q?wVAhTpt6RJjqWxb/2MmEjj+/oCLcldx5egcWKnW6Dr5nw5HIFtUJAAvcmRDY?= =?us-ascii?Q?SjL7qzOtXuiMPN3VvfYuONqucjIacLInoTYfq7rX7EL1iVqNHwjm2/gRc5++?= =?us-ascii?Q?jm3EwoGKrT4PzTWg7R1RbJyB8AxO0SoS1X/8NOFvio8scBkd0gEMrK7djPsb?= =?us-ascii?Q?196q9CyRy96af/mkiEf8s7rCDQRWBt/iIPTclyh5lZClT7WtYCTTlyvcigcx?= =?us-ascii?Q?tjQS2KgzWRBHU/42bPURsY+c3HvSzCI3BgW4gnFAcazkt5DF3GsSG28Um0EU?= =?us-ascii?Q?QUjmYrQb5lyGdtWYhhZXx2Zo+pVTSy9wAymQ45NA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2LQJO7kwXzmxVN3mUHqdvyxLE/DRcbq5DM49gUROTi4PiofujWAnloLV+NdQ57SWkXKvpx2siOC2QgJgHLpd49l10ZsvFfkt8DhGc8K48/pnJ20BGc1tRE17Hc38u1kwUUf93HTZbBbUH7LhDK2QpVo/dSjzVp/r/usgG8f73AWU1eGGJahuAtqYZWkznySiZE6X2dB/tQK5BmpOrksBcN7ZqVA2NmW/t/UPLESRC8t2v6TNQ1i5jb7fG47rZd52uzBKi5iiURrtdzCBKKIe4YoLVkHDLQpMZambUGaemb0ocn/joQSSu/5rrnagN95xfr8BWpwqlHjqSFExzUgjU8OPEkfA1/7IS2ofw/RFBjC6dfHjJLZv/L1FLCKoHzipPz2OQAdSLFPE94n5waZaV+qet21p1BcO3P1pnNIOB7rWBcZ/iUPL1p4lP/OTg97K6+/0PgmedKQAybb86T177TT+i0ZIV1sJHxLsmhVp2hH4M51lWwbCEPCDTKx9IaqMqQqxH7GMP8LVMWDeIqlPmCK7YRmsIhjcj8+d7vDj9bnnOwMS5jiBxpG1+gYOpuK5IeV0w9rS+kBlz3oJclutA++UEIdCAGY4vcGmpYJXef5onVMPKjmptEpXqSakYxfgUSanS3nynZc4znT6mhKJ4kBVbMMZL/+Rxez0OgbRhh/XB02gsvx24cpCDw9jZoafBOZLoi8AqCfH/75JkrhfMDQi2qot6cYcy6FFYd4a0FEMA3JDZWzzhSR4hFB/g498 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7203a43a-2f8d-48a1-d994-08dbc45db8f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2023 22:11:41.6738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gSD7X7JhYPjD+AgjOM8+LzPdNnuidqYB0OVDs2bVqtJ26v/N4GdvNKgBwAIDiAd7yXA+nkG2KLZQfa0sjqaDFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6639 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-03_18,2023-10-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 mlxlogscore=596 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310030167 X-Proofpoint-ORIG-GUID: mVMtcjrqQTDXv9VE6ZvMg0mwRH03fkSR X-Proofpoint-GUID: mVMtcjrqQTDXv9VE6ZvMg0mwRH03fkSR Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) How did the signature of `completing-read' get changed? I didn't notice any proposal or discussion about this in emacs-devel@gnu.org. Did I just miss it somehow? It used to be that _any_ REQUIRE-MATCH value that is not `t', nil, `confirm', or `confirm-after-completion' behaves like `t', except that type RET doesn't exit if what you type does non-null completion. That's no longer true if the value is a function! This completely changes the behavior of `completing-read'. Not happy with the result, and not happy with how the process - how this was done, if it wasn't discussed openly in emacs-devel. In GNU Emacs 29.1 (build 2, x86_64-w64-mingw32) of 2023-08-02 built on AVALON Windowing system distributor 'Microsoft Corp.', version 10.0.19045 System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.3448) Configured using: 'configure --with-modules --without-dbus --with-native-compilation=3Daot --without-compress-install --with-tree-sitter CFLAGS=3D-O2' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB (NATIVE_COMP present but libgccjit not available) From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 19:25:50 2023 Received: (at 66328) by debbugs.gnu.org; 3 Oct 2023 23:25:50 +0000 Received: from localhost ([127.0.0.1]:40902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnoly-0003yo-DD for submit@debbugs.gnu.org; Tue, 03 Oct 2023 19:25:50 -0400 Received: from mout.gmx.net ([212.227.17.21]:49705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnolw-0003yb-A9 for 66328@debbugs.gnu.org; Tue, 03 Oct 2023 19:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1696375521; x=1696980321; i=stephen.berman@gmx.net; bh=JjTBpZixokUJw5TEmuLcoNHQJ7ECjsXeOiNArv/7IWE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=oHFq5hKcnMy6ocan/+pz1wYAZE4cDC0obRUHbR0sggyHhsKkIH2U+r5J6Dsnfyt7NprG7JvkhBZ UnUGQL6E8Sp28ZkXifBiXGUXQjYFubAIEucIo6/BXG1eMukWIwAj+MpSNILLq87WzblOmr3Ic2u0d Rsln2+Ehv43Z4TzOjpYZzjfTCBlCgQiqGkrSeIf+6mrNRNwiJ6u1653/2J80ZV/cx49iCljUVeWzC Gru6UwnQzkZ7s4qQaH/euUnaWMWNlnc5AKxxH9V9LubOyMDHPZNV87u4RtaLSXR64Rxw6QXuUbtnr iWY1qXlJkG7hAZg6asRW/JMbSmfnMVCvf/1A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.196.39]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N9MpY-1rhpcz2e1c-015Ej0; Wed, 04 Oct 2023 01:25:21 +0200 From: Stephen Berman To: Drew Adams Subject: Re: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code In-Reply-To: (Drew Adams's message of "Tue, 3 Oct 2023 22:11:41 +0000") References: Date: Wed, 04 Oct 2023 01:25:20 +0200 Message-ID: <87a5sz70gv.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:sfGqAP5/p3/hjO8AedR5HDMDwADogNQ+IQ+H43yEqTAQhIAw6v2 ycPvCIFu7v4Y7FAG6oKn0e6a29XKq3xxKwptkJIi/40OJJMJpPMGvsLOa98k/WG1o1ilj+z 27NsGkxxj27PZhtpvHL4UZ6RVVM2ZTHRFOFdH5x3OYPz1w/oMQKv2hzVo4ofbac6H1BcX3X U+oQSHNBfi/QOePZQ/LEA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:we0rEJkLFg8=;5Bs5PIbP8sIowwCEDe3U+0FdNKf I1ODKy0DUh/4aa9rDhg3vFIsFmYfUgonJ7cE677o/o01bTPye7oZ8XUIFSxoZTWGE/8C6OCxb U7fXC+sQlVIfQtBO9AQ8wbsicKjWTO7zNDiovY+HbWRPPnf2N811+MHooEqbZlBIehwRoT/qW 5WuWjhoMp4qBW1nYrAoqM9x3azf2tZapBj3w0seALQGG3y4OBLNCrIAt7iuRRZKDrdfS5PNZP 6fbuIe79jPXTFWIEk9dTAM8fkiqxssg2tPGXCcdbUjJxzoPmqX9WYe3OriLT+WC2YVJKsR2N7 YsEKiPtftH7jLSzXT675xAmsuQyvaK1V/0i3Up1UZz3BmhMljlBnoWUyMiyIX6K00TazhGACq nN2hg+plU8e8nNtAs5ehqHrer2nOUfSIjdVi3M5y/br8z+SxuubTBkt+MclQxE5/LnQ10TVFi POfm04KNgmAff8hDjjX2/LaDbfzmc2+Hg2hml/g8RQfwwaWbr+oiPDYtyJ3ZmcFq4jgyU4sWE 4p+DQ60IlQWYrh7zynv7NF44jsiegpbcgZpLcXhdlmV/XtXrwA+BaA8XH4VrqnN6f/gc8Ai2M 617B9yJIm/OzLjnCoBLqFAKiIilL7rzPVHrwlqXSJZDe08tI7gzoJJ+8iAnwzxzRC8YGIOAjU G7MaCKzd+pZkwVqa7m9MQ8M52qbbxFUfWXOoZRBNOf8O9IidwBmk689gBIrzcMH9FYDuwUUA3 +nusOoXpQfA2O/MNdbYPZdx15f1igDhqg/Iw/wm7w4YIW7NvywW29t8CXql16qE3gn9JOf0ua 4iVli4x/En//BoC3rtXPnSODhDcKKTreJyo/6BbWsxSqCQPBlk37vmXnOSSjevFaYoZ/MHQQt F5Geow/40reLieXp3Z15Xq4+YW4gY9Ew1cgxesmyMSsjoTj7S25WON7LvIc6a5I1FpCwoGX+M blet4PMX99F0g1CujQlSgbRKK5k= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66328 Cc: 66328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 3 Oct 2023 22:11:41 +0000 Drew Adams wrote: > How did the signature of `completing-read' get changed? I didn't notice > any proposal or discussion about this in emacs-devel@gnu.org. Did I > just miss it somehow? > > It used to be that _any_ REQUIRE-MATCH value that is not `t', nil, > `confirm', or `confirm-after-completion' behaves like `t', except that > type RET doesn't exit if what you type does non-null completion. > > That's no longer true if the value is a function! This completely > changes the behavior of `completing-read'. > > Not happy with the result, and not happy with how the process - how this > was done, if it wasn't discussed openly in emacs-devel. There was a short discussion, after the change was made, starting here: https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00539.html Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 22:04:26 2023 Received: (at 66328) by debbugs.gnu.org; 4 Oct 2023 02:04:26 +0000 Received: from localhost ([127.0.0.1]:41008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnrFR-0008L8-Tc for submit@debbugs.gnu.org; Tue, 03 Oct 2023 22:04:26 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:64082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnrFP-0008Kw-7l for 66328@debbugs.gnu.org; Tue, 03 Oct 2023 22:04:24 -0400 Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393I49Ic025004; Wed, 4 Oct 2023 02:04:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=ydIp7FSqdtYJLQPTAt01gqPfiMJuXk9ok+QptgNMjtU=; b=3gOYKq34ANvWtR4yjoKj7eQV+KNDHB8fjoCa1sAnwebWE8E+5WIFqvKAnmzDdX3IdHeB sXPktaEfDxnQQS0nKPK3ktbB9/5bM5qpeBJwur7a9rnuLPUOLjkgywZAGVgIkCcIrK5r 9XHUKnv4PIRqJga+DrpvRPBR2luHTag9dqfSwtEyfrFROscReqBuVe8xcRQcVsU3G0/i Ihm7VxmmLOv8jYh0vGf+sZLYd8Usic1H2UE+mY/ugSjfAlHWgNAdZ3lJWGKP7ul0Xo0n CiTIZZnABDuF3sB3qz0UmaENv0linPgQAZ2DrjSirI4qazS1vIcO0A8ovGYs8dT4KL8B 8Q== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tebqdx1pr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Oct 2023 02:04:04 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3940tDqC005824; Wed, 4 Oct 2023 02:04:03 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2047.outbound.protection.outlook.com [104.47.57.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tea46x2x2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Oct 2023 02:04:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6Z0Ug9nnhxdTDJDX9/4qsWGZvpRjSZGQK3FQrLcqDyiSV1Ratto7q1pdnSjGgOyyjxt67evq49LhUuuOj+Nbj+uKpFWO33btFMDoBDnbtO9CYlEeeD7ZrIdGcsjAG68qyGF8NgLGK0xpjyoAbgqOZnW8JsWHl6SUhDthSF5dXt9mtrpa4FZ2VMuqe8qB+rOLlcM1NYjjo7BjazXKteT4+XrzEluOPFv35XZAnV6d8DW/DoGIlo2LNnOJfHnz0eQQ1qKzDXLZUQAmL/0MIjctc6REWEIbt79pELFSLTL6+rLfCkOWUdkhtYG4oCarBI3gUL/Pw8bnW4ARdeR+pzM4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydIp7FSqdtYJLQPTAt01gqPfiMJuXk9ok+QptgNMjtU=; b=OUOxyvIXfJgC8eLLNJ8kamvaqL8Yg8k2dFfowKNacbrsaKpvxYKJnayODA2LAoTNqNPdTuXNSItfHfth9JUYUN7kcvzC1OGE6UoQF6fifAz+JLvM4eHCnCH5+LMNViPeG+c9GZsWbqZI+vUJxhrohWj8XVPtOfj1WNDgCPLj+EW8A+6Lv18uErfJxg3XYHzKT46P+4irMRsVki4Y5FLGGFANKt0UnhAWUrchlOBLf4Wbi5LWJQCXajKoeV/r5sTOi/riE7ZxFVhc7w1FKpkaMcjKGp5SnbkLAb9qHa9ifN+jltOfaKGMSbrWW9My3rgKPDhFzOKxC8oqL/mcJbQklg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ydIp7FSqdtYJLQPTAt01gqPfiMJuXk9ok+QptgNMjtU=; b=Gpuvk+MMAK8IPedBjtKpMhjMmYiZh6keSG4QDjAYxwT+l7ShyQoFcrzWviZf+Z4aOEosCY2wMNBlvHppsZKGCWtf3DqojmbnttujlKQCcfnPR5DqLfJWt1AEgc1GhkvZf79rKM1m/skNKqZWoqqw9SfxTYZAo8ik4oMaRJpcYqI= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by PH8PR10MB6648.namprd10.prod.outlook.com (2603:10b6:510:220::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Wed, 4 Oct 2023 02:04:01 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386%4]) with mapi id 15.20.6838.033; Wed, 4 Oct 2023 02:04:01 +0000 From: Drew Adams To: Stephen Berman Subject: RE: [External] : Re: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code Thread-Topic: [External] : Re: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code Thread-Index: Adn2Ros6Ehwz1+s1R6ebKttcBoDqZAAClsRPAAT0mYA= Date: Wed, 4 Oct 2023 02:04:01 +0000 Message-ID: References: <87a5sz70gv.fsf@gmx.net> In-Reply-To: <87a5sz70gv.fsf@gmx.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|PH8PR10MB6648:EE_ x-ms-office365-filtering-correlation-id: bdba9132-2cfe-433b-5df7-08dbc47e2dbb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: krZOxUVtKEOSGFXBQ3AZqprwf4If+D130sPlg/KsO5PJk9zkXsthOVX9XiF2aep6s0ov/DKrGqobAOwprfUOXdnbUaamzvfAJxIigJ2IQ8yBiOqMS63zP/nVYiADKLsNyHYXWsKR/arBzwa9KZKvDEg6gwfFf/bk9tKo4Eq7aGhvddc5lRv8kOwV2+jNVvsCyzrWYytTusolVsSzbrlUhEz9DFRMe+dDpXMh5IKb7fdX0ydVyP6jRrnSCttYNGICe9rr6mJ/kV4N4kU8N/JBeQwmuB43waVBo3qkZtKN8tMm4gdtLWUL3X5JqwkKmiZKm5vHBPHhcSYFlQbnNYRKPbkPghwgTSW2lpjx57M0dP5ZCH3WEM2A6Ep4SoSRuL50p4IYH0PidnPxBGEBvRsaKl+d4PfQ5XTY06a2RSKXd6laVdYtRbaum8XbOYoRuwWr4YIN7m8ShKf++Cgea90ugGIoADuFzQQ6Ly7m23fhWiSHiGYiZFZP8XKUKtDoTQvH7HaICh/bTgFQbKN9uneKVvtiycw1wk6YBozwyjfig2TaabZsRqPSj/5Ht8bX2fpzMAP3KNelJY9MjOOvytXEqZ3tmDSOo5EZpBqklSQ4LMpDG+pcjNnMHpEP0sUJoni1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(346002)(366004)(376002)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(41300700001)(966005)(6916009)(7696005)(6506007)(9686003)(316002)(66946007)(44832011)(66446008)(66556008)(64756008)(66476007)(76116006)(8676002)(4326008)(5660300002)(8936002)(26005)(478600001)(52536014)(71200400001)(83380400001)(2906002)(122000001)(38100700002)(55016003)(38070700005)(33656002)(86362001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IwJvv19qEMyov8NMWQzTakMlaOjkv7yykvKqhU1Ca+T/fkr+QzjOilxKtAE8?= =?us-ascii?Q?bxIOeIdLe0akfrz9vfnFTvCQdXvsuT7jo/AYidIVstPYARPaG28iPss4o7TG?= =?us-ascii?Q?z7oACB60H0p8zC1IwbCfsW5Zd2G84nbLzp/DJjksMFo/RpQ8JfT3j0JRIBqN?= =?us-ascii?Q?WNlDg0kPf5+NzVJ3ZQ8x7uvDxtTmejk3Hdgt7ww7Q2kNHwlTLC+jGC0fRmf3?= =?us-ascii?Q?PBQuNNpS1KYjQ9qf6qzE3mdKHwyHnm1nj9+pHAZ4G2ZrBACXW7oL3fr+KzS4?= =?us-ascii?Q?tWXeMg7ffeEUQZE3RDMR2dfSR3rmVDKdJJ+VAUPm/fYP9OwSt6EiHZC/ffNG?= =?us-ascii?Q?EuGpKG4aQiFfr/9tGcVE7khh5Qg96NBV8hb97lXzeRoaZOi0dNho2tHr9K4+?= =?us-ascii?Q?ws/t3Nep/0Ol25eKMUOnVjMJikqxEfmdLTveflb3mYyjel6c8z72ozmS1u6Y?= =?us-ascii?Q?Nioqb0kMlU7+bNzi6w14hV8A1kYu0tQmSNZr8SKpe58l/0p43SYkMwPqzUAZ?= =?us-ascii?Q?6kGisSIdrNoEVXJKuk31qatDkczvN4fXoMe42ogehgDUt8oMfSYBDB2ABP6B?= =?us-ascii?Q?rWN4iQGwTg3iDyRKx6NmoKLHoKFHiPPRrnZ9ZX/GR89+P50YEf+syszHOG8P?= =?us-ascii?Q?SVzViOuF+wzDnG8Au56qJmnHfVms6PAcHC4cbjFBkElHhp2Opf/hQBijxJb2?= =?us-ascii?Q?tZBFC4ATtzn1Iehr+MtXS0239eU8g17XIKhuYVgvZpwJkk822RbI9+rsJq/W?= =?us-ascii?Q?Y4R/lN6Q2UQQyeCS9eICo9FRsXf0JspIEXfJDx5cj0A0HCqBfwxbRgVkt+PC?= =?us-ascii?Q?cbplOA88itxYtz8WFKbhamQZ1ZLG0iEUfCRXoPzrvufWha9eWpedqZetU60O?= =?us-ascii?Q?WzZbXRnigP5h6HsEapbVbvwm+XDNxz567FbBqIraRFbdSVpzKA87geC3S+la?= =?us-ascii?Q?vRbU2/bi5GsWOaQkhkMFFNe9Q3Yagm0dDd4i+Bj7SpMdHh6lC1IizHf+9prP?= =?us-ascii?Q?BNkjjL/9g5ExW9sdPWFbk3YZePtmC9r+EioW9iDs0AayVWbBllc0aaxvcgUc?= =?us-ascii?Q?VB+LcB/EyUZVLzMht3CHFkuOas7JbJyUwbr3OtOUggLqkx186RXTtrszN+Rk?= =?us-ascii?Q?pA1QS4RqQSQRpKORwuFPNHKE5tegRPV9yN2iS2RH6iBT76oRysO0Mt0zgMN5?= =?us-ascii?Q?b2hkH0zVSPAU0Pfpo5OsrxTYWu9xKSwit3A+L5i5DD0e0PSU7W6btAenrgei?= =?us-ascii?Q?NIGuyal6LF9wooA8Ru838D6cd0yc31Wt3bOy/3jJ98++T0vPgjxPbdT5UL7y?= =?us-ascii?Q?yQdlVfijhvUgj+eGlJ4i8smN5gNzaKI2h2O3mbmpoj+uH2FwXeRzbczIElod?= =?us-ascii?Q?YOAAvlDUrC269xf45ZZ6dhjb6z0mmGsUnpzGaJB3EPXMuGks8DYsgGcP0gpY?= =?us-ascii?Q?/lkjmDcTD+EPt13rloEahQYBG57EQnpkH1hNUgRq8i0eGZBJjTFSGW9yYm6Y?= =?us-ascii?Q?kS0DLrtSmY5zhr0jRHU7Fjle1upWKy/YqdRvqWWfCG/UOm/lfQbP0rW+c6YY?= =?us-ascii?Q?tOIAnb0Gxc5X4lFSXPcx/Rauus6gkC8ai8fMEE1r?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KjrKUNlEY3O1D7+uiImecGWDeTeOSECZTyUDzPy6TEUjKsikWiSEEwkJmgFi8B+YuR7lCb5a5bo5UsboG0rBAKtLVI7Igo+3frHxw6xIO0+HhNZPjclmIcGPEXXYwaikzOBXUy0LbYlpDvx/0FpjyAScIoNU49ml0E5+PnD94fhC3suMPnWGQCbYW0YbXyROPSxvxl59kETC0tMrBEsOgHe77L1McttSsbBkJjhkJx1v1eSZ1ud5qgH5NytDC6EiEGZLB/PbULMwdP8AS8u0zLxMYxgwgnpomQwZ3LmwrkPLQ1aQsLLZVBRa4gzAdJUhYvzV4cYvYz9JhoPeO0LwKGT7veh3RRTX8o95ke7OAELp/7I9Zec4KfX4+RGoE1NY1HSjo3XfIlGurrSucOFPmAj92toX6HzO9xhuyo4P80ao8YNCd6iUyiscUWUf/2HPZd3GK3UocFskB5T2M50FVX7m0RYOa0nmk9FnDHAaWA8V36xqCnWng177AKqrzFljgNSO+lgpB4p6+PlJwlAGS1Z9fSKqDJc6DL0Oq6MRRlvu60Fm7Zp59/9o3kjcc4Xh4jQvsn6FUvU3UrXfU4aKPOq9yDoOKMvTw9ja4d5uRw4ZrCectmU2Og2Sk93R3nxfXHb+ttvouhAQ5s/rZ/RSnO6py6DsxYGVHfFpdVbq/j/4vkgXHrlMwGolzpK2d7kev801OGNRjzhV9nrv5kyKzEjTmnbCDc2G6qALyaMu/p7tZGYenbqq87x89NMA2BPOd/EBSX7W1QleJbmPgAcd4EjzCn/1cT2dMFd7md5tv+E= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdba9132-2cfe-433b-5df7-08dbc47e2dbb X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2023 02:04:01.4647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HF3qX5BA+kQWTfAr4XJIpup4ypUjpFvwEK9v5iq3QLUKUkr5ANRkgxqBP0h7v3csUbdqdiwDmDowjaMijsBqpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6648 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-04_01,2023-10-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310040013 X-Proofpoint-GUID: EJOpveqnFJIgyD8Ng4RNzJrWmoOqmDVi X-Proofpoint-ORIG-GUID: EJOpveqnFJIgyD8Ng4RNzJrWmoOqmDVi X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66328 Cc: "66328@debbugs.gnu.org" <66328@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > How did the signature of `completing-read' get changed? > > I didn't notice any proposal or discussion about this > > in emacs-devel@gnu.org. Did I just miss it somehow? > > > > It used to be that _any_ REQUIRE-MATCH value that is > > not `t', nil, `confirm', or `confirm-after-completion' > > behaves like `t', except that type RET doesn't exit if > > what you type does non-null completion. > > > > That's no longer true if the value is a function! > > This completely changes the behavior of `completing-read'. > > > > Not happy with the result, and not happy with how the > > process - how this was done, if it wasn't discussed > > openly in emacs-devel. >=20 > There was a short discussion, after the change was made, starting here: > https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs- > devel/2022- > 06/msg00539.html__;!!ACWV5N9M2RV99hQ!Pi4vEIugzynWXlOXCj_8GVnUyeP_8Q9i9ysV > ZwoUAmd2dc4qwMRUMS8Ce9W_d_8GAlmYBaDccZg8x2-utGVJed4B$ I see; thank you! Yes, very ugly. And no proposal or discussion; just Lars changing things. At least Stefan spoke up (though not about the basic breaking of compatibility) - after the fait accompli. I suppose I should have guessed it was something like that. Wish I'd have seen it at the time, and realized what the overall effect is. Really too bad. The justification given: "adding a new parameter for this use case seemed a bit overboard." So just break what that argument has always been about, and reuse it for something altogether different? Sigh. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 03:23:26 2023 Received: (at 66328) by debbugs.gnu.org; 4 Oct 2023 07:23:26 +0000 Received: from localhost ([127.0.0.1]:41399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnwEA-0007Jk-AF for submit@debbugs.gnu.org; Wed, 04 Oct 2023 03:23:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnwE8-0007JH-PW for 66328@debbugs.gnu.org; Wed, 04 Oct 2023 03:23:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnwDl-00076V-Qa; Wed, 04 Oct 2023 03:23:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6xSHQlhtw/Y4IA71pkHde6BE61hnc6Ma324rG0NA638=; b=iXaPCbcEyWUP IBfGEtQZA9VRQgUqY8kl3JaEIiCyUSPx9IA/gM9yAp6Oth6X2qaM3mRXaDlkUDhoa6FBj1YboFjmm qBcu7kpokLY14f1g+vxVWoBdS4jI8KvA4fsafLZvx3GCkXD5OYAbtHptQr+y8tiYQaMvMaJ99vSN4 15nNDDDjFXROfyv31P0bK9O9pPJ5SqHMZb6Mh8k3ZPbFOk0BetHamIWTUqDHdwh3Qa3woG3np+xuW woQUTcs5bpQFRlPNyOBdiAmuED8Qnn+KKXh0IoPQ0JBvv4vWYWzwjMABYxWX9fMZtFOpqEFrlJ20K e8XoVOn++UiHjMvOUkqnOQ==; Date: Wed, 04 Oct 2023 10:23:04 +0300 Message-Id: <83o7he6ecn.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-Reply-To: (message from Drew Adams on Tue, 3 Oct 2023 22:11:41 +0000) Subject: Re: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66328 Cc: 66328@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Drew Adams > Date: Tue, 3 Oct 2023 22:11:41 +0000 > > How did the signature of `completing-read' get changed? I didn't notice > any proposal or discussion about this in emacs-devel@gnu.org. Did I > just miss it somehow? It was discussed here: https://lists.gnu.org/archive/html/emacs-devel/2022-06/msg00539.html From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 03:31:39 2023 Received: (at 66328-done) by debbugs.gnu.org; 4 Oct 2023 07:31:39 +0000 Received: from localhost ([127.0.0.1]:41410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnwM6-0007Y1-LW for submit@debbugs.gnu.org; Wed, 04 Oct 2023 03:31:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnwM5-0007Xn-Iz for 66328-done@debbugs.gnu.org; Wed, 04 Oct 2023 03:31:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnwLi-0003KU-9Z; Wed, 04 Oct 2023 03:31:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ej87ANPJKBR8EuVwpV8hXRrx1votOU+ybrylveCkt00=; b=k/7k5w8df9+Q bSmCwxjSryDMOvVvMdEjkhEuNn2rNyLpGHvm65BIjz7A0Mb1wNCfIVbfFN6LS1CacSkqYLub7+vAo 8DMejbI1yqExHM8CEpirgnDe7LrPCM8Hv9FBqu0QoGxyxXAWsML2ufk896qtDutwXu7yMEQbHDA2s 6T/HMN5xxrUP/RJ9G3WDHQVQ6LygnwmMnnFx0oQlDD5m0BKe38Uel9Nkw/4MZWHidbncZtatsNsM4 R3MEqsi7wbhLxoi4rV3GidXvfeki3+oY7rq9lkwK6AJfAQnzOqAsFcrunpKSb4eF80lR37CgQ06gG wSHittRthQXnv1mpL+ayRw==; Date: Wed, 04 Oct 2023 10:31:12 +0300 Message-Id: <83leci6dz3.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-Reply-To: (message from Drew Adams on Wed, 4 Oct 2023 02:04:01 +0000) Subject: Re: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code References: <87a5sz70gv.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66328-done Cc: 66328-done@debbugs.gnu.org, stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: "66328@debbugs.gnu.org" <66328@debbugs.gnu.org> > From: Drew Adams > Date: Wed, 4 Oct 2023 02:04:01 +0000 > > > > How did the signature of `completing-read' get changed? > > > I didn't notice any proposal or discussion about this > > > in emacs-devel@gnu.org. Did I just miss it somehow? > > > > > > It used to be that _any_ REQUIRE-MATCH value that is > > > not `t', nil, `confirm', or `confirm-after-completion' > > > behaves like `t', except that type RET doesn't exit if > > > what you type does non-null completion. > > > > > > That's no longer true if the value is a function! > > > This completely changes the behavior of `completing-read'. > > > > > > Not happy with the result, and not happy with how the > > > process - how this was done, if it wasn't discussed > > > openly in emacs-devel. > > > > There was a short discussion, after the change was made, starting here: > > https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs- > > devel/2022- > > 06/msg00539.html__;!!ACWV5N9M2RV99hQ!Pi4vEIugzynWXlOXCj_8GVnUyeP_8Q9i9ysV > > ZwoUAmd2dc4qwMRUMS8Ce9W_d_8GAlmYBaDccZg8x2-utGVJed4B$ > > I see; thank you! > > Yes, very ugly. And no proposal or discussion; > just Lars changing things. At least Stefan > spoke up (though not about the basic breaking > of compatibility) - after the fait accompli. > > I suppose I should have guessed it was something > like that. Wish I'd have seen it at the time, > and realized what the overall effect is. > > Really too bad. > > The justification given: "adding a new parameter > for this use case seemed a bit overboard." So > just break what that argument has always been > about, and reuse it for something altogether > different? Sigh. I see no reason to revert that change, so I'm closing this bug. From unknown Wed Jun 18 23:03:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 01 Nov 2023 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator