From unknown Wed Jun 18 23:14:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66327 <66327@debbugs.gnu.org> To: bug#66327 <66327@debbugs.gnu.org> Subject: Status: PARTED_CHECK_LIBPARTED shipped with parted 3.6 fails to detect it Reply-To: bug#66327 <66327@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:14:03 +0000 retitle 66327 PARTED_CHECK_LIBPARTED shipped with parted 3.6 fails to detec= t it reassign 66327 parted submitter 66327 Jan Palus severity 66327 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 13:24:22 2023 Received: (at submit) by debbugs.gnu.org; 3 Oct 2023 17:24:22 +0000 Received: from localhost ([127.0.0.1]:40646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnj89-0008Sa-1b for submit@debbugs.gnu.org; Tue, 03 Oct 2023 13:24:22 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnimv-0007vP-Lq for submit@debbugs.gnu.org; Tue, 03 Oct 2023 13:02:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnimX-0003yw-Ra for bug-parted@gnu.org; Tue, 03 Oct 2023 13:02:02 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnimW-0001Rl-2p for bug-parted@gnu.org; Tue, 03 Oct 2023 13:02:01 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E4B943200B83; Tue, 3 Oct 2023 13:01:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 03 Oct 2023 13:01:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1696352515; x=1696438915; bh=BlGzVuj7qRmbMZ9/Y3FoADKTf 7cjPu2CL73KBjHe+rc=; b=COrjH0eWZySXnSq9wYwCt+6RMAPfk/4VbLB7/f+5N Xual6Cgmz+Z+V0cXdjk7QY5vsHGn5snMMlnOnu5pL639gbUVbOIrO5KNqbfBDutE lFQnR+dVhIxuyg7nZmxO7YufYEJ/Ej4o7j1hqRrIVoneT1TaBYshALhDhCuL9sUZ 5gYIpF1HES1E39GeK42C6Eq/+A6CfQ5mVVdl7zMulJ5fnhDwAf2RnkcOoptOlm5a Qt20w9WKkP/GMCCgoRUUBEKCWt+3Co7EjiEG1p7FV5tyEzXLBFp+N825vIPE0PcN cTclz9z2OAW+lRnZFhGfH49ZEdLU7VHn8qylVqXXVUsZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1696352515; x=1696438915; bh=BlGzVuj7qRmbMZ9/Y3FoADKTf7cjPu2CL73 KBjHe+rc=; b=mtEpOtupRSMuS8t+hZlO5I1cZMmwtynS9GIbZnIpTAcAfYeTQDI +pvwKZFh7hnTvvM8xhRnnsfrl4FHgf5v/jPsx8Yz95bTemsbJSBZuqvADBTEfopp qUZpl5BvLCYxwSSgZc9VNinMyvO4QI/7XqQPTt0w417dE/i5ElHYt/zt2KrWmNg/ VV7NjHp3zh+4LTyX6DTCcJjCss6AcFHxmuQcVq3oaok49lbqdZwyd6raRgfh//HL rPWiQ8xYsYLt8FHu/pmiSiv73kHNQdvhMHZaavz6ZDARh7K0XBDejWTp3SRHP33R 76oEZe9v9sQmsin5DIHdOaVezfRONqkByFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfeejgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggufgesthdtsfdttd erjeenucfhrhhomheplfgrnhcurfgrlhhushcuoehjphgrlhhushesfhgrshhtmhgrihhl rdgtohhmqeenucggtffrrghtthgvrhhnpeejieduueeifeetkeeguedugfdttddtkedutd fhjedtfefhffegvddtjefhkeejffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehjphgrlhhushesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i01894241:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 3 Oct 2023 13:01:54 -0400 (EDT) Date: Tue, 3 Oct 2023 19:01:52 +0200 From: Jan Palus To: bug-parted@gnu.org Subject: PARTED_CHECK_LIBPARTED shipped with parted 3.6 fails to detect it Message-ID: <63db4qew2wgsojf7tdka4h6wfnuvw2iw6pzmkyylckcpabmyxq@xabnjw6to2n3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: NeoMutt/20230517 Received-SPF: pass client-ip=64.147.123.20; envelope-from=jpalus@fastmail.com; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 03 Oct 2023 13:24:19 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) autoconf macro PARTED_CHECK_LIBPARTED requires ped_get_version() to return 3 part version string or otherwise it fails with "3.6, bad version string" if ( !(version = ped_get_version ()) ) exit(EXIT_FAILURE); if (sscanf(version, "%d.%d.%d", &major, &minor, µ) != 3) { printf("%s, bad version string\n", version); exit(EXIT_FAILURE); } Therefore it fails for two part version string like "3.6". From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 04 16:52:41 2023 Received: (at 66327) by debbugs.gnu.org; 4 Oct 2023 20:52:41 +0000 Received: from localhost ([127.0.0.1]:45461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qo8rI-0003eW-OF for submit@debbugs.gnu.org; Wed, 04 Oct 2023 16:52:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:33094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qo8rH-0003eN-10 for 66327@debbugs.gnu.org; Wed, 04 Oct 2023 16:52:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696452740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AR1taM3Wm97F7XyspK2mSeBhoQLIxLiNNEY+OtNpYw0=; b=NlnFTv8NF3AaemiCj7QhNOCtCi8d70V7aNu3poGGcKuijJgypEbzuKbsf+YOpS1upPdSdm WEk5TJiEsGUq1FKsh6kbDinP6PVo5gcy1lQPr/orAYSCaoX3QrvscE1E5B0MTAT9Y3lc7p j5YBWkuFHRmNzaxwOfvowZoCcTd5OO8= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-bQsZB9ugMIWokII12QRcVA-1; Wed, 04 Oct 2023 16:52:08 -0400 X-MC-Unique: bQsZB9ugMIWokII12QRcVA-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1c60d6f2c6bso11121825ad.0 for <66327@debbugs.gnu.org>; Wed, 04 Oct 2023 13:52:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696452726; x=1697057526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AR1taM3Wm97F7XyspK2mSeBhoQLIxLiNNEY+OtNpYw0=; b=SoDdZBm9n9VW7U5ukqL1mfA8CfGQIAAUVy2/+rjMk35jGnBLzO8Ff6IxYOcg3wZ1CL cduGu9NdEK2Ivqjd4XfPsgSOROogOZFHdkvCxUVA0Przd7zgWxDeirGSXGT4KpZuR9HS 6G+NxURWJDUAkFuA/Cq+9juSSVGK01p74tHln6XUErBrzkVCXKijP06ZKO6P8KU0aO49 lahobDCudJWTX0rcNvUDSLQsB473nXivNlX6qmaV7dD8C5Wey/GRqJ1XAemuQyibsc/l 7LHBQh87jJZZnFQyW3OQtiJJVFj4m0ms6virc9Crl/I6TcYJF1p3SdRBXeHDG6K3ZKMo 59FQ== X-Gm-Message-State: AOJu0Yz9hOj8Y/kgxzBhHWLbxff9WZDIkvpVNEtEtRuNdN7ezzLH9mH5 +TFcx1KZvH1Ta3Zb7isQFc121tfwz+lf9aB37J/K6TnuWTevXe86IjkjJilgeFDYbhPBZT2kbpy fCg46tsNCUfVzkYE= X-Received: by 2002:a17:903:41c4:b0:1c5:7d49:570e with SMTP id u4-20020a17090341c400b001c57d49570emr1102644ple.29.1696452726589; Wed, 04 Oct 2023 13:52:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECG8+ybQ+eRc/FBl1kse9CUWUjM27Gpv42uDblrFTewZILgj2jzDE9Q8QBQaVMZHFKGnSc4A== X-Received: by 2002:a17:903:41c4:b0:1c5:7d49:570e with SMTP id u4-20020a17090341c400b001c57d49570emr1102623ple.29.1696452726100; Wed, 04 Oct 2023 13:52:06 -0700 (PDT) Received: from ohop.brianlane.com ([2601:603:5000:103:52e5:49ff:fe52:c5be]) by smtp.gmail.com with ESMTPSA id a11-20020a1709027d8b00b001b89536974bsm4152641plm.202.2023.10.04.13.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 13:52:05 -0700 (PDT) Date: Wed, 4 Oct 2023 13:52:03 -0700 From: "Brian C. Lane" To: Jan Palus Subject: Re: bug#66327: PARTED_CHECK_LIBPARTED shipped with parted 3.6 fails to detect it Message-ID: References: <63db4qew2wgsojf7tdka4h6wfnuvw2iw6pzmkyylckcpabmyxq@xabnjw6to2n3> MIME-Version: 1.0 In-Reply-To: <63db4qew2wgsojf7tdka4h6wfnuvw2iw6pzmkyylckcpabmyxq@xabnjw6to2n3> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66327 Cc: 66327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Oct 03, 2023 at 07:01:52PM +0200, Jan Palus wrote: > autoconf macro PARTED_CHECK_LIBPARTED requires ped_get_version() to > return 3 part version string or otherwise it fails with "3.6, bad > version string" > > if ( !(version = ped_get_version ()) ) > exit(EXIT_FAILURE); > if (sscanf(version, "%d.%d.%d", &major, &minor, µ) != 3) { > printf("%s, bad version string\n", version); > exit(EXIT_FAILURE); > } > > Therefore it fails for two part version string like "3.6". > > > Thanks for the report. Where is this causing problems for you? As far as I can tell that code has been there since the start of the git history, and I've never seen a failure. I'm actually not sure it ever gets called by anything -- nothing uses the PARTED_CHECK_LIBPARTED macro in the upstream code. I'm inclined to just delete it. Brian -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 01:03:43 2023 Received: (at 66327) by debbugs.gnu.org; 6 Oct 2023 05:03:43 +0000 Received: from localhost ([127.0.0.1]:49010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qod01-00016f-UB for submit@debbugs.gnu.org; Fri, 06 Oct 2023 01:03:43 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoWal-0006Mo-B6 for 66327@debbugs.gnu.org; Thu, 05 Oct 2023 18:13:13 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BECFC5C02EB; Thu, 5 Oct 2023 18:12:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 05 Oct 2023 18:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1696543966; x=1696630366; bh=PC 05iylSFaBPOEL2LvLSx3NRB8RZcVJawdbVpysmEcg=; b=TE7Y4FoMQSyBxnBLz1 xd1zsG2sjydhEWuDAMqDbYk04Z4kbwnA8tkk4QbMyJoWRob6VFkH03oVn/xpiCax 1T85YA9XTj4w346Vf8ZVw9fkQPx6R+dsR978w7TgKWJWNsMSzd4b9eeB7u6LBy57 eSI7xAEMbbLloV7abCHyyXdjDqkA2h97Zxu4XK9goKsGVD9Z/u6cfEegOQCO57pC xx80daKQdQXOjaWUzdho6d+S4Y+PQZlIUqkRLzfKoRHwANXRxgM0pAr6FqqItl8+ WrrBp7T/hz4COm20iazgEow6EDVoxgVWkgvV2hIVgKPTQzN1XCC2OQGbzx6g7I2F h4Ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696543966; x=1696630366; bh=PC05iylSFaBPO EL2LvLSx3NRB8RZcVJawdbVpysmEcg=; b=jTI46VfKbtkTPzQxBmu9x8m8df8b2 K0jDiTFKM0+sjxGgwjStKYnNA7H8OjR2e9XNBrpdvm7NATbB4n0BwKzeAzTQ9kVN gWovfeQAd4VIhD//w2XiScG8fHhG/zVt2kPXlDD7yj/AuZQCOJygwHykkX53jljK 030ij70B6+z4K+tZemeEWqQlHTnqoags18htDqVDvUkRWPCdPhqCy3uFfAxXoVJT FPyHZmFk+IZ7pbK9BzdNErHMhvjjtzPaxXbTp8grKo2pNaajX5/ORkD6zbTYceMT wPypp5rkt5FwmbWX7L90oVIbIO4Aknr+nHBGKRKjYiBvDjH2Dqf1VrOHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrgeehgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujggfsehttd fstddtreejnecuhfhrohhmpeflrghnucfrrghluhhsuceojhhprghluhhssehfrghsthhm rghilhdrtghomheqnecuggftrfgrthhtvghrnheptdekgfehfffhgfeghedvffduvdeite eiieehvdfffeelkeetgedujeegfeejueeunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepjhhprghluhhssehfrghsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: i01894241:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 Oct 2023 18:12:46 -0400 (EDT) Date: Fri, 6 Oct 2023 00:12:44 +0200 From: Jan Palus To: "Brian C. Lane" Subject: Re: bug#66327: PARTED_CHECK_LIBPARTED shipped with parted 3.6 fails to detect it Message-ID: References: <63db4qew2wgsojf7tdka4h6wfnuvw2iw6pzmkyylckcpabmyxq@xabnjw6to2n3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20230517 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 66327 X-Mailman-Approved-At: Fri, 06 Oct 2023 01:03:39 -0400 Cc: 66327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 04.10.2023 13:52, Brian C. Lane wrote: > On Tue, Oct 03, 2023 at 07:01:52PM +0200, Jan Palus wrote: > > autoconf macro PARTED_CHECK_LIBPARTED requires ped_get_version() to > > return 3 part version string or otherwise it fails with "3.6, bad > > version string" > > > > if ( !(version = ped_get_version ()) ) > > exit(EXIT_FAILURE); > > if (sscanf(version, "%d.%d.%d", &major, &minor, µ) != 3) { > > printf("%s, bad version string\n", version); > > exit(EXIT_FAILURE); > > } > > > > Therefore it fails for two part version string like "3.6". > > > > > > > > Thanks for the report. Where is this causing problems for you? As far as > I can tell that code has been there since the start of the git history, > and I've never seen a failure. I'm actually not sure it ever gets called > by anything -- nothing uses the PARTED_CHECK_LIBPARTED macro in the > upstream code. > > I'm inclined to just delete it. Noticed the issue when checking original fatresize codebase. Don't get me wrong I'm completely fine with either fixing or dropping it entirely. I just don't think it should be shipped in current shape. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 11:16:01 2023 Received: (at 66327) by debbugs.gnu.org; 6 Oct 2023 15:16:02 +0000 Received: from localhost ([127.0.0.1]:52398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qomYb-0004ZD-59 for submit@debbugs.gnu.org; Fri, 06 Oct 2023 11:16:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qomYY-0004Tg-QZ for 66327@debbugs.gnu.org; Fri, 06 Oct 2023 11:15:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696605339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Si7a/3DYr/iIG19fJYTxEbqvCgYxI1c+gdy7lzpVVh0=; b=cDSuKkSdwD9pdF/Yj1IrOC20Emz8CoMBZcNs8WQK/NBcO3R8JezW1BN/Hb4bbiOYjWdhBd /FyLxjQX9SUpQvRJOxVzQVGHlYZoCXXg7KXeMxgjzmUiNBj+j/ZXJaL6TJJMPxDcth8zNZ J+WF9/oC0gUHXMI0u/BROblNW17XO7Y= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-t-m7hHHGO2uQxVRnyY2xMQ-1; Fri, 06 Oct 2023 11:15:27 -0400 X-MC-Unique: t-m7hHHGO2uQxVRnyY2xMQ-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-27714a9f192so2120434a91.1 for <66327@debbugs.gnu.org>; Fri, 06 Oct 2023 08:15:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696605326; x=1697210126; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Si7a/3DYr/iIG19fJYTxEbqvCgYxI1c+gdy7lzpVVh0=; b=LcQN+XLzT5CA/beIO+rLLudvtS6hh5gK0mos4LjiB0U3je8M+yRlDe9VFxGSE8o+XJ YTu3l9YHSW9T5TAOmFA5A7Dht25NpEjpT3omtuR8rdQsVxeB8I4bc3LwlC0YrMzP3HoJ Y6eJ/wsn6H3bWjb2M98M4oGFcXke0J9MIBMYW7L+6b1oTDScAipaw0Ki9kxoUiOg3XXH lH7h0tq1wmEwyD/1VXolcrdK5E4VFZ+e14A4EulZWJh2KV46vt7KYL/SFsyvvIJLcLy7 kGXjTph9CbZKl8MgdrBxJxgmsjVEJaWY85cMSmUD83K4FpaEW8yl5U8ALaqaNtVod8YB 7P2Q== X-Gm-Message-State: AOJu0YzUcu4yDEE3ysltStzesh+RV3zT5og8e04Ucd+q7PPJ9Y44OuMv 1QXtY4utARUAT5hYFLk5YwJ6GXLsm2kICN0ry0o9mmlTWsmquxCMUZwpY261jWEtXn67IuRbViC sDNXnB8qBR93/36A= X-Received: by 2002:a17:90a:7bcf:b0:279:e19:86db with SMTP id d15-20020a17090a7bcf00b002790e1986dbmr8860387pjl.8.1696605326485; Fri, 06 Oct 2023 08:15:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8a6R+wSMH9X0Ijs/eaIt1OGnDnGKGcaAcGeQkHuG2YqAFGAT2DJcUTkoaZLUi/X2Yr4UHOQ== X-Received: by 2002:a17:90a:7bcf:b0:279:e19:86db with SMTP id d15-20020a17090a7bcf00b002790e1986dbmr8860354pjl.8.1696605326091; Fri, 06 Oct 2023 08:15:26 -0700 (PDT) Received: from ohop.brianlane.com ([2601:603:5000:103:52e5:49ff:fe52:c5be]) by smtp.gmail.com with ESMTPSA id 6-20020a17090a1a4600b0026d54b2abe9sm3878017pjl.37.2023.10.06.08.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 08:15:25 -0700 (PDT) Date: Fri, 6 Oct 2023 08:15:23 -0700 From: "Brian C. Lane" To: Jan Palus Subject: Re: bug#66327: PARTED_CHECK_LIBPARTED shipped with parted 3.6 fails to detect it Message-ID: References: <63db4qew2wgsojf7tdka4h6wfnuvw2iw6pzmkyylckcpabmyxq@xabnjw6to2n3> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66327 Cc: 66327@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, Oct 06, 2023 at 12:12:44AM +0200, Jan Palus wrote: > On 04.10.2023 13:52, Brian C. Lane wrote: > > On Tue, Oct 03, 2023 at 07:01:52PM +0200, Jan Palus wrote: > > > autoconf macro PARTED_CHECK_LIBPARTED requires ped_get_version() to > > > return 3 part version string or otherwise it fails with "3.6, bad > > > version string" > > > > > > if ( !(version = ped_get_version ()) ) > > > exit(EXIT_FAILURE); > > > if (sscanf(version, "%d.%d.%d", &major, &minor, µ) != 3) { > > > printf("%s, bad version string\n", version); > > > exit(EXIT_FAILURE); > > > } > > > > > > Therefore it fails for two part version string like "3.6". > > > > > > > > > > > > > Thanks for the report. Where is this causing problems for you? As far as > > I can tell that code has been there since the start of the git history, > > and I've never seen a failure. I'm actually not sure it ever gets called > > by anything -- nothing uses the PARTED_CHECK_LIBPARTED macro in the > > upstream code. > > > > I'm inclined to just delete it. > > Noticed the issue when checking original fatresize codebase. Don't get > me wrong I'm completely fine with either fixing or dropping it entirely. > I just don't think it should be shipped in current shape. > Ah, ok. Wanted to make sure it wasn't something you were depending on somehow :) This codebase is *really* old at this point so there are bound to be unused corners like this -- especially if it isn't used and this looks like it never would have worked, the first release in git is 1.8 Thanks, Brian -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart