GNU bug report logs - #6632
23.2.50; dired-mode should use [remap ...] instead of hard-coded overriding of global key bindings

Previous Next

Package: emacs;

Reported by: Teemu Likonen <tlikonen <at> iki.fi>

Date: Wed, 14 Jul 2010 16:01:01 UTC

Severity: normal

Found in version 23.2.50

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6632 in the body.
You can then email your comments to 6632 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6632; Package emacs. (Wed, 14 Jul 2010 16:01:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Teemu Likonen <tlikonen <at> iki.fi>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 14 Jul 2010 16:01:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2.50; dired-mode should use [remap ...] instead of hard-coded
	overriding of global key bindings
Date: Wed, 14 Jul 2010 18:58:13 +0300

[Message part 1 (text/plain, inline)]
dired-mode uses hard-coding when it rebinds some global key bindings.
For example, there is the following line in dired.el file:

    (define-key map "\C-n" 'dired-next-line)

Therefore it overrides the global C-n key, whatever its command is in
user's keymap. The command should be bound like this:

    (define-key map [remap next-line] 'dired-next-line)

Using [remap ...] is preferred because it makes it possible for user to
redefine the global keymap they way she wishes and keys will still
automatically get their mode-specific behaviour. The attached patch
fixes this for dired-mode.


[dired-mode-remap.diff (text/x-diff, attachment)]
Reply sent to Juanma Barranquero <lekktu <at> gmail.com>:
You have taken responsibility. (Thu, 22 Jul 2010 11:57:01 GMT) Full text and rfc822 format available.
Notification sent to Teemu Likonen <tlikonen <at> iki.fi>:
bug acknowledged by developer. (Thu, 22 Jul 2010 11:57:02 GMT) Full text and rfc822 format available.

Message #10 received at 6632-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Teemu Likonen <tlikonen <at> iki.fi>
Cc: 6632-done <at> debbugs.gnu.org
Subject: Re: bug#6632: 23.2.50; dired-mode should use [remap ...] instead of 
	hard-coded overriding of global key bindings
Date: Thu, 22 Jul 2010 13:57:00 +0200

On Wed, Jul 14, 2010 at 17:58, Teemu Likonen <tlikonen <at> iki.fi> wrote:

> The attached patch fixes this for dired-mode.

Committed, thanks.

    Juanma
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 20 Aug 2010 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 358 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.