From unknown Sun Jun 22 11:31:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66296 <66296@debbugs.gnu.org> To: bug#66296 <66296@debbugs.gnu.org> Subject: Status: [PATCH] pack: Allow setting a custom image tag for Docker images Reply-To: bug#66296 <66296@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:31:17 +0000 retitle 66296 [PATCH] pack: Allow setting a custom image tag for Docker ima= ges reassign 66296 guix-patches submitter 66296 soeren@soeren-tempel.net severity 66296 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 01 09:07:12 2023 Received: (at submit) by debbugs.gnu.org; 1 Oct 2023 13:07:12 +0000 Received: from localhost ([127.0.0.1]:60868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmwAB-0007wa-JJ for submit@debbugs.gnu.org; Sun, 01 Oct 2023 09:07:12 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmwA9-0007w1-4p for submit@debbugs.gnu.org; Sun, 01 Oct 2023 09:07:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmw9k-0007MG-RC for guix-patches@gnu.org; Sun, 01 Oct 2023 09:06:45 -0400 Received: from magnesium.8pit.net ([45.76.88.171]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmw9i-0007aW-7z; Sun, 01 Oct 2023 09:06:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=opensmtpd; bh=k3De1y4apY c1PiMfD833NBP1dFa5SlGFLO/fnSY18qs=; h=date:subject:to:from; d=soeren-tempel.net; b=fbg95GBXDrtnuMN0VFuibu1ip++DY/vsr40EW4C95FlhDWh 9x+OHFcaSzPiQK4ipvkal6OdUKkw/Z+1JHeW4IBT0lqWj/E/ZdsFKIFzAH++9KIwCegLe1 RrkHzqYV6Ph1RcaYdU8rKOfcHB/Fds5iBAG3jycF2nGyveImUvv1AI= Received: from localhost (dynamic-2a02-3102-49da-001b-268f-6598-9e92-70b5.310.pool.telefonica.de [2a02:3102:49da:1b:268f:6598:9e92:70b5]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id fffc4d4e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sun, 1 Oct 2023 15:06:35 +0200 (CEST) From: soeren@soeren-tempel.net To: guix-patches@gnu.org Subject: [PATCH] pack: Allow setting a custom image tag for Docker images Date: Sun, 1 Oct 2023 15:06:15 +0200 Message-ID: <20231001130615.18132-1-soeren@soeren-tempel.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=45.76.88.171; envelope-from=soeren@soeren-tempel.net; helo=magnesium.8pit.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) From: Sören Tempel Previously, the image repository name was automatically computed from the packages in the manifest without allowing the user to set a custom one. As such, changing the packages in the manifest would result in a new image name. Thereby requiring updating documentation et cetera when using `docker load` directory on the resulting image. Inspired by `docker build -t`, this commit adds a new Docker-specific option to `guix pack` which allows setting a custom repository name for the resulting image. If this option is not specified, pack falls back to computing the name from the manifest. Therefore, this change is entirely backwards compatible. * guix/scripts/pack.scm (guix-pack): add --image-tag option * guix/scripts/pack.scm (%docker-format-options): new constant * guix/scripts/pack.scm (show-docker-format-options): new procedure * guix/scripts/pack.scm (show-docker-format-options/detailed): new procedure * guix/scripts/pack.scm (docker-image): allow setting a custom repository name for the created docker image via extra-options. Signed-off-by: Sören Tempel --- guix/scripts/pack.scm | 66 ++++++++++++++++++++++++++++++------------- 1 file changed, 46 insertions(+), 20 deletions(-) diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm index 01995c48b7..e7005e7bc6 100644 --- a/guix/scripts/pack.scm +++ b/guix/scripts/pack.scm @@ -507,7 +507,7 @@ (define* (docker-image name profile image is a tarball conforming to the Docker Image Specification, compressed with COMPRESSOR. It can be passed to 'docker load'. If TARGET is true, it must a be a GNU triplet and it is used to derive the architecture metadata in -the image." +the image. EXTRA-OPTIONS may contain the IMAGE-TAG keyword argument." (define database (and localstatedir? (file-append (store-database (list profile)) @@ -531,7 +531,7 @@ (define build (guix build utils) (guix profiles) (guix search-paths) (srfi srfi-1) (srfi srfi-19) - (ice-9 match)) + (ice-9 match) (ice-9 optargs)) #$(procedure-source manifest->friendly-name) @@ -560,23 +560,26 @@ (define directives (setenv "PATH" #+(file-append archiver "/bin")) - (build-docker-image #$output - (map store-info-item - (call-with-input-file "profile" - read-reference-graph)) - #$profile - #:repository (manifest->friendly-name - (profile-manifest #$profile)) - #:database #+database - #:system (or #$target %host-type) - #:environment environment - #:entry-point - #$(and entry-point - #~(list (string-append #$profile "/" - #$entry-point))) - #:extra-files directives - #:compressor #+(compressor-command compressor) - #:creation-time (make-time time-utc 0 1)))))) + (let-keywords '#$extra-options #f + ((image-tag #f)) + (build-docker-image #$output + (map store-info-item + (call-with-input-file "profile" + read-reference-graph)) + #$profile + #:repository (or image-tag + (manifest->friendly-name + (profile-manifest #$profile))) + #:database #+database + #:system (or #$target %host-type) + #:environment environment + #:entry-point + #$(and entry-point + #~(list (string-append #$profile "/" + #$entry-point))) + #:extra-files directives + #:compressor #+(compressor-command compressor) + #:creation-time (make-time time-utc 0 1))))))) (gexp->derivation (string-append name ".tar" (compressor-extension compressor)) @@ -1287,6 +1290,20 @@ (define (required-option symbol) (alist-cons symbol arg result) rest)))) +(define %docker-format-options + (list (required-option 'image-tag))) + +(define (show-docker-format-options) + (display (G_ " + --help-docker-format list options specific to the docker format"))) + +(define (show-docker-format-options/detailed) + (display (G_ " + --image-tag=NAME + Use the given NAME for the Docker image repository")) + (newline) + (exit 0)) + (define %deb-format-options (list (required-option 'control-file) (required-option 'postinst-file) @@ -1407,6 +1424,10 @@ (define %options (lambda (opt name arg result) (alist-cons 'bootstrap? #t result))) + (option '("help-docker-format") #f #f + (lambda args + (show-docker-format-options/detailed))) + (option '("help-deb-format") #f #f (lambda args (show-deb-format-options/detailed))) @@ -1415,7 +1436,8 @@ (define %options (lambda args (show-rpm-format-options/detailed))) - (append %deb-format-options + (append %docker-format-options + %deb-format-options %rpm-format-options %transformation-options %standard-build-options @@ -1433,6 +1455,7 @@ (define (show-help) (newline) (show-transformation-options-help) (newline) + (show-docker-format-options) (show-deb-format-options) (show-rpm-format-options) (newline) @@ -1586,6 +1609,9 @@ (define (process-file-arg opts name) manifest))) (pack-format (assoc-ref opts 'format)) (extra-options (match pack-format + ('docker + (list #:image-tag + (assoc-ref opts 'image-tag))) ('deb (list #:control-file (process-file-arg opts 'control-file) From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 14 04:23:43 2023 Received: (at 66296) by debbugs.gnu.org; 14 Oct 2023 08:23:43 +0000 Received: from localhost ([127.0.0.1]:47836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZvz-0006y0-99 for submit@debbugs.gnu.org; Sat, 14 Oct 2023 04:23:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrZvv-0006vL-GT for 66296@debbugs.gnu.org; Sat, 14 Oct 2023 04:23:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrZvR-0003rT-Vx; Sat, 14 Oct 2023 04:23:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=o2xJLhjHSVN98Nxo9ZuUze1NwiccAY51c3MHfSYbLgQ=; b=IkgW7SozCjwkYhOGhLJm hnMLpIWQbnviF5//Yxp7s2l8og2tmhKsEYupl6V+tA6pDXFIbEBg4MyYeERUckVNQaSNIE3esznPc YviV1pQ0qeoGJXLty3qTp0wcnfnfBR6OnHCerdeuos1QiWvCCrFyJ7qufYoW8qmPa5FmT6Gd3iRAN l/rroRP89rqdhmjCfiZ9JEREmT3K9AF93hn4wKh7RYuZDLiXLPLzkH3OZakuQ2W/1nHCsJk/4Qmjz Mpu6HqqMp+nAw3+tl9YsRUJdyXmql4w7NCkfMiZy7iWHUIUqd9WOmF2TpnGDvM87H7u9HdvVcjFBG 2eeOR4jpDUPmXA==; From: Mathieu Othacehe To: soeren@soeren-tempel.net Subject: Re: bug#66296: [PATCH] pack: Allow setting a custom image tag for Docker images References: <20231001130615.18132-1-soeren@soeren-tempel.net> Date: Sat, 14 Oct 2023 10:23:07 +0200 In-Reply-To: <20231001130615.18132-1-soeren@soeren-tempel.net> (soeren@soeren-tempel.net's message of "Sun, 1 Oct 2023 15:06:15 +0200") Message-ID: <87zg0lehp0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66296 Cc: 66296@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > Inspired by `docker build -t`, this commit adds a new Docker-specific > option to `guix pack` which allows setting a custom repository name for > the resulting image. If this option is not specified, pack falls back > to computing the name from the manifest. Therefore, this change is > entirely backwards compatible. This seems to work fine, thanks. There is a line in the documentation that states: --8<---------------cut here---------------start------------->8--- The =E2=80=9Crepository name=E2=80=9D as it appears in the output of the do= cker images command is computed from package names passed on the command line or in the manifest file. --8<---------------cut here---------------end--------------->8--- Could you build upon that statement and introduce the new --image-tag field there? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 14 05:41:14 2023 Received: (at 66296) by debbugs.gnu.org; 14 Oct 2023 09:41:14 +0000 Received: from localhost ([127.0.0.1]:47910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrb8z-0001KH-Tm for submit@debbugs.gnu.org; Sat, 14 Oct 2023 05:41:14 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:20608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrb8t-0001K2-Qi; Sat, 14 Oct 2023 05:41:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=opensmtpd; bh=Jtp9XJt4h3 21dIylP4F+Yla0H7ZPbtOaAkgIQzq86cY=; h=date:subject:to:from; d=soeren-tempel.net; b=J6QpODIUR+9uOaUm49x2CmkJq/09M1MNx8lUaAiPuDAsouB 6N8vPrsJpmJKeyB5rGkuRA7pCcFFvkCuOHGS2qkNiCnQWgZwETQ7Mq3GQO4uMBMGIbhnda vH9mqrraMuwxEM2tbir+n1Z9dEe5sAocwy0oRGZjwqDJh+t+eUpibQ= Received: from localhost (dynamic-2a02-3102-49da-001b-8819-7387-eed0-4220.310.pool.telefonica.de [2a02:3102:49da:1b:8819:7387:eed0:4220]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id d66855ea (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 14 Oct 2023 11:40:42 +0200 (CEST) From: soeren@soeren-tempel.net To: 66296@debbugs.gnu.org Subject: [PATCH v2] pack: Allow setting a custom image tag for Docker images Date: Sat, 14 Oct 2023 11:38:56 +0200 Message-ID: <20231014094024.3993-3-soeren@soeren-tempel.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66296 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Sören Tempel Previously, the image repository name was automatically computed from the packages in the manifest without allowing the user to set a custom one. As such, changing the packages in the manifest would result in a new image name. Thereby requiring updating documentation et cetera when using `docker load` directory on the resulting image. Inspired by `docker build -t`, this commit adds a new Docker-specific option to `guix pack` which allows setting a custom repository name for the resulting image. If this option is not specified, pack falls back to computing the name from the manifest. Therefore, this change is entirely backwards compatible. * guix/scripts/pack.scm (guix-pack): add --image-tag option * guix/scripts/pack.scm (%docker-format-options): new constant * guix/scripts/pack.scm (show-docker-format-options): new procedure * guix/scripts/pack.scm (show-docker-format-options/detailed): new procedure * guix/scripts/pack.scm (docker-image): allow setting a custom repository name for the created docker image via extra-options. * doc/guix.texi (Invoking guix pack)[docker]: Document --image-tag option Signed-off-by: Sören Tempel --- Changes since v1: Document the new --image-tag and --help-docker-format options in the Guix manual (Invoking guix pack). doc/guix.texi | 9 ++++-- guix/scripts/pack.scm | 66 ++++++++++++++++++++++++++++++------------- 2 files changed, 52 insertions(+), 23 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 8c5697589f..b9b45cfe9d 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -7314,9 +7314,12 @@ specified binaries and symlinks. @item docker This produces a tarball that follows the @uref{https://github.com/docker/docker/blob/master/image/spec/v1.2.md, -Docker Image Specification}. The ``repository name'' as it appears in -the output of the @command{docker images} command is computed from -package names passed on the command line or in the manifest file. +Docker Image Specification}. By default, the ``repository name'' as it +appears in the output of the @command{docker images} command is computed +from package names passed on the command line or in the manifest file. +Alternatively, the ``repository name'' can also be configured via the +@option{--image-tag} option. Refer to @option{--help-docker-format} for +more information on such advanced options. @item squashfs This produces a SquashFS image containing all the specified binaries and diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm index 01995c48b7..e7005e7bc6 100644 --- a/guix/scripts/pack.scm +++ b/guix/scripts/pack.scm @@ -507,7 +507,7 @@ (define* (docker-image name profile image is a tarball conforming to the Docker Image Specification, compressed with COMPRESSOR. It can be passed to 'docker load'. If TARGET is true, it must a be a GNU triplet and it is used to derive the architecture metadata in -the image." +the image. EXTRA-OPTIONS may contain the IMAGE-TAG keyword argument." (define database (and localstatedir? (file-append (store-database (list profile)) @@ -531,7 +531,7 @@ (define build (guix build utils) (guix profiles) (guix search-paths) (srfi srfi-1) (srfi srfi-19) - (ice-9 match)) + (ice-9 match) (ice-9 optargs)) #$(procedure-source manifest->friendly-name) @@ -560,23 +560,26 @@ (define directives (setenv "PATH" #+(file-append archiver "/bin")) - (build-docker-image #$output - (map store-info-item - (call-with-input-file "profile" - read-reference-graph)) - #$profile - #:repository (manifest->friendly-name - (profile-manifest #$profile)) - #:database #+database - #:system (or #$target %host-type) - #:environment environment - #:entry-point - #$(and entry-point - #~(list (string-append #$profile "/" - #$entry-point))) - #:extra-files directives - #:compressor #+(compressor-command compressor) - #:creation-time (make-time time-utc 0 1)))))) + (let-keywords '#$extra-options #f + ((image-tag #f)) + (build-docker-image #$output + (map store-info-item + (call-with-input-file "profile" + read-reference-graph)) + #$profile + #:repository (or image-tag + (manifest->friendly-name + (profile-manifest #$profile))) + #:database #+database + #:system (or #$target %host-type) + #:environment environment + #:entry-point + #$(and entry-point + #~(list (string-append #$profile "/" + #$entry-point))) + #:extra-files directives + #:compressor #+(compressor-command compressor) + #:creation-time (make-time time-utc 0 1))))))) (gexp->derivation (string-append name ".tar" (compressor-extension compressor)) @@ -1287,6 +1290,20 @@ (define (required-option symbol) (alist-cons symbol arg result) rest)))) +(define %docker-format-options + (list (required-option 'image-tag))) + +(define (show-docker-format-options) + (display (G_ " + --help-docker-format list options specific to the docker format"))) + +(define (show-docker-format-options/detailed) + (display (G_ " + --image-tag=NAME + Use the given NAME for the Docker image repository")) + (newline) + (exit 0)) + (define %deb-format-options (list (required-option 'control-file) (required-option 'postinst-file) @@ -1407,6 +1424,10 @@ (define %options (lambda (opt name arg result) (alist-cons 'bootstrap? #t result))) + (option '("help-docker-format") #f #f + (lambda args + (show-docker-format-options/detailed))) + (option '("help-deb-format") #f #f (lambda args (show-deb-format-options/detailed))) @@ -1415,7 +1436,8 @@ (define %options (lambda args (show-rpm-format-options/detailed))) - (append %deb-format-options + (append %docker-format-options + %deb-format-options %rpm-format-options %transformation-options %standard-build-options @@ -1433,6 +1455,7 @@ (define (show-help) (newline) (show-transformation-options-help) (newline) + (show-docker-format-options) (show-deb-format-options) (show-rpm-format-options) (newline) @@ -1586,6 +1609,9 @@ (define (process-file-arg opts name) manifest))) (pack-format (assoc-ref opts 'format)) (extra-options (match pack-format + ('docker + (list #:image-tag + (assoc-ref opts 'image-tag))) ('deb (list #:control-file (process-file-arg opts 'control-file) From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 14 09:31:40 2023 Received: (at 66296-done) by debbugs.gnu.org; 14 Oct 2023 13:31:40 +0000 Received: from localhost ([127.0.0.1]:48191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrek0-0000df-5L for submit@debbugs.gnu.org; Sat, 14 Oct 2023 09:31:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrejx-0000dN-Vt for 66296-done@debbugs.gnu.org; Sat, 14 Oct 2023 09:31:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrejR-0001hm-Pb; Sat, 14 Oct 2023 09:31:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=r6uwcPNHeqNq9452tbwmXixoxGnpeKGOw1bE8pkPDec=; b=pNTN3vN0hr92gAlOC6UY WmOFqnYXHVyKpdoSMRj/JnN+l2OfnLYzI1++1BL/TFog2DY+6RI5aCWjCRvRF07hKO+0NPh6f9zMK 2YFmmYmuFtSMrIEAwSIfsqr9r/oJOV+beg50eFiHTGRUT1M8kDAXLNuM1EixWFqnT0qCilXOoS9Tp IdbC9byfL/KW1pOMKmNfGwIUZU9CVxeLCa9rnfTbq097egLvCcPkMiMlhKVSs4TSREdHzSvZuCmbA 8E24A4P+8WvQJiAsjagEGQ2EOaL33ByrhN8Q/q2D1n9xYieJm/qTUC0RV7GLjABGWmZVVYPb1h1Tl Rq7nXDvV28/60w==; From: Mathieu Othacehe To: soeren@soeren-tempel.net Subject: Re: bug#66296: [PATCH] pack: Allow setting a custom image tag for Docker images References: <20231001130615.18132-1-soeren@soeren-tempel.net> <20231014094024.3993-3-soeren@soeren-tempel.net> Date: Sat, 14 Oct 2023 15:31:03 +0200 In-Reply-To: <20231014094024.3993-3-soeren@soeren-tempel.net> (soeren@soeren-tempel.net's message of "Sat, 14 Oct 2023 11:38:56 +0200") Message-ID: <87a5slgwko.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66296-done Cc: 66296-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > * guix/scripts/pack.scm (guix-pack): add --image-tag option > * guix/scripts/pack.scm (%docker-format-options): new constant > * guix/scripts/pack.scm (show-docker-format-options): new procedure > * guix/scripts/pack.scm (show-docker-format-options/detailed): new procedure > * guix/scripts/pack.scm (docker-image): allow setting a custom > repository name for the created docker image via extra-options. > * doc/guix.texi (Invoking guix pack)[docker]: Document --image-tag option Applied with an adapted commit message, Thanks! Mathieu From unknown Sun Jun 22 11:31:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Sun, 15 Oct 2023 14:08:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 15 10:07:57 2023 Received: (at control) by debbugs.gnu.org; 15 Oct 2023 14:07:57 +0000 Received: from localhost ([127.0.0.1]:53868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs1mf-0004q0-3V for submit@debbugs.gnu.org; Sun, 15 Oct 2023 10:07:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs1mc-0004pk-3b for control@debbugs.gnu.org; Sun, 15 Oct 2023 10:07:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qs1m8-0008TO-AQ for control@debbugs.gnu.org; Sun, 15 Oct 2023 10:07:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=3OCX5sPjmD45JDHlTJlQ2jTs5orDQz8aut4jYdzfsTY=; b=X8loZSR/7NdInP ijZpy3nIk9xzk+bKBeLvTE92miZu9NJm9GedzCpjTVKpHDJZVk1kfXA2j1BBk+G7+ASSKhnUZ8hj2 oJtclbkoyTfhKpBkGuu41d49OzVvLmmA03SdMTuYB1na7Qjzy3cGsLruGqzw/9AS7DJ3zB4yLJ2Ol ySeRq2FGlaID2S1BZHSxkDk74UrL1nOjEL0oSnLXMLXXboSQ8LoWZWLjAGB2iXYpioZyFtyhLQJGJ jzV3Qig2bNBbjij/qi6nzypNHQbtp11z+0EMFISRck7SYPz5cggTalDaXZGwMy4nDErCA73eyeW57 ErH13QCGlT/OYIyAqOjg==; Date: Sun, 15 Oct 2023 16:07:21 +0200 Message-Id: <874jis9dye.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #66296 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) reopen 66296 tags 66296 - fixed patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 15 10:12:35 2023 Received: (at 66296) by debbugs.gnu.org; 15 Oct 2023 14:12:35 +0000 Received: from localhost ([127.0.0.1]:53877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs1r9-0004xe-2t for submit@debbugs.gnu.org; Sun, 15 Oct 2023 10:12:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qs1r6-0004xR-Me for 66296@debbugs.gnu.org; Sun, 15 Oct 2023 10:12:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qs1qc-0000uj-9y; Sun, 15 Oct 2023 10:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=BwRhNpUWrwCjDc2vvo+hzlS3DEXKcHLMl61YVbxUHEY=; b=X+w7Mkq3CJhUJw0OBw/W w8diWnZbX8p1u0dMUcxQ4RyQggwYT3hDL9YShmGD/CKs5vg/OyrQ8ktvPyQSbhdWYqkCa4vuMicIU wZ4IunkcXFsHu+L6xEtMhPlApvc8Vf7cQghg/tDmobceIMZimL+Z6TkcCVH+L+gV9LCSSvf7AMj0Y czCzIE+1E9fn0LCwVbU78rCtvBHH+mUQkmSsXq8tQiWftjMjxjMW8LDuMLwy6G6A5RPV+TtL4ZJux YlvIiT8dvL+5wynUziGZWjBuw7wd0j0fpgYQsIvkXO1YDu7GFopj3snOpA278oZ8lbrnwrflEH5Ky apNvqBR73BJSTw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: soeren@soeren-tempel.net Subject: Re: [bug#66296] [PATCH v2] pack: Allow setting a custom image tag for Docker images In-Reply-To: <20231014094024.3993-3-soeren@soeren-tempel.net> (soeren@soeren-tempel.net's message of "Sat, 14 Oct 2023 11:38:56 +0200") References: <20231001130615.18132-1-soeren@soeren-tempel.net> <20231014094024.3993-3-soeren@soeren-tempel.net> Date: Sun, 15 Oct 2023 16:11:59 +0200 Message-ID: <87zg0k7z68.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66296 Cc: 66296@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, soeren@soeren-tempel.net skribis: > From: S=C3=B6ren Tempel > > Previously, the image repository name was automatically computed from > the packages in the manifest without allowing the user to set a custom > one. As such, changing the packages in the manifest would result in a > new image name. Thereby requiring updating documentation et cetera when > using `docker load` directory on the resulting image. > > Inspired by `docker build -t`, this commit adds a new Docker-specific > option to `guix pack` which allows setting a custom repository name for > the resulting image. If this option is not specified, pack falls back > to computing the name from the manifest. Therefore, this change is > entirely backwards compatible. > > * guix/scripts/pack.scm (guix-pack): add --image-tag option > * guix/scripts/pack.scm (%docker-format-options): new constant > * guix/scripts/pack.scm (show-docker-format-options): new procedure > * guix/scripts/pack.scm (show-docker-format-options/detailed): new proced= ure > * guix/scripts/pack.scm (docker-image): allow setting a custom > repository name for the created docker image via extra-options. > * doc/guix.texi (Invoking guix pack)[docker]: Document --image-tag option > > Signed-off-by: S=C3=B6ren Tempel It looks like commit 373ec2cf8ce97d5f89191c3d9211ee3a5c2067dc does not include the pack.scm changes, only documentation. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 16 03:30:00 2023 Received: (at 66296) by debbugs.gnu.org; 16 Oct 2023 07:30:00 +0000 Received: from localhost ([127.0.0.1]:55140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsI35-0003Xd-M4 for submit@debbugs.gnu.org; Mon, 16 Oct 2023 03:29:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qsI31-0003XI-Qd for 66296@debbugs.gnu.org; Mon, 16 Oct 2023 03:29:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsI2W-00062m-8e; Mon, 16 Oct 2023 03:29:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=wOYGkn0g7K8XUOXjJDJT6TlQyopNT+T4uojdSewCVRg=; b=FevPObCTfhzN+KCZyTJm uItSK722DxVyjyhRL05j4HT5HXdz9ZyznrQfcKynDNWVP1bAUW8pt37g1rYPD9cJGVUfXbjFrUy70 4QEqX4BMncpGQzNWgDjt8zT+78vNBt0lDdhSvyV+KQvfwBLt82fhMSrVlkccCmOr49+vuZDIIIT+f VJ3KI+1bCzpNRoFyur2fp5ShtKjdVsDRhnwpKPH/Kls7oXQ2raf8Z7udJQraec/pggYiluCPi9bI1 1tVyEYMv4d7mS7rB5SZ4tb74z/7FsnU2c86zcoVUcR0Cvy6TQZtwH5w/uVDB5ipL3uKkjMkRHoZTY JcaiXgCeJkFDRA==; From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#66296] [PATCH v2] pack: Allow setting a custom image tag for Docker images In-Reply-To: <87zg0k7z68.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 15 Oct 2023 16:11:59 +0200") References: <20231001130615.18132-1-soeren@soeren-tempel.net> <20231014094024.3993-3-soeren@soeren-tempel.net> <87zg0k7z68.fsf@gnu.org> Date: Mon, 16 Oct 2023 09:29:17 +0200 Message-ID: <87r0lvnhyq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66296 Cc: 66296@debbugs.gnu.org, soeren@soeren-tempel.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > It looks like commit 373ec2cf8ce97d5f89191c3d9211ee3a5c2067dc does not > include the pack.scm changes, only documentation. Fixed with 435090fa3f406a76c83e11de9cd01f61ef89dcca. Thanks for the heads-up, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 25 05:59:04 2023 Received: (at control) by debbugs.gnu.org; 25 Oct 2023 09:59:04 +0000 Received: from localhost ([127.0.0.1]:57413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvafH-0005Ou-Os for submit@debbugs.gnu.org; Wed, 25 Oct 2023 05:59:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvafF-0005Nz-Jk for control@debbugs.gnu.org; Wed, 25 Oct 2023 05:59:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvaeg-0007mz-7W for control@debbugs.gnu.org; Wed, 25 Oct 2023 05:58:26 -0400 Date: Wed, 25 Oct 2023 11:58:00 +0200 Message-Id: <87a5s7xbvb.fsf@meije.mail-host-address-is-not-set> To: control@debbugs.gnu.org From: Mathieu Othacehe Subject: control message for bug #66296 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) close 66296 quit From unknown Sun Jun 22 11:31:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Nov 2023 12:24:18 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator