GNU bug report logs - #66288
29.1; Performance regression using pipe for subprocess

Previous Next

Package: emacs;

Reported by: Chris Hanson <cph <at> chris-hanson.org>

Date: Sun, 1 Oct 2023 00:59:02 UTC

Severity: normal

Found in version 29.1

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: gerd.moellmann <at> gmail.com, 66288 <at> debbugs.gnu.org, gregory <at> heytings.org, eggert <at> cs.ucla.edu, cph <at> chris-hanson.org
Subject: bug#66288: 29.1; Performance regression using pipe for subprocess
Date: Thu, 05 Oct 2023 08:50:06 +0300

> Date: Thu, 5 Oct 2023 01:54:43 +0300
> Cc: gregory <at> heytings.org, gerd.moellmann <at> gmail.com, 66288 <at> debbugs.gnu.org
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> On 05/10/2023 01:49, Paul Eggert wrote:
> >> +      fcntl (inchannel, F_SETPIPE_SZ, readmax);
> > 
> > This call can fail if you aren't root and you exceed the system limit in 
> > /proc/sys/fs/pipe-max-size. So I suggest that if this fnctl fails with 
> > EPERM, trying it again after clipping to that limit.
> 
> Perhaps we'd rather fail loudly, so the user is aware that their 
> customized value cannot be applied.

Why not silently?  The clip_to_bounds call can already silently change
the original request anyway.
This bug report was last modified 1 year and 229 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.