GNU bug report logs - #66283
30.0.50; which-function-mode: When configured to display in header, and toggling off, then does not remove header

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: mekeor <at> posteo.de, sbaugh <at> catern.com, 66283 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: bug#66283: 30.0.50; which-function-mode: When configured to display in header, and toggling off, then does not remove header
Date: Sat, 14 Oct 2023 10:29:59 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: Mekeor Melire <mekeor <at> posteo.de>,  Author <sbaugh <at> catern.com>,
>    66283 <at> debbugs.gnu.org,  Committer <eliz <at> gnu.org>
> Date: Wed, 04 Oct 2023 11:13:06 -0400
> 
> Two fixes to the previous patch:
> 
> - There was always a bug with which-function-mode where if you enabled
>   it when there were already existing buffers, it would behave
>   differently than if you enabled it and then created those buffers.
>   Namely it would enable which-func-mode for every buffer, even if the
>   buffer didn't support imenu.  This is especially noticeable when
>   toggling which-function-mode and using the header line, so I fixed it.
> 
> - Also, I accidentally dropped a paren before submitting.  Now that's
>   fixed :)

Thanks, but how about some tests for these fixes?  It's high time
which-mode had some test suite, I think.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.