GNU bug report logs - #6628
[PATCH] omit $(POW_LIB) when linking, as this is no longer needed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6628 in the body.
You can then email your comments to 6628 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> CS.UCLA.EDU>
To: Bug Coreutils <bug-coreutils <at> gnu.org>
Subject: [PATCH] omit $(POW_LIB) when linking, as this is no longer needed
Date: Tue, 13 Jul 2010 16:32:17 -0700

Here's an obvious patch to simplify src/Makefile.am now that
gnulib strtod no longer needs libm.  Is it OK to install this?

From 018e0adb679ac8ba713de00c1afb686395ce13fc Mon Sep 17 00:00:00 2001
From: Paul R. Eggert <eggert <at> cs.ucla.edu>
Date: Tue, 13 Jul 2010 16:29:37 -0700
Subject: [PATCH] omit $(POW_LIB) when linking, as this is no longer needed

* src/Makefile.am (printf_LDADD, seq_LDADD, sleep_LDADD, sort_LDADD):
(tail_LDADD, uptime_LDADD): Omit $(POW_LIB), as it's no longer
needed due to recent gnulib changes, where the strtod module no
longer uses the pow function.  strtold needs pow only because it's
sometimes aliased to strtod.  See
http://lists.gnu.org/archive/html/bug-gnulib/2010-07/msg00076.html
---
 src/Makefile.am |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 2e0e320..d87fbb5 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -343,14 +343,6 @@ ls_LDADD += $(LIB_CAP)
 dd_LDADD += $(LIB_FDATASYNC)
 shred_LDADD += $(LIB_FDATASYNC)
 
-# for strtod, strtold
-printf_LDADD += $(POW_LIB)
-seq_LDADD += $(POW_LIB)
-sleep_LDADD += $(POW_LIB)
-sort_LDADD += $(POW_LIB)
-tail_LDADD += $(POW_LIB)
-uptime_LDADD += $(POW_LIB)
-
 # for xnanosleep
 sleep_LDADD += $(LIB_NANOSLEEP)
 sort_LDADD += $(LIB_NANOSLEEP)
-- 
1.7.1

Message #8 received at 6628 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> CS.UCLA.EDU>
Cc: 6628 <at> debbugs.gnu.org
Subject: Re: bug#6628: [PATCH] omit $(POW_LIB) when linking,
	as this is no longer needed
Date: Wed, 14 Jul 2010 15:09:44 +0200

Paul Eggert wrote:
> Here's an obvious patch to simplify src/Makefile.am now that
> gnulib strtod no longer needs libm.  Is it OK to install this?
>
> Subject: [PATCH] omit $(POW_LIB) when linking, as this is no longer needed
>
> * src/Makefile.am (printf_LDADD, seq_LDADD, sleep_LDADD, sort_LDADD):
> (tail_LDADD, uptime_LDADD): Omit $(POW_LIB), as it's no longer
> needed due to recent gnulib changes, where the strtod module no
> longer uses the pow function.  strtold needs pow only because it's
> sometimes aliased to strtod.  See
> http://lists.gnu.org/archive/html/bug-gnulib/2010-07/msg00076.html

Hi Paul,
Thanks for the clean-up.  That looks fine.

Message #13 received at 6628-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Paul Eggert <eggert <at> CS.UCLA.EDU>
Cc: 6628-done <at> debbugs.gnu.org
Subject: Re: bug#6628: [PATCH] omit $(POW_LIB) when linking,	as this is no
	longer needed
Date: Wed, 14 Jul 2010 15:45:09 +0100

On 14/07/10 00:32, Paul Eggert wrote:
> Here's an obvious patch to simplify src/Makefile.am now that
> gnulib strtod no longer needs libm.  Is it OK to install this?
> 
>>From 018e0adb679ac8ba713de00c1afb686395ce13fc Mon Sep 17 00:00:00 2001
> From: Paul R. Eggert <eggert <at> cs.ucla.edu>
> Date: Tue, 13 Jul 2010 16:29:37 -0700
> Subject: [PATCH] omit $(POW_LIB) when linking, as this is no longer needed

That looks good.
I've just updated to the latest gnulib,
so I went ahead and pushed that.

cheers,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.