From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 30 06:11:16 2023 Received: (at submit) by debbugs.gnu.org; 30 Sep 2023 10:11:17 +0000 Received: from localhost ([127.0.0.1]:57765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmWwO-0002XA-JD for submit@debbugs.gnu.org; Sat, 30 Sep 2023 06:11:16 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmWwM-0002Wt-BH for submit@debbugs.gnu.org; Sat, 30 Sep 2023 06:11:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmWw1-0004W9-Ks for bug-guix@gnu.org; Sat, 30 Sep 2023 06:10:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmWw1-00056a-B2 for bug-guix@gnu.org; Sat, 30 Sep 2023 06:10:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=70XRpPJZdEVFgf9/W5R26t/UEYYl+ytDEAk3kWJ4R6U=; b=AqjBq6dvvQsPeO F72sthKGntRHgWGMDqMUhM9NEmIQPjkhAbgv8wVD8iuJgmvX6tDgLHY3sc+gkxdMBDX7irhuNHwK5 ogAsgl1D/4IEwVXzf3CBrTC1LjT0x3s+9CTI/TCsCfyobiqTXWD1P2k+iMp6QZkiUpPpqtASiRMZ/ t7yPUSo83imcC8103+JNYapTkjVeq2fegy9tZUC89c3F9Vq5TUzBp4tsiy34XAP8P9JAUZ4KeiqV9 i0O3FPCzboEHbfxeFmVkuoUq17k3IMFy7p4u60wYROnoZtCxhdXCXAftrV5opHnuTk3eP3zj1My6z heyBzTqwCN5f8pgRXd7g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-guix@gnu.org Subject: Unexporting X-Debbugs-Cc: Maxim Cournoyer X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 =?utf-8?Q?Vend=C3=A9miaire?= an 232 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Panais X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 30 Sep 2023 12:10:51 +0200 Message-ID: <87jzs8t1hw.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, Commit 03795e2ba27424fc98957da00f6c71325e7ae425 exports the record type descriptor (RTD). Common practice is to keep RTDs private because by publishing them, we make it harder to change the ABI (because users might be matching fields positionally) and we make it trivial for users to forge records of that type, bypassing any checks we may have in the official constructor (such as =E2=80=9Csanitizers=E2=80=9D). What do you think of reverting this commit? I don=E2=80=99t see references= to outside of its module. (I=E2=80=99m aware there are a few other places where RTDs are exported; I = think we should eventually fix them as well.) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 01 16:28:57 2023 Received: (at 66279) by debbugs.gnu.org; 1 Oct 2023 20:28:57 +0000 Received: from localhost ([127.0.0.1]:35475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn33h-0007An-CZ for submit@debbugs.gnu.org; Sun, 01 Oct 2023 16:28:57 -0400 Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]:49600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qn33f-0007AY-II for 66279@debbugs.gnu.org; Sun, 01 Oct 2023 16:28:55 -0400 Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-65af75a0209so70584096d6.3 for <66279@debbugs.gnu.org>; Sun, 01 Oct 2023 13:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696192113; x=1696796913; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=wCksUy/uZitxPJ/zxV19DFR0UDLRND14YMQzNJY29to=; b=UBDws8CyOtQye4clj0TTqYBi2tM7i45r/fsXDczZzDXXpmVFSQq6Cn/cSkhfsVHRKB ZJ5BeK0Gv6EeUNYoljcuHjehoVLS77BFfdDb2TvyQq7vRjyiauDRTD7qsnqKEWgsRGxS ER8JxPCVpHXuAJyBlFRpTYyplx/RxVcFQN5y3+kog4j3uU37IiaTr86y4U20shtdlBbL aBLJjFrfpqOiXrW9aImNsjexQUKXwOMpMIU6HLFgtgpLQ0WsY03ZV3X2lOeKwK7b4cx0 GvYh8pmkYy762JKIMXebU3WBk5xrWFyzKk4mriLXllKAQf5l/LhiWw/4TvPyMeVuzUgt XsDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696192113; x=1696796913; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wCksUy/uZitxPJ/zxV19DFR0UDLRND14YMQzNJY29to=; b=pdoLi90Vs3ZNtYnypPuvSpJM6vl6SmB3Tg4AED3vyXlVctvM1oaXpku4ncpzVjW+l7 n8pjIIgPsmjiYnBfeWA01VQQOIimBy2Qg/iNBtdOTctieq0aKbhnNix+dd8xY6Wy7jVq kHMihJ9mIkDyv+9PENtx7Civdr/B0z2I/TRzHYQwvYKR+dMRcSnJSZIfzlI2bcdpyU76 xM2V5FN+eRka7sI8GjXjzmijRYKFrhGiclTc839Owz0tbSxwPtNRr2BskOJK4Ee39d4X n1iFWj3KIfVDmw+mcVMWSa+Z8ZYaqUi00YoQ4HsdzQ3Fyu5Mu80uUCE5NppmNiRVjesl uOPg== X-Gm-Message-State: AOJu0YyZh5ODyYNMC2W5jv8yNisvE08X2MkctNP9bqNitz5HO85e2+el YDMYuL5nSMRi3X5r9MQHsnpa0gifR5Q= X-Google-Smtp-Source: AGHT+IGb17n39UBve+q7jZD5dA1hPRehbdQhy4n+/R9dhfCAXpXIO15vfdLDMUmFH5LiFxnHtPexkQ== X-Received: by 2002:a05:6214:321:b0:636:afa1:345d with SMTP id j1-20020a056214032100b00636afa1345dmr8392400qvu.17.1696192113397; Sun, 01 Oct 2023 13:28:33 -0700 (PDT) Received: from hurd (dsl-10-136-90.b2b2c.ca. [72.10.136.90]) by smtp.gmail.com with ESMTPSA id n17-20020a0ce491000000b0065af657de01sm7241794qvl.115.2023.10.01.13.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Oct 2023 13:28:32 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#66279: Unexporting References: <87jzs8t1hw.fsf@inria.fr> Date: Sun, 01 Oct 2023 16:28:31 -0400 In-Reply-To: <87jzs8t1hw.fsf@inria.fr> ("Ludovic =?utf-8?Q?Court=C3=A8s=22?= =?utf-8?Q?'s?= message of "Sat, 30 Sep 2023 12:10:51 +0200") Message-ID: <87wmw65bps.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66279 Cc: 66279@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Commit 03795e2ba27424fc98957da00f6c71325e7ae425 exports the > record type descriptor (RTD). > > Common practice is to keep RTDs private because by publishing them, we > make it harder to change the ABI (because users might be matching fields > positionally) and we make it trivial for users to forge records of that > type, bypassing any checks we may have in the official constructor (such > as =E2=80=9Csanitizers=E2=80=9D). Perhaps we should document this? More power to the users! > What do you think of reverting this commit? I don=E2=80=99t see referenc= es to > outside of its module. I'd like to note there are also valid usages requiring a record type, such as 'match-record' from (guix records). Otherwise, I don't feel strongly about it, but if if's done I think the rationale you gave above should be documented in our contributing guidelines. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 05 17:29:19 2023 Received: (at 66279-done) by debbugs.gnu.org; 5 Oct 2023 21:29:20 +0000 Received: from localhost ([127.0.0.1]:48663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoVuJ-0002HX-J8 for submit@debbugs.gnu.org; Thu, 05 Oct 2023 17:29:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoVuG-0002HK-AW for 66279-done@debbugs.gnu.org; Thu, 05 Oct 2023 17:29:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoVts-0001L9-CS; Thu, 05 Oct 2023 17:28:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=sGUd6NlFjp/uI0/tDqRRjJAAc8mEMFOvTO6hFFlSUIk=; b=dViHXub85l9OE070O8rv aNlP9YkrSMxdMYJ0ibxigHosrLcyMSChjM5KtttZ+pZgb6KExg9wQk0qexpJy6/EsDTzWbMpPIczI MevV+8n0AAugY3CaL+GMXI4vzcQB6kXm8bgjktBZiDp2zhrqWLOe/zpwvx1+4K9zWD3ygWrw9ts7I ApZdYRg8zCtABqPoZmKdpUmcDnk9GwBYoHBpori7Fj4h8HZitnsnQmZyQ989U70ELGnY8oz4CwF6x omYkhgkwW3GfZhHJoaXTzX6wVyLQd3pTF6gNp+Z3m/MBN+HSuZgE6VhWjvuGLUnuLPBkiybY9KBMo h79cQ0GI52Q78A==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#66279: Unexporting In-Reply-To: <87wmw65bps.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 01 Oct 2023 16:28:31 -0400") References: <87jzs8t1hw.fsf@inria.fr> <87wmw65bps.fsf@gmail.com> Date: Thu, 05 Oct 2023 23:28:49 +0200 Message-ID: <87h6n421ym.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66279-done Cc: 66279-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> Hi Maxim, >> >> Commit 03795e2ba27424fc98957da00f6c71325e7ae425 exports the >> record type descriptor (RTD). >> >> Common practice is to keep RTDs private because by publishing them, we >> make it harder to change the ABI (because users might be matching fields >> positionally) and we make it trivial for users to forge records of that >> type, bypassing any checks we may have in the official constructor (such >> as =E2=80=9Csanitizers=E2=80=9D). > > Perhaps we should document this? More power to the users! Done in commit 7b710836a1c7cb921f54ead64f465bcc5333d076, based on what I wrote above. >> What do you think of reverting this commit? I don=E2=80=99t see referen= ces to >> outside of its module. > > I'd like to note there are also valid usages requiring a record type, > such as 'match-record' from (guix records). Otherwise, I don't feel > strongly about it, but if if's done I think the rationale you gave above > should be documented in our contributing guidelines. Alright, done as well in commit 97927608cb4f9c5d721115f1cb638de17ac38e62. Thanks, Ludo=E2=80=99. From unknown Mon Aug 18 17:58:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Nov 2023 11:24:17 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator