Subject: bug#66270: closed (Re: [bug#66270] [PATCH v2] gnu: mpd-mpc: Install bash completions in correct location.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 08 Oct 2023 06:56:01 +0000

Your bug report

#66270: [PATCH] gnu: mpd-mpc: Install bash completions in correct location.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
66270: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66270
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#66270] [PATCH v2] gnu: mpd-mpc: Install bash completions in correct location.
From: Liliana Marie Prikler <[email-masked]>
To: Simon Tournier <[email-masked]>, [email-masked]
Date: Sun, 08 Oct 2023 08:54:51 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Am Freitag, dem 06.10.2023 um 10:59 +0200 schrieb Liliana Marie
Prikler:
> Am Donnerstag, dem 05.10.2023 um 17:06 +0200 schrieb Simon Tournier:
> > Hi,
> > 
> > On Wed, 04 Oct 2023 at 20:51, Liliana Marie Prikler
> > <[email-masked]> wrote:
> > 
> > > It's not installing it, though – merely moving it from one place
> > > in
> > > output, to another (the one that's actually consulted by bash). 
> > > Hence, move.
> > 
> > That’s the definition of “installing files”, no? :-)
> > 
> > --8<---------------cut here---------------start------------->8---
> > INSTALL(1)                  User Commands                 
> > INSTALL(1)
> > 
> > NAME
> >        install - copy files and set attributes
> > 
> > DESCRIPTION
> >        This  install  program copies files (often just compiled)
> > into
> >        destination locations you choose.
> > --8<---------------cut here---------------end--------------->8---
> > 
> > Anyway.  I had my coffee now, so no more bikeshed between “copy” vs
> > “move”, which is in this context the same. ;-)
> On a high level, copying means that (a copy of) the file persists in
> its previous location, whereas move means it does not.  […]
Pushed now.

Cheers

Subject: [PATCH] gnu: mpd-mpc: Install bash completions in correct location.
From: Liliana Marie Prikler <[email-masked]>
To: [email-masked]
Date: Fri, 29 Sep 2023 20:45:33 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/mpd.scm (mpd-mpc)[#:phases]: Add ‘move-completion’.
---
 gnu/packages/mpd.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index d617dc014b..f42f08414f 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -246,7 +246,14 @@ (define-public mpd-mpc
                  ;; actually invoked.
                  (lambda _
                    (substitute* "doc/meson.build"
-                     (("rsync") "ls")))))))
+                     (("rsync") "ls"))))
+               (add-after 'install 'move-completion
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (let* ((out (assoc-ref outputs "out"))
+                          (contrib (string-append out "/share/doc/mpc/contrib"))
+                          (completion "/etc/bash-completion.d/"))
+                     (rename-file (string-append contrib "/mpc-completion.bash")
+                                  (string-append completion "/mpc"))))))))
     (inputs (list libmpdclient))
     (native-inputs
      (list pkg-config python-sphinx))

base-commit: ce0cc6137df81919389f61671096a6ce701c0889
-- 
2.41.0