GNU bug report logs - #66268
Guix makes invalid assumptions regarding guile-git guarantees leading to guix pull failing

Previous Next

Package: guix;

Reported by: Tomas Volf <~@wolfsden.cz>

Date: Fri, 29 Sep 2023 16:54:02 UTC

Severity: important

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: Jack Hill <jackhill <at> jackhill.us>, 66268 <at> debbugs.gnu.org
Subject: bug#66268: Guix makes invalid assumptions regarding guile-git guarantees leading to guix pull failing
Date: Thu, 17 Apr 2025 22:24:07 +0200
Hello,

Tomas Volf <~@wolfsden.cz> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>> Taking a step back, I think we can sidestep the issue entirely.  Based
>> on 45mg’s initial work, I added (git graph).  This includes
>> ‘graph-descendant?’, which is all we need in (guix git).
>>
>> So I think I’ll revert the offending commit
>> (cd91dc908ac4b215bc87a97455ff64ed4d89b721) and then come up with a patch
>> in Guix to use ‘graph-descendant?’ instead of our home-made graph
>> traversal code.
>>
>> How does that sound?
>
> I think that sounds like a great plan.  Using the new graph-descendant?
> should make the code both correct and faster, so win-win. :)

Yup!

I tagged Guile-Git 0.10.0 and sent this patch:

  https://issues.guix.gnu.org/77875

Thanks for your feedback!

Ludo’.




This bug report was last modified 29 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.