GNU bug report logs - #66263
[PATCH 00/23] guix: Add avr as a platform.

Previous Next

Full log

Message #131 received at 66263 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Cc: 66263 <at> debbugs.gnu.org, vagrant <at> debian.org, efraim <at> flashner.co.il
Subject: Re: [bug#66263] [PATCH 18/23] gnu: Add avr-libc.
Date: Thu, 05 Oct 2023 11:10:07 -0400

Hi,

Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com> writes:

> * gnu/packages/cross-toolchain.scm (avr-libc): New variable.
> ---
>  gnu/packages/cross-toolchain.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/cross-toolchain.scm b/gnu/packages/cross-toolchain.scm
> index 77af6b862b..929e665e50 100644
> --- a/gnu/packages/cross-toolchain.scm
> +++ b/gnu/packages/cross-toolchain.scm
> @@ -65,3 +65,8 @@ (define-public binutils-cross-avr
>  
>  (define-deprecated/public avr-binutils binutils-cross-avr
>    (deprecated-package "avr-binutils" binutils-cross-avr))
> +
> +;;; C standard libraries:
> +
> +(define-public avr-libc
> +  (cross-libc "avr"))

LGTM, with the Commentary section added as suggested before to warn this
module should *not* be imported elsewhere, for cyclic module
dependency reasons.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.