From unknown Sat Jun 21 03:26:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66240 <66240@debbugs.gnu.org> To: bug#66240 <66240@debbugs.gnu.org> Subject: Status: [PATCH] ; Substitute quotes in obsoletion notice in 'C-h f' Reply-To: bug#66240 <66240@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:26:55 +0000 retitle 66240 [PATCH] ; Substitute quotes in obsoletion notice in 'C-h f' reassign 66240 emacs submitter 66240 Eshel Yaron severity 66240 normal tag 66240 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 12:41:28 2023 Received: (at submit) by debbugs.gnu.org; 27 Sep 2023 16:41:28 +0000 Received: from localhost ([127.0.0.1]:52347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXbM-000260-76 for submit@debbugs.gnu.org; Wed, 27 Sep 2023 12:41:28 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXbK-00025j-2X for submit@debbugs.gnu.org; Wed, 27 Sep 2023 12:41:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlXb0-0004QF-Qj for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2023 12:41:06 -0400 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlXav-0000Q2-Oo for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2023 12:41:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1695832860; bh=vr4B84mtqF3VOaiPCEeyDZ6nip68/Dsk8PjebR9rXoI=; h=From:To:Subject:Date:From; b=CQVNFAtFqJnSxQFB0Glp8FFDKAzrYpPUSLoi2/QOyiWjcJhsD3T/QpKwrfEwet3aw qZVw8KqaQsqnTxlGS9WG72Ozg60SUHRmzf5zP2zdcpu95tFtxpJmtUtjB/uTZq3crh hK5J1wZAK2yGu2NidruPxYeAnDkgaAC+orUkL5mf86IYwC+FwX1I3HPwHe8C5GencA BtKfgVk02H6AWvJGoeV5U9elOqJYiJtfYFIVma4pX5Wk3NjUXjth2kxpyPf9gEj7O+ GaoEAyZbgYUPuM2Qq2T1RzVKsK5dkWF0kTh0NxB5XnKeutuHMdHry3B/XVQ0WncFXT LfdajQxlkvYKg== From: Eshel Yaron To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Substitute quotes in obsoletion notice in 'C-h f' X-Hashcash: 1:20:230927:bug-gnu-emacs@gnu.org::gKXi1lKDq90e1Cgt:0Mjx X-Debbugs-CC: Stefan Monnier Date: Wed, 27 Sep 2023 18:40:58 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Tags: patch Hi, Before this patch, `C-h f defadvice RET` says: This macro is obsolete since 30.1; use advice-add or define-advice The symbols `advice-add` and `define-advice` are not fontified nor buttonized. With this patch the symbols are quoted like other symbols in the *Help* buffer, and, more crucially, they're buttonized. Best, Eshel --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Substitute-quotes-in-obsoletion-notice-in-C-h-f.patch >From 1ff75d6daf59f8282544d3aea42ad2808f1469c9 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Wed, 27 Sep 2023 18:27:12 +0200 Subject: [PATCH] ; Substitute quotes in obsoletion notice in 'C-h f' * lisp/help-fns.el (help-fns--obsolete): Substitute quotes in string arguments to 'obsolete' declarations. * lisp/emacs-lisp/advice.el (defadvice): Markup symbols in 'obsolete' declaration. --- lisp/emacs-lisp/advice.el | 2 +- lisp/help-fns.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index 3265809f592..7fbdd963e0e 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -3131,7 +3131,7 @@ defadvice [DOCSTRING] [INTERACTIVE-FORM] BODY...)" (declare (doc-string 3) (indent 2) - (obsolete "use advice-add or define-advice" "30.1") + (obsolete "use `advice-add' or `define-advice'" "30.1") (debug (&define name ;; thing being advised. (name ;; class is [&or "before" "around" "after" ;; "activation" "deactivation"] diff --git a/lisp/help-fns.el b/lisp/help-fns.el index b34778773a9..e93c535bbef 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -767,7 +767,7 @@ help-fns--obsolete " is obsolete") (when (nth 2 obsolete) (insert (format " since %s" (nth 2 obsolete)))) - (insert (cond ((stringp use) (concat "; " use)) + (insert (cond ((stringp use) (concat "; " (substitute-quotes use))) (use (format-message "; use `%s' instead." use)) (t ".")) "\n") -- 2.42.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 28 15:46:51 2023 Received: (at 66240-done) by debbugs.gnu.org; 28 Sep 2023 19:46:51 +0000 Received: from localhost ([127.0.0.1]:54545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlwyJ-0003Dh-Ay for submit@debbugs.gnu.org; Thu, 28 Sep 2023 15:46:51 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:61912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlwyH-0003DS-71 for 66240-done@debbugs.gnu.org; Thu, 28 Sep 2023 15:46:49 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c15463ddd4so154928831fa.3 for <66240-done@debbugs.gnu.org>; Thu, 28 Sep 2023 12:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695930389; x=1696535189; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=yPbrVqaYG2va1fvx+tjWHPzJCFNLsv4Yqkl1HheDjTU=; b=ABYz3k95k+lbPOOTMtaZxtIIxJvqaEOooDVbkzVUhDL5bwvvnTcvEeG2LEVcccIibs +upcO3sSDSNCMX5Kl4gj7hnp7Eg6/ICSq4R59O0WDUIdXDPfHPVxBor3P3lMoO4KTHf6 KuMQCagP1QOByQSWhUjDquIv1S04IBnKEvLwXpqWsdcKqO+HHswWuIUtivaq/akKBJaX F83JtANVcLqdFaq+xj/VPa3ASMUq1Dogt1fu9NvMkvx15/s3wXMRYEjswhgFgsIbNhlS w+QfsMHwLLSGXyB8OaJfDVW0uur071L7SyZAxlv//eFgwMn39BuzV28DQ1s8PRgCQmXo PICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695930389; x=1696535189; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yPbrVqaYG2va1fvx+tjWHPzJCFNLsv4Yqkl1HheDjTU=; b=PBl44232w/yxHNYY+qVnm8nhwvciGAx3fMJSj7s5Lbk+UYMom5ZXqOyxqueTrBvtu3 v2NwYZ6ah3J3ClsPOCmOSYV6uEWnm9evc4fWqgugMZyPAi/Kj2M5XU57LmzTMmEIMSbS ++sBSLwU97Otc0cEvmGhDQadFAn8KPPEWAjWKIc/hIALPkUEBfIV4YsHLyQ2dAuhdcZe 7GI9/Mlf3r0wh6wRAEVzx8axr2ylb4wGooW6vBXak0Ef4jzVRb6stlsjW3FjEukAkfJB h4ghp1Ca/CWon1ZKHAIYUkQ/wduZtreQtWKhScNzxfShpAPqUkfB21xEtvfVnUIq1+fy +pVA== X-Gm-Message-State: AOJu0YzWkbgc/Fw/cGdy8hfmyr5bn1i2DWhNvLjuEx1oMy0x88PCAb0h mLkDQae23YIcxjajhqhBQz7f+hgzlOdcQnKpd0k= X-Google-Smtp-Source: AGHT+IHXbqmOLVSByBw+3bGolPdEJ/gI3UrRYWirtfcF2AXiL22MksCQ6R/+hR4F1KUKrxmHjhPjaWz7nTYvJE2U40M= X-Received: by 2002:a2e:b285:0:b0:2bc:efa4:2c32 with SMTP id 5-20020a2eb285000000b002bcefa42c32mr1759617ljx.37.1695930388619; Thu, 28 Sep 2023 12:46:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 28 Sep 2023 12:46:28 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Thu, 28 Sep 2023 12:46:28 -0700 Message-ID: Subject: Re: bug#66240: [PATCH] ; Substitute quotes in obsoletion notice in 'C-h f' To: Eshel Yaron , 66240-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66240-done Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Before this patch, `C-h f defadvice RET` says: > > This macro is obsolete since 30.1; use advice-add or define-advice > > The symbols `advice-add` and `define-advice` are not fontified nor > buttonized. With this patch the symbols are quoted like other symbols > in the *Help* buffer, and, more crucially, they're buttonized. Thanks, installed on master. [1: 8a635ac849d]: 2023-09-28 21:44:09 +0200 ; Substitute quotes in obsoletion notice in 'C-h f' https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8a635ac849d1cc79e0bb3d6cb11b0ff530500a47 From unknown Sat Jun 21 03:26:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Oct 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator