From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: casouri@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Sep 2023 00:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 66223@debbugs.gnu.org Cc: yuan fu X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: yuan fu Received: via spool by submit@debbugs.gnu.org id=B.169577391610154 (code B ref -1); Wed, 27 Sep 2023 00:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Sep 2023 00:18:36 +0000 Received: from localhost ([127.0.0.1]:50076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIGB-0002di-F0 for submit@debbugs.gnu.org; Tue, 26 Sep 2023 20:18:35 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIG8-0002dN-CK for submit@debbugs.gnu.org; Tue, 26 Sep 2023 20:18:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlIFk-0003bg-MS for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 20:18:08 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlIFh-0006wO-Pv for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 20:18:08 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 706A332005B5 for ; Tue, 26 Sep 2023 20:18:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 26 Sep 2023 20:18:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm1; t=1695773880; x=1695860280; bh=ds vByhHjo5xd6eKjg0aJi5XK2e9DtZVpkL/6SjuAtCI=; b=z/lnpCrs5Ux8lny6z+ 83BBB8RvnYC9rwzH52hLbh8EGpbupdFEknqc+E/FRkwpAc7N82F7Jb0XVnz3htSU 8Wy1zyURg2PwiVW7/TjddvowRNAOyKtP27h2dVUQbOh4d176jx6zfY3zWwypYYX5 gzewIJ7aq88RteOX7MJULitNt98GceOYTFvAFZstLqumE5N1kmkX8vyQ3C/OxgHr XGSY2e+eXS+y94zcm06X9pg/eFp472uIVS/PY26n1x9FPrRfCvzBFZPMU4+gY+Pj SiV8eWRJQDd8L5R+7sZPFrzsatpupYz3Sw8tzurnRVfWcYry5zN2w5UOEjOFAF0/ KSBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695773880; x=1695860280; bh=dsvByhHjo5xd6 eKjg0aJi5XK2e9DtZVpkL/6SjuAtCI=; b=AOd+S+RtOY7WD6HAkOYgPkfUogDGw oEZw3spDoTS3ut84w2DExAOtfwpxX8IA5CRqRgz/Wzw3nlj86dDei+B4Cg6emrod UnSUAbAqiXOZvUXbJ0uqZf2YUrTo91ANUWV67hevHvc/x11nTPx6dBzLL7SxuRXj rEJdCsdp7DEooIZzqtzT1Rnxg8OT4y0vbm4G8zgvHxhRcHGd0mL47H06qQEoVzVE vqQIK4mWdrVdllRpz4PxnGvA3RsWcgsGtjXH5DwzYbJrkQ4p+R9E3R9HiPfm8rkF mPgr8xB7UmGBLRVpfpFwKYw41XWFZukmG4f3MwInvl6uvbDXD+JYvue5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvjedrtddugdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfvffhufgtgfesthejredttd efjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhv rdguvghvqeenucggtffrrghtthgvrhhnpeeguedtueethfetleetffevveeiteelgfetke evfeeutdetjefgkeetteetkefhgeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrh ihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 26 Sep 2023 20:18:00 -0400 (EDT) Message-ID: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> Date: Wed, 27 Sep 2023 03:17:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US From: Dmitry Gutov Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=64.147.123.21; envelope-from=dmitry@gutov.dev; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) X-Debbugs-CC: Yuan Fu It doesn't seem necessary (everything seems to work okay without that call), and it's not the right thing idiomatically (the user should have the ability to disable global-font-lock-mode). If it does get called, the call to treesit-font-lock-recompute-features should happen before that. The report was triggered by somewhat unusual circumstances (somebody trying out mmm-mode together with typescript-ts-mode: https://github.com/dgutov/mmm-mode/issues/138), but the fix seems easy and natural enough. To reproduce the bug, though, try this: (with-current-buffer (generate-new-buffer "foo") (let (font-lock-support-mode) (typescript-ts-mode))) It results in Debugger entered--Lisp error: (treesit-query-error "Node type error at" 2 "(jsx_opening_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_closing_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_self_closing_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_attribute (property_identifier) @typescript-ts-jsx-attribute-face)" "Debug the query with `treesit-query-validate'") treesit-query-capture(# # 1 1) (let* ((delta-start ... treesit--font-lock-fontify-region-1(# # 1 1 nil nil) (let ((sub-node (car tail)))... treesit-font-lock-fontify-region(1 1 nil) font-lock-fontify-syntactically-region(1 1 nil) font-lock-default-fontify-region(1 1 nil) font-lock-fontify-region(1 1 nil) font-lock-default-fontify-buffer() font-lock-fontify-buffer() font-lock-initial-fontify() font-lock-mode(1) (progn (set (make-lo... treesit-major-mode-setup() typescript-ts-mode() because typescript-ts-mode's treesit-font-lock-settings hide the jsx rule (which the typescript grammar itself doesn't support, only the tsx one does) using the absence of that feature in treesit-font-lock-feature-list. But for that to take effect, the call to 'treesit-font-lock-recompute-features' needs to happen first. The jit-lock conceals the problem by inhibiting the first fontification until the major mode function has run and the buffer is visible. I ended up disabling it in mmm-mode's auxiliary temp buffer because it spams the message "Not enabling jit-lock: it does not work in indirect buffer". From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Sep 2023 07:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.169579931022927 (code B ref 66223); Wed, 27 Sep 2023 07:22:01 +0000 Received: (at 66223) by debbugs.gnu.org; 27 Sep 2023 07:21:50 +0000 Received: from localhost ([127.0.0.1]:50396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlOrm-0005xj-EF for submit@debbugs.gnu.org; Wed, 27 Sep 2023 03:21:50 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:55800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlOrk-0005xV-5Q for 66223@debbugs.gnu.org; Wed, 27 Sep 2023 03:21:48 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-69101022969so9385294b3a.3 for <66223@debbugs.gnu.org>; Wed, 27 Sep 2023 00:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695799289; x=1696404089; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=o+Zd6HED50MHmC/SpTV4cYUSZ+ZX5+oqJZGSPw4WKfs=; b=QobwgMIf8oMRfnuGmmopXa30QHwgqlauRZJxR3O0HxntnhreLtKLDRt+ImS80cgFRt hm1uWDVlhNsPw+z099Jpne92dafupCARVXY3eMCE16yLGQctPuIeEskMc06S4c5cYsqB Jv5FrJkYALGVnxX2+tnmiU9T8M0hwHVt4DsYAJzwX+nVzs1au+1t/NtVFgxndlprKz/B PsFvFA1axfdklepes/yBv02ga1J8EJyhGE+TADaiH9gRK2jtTMraQFvZznj8VH4/eD3S sBYszRHWwKl65BA/h5PVty8+CuX+gskqE/JgQFFzsM+SsiXfy/chitETFnUpuKFqAFH/ qL4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695799289; x=1696404089; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o+Zd6HED50MHmC/SpTV4cYUSZ+ZX5+oqJZGSPw4WKfs=; b=oHGBas8axx6ufPU4xGVZ8sfHHfIj69rCcV4KNlYIEHGsCIzcBBLYWiWSrPPSfO/Ehj ReipKjtRzY4fGiigbxpZ0Bg9+aKyfcE1GT8H++yGwrfWKaDmiQPcivoT+xUmi969SlGn kBfbHl9Sz5lvFc0ZC1ov01u8e6i5T+EyoUiwe07SSF1O8aJwcmZXKOj0tQub1/iMhJe5 hZagWtgq3T0StV+SvNu/fyoFaKstxJqVdpSAPU8js4LZcLB6s/RMyTW3vZKWgyRWURvL z4GjSCuz5AuWQS7+oMqODiVC+7tE7BcAZtLTPjBuWtB60mrDaRlcEe0z87s8C5TrbUwq SGAw== X-Gm-Message-State: AOJu0YxagpGudKk+ahHbEfb+T810xaKzSHwG6+vViuv1n2flM0xle81s oljo51cemiLsh95B0TNVFN0= X-Google-Smtp-Source: AGHT+IHcIK5SgdrneM8EAIXzgZBlr9b8bpJyQ+5C4a827f+v45AOBx/oZDNuAkZWJqojO4snzDbctg== X-Received: by 2002:a05:6a00:244e:b0:68f:a661:d037 with SMTP id d14-20020a056a00244e00b0068fa661d037mr1469689pfj.3.1695799288534; Wed, 27 Sep 2023 00:21:28 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id c14-20020aa7880e000000b0069100e70943sm11115963pfo.24.2023.09.27.00.21.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2023 00:21:28 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> Date: Wed, 27 Sep 2023 00:21:16 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Sep 26, 2023, at 5:17 PM, Dmitry Gutov wrote: >=20 > X-Debbugs-CC: Yuan Fu >=20 > It doesn't seem necessary (everything seems to work okay without that = call), and it's not the right thing idiomatically (the user should have = the ability to disable global-font-lock-mode). >=20 > If it does get called, the call to = treesit-font-lock-recompute-features should happen before that. >=20 > The report was triggered by somewhat unusual circumstances (somebody = trying out mmm-mode together with typescript-ts-mode: = https://github.com/dgutov/mmm-mode/issues/138), but the fix seems easy = and natural enough. >=20 > To reproduce the bug, though, try this: >=20 > (with-current-buffer (generate-new-buffer "foo") > (let (font-lock-support-mode) > (typescript-ts-mode))) >=20 > It results in >=20 > Debugger entered--Lisp error: (treesit-query-error "Node type error = at" 2 "(jsx_opening_element [(nested_identifier (identifier)) = (identifier)] @typescript-ts-jsx-tag-face) (jsx_closing_element = [(nested_identifier (identifier)) (identifier)] = @typescript-ts-jsx-tag-face) (jsx_self_closing_element = [(nested_identifier (identifier)) (identifier)] = @typescript-ts-jsx-tag-face) (jsx_attribute (property_identifier) = @typescript-ts-jsx-attribute-face)" "Debug the query with = `treesit-query-validate'") > treesit-query-capture(# = # 1 1) > (let* ((delta-start ... > treesit--font-lock-fontify-region-1(# = # 1 1 nil nil) > (let ((sub-node (car tail)))... > treesit-font-lock-fontify-region(1 1 nil) > font-lock-fontify-syntactically-region(1 1 nil) > font-lock-default-fontify-region(1 1 nil) > font-lock-fontify-region(1 1 nil) > font-lock-default-fontify-buffer() > font-lock-fontify-buffer() > font-lock-initial-fontify() > font-lock-mode(1) > (progn (set (make-lo... > treesit-major-mode-setup() > typescript-ts-mode() >=20 > because typescript-ts-mode's treesit-font-lock-settings hide the jsx = rule (which the typescript grammar itself doesn't support, only the tsx = one does) using the absence of that feature in = treesit-font-lock-feature-list. But for that to take effect, the call to = 'treesit-font-lock-recompute-features' needs to happen first. The = jit-lock conceals the problem by inhibiting the first fontification = until the major mode function has run and the buffer is visible. I ended = up disabling it in mmm-mode's auxiliary temp buffer because it spams the = message "Not enabling jit-lock: it does not work in indirect buffer=E2=80=9D= . Makes sense. We can remove that line in master, and see if anything = comes up. I don=E2=80=99t remember why I added it, I don=E2=80=99t think = there was any particular reason. Yuan= From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Sep 2023 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.1695804746560 (code B ref 66223); Wed, 27 Sep 2023 08:53:02 +0000 Received: (at 66223) by debbugs.gnu.org; 27 Sep 2023 08:52:26 +0000 Received: from localhost ([127.0.0.1]:50458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlQHR-00008y-P2 for submit@debbugs.gnu.org; Wed, 27 Sep 2023 04:52:26 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:56409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlQHP-00008g-3i for 66223@debbugs.gnu.org; Wed, 27 Sep 2023 04:52:24 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 6A0EA320046E; Wed, 27 Sep 2023 04:52:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 27 Sep 2023 04:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1695804722; x=1695891122; bh=BJfuEdIroHm4gp31kaAdUcJ0JBrIjpzIwQZ YYQ2VCpM=; b=U9q52/TuBezcRRkrM0RlOKqu3eUQDHXVmgCyeehlyf8m/necwex Hp8U558Bc9P2CeqFohliSfvQkK1SGtA7aQEGc7Azsavcidi/u6PZdaxG1Z+DEaoq yn6s4MLRIrrrk+Qi5daNO6zHdSzfVkXvtjwOyE73ouFW4vNKNBg3aay7uD0uLkBV ypODsk4qPlgja2znTGFdLAIus2DASGn/oLdWJgR/qoCE/IZB0Gm9TtltxuNljiFP e2mFIDIWN7pt6LyrkvOHeanzz28SW+RqFrRNRiCVJLUoXnzscNH46dbyNaXkOTd5 5NtqjxnvtUJebGr82IE0iIT9VOsOH/kge8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695804722; x=1695891122; bh=BJfuEdIroHm4gp31kaAdUcJ0JBrIjpzIwQZ YYQ2VCpM=; b=bs5TpISOUrp0XS7OFz5GuLaZSMZ2ytrT6rMNmIQyBKt39XVicQ6 bX74vlCyAPxJQCaRRES3+Pgrw/m81WT2wWHf94FohbiSZ431NudQgjFWR53ZrIPv yc/2DjNeoZxzX5LhuEtXxpqHFodjwQlDJ0UgIZEW5aPR6i/bi8IUmxaTEp6XDmLp Kxf9csvO3PsaIrliLhTWeWflShGNXv3KUBBYlnFCHnKdvAWYmNZ7rJApe7kemERn a6BwMXUDLExNVUj/M/UT6a42UCcaPWLCiAFjz4sBOGvaf9+6GyCX4WdbWfoM0KgK A4tLfhsX5GcKiUlvsw1Mt5MFxwrSB+wpZ4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvjedrtddvgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtke ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhephfffheeljeffgeffueeghfekkedtff fgheejvdegjeettdduheeufffggfefjeehnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Sep 2023 04:52:01 -0400 (EDT) Message-ID: <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> Date: Wed, 27 Sep 2023 11:51:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> From: Dmitry Gutov In-Reply-To: <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.2 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On 27/09/2023 10:21, Yuan Fu wrote: > Makes sense. We can remove that line in master, and see if anything comes up. I don’t remember why I added it, I don’t think there was any particular reason. If we have to start on master, so be it. I'd like to see the fix in emacs-29, though (at least eventually). From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Sep 2023 11:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov , Yuan Fu Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.169581338414463 (code B ref 66223); Wed, 27 Sep 2023 11:17:01 +0000 Received: (at 66223) by debbugs.gnu.org; 27 Sep 2023 11:16:24 +0000 Received: from localhost ([127.0.0.1]:50645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlSWi-0003l9-L2 for submit@debbugs.gnu.org; Wed, 27 Sep 2023 07:16:24 -0400 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]:44351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlSWd-0003ka-4I for 66223@debbugs.gnu.org; Wed, 27 Sep 2023 07:16:19 -0400 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2bffdf50212so176363501fa.1 for <66223@debbugs.gnu.org>; Wed, 27 Sep 2023 04:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695813355; x=1696418155; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=bfXwHiMWv6shOrUEh1CMny30biNsbtkz1/mnkaUIuTw=; b=Bv4p+ajCzvxsEalUlJ2ywdwQa3TADi33YZuv/g2qfa2Xj0sssV2KeyAhaA7gnAlID8 K75egYRr79lEIB6eg98rLxG+AbXqhIBkBVDuBN2l7i/u2i5eouAh5WbEuH8Z8UoUuo05 MGSu2zksPSnWJ/lP2RF/QopUc+h+5SWurc9DgZSrUCoIcVsLe6dtbcpHsBy24hz9RNzs o4X5JOGWvJLYh918SuROfXNBzvrx7Si1TpK/kLfdrDVqD0d19rw4cPb/nFs/jSGzSXaN L+v5vA2wBX+Qm+7Ir0yI8g3FIVsHmfZdJm1DPOO0Ib82fckfH2exhLINbP73GLoUxGv9 AF/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695813355; x=1696418155; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bfXwHiMWv6shOrUEh1CMny30biNsbtkz1/mnkaUIuTw=; b=QqY/FHEsWO2eHxxEG8rIPodXRpcRV8fBFRohn6OWti9XfiUMmWSNbPe7CO2inw7jNn KJ6GptATPEd0ecYOULWxuBLy6d4gZqZwIrNA1Wv/WeTJb/dTm0zGaqN//YuPDw30O4V+ 9rGGzIAQu4nG6X2PFQbGVYi0IZJCaWfTT15oxiwFc3qPTSipn9eMt0VuuUDDgm38vPsw 0zSW06qLzl41PFm5shcBAy0/A0bC8g842B2TIXnWj74bRS3je4hn4LS97Y+AFrVMj4NE XBB4fVbCLdSnOMJquQfyGsx8e0h923Cmlw8BxxgkmX07WcTpU2W68FUitNH9mvfEuaDC 7WUg== X-Gm-Message-State: AOJu0YztY1qzo+kVwSaTgGirlOD9vyOFr0c9LiUPr/aBXKcEVofXsifU 92QtiPkB1L6EZV3pnDbNt4uwy6KWs0mxr5sWgq4= X-Google-Smtp-Source: AGHT+IEvt+7uWZ2VosUeixE3wNz8rDwcuuDfZ0+dqTdWkxfVAgQwZ3ff96YXyA/zJnLE0QvAGJze9NbEI1XOAg3xNos= X-Received: by 2002:a2e:3611:0:b0:2bc:eaec:e23f with SMTP id d17-20020a2e3611000000b002bceaece23fmr1871567lja.43.1695813354696; Wed, 27 Sep 2023 04:15:54 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 27 Sep 2023 04:15:54 -0700 From: Stefan Kangas In-Reply-To: <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> MIME-Version: 1.0 Date: Wed, 27 Sep 2023 04:15:54 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 27/09/2023 10:21, Yuan Fu wrote: >> Makes sense. We can remove that line in master, and see if anything >> comes up. I don=E2=80=99t remember why I added it, I don=E2=80=99t think= there was >> any particular reason. > > If we have to start on master, so be it. I'd like to see the fix in > emacs-29, though (at least eventually). Sounds good to me, if no one has any objections. The call does seem superfluous there. I've noted this bug in my list of things to revisit before the first Emacs 29.2 pretest. It doesn't hurt if someone else helps remembering it too, of course. From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Sep 2023 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas , Yuan Fu Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.169584377714533 (code B ref 66223); Wed, 27 Sep 2023 19:43:02 +0000 Received: (at 66223) by debbugs.gnu.org; 27 Sep 2023 19:42:57 +0000 Received: from localhost ([127.0.0.1]:52546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlaQz-0003mL-DH for submit@debbugs.gnu.org; Wed, 27 Sep 2023 15:42:57 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlaQw-0003m7-P8 for 66223@debbugs.gnu.org; Wed, 27 Sep 2023 15:42:56 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9FCC25C27C9; Wed, 27 Sep 2023 15:42:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Sep 2023 15:42:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1695843755; x=1695930155; bh=LyMEoDc26ioMxGXXlZHvXhz3saGrVlPPJgK OglSCuGA=; b=W7sXwMT8btaN5dVnBjbq5TFvCMZQ5W8US3kovOHVV9nNu61pAo8 Pzln0eq2pP0oDv22bIr3DyywZshM3ZIv8/WrrT+lmKnLDch94PCpo9Y1Rc9PKXFB e4Fts5KTon9yRS9fKPFcZ+UFkCENNkFmDN6mD9j0Lqn/HZi3dumfmKn1QSDZ9mwb cCnMKjnrULDeCYIWo4PCWqoo6FnbsNefHUZ/AKlITMwYEJZhXtkVOTVM8kdz+zFz ojV2e9ZU02YRQzrdvNhIKQiq1naqD0WhTzDAnCqvAuVznN2N7d2FDBeUefNWZV5J C9GFNbSnzSp6We+hWv7ZQDFDZXXSe3yLaUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695843755; x=1695930155; bh=LyMEoDc26ioMxGXXlZHvXhz3saGrVlPPJgK OglSCuGA=; b=URO3YMl9qlQIzxpYCOemMoELnlXcfnDTyFb5ygMGv+0Kf6gK875 mQHdY1lp7POHn0dFdT7VHtjVzHLEtK77kdS7OGuO60RhvjRrldHXn+KnRrS5e98E 0RQhANkl7mfxSE5F2kezmsL1iTPKZ1FurP363VHfCcm2iCV0QDz8bq7Vla7yPjkO nMv0aYyXtyzjOdnwkAXyE5jDWW6WHKNUxMDz2ZiCJtKsXlG8ep8jVgvmhkzzhM+F 0CKNPgNFnFAxkKeVpZWJ0vOYvNaCINsODkcwZ64Oe2JFIIy4QWNWgExCeGFQDQhV hZIPOyXHKcdqmSithsc6AJPuY+VdT/VhGhg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvjedrtdeggdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Sep 2023 15:42:34 -0400 (EDT) Message-ID: Date: Wed, 27 Sep 2023 22:42:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.2 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On 27/09/2023 14:15, Stefan Kangas wrote: > I've noted this bug in my list of things to revisit before the first > Emacs 29.2 pretest. It doesn't hurt if someone else helps remembering > it too, of course. Thanks! From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Sep 2023 00:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.169586065721047 (code B ref 66223); Thu, 28 Sep 2023 00:25:02 +0000 Received: (at 66223) by debbugs.gnu.org; 28 Sep 2023 00:24:17 +0000 Received: from localhost ([127.0.0.1]:52730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlepF-0005TP-2b for submit@debbugs.gnu.org; Wed, 27 Sep 2023 20:24:17 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:58539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlepB-0005T8-2x for 66223@debbugs.gnu.org; Wed, 27 Sep 2023 20:24:15 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-578b4997decso9770184a12.0 for <66223@debbugs.gnu.org>; Wed, 27 Sep 2023 17:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695860633; x=1696465433; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5/hN7pf/bW/PqW58Vn8wi6k4M3ZXKI7WO7pIgF2nBgA=; b=L/id0OGmZVqdkxIEIzF5E9fr7Y6cLL6b1JH7qpqT7cuAb+OcN0DhthWQ3pZ2GwoHM7 O8uP4aqlvSwcTGBNvd5quF1tMbl5J8pdf/OvD/6UXONcoqWX1QX3qwxU9XZ+GXVdHVd1 UkdZWrdrvMiJDScBhwL5z70pro3gLJDtxtOlG03L5DWRUvdJQwQKUZwFnria2+FsRWHu YSCnAsTSDS3JMVsfIQVmgDN89JfyBQyXCFnM6VtGyWkawCG8A+/iBhzUj8yFBARoqC1E KY6RJONNqzZdAgA8swFdPQoHcs5niuxIJMeOM7IubLMPbBu1AC+qfqIrgXzyibSsCotC t3AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695860633; x=1696465433; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5/hN7pf/bW/PqW58Vn8wi6k4M3ZXKI7WO7pIgF2nBgA=; b=PKjeo+1ke//cMVvTRdl6lhSknPwoH6aAmGfJGD741vksGs9f9PnsiNtPFl+Z1MzNU0 tjM5CzGWK2R+iLvfVOD7c8YG2Mj+kux5p24WyRgr1XexFy6MzYEPq5/Byus0yJ8NFdxp ubyGv+MnoXVHTP2weO6Cay6wQ0eBx4tPgasQtwF24o4k9ehaZmOV9vYrV/fFyuTxK/XT gjs/LMd/Q7EuqpvfrYHjECVDJqfiHyqtkRWhnhMX/R4lOW7e9Wf+8vAq7+xpML2E2e8W xAj6qUhiO6V1uSh8ybVFm4jsKRtbxXeej8XDconT+gYPErwkAoMOxJgayWLHc6cExvUL lcVw== X-Gm-Message-State: AOJu0Yz3cvkHJY+UpTwVtssQpvDCfL/YyFH6nGA1+1L6Q5XdViOaa7Cf 718btd9AetbPKzmCXtv9JF0= X-Google-Smtp-Source: AGHT+IEHhXVKMBmBR7jmF8oqYO1mBJyV5Q+nOZxBMZPG54EzjWze9YFVzzOUCewXXH3CWHfbfRd/cw== X-Received: by 2002:a05:6a21:1f07:b0:15d:6ea0:82da with SMTP id ry7-20020a056a211f0700b0015d6ea082damr2945363pzb.33.1695860633106; Wed, 27 Sep 2023 17:23:53 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id jb12-20020a170903258c00b001bbab888ba0sm6653981plb.138.2023.09.27.17.23.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2023 17:23:52 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> Date: Wed, 27 Sep 2023 17:23:41 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Sep 27, 2023, at 1:51 AM, Dmitry Gutov wrote: >=20 > On 27/09/2023 10:21, Yuan Fu wrote: >> Makes sense. We can remove that line in master, and see if anything = comes up. I don=E2=80=99t remember why I added it, I don=E2=80=99t think = there was any particular reason. >=20 > If we have to start on master, so be it. I'd like to see the fix in = emacs-29, though (at least eventually). Yeah, let=E2=80=99s test this out on master for a while and apply it to = emacs-29 if no one comes up and complain. It seems to me that 29.2 is = still a while away. Yuan= From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Sep 2023 03:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 66223@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16958724647571 (code B ref -1); Thu, 28 Sep 2023 03:42:03 +0000 Received: (at submit) by debbugs.gnu.org; 28 Sep 2023 03:41:04 +0000 Received: from localhost ([127.0.0.1]:52815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlhtg-0001y3-2V for submit@debbugs.gnu.org; Wed, 27 Sep 2023 23:41:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlhtZ-0001xN-Os for submit@debbugs.gnu.org; Wed, 27 Sep 2023 23:41:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlhtG-0007Ad-8l for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2023 23:40:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlhtG-0008PE-0R for bug-gnu-emacs@gnu.org; Wed, 27 Sep 2023 23:40:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Subject:To:From: Date; bh=xm2wHK2ARDgwwOKs67aVunvNMgt03x/0uhWmJTGxQDM=; b=XaYEBkh9JUdsnS2wOd7I HVlLt19dF5J/RBB1pHQMjZvRKYhWKnkDluh/zYzESurtYymt9+aTV9IXASWbKffsmvr7754xOX8EA tFg9suSOpw0dXUA5+U0/ZEnukDOizLRdVp+f0/VP2oZL8BthjOhcGr76ouI4ZamjyTSQn+yXTJJWS Sww35Jj7NoIhtmaTL6Q0itWWyeNCrgo8JlVDR5y/X7MWT2SdcDe91gO9lATyMm+gKDD/fqWRnX/v1 csL7Axz7EHsUtuPmzE2acd9OMoo1VlDzGDyMqoQ9jIyWs0zYOU4ceRCvJwGcvsaDIEc4weiof+uq+ INd8dgyOpAAWYg==; Date: Thu, 28 Sep 2023 05:40:32 +0200 From: Eli Zaretskii User-Agent: K-9 Mail for Android In-Reply-To: <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> Message-ID: <41F82630-B664-4195-BA0D-A1701C6C9CB7@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=eliz@gnu.org; keydata= mQENBF+pf4UBCAC6vjkWLSAsQpe8YIGKLQzNOJx/IjGtCdFF8uzmO5jmME+SD8ROuJN+t5KXVw58 uzu75EFD0vHTY9e+udJ2gkpuy0NnzkFcbumdLLo2ERKCoSctZZRhzKXI5z5cHxCqW0B2ygHRrRLt oNlGID7bAgcgSViT1ptGqTXO7zGVu4Airok7dNzcPtHgns8GlR5YAFX0TvE6oGd0l2VPghNeVJKJ OjrbfhoDxl3ucFpqbqMH8z9HTLDOFpz8UaYYUdJMi3xX6vwTZxI2sM2RRVLUpZyllAkSMI4lln1O OgazM/62DJUs/rKIHKBnF6h3/qsJUjUYXaAHbrXY26mWllAd536lABEBAAG0I0VsaSBaYXJldHNr aWkgKGVsaXopIDxlbGl6QGdudS5vcmc+iQE4BBMBAgAiBQJfqX+FAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAAKCRCRwSYvAeuNOYUQB/4/iIKKOG45ijNaRoTvmJJZMvj1S07WQxEm7c5SHEeE QbLOAxB9vESOV7sLueuN3oqEndtzyYt4x1WTSBmHFF7h5fcCMjBs41siOIp5Sj/xD0Bvaa0IKGCR SZ7PAo8Mq3wgajXpTpn9vxE2PmtzA8KdEE0K1+f9pVAfOpUIcCl44rIxLUW352XG0y7iz6c/O6LB 1deOKMiKFctKO7pBti1dJEm1ImewLH3H8uTbwspLOs3EB8xhsESxmTidnze68HX2jt+2EeMgCdki NU+LWbexQZPfIS7+ZmE06ll0v6+Jy7ZdTkCCRypKWTnW7pIFsq/p4kybV8O/kHSV6B4vvQBfuQEN BF+pf4UBCACvFrdx/m22lgObypSmSS4TNlNvQnMUorrMmp0U32hv5adt6CKXeMjk05F+GcIfVMrp xqMBn4sEUIXWhhogQJa9ZbWEP/HbS8XjMMbz0Q0Siaty9+DSspK/9u2GWKsz3uQzLCexIJtzmXvj AVmvoMCAU/F2t038ggygjYLRgyLRNLgbbartu2dMkvrfxRjheip60S4S3utOcwUf/qdoa1grNann CFluHr/ftXCeeuGB4H8iO0BXWNby6NZPizxJttx9gdcH8/OmDOJkXyRMTT/3sSem76CSOjfXcz7s aJlg680NQhG5TmuYERjJD4+U02K5RuqTsEnOuWeFy4p+/mslABEBAAGJATYEGAECAAkFAl+pf4UC GwwAIQkQkcEmLwHrjTkWIQTmyQKcNjrUHXh6jruRwSYvAeuNOejsB/9rVegsfEBSRLjeeYXyJrOf dme7BYpYsQCw2vGTnrJTGFQ9HM2zT9+wAENBHWjQPJOptJwo5w4xIbZgwJy0uIN3sV18xbCRSxX0 ZSk8GJG0PrQTCaf2xs0kqsShnkvqyo5QSyUlFUAG7m1o7NUhF95Q89oxGO8JyvR356kqNbzUn0Cq PxKyS42QfC8dyFNgVhVPbZp6aONnUwY5SbtCLJtZCBgvppI9XaBH41BDukSE4GgSLoYsSIGShg4h e+bGypAsGtQ9uwmryUi1gRrDgca3wFo/G0rbJn2ZKoLbGFZivWPVgAgd9/O5sLSPFznOdcRGxEA2 gk7A1ReaJ10PtQz0 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On September 28, 2023 2:23:41 AM GMT+02:00, Yuan Fu w= rote: >=20 >=20 > > On Sep 27, 2023, at 1:51 AM, Dmitry Gutov wrote: > >=20 > > On 27/09/2023 10:21, Yuan Fu wrote: > >> Makes sense=2E We can remove that line in master, and see if anything= comes up=2E I don=E2=80=99t remember why I added it, I don=E2=80=99t think= there was any particular reason=2E > >=20 > > If we have to start on master, so be it=2E I'd like to see the fix in = emacs-29, though (at least eventually)=2E >=20 > Yeah, let=E2=80=99s test this out on master for a while and apply it to = emacs-29 if no one comes up and complain=2E It seems to me that 29=2E2 is s= till a while away=2E Actually, it isn't: I was thinking about starting a pretest soon=2E From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Sep 2023 04:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.169587696014878 (code B ref 66223); Thu, 28 Sep 2023 04:56:01 +0000 Received: (at 66223) by debbugs.gnu.org; 28 Sep 2023 04:56:00 +0000 Received: from localhost ([127.0.0.1]:52834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlj4B-0003ru-My for submit@debbugs.gnu.org; Thu, 28 Sep 2023 00:56:00 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:47230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlj48-0003rf-Le for 66223@debbugs.gnu.org; Thu, 28 Sep 2023 00:55:57 -0400 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-578d78ffdbcso7783553a12.2 for <66223@debbugs.gnu.org>; Wed, 27 Sep 2023 21:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695876937; x=1696481737; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=u1mVnuu5timqKD99O7jlyTZie0MzGmvrKP5D6FHPpFc=; b=OE9s9nsfCxs0xOcVB5zNLDyWwilQfdxbyLv5MgYNBnmnO2R3BhKmOCxfgTeOlwQ7Vg x05GvDh4S41seaxwZoT3o+R2PY15pJqw+h7HGCs0YbFBGFurnojbURS2o7893O6wAWh9 7v5KsTSqIU/eVfiGvg9st9SlvMUAjUBDoi+oq3UdgLQK9Sd53qgeTHcLiBkowHsl/IT7 y/bv5xYQpWUvH21K8FW6Yt4297dzdsuPhrF82/dt6USQwloxE7Bgx0pc8Sye/pfKVonH a7SNJL70wVZKOn13Ir6ChQqXqh2+PaGC90PpxpX2AzV4GIqQacgmGOt48cEw55kbMnrG pe5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695876937; x=1696481737; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u1mVnuu5timqKD99O7jlyTZie0MzGmvrKP5D6FHPpFc=; b=UEAuIc5vmCQaqddEpLalK5Y9NBAVdMi36WHaZvm+Ozrx0VpHH+bs2u1PGSYeaAe4I9 XLVxD+rs+d7ynHigNigDmxRIqYn5rYdJ+LCAUqGhOxBfILa87hAFOnElv680xDvEe71X ShvGnhNyXPc5l40x+O16fb6blEQHWDi/FHsLwKh6t76WF5bHYhkbnI9TdACq2CFQCorZ GFZ+m8ZHSOhOx1TQJPap2AKKQA+xTIDiKl7iGLuBm0EnMsC6dENciDqe1e2dEFkHcqmz s8Jzs7/T+p9hwlujOGI9RY3u/LAHH16YfctcqPC0E54WGzDPa7VATChTNxJGLafPhldC XUqg== X-Gm-Message-State: AOJu0YzQS5cFZJWzNSc9HhZjhB9pjlHIUOO8qg3XUMqys0APnwh/jze1 5mktb+/3IJIzvrTgUH1mGGI= X-Google-Smtp-Source: AGHT+IHPpzo0mHr8T1w8GfNtp8xCFE50p/M3AHfPD2ua8FZCCDI+9RqrAm0dW1l0hy39vrC5zpkXhQ== X-Received: by 2002:a17:902:ef96:b0:1c4:6ca6:35b3 with SMTP id iz22-20020a170902ef9600b001c46ca635b3mr114869plb.44.1695876936561; Wed, 27 Sep 2023 21:55:36 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id iz19-20020a170902ef9300b001bda30ecaa6sm14086263plb.51.2023.09.27.21.55.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2023 21:55:36 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <41F82630-B664-4195-BA0D-A1701C6C9CB7@gnu.org> Date: Wed, 27 Sep 2023 21:55:24 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <457CAAB8-124C-4369-BA1E-A0EE7EA98AF2@gmail.com> References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> <41F82630-B664-4195-BA0D-A1701C6C9CB7@gnu.org> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Sep 27, 2023, at 8:40 PM, Eli Zaretskii wrote: >=20 > On September 28, 2023 2:23:41 AM GMT+02:00, Yuan Fu = wrote: >>=20 >>=20 >>> On Sep 27, 2023, at 1:51 AM, Dmitry Gutov wrote: >>>=20 >>> On 27/09/2023 10:21, Yuan Fu wrote: >>>> Makes sense. We can remove that line in master, and see if anything = comes up. I don=E2=80=99t remember why I added it, I don=E2=80=99t think = there was any particular reason. >>>=20 >>> If we have to start on master, so be it. I'd like to see the fix in = emacs-29, though (at least eventually). >>=20 >> Yeah, let=E2=80=99s test this out on master for a while and apply it = to emacs-29 if no one comes up and complain. It seems to me that 29.2 is = still a while away. >=20 > Actually, it isn't: I was thinking about starting a pretest soon. Thanks for the heads up. We=E2=80=99ll need to remember to add that = change before the pretest is cut, then. Yuan= From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 23:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.16968062479304 (code B ref 66223); Sun, 08 Oct 2023 23:05:01 +0000 Received: (at 66223) by debbugs.gnu.org; 8 Oct 2023 23:04:07 +0000 Received: from localhost ([127.0.0.1]:58861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpcog-0002Pz-Uw for submit@debbugs.gnu.org; Sun, 08 Oct 2023 19:04:07 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:59666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpcof-0002PS-Fq for 66223@debbugs.gnu.org; Sun, 08 Oct 2023 19:04:06 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-690fe10b6a4so3250366b3a.3 for <66223@debbugs.gnu.org>; Sun, 08 Oct 2023 16:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696806219; x=1697411019; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pQ2+F+jCtR4/LjkA6PTb+daAR+U0pJmpsUQ/bdczntg=; b=HOFpTHPtG5dAJ1uUQ5B5pRiVUx7SKLk/5FcL3I1pnXtfaUcsDkcy3kpxRk5lThbwYy TIwDXTicQQOO7SQwvzk6Xao7ggd4skoo2MwegtTJnnAkhnVnZKV+q/WG3l74+dt7V1zD lLqGwmna1HDwZaUbhVco0TvqiO9vNc2Rz0Sxdgd6UbFfyt5wMorx5k/198X+nKZBt9tz qMnUSYL8B4Fq8IbAWau5BbmedxaGMqv23cb5bDZTvitT7tHdPW/4M5p7IwLfLjvqQdCc zBfAUR7pVou1bMPU4alJz3FsJdVP7rcXaorSHS8tXa/qJ9eUXW+EWrQeIIMURprRAwU9 Uf7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696806219; x=1697411019; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pQ2+F+jCtR4/LjkA6PTb+daAR+U0pJmpsUQ/bdczntg=; b=Kk5NTiFIw1mqY1DfGnhADB/r0p9U4mDx7j0N77B0QLv7le+yefKg5pRbPcSFUCUG4S oPsv4pXTDMg+oj/IC0YEM7Hyp6RKi4Dm7t1aMyCV1nJH2J4WZqT81u92b0gqw1Yg4fwV 6+qKeFw5d9wysq++cx/v3F8CLBUEYbGuYqFj28dI1ws3aFOynsTkp520LjIXCQTXe0d8 dhFv1eB7Mf4xX6EI4arbmWsoHjXGFwG6N/N592gQIrXrmORpOqYRSEi4f1tbj9gBtkbt YbVJiwjRm6EDQsvIRa0GfI+BbevWKsuENEfSeD4muqW4+eOd9iJcri5L1bqCwYq0i2sK Dykw== X-Gm-Message-State: AOJu0YxNatxWifqU3gP/VkYV6za8cVAhLI6mV+dtvLaBylLtzfi13eL2 ZXPwfkO3lTrk7BUXHwvtRv2MB29wct4= X-Google-Smtp-Source: AGHT+IGj3/LJfufmriksUYB6RsU3BnlAQp97wW5dbG2Z0x5Rn0ZwrWv55iSfiHzUh/XbgHoXDioeGw== X-Received: by 2002:a05:6a20:da9a:b0:16c:b580:2a03 with SMTP id iy26-20020a056a20da9a00b0016cb5802a03mr8374463pzb.24.1696806219286; Sun, 08 Oct 2023 16:03:39 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z18-20020aa791d2000000b0068fcb70ccafsm4962380pfa.129.2023.10.08.16.03.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 16:03:38 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) From: Yuan Fu In-Reply-To: <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> Date: Sun, 8 Oct 2023 16:03:27 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <9160A07F-5297-43CA-8859-3FCEA3C62726@gmail.com> References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Sep 27, 2023, at 5:23 PM, Yuan Fu wrote: >=20 >=20 >=20 >> On Sep 27, 2023, at 1:51 AM, Dmitry Gutov wrote: >>=20 >> On 27/09/2023 10:21, Yuan Fu wrote: >>> Makes sense. We can remove that line in master, and see if anything = comes up. I don=E2=80=99t remember why I added it, I don=E2=80=99t think = there was any particular reason. >>=20 >> If we have to start on master, so be it. I'd like to see the fix in = emacs-29, though (at least eventually). >=20 > Yeah, let=E2=80=99s test this out on master for a while and apply it = to emacs-29 if no one comes up and complain. It seems to me that 29.2 is = still a while away. I have been running with the fix for awhile and didn=E2=80=99t notice = anything. No one seems to have complained either. (Hopefully there are = people building master and running tree-sitter modes other than me ;-) I think we can apply this to emacs-29. Is there anything I should do? Do = we just cheery-pick the commit into emac-29, or there are more elaborate = operations required? Yuan= From unknown Sun Jun 22 11:47:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#66223: treesit-major-mode-setup should not call font-lock-mode Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 23:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: 66223@debbugs.gnu.org Received: via spool by 66223-submit@debbugs.gnu.org id=B66223.16968063929529 (code B ref 66223); Sun, 08 Oct 2023 23:07:02 +0000 Received: (at 66223) by debbugs.gnu.org; 8 Oct 2023 23:06:32 +0000 Received: from localhost ([127.0.0.1]:58866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpcr2-0002Tc-Ea for submit@debbugs.gnu.org; Sun, 08 Oct 2023 19:06:32 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:50987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpcr0-0002TO-2x for 66223@debbugs.gnu.org; Sun, 08 Oct 2023 19:06:31 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B0FA05C02C3; Sun, 8 Oct 2023 19:06:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 08 Oct 2023 19:06:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1696806363; x=1696892763; bh=JJOZFfMwroCKvgfT94ylGp0mBAKxNe5bSQ0 ydLbg484=; b=GokA/ZjsxWqSens73UMyy/mQ9gYjcvKgbvxfk7uBW3dH0klQuRZ z5Y4YriTog/7ZdXEXTXGB3iQcoLuuqFSXsHCdQ0WfAF0DquqD0ahai6DBZZ5Z0yH iTr1u2+h9Cn3ubzTCSAVLzrrNRAgCzZfMUOK2EhUglOM9Svyx1zqNrpw6W4yPPDr zIcuHJfz8THAKDTSyxn1oavCWl337iK+xxjn6JTX+8MAOHgQtAp8j6enGr8Eaj58 TVqsRJUCXy5iRytkxKeNV9eJnnAk5o5yxWNaw8TUcQ6uiYTr+tn5VfiyvrKjuFZc pSZ8Cr9oP4DVKQq8fG0osNKARj+KUF7G1jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1696806363; x=1696892763; bh=JJOZFfMwroCKvgfT94ylGp0mBAKxNe5bSQ0 ydLbg484=; b=L/MrF1WM7XfvCJ8KGxpx2UtkHLFuG/dTgX6n+YHMNX7zGIzkQOh PbMtM9mun9VxqUuZC5gb4n4bv/m4KGCrh7S2eJ7c/9g2YX/KcmDkZDKfn286wwLE jwaEDrIllOErM0ebZG8mw7uTZLgxk1WUN5lPpLJxeWBS9UpJvf5wSRvKva/6Xrii 0vKvhLLqTcdfrt4uzPHcJ6qr+s6J6GcI4XglRYqpSBtuuQWa6wgwvZbczzoIqbQi kbRn9DUmxFJpTau3BtQv9vxJGhUSkIxRJ6DUGM6H9eOx26SsPJ3FWxFtPIL176Q+ y0OHsgqBoxBn7bIHP6HlKLH2qE3UZr77gtQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrhedvgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepiefgteevheevveffheeltdeukeeiie ekueefgedugfefgefhudelgfefveelvdevnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Oct 2023 19:06:02 -0400 (EDT) Message-ID: <72f5b67f-a71c-c027-c8c3-d373ae8dea35@gutov.dev> Date: Mon, 9 Oct 2023 02:05:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> <9160A07F-5297-43CA-8859-3FCEA3C62726@gmail.com> From: Dmitry Gutov In-Reply-To: <9160A07F-5297-43CA-8859-3FCEA3C62726@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.2 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On 09/10/2023 02:03, Yuan Fu wrote: > I think we can apply this to emacs-29. Is there anything I should do? Do we just cheery-pick the commit into emac-29, or there are more elaborate operations required? As per admin/notes/git-workflow (I'm not sure why it's that far away), ... cd ~/emacs/emacs-29 git cherry-pick -xe and add "Backport:" to the commit string. Then ... Thanks! From unknown Sun Jun 22 11:47:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Dmitry Gutov Subject: bug#66223: closed (Re: bug#66223: treesit-major-mode-setup should not call font-lock-mode) Message-ID: References: <2A274345-06E1-4D78-815A-8D93057B1343@gmail.com> <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> X-Gnu-PR-Message: they-closed 66223 X-Gnu-PR-Package: emacs Reply-To: 66223@debbugs.gnu.org Date: Mon, 09 Oct 2023 05:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1696827902-23635-1" This is a multi-part message in MIME format... ------------=_1696827902-23635-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #66223: treesit-major-mode-setup should not call font-lock-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 66223@debbugs.gnu.org. --=20 66223: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D66223 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1696827902-23635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 66223-done) by debbugs.gnu.org; 9 Oct 2023 05:04:45 +0000 Received: from localhost ([127.0.0.1]:59030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpiRh-00068Z-04 for submit@debbugs.gnu.org; Mon, 09 Oct 2023 01:04:45 -0400 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]:58581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpiRe-00068I-Ol for 66223-done@debbugs.gnu.org; Mon, 09 Oct 2023 01:04:43 -0400 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-1dcfb21f9d9so2556567fac.0 for <66223-done@debbugs.gnu.org>; Sun, 08 Oct 2023 22:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696827856; x=1697432656; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2bO+J/ddJTh/IWxm9aK+yn2/0A+u8AVXwl6IHY19/+M=; b=ghNE9AsGnZCM2hh5SmJvId+ScGpIT8TU3Zzl+BXtMq5Ivzqalz8ACtXClFhYw1u+Ev IcoGuR7y8d5w2F0++BKucJtXmG3U1B45/GBbZ/qo/QW+Grt+cns/hsoLUEdivijJ51Il O4LSgFkQV/x+n0/xeW+sfczHuXtomgNcSWKHbDlToVIIi9PUNLwU5UZG2q1Vg/GpvwYo 5S4nmoYHeEKseLgv3QX2RR4UHa5NOrsi9o+K54iDmuGA7nORNJPwtGSbkl7SO14oySv5 pufLYCuvHl5i+qIBErq1HRMlmhz9CBS7luY3Cn1U3s+DWmFs/yGsqyE/+McVGIkhugla twnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696827856; x=1697432656; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2bO+J/ddJTh/IWxm9aK+yn2/0A+u8AVXwl6IHY19/+M=; b=TsN766R2qpjSWV9nNshI/xq+2Mj7wZSTpEu6MHpcsOR+bzz45GgFEbSNpGGsHJL+iU iBVS5pbC10F/IMxIUrlSSMr5k4Zk2dN4NO2KS/r3jx+B4oFW2KiXz9u2kc+GmFSOSadn B+qowZG6B5dB+5eXlvPGKwZoc5fj9k/S+kUVImMel23WNjcqpTVqiHrx1bG0/BG+K7pS 3sBBcrl0im3C/Jwphazi5tkQR1pjA8B4AnjhIHmeslDLWCaJM1GddJUMQDrTQcHWEJzg 0kSjwiDsgaZfZ3W2xZn2SH9p14iwIMx78htjsG5lqjmSqfqVEjgJd8fzsI2swIj9hmmf ruEw== X-Gm-Message-State: AOJu0YxWGzJ6mZ6XHZLvq4bTEnYtldJATgrtV3zsMhSk6aR1i+1qBH04 RKPr0aS6d90O9zY3pCIHYz0= X-Google-Smtp-Source: AGHT+IFpmZG8eolW1IM6t68pMBM6nvIx7sFYNLXC8ktwDSvhowgXFF8OHDPUEeS0XJ4aKujUaPc+Qw== X-Received: by 2002:a05:6870:1593:b0:1dc:a72c:5ce9 with SMTP id j19-20020a056870159300b001dca72c5ce9mr16452213oab.4.1696827856446; Sun, 08 Oct 2023 22:04:16 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id d13-20020aa7814d000000b00690cd981652sm5367981pfn.61.2023.10.08.22.04.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 22:04:15 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#66223: treesit-major-mode-setup should not call font-lock-mode From: Yuan Fu In-Reply-To: <72f5b67f-a71c-c027-c8c3-d373ae8dea35@gutov.dev> Date: Sun, 8 Oct 2023 22:04:04 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <2A274345-06E1-4D78-815A-8D93057B1343@gmail.com> References: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> <23152919-A885-4B9A-8624-D5F079D576CF@gmail.com> <3f66990d-1f69-f2bd-f696-a30ff64bd9a2@gutov.dev> <8EB5FF6F-CB88-49B7-BC26-7517771831C4@gmail.com> <9160A07F-5297-43CA-8859-3FCEA3C62726@gmail.com> <72f5b67f-a71c-c027-c8c3-d373ae8dea35@gutov.dev> To: Dmitry Gutov X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66223-done Cc: 66223-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 8, 2023, at 4:05 PM, Dmitry Gutov wrote: >=20 > On 09/10/2023 02:03, Yuan Fu wrote: >> I think we can apply this to emacs-29. Is there anything I should do? = Do we just cheery-pick the commit into emac-29, or there are more = elaborate operations required? >=20 > As per admin/notes/git-workflow (I'm not sure why it's that far away), >=20 > ... > cd ~/emacs/emacs-29 > git cherry-pick -xe >=20 > and add "Backport:" to the commit string. Then > ... >=20 > Thanks! Done, thanks. Yuan= ------------=_1696827902-23635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Sep 2023 00:18:36 +0000 Received: from localhost ([127.0.0.1]:50076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIGB-0002di-F0 for submit@debbugs.gnu.org; Tue, 26 Sep 2023 20:18:35 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIG8-0002dN-CK for submit@debbugs.gnu.org; Tue, 26 Sep 2023 20:18:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlIFk-0003bg-MS for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 20:18:08 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qlIFh-0006wO-Pv for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 20:18:08 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 706A332005B5 for ; Tue, 26 Sep 2023 20:18:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 26 Sep 2023 20:18:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm1; t=1695773880; x=1695860280; bh=ds vByhHjo5xd6eKjg0aJi5XK2e9DtZVpkL/6SjuAtCI=; b=z/lnpCrs5Ux8lny6z+ 83BBB8RvnYC9rwzH52hLbh8EGpbupdFEknqc+E/FRkwpAc7N82F7Jb0XVnz3htSU 8Wy1zyURg2PwiVW7/TjddvowRNAOyKtP27h2dVUQbOh4d176jx6zfY3zWwypYYX5 gzewIJ7aq88RteOX7MJULitNt98GceOYTFvAFZstLqumE5N1kmkX8vyQ3C/OxgHr XGSY2e+eXS+y94zcm06X9pg/eFp472uIVS/PY26n1x9FPrRfCvzBFZPMU4+gY+Pj SiV8eWRJQDd8L5R+7sZPFrzsatpupYz3Sw8tzurnRVfWcYry5zN2w5UOEjOFAF0/ KSBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695773880; x=1695860280; bh=dsvByhHjo5xd6 eKjg0aJi5XK2e9DtZVpkL/6SjuAtCI=; b=AOd+S+RtOY7WD6HAkOYgPkfUogDGw oEZw3spDoTS3ut84w2DExAOtfwpxX8IA5CRqRgz/Wzw3nlj86dDei+B4Cg6emrod UnSUAbAqiXOZvUXbJ0uqZf2YUrTo91ANUWV67hevHvc/x11nTPx6dBzLL7SxuRXj rEJdCsdp7DEooIZzqtzT1Rnxg8OT4y0vbm4G8zgvHxhRcHGd0mL47H06qQEoVzVE vqQIK4mWdrVdllRpz4PxnGvA3RsWcgsGtjXH5DwzYbJrkQ4p+R9E3R9HiPfm8rkF mPgr8xB7UmGBLRVpfpFwKYw41XWFZukmG4f3MwInvl6uvbDXD+JYvue5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvjedrtddugdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfvffhufgtgfesthejredttd efjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhv rdguvghvqeenucggtffrrghtthgvrhhnpeeguedtueethfetleetffevveeiteelgfetke evfeeutdetjefgkeetteetkefhgeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrh ihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 26 Sep 2023 20:18:00 -0400 (EDT) Message-ID: <0f34478f-6d41-078d-295e-15caa4556b3f@gutov.dev> Date: Wed, 27 Sep 2023 03:17:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Dmitry Gutov Subject: treesit-major-mode-setup should not call font-lock-mode Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=64.147.123.21; envelope-from=dmitry@gutov.dev; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) X-Debbugs-CC: Yuan Fu It doesn't seem necessary (everything seems to work okay without that call), and it's not the right thing idiomatically (the user should have the ability to disable global-font-lock-mode). If it does get called, the call to treesit-font-lock-recompute-features should happen before that. The report was triggered by somewhat unusual circumstances (somebody trying out mmm-mode together with typescript-ts-mode: https://github.com/dgutov/mmm-mode/issues/138), but the fix seems easy and natural enough. To reproduce the bug, though, try this: (with-current-buffer (generate-new-buffer "foo") (let (font-lock-support-mode) (typescript-ts-mode))) It results in Debugger entered--Lisp error: (treesit-query-error "Node type error at" 2 "(jsx_opening_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_closing_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_self_closing_element [(nested_identifier (identifier)) (identifier)] @typescript-ts-jsx-tag-face) (jsx_attribute (property_identifier) @typescript-ts-jsx-attribute-face)" "Debug the query with `treesit-query-validate'") treesit-query-capture(# # 1 1) (let* ((delta-start ... treesit--font-lock-fontify-region-1(# # 1 1 nil nil) (let ((sub-node (car tail)))... treesit-font-lock-fontify-region(1 1 nil) font-lock-fontify-syntactically-region(1 1 nil) font-lock-default-fontify-region(1 1 nil) font-lock-fontify-region(1 1 nil) font-lock-default-fontify-buffer() font-lock-fontify-buffer() font-lock-initial-fontify() font-lock-mode(1) (progn (set (make-lo... treesit-major-mode-setup() typescript-ts-mode() because typescript-ts-mode's treesit-font-lock-settings hide the jsx rule (which the typescript grammar itself doesn't support, only the tsx one does) using the absence of that feature in treesit-font-lock-feature-list. But for that to take effect, the call to 'treesit-font-lock-recompute-features' needs to happen first. The jit-lock conceals the problem by inhibiting the first fontification until the major mode function has run and the buffer is visible. I ended up disabling it in mmm-mode's auxiliary temp buffer because it spams the message "Not enabling jit-lock: it does not work in indirect buffer". ------------=_1696827902-23635-1--