GNU bug report logs - #66199
[PATCH] gnu: librepcb: Update to 1.0.0.

Previous Next

Full log

Message #50 received at 66199 <at> debbugs.gnu.org (full text, mbox):

From: pinoaffe <pinoaffe <at> gmail.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 66199 <at> debbugs.gnu.org
Subject: Re: [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0.
Date: Wed, 04 Oct 2023 01:39:44 +0200

Thanks again!

Vinicius Monego <monego <at> posteo.net> writes:
>> * gnu/packages/engineering.scm (librepcb): Update to 1.0.0.
>> [inputs]: Add various dependencies (both new ones and old ones that are now
>>          debundled).
>
> If the change is not automated, then every input should be listed,
> separated by commas.
Done, I hope this is more or less what you meant

>> [arguments]: Remove overriding of configure phase. Replace test
>>          phase. Debundle various dependencies.
>
> Avoid words like "various", list all items whenever possible.
Okay

>> [build-system]: Use cmake-build-system.
>> [native-inputs]: Add googletest.
> pkg-config was also added to native-inputs.
I added it to the commit message

> And don't worry too much about the commit message, I can change it
> later.
Aight

>> +     (list fontconfig
>> +           fontobene-qt5
>> +           glu
>> +           hoedown
>> +           muparser
>> +           opencascade-occt
>> +           clipper
> Nitpick: 'clipper' is out of order
Whoops!

>> +     `(#:phases (modify-phases %standard-phases
>> +                  (replace 'check
>> +                    (lambda* (#:key tests? #:allow-other-keys)
>> +                      (when tests?
>> +                        (setenv "QT_QPA_PLATFORM" "offscreen")
>> +                        (setenv "QT_QUICK_BACKEND" "software")
>> +                        (display "Running unittests...\n")
>> +                        (invoke "./tests/unittests/librepcb-unittests" "--help")))))
>> +

> Why --help?
Oops, that's a leftover artifact of me testing some stuff

> I ran librepcb-unittests with no arguments and found that
> ~20 tests failed out of ~2100. If it's not possible to skip them
> manually, you could skip all tests and leave a comment reporting what
> happened. I didn't check the output of --help.
I manually skipped them, though I feel a bit "dirty" skipping 22 tests
without properly knowing why they fail, especially since it's just a
constant list of 22 strings in the middle of a package definition.

> #:configure-flags is usually placed above #:phases.
Okay, I moved it

> I think this patch is ready after fixing the test suite.
Great!

Kind regards,
pinoaffe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.