GNU bug report logs - #66199
[PATCH] gnu: librepcb: Update to 1.0.0.

Previous Next

Full log

View this message in rfc822 format

From: pinoaffe <pinoaffe <at> gmail.com>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 66199 <at> debbugs.gnu.org
Subject: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0.
Date: Tue, 26 Sep 2023 14:08:23 +0200

Hi,

thank you for your review!

Vinicius Monego <monego <at> posteo.net> writes:
> The commit message should also mention the switch to
> cmake-build-system, the "not overriding" of the configure phase, the
> new inputs and the test skip..
I wasn't sure how to phrase / format this, is what I arrived at OK?

> Inputs should be sorted alphabetically.
Done

> The comment about lrelease can be removed as lrelease is not being
> manually invoked anymore, and the native inputs list can be squashed
> in one line.
Done

> There are options in LibrePCB's CMakeLists.txt to unvendor some
> dependencies:
> https://github.com/LibrePCB/LibrePCB/blob/9edb6ede393e5b48785f95252f81a027db4b718a/CMakeLists.txt#L51
I unvendored all of the mentioned dependencies apart from dxflib (I
couldn't get it to build).

> The only dependencies we do not have is dxflib and fontobene-qt5. It
> failed to find muparser and polyclipping ('clipper' package in Guix),
> I don't know why.
Adding pkg-config as a native dependency seems to have done the trick

> It would be best to unvendor as many dependencies as possible. Could
> you send an updated patch? Optionally, you can try to package
> fontobene-qt5 and have cmake find muparser and polyclipping.

I'll send some updated patches in a minute

Kind regards,
pinoaffe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.