From unknown Sat Jun 14 03:52:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#66199 <66199@debbugs.gnu.org> To: bug#66199 <66199@debbugs.gnu.org> Subject: Status: [PATCH] gnu: librepcb: Update to 1.0.0. Reply-To: bug#66199 <66199@debbugs.gnu.org> Date: Sat, 14 Jun 2025 10:52:10 +0000 retitle 66199 [PATCH] gnu: librepcb: Update to 1.0.0. reassign 66199 guix-patches submitter 66199 pinoaffe severity 66199 normal tag 66199 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 16:27:33 2023 Received: (at submit) by debbugs.gnu.org; 25 Sep 2023 20:27:33 +0000 Received: from localhost ([127.0.0.1]:46750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qksB3-0004dz-C9 for submit@debbugs.gnu.org; Mon, 25 Sep 2023 16:27:33 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qksB0-0004de-Nn for submit@debbugs.gnu.org; Mon, 25 Sep 2023 16:27:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qksAi-0003BB-K0 for guix-patches@gnu.org; Mon, 25 Sep 2023 16:27:12 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qksAg-0004fR-Sj for guix-patches@gnu.org; Mon, 25 Sep 2023 16:27:12 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9a645e54806so881806866b.0 for ; Mon, 25 Sep 2023 13:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695673629; x=1696278429; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+9HxV4wL8j4F+T6m6P853Op6SYm4UXEIcKGTyr9TVU0=; b=i3LJ5j6NHqJy3CvntiLpXIfglQX5i9w3vFLgHHD9Ta5kUqZOd6qoOj4PY6KOwrjdFR W2V6GBXCgXsEIy2sctrvylmlYAgOycOsmeocTz8rJwEj2ttxg0MAU1N9kB/VoG3+C1S5 PNVCWDCYmVIsD0DQDvXFBmZWvYSnrrqCE/GFtUmw1/vLam8JvBElbXJdt0CNccsKHoVq b25PfRzFxuOKCrpeGAzeYwn9YpW/os3ZhVg1tp0c/EEz+sXNGF93Gie77YV6Mgu7Jtbk zoNY7fwN8qux6CHaImqn9tb4v3VjqARmqG6SNYFHfkB8xVk5sPP8dAFur8Q53sXy/V8r p3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695673629; x=1696278429; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+9HxV4wL8j4F+T6m6P853Op6SYm4UXEIcKGTyr9TVU0=; b=IC88IeLyGo3KfzluBp5dz3SHM7QOJpV8lqoreFkmnU72aGhq5UkRq4U/pP77CaNCsf usXoArz9WusmR3MIZkJ4ifWLiBW9yFo2xdTvrkg12bQLanqPKiN1A9TL5uMSg4XKL2S0 sl/aUvB75TDmpAUUjIJs/T18rNw1Bsnvxm7IWkIHrGpxHOt5b8BsU0EDRDvWxnz7aLCL Jyc2BZfmZPrCbxmjVe4TLGSlVb+kF5rqPX6N1534H5LaxmKDFfRMfWAN/o/WF8ZOGMFa sQPDirEXh7SPK9V/MRlvlPY9i97kqYbx8VzvduQON+ExLayII6Yq5L/TDnMBh3HqzAdT T0mA== X-Gm-Message-State: AOJu0YwdZ5N21gMjcST+LV48uNnfw2sQQGv50nv3InrzOAjjQwGc7Ttf Aee9Q/+ZECedbkQXSVHIghO7HyhgkSPatg== X-Google-Smtp-Source: AGHT+IF3WN9gDpYBhVDI/INgzfnXh4W/YLNUbnGnaZOKiYUIfXxD0f32OsiyYQFtMw3Dcy9AZwq5bA== X-Received: by 2002:a17:906:3116:b0:9ae:53a2:4289 with SMTP id 22-20020a170906311600b009ae53a24289mr6929022ejx.63.1695673628792; Mon, 25 Sep 2023 13:27:08 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id i13-20020a1709061ccd00b00991faf3810esm6824941ejh.146.2023.09.25.13.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 13:27:08 -0700 (PDT) From: pinoaffe To: guix-patches@gnu.org Subject: [PATCH] gnu: librepcb: Update to 1.0.0. Date: Mon, 25 Sep 2023 22:27:04 +0200 Message-ID: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=pinoaffe@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. --- gnu/packages/engineering.scm | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index c2846f0bda..f12f4ad59d 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -2260,33 +2260,30 @@ (define-public freehdl (define-public librepcb (package (name "librepcb") - (version "0.1.5") + (version "1.0.0") (source (origin (method url-fetch) (uri (string-append "https://download.librepcb.org/releases/" version "/librepcb-" version "-source.zip")) (sha256 - (base32 "0smp1p7wnrj0vh4rmz1cr2krfawc2lzx0pbzmgyay7xdp6jxympr")))) - (build-system gnu-build-system) + (base32 "02qfwyhdq1pklb5gkwn3rbsdhwvcgiksd21swaphz3kw6s4p9i8v")))) + (build-system cmake-build-system) (inputs - (list qtbase-5 qtsvg-5 zlib)) + (list qtbase-5 + qtsvg-5 + qtdeclarative-5 + qtquickcontrols2-5 + zlib + opencascade-occt + glu + fontconfig)) (native-inputs (list qttools-5 ; for lrelease unzip)) (arguments - `(#:phases - (modify-phases %standard-phases - (replace 'configure - (lambda* (#:key inputs outputs #:allow-other-keys) - (mkdir-p "build") - (chdir "build") - (let ((lrelease (search-input-file inputs "/bin/lrelease")) - (out (assoc-ref outputs "out"))) - (invoke "qmake" - (string-append "QMAKE_LRELEASE=" lrelease) - (string-append "PREFIX=" out) - "../librepcb.pro"))))))) + ;; There is no cmake test target + `(#:tests? #f)) (home-page "https://librepcb.org/") (synopsis "Electronic Design Automation tool") (description "LibrePCB is @dfn{Electronic Design Automation} (EDA) base-commit: 445a0359083388b5ee686e6e855f94a3aac5f79c -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 25 20:37:46 2023 Received: (at 66199) by debbugs.gnu.org; 26 Sep 2023 00:37:46 +0000 Received: from localhost ([127.0.0.1]:46915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkw5C-0005wM-DF for submit@debbugs.gnu.org; Mon, 25 Sep 2023 20:37:46 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkw58-0005w4-Fs for 66199@debbugs.gnu.org; Mon, 25 Sep 2023 20:37:45 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 6F73C240027 for <66199@debbugs.gnu.org>; Tue, 26 Sep 2023 02:37:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695688643; bh=TgvbnDR2rsVxlKw8KEqR3u7VI6zTlzZF5RnIqxfDR+Q=; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Transfer-Encoding:From; b=q1hc3bKYVZBnJr6VP/whz7zVvGmHgGzwEkr9zjLT16pLWzPclRqU/oMbzlUq0LJte f/eYmhAaYNBsSU0IK5XsmsWPxvkwm5SLEBlWKriWl1kU8QXPN7dJ6DSXd6ZN4KK9JV MaSu8MgN/FDdmDVlAapK3MHnhcHRuL6i8ygA4G5PLJJKk87PsiaaoqmpoqrODmp78t zjZqCjVQ3dDE03DJjNxJq4nfToKtXmeVO8QbIcHdBk9sgBsKEL0EyffaH/yStXpHk8 odMEOVE5FwYy2tk4I6icsgD8EOQcs8PatOwxTMYxmHeGK0VmjAKiKFfuX3EBIE6Jyx 3kBiVgoAHu9gQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rvgmx5RWPz6twg; Tue, 26 Sep 2023 02:37:21 +0200 (CEST) Message-ID: <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> Date: Tue, 26 Sep 2023 00:37:20 +0000 MIME-Version: 1.0 Subject: Re: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0. Content-Language: en-US To: pinoaffe@gmail.com, 66199@debbugs.gnu.org References: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> From: Vinicius Monego In-Reply-To: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66199 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Em 25/09/2023 17:27, pinoaffe escreveu: > * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. Thank you. The commit message should also mention the switch to cmake-build-system, the "not overriding" of the configure phase, the new inputs and the test skip. I have a few more comments below. > --- > gnu/packages/engineering.scm | 29 +++++++++++++---------------- > 1 file changed, 13 insertions(+), 16 deletions(-) > > diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm > index c2846f0bda..f12f4ad59d 100644 > --- a/gnu/packages/engineering.scm > +++ b/gnu/packages/engineering.scm > @@ -2260,33 +2260,30 @@ (define-public freehdl > (define-public librepcb > (package > (name "librepcb") > - (version "0.1.5") > + (version "1.0.0") > (source > (origin > (method url-fetch) > (uri (string-append "https://download.librepcb.org/releases/" > version "/librepcb-" version "-source.zip")) > (sha256 > - (base32 "0smp1p7wnrj0vh4rmz1cr2krfawc2lzx0pbzmgyay7xdp6jxympr")))) > - (build-system gnu-build-system) > + (base32 "02qfwyhdq1pklb5gkwn3rbsdhwvcgiksd21swaphz3kw6s4p9i8v")))) > + (build-system cmake-build-system) > (inputs > - (list qtbase-5 qtsvg-5 zlib)) > + (list qtbase-5 > + qtsvg-5 > + qtdeclarative-5 > + qtquickcontrols2-5 > + zlib > + opencascade-occt > + glu > + fontconfig)) Inputs should be sorted alphabetically. > (native-inputs > (list qttools-5 ; for lrelease > unzip)) The comment about lrelease can be removed as lrelease is not being manually invoked anymore, and the native inputs list can be squashed in one line. > (arguments > - `(#:phases > - (modify-phases %standard-phases > - (replace 'configure > - (lambda* (#:key inputs outputs #:allow-other-keys) > - (mkdir-p "build") > - (chdir "build") > - (let ((lrelease (search-input-file inputs "/bin/lrelease")) > - (out (assoc-ref outputs "out"))) > - (invoke "qmake" > - (string-append "QMAKE_LRELEASE=" lrelease) > - (string-append "PREFIX=" out) > - "../librepcb.pro"))))))) > + ;; There is no cmake test target > + `(#:tests? #f)) > (home-page "https://librepcb.org/") > (synopsis "Electronic Design Automation tool") > (description "LibrePCB is @dfn{Electronic Design Automation} (EDA) > > base-commit: 445a0359083388b5ee686e6e855f94a3aac5f79c There are options in LibrePCB's CMakeLists.txt to unvendor some dependencies: https://github.com/LibrePCB/LibrePCB/blob/9edb6ede393e5b48785f95252f81a027db4b718a/CMakeLists.txt#L51 The only dependencies we do not have is dxflib and fontobene-qt5. It failed to find muparser and polyclipping ('clipper' package in Guix), I don't know why. It would be best to unvendor as many dependencies as possible. Could you send an updated patch? Optionally, you can try to package fontobene-qt5 and have cmake find muparser and polyclipping. Vinicius From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 08:15:41 2023 Received: (at 66199) by debbugs.gnu.org; 26 Sep 2023 12:15:41 +0000 Received: from localhost ([127.0.0.1]:47520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6yb-0008KG-BE for submit@debbugs.gnu.org; Tue, 26 Sep 2023 08:15:41 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:47380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6yV-0008Jr-JD for 66199@debbugs.gnu.org; Tue, 26 Sep 2023 08:15:39 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9b0168a9e05so828239066b.3 for <66199@debbugs.gnu.org>; Tue, 26 Sep 2023 05:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695730516; x=1696335316; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=soW8m1Mwb6bCeQ1rn7YxNSjIOKLRF0BpjBg0wdRCMiw=; b=nCNtDtIemtsNwxcv35aJuQYaDgLiveXwNwUY5FERyDX9uF8HEhQrvBN1ya0sqrKMoB TEQJjc6kjdq+PafgXrmHAqdR65lwnM0jU5hKl87y59cnYGyGgkRQyKoTXV1gk+Aw+aLa aY/cNv4WFRuXUJeAYF0eunOR5IenHantmq5Ke6/T3a/sMTaAjHxJQnwH/uBqRuCjI45k ks7AnzeGPgWSfqIWKmCoFPEr9KNZ3mxAvR7vf1VPkARktTcE9pMq7bliNgDAjzOlWQSD YCpEkGuIr4LkI5co5bcCwmwFON+fckzMldhVvyGD+AfZPewL6TnGAk0XeQoptXwsXZDx gVMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695730516; x=1696335316; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=soW8m1Mwb6bCeQ1rn7YxNSjIOKLRF0BpjBg0wdRCMiw=; b=TVHHb0UOhAPZXihK8SmBBibLQXyckapt0NWcGTDEyeuMIrO5JIdUkysKfv7Of7mivH K2f5GaRX5Iz15pMnWE/EARIE0osZwNibPA3gxEyWHX5XXao1Bpj0Nc3VJV+dhhUG64O7 qBfFWpxKyoLIW99BhN531ihJlGUCSHj+BVzleIqPAZrBLjYusSafWUsM93P29irn9vgs 2dwsddxgZwuzAPK6tQSZAcowcFu+tHfsNbZhstznRrNpgoIzTeRomP/pLwNCFMgxGz1V DxvXA+VL3AHHqdPVq1xDRmJw/QgCxJTPRsJvh3bRCZXQA9xpEviukwgBYMCDTo8VZF3/ uGcQ== X-Gm-Message-State: AOJu0YwJSYKl9+34t6MPvNx+fzjl5zeNoABI8NOrVsb+oACONHJlUVlk /f1dMywBBkP6Nv4ck87pQas= X-Google-Smtp-Source: AGHT+IG4mCpr30aJpT7Fy8mfpdSWLnYnZaKvMjpO9rXsbmddP3SDljOxx4Iq83B8AEegPuvxtt9seQ== X-Received: by 2002:a17:906:53d8:b0:9ae:5643:6493 with SMTP id p24-20020a17090653d800b009ae56436493mr8271966ejo.74.1695730516107; Tue, 26 Sep 2023 05:15:16 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id sa21-20020a170906edb500b009add084a00csm7647071ejb.36.2023.09.26.05.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 05:15:15 -0700 (PDT) References: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe To: Vinicius Monego Subject: Re: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0. Date: Tue, 26 Sep 2023 14:08:23 +0200 In-reply-to: <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> Message-ID: <87h6nhdtbh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: 66199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, thank you for your review! Vinicius Monego writes: > The commit message should also mention the switch to > cmake-build-system, the "not overriding" of the configure phase, the > new inputs and the test skip.. I wasn't sure how to phrase / format this, is what I arrived at OK? > Inputs should be sorted alphabetically. Done > The comment about lrelease can be removed as lrelease is not being > manually invoked anymore, and the native inputs list can be squashed > in one line. Done > There are options in LibrePCB's CMakeLists.txt to unvendor some > dependencies: > https://github.com/LibrePCB/LibrePCB/blob/9edb6ede393e5b48785f95252f81a027db4b718a/CMakeLists.txt#L51 I unvendored all of the mentioned dependencies apart from dxflib (I couldn't get it to build). > The only dependencies we do not have is dxflib and fontobene-qt5. It > failed to find muparser and polyclipping ('clipper' package in Guix), > I don't know why. Adding pkg-config as a native dependency seems to have done the trick > It would be best to unvendor as many dependencies as possible. Could > you send an updated patch? Optionally, you can try to package > fontobene-qt5 and have cmake find muparser and polyclipping. I'll send some updated patches in a minute Kind regards, pinoaffe From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 08:17:05 2023 Received: (at 66199) by debbugs.gnu.org; 26 Sep 2023 12:17:05 +0000 Received: from localhost ([127.0.0.1]:47528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6zx-0008Nf-0Z for submit@debbugs.gnu.org; Tue, 26 Sep 2023 08:17:05 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:42491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6zu-0008N6-Lg for 66199@debbugs.gnu.org; Tue, 26 Sep 2023 08:17:03 -0400 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-52f3ba561d9so19212239a12.1 for <66199@debbugs.gnu.org>; Tue, 26 Sep 2023 05:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695730604; x=1696335404; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2qnsFNRNdSXVP0GMbOsx0ZW6qSlP6vJzylzZtRX9gRA=; b=HR/BL8icCHiApkU8QTyXMP4/b/takBG2hYR4wMMjZI7dK9cXDeexL+QnSraUM85+k0 XMbppxogS+ohuxWyr0y1jUPMdeiypxt+KvGrTCR3X5FYYFCMCr5b3z9XJfZKAjyxSIHX J/ELGAdNXKlhYgEzqH5+OP3FjvZuQtKWlZq8ZIZZdiyI7EurQFnVknuV0+ojS65NaWug WowHHgxH5lXESIiCsp0YehTETa8y0ILSeMSGr1StahTeVwzwo86hGgq5NG80XWv6EfPe U/pInQlxnZMGzDmMHo/jF4BQD2/5vzdLbIY3mfQdFSiboBaowrih58SzF1PvoM1xoyGn DpuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695730604; x=1696335404; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2qnsFNRNdSXVP0GMbOsx0ZW6qSlP6vJzylzZtRX9gRA=; b=BrUr3Az1I34xtnYtETcCpxv8k+Xrw0Pt+YBuI/2QcQy8KJ5n7hjCMnA7mi3G69uCuf tzrBXToTsY9WM+xliDALjW8GtWivbr0sKxkEhD6M3yPt2ORzu/AOQNsY10hY3OusmXzr u5upMN3JWEEpOEBbAaSeztdKgFeM4Hl7XV3fWpB3mcpMmNXC75jZGB1S9lKjRKQYOhJ0 otWGceE6fo++xKlDhJD8K1g5retNe/u6yAvV1LbhjiuGmnDu4l+o/777LvxjJly1g9WV JLksbo+5YeGnldcppmqmw4GPEWHLAzIDMLVOyqZitlIqIaW557Upu7jznwfbqcXp3uJb 7Tag== X-Gm-Message-State: AOJu0Yw4UWDiQjq0Xj7TMjZVayAUnBW4Wiykkj8WdKYiGOuIbBS/yR6a CPOK1Urny5g10HIYFhVzd2sxE9A8fCZIcQb9 X-Google-Smtp-Source: AGHT+IHiOk9sFoOfVDq30f/CvGESY/pE3geHuBxs6VU5IzGXlomaDs3qMr7KtniIKMA3im0IpaWSPg== X-Received: by 2002:a05:6402:959:b0:523:3e27:caa7 with SMTP id h25-20020a056402095900b005233e27caa7mr3716610edz.20.1695730603484; Tue, 26 Sep 2023 05:16:43 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id z14-20020aa7d40e000000b00530a9488623sm6765671edq.46.2023.09.26.05.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 05:16:43 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: Add fontobene-qt5. Date: Tue, 26 Sep 2023 14:16:32 +0200 Message-ID: <00f8b2031e0af268e413cefa7dea3eeba4775582.1695729169.git.pinoaffe@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: monego@posteo.net, pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/fontutils.scm (fontobene-qt5): New variable. --- gnu/packages/fontutils.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm index 230fdd1dde..71a4f156b0 100644 --- a/gnu/packages/fontutils.scm +++ b/gnu/packages/fontutils.scm @@ -18,6 +18,7 @@ ;;; Copyright © 2023 gemmaro ;;; Copyright © 2023 John Kehayias ;;; Copyright © 2023 Janneke Nieuwenhuizen +;;; Copyright © 2023 pinoaffe ;;; ;;; This file is part of GNU Guix. ;;; @@ -65,6 +66,7 @@ (define-module (gnu packages fontutils) #:use-module (gnu packages python) #:use-module (gnu packages python-build) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages qt) #:use-module (gnu packages sqlite) #:use-module (gnu packages webkit) #:use-module (gnu packages xdisorg) @@ -951,6 +953,34 @@ (define-public python-ufonormalizer @end itemize") (license license:bsd-3))) +(define-public fontobene-qt5 + (package + (name "fontobene-qt5") + (version "0.2.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/fontobene/fontobene-qt5") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0gy3sfraf23k7dm4ha8nqpd6madzk0zmxkcb204micyn5b5l8ljg")))) + (inputs (list qtbase-5)) + (build-system cmake-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "./tests/fontobene-qt5-tests"))))))) + (home-page "https://github.com/fontobene/fontobene-qt5") + (synopsis "Parser for FontoBene stroke fonts") + (description "A header-only library to parse FontoBene stroke fonts with +C++11/Qt5.") + (license license:expat))) + (define-public ttfautohint (package (name "ttfautohint") base-commit: 445a0359083388b5ee686e6e855f94a3aac5f79c -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 08:17:10 2023 Received: (at 66199) by debbugs.gnu.org; 26 Sep 2023 12:17:10 +0000 Received: from localhost ([127.0.0.1]:47531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql702-0008Nx-EW for submit@debbugs.gnu.org; Tue, 26 Sep 2023 08:17:10 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:60894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql6zy-0008NL-LM for 66199@debbugs.gnu.org; Tue, 26 Sep 2023 08:17:07 -0400 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99bdeae1d0aso1075171366b.1 for <66199@debbugs.gnu.org>; Tue, 26 Sep 2023 05:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695730608; x=1696335408; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=azWEqbEIVUFe0QK5xEr9+p45njEw480cEo1BEEmHJsU=; b=HFhlapLFOe+vcdOQguQGp8htokbfI10yyc8IrUs0VJazwVhlwmxS7nd9vI0fsE7ULV t42Kqj4p/Y9XSyNzQPLF5k/gK0CmunDoLCblBva6PkEyzcoaKasmlNEFRNVE+Qx6ajAp cH92nKkbeN+adtt0JngBY0Jtejx4m2ZNiYOmNERAosYfl7k8RycR9cv1BKRUnLknoQGw 78lZ/+X7J18wStgHU0zLdHqWJrwIm/rWhSAiKRE6YTCXR4xsxDKKq9Zw4iEYKPOksIVw RfygZgsPEsHHaw88k1pf3HwCr63yA+L3rBQs7Z7cO3WKWkHPa1qh1mpuC7Ortk100u4Y SeCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695730608; x=1696335408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=azWEqbEIVUFe0QK5xEr9+p45njEw480cEo1BEEmHJsU=; b=La0wndv/4kEcnEh0gapp2mn6Z//nTWlZJwI/4w9S7P/BCuqK3Dej3pVc03sFJBcUTb ZJKJ/jKuhGLiRiqUAa9bGtqUkcLd5eOaW0bNhlUOxdo1Wt7RxSDipBN4RHa1znKZ+tVP jx5bDLkEMOtN5arZZ/ul/JcjxvZiuAT2SUHm263AJUrkyIveLsQZV+8ArLRzJQZty2dY oeFVFVZk7DysOMnLot6kyhsA/o8r+C1r0/Ux+oB3Irjicl+zIl+X5eYQpUunlfv4WBle jlVF6zUbEZPCCtmtmdJDjIYcX5hInnCEdRzxuwFVHqEV7dVRuqpdxekpvq+ACo6uVaUa 5dpQ== X-Gm-Message-State: AOJu0YysoYEa7r2wunBwa2h+GA3Y81vNjvVnvfBxu28mL8cUes3Eck0M y0MYUPxrLS3CqOiqk2QiXXy1QBH9qP9iLgrw X-Google-Smtp-Source: AGHT+IGCCsxTPko9I2GH3TIlI0mNZ0qNmm3vbzqVKYpWy4PREoI67LnXjSPD1WHcR/h6oGG5mPtbtQ== X-Received: by 2002:a17:906:3104:b0:9ae:4843:66ee with SMTP id 4-20020a170906310400b009ae484366eemr8954278ejx.36.1695730607811; Tue, 26 Sep 2023 05:16:47 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id d11-20020a170906370b00b0097404f4a124sm7712623ejc.2.2023.09.26.05.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 05:16:47 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: librepcb: Update to 1.0.0. Date: Tue, 26 Sep 2023 14:16:33 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: <00f8b2031e0af268e413cefa7dea3eeba4775582.1695729169.git.pinoaffe@gmail.com> References: <00f8b2031e0af268e413cefa7dea3eeba4775582.1695729169.git.pinoaffe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: monego@posteo.net, pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. * gnu/packages/engineering.scm (librepcb): Switch to CMake build system. --- gnu/packages/engineering.scm | 46 ++++++++++++++++++++++-------------- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index c2846f0bda..ab36700ff5 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -37,6 +37,7 @@ ;;; Copyright © 2022 Maxim Cournoyer ;;; Copyright © 2022, 2023 Felix Gruber ;;; Copyright © 2023 Theofilos Pechlivanis +;;; Copyright © 2023 pinoaffe ) id 1qlIWi-00037Y-Rk for submit@debbugs.gnu.org; Tue, 26 Sep 2023 20:35:41 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIWf-00037F-U8 for 66199@debbugs.gnu.org; Tue, 26 Sep 2023 20:35:39 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 308EC240101 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 02:35:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695774918; bh=y/zrI7ynDApVhAPSVxwUSjpG8BNcHKL+dOU5U2/TWDU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From: Content-Transfer-Encoding:From; b=ITFxBGY7YpmgwXLr6nZs3o5nU5Gh/3U7gEUhDN37vLevfYKfT0/ykxN8LEtYOszEn wRcR3euANz4hKv8J//eklSFDCAMnefzymBhCi48xlkp0SMeysZHUJ+FufkZ9yCvZ43 8QnL5q/oK7RFtSSn0KnG5bD1MKWFvO/78e9UOdqxi1p/gyLKYZM0HXuZ6yaUI6Zrpo EgMj7M0w1m4tcVhpgE5G1jucvxRSjF9qYMAHMzUvIbLzNWI+TWk7+wkXdNHO35q2g9 h8o+a6A4fHnyq58tZ5YHX3M/+uDKIM84zLnu5uXCDfFVJbVq76d+lakBN/53aYlSy3 Gx0JCizx15hSQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RwHh43wB3z9rxT; Wed, 27 Sep 2023 02:35:16 +0200 (CEST) Message-ID: Date: Wed, 27 Sep 2023 00:35:14 +0000 MIME-Version: 1.0 Subject: Re: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0. Content-Language: en-US To: pinoaffe References: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> <87h6nhdtbh.fsf@gmail.com> From: Vinicius Monego In-Reply-To: <87h6nhdtbh.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66199 Cc: 66199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Em 26/09/2023 09:08, pinoaffe escreveu: > Hi, Hi! > thank you for your review! > > Vinicius Monego writes: >> The commit message should also mention the switch to >> cmake-build-system, the "not overriding" of the configure phase, the >> new inputs and the test skip.. > I wasn't sure how to phrase / format this, is what I arrived at OK? You can check the logs of e.g. commit 19617735df2b1af3b169d8153ae543ad3e0fc1a1 for reference. >> Inputs should be sorted alphabetically. > Done > 'googletest' should be a native input, it's a test requirement only. [...] > I'll send some updated patches in a minute > > Kind regards, > pinoaffe [Comment on the LibrePCB update patch specifically]: This v2 is much better, thanks. While investigating the build I also found a few more things that could be improved: - The bundles that were unvendored can be deleted in a source snippet (see e.g. the mixxx package). - LibrePCB builds a test executable at tests/unittests/librepcb-unittests. Instead of 'make test', that file could be run manually when overriding the check phase. - The license list should be updated as some of the bundles listed there are not being provided anymore, or even better let it be only gpl3+ because that's the license of the final product. - I got two merge conflicts on 06dc36ffb7cde821a4762b299d1c95b3788ba110, please rebase it to the latest commit. If the tests are too problematic that's fine, I can merge this patch with the other changes later this week. Vinicius From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 26 20:39:36 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 00:39:36 +0000 Received: from localhost ([127.0.0.1]:50111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIaV-0003Dg-Fu for submit@debbugs.gnu.org; Tue, 26 Sep 2023 20:39:35 -0400 Received: from mout01.posteo.de ([185.67.36.65]:38533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlIaR-0003DL-1N for 66199@debbugs.gnu.org; Tue, 26 Sep 2023 20:39:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A937A240028 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 02:39:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695775151; bh=7eMpA5DvE+xghDuEc32ERqK7+y+aHWktRiniBFY8EYE=; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Transfer-Encoding:From; b=Vwb7G9eYCiBxqDmw5x6eM/rWsBrjZOMc9lgQTibXecN+V40RbqNOCOOhR4uAr9HQf MBgKo5d7yX8B+XFDrpTCbpJc6jEoyz/6VeDL4gXiwqJOYSTEOO20i6P72njkT0jy+S +H3B69sGPqLOD30QEFTBG0xXvG8xw+iO2np+KnSo/GN6JfxfQosakLl51BUOsItg4D oALr47DNRCAVRFJs7LyXHYX+2cQQ0LpNNBYmWbFLiwAVxpk6Nn2rv73z+2YBitPPa3 ExOuWpNG+bqYOYzERlnyeZdMBHRL6c44OxxC2WcnvEH036TETFDgKSQIUo7xnE8NN1 GY4CtonBy8E3Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RwHmZ2Bq4z9s4Y; Wed, 27 Sep 2023 02:39:09 +0200 (CEST) Message-ID: Date: Wed, 27 Sep 2023 00:39:09 +0000 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/2] gnu: Add fontobene-qt5. Content-Language: en-US To: pinoaffe , 66199@debbugs.gnu.org References: <00f8b2031e0af268e413cefa7dea3eeba4775582.1695729169.git.pinoaffe@gmail.com> From: Vinicius Monego In-Reply-To: <00f8b2031e0af268e413cefa7dea3eeba4775582.1695729169.git.pinoaffe@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66199 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Em 26/09/2023 09:16, pinoaffe escreveu: > * gnu/packages/fontutils.scm (fontobene-qt5): New variable. > --- > gnu/packages/fontutils.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm > index 230fdd1dde..71a4f156b0 100644 > --- a/gnu/packages/fontutils.scm > +++ b/gnu/packages/fontutils.scm > @@ -18,6 +18,7 @@ > ;;; Copyright © 2023 gemmaro > ;;; Copyright © 2023 John Kehayias > ;;; Copyright © 2023 Janneke Nieuwenhuizen > +;;; Copyright © 2023 pinoaffe > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -65,6 +66,7 @@ (define-module (gnu packages fontutils) > #:use-module (gnu packages python) > #:use-module (gnu packages python-build) > #:use-module (gnu packages python-xyz) > + #:use-module (gnu packages qt) > #:use-module (gnu packages sqlite) > #:use-module (gnu packages webkit) > #:use-module (gnu packages xdisorg) > @@ -951,6 +953,34 @@ (define-public python-ufonormalizer > @end itemize") > (license license:bsd-3))) > > +(define-public fontobene-qt5 > + (package > + (name "fontobene-qt5") > + (version "0.2.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/fontobene/fontobene-qt5") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0gy3sfraf23k7dm4ha8nqpd6madzk0zmxkcb204micyn5b5l8ljg")))) > + (inputs (list qtbase-5)) > + (build-system cmake-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + (invoke "./tests/fontobene-qt5-tests"))))))) > + (home-page "https://github.com/fontobene/fontobene-qt5") > + (synopsis "Parser for FontoBene stroke fonts") > + (description "A header-only library to parse FontoBene stroke fonts with > +C++11/Qt5.") Descriptions should be full sentences (subject + predicate). The linter should be able to catch this. Otherwise LGTM. > + (license license:expat))) > + > (define-public ttfautohint > (package > (name "ttfautohint") > > base-commit: 445a0359083388b5ee686e6e855f94a3aac5f79c Vinicius From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 12:13:54 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 16:13:54 +0000 Received: from localhost ([127.0.0.1]:52306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXAf-0001H4-QA for submit@debbugs.gnu.org; Wed, 27 Sep 2023 12:13:54 -0400 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:45468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXAb-0001Gn-Nh for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 12:13:52 -0400 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5345a3dfe3bso5516102a12.3 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 09:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695831210; x=1696436010; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=Frp/MYv2HWdA7dwBbirsWqyWUBSuvXpsNzDm7TOXtN8=; b=k5Qwe9Ao8Fsm9viUWgkrRIpwAWh7MLfjiBepYjbhu22oxPGiUnp7oq+6L8jb0Gzs4K jkzFC2BpcKrkwTyDrN2m4KqqyDJWYGdQCg0vAIwKjs0R+xiDt7PNKhSQUxJy41/ovhfk VNjzzEig921wrLt/ai87UYe8hyXrWuhvAl6a8SuMxdKgFflzGYPCOqncZQoHvNzD43JO bUu9BbqyPPLjL59o+L+zKiAXQLtlsiDub3Mn27596JNDTGkcRHqiXEUi5bvLOK00ai7x 6WnEDKmVlLUPE+QiG34oETsKehLUiFF1rAP8hNFePBzuO2EVkZzritEA7gKnV8VgtGz9 ti+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695831210; x=1696436010; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Frp/MYv2HWdA7dwBbirsWqyWUBSuvXpsNzDm7TOXtN8=; b=I16ii4b6kN1slzE5lVAubdwiD+PmMUJ5gtIHoIXI9nw2mY0egR4yKO5lCy2GuybaMu KHdIexEcyKfG9MsOY7uJjRHRswJfVHz7i4eXcA5uKjwYbGETII28bVp7w3q9tTVX7yeG DP9F3zhgNFqODe8X37zNtDdnVvWUJCqG5p1Aw7D/qX8G5Jen5ROqusVXNWIN9JlIT0p8 JSMskUOw11lcf0rzb0F0BueljjVO6SHVLGJgJCsbN/GEqsQkBftA30DMzRIhhN9GRbVK zdGHjQjd4sKToeMzcnMzoYnhOy0P5k/3MpSeBwl9pxu7zoL+O7TTlGbXxMFb1Ul/YjFk JgiQ== X-Gm-Message-State: AOJu0YxZMI+Z256CUTWHwXvQ0P3w6uPOgBtb3eAiE0UITy0tHQLPQt+6 xnEh/H9VwSc/KDi2xytvsExbAdXbYXQ= X-Google-Smtp-Source: AGHT+IGJc9WE7nZvQGpxuSk5SXE0GfIYUzk+hO5y2m5fTIdRfkXKeHAUxAaxtz5Gk2Wwb2aAUViZYw== X-Received: by 2002:a17:906:53ca:b0:9b2:9e44:222e with SMTP id p10-20020a17090653ca00b009b29e44222emr2604991ejo.19.1695831209452; Wed, 27 Sep 2023 09:13:29 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id qw25-20020a1709066a1900b009b293d1f2eesm3652822ejc.107.2023.09.27.09.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 09:13:29 -0700 (PDT) References: <3e28337e7ead18b49e5e2e99d0e3d1d22e3f9d47.1695673614.git.pinoaffe@gmail.com> <2f4f0210-ea10-27e0-55fc-ccd55e807576@posteo.net> <87h6nhdtbh.fsf@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe To: Vinicius Monego Subject: Re: [bug#66199] [PATCH] gnu: librepcb: Update to 1.0.0. Date: Wed, 27 Sep 2023 18:06:36 +0200 In-reply-to: Message-ID: <87jzsbbnmf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: 66199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks again! Vinicius Monego writes: > Em 26/09/2023 09:08, pinoaffe escreveu: >> Vinicius Monego writes: >>> The commit message should also mention the switch to >>> cmake-build-system, the "not overriding" of the configure phase, the >>> new inputs and the test skip.. >> I wasn't sure how to phrase / format this, is what I arrived at OK? > You can check the logs of e.g. commit > 19617735df2b1af3b169d8153ae543ad3e0fc1a1 for reference. Ah yes, I'll try to replicate that > 'googletest' should be a native input, it's a test requirement only. oh yes, of course, thanks! > [Comment on the LibrePCB update patch specifically]: This v2 is much > better, thanks. While investigating the build I also found a few more > things that could be improved: > > - The bundles that were unvendored can be deleted in a source snippet > (see e.g. the mixxx package). Done > - LibrePCB builds a test executable at > tests/unittests/librepcb-unittests. Instead of 'make test', that > file could be run manually when overriding the check phase. Done > - The license list should be updated as some of the bundles listed > there are not being provided anymore, or even better let it be only > gpl3+ because that's the license of the final product. I removed all of the licenses and license comments that were no longer relevant, but there's still some non-GPL3+ code involved, so I figured I'd keep those licenses around. > - I got two merge conflicts on > 06dc36ffb7cde821a4762b299d1c95b3788ba110, please rebase it to the > latest commit. Done > If the tests are too problematic that's fine, I can merge this patch > with the other changes later this week. > > Vinicius Kind regards, pinoaffe From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 12:14:13 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 16:14:13 +0000 Received: from localhost ([127.0.0.1]:52310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXAz-0001IH-8H for submit@debbugs.gnu.org; Wed, 27 Sep 2023 12:14:13 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:54467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXAx-0001I4-Ug for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 12:14:12 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9936b3d0286so1470718766b.0 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 09:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695831232; x=1696436032; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=vD0kSTTRNQOpx14UJqUXzczHKfwiTReh8awl14M294s=; b=HVeGbwbNFOEfy6V/IUzWtaR3uEYs94J+eQ4TyPrrFb0qSAkhxlnHccuLTtGQBWRQh2 6a0DqwFYTwxMKc+mA5g4Bsu43uW6062Ale3pkfK9DGSCozDHCprwGntnzpMROWsAmcbI JCGUgKOIKMVAdC9zkwgwzw4SijO6AIdfzHe3QufT/IZ/1CyeAuNFYjsW+YiX3Rv6FW9P /5/4YFUGoNJCdqxi6cy6HZRZdLfT5KYyeSKTSNa3ojT1GFk7QB59P/rsVm9P7RmgIiEk 0yb1kFpSFxYSAfo+xfbP+EmSctjW563r44G+UVMwo4KlykoHJ+/lf4rOdzLaeeO2s06N 4Aww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695831232; x=1696436032; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vD0kSTTRNQOpx14UJqUXzczHKfwiTReh8awl14M294s=; b=nXexsdZjqW5wSn3FZho8TOk9XQT/HKYJpGXBIOESQL18XxC7S72WpzdlKRF3V54umK Vun9CV2SyHnma1uzHdEiCJxraYcfgqhbvlKeH3MtR4tpzgEYTmmBNKDSoetvXGAsrFwd 0UstR5bzcVbCduJESsdhB4ZyNzWnd+MfYELaa74Qv/4yvU2SNmB3A2IxTWO2XrL9pIyh Z4RKKJ5lNi0Mn34dqtd1ck2V5dUSIRG8hAXni8fsTkrsZuFzoVeVpBkOZsJlBeGHta25 WkwfzA/uUONbMZNE3jYq/kzC4cPrQsdoko90N8HmG2yyFoBvWorU5O3hewq2iY2NcUWu a5Yg== X-Gm-Message-State: AOJu0Ywk7jYMv4onJ+wwgHJh/ZCdB2zgF1h/2CFjJLu/m9cBusQ14hFc lFuyG4IGXdbE2A4tXrX8gnJhdXt6AHA= X-Google-Smtp-Source: AGHT+IESluqREsrlNK7c+EIVBAp4+mLnAzs7gyEm+HonKSdAI0htbDaFJJk/R1wcT9VLo0cXbiIGrg== X-Received: by 2002:a17:906:5357:b0:9b2:b9ad:ddd1 with SMTP id j23-20020a170906535700b009b2b9adddd1mr834432ejo.28.1695831232039; Wed, 27 Sep 2023 09:13:52 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id ha26-20020a170906a89a00b009930308425csm9541855ejb.31.2023.09.27.09.13.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 09:13:51 -0700 (PDT) References: <00f8b2031e0af268e413cefa7dea3eeba4775582.1695729169.git.pinoaffe@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe To: Vinicius Monego Subject: Re: [PATCH v2 1/2] gnu: Add fontobene-qt5. Date: Wed, 27 Sep 2023 18:11:02 +0200 In-reply-to: Message-ID: <87fs2zbnls.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: 66199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the review! Vinicius Monego writes: > Hi, > > Em 26/09/2023 09:16, pinoaffe escreveu: >> + (description "A header-only library to parse FontoBene stroke fonts with >> +C++11/Qt5.") > Descriptions should be full sentences (subject + predicate). The > linter should be able to catch this. Otherwise LGTM. For whatever reason it didn't catch this, but this should be fixed with v3 of the patch series Kind regards, pinoaffe From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 12:14:56 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 16:14:56 +0000 Received: from localhost ([127.0.0.1]:52314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXBf-0001Ja-NG for submit@debbugs.gnu.org; Wed, 27 Sep 2023 12:14:56 -0400 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:60444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXBd-0001JG-NL for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 12:14:54 -0400 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c124adf469so193959681fa.0 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 09:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695831274; x=1696436074; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R5zP5rAqZdKTdOhtIuTq9ra6t0xdRE1fJOixwG/x/rY=; b=OZNvp1meTppk5C/X8HYvvPt2tCycRq1wC0sZeb2quzOIE8JxiDr+vCgy8c/1LkZ6pl cB3/0ZNrl9X1Fs1mwV6BBTPYz1+oFARzSWXEXvzhgDUY9QUNwpRcPeo1nZiDpoisQ5Ps JjDin96DsoFIkgeITMSg9oiiZPcxSR2U/dgf/Tx679a7b1B0iH1kuK2aD0mzr75x8Ulj mgQCk2+4hOlGFWMPVFW2muE/N2FNYs45ytdyKS+0mxLFWXJ2iiI9y9BA2Ytd+nG3rvX9 PoaYd4C4z4/6FXK0dcALryocBetIT1k5OT8sIBNDmj4a08BsbejlVtaizI4EZPrjr7lE nexw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695831274; x=1696436074; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5zP5rAqZdKTdOhtIuTq9ra6t0xdRE1fJOixwG/x/rY=; b=dOQQHCI3Ot/nfPlVsye7+9QCJTC3SjTRHDptEUPSQk/WJR5dsDhmLaRpW7ob/riINx 2WnMMaLca0K2uMwceXsdXdKpuqH1XWzAeq0khFKkBuWh1O0OmR89V8QJcaJeFt5Vgn1D lj6HoKXhiyBlTtuXNGF+bwM1f4GyW/0z0wVktTdGHix5V6EqkD1H756c916XfjhmZQWi ppuGMRGLBXm9ZPSe+TZa19y312wc+91/MrqDqg+XlzA+v0rzndpB6JWUOXIq3bUTqSss wju2LgiL73ur5FALn5YOAXIX7sDeye939/TP76nX6A0TrtJEDe4MEM9eEwOIS/D4D1tQ do7Q== X-Gm-Message-State: AOJu0Yyfs2xbk8Et3FnTjh0SxmjUT9+HURyMUP4XDCL9Gxa/iX8JLA4o MafO1QnvS6jeR6HAqT4RgYSvNfqxg/Y= X-Google-Smtp-Source: AGHT+IFbnqfrKeFx/Np+csdjuIXKckLu/5Y/gndAL31p4ns85w3bcUhyP+7EKL1gj/jWms9YbSbOvQ== X-Received: by 2002:a2e:b179:0:b0:2bc:fd50:573a with SMTP id a25-20020a2eb179000000b002bcfd50573amr2405198ljm.6.1695831273837; Wed, 27 Sep 2023 09:14:33 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id j26-20020a170906831a00b0099275c59bc9sm9521630ejx.33.2023.09.27.09.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 09:14:33 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v3 1/2] gnu: Add fontobene-qt5. Date: Wed, 27 Sep 2023 18:14:25 +0200 Message-ID: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695830708.git.pinoaffe@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/fontutils.scm (fontobene-qt5): New variable. --- gnu/packages/fontutils.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm index 18697cd821..603f442e0a 100644 --- a/gnu/packages/fontutils.scm +++ b/gnu/packages/fontutils.scm @@ -18,6 +18,7 @@ ;;; Copyright © 2023 gemmaro ;;; Copyright © 2023 John Kehayias ;;; Copyright © 2023 Janneke Nieuwenhuizen +;;; Copyright © 2023 pinoaffe ;;; ;;; This file is part of GNU Guix. ;;; @@ -65,6 +66,7 @@ (define-module (gnu packages fontutils) #:use-module (gnu packages python) #:use-module (gnu packages python-build) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages qt) #:use-module (gnu packages sqlite) #:use-module (gnu packages webkit) #:use-module (gnu packages xdisorg) @@ -951,6 +953,34 @@ (define-public python-ufonormalizer @end itemize") (license license:bsd-3))) +(define-public fontobene-qt5 + (package + (name "fontobene-qt5") + (version "0.2.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/fontobene/fontobene-qt5") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0gy3sfraf23k7dm4ha8nqpd6madzk0zmxkcb204micyn5b5l8ljg")))) + (inputs (list qtbase-5)) + (build-system cmake-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "./tests/fontobene-qt5-tests"))))))) + (home-page "https://github.com/fontobene/fontobene-qt5") + (synopsis "Parser for FontoBene stroke fonts") + (description "FontoBene-Qt5 is a header-only library to parse FontoBene +stroke fonts with C++11/Qt5.") + (license license:expat))) + (define-public ttfautohint (package (name "ttfautohint") base-commit: ce0cc6137df81919389f61671096a6ce701c0889 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 12:15:02 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 16:15:02 +0000 Received: from localhost ([127.0.0.1]:52316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXBl-0001Js-A2 for submit@debbugs.gnu.org; Wed, 27 Sep 2023 12:15:02 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:56535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlXBf-0001JL-Ee for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 12:14:56 -0400 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-52bd9ddb741so13780933a12.0 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 09:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695831276; x=1696436076; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dDunM70bdR8O6icTLi3TW+01a6l3E/MBihOIPNX5Qmk=; b=LsdfeOu7L9bJ+qVh8SVs5sBAXXOt9p5vGgtRvB3e/9i+4HztGjhhSHfpnCoXiBh5vs e3drdDpSlvzRuW89u/2TK1bM/J+kqJZdZzNPUxUSZh59vssXQeNyvLo2yTvho4SkHd3R OPyNKGVQR810jGELVc0349q8ACwJin8cLDm1tWqeOI3UQw05+3nd7dbAMTkY/zuu1ISb F53BJ4KNjr/faKo0M/1GYqXGZZylGfTnHsHcNkORbMe3j7sD1FllWgnIfH38V292+LIX wJiytOO6xqUMbW6EZlCy6A4urTkxhg/VNQ/XFXnEApVW9EM5oPxytjG0V8qjRbLcs6AL ZQIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695831276; x=1696436076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dDunM70bdR8O6icTLi3TW+01a6l3E/MBihOIPNX5Qmk=; b=aSPmp2Fm/Fvr8uxOuaIw3reA9AUVFRrlMhaYiwRy+nZ3NerjYyn96cqUNP4OVR2lBz Ix0lowJCQGvYlxAnL4koT8TkwZAbnqTuIMfHi/6Eqm/LG0NCkdcYpW7miA5PQnzSZL7N yLx8GGdZMNFq8GCPLU9/gVC3GL5vfOavywU3zzFE9QtFb2nRtUaVcF7hrAL7t6yvM00G G8TEXf8Qp4xs9ZhtPmU44d3W7fb1rbCnAfacLtlmG1zdm1fNT9RMfKKB6ddkaCxcOHzf ejIINFMG73BvUxiutPgX3Gb/irbfZU/3xO8530pnZwYv8uRX1us1xikZlfmGn73FtusD b1mA== X-Gm-Message-State: AOJu0YwYs5p/KyqlIIYAy6RhE7IkPJNiFZ7D9BNCbqTuViC6Rtc9OlXL iVfR+ImMxF4uef4o33p3IlFATQWlfKk= X-Google-Smtp-Source: AGHT+IGZLndFaipU/2o2p/EZmnX52v+tuv0c0I4RkKmd/za0tW/tguS2dlF096BreLPfvLiJJCvKZA== X-Received: by 2002:a17:906:1db1:b0:9a6:2a0:6391 with SMTP id u17-20020a1709061db100b009a602a06391mr2214624ejh.14.1695831275957; Wed, 27 Sep 2023 09:14:35 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id y16-20020a1709064b1000b009adc7733f98sm9555592eju.97.2023.09.27.09.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 09:14:35 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v3 2/2] gnu: librepcb: Update to 1.0.0. Date: Wed, 27 Sep 2023 18:14:26 +0200 Message-ID: <63835d7494871259399f0ad3f8248978102c2944.1695830708.git.pinoaffe@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695830708.git.pinoaffe@gmail.com> References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695830708.git.pinoaffe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. [inputs]: Add various dependencies (both new ones and old ones that are now debundled). [arguments]: Remove overriding of configure phase. Replace test phase. Debundle various dependencies. [build-system]: Use cmake-build-system. [native-inputs]: Add googletest. --- gnu/packages/engineering.scm | 140 ++++++++++++++++++++++++++++------- 1 file changed, 114 insertions(+), 26 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index faba76161b..86e3407b4d 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -38,6 +38,7 @@ ;;; Copyright © 2022, 2023 Felix Gruber ;;; Copyright © 2023 Theofilos Pechlivanis ;;; Copyright © 2023 Sharlatan Hellseher +;;; Copyright © 2023 pinoaffe ;;; ;;; This file is part of GNU Guix. ;;; @@ -123,7 +124,9 @@ (define-module (gnu packages engineering) #:use-module (gnu packages lisp) #:use-module (gnu packages m4) #:use-module (gnu packages man) + #:use-module (gnu packages markup) #:use-module (gnu packages maths) + #:use-module (gnu packages multiprecision) #:use-module (gnu packages mpi) #:use-module (gnu packages multiprecision) #:use-module (gnu packages ncurses) @@ -2322,36 +2325,126 @@ (define-public freehdl (license (list license:gpl2+ license:lgpl2.0+)))) ; freehdl's libraries +;; (define-public dxflib +;; (package +;; (name "dxflib") +;; (version "3.26.4") +;; (source (origin +;; (method git-fetch) +;; (uri (git-reference +;; (url "https://github.com/LibrePCB/dxflib") +;; (commit "3b09713d9938b3d6e60a628124f460a1ce4efdd0"))) +;; (file-name (git-file-name name version)) +;; (sha256 +;; (base32 +;; "0nli8f58gq91zkv82gw05zprr2xbin1zl0l32ihw31jvyr41zr40")))) +;; (build-system cmake-build-system) +;; (arguments +;; `(#:tests? #f)) ;; No tests +;; (inputs (list qtbase-5)) +;; (native-inputs (list pkg-config)) +;; (home-page "https://www.ribbonsoft.com/en/what-is-dxflib") +;; (synopsis "Parser for DXF files") +;; (description "dxflib is an open source C++ library mainly for parsing DXFTM files. dxflib can also write DXF files, but you need to have good knowledge of the DXF format to produce valid output.") +;; (license license:gpl2+))) + +;; (define-public dxflib +;; (package +;; (name "dxflib") +;; (version "3.26.4") +;; (source (origin +;; (method url-fetch) +;; (uri (string-append "https://www.ribbonsoft.com/archives/dxflib/dxflib-" version "-src.tar.gz")) +;; (sha256 +;; (base32 +;; "0pwic33mj6bp4axai5jiyn4xqf31y0xmb1i0pcf55b2h9fav8zah")))) +;; (build-system gnu-build-system) +;; (inputs (list qtbase-5)) +;; (native-inputs (list pkg-config)) +;; (arguments +;; `(#:phases +;; (modify-phases %standard-phases +;; (add-before 'configure 'add-install-prefix +;; (lambda _ +;; (substitute* "dxflib.pro" +;; (("dxflib.rc") +;; "dxflib.rc +;; target.path = $${PREFIX}/bin +;; share.path = $${PREFIX} +;; INSTALLS += target share")))) +;; (replace 'configure +;; (lambda* (#:key outputs #:allow-other-keys) +;; (let ((out (assoc-ref outputs "out"))) +;; (invoke "qmake" +;; (string-append "PREFIX=" out)))))))) +;; (home-page "https://www.ribbonsoft.com/en/what-is-dxflib") +;; (synopsis "Parser for DXF files") +;; (description "dxflib is an open source C++ library mainly for parsing DXFTM files. dxflib can also write DXF files, but you need to have good knowledge of the DXF format to produce valid output.") +;; (license license:gpl2+))) + (define-public librepcb (package (name "librepcb") - (version "0.1.5") + (version "1.0.0") (source (origin (method url-fetch) (uri (string-append "https://download.librepcb.org/releases/" version "/librepcb-" version "-source.zip")) + (modules `((guix build utils))) + (snippet + ;; Delete libraries that we already have or don't need. + ;; TODO: try to unbundle more (see lib/). + `(begin + (let ((third-parties '("fontobene-qt5" + "googletest" + "hoedown" + "muparser" + "polyclipping" + "quazip"))) + (with-directory-excursion "libs" + (map (lambda (third-party) + (delete-file-recursively third-party)) + third-parties))) + #t)) (sha256 - (base32 "0smp1p7wnrj0vh4rmz1cr2krfawc2lzx0pbzmgyay7xdp6jxympr")))) - (build-system gnu-build-system) + (base32 "02qfwyhdq1pklb5gkwn3rbsdhwvcgiksd21swaphz3kw6s4p9i8v")))) + (build-system cmake-build-system) (inputs - (list qtbase-5 qtsvg-5 zlib)) + (list fontconfig + fontobene-qt5 + glu + hoedown + muparser + opencascade-occt + clipper + qtbase-5 + qtdeclarative-5 + qtquickcontrols2-5 + qtsvg-5 + quazip + zlib)) (native-inputs - (list qttools-5 ; for lrelease + (list googletest + pkg-config + qttools-5 unzip)) (arguments - `(#:phases - (modify-phases %standard-phases - (replace 'configure - (lambda* (#:key inputs outputs #:allow-other-keys) - (mkdir-p "build") - (chdir "build") - (let ((lrelease (search-input-file inputs "/bin/lrelease")) - (out (assoc-ref outputs "out"))) - (invoke "qmake" - (string-append "QMAKE_LRELEASE=" lrelease) - (string-append "PREFIX=" out) - "../librepcb.pro"))))))) + `(#:phases (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (setenv "QT_QPA_PLATFORM" "offscreen") + (setenv "QT_QUICK_BACKEND" "software") + (display "Running unittests...\n") + (invoke "./tests/unittests/librepcb-unittests" "--help"))))) + #:configure-flags (list + "-DUNBUNDLE_FONTOBENE_QT5=ON" + "-DUNBUNDLE_GTEST=ON" + "-DUNBUNDLE_HOEDOWN=ON" + "-DUNBUNDLE_MUPARSER=ON" + "-DUNBUNDLE_POLYCLIPPING=ON" + "-DUNBUNDLE_QUAZIP=ON"))) (home-page "https://librepcb.org/") (synopsis "Electronic Design Automation tool") (description "LibrePCB is @dfn{Electronic Design Automation} (EDA) @@ -2359,17 +2452,12 @@ (define-public librepcb formats and complete project management with library, schematic and board editors.") (license (list license:gpl3+ - license:boost1.0 ; libs/clipper, - ; libs/optional/tests/catch.hpp, - ; libs/sexpresso/tests/catch.hpp + license:boost1.0 ; libs/optional/tests/catch.hpp, license:expat ; libs/delaunay-triangulation, ; libs/parseagle, libs/type_safe - license:asl2.0 ; libs/fontobene, libs/googletest, - ; libs/parseagle - license:isc ; libs/hoedown - license:cc0 ; libs/optional, libs/sexpresso - license:bsd-2 ; libs/optional/tests/catch.hpp - license:lgpl2.1+)))) ; libs/quazip + license:asl2.0 ; libs/parseagle + license:cc0 ; libs/optional + license:bsd-2)))) ; libs/optional/tests/catch.hpp (define-public gpx (package -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 14:46:28 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 18:46:28 +0000 Received: from localhost ([127.0.0.1]:52513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlZYJ-0002K5-Sm for submit@debbugs.gnu.org; Wed, 27 Sep 2023 14:46:28 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:45058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlZYG-0002Jm-5x for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 14:46:26 -0400 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2c12ae20a5cso192935491fa.2 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 11:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695840364; x=1696445164; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=AcVQsXNiYNS8cZb5zXBS0bTPF/9cRCUAMcbEaVJCHwA=; b=N/+bzYS8e3Vw9/mshxAsQ+tVBTsoZFzCv1HMkPSOBT7fEM9Et+GohUP5Jz/1CMEfK+ T0NBJnSMPZZRu6fpKaa8OFLYnnHXQe2po9sxRfbuC7OcgUcy/YeJVfIBvhVsmvOc0e+V I4I9OK58A+WmLJZXp1tNx6n4wkVDP2dtYz+HQkxBgLCj8IrSL3brIHmELlknZhNIHxFb nA4ylRRN2h5doG5y61kqbm45bAhRhYDqpyvv8LTaGRpySrwnCJab396AX44S4zsKUQWO izzL0s7WkhNVdMfqAo+bso7DKDBqtJyQVkKS3QZcIMSH///iyHjwYD7UpUpRhlnOGsKG MBBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695840364; x=1696445164; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AcVQsXNiYNS8cZb5zXBS0bTPF/9cRCUAMcbEaVJCHwA=; b=rvYMJ7NpoHlgVlbkgizxBftg/mj0xwtWTEfe/aDONSLXw6aj9VSylEMVdP2WY7fZNm enKC5tscFSf2P6lGxwRR/hQRYHi+qSSbxNF1Bs+ne1fog2HA2Z3kYXSmee7II7uoS2se zmiPt9GbREU26Req0ZxkigMkG9utbBCpnVfjIZLIjt7rTA9BOqujlMTiprkMWFRKAzqH iIWkmallgm5zv7azIxvK1edWqvunk5/T35l73IU4oDTa7P/WesnoIcmx43JSKz+Qxb2j uBocyuZ3s97QCQAlNpbGi+5ZTU4K4qztvGwyoVw+K77fBRmtfLI17BmibLyN5uYCkvlk qXvg== X-Gm-Message-State: AOJu0YwegWdzmk1OR041zeUyRouq5sIJXbWCaLQf9MxjJbhBpM0UNw8j M5EZ0KV5NHnOuJYLti/mBUA= X-Google-Smtp-Source: AGHT+IHPqQdbpCS5WB6jFoOulEHnfL+TxNWGOxI36Asn4Ev39MnUJGA2cKAnOrBpxCDO23Dd7CGLFg== X-Received: by 2002:a2e:b78b:0:b0:2bf:f772:d647 with SMTP id n11-20020a2eb78b000000b002bff772d647mr2918178ljo.29.1695840363627; Wed, 27 Sep 2023 11:46:03 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id w23-20020a1709061f1700b0098921e1b064sm9687548ejj.181.2023.09.27.11.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 11:46:03 -0700 (PDT) References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695830708.git.pinoaffe@gmail.com> <63835d7494871259399f0ad3f8248978102c2944.1695830708.git.pinoaffe@gmail.com> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe To: pinoaffe Subject: Re: [PATCH v3 2/2] gnu: librepcb: Update to 1.0.0. Date: Wed, 27 Sep 2023 20:45:24 +0200 In-reply-to: <63835d7494871259399f0ad3f8248978102c2944.1695830708.git.pinoaffe@gmail.com> Message-ID: <87bkdnbgk5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: 66199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) whoops, I didn't mean to include my commented-out attempts at packaging dxflib in the patch - v4 incoming From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 14:46:40 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 18:46:40 +0000 Received: from localhost ([127.0.0.1]:52517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlZYW-0002KW-5N for submit@debbugs.gnu.org; Wed, 27 Sep 2023 14:46:40 -0400 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:49529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlZYS-0002KG-Vr for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 14:46:38 -0400 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-9b2b53e17feso233965066b.3 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 11:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695840377; x=1696445177; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R5zP5rAqZdKTdOhtIuTq9ra6t0xdRE1fJOixwG/x/rY=; b=R6vc1lMQoGGMNs1XTfm1HsQiNPgp3Sxz2yetbOMs5vu1TqdlDTp9ZHLuyzjOhrKQ03 GhvihYLPPEcGee8X6lqIjjAr5nHeokv8aAu9bIaPq6yJsglg+UF8uJWVU15bFm/e5w2O 1DAU3Q9llqD6p7mTlLSu0bx7m2yV5RCnvVFBG3m+tECu+W4mQ4Bw3X5eJ/UFQrI0VQWd X4OhI8pZ+tCbMPBqDpVgjBX4C1+aBnolNB4HrxrPBDWudOEFQVtk8K7qgSxj5xp9tYWI 7gcTxQaov6mr/WrByiQbwktXjFOiaQQbF728Z6+ZVsLV0J1ZVOjfDDiC7Y7sKVT/awHX nGrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695840377; x=1696445177; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5zP5rAqZdKTdOhtIuTq9ra6t0xdRE1fJOixwG/x/rY=; b=AdMKHDh2PgkPTClf4qfwRG1o4PcM1wcULAPKRaqb7e1Xm8YvSyC6EiKOepXx6CZfYZ BxvYb970/QeTfs9bPiy093VRDc87S+evBbpHsOkJOXgngmpSbo6RDpBUALRqKShlfHe/ iabgTxTx8xc5r3+lkk3gaISw6vOsykVAVuAmcPMmORfI6WDvfEpDjNiOS8qglXs6Ujgk sWLavLCyZwQ6i4ARk7qM/yxKPmssRaQ8x8036p9L9vbc1T8NExn0ax4JBhrdZ9Ob9343 QVT3yNv240Zj4gLmzU+OxtG9Vjv6QZpmfVorCmWjIlM5T/OQVp8sGc1eu4fwxEgYy+w3 ua0Q== X-Gm-Message-State: AOJu0YyzVoZfzaILdtxYg+OQFsuX5B0dkRPNkvm/wpiy+V1xGvTrJRke XmkjLlMLnT31DMBs34CH+XSr+DRjObA= X-Google-Smtp-Source: AGHT+IE0aV3qVerzj15oC/CS8s8Zi6XmT5a3/sAqzmgXYD54Cvt7PCO3DoYFtnzwBwHcKru2tT9dAw== X-Received: by 2002:a17:906:748c:b0:9a5:cade:8047 with SMTP id e12-20020a170906748c00b009a5cade8047mr2636961ejl.71.1695840377115; Wed, 27 Sep 2023 11:46:17 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id sa21-20020a170906edb500b009add084a00csm9623725ejb.36.2023.09.27.11.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 11:46:16 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v4 1/2] gnu: Add fontobene-qt5. Date: Wed, 27 Sep 2023 20:46:10 +0200 Message-ID: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695840289.git.pinoaffe@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/fontutils.scm (fontobene-qt5): New variable. --- gnu/packages/fontutils.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm index 18697cd821..603f442e0a 100644 --- a/gnu/packages/fontutils.scm +++ b/gnu/packages/fontutils.scm @@ -18,6 +18,7 @@ ;;; Copyright © 2023 gemmaro ;;; Copyright © 2023 John Kehayias ;;; Copyright © 2023 Janneke Nieuwenhuizen +;;; Copyright © 2023 pinoaffe ;;; ;;; This file is part of GNU Guix. ;;; @@ -65,6 +66,7 @@ (define-module (gnu packages fontutils) #:use-module (gnu packages python) #:use-module (gnu packages python-build) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages qt) #:use-module (gnu packages sqlite) #:use-module (gnu packages webkit) #:use-module (gnu packages xdisorg) @@ -951,6 +953,34 @@ (define-public python-ufonormalizer @end itemize") (license license:bsd-3))) +(define-public fontobene-qt5 + (package + (name "fontobene-qt5") + (version "0.2.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/fontobene/fontobene-qt5") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0gy3sfraf23k7dm4ha8nqpd6madzk0zmxkcb204micyn5b5l8ljg")))) + (inputs (list qtbase-5)) + (build-system cmake-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "./tests/fontobene-qt5-tests"))))))) + (home-page "https://github.com/fontobene/fontobene-qt5") + (synopsis "Parser for FontoBene stroke fonts") + (description "FontoBene-Qt5 is a header-only library to parse FontoBene +stroke fonts with C++11/Qt5.") + (license license:expat))) + (define-public ttfautohint (package (name "ttfautohint") base-commit: ce0cc6137df81919389f61671096a6ce701c0889 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 27 14:46:45 2023 Received: (at 66199) by debbugs.gnu.org; 27 Sep 2023 18:46:45 +0000 Received: from localhost ([127.0.0.1]:52519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlZYa-0002Km-NQ for submit@debbugs.gnu.org; Wed, 27 Sep 2023 14:46:45 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:55649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qlZYU-0002KI-UK for 66199@debbugs.gnu.org; Wed, 27 Sep 2023 14:46:40 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-99de884ad25so1510576366b.3 for <66199@debbugs.gnu.org>; Wed, 27 Sep 2023 11:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695840379; x=1696445179; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rok2ZkzEOZRggcukIw3l6e/QfatmNUVl26jNx1mb5uo=; b=PveEHCp7a3H2hXPMrZselZp3FaKrNliVEIG6uB58I+3IWHNFcxqEbi9fa/Uu8IJI76 zhmkHtU6/qLGQb5oSW1y00OqJSVq3TFAg1GZ6wkfcRe+H8AHPiyUDuecqSeDJtbw+Bsc jKGyHh99UUQhImZm2pAqP0taRYIjqQYNPPi9YkR+PwpWYyHd6dDbEOTzPpmSh+nxEwbs KII+L0c1AsPFc8SplzsSv1Xg2OW22Ky3+JG1r0x9wCOyhFQqpD/j/lr0WlanK0hTnKPc d+Chk4OsB7aMgiyhHI0wKQclsT/CQ5xJbBFJyyh0mwzJptZtw88+XQC49D/ziScThJ/u t6vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695840379; x=1696445179; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rok2ZkzEOZRggcukIw3l6e/QfatmNUVl26jNx1mb5uo=; b=hJyQqztl/6clM8BmqnYCAUBqX99ZrUHBZPfrpcEw97HvpYUhF7n5BPag3iytODZGuM EAgU7yDSfTJ7Gouj3XJmHL+XkLffGW5M1PoHN1p2j7p8twMGH33d1hWuT5Oer5t8Qv3Q MMz48w88INQZqRbayZ2iwj5SuaHUBRpU8Btbtt4WjsWPa/Z3/U7OTG7rUxfY+3jSrPs1 8EoZP91dQuDVXUG/JbT0YXh1GpAl90GbqXRnipuVGqcXIR34Mq4uSj1l9lsQ2SJNSzJh 5ZnEA2wil2agkBLqv3uqzvrJ4G/3VjoQYynpLNiVfMngmI/cnb4hTVUTHqCOKOj6VrdM jd+A== X-Gm-Message-State: AOJu0YzChYplJwmpxGhqYpD/lL5DeWrvvngjxtew4L0+SvpTIqpNdYP6 sLUxwK+XIdtcXq2adF+1xgaaVGjIIas= X-Google-Smtp-Source: AGHT+IFlyugd0YGdNrqyVL037PbjRq49+wzf92gtjDX7XIau5e1IO3G7wnwq7Fpl8EqJZ+Hlml9lbA== X-Received: by 2002:a17:907:7889:b0:9b2:b269:d563 with SMTP id ku9-20020a170907788900b009b2b269d563mr2528015ejc.63.1695840379382; Wed, 27 Sep 2023 11:46:19 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id qk8-20020a170906d9c800b009ad89697c86sm9776816ejb.144.2023.09.27.11.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 11:46:19 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0. Date: Wed, 27 Sep 2023 20:46:11 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695840289.git.pinoaffe@gmail.com> References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695840289.git.pinoaffe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. [inputs]: Add various dependencies (both new ones and old ones that are now debundled). [arguments]: Remove overriding of configure phase. Replace test phase. Debundle various dependencies. [build-system]: Use cmake-build-system. [native-inputs]: Add googletest. --- gnu/packages/engineering.scm | 83 +++++++++++++++++++++++++----------- 1 file changed, 57 insertions(+), 26 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index faba76161b..fca831f44b 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -38,6 +38,7 @@ ;;; Copyright © 2022, 2023 Felix Gruber ;;; Copyright © 2023 Theofilos Pechlivanis ;;; Copyright © 2023 Sharlatan Hellseher +;;; Copyright © 2023 pinoaffe ;;; ;;; This file is part of GNU Guix. ;;; @@ -123,7 +124,9 @@ (define-module (gnu packages engineering) #:use-module (gnu packages lisp) #:use-module (gnu packages m4) #:use-module (gnu packages man) + #:use-module (gnu packages markup) #:use-module (gnu packages maths) + #:use-module (gnu packages multiprecision) #:use-module (gnu packages mpi) #:use-module (gnu packages multiprecision) #:use-module (gnu packages ncurses) @@ -2325,33 +2328,66 @@ (define-public freehdl (define-public librepcb (package (name "librepcb") - (version "0.1.5") + (version "1.0.0") (source (origin (method url-fetch) (uri (string-append "https://download.librepcb.org/releases/" version "/librepcb-" version "-source.zip")) + (modules `((guix build utils))) + (snippet + ;; Delete libraries that we already have or don't need. + ;; TODO: try to unbundle more (see lib/). + `(begin + (let ((third-parties '("fontobene-qt5" + "googletest" + "hoedown" + "muparser" + "polyclipping" + "quazip"))) + (with-directory-excursion "libs" + (map (lambda (third-party) + (delete-file-recursively third-party)) + third-parties))) + #t)) (sha256 - (base32 "0smp1p7wnrj0vh4rmz1cr2krfawc2lzx0pbzmgyay7xdp6jxympr")))) - (build-system gnu-build-system) + (base32 "02qfwyhdq1pklb5gkwn3rbsdhwvcgiksd21swaphz3kw6s4p9i8v")))) + (build-system cmake-build-system) (inputs - (list qtbase-5 qtsvg-5 zlib)) + (list fontconfig + fontobene-qt5 + glu + hoedown + muparser + opencascade-occt + clipper + qtbase-5 + qtdeclarative-5 + qtquickcontrols2-5 + qtsvg-5 + quazip + zlib)) (native-inputs - (list qttools-5 ; for lrelease + (list googletest + pkg-config + qttools-5 unzip)) (arguments - `(#:phases - (modify-phases %standard-phases - (replace 'configure - (lambda* (#:key inputs outputs #:allow-other-keys) - (mkdir-p "build") - (chdir "build") - (let ((lrelease (search-input-file inputs "/bin/lrelease")) - (out (assoc-ref outputs "out"))) - (invoke "qmake" - (string-append "QMAKE_LRELEASE=" lrelease) - (string-append "PREFIX=" out) - "../librepcb.pro"))))))) + `(#:phases (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (setenv "QT_QPA_PLATFORM" "offscreen") + (setenv "QT_QUICK_BACKEND" "software") + (display "Running unittests...\n") + (invoke "./tests/unittests/librepcb-unittests" "--help"))))) + #:configure-flags (list + "-DUNBUNDLE_FONTOBENE_QT5=ON" + "-DUNBUNDLE_GTEST=ON" + "-DUNBUNDLE_HOEDOWN=ON" + "-DUNBUNDLE_MUPARSER=ON" + "-DUNBUNDLE_POLYCLIPPING=ON" + "-DUNBUNDLE_QUAZIP=ON"))) (home-page "https://librepcb.org/") (synopsis "Electronic Design Automation tool") (description "LibrePCB is @dfn{Electronic Design Automation} (EDA) @@ -2359,17 +2395,12 @@ (define-public librepcb formats and complete project management with library, schematic and board editors.") (license (list license:gpl3+ - license:boost1.0 ; libs/clipper, - ; libs/optional/tests/catch.hpp, - ; libs/sexpresso/tests/catch.hpp + license:boost1.0 ; libs/optional/tests/catch.hpp, license:expat ; libs/delaunay-triangulation, ; libs/parseagle, libs/type_safe - license:asl2.0 ; libs/fontobene, libs/googletest, - ; libs/parseagle - license:isc ; libs/hoedown - license:cc0 ; libs/optional, libs/sexpresso - license:bsd-2 ; libs/optional/tests/catch.hpp - license:lgpl2.1+)))) ; libs/quazip + license:asl2.0 ; libs/parseagle + license:cc0 ; libs/optional + license:bsd-2)))) ; libs/optional/tests/catch.hpp (define-public gpx (package -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 29 21:35:15 2023 Received: (at 66199) by debbugs.gnu.org; 30 Sep 2023 01:35:15 +0000 Received: from localhost ([127.0.0.1]:57464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmOt1-0000qg-7c for submit@debbugs.gnu.org; Fri, 29 Sep 2023 21:35:15 -0400 Received: from mout01.posteo.de ([185.67.36.65]:34393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmOsx-0000qP-UX for 66199@debbugs.gnu.org; Fri, 29 Sep 2023 21:35:13 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B86E9240027 for <66199@debbugs.gnu.org>; Sat, 30 Sep 2023 03:34:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1696037690; bh=1bNajzMIKZ7BMMpYZZCFzalrk4huK/B/vDmXS+szogo=; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Transfer-Encoding:From; b=NmcFqssaPeOrcHTDauw9kNt0fGXASnfuxTDHuegqM9ZLWL+WKzmYOCTV3OryJizn/ sjA+mRZwtiw+WpI6VZc2NXEn3/4+OX15uuuBdD4zkbUsoNb4wkE3Zjd6r2Uz143qWU wExnXDbbiT80vsMTvhJKBP/zD2uSduOlQcnIq2eoTViPcdRNfogrAk/U75dHjmMBJR Ki4hhhKmg2mPfSM27q8eMctC97bqccvwcwnSMfhncNAdPlP7Kmu7Kqmna1Z1S/iTX6 CO4/TSeIlvoeSZ6/aTktU95ko9GHqWEmXHpGEaxL+dzqL2cEy3mtMLeJCTnXeQq7S/ AjgHlBYzFE5LQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Ry8sP08Y3z9rxD; Sat, 30 Sep 2023 03:34:48 +0200 (CEST) Message-ID: <5d81aa7e-1f82-9089-2d10-1c266c2f6272@posteo.net> Date: Sat, 30 Sep 2023 01:34:48 +0000 MIME-Version: 1.0 Subject: Re: [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0. To: pinoaffe , 66199@debbugs.gnu.org References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695840289.git.pinoaffe@gmail.com> Content-Language: en-US From: Vinicius Monego In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66199 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Em 27/09/2023 15:46, pinoaffe escreveu: > * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. > [inputs]: Add various dependencies (both new ones and old ones that are now > debundled). If the change is not automated, then every input should be listed, separated by commas. > [arguments]: Remove overriding of configure phase. Replace test > phase. Debundle various dependencies. Avoid words like "various", list all items whenever possible. > [build-system]: Use cmake-build-system. > [native-inputs]: Add googletest. pkg-config was also added to native-inputs. And don't worry too much about the commit message, I can change it later. > --- > gnu/packages/engineering.scm | 83 +++++++++++++++++++++++++----------- > 1 file changed, 57 insertions(+), 26 deletions(-) > > diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm > index faba76161b..fca831f44b 100644 > --- a/gnu/packages/engineering.scm > +++ b/gnu/packages/engineering.scm > @@ -38,6 +38,7 @@ > ;;; Copyright © 2022, 2023 Felix Gruber > ;;; Copyright © 2023 Theofilos Pechlivanis > ;;; Copyright © 2023 Sharlatan Hellseher > +;;; Copyright © 2023 pinoaffe > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -123,7 +124,9 @@ (define-module (gnu packages engineering) > #:use-module (gnu packages lisp) > #:use-module (gnu packages m4) > #:use-module (gnu packages man) > + #:use-module (gnu packages markup) > #:use-module (gnu packages maths) > + #:use-module (gnu packages multiprecision) > #:use-module (gnu packages mpi) > #:use-module (gnu packages multiprecision) > #:use-module (gnu packages ncurses) > @@ -2325,33 +2328,66 @@ (define-public freehdl > (define-public librepcb > (package > (name "librepcb") > - (version "0.1.5") > + (version "1.0.0") > (source > (origin > (method url-fetch) > (uri (string-append "https://download.librepcb.org/releases/" > version "/librepcb-" version "-source.zip")) > + (modules `((guix build utils))) > + (snippet > + ;; Delete libraries that we already have or don't need. > + ;; TODO: try to unbundle more (see lib/). > + `(begin > + (let ((third-parties '("fontobene-qt5" > + "googletest" > + "hoedown" > + "muparser" > + "polyclipping" > + "quazip"))) > + (with-directory-excursion "libs" > + (map (lambda (third-party) > + (delete-file-recursively third-party)) > + third-parties))) > + #t)) > (sha256 > - (base32 "0smp1p7wnrj0vh4rmz1cr2krfawc2lzx0pbzmgyay7xdp6jxympr")))) > - (build-system gnu-build-system) > + (base32 "02qfwyhdq1pklb5gkwn3rbsdhwvcgiksd21swaphz3kw6s4p9i8v")))) > + (build-system cmake-build-system) > (inputs > - (list qtbase-5 qtsvg-5 zlib)) > + (list fontconfig > + fontobene-qt5 > + glu > + hoedown > + muparser > + opencascade-occt > + clipper Nitpick: 'clipper' is out of order > + qtbase-5 > + qtdeclarative-5 > + qtquickcontrols2-5 > + qtsvg-5 > + quazip > + zlib)) > (native-inputs > - (list qttools-5 ; for lrelease > + (list googletest > + pkg-config > + qttools-5 > unzip)) > (arguments > - `(#:phases > - (modify-phases %standard-phases > - (replace 'configure > - (lambda* (#:key inputs outputs #:allow-other-keys) > - (mkdir-p "build") > - (chdir "build") > - (let ((lrelease (search-input-file inputs "/bin/lrelease")) > - (out (assoc-ref outputs "out"))) > - (invoke "qmake" > - (string-append "QMAKE_LRELEASE=" lrelease) > - (string-append "PREFIX=" out) > - "../librepcb.pro"))))))) > + `(#:phases (modify-phases %standard-phases > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + (setenv "QT_QPA_PLATFORM" "offscreen") > + (setenv "QT_QUICK_BACKEND" "software") > + (display "Running unittests...\n") > + (invoke "./tests/unittests/librepcb-unittests" "--help"))))) > + Why --help? I ran librepcb-unittests with no arguments and found that ~20 tests failed out of ~2100. If it's not possible to skip them manually, you could skip all tests and leave a comment reporting what happened. I didn't check the output of --help. > #:configure-flags (list > + "-DUNBUNDLE_FONTOBENE_QT5=ON" > + "-DUNBUNDLE_GTEST=ON" > + "-DUNBUNDLE_HOEDOWN=ON" > + "-DUNBUNDLE_MUPARSER=ON" > + "-DUNBUNDLE_POLYCLIPPING=ON" > + "-DUNBUNDLE_QUAZIP=ON"))) #:configure-flags is usually placed above #:phases. > (home-page "https://librepcb.org/") > (synopsis "Electronic Design Automation tool") > (description "LibrePCB is @dfn{Electronic Design Automation} (EDA) > @@ -2359,17 +2395,12 @@ (define-public librepcb > formats and complete project management with library, schematic and board > editors.") > (license (list license:gpl3+ > - license:boost1.0 ; libs/clipper, > - ; libs/optional/tests/catch.hpp, > - ; libs/sexpresso/tests/catch.hpp > + license:boost1.0 ; libs/optional/tests/catch.hpp, > license:expat ; libs/delaunay-triangulation, > ; libs/parseagle, libs/type_safe > - license:asl2.0 ; libs/fontobene, libs/googletest, > - ; libs/parseagle > - license:isc ; libs/hoedown > - license:cc0 ; libs/optional, libs/sexpresso > - license:bsd-2 ; libs/optional/tests/catch.hpp > - license:lgpl2.1+)))) ; libs/quazip > + license:asl2.0 ; libs/parseagle > + license:cc0 ; libs/optional > + license:bsd-2)))) ; libs/optional/tests/catch.hpp > > (define-public gpx > (package I think this patch is ready after fixing the test suite. Vinicius From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 20:14:25 2023 Received: (at 66199) by debbugs.gnu.org; 4 Oct 2023 00:14:25 +0000 Received: from localhost ([127.0.0.1]:40948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpWz-0005Gy-A0 for submit@debbugs.gnu.org; Tue, 03 Oct 2023 20:14:25 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:58438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpWw-0005Gi-Dx for 66199@debbugs.gnu.org; Tue, 03 Oct 2023 20:14:23 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9b64b98656bso289821166b.0 for <66199@debbugs.gnu.org>; Tue, 03 Oct 2023 17:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696378437; x=1696983237; darn=debbugs.gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=OO5Z7bWZPX4dueYBxkbZFOYnwa+cnZTp9LoVQhOvlAk=; b=K3Mlw+LLlNWeDctnwy9Bo7i8WErpD86BosOERcLUUpk71UOsMa7q4/LQgGIfivOYw4 M0UI3QIxrJBgpEaXz5J5K53threPgV7pEvTU394Nlo0Vs9TbDtBDq+rQ/q8w4HIRJzY5 O4hecMmCqaPuoa8PjOHgTTWWOVTI9pYVcsXW7IIY14SWVa0XKIuRC40yANTvtUrrf6a0 paOqAWrcIyPOqGD5s7MaKiP6r78SwgFtVZYivW1T3DErsuECwmw4wslkiegxkIzbKwht aKywhkmGwBSnxCCx1f+EMFhosoeA+Aeqo0paBd6WT3XlMQjiOLHXApLF/oBKidNjbK/9 gUeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696378437; x=1696983237; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OO5Z7bWZPX4dueYBxkbZFOYnwa+cnZTp9LoVQhOvlAk=; b=IyFQ1qt3BM57etyLipbSNSj199IZWN7TiKtwU5KeBXxm3GJBXJiJ6vNnXpyKWjb3BG TCtAYGBOh8KJyITCqPjjcicsHazNrxbtS9qqJn/zdboqxta9FzU2SWFB8iusZPooVcz+ 9Uzg7szJMI8X8MK2iCRX7eXu7ZpR2Ox8JX9xAFMjOE2qs4BOpm5TL69/BYRCR7Ddop9Y 2CmswsJa4B2giqClcaOdXv3YAZZdNK71i8shVCgfUX9CtOGDQqn9izEYIlp1b+4Eg8gu L/7UPAyHzDvAGDtwCkIZFmUSO8TEwha3iLeYU/Z8QkTJUoidDNP3IiVn8jRvRQjEsPiX l59w== X-Gm-Message-State: AOJu0Yx5ozK07T3CwAlEiXVt2YnLHduEC25yZNlNlRQZpCQx05lsPBYy sNLjU0Qp2BPfWaKa0Dbiwx4= X-Google-Smtp-Source: AGHT+IENpkzWpsPYu/9fb7PPKpckSkusCelUkty8xdQk4/iOB7ak7AT76jhyAbgZk2lUqxJpMk8spQ== X-Received: by 2002:a17:906:1ba1:b0:9ae:5fdc:aee8 with SMTP id r1-20020a1709061ba100b009ae5fdcaee8mr667913ejg.53.1696378437000; Tue, 03 Oct 2023 17:13:57 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id w26-20020aa7da5a000000b0052a063e52b8sm1533970eds.83.2023.10.03.17.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 17:13:56 -0700 (PDT) References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695840289.git.pinoaffe@gmail.com> <5d81aa7e-1f82-9089-2d10-1c266c2f6272@posteo.net> User-agent: mu4e 1.10.5; emacs 28.2 From: pinoaffe To: Vinicius Monego Subject: Re: [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0. Date: Wed, 04 Oct 2023 01:39:44 +0200 In-reply-to: <5d81aa7e-1f82-9089-2d10-1c266c2f6272@posteo.net> Message-ID: <87y1gjz1ks.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: 66199@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks again! Vinicius Monego writes: >> * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. >> [inputs]: Add various dependencies (both new ones and old ones that are now >> debundled). > > If the change is not automated, then every input should be listed, > separated by commas. Done, I hope this is more or less what you meant >> [arguments]: Remove overriding of configure phase. Replace test >> phase. Debundle various dependencies. > > Avoid words like "various", list all items whenever possible. Okay >> [build-system]: Use cmake-build-system. >> [native-inputs]: Add googletest. > pkg-config was also added to native-inputs. I added it to the commit message > And don't worry too much about the commit message, I can change it > later. Aight >> + (list fontconfig >> + fontobene-qt5 >> + glu >> + hoedown >> + muparser >> + opencascade-occt >> + clipper > Nitpick: 'clipper' is out of order Whoops! >> + `(#:phases (modify-phases %standard-phases >> + (replace 'check >> + (lambda* (#:key tests? #:allow-other-keys) >> + (when tests? >> + (setenv "QT_QPA_PLATFORM" "offscreen") >> + (setenv "QT_QUICK_BACKEND" "software") >> + (display "Running unittests...\n") >> + (invoke "./tests/unittests/librepcb-unittests" "--help"))))) >> + > Why --help? Oops, that's a leftover artifact of me testing some stuff > I ran librepcb-unittests with no arguments and found that > ~20 tests failed out of ~2100. If it's not possible to skip them > manually, you could skip all tests and leave a comment reporting what > happened. I didn't check the output of --help. I manually skipped them, though I feel a bit "dirty" skipping 22 tests without properly knowing why they fail, especially since it's just a constant list of 22 strings in the middle of a package definition. > #:configure-flags is usually placed above #:phases. Okay, I moved it > I think this patch is ready after fixing the test suite. Great! Kind regards, pinoaffe From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 20:16:03 2023 Received: (at 66199) by debbugs.gnu.org; 4 Oct 2023 00:16:03 +0000 Received: from localhost ([127.0.0.1]:40953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpYY-0005KE-R5 for submit@debbugs.gnu.org; Tue, 03 Oct 2023 20:16:03 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:62694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpYT-0005JY-Hj for 66199@debbugs.gnu.org; Tue, 03 Oct 2023 20:16:01 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9ae7383b7ecso81183866b.0 for <66199@debbugs.gnu.org>; Tue, 03 Oct 2023 17:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696378534; x=1696983334; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R5zP5rAqZdKTdOhtIuTq9ra6t0xdRE1fJOixwG/x/rY=; b=fu4HQJqWWr/M5VI+UUDtF49uxO5SP5hOUw/jyQeWMia20DxNp+oUpgrfYyIujv8pqe XHQRTQWMvqrxB86Rewf1M4V+qEsMuZdbflefcLmXkm0cDcLNsJgv3r1xHU3KECtfwbGA mmCD53AaYVtJLrpJ2yGWA0CXjLRwd/A7Z0nozS6xqPdrDWcFz9k7snjViebeDp+u7BVB /T8Qm2DU1Ve4SvpmP6bXrX7EtD0+FcWze9OVTJlJcHfJgMfdjIRGfOoP7lVDV/7yjB3G fbXWanYe+cd8v5mxYTJ3zq66DCHSzdw0MQWt5iasIc2IvIVpsa+Z+b4KeYMZF9no8P+V 8UhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696378534; x=1696983334; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R5zP5rAqZdKTdOhtIuTq9ra6t0xdRE1fJOixwG/x/rY=; b=lGFns/D+twwfU8u7IxUF2lEz3rsGFHseKq4lDAyuNywIn8/TicxSz5dP2c/qE5kkdv 6WTSCXtqF8bEMhCjYW7N05+5CQaXVyGjgmfpkcY90mV3StIdXmjBnJ5Ar0uLGiy/aPjW UpbwRqlGazt7U0orEuG3Hr4bJTF3+Z5XC0iwiRoBoAZvjzVFDzpR06h/dMlvW//w/C6M vo6hp3poRrxtzbIdO9EAioH5KUz6i313XMUdQJAjEy2U61E4+A57uJaoRhtLSWhNL/zJ s1krGGNiQXkNNB0UCa+reYzCrFPMvR3JIC/3E6UWUclUMwQb4Xwipf61/aSoy6WXL+my GwDA== X-Gm-Message-State: AOJu0YxsmGFoKWH5kS28jIIQWSOPEtAgou0hHx5CIobBnAUavHBT4IdK Yvef3qbBer+4ZCaK5fVQKEfGcQE+ZbM= X-Google-Smtp-Source: AGHT+IHMx3f1/W95LryqGQFJOcbapdNMBWjHcZvTXA9gL7y2BmPtyKbgaaLFU2mINTJhyfTH0RdGCg== X-Received: by 2002:a17:907:7fa4:b0:9a9:405b:26d1 with SMTP id qk36-20020a1709077fa400b009a9405b26d1mr4141209ejc.5.1696378534004; Tue, 03 Oct 2023 17:15:34 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id sa18-20020a170906edb200b0098733a40bb7sm1805811ejb.155.2023.10.03.17.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 17:15:33 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v5 1/2] gnu: Add fontobene-qt5. Date: Wed, 4 Oct 2023 02:15:21 +0200 Message-ID: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1696378510.git.pinoaffe@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/fontutils.scm (fontobene-qt5): New variable. --- gnu/packages/fontutils.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm index 18697cd821..603f442e0a 100644 --- a/gnu/packages/fontutils.scm +++ b/gnu/packages/fontutils.scm @@ -18,6 +18,7 @@ ;;; Copyright © 2023 gemmaro ;;; Copyright © 2023 John Kehayias ;;; Copyright © 2023 Janneke Nieuwenhuizen +;;; Copyright © 2023 pinoaffe ;;; ;;; This file is part of GNU Guix. ;;; @@ -65,6 +66,7 @@ (define-module (gnu packages fontutils) #:use-module (gnu packages python) #:use-module (gnu packages python-build) #:use-module (gnu packages python-xyz) + #:use-module (gnu packages qt) #:use-module (gnu packages sqlite) #:use-module (gnu packages webkit) #:use-module (gnu packages xdisorg) @@ -951,6 +953,34 @@ (define-public python-ufonormalizer @end itemize") (license license:bsd-3))) +(define-public fontobene-qt5 + (package + (name "fontobene-qt5") + (version "0.2.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/fontobene/fontobene-qt5") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0gy3sfraf23k7dm4ha8nqpd6madzk0zmxkcb204micyn5b5l8ljg")))) + (inputs (list qtbase-5)) + (build-system cmake-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "./tests/fontobene-qt5-tests"))))))) + (home-page "https://github.com/fontobene/fontobene-qt5") + (synopsis "Parser for FontoBene stroke fonts") + (description "FontoBene-Qt5 is a header-only library to parse FontoBene +stroke fonts with C++11/Qt5.") + (license license:expat))) + (define-public ttfautohint (package (name "ttfautohint") base-commit: ce0cc6137df81919389f61671096a6ce701c0889 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 03 20:16:06 2023 Received: (at 66199) by debbugs.gnu.org; 4 Oct 2023 00:16:07 +0000 Received: from localhost ([127.0.0.1]:40955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpYc-0005KV-8A for submit@debbugs.gnu.org; Tue, 03 Oct 2023 20:16:06 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:50193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnpYV-0005Jb-Ty for 66199@debbugs.gnu.org; Tue, 03 Oct 2023 20:16:04 -0400 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9b1ebc80d0aso273769466b.0 for <66199@debbugs.gnu.org>; Tue, 03 Oct 2023 17:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696378536; x=1696983336; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=auYVuQZCpoCapAEIj1FXAGsMW2KzQSXw9jOECP+a98o=; b=BLY1dEWvxdK2tHFf9ZeV4nxjntIobyUOGLNJBhRtmIayHgd0Y6pFd2+NfSzy77S5+G /JRaDKCcxZ+jnANurEipkMiJ19Lmde2T8V/2sENeb5UEiTnMPuva5r3DT/LyCJxyv14Y IFCazICq/d7sxYa1V1gFaLpmuU77xqMwrU1bF7Hn8vNmNz/k/0K/ZkbJvrU+dF/KvdRA O61jQMiz9n3d/aEaipDZePgzh98a+ba9qguMQe2rOQFAH1QRUKPTgjVG/RJRxGQrj32b NZaZimpLwkMfAidhwsVZDeWki1ZlZlX8yaKiUlBhfHkLWv47C/g3204WoUcA6lY47vq7 +G0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696378536; x=1696983336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=auYVuQZCpoCapAEIj1FXAGsMW2KzQSXw9jOECP+a98o=; b=ScnZzO6q34nShlilFjfNfpbPyNrcSGPIpRaTbIAPoo8uJRolhD6dtWXWLvwRorze8w PTMYWdHqiKxCeJmrfYxjd64nyHYVFgoOSFPeB3bmQXMBzCcA3CMOrRBx+4JnmyulCfGo gPIqzMuPIwZK0kL/eFpDR+eSUNMn/5xnKPVTi+Xv9zyhWLyGJyyih35NNU/F0/82M4jz /dPsfb6SAa00v6oN9+NDUOaVVGMhBWzhHk3L9ROeC6kPNiNe0z/vNc1MIMkvZEiXk8ME tdKMuUWhni3PbxmBPGG9p6jjJZni2xo23XG/EK9TD9qrY6IS99dtU+QEQI7XFQNlJnbl WU6A== X-Gm-Message-State: AOJu0YwOEG38023vjzgzSSxvTiUPw6Ia4aJHksPtZPC+VpMRkVt9F380 fNPIQC0xWn+cKesVNXObFpddyCRnsyo= X-Google-Smtp-Source: AGHT+IHKbHijG9bSF9/lpwt9z4yPeAvENI9e54By8RbPlA6gqMfq3fFXsraJ7SCEej+1w84LcdK76g== X-Received: by 2002:a17:907:75e5:b0:9a5:852f:10ae with SMTP id jz5-20020a17090775e500b009a5852f10aemr581711ejc.60.1696378536570; Tue, 03 Oct 2023 17:15:36 -0700 (PDT) Received: from localhost (h120217.upc-h.chello.nl. [62.194.120.217]) by smtp.gmail.com with ESMTPSA id j20-20020a1709066dd400b009b285351817sm1787738ejt.116.2023.10.03.17.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 17:15:36 -0700 (PDT) From: pinoaffe To: 66199@debbugs.gnu.org Subject: [PATCH v5 2/2] gnu: librepcb: Update to 1.0.0. Date: Wed, 4 Oct 2023 02:15:22 +0200 Message-ID: <713d243e80ccbf8aa3d618d914c6f7896975e0e7.1696378510.git.pinoaffe@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1696378510.git.pinoaffe@gmail.com> References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1696378510.git.pinoaffe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 66199 Cc: pinoaffe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. [inputs]: Add the following dependencies: fontconfig, fontobene-qt5, glu, hoedown, muparser, opencascade-occt, clipper, qtdeclarative-5, qtquickcontrols2-5, and quazip. [arguments]: Remove overriding of configure phase. Replace test phase. Disable 22 failing tests. Debundle clipper aka polyclipping, fontobene-qt5, googletest, hoedown, muparser, and quazip. [build-system]: Use cmake-build-system. [native-inputs]: Add googletest (for the test suite) and pkg-config (so the build system can find the debundled dependencies). --- gnu/packages/engineering.scm | 119 +++++++++++++++++++++++++++-------- 1 file changed, 93 insertions(+), 26 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index faba76161b..f25d5b140d 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -38,6 +38,7 @@ ;;; Copyright © 2022, 2023 Felix Gruber ;;; Copyright © 2023 Theofilos Pechlivanis ;;; Copyright © 2023 Sharlatan Hellseher +;;; Copyright © 2023 pinoaffe ;;; ;;; This file is part of GNU Guix. ;;; @@ -123,7 +124,9 @@ (define-module (gnu packages engineering) #:use-module (gnu packages lisp) #:use-module (gnu packages m4) #:use-module (gnu packages man) + #:use-module (gnu packages markup) #:use-module (gnu packages maths) + #:use-module (gnu packages multiprecision) #:use-module (gnu packages mpi) #:use-module (gnu packages multiprecision) #:use-module (gnu packages ncurses) @@ -2325,33 +2328,102 @@ (define-public freehdl (define-public librepcb (package (name "librepcb") - (version "0.1.5") + (version "1.0.0") (source (origin (method url-fetch) (uri (string-append "https://download.librepcb.org/releases/" version "/librepcb-" version "-source.zip")) + (modules `((guix build utils))) + (snippet + ;; Delete libraries that we already have or don't need. + ;; TODO: try to unbundle more (see lib/). + `(begin + (let ((third-parties '("fontobene-qt5" + "googletest" + "hoedown" + "muparser" + "polyclipping" + "quazip"))) + (with-directory-excursion "libs" + (map (lambda (third-party) + (delete-file-recursively third-party)) + third-parties))) + #t)) (sha256 - (base32 "0smp1p7wnrj0vh4rmz1cr2krfawc2lzx0pbzmgyay7xdp6jxympr")))) - (build-system gnu-build-system) + (base32 "02qfwyhdq1pklb5gkwn3rbsdhwvcgiksd21swaphz3kw6s4p9i8v")))) + (build-system cmake-build-system) (inputs - (list qtbase-5 qtsvg-5 zlib)) + (list clipper + fontconfig + fontobene-qt5 + glu + hoedown + muparser + opencascade-occt + qtbase-5 + qtdeclarative-5 + qtquickcontrols2-5 + qtsvg-5 + quazip + zlib)) (native-inputs - (list qttools-5 ; for lrelease + (list googletest + pkg-config + qttools-5 unzip)) (arguments - `(#:phases - (modify-phases %standard-phases - (replace 'configure - (lambda* (#:key inputs outputs #:allow-other-keys) - (mkdir-p "build") - (chdir "build") - (let ((lrelease (search-input-file inputs "/bin/lrelease")) - (out (assoc-ref outputs "out"))) - (invoke "qmake" - (string-append "QMAKE_LRELEASE=" lrelease) - (string-append "PREFIX=" out) - "../librepcb.pro"))))))) + `(#:configure-flags (list + "-DUNBUNDLE_FONTOBENE_QT5=ON" + "-DUNBUNDLE_GTEST=ON" + "-DUNBUNDLE_HOEDOWN=ON" + "-DUNBUNDLE_MUPARSER=ON" + "-DUNBUNDLE_POLYCLIPPING=ON" + "-DUNBUNDLE_QUAZIP=ON") + #:phases (modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (let ((test-include (list "*")) + (test-exclude + (list + ;; These tests all fail when run by the build + ;; process even though they pass when manually + ;; run as a normal user. + + ;; TODO: verify that the failing tests don't + ;; point to any actual underlying issues + "SystemInfoTest.testGetUsername" + "OrderPcbDialogTest.testAutoOpenBrowser" + "DxfImportDialogTest.testLayerName" + "DxfImportDialogTest.testCirclesAsDrills" + "DxfImportDialogTest.testJoinTangentPolylines" + "DxfImportDialogTest.testLineWidth" + "DxfImportDialogTest.testScaleFactor" + "DxfImportDialogTest.testPlacementPosition" + "GraphicsExportDialogTest.testPageSize" + "GraphicsExportDialogTest.testOrientation" + "GraphicsExportDialogTest.testMargins" + "GraphicsExportDialogTest.testShowPinNumbers" + "GraphicsExportDialogTest.testRotate" + "GraphicsExportDialogTest.testMirror" + "GraphicsExportDialogTest.testScale" + "GraphicsExportDialogTest.testPixmapDpi" + "GraphicsExportDialogTest.testBlackWhite" + "GraphicsExportDialogTest.testBackgroundColor" + "GraphicsExportDialogTest.testMinLineWidth" + "GraphicsExportDialogTest.testLayerColors" + "GraphicsExportDialogTest.testOpenExportedFiles" + "AddComponentDialogTest.testAddMore"))) + (setenv "QT_QPA_PLATFORM" "offscreen") + (setenv "QT_QUICK_BACKEND" "software") + (display "Running unittests...\n") + (invoke "./tests/unittests/librepcb-unittests" + (string-append + "--gtest_filter=" + (string-join test-include ":") + "-" + (string-join test-exclude ":")))))))))) (home-page "https://librepcb.org/") (synopsis "Electronic Design Automation tool") (description "LibrePCB is @dfn{Electronic Design Automation} (EDA) @@ -2359,17 +2431,12 @@ (define-public librepcb formats and complete project management with library, schematic and board editors.") (license (list license:gpl3+ - license:boost1.0 ; libs/clipper, - ; libs/optional/tests/catch.hpp, - ; libs/sexpresso/tests/catch.hpp + license:boost1.0 ; libs/optional/tests/catch.hpp, license:expat ; libs/delaunay-triangulation, ; libs/parseagle, libs/type_safe - license:asl2.0 ; libs/fontobene, libs/googletest, - ; libs/parseagle - license:isc ; libs/hoedown - license:cc0 ; libs/optional, libs/sexpresso - license:bsd-2 ; libs/optional/tests/catch.hpp - license:lgpl2.1+)))) ; libs/quazip + license:asl2.0 ; libs/parseagle + license:cc0 ; libs/optional + license:bsd-2)))) ; libs/optional/tests/catch.hpp (define-public gpx (package -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 06 21:17:13 2023 Received: (at 66199-done) by debbugs.gnu.org; 7 Oct 2023 01:17:13 +0000 Received: from localhost ([127.0.0.1]:53074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qovwP-0001It-6t for submit@debbugs.gnu.org; Fri, 06 Oct 2023 21:17:13 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qovwN-0001If-8n for 66199-done@debbugs.gnu.org; Fri, 06 Oct 2023 21:17:12 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 00F7A240101 for <66199-done@debbugs.gnu.org>; Sat, 7 Oct 2023 03:16:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1696641406; bh=a8N/Nh+//DELshVkmuhW9aGbzYLfSOzzTtQE8l5wFQs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:From; b=YxiacM9dHFnY1Tish/c3ijloFQoxDrUiD0ava8kr3yEQctT7ubJ0dvv4dtdtrVlp2 /MC5glAChlPZsBoM9aVY66yJ2Kfu92NPq1RE8uOE20D9Vv1e2f8/E9W0og9yjKUOex ojOSXhw5FprfdDPPb3JGVd3Q6hATcIZf75U9sQ1WbPyJBA55JgssykQfzz+qbfnH05 JI4pzpLo87CCK1uBYO9wYqWW9aWv0olcjjWU4hX4CSGRhV1Dp3u/wFGq1o5Hip5wqB tUR13mWPzDlDMkjAJdYFy6kTatN+fqUfQ0lOmR8zH6e7L3SIvkpgZ2zM4sUtsGO/yn wIcq69ao4hAoA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4S2S7J1jWhz9rxY; Sat, 7 Oct 2023 03:16:43 +0200 (CEST) Content-Type: multipart/alternative; boundary="------------7og3kawDuL7l620Fz6cJvJT3" Message-ID: Date: Sat, 7 Oct 2023 01:16:45 +0000 MIME-Version: 1.0 Subject: Re: [bug#66199] [PATCH v4 2/2] gnu: librepcb: Update to 1.0.0. Content-Language: en-US To: pinoaffe References: <01b109c3d00cb4ab5d81d48d22b6bc4cfe0b943a.1695840289.git.pinoaffe@gmail.com> <5d81aa7e-1f82-9089-2d10-1c266c2f6272@posteo.net> <87y1gjz1ks.fsf@gmail.com> From: Vinicius Monego In-Reply-To: <87y1gjz1ks.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 66199-done Cc: 66199-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------7og3kawDuL7l620Fz6cJvJT3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Em 03/10/2023 20:39, pinoaffe escreveu: > Thanks again! > > Vinicius Monego writes: >>> * gnu/packages/engineering.scm (librepcb): Update to 1.0.0. >>> [inputs]: Add various dependencies (both new ones and old ones that are now >>> debundled). >> If the change is not automated, then every input should be listed, >> separated by commas. > Done, I hope this is more or less what you meant > >>> [arguments]: Remove overriding of configure phase. Replace test >>> phase. Debundle various dependencies. >> Avoid words like "various", list all items whenever possible. > Okay > >>> [build-system]: Use cmake-build-system. >>> [native-inputs]: Add googletest. >> pkg-config was also added to native-inputs. > I added it to the commit message > >> And don't worry too much about the commit message, I can change it >> later. > Aight > >>> + (list fontconfig >>> + fontobene-qt5 >>> + glu >>> + hoedown >>> + muparser >>> + opencascade-occt >>> + clipper >> Nitpick: 'clipper' is out of order > Whoops! > >>> + `(#:phases (modify-phases %standard-phases >>> + (replace 'check >>> + (lambda* (#:key tests? #:allow-other-keys) >>> + (when tests? >>> + (setenv "QT_QPA_PLATFORM" "offscreen") >>> + (setenv "QT_QUICK_BACKEND" "software") >>> + (display "Running unittests...\n") >>> + (invoke "./tests/unittests/librepcb-unittests" "--help"))))) >>> + >> Why --help? > Oops, that's a leftover artifact of me testing some stuff > >> I ran librepcb-unittests with no arguments and found that >> ~20 tests failed out of ~2100. If it's not possible to skip them >> manually, you could skip all tests and leave a comment reporting what >> happened. I didn't check the output of --help. > I manually skipped them, though I feel a bit "dirty" skipping 22 tests > without properly knowing why they fail, especially since it's just a > constant list of 22 strings in the middle of a package definition. > >> #:configure-flags is usually placed above #:phases. > Okay, I moved it > >> I think this patch is ready after fixing the test suite. > Great! > > Kind regards, > pinoaffe Great job! I pushed the patches after rewriting the commit message for librepcb and doing some minor tweaks. It's OK to skip some tests, and even better to add a comment stating that they pass after the package is built. Thanks, Vinicius --------------7og3kawDuL7l620Fz6cJvJT3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hello,

Em 03/10/2023 20:39, pinoaffe escreveu:
Thanks again!

Vinicius Monego <monego@posteo.net> writes:

* gnu/packages/engineering.scm (librepcb): Update to 1.0.0.
[inputs]: Add various dependencies (both new ones and old ones that are now
         debundled).

If the change is not automated, then every input should be listed,
separated by commas.

Done, I hope this is more or less what you meant


[arguments]: Remove overriding of configure phase. Replace test
         phase. Debundle various dependencies.

Avoid words like "various", list all items whenever possible.

Okay


[build-system]: Use cmake-build-system.
[native-inputs]: Add googletest.

pkg-config was also added to native-inputs.

I added it to the commit message


And don't worry too much about the commit message, I can change it
later.

Aight


+     (list fontconfig
+           fontobene-qt5
+           glu
+           hoedown
+           muparser
+           opencascade-occt
+           clipper

Nitpick: 'clipper' is out of order

Whoops!


+     `(#:phases (modify-phases %standard-phases
+                  (replace 'check
+                    (lambda* (#:key tests? #:allow-other-keys)
+                      (when tests?
+                        (setenv "QT_QPA_PLATFORM" "offscreen")
+                        (setenv "QT_QUICK_BACKEND" "software")
+                        (display "Running unittests...\n")
+                        (invoke "./tests/unittests/librepcb-unittests" "--help")))))
+


      

        
Why --help?


      

      
Oops, that's a leftover artifact of me testing some stuff



      

        
I ran librepcb-unittests with no arguments and found that
~20 tests failed out of ~2100. If it's not possible to skip them
manually, you could skip all tests and leave a comment reporting what
happened. I didn't check the output of --help.


      

      
I manually skipped them, though I feel a bit "dirty" skipping 22 tests
without properly knowing why they fail, especially since it's just a
constant list of 22 strings in the middle of a package definition.



      

        
#:configure-flags is usually placed above #:phases.


      

      
Okay, I moved it



      

        
I think this patch is ready after fixing the test suite.


      

      
Great!

Kind regards,
pinoaffe

    

    
Great job! I pushed the patches after rewriting the commit
      message for librepcb and doing some minor tweaks.

    
It's OK to skip some tests, and even better to add a comment stating that they pass after the package is built.

    
Thanks,

    
Vinicius


  


--------------7og3kawDuL7l620Fz6cJvJT3--




From unknown Sat Jun 14 03:52:10 2025
Received: (at fakecontrol) by fakecontrolmessage;
To: internal_control@debbugs.gnu.org
From: Debbugs Internal Request 
Subject: Internal Control
Message-Id: bug archived.
Date: Sat, 04 Nov 2023 11:24:05 +0000
User-Agent: Fakemail v42.6.9

# This is a fake control message.
#
# The action:
# bug archived.
thanks
# This fakemail brought to you by your local debbugs
# administrator