Subject: [bug#66199] [PATCH v2 1/2] gnu: Add fontobene-qt5.

From: Vinicius Monego <[email-masked]>
Date: Wed, 27 Sep 2023 00:39:09 +0000

Hi,

Em 26/09/2023 09:16, pinoaffe escreveu:
> * gnu/packages/fontutils.scm (fontobene-qt5): New variable.
> ---
>   gnu/packages/fontutils.scm | 30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 230fdd1dde..71a4f156b0 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -18,6 +18,7 @@
>   ;;; Copyright © 2023 gemmaro <[email-masked]>
>   ;;; Copyright © 2023 John Kehayias <[email-masked]>
>   ;;; Copyright © 2023 Janneke Nieuwenhuizen <[email-masked]>
> +;;; Copyright © 2023 pinoaffe <[email-masked]>
>   ;;;
>   ;;; This file is part of GNU Guix.
>   ;;;
> @@ -65,6 +66,7 @@ (define-module (gnu packages fontutils)
>     #:use-module (gnu packages python)
>     #:use-module (gnu packages python-build)
>     #:use-module (gnu packages python-xyz)
> +  #:use-module (gnu packages qt)
>     #:use-module (gnu packages sqlite)
>     #:use-module (gnu packages webkit)
>     #:use-module (gnu packages xdisorg)
> @@ -951,6 +953,34 @@ (define-public python-ufonormalizer
>   @end itemize")
>       (license license:bsd-3)))
>   
> +(define-public fontobene-qt5
> +  (package
> +    (name "fontobene-qt5")
> +    (version "0.2.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/fontobene/fontobene-qt5")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0gy3sfraf23k7dm4ha8nqpd6madzk0zmxkcb204micyn5b5l8ljg"))))
> +    (inputs (list qtbase-5))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               (invoke "./tests/fontobene-qt5-tests")))))))
> +    (home-page "https://github.com/fontobene/fontobene-qt5")
> +    (synopsis "Parser for FontoBene stroke fonts")
> +    (description "A header-only library to parse FontoBene stroke fonts with
> +C++11/Qt5.")

Descriptions should be full sentences (subject + predicate). The linter 
should be able to catch this. Otherwise LGTM.

> +    (license license:expat)))
> +
>   (define-public ttfautohint
>     (package
>       (name "ttfautohint")
>
> base-commit: 445a0359083388b5ee686e6e855f94a3aac5f79c

Vinicius